[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #37 from Katrin Fischer --- RMaints, please also take into account the depending bug 25946 - I think we might want to fix this first! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #36 from Aleisha Amohia --- Hi all, this does not apply cleanly on 19.11.x, please rebase if you want me to backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.02 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #35 from Lucas Gass --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Owen Leonard changed: What|Removed |Added Blocks||25946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 [Bug 25946] borrowerRelationship can no longer be empty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Nick Clemens changed: What|Removed |Added Blocks|25750 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #34 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Nick Clemens changed: What|Removed |Added Blocks||25750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Alex Arnaud changed: What|Removed |Added Attachment #106170|0 |1 is obsolete|| --- Comment #33 from Alex Arnaud --- Created attachment 106318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106318=edit Bug 25322: fix for not selected "relationship" defaults to father When a user creates a patron's guarantor on /cgi-bin/koha/members/memberentry.pl but doesn't select the relationship from a dropdown, the relationship defaults to first value, which in default sysprefs is "father". This may or may not be correct as this is not a conscious choice from the user. The solution is to make the "Relationship" field mandatory when there is no empty entry in the system preferences, always starting with an empty option but not allowing the user to save an empty entry. And if there is an empty option in sysprefs, it allows to save empty, as well as makes it default choice. To reproduce with default system preferences: 1) Create a new patron who is assumed to have a guarantor or modify the existing one. 2) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 3) Observe that relationship is set as "father". 4) Apply the patch. 5) Repeat steps 1 and 2. 6) Observe that it doesn't allow you to save the form until you pick a relationship type. To reproduce with empty entry added to system preferences: 1) Add an empty entry to borrowerRelationship at /cgi-bin/koha/admin/preferences.pl?tab=patrons in Patron relationships section (example: "|father|mother"). 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 4) Observe that relationship is set as "father". 5) Apply the patch. 6) Repeat steps 1, 2 and 3. 7) Observe when you save the empty entry it does set the relationship as empty. Signed-off-by: Katrin Fischer Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Katrin Fischer changed: What|Removed |Added Attachment #105972|0 |1 is obsolete|| --- Comment #32 from Katrin Fischer --- Created attachment 106170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106170=edit Bug 25322: fix for not selected "relationship" defaults to father When a user creates a patron's guarantor on /cgi-bin/koha/members/memberentry.pl but doesn't select the relationship from a dropdown, the relationship defaults to first value, which in default sysprefs is "father". This may or may not be correct as this is not a conscious choice from the user. The solution is to make the "Relationship" field mandatory when there is no empty entry in the system preferences, always starting with an empty option but not allowing the user to save an empty entry. And if there is an empty option in sysprefs, it allows to save empty, as well as makes it default choice. To reproduce with default system preferences: 1) Create a new patron who is assumed to have a guarantor or modify the existing one. 2) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 3) Observe that relationship is set as "father". 4) Apply the patch. 5) Repeat steps 1 and 2. 6) Observe that it doesn't allow you to save the form until you pick a relationship type. To reproduce with empty entry added to system preferences: 1) Add an empty entry to borrowerRelationship at /cgi-bin/koha/admin/preferences.pl?tab=patrons in Patron relationships section (example: "|father|mother"). 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 4) Observe that relationship is set as "father". 5) Apply the patch. 6) Repeat steps 1, 2 and 3. 7) Observe when you save the empty entry it does set the relationship as empty. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Summary|Adding a guarantor with no |Adding a guarantor with no |relationship defaults to|relationship defaults to |father |first available ||relationship name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/