Re: [PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host on unknown PVR
On 18.12.2012, at 08:53, Andreas Färber wrote: > Previously we silently exited, with subclasses we got an opcode warning. > Instead explicitly tell the user what's wrong. > > An indication for this is -cpu ? showing "host" with an all-zero PVR. > > Signed-off-by: Andreas Färber > --- > target-ppc/kvm.c |7 +++ > 1 Datei geändert, 7 Zeilen hinzugefügt(+) > > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index f115892..8998d0f 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -1186,7 +1186,14 @@ static void alter_insns(uint64_t *word, uint64_t > flags, bool on) > > static void kvmppc_host_cpu_initfn(Object *obj) > { > +PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(obj); > + > assert(kvm_enabled()); > + > +if (pcc->info->pvr != mfpvr()) { > +fprintf(stderr, "Host PVR unsupported.\n"); This should probably rather say "Host CPU unsupported for -cpu host" or so :). Not everyone who invokes qemu-system-ppc knows what a PVR is. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host on unknown PVR
Previously we silently exited, with subclasses we got an opcode warning. Instead explicitly tell the user what's wrong. An indication for this is -cpu ? showing "host" with an all-zero PVR. Signed-off-by: Andreas Färber --- target-ppc/kvm.c |7 +++ 1 Datei geändert, 7 Zeilen hinzugefügt(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index f115892..8998d0f 100644 --- a/target-ppc/kvm.c +++ b/target-ppc/kvm.c @@ -1186,7 +1186,14 @@ static void alter_insns(uint64_t *word, uint64_t flags, bool on) static void kvmppc_host_cpu_initfn(Object *obj) { +PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(obj); + assert(kvm_enabled()); + +if (pcc->info->pvr != mfpvr()) { +fprintf(stderr, "Host PVR unsupported.\n"); +exit(1); +} } static void kvmppc_host_cpu_class_init(ObjectClass *oc, void *data) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html