Re: [kvm-devel] [PATCH 3/6] virtio net driver
On Fri, Sep 21, 2007 at 02:36:43PM +0200, Christian Borntraeger wrote: > > @@ -335,7 +344,7 @@ static void *virtnet_probe(struct device > dev->poll = virtnet_poll; > dev->hard_start_xmit = start_xmit; > dev->weight = 16; > - dev->features = NETIF_F_HIGHDMA; > + dev->features = NETIF_F_HIGHDMA | NETIF_F_LLTX; > SET_NETDEV_DEV(dev, device); > > /* Do we support "hardware" checksums? */ Please don't use LLTX in new drivers. We're trying to get rid of it since it's 1) unnecessary; 2) causes problems with AF_PACKET seeing things twice. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH RFC 1/3] virtio infrastructure
On Mon, Jun 04, 2007 at 02:25:32PM +0300, Avi Kivity wrote: > > OT: Does that hold for bonded interfaces too? Yes. By default traffic to the same destination MAC always stick to one interface. You could select a layer3+4 hashing policy but even that guarantees a single flow will stick to one physical interface unless it contains IP fragments which should never happen for TCP. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [Xen-devel] Re: [PATCH RFC 1/3] virtio infrastructure
On Mon, Jun 04, 2007 at 12:55:25PM +0300, Avi Kivity wrote: > > Networking hardware generally services descriptors in a FIFO manner. > virtio may not (for example, it may offload copies of larger packets to > a dma engine such as I/OAT, resulting in a delay, but copy smaller > packets immediately). that means that there will be some mismatch > between virtio drivers and real hardware drivers. You're free to do that in the process but before your packets leave the backend you've got to make sure that they haven't been reordered. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH 4/5] KVM: Fix asm constraints with CONFIG_FRAME_POINTER=n
Avi Kivity <[EMAIL PROTECTED]> wrote: > A "g" constraint may place a local variable in an %rsp-relative memory > operand. > but if your assembly changes %rsp, the operand points to the wrong location. > > An "r" constraint fixes that. > > Thanks to Ingo Molnar for neatly bisecting the problem. > > Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> > > Index: linux-2.6/drivers/kvm/vmx.c > === > --- linux-2.6.orig/drivers/kvm/vmx.c > +++ linux-2.6/drivers/kvm/vmx.c > @@ -1825,7 +1825,7 @@ again: > #endif >"setbe %0 \n\t" >"popf \n\t" > - : "=g" (fail) > + : "=r" (fail) > : "r"(vcpu->launched), "d"((unsigned long)HOST_RSP), >"c"(vcpu), >[rax]"i"(offsetof(struct kvm_vcpu, regs[VCPU_REGS_RAX])), We need the following fix for 2.6.20. [KVM] vmx: Fix register constraint in launch code Both "=r" and "=g" breaks my build on i386: $ make CC [M] drivers/kvm/vmx.o {standard input}: Assembler messages: {standard input}:3318: Error: bad register name `%sil' make[1]: *** [drivers/kvm/vmx.o] Error 1 make: *** [_module_drivers/kvm] Error 2 The reason is that setbe requires an 8-bit register but "=r" does not constrain the target register to be one that has an 8-bit version on i386. According to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10153 the correct constraint is "=q". Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index ce219e3..0aa2659 100644 --- a/drivers/kvm/vmx.c +++ b/drivers/kvm/vmx.c @@ -1824,7 +1824,7 @@ again: #endif "setbe %0 \n\t" "popf \n\t" - : "=g" (fail) + : "=q" (fail) : "r"(vcpu->launched), "d"((unsigned long)HOST_RSP), "c"(vcpu), [rax]"i"(offsetof(struct kvm_vcpu, regs[VCPU_REGS_RAX])), - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel