Re: [PATCH v6 14/23] irqchip/gic-v4.1: Add VSGI allocation/teardown

2020-03-24 Thread Marc Zyngier
On Tue, 24 Mar 2020 10:43:09 +0800
Zenghui Yu  wrote:

> Hi Marc,
> 
> On 2020/3/21 2:23, Marc Zyngier wrote:
> > Allocate per-VPE SGIs when initializing the GIC-specific part of the
> > VPE data structure.
> > 
> > Signed-off-by: Marc Zyngier 
> > Reviewed-by: Zenghui Yu 
> > Link: https://lore.kernel.org/r/20200304203330.4967-15-...@kernel.org
> > ---
> >   drivers/irqchip/irq-gic-v3-its.c   |  2 +-
> >   drivers/irqchip/irq-gic-v4.c   | 68 +-
> >   include/linux/irqchip/arm-gic-v4.h |  4 +-
> >   3 files changed, 71 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/irqchip/irq-gic-v3-its.c 
> > b/drivers/irqchip/irq-gic-v3-its.c
> > index 15250faa9ef7..7ad46ff5f0b9 100644
> > --- a/drivers/irqchip/irq-gic-v3-its.c
> > +++ b/drivers/irqchip/irq-gic-v3-its.c
> > @@ -4053,7 +4053,7 @@ static int its_sgi_set_vcpu_affinity(struct irq_data 
> > *d, void *vcpu_info)
> > struct its_cmd_info *info = vcpu_info;  
> >   > switch (info->cmd_type) {  
> > -   case PROP_UPDATE_SGI:
> > +   case PROP_UPDATE_VSGI:
> > vpe->sgi_config[d->hwirq].priority = info->priority;
> > vpe->sgi_config[d->hwirq].group = info->group;
> > its_configure_sgi(d, false);  
> 
> [...]
> 
> > @@ -103,7 +105,7 @@ enum its_vcpu_info_cmd_type {
> > SCHEDULE_VPE,
> > DESCHEDULE_VPE,
> > INVALL_VPE,
> > -   PROP_UPDATE_SGI,
> > +   PROP_UPDATE_VSGI,
> >   };  
> >   >   struct its_cmd_info {  
> 
> As Eric pointed out, this belongs to patch #12.

Dammit. This is the *3rd* time I fsck the rebase. Someone *please* hit
me on the head. Hard.

Now *really* fixed:

https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=kvm-arm64/gic-v4.1=05d32df13c6b3c0850b68928048536e9a736d520

Thanks,

M.
-- 
Jazz is not dead. It just smells funny...
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm


Re: [PATCH v6 14/23] irqchip/gic-v4.1: Add VSGI allocation/teardown

2020-03-23 Thread Zenghui Yu

Hi Marc,

On 2020/3/21 2:23, Marc Zyngier wrote:

Allocate per-VPE SGIs when initializing the GIC-specific part of the
VPE data structure.

Signed-off-by: Marc Zyngier 
Reviewed-by: Zenghui Yu 
Link: https://lore.kernel.org/r/20200304203330.4967-15-...@kernel.org
---
  drivers/irqchip/irq-gic-v3-its.c   |  2 +-
  drivers/irqchip/irq-gic-v4.c   | 68 +-
  include/linux/irqchip/arm-gic-v4.h |  4 +-
  3 files changed, 71 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 15250faa9ef7..7ad46ff5f0b9 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -4053,7 +4053,7 @@ static int its_sgi_set_vcpu_affinity(struct irq_data *d, 
void *vcpu_info)
struct its_cmd_info *info = vcpu_info;
  
  	switch (info->cmd_type) {

-   case PROP_UPDATE_SGI:
+   case PROP_UPDATE_VSGI:
vpe->sgi_config[d->hwirq].priority = info->priority;
vpe->sgi_config[d->hwirq].group = info->group;
its_configure_sgi(d, false);


[...]


@@ -103,7 +105,7 @@ enum its_vcpu_info_cmd_type {
SCHEDULE_VPE,
DESCHEDULE_VPE,
INVALL_VPE,
-   PROP_UPDATE_SGI,
+   PROP_UPDATE_VSGI,
  };
  
  struct its_cmd_info {


As Eric pointed out, this belongs to patch #12.


Thanks,
Zenghui

___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm