[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #158 from NX 2011-06-26 22:42:34 PDT --- (In reply to comment #156) > Meanwhile try use bigger width of line, at least 1.0, this bug my not appear > then. Works fine. Thanks for that "workaround". :) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [ANN] LibreOffice 3.4.1 RC3 available
Le 27/06/2011 01:09, Thorsten Behrens a écrit : > Hi *, > > for 3.4.1 rc3, we're now uploading builds to a public (but > non-mirrored - so don't spread news too widely!) place, as soon as > they're available. Grab them here: > > http://dev-builds.libreoffice.org/pre-releases/ > > If you've a bit of time, please give them a try & report *critical* > bugs not yet in bugzilla here, so we can incorporate them into the > release notes. Please note that it takes approximately 24 hours to > populate the mirrors, so that's about the time we have to collect > feedback. > > The list of fixed bugs in this release is here: > > http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-4-1-release-3.4.1.3.log > > So playing with the areas touched there also greatly appreciated - and > validation that those bugs are really fixed. Quickly tested on Ubuntu x86_64 and XP : no problem from my side. Quickstart problem and blocker found in rc2 are solved. > > Thanks a lot for your help, Thanks to you :-) JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] patch for fdo#38561: can't save pw protected file without pw
Hello, this patch fixes the problem that we are unable to save a password protected file without a password. The problem is that we don't clear the old encryption data and copy them from the old ItemSet. We merge two ItemSets there, and the information about encryption should always come from the ItemSet filled during the file dialog. I think we should include this patch in the 3-4 branch. I think this patch only applies to 3-4 but not to master, so if this patch is accepted I'll write a second one for master and push it. Regards, Markus From 7d9388266ef08e1ebd393c2ecc81a8116ad90f69 Mon Sep 17 00:00:00 2001 From: Markus Mohrhard Date: Mon, 27 Jun 2011 01:44:42 +0200 Subject: [PATCH] fix for fdo#38561: unable to save protected file without pw --- sfx2/source/doc/objstor.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx index f0db081..3b29f52 100644 --- a/sfx2/source/doc/objstor.cxx +++ b/sfx2/source/doc/objstor.cxx @@ -2811,7 +2811,7 @@ sal_Bool SfxObjectShell::PreDoSaveAs_Impl // in "SaveAs" title and password will be cleared ( maybe the new itemset contains new values, otherwise they will be empty ) pMergedParams->ClearItem( SID_PASSWORD ); pMergedParams->ClearItem( SID_DOCINFO_TITLE ); - +pMergedParams->ClearItem( SID_ENCRYPTIONDATA ); pMergedParams->ClearItem( SID_INPUTSTREAM ); pMergedParams->ClearItem( SID_STREAM ); pMergedParams->ClearItem( SID_CONTENT ); -- 1.7.3.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANN] LibreOffice 3.4.1 RC3 available
Hi *, for 3.4.1 rc3, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try & report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs in this release is here: http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-4-1-release-3.4.1.3.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, -- Thorsten pgp5SMTlqoUiT.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSoC][performance] report - week #5
Hi all,
not much happened this week.
I've add some more prefixes and created list of libraries we use in
all components (writer, calc, draw, impress, base).
Caolán suggested we don't have to have all
component_getImplementationEnvironment functions doing the same.
So, I'm sending small patch and maybe then we could just remove them ?
(if they don't do something special)
And next week on Wednesday I will have final exams at school, so I
have to learn something in next two days.
Kind regards,
Matus
diff --git a/cppuhelper/source/shlib.cxx b/cppuhelper/source/shlib.cxx
index 1fb136a..495ba47 100644
--- a/cppuhelper/source/shlib.cxx
+++ b/cppuhelper/source/shlib.cxx
@@ -270,7 +270,7 @@ static OUString makeComponentPath(
}
//==
-static OUString getLibEnv(OUString const & aModulePath,
+static OUString getLibEnv(OUString,
oslModulelib,
uno::Environment * pEnv,
OUString * pSourceEnv_name,
@@ -278,8 +278,6 @@ static OUString getLibEnv(OUString const & aModulePath,
OUString const & cImplName = OUString(),
OUString const & rPrefix = OUString())
{
-OUString aExcMsg;
-
sal_Char const * pEnvTypeName = NULL;
OUString aGetEnvNameExt = rPrefix + OUSTR(COMPONENT_GETENVEXT);
@@ -299,14 +297,8 @@ static OUString getLibEnv(OUString const & aModulePath,
lib, aGetEnvName.pData );
if (pGetImplEnv)
pGetImplEnv(&pEnvTypeName, (uno_Environment **)pEnv);
-
else
-{
-aExcMsg = aModulePath;
-aExcMsg += OUSTR(": cannot get symbol: ");
-aExcMsg += aGetEnvName;
-aExcMsg += OUSTR("- nor: ");
-}
+pEnvTypeName = CPPU_CURRENT_LANGUAGE_BINDING_NAME;
}
if (!pEnv->is() && pEnvTypeName)
@@ -331,7 +323,7 @@ static OUString getLibEnv(OUString const & aModulePath,
}
-return aExcMsg;
+return OUString();
}
extern "C" {static void s_getFactory(va_list * pParam)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] can no longer encrypt files if build with --disable-mozilla
I don't know what the intention for LibreOffice is, but I can say that there are likely changes being made in anticipation of ODF 1.2 approval. There has been extensive tightening to the Encryption specification in the Package description for ODF 1.2. That specification is now separated into Part 3 of the ODF 1.2 Committee Specification 01 which is now under Public Review as a Candidate OASIS Standard. Consulting that document might provide some insight into changes that have occurred in the OO.o code base. I'll take responsibility for what I hope is a more rigorous specification of package encryption in ODF 1.2, but I have no idea how this is tied to changes in the ODF 1.2-anticipating *Office.org implementations. - Dennis DETAILS AND SPECULATIONS: manifest:checksum-type="sha256-1k" is now recommended for the hash that is used to verify that the decryption appears to be correct, although consumers are expected to support both "sha1-1k" and "sha256-1k". (Part 3 section 4.8.3) manifest:start-key-generation-name="http://www.w3.org/2000/09/xmldsig#sha256"; is now recommended for the initial hash of the password that is then used for encryption-key derivation. Consumers are required to support that value and the two other values, "SHA1" and "http://www.w3.org/2000/09/xmldsg#sha1";. (Part 3 section 4.8.6) These are the only places where SHA256 has been explicitly introduced in conjunction with package encryption. The PBKDF2 key-derivation is still based on HMAC-SHA-1 although there is now provision for alternative key-derivation algorithms. I assume the change for manifest:start-key-generation-name is simply to provide a better hash and make it a bit harder to attack the password. Some believe that the detection of SHA1 collisions makes these cases of SHA1 usage compromised. That does not appear to be very relevant since the start-key is not recorded anywhere, in contrast with the protection-key hash values which an ODF document can be littered with. The change for manifest:checksum-type does not appear cryptographically significant since it doesn't change anything with regard to how the manifest:checksum might be exploited as information leakage in aid of known-plaintext discovery/attack. -Original Message- From: libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org [mailto:libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org] On Behalf Of Markus Mohrhard Sent: Sunday, June 26, 2011 11:27 To: libreoffice-dev Subject: [Libreoffice] can no longer encrypt files if build with --disable-mozilla Hello, is it in our intention that we can no longer encrypt files if we build with --disable-mozilla? It seems that this was introduced through our latest merge from OOo. It seems that we need SHA-1 and SHA256 since the latest merge. SHA-1 still works but for SHA-256 we rely on NSS which is disabled if we build with --disable-mozilla. Does anyone know why they added SHA-256? Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] external LinLibertineG not available
Hi, Many thanks for your kind words in the name of Linux Libertine/Biolinum and Graphite developers, too. There are some quite exciting developments from these area. Eg. improved and extended font family of Linux Libertine: new bold variant (the old one is renamed to semi-bold); Linux Libertine Display, a size variant for greater point sizes, see http://www.linuxlibertine.org/uploads/media/2011-05-PR-V5.0.0_02.pdf, also the upcoming Graphite 2 integration for better performance. I will convert the new Linux Libertine and Biolinum fonts to Graphite now with combining diacritics (a basic need of several languages and scientific/linguistic usage), and with some extra functions, too. There are also a lot of other tasks to improve LibreOffice DTP, and we have a big loss, Keith Stribley (see http://ultimategerardm.blogspot.com/2011/02/in-memoriam-keith-stribley.html). I hope, we will be able to continue his work to develop a professional layout engine for LibreOffice with excellent (and default) typographical facilities. Best regards, László 2011/6/25 aqualung : > Apologies for posting to the developers' list but I just wanted to express a > big thank you to the creator(s) of the wonderful Linux Libertine G and Linux > Biolinum G! > > These fonts, with their many ligatures and other special characters and > combinations, bring some of the delight back that the typesetters of old > must have experienced when choosing from their palette of lead types. > > I am puzzled that this achievement has not been recognized with a major > typography award yet, or perhaps they are just too modest to post it on > their website. > > -- > View this message in context: > http://nabble.documentfoundation.org/external-LinLibertineG-not-available-tp3104795p3107029.html > Sent from the Dev mailing list archive at Nabble.com. > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Potential Problems for LibreOffice on Mac with impending release of Lion OSX
Hi Alexander, *, On Sun, Jun 26, 2011 at 1:29 PM, Alexander Thurgood wrote: > Le 24/06/11 06:59, Alexander Thurgood a écrit : > > I've managed to find this, an indication of things that will be > different with Lion OSX : > http://www.appleinsider.com/articles/11/02/24/sources_detail_new_features_in_apples_first_beta_of_mac_os_x_10_7_lion.html > > Interesting bit about changes to NSApplication and NSWindow classes (not > much detail unfortunately), possibly might have an effect on Impress and > full screen display of presentations ? Don't think so, those are new (and as I understand) optional features, no need to worry about that. The interesting part (to me) is this: "Mac OS X File Coordination File coordination allows an application to access files and directories in a way that is serialized with other processes' accesses of the same files and directories. This prevents inconsistencies due to overlapping reads and writes." This might be the reason why users cannot save documents in Lion. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] can no longer encrypt files if build with --disable-mozilla
Hello, is it in our intention that we can no longer encrypt files if we build with --disable-mozilla? It seems that this was introduced through our latest merge from OOo. It seems that we need SHA-1 and SHA256 since the latest merge. SHA-1 still works but for SHA-256 we rely on NSS which is disabled if we build with --disable-mozilla. Does anyone know why they added SHA-256? Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar
Hello Noel,
On Fri, Jun 24, 2011 at 7:53 PM, Noel Power wrote:
> Hi Anurag
> On 22/06/11 15:51, Anurag Jain wrote:
>>
>> Hi Noel,
>>
>> Resending the patch again along with the source files here.
>
> as mentioned on Wed on iRC I pushed the patch to the feature branch. I had
> hoped to see the latest changes you made to correct the control size problem
> that I identified that was preventing your new control from being displayed
> before reviewing the patch further, I am not *that* familiar with
> libreoffice ui bits and pieces and was hoping to have something to run to
> test. Additionally on IRC it wasn't clear how you now were calcuating the
> the ScInputBarGroup width, I'd like to have seen the code for that
>
I'm sending the fix patch here which calculates the height and width
of the ScInputbarGroup and makes the border invisible.
> Anyway some comments on what is there so far, I think the ScInputBarGroup is
> taking shape, clearly it's very rough at this stage ( understandable since
> you had problems getting it to show ). One thing I would suggest here to
> a) change the name of ScTextWindow to something like ScMultiLineTxtWin ( or
> any other suitable name )
> b) restore the orig ScTextWindow class
>
There is no class named as ScTextWindow and never was. It has always
been ScTextWnd-->ScInputWindow and now it has become like
ScTextWnd-->ScInputBarGroup-->ScInputWidow
> I suggest this because it is intended when the gsoc code is initially
> integrated that it be configurable and for this reason it probably makes
> sense to preserve the original ScTextWindow class and distinguish it from
> your new implementation. This will make maintenance easier.
So I guess there should not be any problem with the maintenance of
code as I've not renamed any pre existing class and just inserted a
new class i.e ScInputBarGroup.
> Then next thing to concentrate on is getting the multi-line textbox
> functionality to work and to make that behaviour switchable. I believe Kohei
> suggested adding a button to the ScInputBarGroup window. So, you need to be
> able to detect the button click and switch the state of the bIsMultiLine
> flag that you have already added ( presumably for this purpose ) please do a
> grep for PushButton & SetClickHdl in sc for sample code for handling the
> button.
Next hurdle which I'm trying to get through is getting the Scrollbar
and Button at the right position after the Textbar ends. Does the
function SetPosSizePixel() or SetPosPixel() in window.hxx can be used
for getting them at the desired position. Or is there any other more
modular way to decide the ordering of these items similar to
InsertWindow() and InsetItem() methods used in ScInputWindow ?
> When you get a button click you will need to resize your InputBarGroupbox
> window based on the new state of the bIsMultiLine flag and of course
> increase the height in multiples of the calculated height of a single line.
> e.g. in Multiline mode the ScInputGroupBox height should be some multiple of
> the calculated singleline height ( maybe 10 as a default ? ) Of course the
> size of the ScMultiLineTxtWin (let's call it that for now but please rename
> it as you wish ) window needs to also be adjusted and everything resized. I
> would do this first before worrying about scrollbar behaviour.
>
yes as soon as I get things placed in right place I'll be working on
switching from single line to multiline mode on the button click.
> regards
> Noel
>
>
>
Thanks and regards
--
Anurag Jain
Final yr B.Tech CSE
SASTRA University
Thanjavur(T.N.)-613402
diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index c3d0ffc..dc12376 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -140,7 +140,7 @@ ScInputWindow::ScInputWindow( Window* pParent, SfxBindings* pBind ) :
ToolBox ( pParent, WinBits(WB_BORDER|WB_3DLOOK|WB_CLIPCHILDREN) ),
aWndPos ( this ),
// maScrollBar ( this, WB_VERT | WB_DRAG ),
-aBarGroup ( this ),
+aBarGroup ( this),
pInputHdl ( NULL ),
pBindings ( pBind ),
aTextOk ( ScResId( SCSTR_QHELP_BTNOK ) ), // not always new from Resource
@@ -179,14 +179,6 @@ ScInputWindow::ScInputWindow( Window* pParent, SfxBindings* pBind ) :
//aTextWindow.SetQuickHelpText( ScResId( SCSTR_QHELP_INPUTWND ) );
//aTextWindow.SetHelpId ( HID_INSWIN_INPUT );
-/*
-maScrollBar.SetPageSize( 1 );
-maScrollBar.SetVisibleSize( 1 );
-maScrollBar.SetLineSize( 1 );
-maScrollBar.SetRange( Range( 0, 1 ) );
-maScrollBar.SetThumbPos( 10 );
-*/
-
// kein SetHelpText, die Hilfetexte kommen aus der Hilfe
SetItemText ( SID_INPUT_FUNCTION, ScResId( SCSTR_QHELP_BTNCALC ) );
@@ -496,6 +488,15 @@ void ScInputWindow::Resize()
{
ToolBox::Resize();
+long nWidth = GetSizePixel().Width();
+long nLeft = aBarGroup.GetPosPixel().X();
+Size aSize = aBarGroup.
Re: [Libreoffice] A good Sunday to you all
/me doesn't find the 'Like' button in your post ;) so +1 :) Kind regards Sophie On 26/06/2011 18:33, drew wrote: http://conference.libreoffice.org/submit-your-paper/ . .:::. .:::. V^V^V^V^V^V (| ^ ^ |) | (_) | `//=\\' ))) )))(( (( ))(( (() )) ( jgs It does not matter how slowly you go so long as you do not stop. - Confucius October 12-15, one new submittal since last my nuisance post and 'nuff said, Best wishes, //drew ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Founding member of The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] A good Sunday to you all
http://conference.libreoffice.org/submit-your-paper/ . .:::. .:::. V^V^V^V^V^V (| ^ ^ |) | (_) | `//=\\' ))) )))(( (( ))(( (() )) ( jgs It does not matter how slowly you go so long as you do not stop. - Confucius October 12-15, one new submittal since last my nuisance post and 'nuff said, Best wishes, //drew ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] What is "important bug fixes" for bugfix release?
Hello all, I wonder what are the criteria specifying whether a bug should be fixed in which stable branch, if it affects all? Such as, in my understanding, fdo#33149 is fixed in master after branching -3-3 but before -3-4, so -3-4 has it but -3-3 not. I've found in wiki [1] that 3.x.y has "only important bug fixes ...", but the point is: what is "important"? I think the bug report will report earliest version [2] (which seems impossible, because I think there is a few people that have old versions), the patch should go into that earliest branch, then merge into more update branch ... [1] http://wiki.documentfoundation.org/ReleasePlan/3.3 [2] http://wiki.documentfoundation.org/BugReport_Details#Version Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] l10n process for help content (WAS: [PATCH] Update help fdo#31652)
Hello all, On Fri, Jun 24, 2011 at 19:47, Caolán McNamara wrote: > On Thu, 2011-06-23 at 18:46 +0200, Andras Timar wrote: >> Sorry, this breaks the string freeze in 3-3, 3-4 and 3-4-1. Translators >> expect that strings don't change in stable brances. I would say, it is >> easier for everyone, if we change strings in master only. > > Seems nuts to me that its better to keep translations of incorrect help > content in sync than to have at least some of them right, but *shrug*, > whatever's easiest to manage. Currently there are many help contents that obsolete or inaccurate. But wrt the string freeze, we couldn't release the fix of them (because they all must happen in master), and user have to wait for the next 3.x major release to have them correct, which is every too-long six months. So, IMO - may we freeze only UI string, but not help? (but it's harder to manage, though) - or update the wikihelp more frequently? (but this doesn't update localhelp, which maybe essential for some users) - or just leave it as is? What is the process for other projects? Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED]PATCH] Update help fdo#31652
Hello Andras, Caolán, Christian, * Sorry for all mess which cause string freeze break. So, should we revert my fix in all stable branch? Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Potential Problems for LibreOffice on Mac with impending release of Lion OSX
Le 24/06/11 06:59, Alexander Thurgood a écrit : I've managed to find this, an indication of things that will be different with Lion OSX : http://www.appleinsider.com/articles/11/02/24/sources_detail_new_features_in_apples_first_beta_of_mac_os_x_10_7_lion.html Interesting bit about changes to NSApplication and NSWindow classes (not much detail unfortunately), possibly might have an effect on Impress and full screen display of presentations ? Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Update help fdo#31652
Hello Cor, all, On Fri, Jun 24, 2011 at 01:17, Cor Nouws wrote: > Great to see this subject here - I happened to think about it two evenings > before, since I saw "Edit > Delete contents Backspace" in the menu of Calc. But I saw "Edit > Delete contents Delete" in official 3.3.3. Anyway, it's surely incorrect in some points. ;) > One big 'however' : there is the option Tools > Options > Calc > > Compatibility that, among others, toggles these keys. > > Handling that in the Help text is not that difficult. > Making that work in the menu ..? I doubt if the text is dynamic after the > start. So, I've reported this in fdo bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38691 Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] ●en8 降 低 采 购 成 本 及 供 应 商 谈 判 技 巧 -- 傅丽如 敬呈！！
odko请4ecy查qehn收6wfi附zzx5件jtt7 见没事后利这才接过一览。 画面推移到几天以前。 里。否则地话。我可要赶人了。” 降低采购成本及供应商谈判技巧.xls Description: MS-Excel spreadsheet ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] impress: after adding a new animation, scroll down to it in the list.
Hi Radek,
On Sat, Jun 25, 2011 at 3:35 AM, Radek Doulik wrote:
>
>
> At least I am not reaching the part you modified when adding custom
> animation thru custom animation pane (using the add button and custom
> animation dialog). If we move it to the loop, it will be reached always
> when selecting an entry - the select method is called recursively when
> adding new pEntry in:
>
>if( !pEntry && bSelect )
>{
>append( pEffect );
>select( pEffect );
>}
>
> I wonder how do you reach that part of code?
Hmm. I think the code is incorrect here. That last if statement should
really only be used if the effect wasn't in the list & needs to be added.
But when I added the MakeVisible in the if statement, it made new animations
be scrolled to, and I was doing it via add->custom animation dialog too.
What do you think of my attached patch? Once we have found the given entry,
we should select it and then we are done, aren't we?
Kind regards,
Luke.
From 83f1cfca5aab5ea98f703108b6f7d0baa02343ca Mon Sep 17 00:00:00 2001
From: Luke Symes
Date: Sun, 26 Jun 2011 21:53:46 +1200
Subject: [PATCH] Scroll to newly added animations in the list.
---
sd/source/ui/animations/CustomAnimationList.cxx |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx
index cfb8463..6e6b637 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -533,7 +533,8 @@ void CustomAnimationList::select( CustomAnimationEffectPtr pEffect, bool bSelect
if( pEntry->getEffect() == pEffect )
{
Select( pEntry, bSelect );
-break;
+MakeVisible( pEntry );
+return;
}
pEntry = static_cast< CustomAnimationListEntry* >(Next( pEntry ));
}
@@ -542,6 +543,7 @@ void CustomAnimationList::select( CustomAnimationEffectPtr pEffect, bool bSelect
{
append( pEffect );
select( pEffect );
+MakeVisible( Last() );
}
}
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED:master] Fix for Bug 37484 - On any animation change, current position in list is lost
Hi Radek,
On Sat, Jun 25, 2011 at 3:47 AM, Radek Doulik wrote:
>
> I run into a crash on startup in that part. I quickly fixed it, but it
> might be better if you check that it plays nicely with your new code. Or
> maybe make the ScrollToAbsPos not crash when called with unexpected
> values, -1 for example.
Thanks for fixing this! You're right, I didn't test loading a blank
presentation... Your quick fix fits well with the rest of the code;
nFirstVis will never be -1 if there are entries in the CustomAnimationList.
I was sad that ScrollToAbsPos failed; it turns out that it's due to there
being no entries in the list (I had added a check for negative scroll
position values which would try to go to scroll to the first entry). I have
attached a patch for ScrollToAbsPos that will check if there are entries in
the list first, and if not just return. Could you please review/commit this?
Kind regards,
Luke.
From f1b9f0219708da8332f1ba728fce0c63cbec6f4b Mon Sep 17 00:00:00 2001
From: Luke Symes
Date: Sun, 26 Jun 2011 22:13:01 +1200
Subject: [PATCH] Fix ScrollToAbsPos to work when we have an empty list.
---
svtools/source/contnr/svimpbox.cxx |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/svtools/source/contnr/svimpbox.cxx b/svtools/source/contnr/svimpbox.cxx
index fd5a649..e0e9efc 100644
--- a/svtools/source/contnr/svimpbox.cxx
+++ b/svtools/source/contnr/svimpbox.cxx
@@ -1014,6 +1014,8 @@ void SvImpLBox::MakeVisible( SvLBoxEntry* pEntry, sal_Bool bMoveToTop )
void SvImpLBox::ScrollToAbsPos( long nPos )
{
+if( pView->GetVisibleCount() == 0 )
+return;
long nLastEntryPos = pView->GetAbsPos( pView->Last() );
if( nPos < 0 )
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
