License statement
To those to whom the proceeding shall concern, Any past, present and future contributions of mine shall be deemed to be contributed under the dual-licensing scheme of the Lesser GNU General Public License, version 3, and the Mozilla Public License, unless further notice is given. Best regards, Kevin Peng -- Kevin Peng kpeng...@fastmail.fm -- http://www.fastmail.fm - Access all of your messages and folders wherever you are ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: C++11 in LibreOffice
On 07/19/2012 11:26 AM, Michael Meeks wrote: On Thu, 2012-07-19 at 16:04 +0200, Michael Stahl wrote: i'm saying it doesn't benefit from the "sophisticated" optimizations that vendor compilers like SunStudio or Intel do that speed up your BLAS stuff with gigabytes of floating point arrays by X times because office suites don't contain gigabytes of floating point arrays. So - Kohei has been working for years to turn Calc spreadsheets into gigabyte arrays of floating point numbers - precisely to take advantage of this sort of optimisation :-) Just wrote a blog post explaining some of that. http://kohei.us/2012/07/20/mdds-multi_type_vector-explained/ Almost 2 years in the making (well, that also includes one year of just thinking about it idly with no code), I'm glad I've finally got this one off my shoulder. :-) But no doubt more work is ahead to further optimize this structure. Also, ScMatrix's new backend now uses it. My hope is to use ScMatrix as a test-drive and try to get all its kinks sorted out before using this to store cells in ScColumn. Best, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/core/tool/scmatrix.cxx | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
New commits:
commit 87404d2671e78225aa91ead79ebf7191f6317a16
Author: Kohei Yoshida
Date: Fri Jul 20 23:31:06 2012 -0400
It's much faster to pass value array in one go than individually.
Change-Id: Iaf58915ab5c56ef5707f3a90a308c8b57cdc4fe9
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index d0d3fce..ccf786c 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -38,6 +38,8 @@
#include
+#include
+
#include
#include
#include
@@ -856,9 +858,12 @@ void ScMatrixImpl::FillDouble( double fVal, SCSIZE nC1,
SCSIZE nR1, SCSIZE nC2,
{
if (ValidColRow( nC1, nR1) && ValidColRow( nC2, nR2))
{
-for (SCSIZE i = nR1; i <= nR2; ++i)
-for (SCSIZE j = nC1; j <= nC2; ++j)
-maMat.set(i, j, fVal);
+for (SCSIZE j = nC1; j <= nC2; ++j)
+{
+// Passing value array is much faster.
+std::vector aVals(nR2-nR1+1, fVal);
+maMat.set(nR1, j, aVals.begin(), aVals.end());
+}
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Memory options defaults
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Someone from the Brazilian users list raised an issue about the current memory defaults we carry in our age-old options. He argues that the current values were set when computers were short on GBytes, which is not the case anymore actually. He also claims that there are better figures to put that improves LO performance, and those figures should be a function of the amount of RAM available. Does it worth to review our memory figures? Regards - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Fundação responsável civilmente, de acordo com o direito civil Detalhes Legais: http://www.documentfoundation.org/imprint LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJQCgd+AAoJEJp3R7nH3vLxwPgH/3qSjGRL60fMspTkEY7a2Mw8 Xbfn9BC+tVusoiI5fT3Q9ypSk/1T/LzOrAC4WXs2HhIHmMSRK68Wf0u2sVhZaKvZ vmapXfuWBKWZCBs+zMQQiR3geZs4NVV59wzT/eTc7Rz/19IU+F9i8Pai3Q5ONcXv jr2uBfD2Ki3gRhbKXlOFNBWZZxbI+1p1vplLWuXcD4aDQdRso7lGLwJDl6wBTa7X DkogH2Ulj20PQvme775eaOzSAhIb4xdfsuP2eppCOqLMuUv1P6HlIQqNI4kWMNXb VBat3kt626883p6IUZWfzI0qHEWHSO06rS0O11mO16ecoSx4A8yDoqSFugT3U0A= =Cq5A -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Modern font features, hacky patch
On Fri, Mar 30, 2012 at 03:27:39PM +0100, Caolán McNamara wrote: > On Fri, 2012-03-30 at 16:13 +0200, Khaled Hosny wrote: > > If there is interest in this, I can try implementing optional HarfBuzz > > support next to ICU so we can experiment more with this (though I'm not > > the best person to do this, but I can try). > > Can't hurt to give it a go anyway. Even epic failure can point the next > person in the right way to go. Yeah lacking Indic shaping would be a > problem for right now. Indic scripts are supported now (git master, not released yet), and given HarfBuzz track record, it should even be better than ICU layout engine which is essentially put on ventilator (pun intended), so now is a good time to experiment, but I didn't manage to try doing it yet. Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - sfx2/inc sfx2/source
sfx2/inc/templatedlg.hxx|2 +-
sfx2/source/doc/templatedlg.cxx |9 +
sfx2/source/doc/templatedlg.src | 10 +-
3 files changed, 11 insertions(+), 10 deletions(-)
New commits:
commit 86f7066c0921df5d9fa2a1d4c07b175fb0fb49c9
Author: Rafael Dominguez
Date: Mon Jul 16 21:55:20 2012 -0430
Display correct view when searching and position online view below box.
Change-Id: Ib58a48c3cbd8aaba38f053bf0a646d6c267f7909
diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 9017f09..4add070 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -604,7 +604,7 @@ IMPL_LINK_NOARG(SfxTemplateManagerDlg, SearchUpdateHdl)
{
mpSearchView->Clear();
mpSearchView->Show();
-maView->Hide();
+mpCurView->Hide();
}
rtl::OUString aKeyword = mpSearchEdit->GetText();
@@ -634,7 +634,7 @@ IMPL_LINK_NOARG(SfxTemplateManagerDlg, SearchUpdateHdl)
else
{
mpSearchView->Hide();
-maView->Show();
+mpCurView->Show();
}
return 0;
@@ -741,6 +741,7 @@ void SfxTemplateManagerDlg::OnTemplateSearch ()
SetSizePixel(aWinSize);
maView->SetPosPixel(aPos);
+mpOnlineView->SetPosPixel(aPos);
mpSearchView->SetPosPixel(aPos);
maButtonClose.SetPosPixel(aClosePos);
@@ -748,7 +749,7 @@ void SfxTemplateManagerDlg::OnTemplateSearch ()
if (bVisible)
{
mpSearchView->Hide();
-maView->Show();
+mpCurView->Show();
}
mpSearchEdit->Show(!bVisible);
commit 8d1e1177bd41f342d934f3ef47018a4651a390d5
Author: Rafael Dominguez
Date: Mon Jul 16 18:44:07 2012 -0430
Make command names shorter.
Change-Id: I2e258ad84aafd17121f86bdc8b8b1aa24b24e709
diff --git a/sfx2/source/doc/templatedlg.src b/sfx2/source/doc/templatedlg.src
index 44a48e4..cb73de0 100644
--- a/sfx2/source/doc/templatedlg.src
+++ b/sfx2/source/doc/templatedlg.src
@@ -177,7 +177,7 @@ ModelessDialog DLG_TEMPLATE_MANAGER
ToolBoxItem
{
Identifier = TBI_TEMPLATE_CREATE;
-Text [ en-US ] = "Create a template" ;
+Text [ en-US ] = "Create" ;
ItemImage = Image
{
@@ -188,19 +188,19 @@ ModelessDialog DLG_TEMPLATE_MANAGER
ToolBoxItem
{
Identifier = TBI_TEMPLATE_LOCAL;
-Text [ en-US ] = "Local Templates";
+Text [ en-US ] = "Local";
};
ToolBoxItem
{
Identifier = TBI_TEMPLATE_ONLINE;
-Text [ en-US ] = "Online Templates";
+Text [ en-US ] = "Online";
};
ToolBoxItem
{
Identifier = TBI_TEMPLATE_IMPORT ;
-Text [ en-US ] = "Import a template" ;
+Text [ en-US ] = "Import" ;
ItemImage = Image
{
commit 82dad7f68ab05e55cc2e7e0f27026419e04e0622
Author: Rafael Dominguez
Date: Sun Jul 15 12:16:02 2012 -0430
Make TemplateDialog modeless.
Change-Id: I71f923112e932b9cbee9f084581b7a5cdd878510
diff --git a/sfx2/inc/templatedlg.hxx b/sfx2/inc/templatedlg.hxx
index 47e6f9b..23fd9a4 100644
--- a/sfx2/inc/templatedlg.hxx
+++ b/sfx2/inc/templatedlg.hxx
@@ -31,7 +31,7 @@ namespace com {
} } }
}
-class SfxTemplateManagerDlg : public ModalDialog
+class SfxTemplateManagerDlg : public ModelessDialog
{
public:
diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 05d333b..9017f09 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -84,7 +84,7 @@ private:
};
SfxTemplateManagerDlg::SfxTemplateManagerDlg (Window *parent)
-: ModalDialog(parent, SfxResId(DLG_TEMPLATE_MANAGER)),
+: ModelessDialog(parent, SfxResId(DLG_TEMPLATE_MANAGER)),
aButtonAll(this,SfxResId(BTN_SELECT_ALL)),
aButtonDocs(this,SfxResId(BTN_SELECT_DOCS)),
aButtonPresents(this,SfxResId(BTN_SELECT_PRESENTATIONS)),
diff --git a/sfx2/source/doc/templatedlg.src b/sfx2/source/doc/templatedlg.src
index 2681200..44a48e4 100644
--- a/sfx2/source/doc/templatedlg.src
+++ b/sfx2/source/doc/templatedlg.src
@@ -45,7 +45,7 @@ String STR_INPUT_NEW
Text [ en-US ] = "Enter folder name:";
};
-ModalDialog DLG_TEMPLATE_MANAGER
+ModelessDialog DLG_TEMPLATE_MANAGER
{
HelpId = CMD_SID_TEMPLATE_MANAGER;
OutputSize = TRUE;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: i18npool/source
i18npool/source/localedata/data/list-dateacceptancepattern.awk | 17
+++---
1 file changed, 12 insertions(+), 5 deletions(-)
New commits:
commit 369c76f325bf3d998bab0b069a5a4e6112e2d32e
Author: Eike Rathke
Date: Sat Jul 21 01:47:39 2012 +0200
print full inheritance
Change-Id: Ia53fcbde6b3ff4d38b477069a1f956c9aef84f78
diff --git a/i18npool/source/localedata/data/list-dateacceptancepattern.awk
b/i18npool/source/localedata/data/list-dateacceptancepattern.awk
index b272905..1d47814 100644
--- a/i18npool/source/localedata/data/list-dateacceptancepattern.awk
+++ b/i18npool/source/localedata/data/list-dateacceptancepattern.awk
@@ -80,7 +80,7 @@ END {
for (i in LocaleList)
{
if (LocaleList[i][offinherit] && LocaleList[i][offpatterns])
-print LocaleList[i][offlocale] " = " LocaleList[i][offinherit]
" "
+print getInheritance( LocaleList[i][offlocale],
LocaleList[i][offlocale]) " "
}
print "\n"
}
@@ -89,7 +89,7 @@ END {
for (i in LocaleList)
{
if (LocaleList[i][offinherit] && LocaleList[i][offpatterns])
-print LocaleList[i][offlocale] " = " LocaleList[i][offinherit]
+print getInheritance( LocaleList[i][offlocale],
LocaleList[i][offlocale])
}
print "\n"
}
@@ -105,7 +105,7 @@ END {
for (i in LocaleList)
{
if (!LocaleList[i][offpatterns])
-print LocaleList[i][offlocale] " "
+print getInheritance( LocaleList[i][offlocale],
LocaleList[i][offlocale]) " "
}
}
else
@@ -113,13 +113,13 @@ END {
for (i in LocaleList)
{
if (!LocaleList[i][offpatterns])
-print LocaleList[i][offlocale]
+print getInheritance( LocaleList[i][offlocale],
LocaleList[i][offlocale])
}
}
}
-function endFile() {
+function endFile( locale ) {
locale = getLocale( file)
LocaleList[locale][offlocale] = locale
LocaleList[locale][offpatterns] = patterns
@@ -172,4 +172,11 @@ function fillAllInherited( i ) {
}
}
+
+function getInheritance( str, locale ) {
+if (LocaleList[locale][offinherit])
+str = getInheritance( str " = " LocaleList[locale][offinherit],
LocaleList[locale][offinherit])
+return str
+}
+
# vim:set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[ANN] LibreOffice 3.6.0 RC2 available
Dear Community, The Document Foundation is happy to announce the second release candidate of LibreOffice 3.6.0. The upcoming 3.6.0 will be our fourth major release in two years, and comes with a nice set of new features. Please be aware that LibreOffice 3.6.0 RC2 is not ready for production use, you should continue to use LibreOffice 3.5.5 for that. The release is available for Windows, Linux and Mac OS X from our QA builds download page at http://www.libreoffice.org/download/pre-releases/ The (still growing) list of features for the upcoming 3.6.0 is on our wiki - please help filling gaps there, e.g. by providing more screenshots: http://wiki.documentfoundation.org/ReleaseNotes/3.6 Should you find bugs, please report them to the FreeDesktop Bugzilla: https://bugs.freedesktop.org A good way to assess the release candidate quality is to run some specific manual tests on it, our TCM wiki page has more details: http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test (and the announcement mail: http://lists.freedesktop.org/archives/libreoffice/2011-December/022464.html) For other ways to get involved with this exciting project - you can e.g. contribute code: http://www.libreoffice.org/get-involved/developers/ translate LibreOffice to your language: http://wiki.documentfoundation.org/Translation_for_3.5 or help with funding our operations: http://challenge.documentfoundation.org/ A list of known issues and fixed bugs with 3.6.0 RC2 is available from our wiki: http://wiki.documentfoundation.org/Releases/3.6.0/RC2 Please find the list of changes against LibreOffice 3.6.0 RC1 here: http://download.documentfoundation.org/libreoffice/src/bugfixes-libreoffice-3-6-0-release-3.6.0.2.log Let us close again with a BIG Thank You! to all of you having contributed to the LibreOffice project - this release would not have been possible without your help. Yours, The Document Foundation Board of Directors The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Rechtsfähige Stiftung des bürgerlichen Rechts Legal details: http://www.documentfoundation.org/imprint pgpKqm807Z3HR.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: i18npool/source
i18npool/source/localedata/data/list-dateacceptancepattern.awk | 60
++
1 file changed, 40 insertions(+), 20 deletions(-)
New commits:
commit 61c1af3336e91144fadeffe1a479e2a0f10cdfd1
Author: Eike Rathke
Date: Sat Jul 21 01:07:54 2012 +0200
make this extensible and do not omit inherited without patterns
Change-Id: I97a554169637740aab4282b303a32f476f294e2f
diff --git a/i18npool/source/localedata/data/list-dateacceptancepattern.awk
b/i18npool/source/localedata/data/list-dateacceptancepattern.awk
index 87ddfdc..b272905 100644
--- a/i18npool/source/localedata/data/list-dateacceptancepattern.awk
+++ b/i18npool/source/localedata/data/list-dateacceptancepattern.awk
@@ -23,7 +23,9 @@ BEGIN {
--ARGC
}
file = ""
-nopatterns = 0
+offlocale = 0
+offpatterns = 1
+offinherit = 2
inheritedcount = 0
if (html)
print ""
@@ -58,6 +60,11 @@ file != FILENAME {
END {
if (file)
endFile()
+
+PROCINFO["sorted_in"] = "@ind_str_asc"
+
+fillAllInherited()
+
if (html)
{
print ""
@@ -70,19 +77,19 @@ END {
if (html)
{
print ""
-for (i=0; i"
}
else
{
-for (i=0; i"
if (html)
{
-for (i=0; ihttp://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH (partial)] Writer autocompletion feature
On 18.07.2012 14:57, Jan Holesovsky wrote: Hi Nico, On 2012-07-09 at 23:46 +0200, Nico Weyand wrote: Originally, I wanted to submit a patch to improve the writer autocompletion feature. However I won't have the time to finish it for the next two or three months, so I thought I'd submit what has already been finished in case anyone is interested on doing any work on the feature. The archive attached contains the files required for replacing the current list used to store autocompletion words by a much faster tree structure. It also allows for storing the word probability so that for a given word prefix, if will return the autocompletion with the highest probability. Thank you for that - sounds very interesting :-) PS.: I do release this code under GPL 3+ – as long as this doesn't mean my email address is posted in a public location :D Unfortunately - this is a problem. The LibreOffice license is MPL and LGPLv3+ (not GPLv3+), so we cannot use that - would be great if you can re-post with the MPL/LGPLv3+ license, ideally via a post to this mailing list stating that all your patches to LibreOffice are licensed MPL/LGPLv3+; anything else is hard to track, unfortunately. Thank you a lot, Kendy Well, in that case, I'm officially stating that the code I've committed (and all future code I am going to commit) may be used under LGPLv3+ (If I've understood it correctly, only one of both the licenses you named is required and I do prefer LGPL over MPL). Greetings, Nico ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - sc/qa
sc/qa/unit/ucalc.cxx | 142 +++
1 file changed, 142 insertions(+)
New commits:
commit d039b0070d62a54740b3f88d52debe3d5f4d664c
Author: Markus Mohrhard
Date: Fri Jul 20 23:46:00 2012 +0200
second test for ScDocument::FindAreaPos
Change-Id: I215a33d6a1e38ad3edcb92e160e90f7d04db08f1
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 6a479f0..8753a40 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -216,6 +216,7 @@ public:
void testCopyPasteFormulasExternalDoc();
void testFindAreaPosRowDown();
+void testFindAreaPosColRight();
CPPUNIT_TEST_SUITE(Test);
#if 0
@@ -262,6 +263,7 @@ public:
CPPUNIT_TEST(testCopyPasteFormulasExternalDoc);
#endif
CPPUNIT_TEST(testFindAreaPosRowDown);
+CPPUNIT_TEST(testFindAreaPosColRight);
CPPUNIT_TEST_SUITE_END();
private:
@@ -4593,7 +4595,7 @@ void Test::testCopyPasteFormulasExternalDoc()
void Test::testFindAreaPosRowDown()
{
const char* aData[][2] = {
-{ "", "" },
+{ "", "1" },
{ "1", "" },
{ "1", "1" },
{ "", "1" },
@@ -4660,6 +4662,71 @@ void Test::testFindAreaPosRowDown()
pDoc->DeleteTab(0);
}
+void Test::testFindAreaPosColRight()
+{
+const char* aData[][7] = {
+{ "", "1", "1", "", "1", "1", "1" },
+{ "", "", "1", "1", "1", "", "1" }, };
+
+ScDocument* pDoc = m_xDocShRef->GetDocument();
+rtl::OUString aTabName1("test1");
+pDoc->InsertTab(0, aTabName1);
+clearRange( pDoc, ScRange(0, 0, 0, 7, SAL_N_ELEMENTS(aData), 0));
+ScAddress aPos(0,0,0);
+ScRange aDataRange = insertRangeData( pDoc, aPos, aData,
SAL_N_ELEMENTS(aData));
+CPPUNIT_ASSERT_MESSAGE("failed to insert range data at correct position",
aDataRange.aStart == aPos);
+
+pDoc->SetColHidden(4,4,0,true);
+bool bHidden = pDoc->ColHidden(4,0);
+CPPUNIT_ASSERT(bHidden);
+
+SCCOL nCol = 0;
+SCROW nRow = 0;
+pDoc->FindAreaPos(nCol, nRow, 0, 1, 0);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(0), nRow);
+CPPUNIT_ASSERT_EQUAL(static_cast(1), nCol);
+
+pDoc->FindAreaPos(nCol, nRow, 0, 1, 0);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(0), nRow);
+CPPUNIT_ASSERT_EQUAL(static_cast(2), nCol);
+
+pDoc->FindAreaPos(nCol, nRow, 0, 1, 0);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(0), nRow);
+// BUG! This returns right now 4 because FindAreaPos does
+// not yet work correctly with hidden rows
+//CPPUNIT_ASSERT_EQUAL(static_cast(5), nCol);
+
+pDoc->FindAreaPos(nCol, nRow, 0, 1, 0);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(0), nRow);
+CPPUNIT_ASSERT_EQUAL(static_cast(6), nCol);
+
+pDoc->FindAreaPos(nCol, nRow, 0, 1, 0);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(0), nRow);
+CPPUNIT_ASSERT_EQUAL(static_cast(MAXCOL), nCol);
+
+nCol = 2;
+nRow = 1;
+
+pDoc->FindAreaPos(nCol, nRow, 0, 1, 0);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(1), nRow);
+// BUG! This returns right now 4 because FindAreaPos does
+// not yet work correctly with hidden rows
+//CPPUNIT_ASSERT_EQUAL(static_cast(3), nCol);
+
+pDoc->FindAreaPos(nCol, nRow, 0, 1, 0);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(1), nRow);
+CPPUNIT_ASSERT_EQUAL(static_cast(6), nCol);
+
+pDoc->DeleteTab(0);
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(Test);
}
commit 40cfaaa73887045230f9508e8330ce267390fe6b
Author: Markus Mohrhard
Date: Fri Jul 20 22:59:10 2012 +0200
first test for ScDocument::FindAreaPos
This is the first step into fixing the cursor navigation.
ScDocument::FindAreaPos contains still bugs in the handling of hidden
rows and hidden columns. This test checks only problems with rows and
moving downwards.
Change-Id: I204064a96a1abdb8ab5f46e395f8f7c391fb4824
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 79cda88..6a479f0 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -215,7 +215,10 @@ public:
void testCopyPasteFormulas();
void testCopyPasteFormulasExternalDoc();
+void testFindAreaPosRowDown();
+
CPPUNIT_TEST_SUITE(Test);
+#if 0
CPPUNIT_TEST(testCollator);
CPPUNIT_TEST(testInput);
CPPUNIT_TEST(testCellFunctions);
@@ -257,6 +260,8 @@ public:
CPPUNIT_TEST(testAutoFill);
CPPUNIT_TEST(testCopyPasteFormulas);
CPPUNIT_TEST(testCopyPasteFormulasExternalDoc);
+#endif
+CPPUNIT_TEST(testFindAreaPosRowDown);
CPPUNIT_TEST_SUITE_END();
private:
@@ -4585,6 +4590,76 @@ void Test::testCopyPasteFormulasExternalDoc()
CPPUNIT_ASSERT_EQUAL(aFormula, rtl::OUString("=$ExtSheet2.$B$2"));
}
+void Test::testFindAreaPosRowDown()
+{
+const char* aData[][2] = {
+{ "", "" },
+{ "1", "" },
+{ "1", "1" },
+{ "", "1" },
+{ "1", "1" },
+{ "1", "" },
+{ "1", "1" }, };
+
+ScDocument* pDoc = m_xDocShRef->GetDocument();
+rtl::OUString aTabName1("test1");
+pDoc->InsertTab(0, aTabName1);
+cl
Re: git branch audit - results ...
On Fri, Jul 20, 2012 at 05:15:27PM +0100, Michael Meeks wrote: > origin/feature/gbuild_mkdir Norberts, dunno. > origin/feature/gbuildfixes mostly mine. Whatever is in there is either merged or obsolete -> can be deleted. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git branch audit - results ...
On Fri, Jul 20, 2012 at 11:45 AM, Michael Meeks wrote: > > Thanks for all the input, I tried to condense it; what I have is this. > After another > > git remote prune origin > > I see we're a lot cleaner now :-) but I still have these to delete > (will do that Monday absent screams): > > * to-kill > origin/feature/external_gbuild # ~obsolete attempt to gbuild > external modules > origin/feature/cell-format-data-bar # obsolete now > origin/feature/cell-notes # obsolete now > origin/feature/line-numbers-in-basicIDE # merged to master > origin/feature/masterpages # merged to master & 3.6 > origin/feature/layout # obsoleted by Caolan's new work > > * unknown status - input appreciated > origin/feature/chart_errorbars > origin/feature/gbuild_mkdir > origin/feature/gbuildfixes > origin/feature/mork > origin/feature/template-dialog > > Thanks ! :-) > > Michael. > > * keep: > origin/feature/accfixes2 > origin/feature/gsoc_test_improvements > origin/feature/gsoc_test_improvements2 > origin/feature/gsoc_test_improvements3 > origin/feature/stub_writer > origin/feature/cmclayouttrans > origin/feature/unitymenus > origin/feature/coretext # Norbert's coretext work > origin/feature/submodules > origin/features/base-preview # Lionel's ongoing work > origin/feature/gsoc-calc-perf > origin/feature/gsoc-calc-perf2 > origin/feature/matrix-new-backend # Kohei's ongoing work > origin/feature/opengl-canvas # openGL rendering > origin/feature/remote # Andrezj's Android remote > origin/feature/gbuild_help > > * already removed: > origin/feature/android-x86 > origin/feature/pdf-signing > origin/feature/crossmsi > origin/feature/kill-set_soenv > origin/feature/mspub > origin/feature/multiline-input > origin/feature/gbuild_a11y > origin/feature/gbuild_components > origin/feature/gbuild_conversions > origin/feature/gbuild_extensions > origin/feature/gbuild_java > origin/feature/gbuild_merge > origin/feature/gbuild_mkdir > origin/feature/gbuild_scp2 > origin/feature/gbuild_sdext > origin/feature/gbuild_shell > origin/feature/gbuild_testtools > > -- > michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice origin/feature/chart_errorbars origin/feature/template-dialog Both of them are already merged ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH (partial)] fdo#48549 System::Beep() removal
2012/7/20 Mek Otar : > Hi, > > I've written a patch that remove all call to Sound:Beep. Thomas > Arnhold suggest me to replace the Sound:Beep by some error reporting > mechanism. My question is: What is, in your opinion, the best way to > do this? > > Best regards > > Mek Otar Hi Mek, When I looked at your patch I was also wondering if such a radical deletion is such a good thing... or if it wouldn't be better to log at least in some of those cases an error messages? In my eyes these beeps were originally intended to tell the user that something unexpected happend but I agree that a beep is not the right way to do so. Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: i18npool/source
i18npool/source/localedata/data/list-dateacceptancepattern.awk | 56
--
1 file changed, 45 insertions(+), 11 deletions(-)
New commits:
commit 38feb1ef3840a7c4aa8b70e4d1570675697a53ae
Author: Eike Rathke
Date: Fri Jul 20 23:19:31 2012 +0200
include locales inheriting patterns
Change-Id: I06f4578f6d681064a8e41e4bef45a7034b7b5a64
diff --git a/i18npool/source/localedata/data/list-dateacceptancepattern.awk
b/i18npool/source/localedata/data/list-dateacceptancepattern.awk
index b1ad115..87ddfdc 100644
--- a/i18npool/source/localedata/data/list-dateacceptancepattern.awk
+++ b/i18npool/source/localedata/data/list-dateacceptancepattern.awk
@@ -8,8 +8,11 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
# Usage: gawk -f list-dateacceptancepattern.awk *.xml [--html]
-# Outputs two lists of locales, one with DateAcceptancePattern elements
-# defined, and one where none are defined.
+#
+# Outputs three lists of locales, one with DateAcceptancePattern elements
+# defined, one with inherited LC_FORMAT elements and thus date patterns, and
+# one where no DateAcceptancePattern are defined.
+#
# If --html is given as the last parameter, format output suitable for
# inclusion in HTML.
@@ -21,6 +24,7 @@ BEGIN {
}
file = ""
nopatterns = 0
+inheritedcount = 0
if (html)
print ""
else
@@ -36,7 +40,7 @@ file != FILENAME {
endFile()
file = FILENAME
patterns = 0
-noFormatCode = 1
+inherited = ""
}
// {
@@ -44,10 +48,10 @@ file != FILENAME {
pattern[patterns++] = a[3]
}
-# No FormatCode element means inherited LC_FORMAT ref=...
-# hence pattern inherited as well.
-// {
-noFormatCode = 0
+# pattern inherited as well
+/]* ref="[^>"]+"[^>]*>/ {
+split( $0, a, /.* ref="|"/ )
+inherited = a[2]
}
@@ -61,6 +65,28 @@ END {
}
else
print "\n"
+
+print "Locales inheriting patterns:"
+if (html)
+{
+print ""
+for (i=0; i"
+}
+else
+{
+for (i=0; i"
@@ -85,11 +111,13 @@ END {
function endFile() {
+locale = getLocale( file)
+LocaleHasPatterns[locale] = patterns
if (patterns)
{
if (html)
{
-print " " getLocale( file) ":"
+print " " locale ":"
print " "
for ( i=0; ihttp://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [GSoC 2012][Collaboration] status, ideas
Hi Michael, On 16 July 2012 14:57, Michael Meeks wrote: > Hi Matus, > > On Sat, 2012-07-14 at 19:49 +0200, Matúš Kukan wrote: >> And it works! I was able to invite a contact and after accepting in VM >> in empathy, Channel Dispatcher has executed .../soffice --calc as told >> in org.freedesktop.Telepathy.Client.LibreOffice.service. >> I was thinking that it could run .../soffice --accept-tube, so we know >> why Libreoffice is started and do something clever ;-) > > Yep; that's the idea I guess - we'd need to hack desktop/source/app/ > cmdline etc. bits to pass through the identifier of the tube to accept, > and find some elegant way of plugging that into desktop/ I guess. So - I've used gerrit for this: https://gerrit.libreoffice.org/#/c/336/ I am not sure I want this in its current form but it's something visible and anyone can comment now ;-) I use Desktop class, and init TeleManager in there. But registering clients (so you could get channels, files) is happening now only when we run ./soffice --invisible. This is probably not right thing to do. Maybe I could let Listen button still work in addition. >> There is no other case when someone sends us file ? > > There are some nasty cases I suspect when we loose the connection and > have local changes, and need to reconcile them, but - for now, > send-file-to-new-connector is the right thing to do I think. great :-) >> But still, after receiving new channel [4], I need to accept it, >> receive the file and then bind the channel to that file ? >> I guess I need to take a rest and think again later. > > Right; there is a need to associated XFrames - or SfxSomething's with > collaboration sessions I suppose that bit needs doing; It's associated to ScDocFuncSend. But It does not work if we - open another document | receive another channel - between receiving channel and setting session for document belonging to that channel. >> - I broke INTERCEPT=demo mode. > > Fine ;-) I'll fix it when I next need to demo things. Oh, well, I compile it again (because I use CreateScDocFunc again) and need to do ugly things as exporting TeleManager_fileReceived. > Nice work, Thanks :-) Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-commits] .: 3 commits - sc/source tubes/inc tubes/Library_tubes.mk tubes/source
On 20 July 2012 21:50, Lubos Lunak wrote:
> On Friday 20 of July 2012, Matus Kukan wrote:
>> sc/source/ui/collab/contacts.cxx |8 ---
>> sc/source/ui/collab/sendfunc.cxx | 82
>> +--
>> sc/source/ui/collab/sendfunc.hxx | 1
>> tubes/Library_tubes.mk |4 +
>> tubes/inc/tubes/manager.hxx |4 -
>> tubes/source/manager.cxx | 47 +++---
>> 6 files changed, 48 insertions(+), 98 deletions(-)
> ...
>> +try
>> +{
>> +css::uno::Reference < css::frame::XComponentLoader > xLoader(
>> +::comphelper::getProcessServiceFactory()->createInstance(
>> +"com.sun.star.frame.Desktop" ),
>> +css::uno::UNO_QUERY_THROW );
>> +css::uno::Reference < css::util::XCloseable > xDoc(
>> +xLoader->loadComponentFromURL( rStr, "_blank", 0, args ),
>> +css::uno::UNO_QUERY_THROW );
>> +}
>> +catch ( css::uno::Exception& e )
>> +{
>> +fprintf( stderr, "exception when loading '%s' !\n",
>> + rtl::OUStringToOString( e.Message, RTL_TEXTENCODING_UTF8
>> ).getStr() );
>
> SAL_WARN
Thanks, it was moved from sc/source/ui/collab where we still use fprintf.
Fixed in tubes/
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: tubes/source
tubes/source/manager.cxx |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
New commits:
commit 179283359fe6167a6a499fe2abd4800ca142755a
Author: Matúš Kukan
Date: Fri Jul 20 22:12:19 2012 +0200
tubes: use SAL_WARN SAL_LOG
Change-Id: Ic0c291183c63bb5c4a0a7e54f80c3c8f23349a3d
diff --git a/tubes/source/manager.cxx b/tubes/source/manager.cxx
index f6642f2..768492b 100644
--- a/tubes/source/manager.cxx
+++ b/tubes/source/manager.cxx
@@ -183,8 +183,7 @@ bool TeleManager::hasWaitingConference()
// FIXME this is exported only because of ScDocFuncDemo
SAL_DLLPUBLIC_EXPORT void TeleManager_fileReceived( const rtl::OUString &rStr )
{
-fprintf( stderr, "incoming file '%s'\n",
- rtl::OUStringToOString( rStr, RTL_TEXTENCODING_UTF8 ).getStr() );
+SAL_INFO( "tubes", "TeleManager_fileReceived: incoming file: " << rStr );
css::uno::Reference< css::lang::XMultiServiceFactory > rFactory =
::comphelper::getProcessServiceFactory();
@@ -202,8 +201,7 @@ SAL_DLLPUBLIC_EXPORT void TeleManager_fileReceived( const
rtl::OUString &rStr )
}
catch ( const css::uno::Exception& e )
{
-fprintf( stderr, "exception when loading '%s' !\n",
- rtl::OUStringToOString( e.Message, RTL_TEXTENCODING_UTF8
).getStr() );
+SAL_WARN( "tubes", "TeleManager_fileReceived: exception when loading:
" << e.Message );
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] updated tango artwork ...
On Fri, Jul 20, 2012 at 09:19:35PM +0200, Eike Rathke wrote: > On Thursday, 2012-07-19 17:57:49 +0100, Michael Meeks wrote: > > all looks good to me, though the sendmail icon is a tad cute :-) > Anyhow, no cows, no dogs, no middle fingers.. have my sign-off. IANAL and trust Michael on that. Other than that looking good, pushed. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] tubes: init TeleManager in desktop
>From Matúš Kukan : Matúš Kukan has uploaded a new change for review. Change subject: tubes: init TeleManager in desktop .. tubes: init TeleManager in desktop - register clients only when we run --invisible - create ScDocFuncSend only if we are going to use it Change-Id: I7e33cd5a2e42e34a055146dc6c2bdac3657d6529 --- M desktop/Library_sofficeapp.mk M desktop/inc/app.hxx M desktop/source/app/app.cxx M sc/source/ui/collab/contacts.cxx M tubes/inc/tubes/manager.hxx M tubes/source/manager.cxx 6 files changed, 90 insertions(+), 51 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/336/1 -- To view, visit https://gerrit.libreoffice.org/336 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e33cd5a2e42e34a055146dc6c2bdac3657d6529 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matúš Kukan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-commits] .: 3 commits - sc/source tubes/inc tubes/Library_tubes.mk tubes/source
On Friday 20 of July 2012, Matus Kukan wrote:
> sc/source/ui/collab/contacts.cxx |8 ---
> sc/source/ui/collab/sendfunc.cxx | 82
> +--
> sc/source/ui/collab/sendfunc.hxx | 1
> tubes/Library_tubes.mk |4 +
> tubes/inc/tubes/manager.hxx |4 -
> tubes/source/manager.cxx | 47 +++---
> 6 files changed, 48 insertions(+), 98 deletions(-)
...
> +try
> +{
> +css::uno::Reference < css::frame::XComponentLoader > xLoader(
> +::comphelper::getProcessServiceFactory()->createInstance(
> +"com.sun.star.frame.Desktop" ),
> +css::uno::UNO_QUERY_THROW );
> +css::uno::Reference < css::util::XCloseable > xDoc(
> +xLoader->loadComponentFromURL( rStr, "_blank", 0, args ),
> +css::uno::UNO_QUERY_THROW );
> +}
> +catch ( css::uno::Exception& e )
> +{
> +fprintf( stderr, "exception when loading '%s' !\n",
> + rtl::OUStringToOString( e.Message, RTL_TEXTENCODING_UTF8
> ).getStr() );
SAL_WARN
> +}
--
Lubos Lunak
l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/remote' - 2 commits - android/sdremote sd/source
android/sdremote/AndroidManifest.xml
|1
android/sdremote/res/layout/activity_thumbnail.xml
| 13
android/sdremote/res/layout/slide_thumbnail.xml
| 21 +
android/sdremote/res/layout/testlayout.xml
|7
android/sdremote/src/org/libreoffice/impressremote/TestClient.java
| 52 +-
android/sdremote/src/org/libreoffice/impressremote/ThumbnailActivity.java
| 185 ++
android/sdremote/src/org/libreoffice/impressremote/communication/CommunicationService.java
| 12
android/sdremote/src/org/libreoffice/impressremote/communication/Receiver.java
| 72 ++-
android/sdremote/src/org/libreoffice/impressremote/communication/SlideShow.java
| 37 ++
sd/source/ui/inc/Server.hxx
|2
sd/source/ui/remotecontrol/ImagePreparer.cxx
| 154
sd/source/ui/remotecontrol/ImagePreparer.hxx
| 51 ++
sd/source/ui/remotecontrol/Listener.cxx
| 27 +
sd/source/ui/remotecontrol/Listener.hxx
|6
sd/source/ui/remotecontrol/Server.cxx
| 21 -
sd/source/ui/slideshow/slideshow.cxx
|2
sd/source/ui/slideshow/slideshowimpl.cxx
|4
17 files changed, 609 insertions(+), 58 deletions(-)
New commits:
commit d4098f9eabb29e470890139f6679be445c016896
Author: Andrzej J. R. Hunt
Date: Fri Jul 20 17:50:10 2012 +0200
Implemented Thumbnail activity.
Change-Id: I I6de8651f3ed36798ca1cc69765c448b821a819a2
diff --git a/android/sdremote/AndroidManifest.xml
b/android/sdremote/AndroidManifest.xml
index 82cb1be..e136ca3 100644
--- a/android/sdremote/AndroidManifest.xml
+++ b/android/sdremote/AndroidManifest.xml
@@ -22,6 +22,7 @@
+
\ No newline at end of file
diff --git a/android/sdremote/res/layout/activity_thumbnail.xml
b/android/sdremote/res/layout/activity_thumbnail.xml
new file mode 100644
index 000..068ab78
--- /dev/null
+++ b/android/sdremote/res/layout/activity_thumbnail.xml
@@ -0,0 +1,13 @@
+
+http://schemas.android.com/apk/res/android";
+android:id="@+id/thumbnail_grid"
+android:layout_width="fill_parent"
+android:layout_height="fill_parent"
+android:columnWidth="90dp"
+android:gravity="center"
+android:horizontalSpacing="10dp"
+android:numColumns="auto_fit"
+android:stretchMode="columnWidth"
+android:verticalSpacing="10dp" >
+
+
\ No newline at end of file
diff --git a/android/sdremote/res/layout/slide_thumbnail.xml
b/android/sdremote/res/layout/slide_thumbnail.xml
new file mode 100644
index 000..448b3ed
--- /dev/null
+++ b/android/sdremote/res/layout/slide_thumbnail.xml
@@ -0,0 +1,21 @@
+
+http://schemas.android.com/apk/res/android";
+android:layout_width="match_parent"
+android:layout_height="match_parent"
+android:orientation="vertical" >
+
+
+
+
+
+
\ No newline at end of file
diff --git a/android/sdremote/res/layout/testlayout.xml
b/android/sdremote/res/layout/testlayout.xml
index 8e7a4f1..4f0b065 100644
--- a/android/sdremote/res/layout/testlayout.xml
+++ b/android/sdremote/res/layout/testlayout.xml
@@ -25,6 +25,13 @@
android:layout_gravity="center_horizontal"
android:text="Previous" />
+
+
parent, View v, int
position,
+ long id) {
+
mCommunicationService.getTransmitter().gotoSlide(position);
+ }
+ }
+
+ // MESSAGE HANDLER
+ protected class MessageHandler extends Handler {
+ @Override
+ public void handleMessage(Message aMessage) {
+ Bundle aData = aMessage.getData();
+ switch (aMessage.what) {
+ case CommunicationService.MSG_SLIDE_CHANGED:
+ int aSlide = aData.getInt("slide_number");
+ setSelected(aSlide);
+ break;
+ case CommunicationService.MSG_SLIDE_PREVIEW:
+ // int aNSlide = aData.getInt("slide_number");
+ mGrid.invalidateViews();
+ break;
+
+ }
+ }
+ }
+
+ // - THUMBNAIL ADAPTER
+ protected class ThumbnailAdapter extends
[Libreoffice-commits] .: 3 commits - sc/source tubes/inc tubes/Library_tubes.mk tubes/source
sc/source/ui/collab/contacts.cxx |8 ---
sc/source/ui/collab/sendfunc.cxx | 82 +--
sc/source/ui/collab/sendfunc.hxx |1
tubes/Library_tubes.mk |4 +
tubes/inc/tubes/manager.hxx |4 -
tubes/source/manager.cxx | 47 +++---
6 files changed, 48 insertions(+), 98 deletions(-)
New commits:
commit 6f606f8064d8dc7daa60960151da71943361d394
Author: Matúš Kukan
Date: Fri Jul 20 15:35:27 2012 +0200
tubes: remove unused parameters
Change-Id: Ia1c683f5b9245d1673a610901636921619f47406
diff --git a/tubes/source/manager.cxx b/tubes/source/manager.cxx
index e43612c..f6642f2 100644
--- a/tubes/source/manager.cxx
+++ b/tubes/source/manager.cxx
@@ -135,7 +135,7 @@ void TeleManager::DBusChannelHandler(
SAL_INFO( "tubes", "accepting");
aAccepted = true;
-TeleConference* pConference = new TeleConference( pManager,
pAccount, TP_DBUS_TUBE_CHANNEL( pChannel ), createUuid() );
+TeleConference* pConference = new TeleConference( pManager,
pAccount, TP_DBUS_TUBE_CHANNEL( pChannel ) );
pConference->acceptTube();
pManager->addConference( pConference );
}
@@ -207,10 +207,8 @@ SAL_DLLPUBLIC_EXPORT void TeleManager_fileReceived( const
rtl::OUString &rStr )
}
}
-void TeleManager::TransferDone( EmpathyFTHandler *handler,
TpFileTransferChannel *, gpointer pUserData)
+void TeleManager::TransferDone( EmpathyFTHandler *handler,
TpFileTransferChannel *, gpointer )
{
-TeleManager* pManager = reinterpret_cast(pUserData);
-
SAL_INFO( "tubes", "TeleManager::TransferDone: hooray!");
GFile *gfile = empathy_ft_handler_get_gfile( handler);
char *uri = g_file_get_uri( gfile);
@@ -538,7 +536,7 @@ bool TeleManager::registerClients()
getFullClientName().getStr(), // name
TRUE, // uniquify to get
a different bus name to the main client, above
TeleManager_FileTransferHandler,// callback
-this, // user_data
+this, // user_data,
unused
NULL// destroy
);
tp_base_client_take_handler_filter( pImpl->mpFileTransferClient,
commit baa7114906108b655f09fcd6d6c593d3212967bb
Author: Matúš Kukan
Date: Fri Jul 20 15:17:44 2012 +0200
tubes: clean up commented out code, headers
Change-Id: I5962fb38d2320199e9c45c6f339131755f817960
diff --git a/tubes/inc/tubes/manager.hxx b/tubes/inc/tubes/manager.hxx
index 21ee3c3..f495c24 100644
--- a/tubes/inc/tubes/manager.hxx
+++ b/tubes/inc/tubes/manager.hxx
@@ -39,7 +39,6 @@
#include
#include
#include
-#include
// For testing purposes, we might need more in future.
#define LIBO_TUBES_DBUS_INTERFACE "org.libreoffice.calc"
diff --git a/tubes/source/manager.cxx b/tubes/source/manager.cxx
index c7ef062..e43612c 100644
--- a/tubes/source/manager.cxx
+++ b/tubes/source/manager.cxx
@@ -28,24 +28,17 @@
#include "tubes/manager.hxx"
#include "tubes/constants.h"
-#include
-#include
-#include
-#include
-// new file send/recv fun ...
#include
-#include
-#include
-#include
-#include
-#include
-#include
#include
#include
#include
-#include
#include
+#include
+#include
+#include
+#include
+#include
namespace css = ::com::sun::star;
@@ -193,42 +186,10 @@ SAL_DLLPUBLIC_EXPORT void TeleManager_fileReceived( const
rtl::OUString &rStr )
fprintf( stderr, "incoming file '%s'\n",
rtl::OUStringToOString( rStr, RTL_TEXTENCODING_UTF8 ).getStr() );
-// using the frame::XLoadable interface fails with a
DoubleInitializationException
-/*css::uno::Sequence < css::beans::PropertyValue > aLoadArgs(5);
-aLoadArgs[0].Name = rtl::OUString( "URL" );
-aLoadArgs[0].Value <<= rpStr;
-aLoadArgs[1].Name = rtl::OUString( "FilterName" );
-aLoadArgs[1].Value <<= rtl::OUString( "calc8" );
-aLoadArgs[2].Name = rtl::OUString( "Referer" );
-aLoadArgs[2].Value <<= rtl::OUString( "" );
-// no interaction handler ?
-aLoadArgs[3].Name = rtl::OUString( "MacroExecutionMode" );
-aLoadArgs[3].Value <<= sal_Int32( 3 );
-aLoadArgs[4].Name = rtl::OUString( "UpdateDocMode" );
-aLoadArgs[4].Value <<= sal_Int32( 2 );
-try
-{
-css::uno::Reference < css::frame::XLoadable > xLoad(
-rDocShell.GetBaseModel(), css::uno::UNO_QUERY_THROW );
-xLoad->load( aLoadArgs );
-}
-catch ( css::uno::Exception& e )
-{
-fprintf( stderr, "exception when loading '%s' !\n",
- rtl::OUStringToOString( e.Message, RTL_TEXTENCODING_UTF8
).getStr() );
- } */
-// #2 - tried out the SfxAutoReloadTimer_Impl - shove stuff at the SID_RELOAD
slot ...
-
-// #3 - can we use the f
Re: Changes needed for "LibreOffice 4"
On Fri, 2012-07-20 at 19:59 +0200, Lubos Lunak wrote: > By the way, could somebody please confirm this or list the things where we > do > need to care about stability to the outside world? I know ure/source/README > has a list of libraries, but this is not only about libraries. In the worst case, documents contain StarBasic macros that do the oddest things using the most tangled UNO APIs you can think of :-) Including FooInterface7 - the 7th attempt to get it right, highlighting again the lack of a need for fundamental extensibility ;-) The IDL is also compiled into JAR files that are necessary to link Java plugins; configuration keys are also part of the ABI; and ideally the behaviour is also predictable. Of course, most of this is a myth; the chart2 re-write had some very substantial changes to the UNO object model built-in, and IIRC almost no-one complained: then again chart2 was much prettier than chart1 so ... perhaps that's why. The real problem is, that there's no good way of telling what UNO / C++ interfaces people are actually using in their binary / proprietary extensions. Unfortunately (apparently) there is no signature that we can unwind from use of an interface - though that could be altered for the future. That result still amazes me - surely there is some in-lined class / type information somewhere. Eike's idea of running 'strings' on a few binary exensions seems like a great one - if we have a bazillion duplicate ::com::sun::star's in our binaries, surely others must have been infected too ;-) Then again - how much sympathy for the proprietary world we should have is unclear. Then again - some binary proprietary plugins are indispensable to some segments - eg. Quebec has some great French / grammer checker to help those french-as-a-second-language writers, or in Germany the Dudencorrector seems popular etc. etc. But - yes, getting hard numbers; and better hard lists of which interfaces are actually used out in the wild would be awesomely useful when making this sort of decision :-) Any help collecting that is -much- appreciated. ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-6-0] updated tango artwork ...
Hi, On Thursday, 2012-07-19 17:57:49 +0100, Michael Meeks wrote: > all looks good to me, though the sendmail icon is a tad cute :-) I couldn't tell what it is if I didn't know the file name. Anyhow, no cows, no dogs, no middle fingers.. have my sign-off. 1 more needed. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpmf8ULr2UUT.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED 3-6-0] resolved fdo#52205 do not force all text cells in CSV import
On Fri, 2012-07-20 at 19:49 +0100, Michael Meeks wrote: > And +1 from me; we need one more I guess. Just saw Markus' mail, Pushed, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6-0' - sc/source
sc/source/ui/docshell/impex.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9581ccc83e472d17f10051b7cc9e6b5f36f120ce Author: Eike Rathke Date: Thu Jul 19 18:10:49 2012 +0200 resolved fdo#52205 do not force all text cells in CSV import Do not set ScSetStringParam::mbSetTextCellFormat=true for SetString() that slightly changed behavior, the nColFormat==SC_COL_TEXT case is handled separately anyway. Change-Id: I0a0f9472801dcb02af77d6eaf90170309a41e9a8 Signed-off-by: Kohei Yoshida Signed-off-by: Markus Mohrhard Signed-off-by: Michael Meeks diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx index e98c67b..50333f8 100644 --- a/sc/source/ui/docshell/impex.cxx +++ b/sc/source/ui/docshell/impex.cxx @@ -1227,7 +1227,7 @@ static bool lcl_PutString( ScSetStringParam aParam; aParam.mpNumFormatter = pFormatter; aParam.mbDetectNumberFormat = bDetectNumFormat; -aParam.mbSetTextCellFormat = true; +aParam.mbSetTextCellFormat = false; aParam.mbHandleApostrophe = false; pDoc->SetString( nCol, nRow, nTab, rStr, &aParam ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 4 commits - sc/inc sc/qa sc/source
sc/inc/orcus/csv_parser.hpp |3 +
sc/qa/unit/data/contentCSV/conditionalFormatting.csv |4 +-
sc/qa/unit/data/contentCSV/information-functions.csv | 32 +-
sc/qa/unit/data/contentCSV/logical-functions.csv |8 ++--
sc/qa/unit/data/contentCSV/mathematical-functions.csv | 26 +++---
sc/qa/unit/data/contentCSV/numberFormat.csv | 10 ++---
sc/qa/unit/data/contentCSV/spreadsheet-functions.csv |8 ++--
sc/qa/unit/helper/qahelper.hxx|1
sc/qa/unit/subsequent_filters-test.cxx|2 -
sc/source/core/data/column2.cxx | 11 +++---
10 files changed, 53 insertions(+), 52 deletions(-)
New commits:
commit 58d4ab69112ca1e1125b59a908fc48bb2f92c08f
Author: Markus Mohrhard
Date: Fri Jul 20 20:57:43 2012 +0200
adapt csv parser, don't trim whitespaces
Change-Id: Iff43b5971bbbd2fd31e7dac5e99f2c94c5d75f4c
diff --git a/sc/qa/unit/data/contentCSV/conditionalFormatting.csv
b/sc/qa/unit/data/contentCSV/conditionalFormatting.csv
index 6b43e46..ac8d212 100644
--- a/sc/qa/unit/data/contentCSV/conditionalFormatting.csv
+++ b/sc/qa/unit/data/contentCSV/conditionalFormatting.csv
@@ -1,2 +1,2 @@
--$2,$0, 1 1/5, 1.23E+004
-05:35, 0.00 USD, 1500%, 01/02/00
+-$2,$0,1 1/5,1.23E+004
+05:35,0.00 USD,1500%,01/02/00
diff --git a/sc/qa/unit/data/contentCSV/information-functions.csv
b/sc/qa/unit/data/contentCSV/information-functions.csv
index e332b8f..660c910 100644
--- a/sc/qa/unit/data/contentCSV/information-functions.csv
+++ b/sc/qa/unit/data/contentCSV/information-functions.csv
@@ -1,18 +1,18 @@
-27, 1, 4, $E$1, $Logical.$A$1, 4, b, v, l
+27,1,4,$E$1,$Logical.$A$1,4,b,v,l
6
-"=CELL(""ROW"",AA1)", "=ADDRESS(2,3)"
-FALSE, TRUE, FALSE
-FALSE, TRUE, FALSE, TRUE
-TRUE, FALSE, TRUE, TRUE
-1, 0, 0, 1
-TRUE, FALSE, FALSE
-FALSE, FALSE, FALSE, TRUE
-TRUE, FALSE, FALSE, FALSE
-TRUE, TRUE, FALSE
-TRUE, FALSE, TRUE
-1, 0, 0, 1, 0
-TRUE, TRUE, FALSE, FALSE, FALSE, FALSE
-FALSE, TRUE, FALSE, TRUE
-0, 1, 42, 0
+"=CELL(""ROW"",AA1)","=ADDRESS(2,3)"
+FALSE,TRUE,FALSE
+FALSE,TRUE,FALSE,TRUE
+TRUE,FALSE,TRUE,TRUE
+1,0,0,1
+TRUE,FALSE,FALSE
+FALSE,FALSE,FALSE,TRUE
+TRUE,FALSE,FALSE,FALSE
+TRUE,TRUE,FALSE
+TRUE,FALSE,TRUE
+1,0,0,1,0
+TRUE,TRUE,FALSE,FALSE,FALSE,FALSE
+FALSE,TRUE,FALSE,TRUE
+0,1,42,0
#N/A
-1, 2, 8, 64, 16
+1,2,8,64,16
diff --git a/sc/qa/unit/data/contentCSV/logical-functions.csv
b/sc/qa/unit/data/contentCSV/logical-functions.csv
index 2223baf..fd348f7 100644
--- a/sc/qa/unit/data/contentCSV/logical-functions.csv
+++ b/sc/qa/unit/data/contentCSV/logical-functions.csv
@@ -1,6 +1,6 @@
-FALSE, FALSE, FALSE, TRUE, FALSE
+FALSE,FALSE,FALSE,TRUE,FALSE
FALSE
-TRUE, FALSE
-TRUE, FALSE
-FALSE, TRUE, TRUE, TRUE, TRUE
+TRUE,FALSE
+TRUE,FALSE
+FALSE,TRUE,TRUE,TRUE,TRUE
TRUE
diff --git a/sc/qa/unit/data/contentCSV/mathematical-functions.csv
b/sc/qa/unit/data/contentCSV/mathematical-functions.csv
index cebf207..639bc2e 100644
--- a/sc/qa/unit/data/contentCSV/mathematical-functions.csv
+++ b/sc/qa/unit/data/contentCSV/mathematical-functions.csv
@@ -1,20 +1,20 @@
-0, 1, 10
-0.5, 0, 1
-0, Err:502
-0.5, 0.75, 0.25
+0,1,10
+0.5,0,1
+0,Err:502
+0.5,0.75,0.25
3.1415926536
1,1,3,-3,-5,5
0,2,12,-4,-6,4
-4, Err:502, Err:502
-14, Err:502
-10, Err:502
-3, 48
-48, 3
-0.7071067812, "0.00"
-0.7071067812, -1
+4,Err:502,Err:502
+14,Err:502
+10,Err:502
+3,48
+48,3
+0.7071067812,"0.00"
+0.7071067812,-1
8
12
5
-"1.2", "1", "0", "1000"
-2, 4, Err:502
+"1.2","1","0","1000"
+2,4,Err:502
diff --git a/sc/qa/unit/data/contentCSV/numberFormat.csv
b/sc/qa/unit/data/contentCSV/numberFormat.csv
index 8120173..001d70f 100644
--- a/sc/qa/unit/data/contentCSV/numberFormat.csv
+++ b/sc/qa/unit/data/contentCSV/numberFormat.csv
@@ -1,6 +1,6 @@
-2.00, -3.00
-40.10%, -22%
-"$12,345.00", "-$1,234.00"
-2.59E+005, -2.35E+03
+2.00,-3.00
+40.10%,-22%
+"$12,345.00","-$1,234.00"
+2.59E+005,-2.35E+03
25 31/82
-FALSE, TRUE
+FALSE,TRUE
diff --git a/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv
b/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv
index 83a33b2..6dbc97a 100644
--- a/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv
+++ b/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv
@@ -1,4 +1,4 @@
-$C$2, $A$1, Sheet.B$2, Sheet!R2C2
-2, 4, 4, 5, 6, 15, 15, 6, 9
-1, 3, 4, 4, 2, 2
-2, 4, 7, 8, 4
+$C$2,$A$1,Sheet.B$2,Sheet!R2C2
+2,4,4,5,6,15,15,6,9
+1,3,4,4,2,2
+2,4,7,8,4
diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx
index 0974e70..e29415c 100644
--- a/sc/qa/unit/helper/qahelper.hxx
+++ b/sc/qa/unit/helper/qahelper.hxx
@@ -78,6 +78,7 @@ void testFile(rtl::OUString& aFileName, ScDocument* pDoc,
SCTAB nTab, StringType
aConfig.delimiters.push_back(',');
aConfig.delimiters.push_back(';');
aConfig.text_qualifier = '"';
+aConfig.trim_cell_value = false;
std::string aContent;
commit dbad63f5a48b037c0187ea63888bd43a42796917
Author: Markus Mohrhard
Date
Re: What is bibisect? And what is it doing in my office?
On Thu, 2012-07-19 at 15:13 +0200, Michael Stahl wrote: > > It does indeed... I got thrown-off by the ominous "FIXME: linkoo > > currently does not work on Mac OS X" message at the end :-) > > then again there are people that claim "linkoo" doesn't work on any > platform, because it's broken by design :) Hah :-) they are presumably the people who havn't noticed that it's saved a huge amount of time and pain for large numbers of hackers who prefer to use a "broken by design" solution that substantially works, instead of a "perfect but non-existent" solution that appears even harder to use ;-> The perfect is always the enemy of the good, and I for one don't have much sympathy with the argument that the good is the enemy of the perfect => we shouldn't do anything good ;-) But that's just me of course ;-) ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
ScSetStringParam::mbSetTextCellFormat (was: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import)
Hi Kohei, On Friday, 2012-07-20 09:25:54 -0400, Kohei Yoshida wrote: > The old behavior for ScSetStringParam::mbSetTextCellFormat was > somewhat confusing and there was a reason for that. I now slightly > changed the behavior of that flag and you commit kept that new > behavior. I inspected places where mbSetTextCellFormat is used and in sc/source/filter/rtf/eeimpars.cxx line 334 in ScEEImport::WriteToDocument() the if(bSimple) case looks similar suspicious, that's used for RTF and HTML import. But there's no extra handling for a forced text case as it is in CSV import, so this may be not as easy to fix. I didn't investigate yet deeper, just imported a simple number from HTML, and that indeed gets imported as text now. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpe2vS7nB2Qn.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 3-6-0] resolved fdo#52205 do not force all text cells in CSV import
On Fri, 2012-07-20 at 09:25 -0400, Kohei Yoshida wrote: > Eike wrote: > > Please review and cherry-pick to 3-6 and 3-6-0 > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7dbc768a71ccfb567e3b2979e57d0d1318977cf > > that fixes https://bugs.freedesktop.org/show_bug.cgi?id=52205 > > Pushed to the -3-6 branch with my sign-off. We need 2 more sign-offs > to push this to the -3-6-0 branch (I assume?). And +1 from me; we need one more I guess. Regards, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import
Hey, 2012/7/20 Kohei Yoshida : > On 07/19/2012 12:31 PM, Eike Rathke wrote: >> >> Hi, >> >> Please review and cherry-pick to 3-6 and 3-6-0 >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7dbc768a71ccfb567e3b2979e57d0d1318977cf >> that fixes https://bugs.freedesktop.org/show_bug.cgi?id=52205 > > > I reviewed and tested several csv files and one related pivot table use > case, and it did fix the bug. > > The old behavior for ScSetStringParam::mbSetTextCellFormat was somewhat > confusing and there was a reason for that. I now slightly changed the > behavior of that flag and you commit kept that new behavior. But I couldn't > reproduce the original issue that the old behavior was intended to fix, so I > think it's safe to keep the new behavior. > > Pushed to the -3-6 branch with my sign-off. We need 2 more sign-offs to > push this to the -3-6-0 branch (I assume?). > Looks good to me. One more needed for 3-6-0. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: spurious IDL rebuilds on master fixed now
Hi Michael, On Fri, 2012-07-20 at 20:01 +0200, Michael Stahl wrote: > this week there was a problem on master with the dependencies generated > for IDL files, caused by adding of a "-I." option in an AOO rebase. Thanks for finding & fixing that ! :-) > this is fixed now on master with 7c10706845e3b2924152c831b35a458078dc274f. Much appreciated, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
Hi Thorsten, On Friday, 2012-07-20 19:03:41 +0200, Thorsten Behrens wrote: > Lubos Lunak wrote: > > Hmm. That makes it something we should take into consideration then, but > > that > > consideration may be quickly over with saying that it's internal API and as > > such we don't care about people who abuse it. > > > There's more nuance required here I think. Substantial use of > "unstable" API still leaves us with noticeable repercussions on the > extension ecosystem, that we might want to have *once*, and not > spread over multiple releases. Well, an API not being marked as published exactly tells authors that the piece may change or go away at any given time, not bound to any major release or whatsoever. But it should be possible to determine at least vaguely the clear text names of services, interfaces and properties an extension uses so maybe we could setup some "scan your extension" service where one can throw an extension in and get a list of API used and maybe split in sections stable, unstable and questionable ... Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpWUYMOC2pHZ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE
THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 4db7926f578e41a23b4161e1fc309459e2409e4b Author: Bjoern Michaelsen Date: Fri Jul 20 20:15:08 2012 +0200 rewording diff --git a/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE b/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE index d18029b..270618f 100644 --- a/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE +++ b/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE @@ -1,6 +1,6 @@ -There are claims that this repository has been migrated to: +The main work on the website has been migrated to: http://github.com/tdf/ -Which sadly excludes all the existing developers from being -able to easily commit to, and help out with website tasks. +interested newcomers should find it there and are invited in helping the +project! ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 50679, which changed state. Bug 50679 Summary: EDITING: Copying cell(s) with conditional formatting CRASH when paste https://bugs.freedesktop.org/show_bug.cgi?id=50679 What|Old Value |New Value Resolution||FIXED Status|REOPENED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
spurious IDL rebuilds on master fixed now
this week there was a problem on master with the dependencies generated for IDL files, caused by adding of a "-I." option in an AOO rebase. this has caused spurious re-builds of all IDL files, which can happen during "make subsequentcheck" and will cause that to fail variously. this is fixed now on master with 7c10706845e3b2924152c831b35a458078dc274f. if you have a source tree on a revision from ~Tuesday to before the fix, to get correct dependencies after pulling, do "make udkapi.clean offapi.clean oovbaapi.clean" or i guess simply letting IDL files rebuild themselves spuriously once more should fix it as well :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On Friday 20 of July 2012, Lubos Lunak wrote: > And after all this is done, it should be easier to actually talk about > LO4, because we'll know what the talk is actually about. As for the > technical details (i.e. c) ), we'll need to decide how to handle the > breakages it'll cause for extensions. Note that as extensions use only URE > (right?), affected code is actually relatively small (AFAIK sal/, > salhelper/, cppu/, cppuhelper/, udkapi/ and offapi/, not sure about the last > one). By the way, could somebody please confirm this or list the things where we do need to care about stability to the outside world? I know ure/source/README has a list of libraries, but this is not only about libraries. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: idlc/source
idlc/source/idlccompile.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit 7c10706845e3b2924152c831b35a458078dc274f
Author: Michael Stahl
Date: Fri Jul 20 19:27:44 2012 +0200
idlc: do not use -I., deps need absolute paths
(regression from 63c508e3e86a140e35161c45d2be97779746f6cb)
Change-Id: I03ae2cf6fdb229e26d33ef4611a1495590f90df7
diff --git a/idlc/source/idlccompile.cxx b/idlc/source/idlccompile.cxx
index 5e3d689..68cf263 100644
--- a/idlc/source/idlccompile.cxx
+++ b/idlc/source/idlccompile.cxx
@@ -244,7 +244,6 @@ sal_Int32 compileFile(const OString * pathname)
lCppArgs.push_back("-DIDL");
lCppArgs.push_back("-C");
lCppArgs.push_back("-zI");
-lCppArgs.push_back("-I.");
OStringBuffer cppArgs(256);
Options* pOptions = idlc()->getOptions();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Changes needed for "LibreOffice 4"
On Friday 20 of July 2012, Thorsten Behrens wrote: > Lubos Lunak wrote: > > Hmm. That makes it something we should take into consideration then, but > > that consideration may be quickly over with saying that it's internal API > > and as such we don't care about people who abuse it. > > There's more nuance required here I think. Substantial use of > "unstable" API still leaves us with noticeable repercussions on the > extension ecosystem, that we might want to have *once*, and not > spread over multiple releases. Even if people actually do use our internal APIs, that doesn't mean we have to leave it that way. And that does not necessarily mean hiding it intentionally. If we are going to make the effort to keep those APIs stable, we may as well just make them public. And, in general, if it's likely that some internal APIs might be used from the outside, then we should consider a way of avoiding that. If it's internal, somebody is going to change it somewhen. So we should hide it, or maybe somehow visible mark it as such and add "if you find this useful, contact us about about it public", or so. Being afraid to change internal interfaces just because somebody from the outside might be using that is just lame (incidentally, that's another thing I have experience with). -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 50679, which changed state. Bug 50679 Summary: EDITING: Copying cell(s) with conditional formatting CRASH when paste https://bugs.freedesktop.org/show_bug.cgi?id=50679 What|Old Value |New Value Resolution|FIXED | Status|RESOLVED|REOPENED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On Friday 20 of July 2012, Lubos Lunak wrote: > On Friday 20 of July 2012, Michael Meeks wrote: > > On Fri, 2012-07-20 at 17:20 +0200, Lubos Lunak wrote: > > > Now, if you look at > > > http://wiki.documentfoundation.org/Development/LibreOffice4 , a lot of > > > the stuff there does not belong to the page at all, as it has > > > absolutely nothing to do with any of the above: > > > > Can you edit the page to separate the pieces that you don't believe > > require ABI change from those that do ? > > I can, but I don't think I know enough to know about all of them. I can > mark some as questionable though. Done. I'm rather unsure about a number of them, and I may have misplaced others, so please check. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On 07/20/2012 12:50 PM, Lubos Lunak wrote: - "de-UNO-ize the ODF import and export filters." is a purely internal matter that does not affect anything outside of LO core (or am I wrong here?) that depends on whether crazy people have tried to hook into / use those interfaces from their scripts etc. Anything exposed is scripting / plugin-authors is liable to their random walk attacks of this nature :-) Hmm. That makes it something we should take into consideration then, but that consideration may be quickly over with saying that it's internal API and as such we don't care about people who abuse it. You can remove it from the list. I'm the one who added it because back then we were tasked with listing all major architectural changes of which this was certainly one. But in the end this work doesn't really affect the existing UNO API, and we are already working on that for 3.7 (one of Daniel's GSOC tasks). So, it's safe to remove it IMO. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build light weight conversion binary
Hello, Il 20/07/2012 07:26, Jerry Tan ha scritto: Hi, The company that I work for use LibreOffice as the main word processor. We convert a lot of client letters from doc/docx to open document format. We are on Mac OS X Lion (10.7) btw. We use: soffice --headless --convert-to odt …. to do the batch conversion. The problems with this are: - It takes quite a long time to start up. It becomes a problem when we have to convert many documents. You can try to look at using UNO wrappers like unoconv so you can keep your libo instance running all the time to avoid startup time costs: https://github.com/dagwieers/unoconv There's a long thread in this issue regarding unoconv on MacOS X https://github.com/dagwieers/unoconv/issues/27 hth, riccardo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
Lubos Lunak wrote: > Hmm. That makes it something we should take into consideration then, but > that > consideration may be quickly over with saying that it's internal API and as > such we don't care about people who abuse it. > There's more nuance required here I think. Substantial use of "unstable" API still leaves us with noticeable repercussions on the extension ecosystem, that we might want to have *once*, and not spread over multiple releases. Cheers, -- Thorsten pgp8HIUwZflNv.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Adding bibisect repository support to tinbuild2
On Fri, Jul 20, 2012 at 11:30 AM, Robinson Tryon wrote: > > Now that I've done some testing here, I realize that we need some way > to turn off the push-nightlies step while still enabling the creation > of the bibisect repositories. For example, I don't want to bother with > pushing nightlies, especially when I'm testing my commits locally. To > fix I've reordered the day-checking guts of do_push() so that we do > our nightly check first, then call do_bibisect_push(), then (if > pushing nightlies is enabled), call push_nightlies.sh. Both parts are > included in the same tinbuild "phase," but can be enabled > independently. Yep, Sound good. > >>> I think that all of the git and file operations should run on most >>> *nix systems, including OSX. There might be a couple of tweaks to make >> ... >> But I'm not so much concerned about the git-foo part of the script but >> rather with what is put in bi-bisect. >> make dev-install does not work on all platform and you do not have a >> */opt/* to 'add' . > > Based on the discussion in this thread it sounds like we're pretty > close with an opt/ directory and make dev-install, but we might need > an unpack step for at least OS/Darwin (and maybe for Windows?). To > address these issues (and per suggestion), I've moved the code that > handles finding the opt/ directory, make-install, copying, etc.. into > tinbuild_internals.sh where we can further override it in > platform-specific files such as tinbuild_internals_Darwin.sh. > > On Thu, Jul 19, 2012 at 5:11 AM, Norbert Thiebaud wrote: >> BTW on mac I though that 'mounting' the dmg and then copying the >> content it over the 'artefact' git should do the trick... >> due to a poor upload bandwidth, I did not bother with it so far since >> I cannot afford to operate such bibisect construction on my box (well >> that is If I want to make it available to others) > > The redo-repos.sh script is set up to create two local repos: > 'bibisect-repository' and 'fake-remote'. All of the git operations, > even the so-called "remote" operations, happen locally on your box, so > it's perfect for fast testing (or when you don't have much/any upload > bandwidth! :-) oh! yeah for testing purpose that is fine.. but for production work I cold not afford it. > Norbert -- if you have a OSX buildbot available and can help figure > out the darwin-specific pieces, that would be very helpful. I hope > that all we'll have to do is make a darwin version of > copy_build_into_bibisect_repository(). I've just stubbed-in a basic > version, but I really need a mac to test it on -- see the patches for > details, and let me know what works and what needs fixing :-) Yeah, I think I probably can get away with a small function that mount the dmg, copy the content in the 'artefact' repo and unmount... I'll give it a shoot this WE. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On Fri, Jul 20, 2012 at 06:33:20PM +0200, john malc wrote: > Hi, > I have some ideas : >3. kick Draw and Math-parts out of LO. Either make it as plugin or just >kill it. 1) nobody uses it (Math> Latex; Draw > photoshop, corel, gimp >etc.); Can we see the numbers, please? > 2) installer can be smaller. You _are_ aware of the fact that Math is tiny compared to the other apps in LibreOffice (not mentioning the core libs that _must_ be installed) and that Draw shares practically all of its code with Impress, are you? D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
john malc wrote: > I have some ideas : > Again the reminder that ideas or discussions _without_ any intention to work on them *in the code*, are off-topic here. Please move them to disc...@documentfoundation.org (subscribe via email to discuss+subscr...@documentfoundation.org). Thanks for keeping this list focused, -- Thorsten pgpFoPz97vHOx.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On Friday 20 of July 2012, Michael Meeks wrote: > On Fri, 2012-07-20 at 17:20 +0200, Lubos Lunak wrote: > > Now, if you look at > > http://wiki.documentfoundation.org/Development/LibreOffice4 , a lot of > > the stuff there does not belong to the page at all, as it has absolutely > > nothing to do with any of the above: > > Can you edit the page to separate the pieces that you don't believe > require ABI change from those that do ? I can, but I don't think I know enough to know about all of them. I can mark some as questionable though. > > - "de-UNO-ize the ODF import and export filters." is a purely internal > > matter that does not affect anything outside of LO core (or am I wrong > > here?) > > that depends on whether crazy people have tried to hook into / use > those interfaces from their scripts etc. Anything exposed is scripting / > plugin-authors is liable to their random walk attacks of this nature :-) Hmm. That makes it something we should take into consideration then, but that consideration may be quickly over with saying that it's internal API and as such we don't care about people who abuse it. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On Friday 20 of July 2012, john malc wrote: > Hi, > I have some ideas : > >1. *rewrite whole LO* (writer, base etc.) from scratch, which would make >all documents unable to open in 3.x. This is very important task, mainly >because of MS Office and the future of LO. The whole thing with plugins >should be same as with documents. >2. make a very long period of testing (beta1/2/3,rc1/2/3/ and then >stable 4.0). Even longer then we have know. I think we should release > 4.0 with almost no bugs. >3. kick Draw and Math-parts out of LO. Either make it as plugin or just >kill it. 1) nobody uses it (Math> Latex; Draw > photoshop, corel, gimp >etc.); 2) installer can be smaller. You are welcome to start your own office suite from scratch, but if you actually do, you'll soon find out that it'll take you ages to get anywhere near to what LibreOffice is now. I didn't mention it explicitly, but since this is a development list, I expect discussion about what _realistically_ can be done. If you want just to post some random unfounded ideas on which you are not going to actually work, please take it elsewhere, such as the discuss list. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On Fri, Jul 20, 2012 at 06:33:20PM +0200, john malc wrote: >1. *rewrite whole LO* I know, it's Friday, but still... ;-) Some reading: http://www.joelonsoftware.com/articles/fog69.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Adding new label's format
Hi Sylvain, On Fri, 2012-07-20 at 16:06 +0200, Info Agipa wrote: > I'm working for a labels manufaturer and I would like to add our format in > libreoffice. > We have customers who have asked for it in the past. Great. > How is the best way to perform this ? > I found in the past that all informations are in a xml file (don't remember > where now). > There is a description of this file to give the good informations ? See: officecfg/registry/data/org/openoffice/Office/Labels.xcu Winfried did some lovely work recently to improve label layout which made this more powerful, he'd be the best guy for a documentation pointer here I suspect. Ultimately, we'd love a patch with an explicit MPL/LGPLv3+ license for all your submissions that we can link into: http://wiki.documentfoundation.org/Development/Developers Many thanks in advance for your contribution :-) ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 3-6-0] fdo#52240 added abbreviated date acceptance patterns for [de-{AT,CH,LI,LU}]
On Fri, 2012-07-20 at 17:55 +0200, Eike Rathke wrote: > Please review and cherry-pick to 3-6 and 3-6-0 the no-brainer > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d0d840c27943f976fd59a673f2de84a10ea475c9 You're the expert here; it looks save on the surface, and presumably hurts only German speakers so ... ;-) As it's picked to -3-6 already, you have an extra +1 for 3.6.0 from me, Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On 20/07/12 18:27, Randolph D. wrote: > ok michael, you wrote friendly, so all ideas given. but I wounder why > Lubos is allowed to write about a marketing brainstorming :-) Lubos writes about _what_? On 20/07/12 17:20, Lubos Lunak wrote: > a) for marketing reasons [...] > > As a) is not technical at all, there's not much point in discussing it on a > development list. If that needs to be done, we stamp "4" on it and it's done. please learn to read. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
Hi, I have some ideas : 1. *rewrite whole LO* (writer, base etc.) from scratch, which would make all documents unable to open in 3.x. This is very important task, mainly because of MS Office and the future of LO. The whole thing with plugins should be same as with documents. 2. make a very long period of testing (beta1/2/3,rc1/2/3/ and then stable 4.0). Even longer then we have know. I think we should release 4.0 with almost no bugs. 3. kick Draw and Math-parts out of LO. Either make it as plugin or just kill it. 1) nobody uses it (Math> Latex; Draw > photoshop, corel, gimp etc.); 2) installer can be smaller. -- @Malcjohn ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Adding bibisect repository support to tinbuild2
(updating subject line) On Wed, Jul 18, 2012 at 6:45 PM, Norbert Thiebaud wrote: >>> >>> + I'd like not to create a new step for that but to fold it in the 'push' >>> step >> >> For clarity I'll keep the bulk of the code factored-out into a >> separate function, but I'll have that function called from within >> do_push(). > > Yep, that is fine. Now that I've done some testing here, I realize that we need some way to turn off the push-nightlies step while still enabling the creation of the bibisect repositories. For example, I don't want to bother with pushing nightlies, especially when I'm testing my commits locally. To fix I've reordered the day-checking guts of do_push() so that we do our nightly check first, then call do_bibisect_push(), then (if pushing nightlies is enabled), call push_nightlies.sh. Both parts are included in the same tinbuild "phase," but can be enabled independently. >> I think that all of the git and file operations should run on most >> *nix systems, including OSX. There might be a couple of tweaks to make > ... > But I'm not so much concerned about the git-foo part of the script but > rather with what is put in bi-bisect. > make dev-install does not work on all platform and you do not have a > */opt/* to 'add' . Based on the discussion in this thread it sounds like we're pretty close with an opt/ directory and make dev-install, but we might need an unpack step for at least OS/Darwin (and maybe for Windows?). To address these issues (and per suggestion), I've moved the code that handles finding the opt/ directory, make-install, copying, etc.. into tinbuild_internals.sh where we can further override it in platform-specific files such as tinbuild_internals_Darwin.sh. On Thu, Jul 19, 2012 at 5:11 AM, Norbert Thiebaud wrote: > BTW on mac I though that 'mounting' the dmg and then copying the > content it over the 'artefact' git should do the trick... > due to a poor upload bandwidth, I did not bother with it so far since > I cannot afford to operate such bibisect construction on my box (well > that is If I want to make it available to others) The redo-repos.sh script is set up to create two local repos: 'bibisect-repository' and 'fake-remote'. All of the git operations, even the so-called "remote" operations, happen locally on your box, so it's perfect for fast testing (or when you don't have much/any upload bandwidth! :-) Here's how I create the repos and test the system: (in the LO checkout) ../buildbot/bin/redo-repos.sh ../buildbot/bin/tinbuild2 -0vx -m debug -p bob Norbert -- if you have a OSX buildbot available and can help figure out the darwin-specific pieces, that would be very helpful. I hope that all we'll have to do is make a darwin version of copy_build_into_bibisect_repository(). I've just stubbed-in a basic version, but I really need a mac to test it on -- see the patches for details, and let me know what works and what needs fixing :-) Cheers, --R 0001-Bibisect-Add-support-for-bibisect-repository-integra.patch.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build light weight conversion binary
Jerry, Michael, Il 20/07/2012 18:04, Michael Stahl ha scritto: On Thu, 2012-07-19 at 22:26 -0700, Jerry Tan wrote: So my boss asked me to fix these 2 issues. I managed to build the source code on Mac OS X Lion and then try to see what's going on (unfortunately specifying --headless fail to build). do you mean the configure "--enable-headless" option? that is very experimental and know to build only on the system of the guy who added it :) Last time i checked the 3.6 branch it was building fine for linux, can you share any details on the configuration that is failing? thanks, riccardo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
On Fri, 2012-07-20 at 17:20 +0200, Lubos Lunak wrote: > Now, if you look at > http://wiki.documentfoundation.org/Development/LibreOffice4 , a lot of the > stuff there does not belong to the page at all, as it has absolutely nothing > to do with any of the above: Can you edit the page to separate the pieces that you don't believe require ABI change from those that do ? > - "de-UNO-ize the ODF import and export filters." is a purely internal matter > that does not affect anything outside of LO core (or am I wrong here?) that depends on whether crazy people have tried to hook into / use those interfaces from their scripts etc. Anything exposed is scripting / plugin-authors is liable to their random walk attacks of this nature :-) > Summary: > - it needs to be said what we expect from "LibreOffice4" Very true; I've used it to refer to the ABI breakage we've been needing for a long time to cleanup our accumulating cruft issues. > - the wiki page with technical tasks needs to be cleaned up It'd be great if you could do that separation :-) please don't delete anything though - some tasks are rather succinct but useful to retain. > - we need to decide how to deal with the fact that LO4 will break backwards > compatibility Of course, we need some good technical ideas. In particular, I'd love some stub / skel libraries and clever bridging with old names to rid us of the com::sun::star evils ;-) ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 added abbreviated date acceptance patterns for [de-{AT,CH,LI,LU}]
Hey, 2012/7/20 Eike Rathke : > Hi, > > Please review and cherry-pick to 3-6 and 3-6-0 the no-brainer > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d0d840c27943f976fd59a673f2de84a10ea475c9 > Looks good. Pushed into 3-6. Two more reviews needed for 3-6-0. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Changes needed for "LibreOffice 4"
ok michael, you wrote friendly, so all ideas given. but I wounder why Lubos is allowed to write about a marketing brainstorming :-) 2012/7/20 Michael Meeks : ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - i18npool/source
i18npool/source/localedata/data/de_AT.xml |1 +
i18npool/source/localedata/data/de_CH.xml |1 +
i18npool/source/localedata/data/de_LI.xml |1 +
i18npool/source/localedata/data/de_LU.xml |1 +
4 files changed, 4 insertions(+)
New commits:
commit 41306f222d7f3aa3fedcd2a9a91fd7558449a24e
Author: Eike Rathke
Date: Fri Jul 20 17:51:39 2012 +0200
fdo#52240 added abbreviated date acceptance patterns for [de-{AT,CH,LI,LU}]
Change-Id: I589cedcd2db0208b03d1e28babbb493912f20c78
diff --git a/i18npool/source/localedata/data/de_AT.xml
b/i18npool/source/localedata/data/de_AT.xml
index dde647e..69e93fc 100644
--- a/i18npool/source/localedata/data/de_AT.xml
+++ b/i18npool/source/localedata/data/de_AT.xml
@@ -35,6 +35,7 @@
metric
+D.M.
Standard
diff --git a/i18npool/source/localedata/data/de_CH.xml
b/i18npool/source/localedata/data/de_CH.xml
index 7349e04..772e004 100644
--- a/i18npool/source/localedata/data/de_CH.xml
+++ b/i18npool/source/localedata/data/de_CH.xml
@@ -38,6 +38,7 @@
metric
+D.M.
Standard
diff --git a/i18npool/source/localedata/data/de_LI.xml
b/i18npool/source/localedata/data/de_LI.xml
index 6e320b1..4abcc9e 100644
--- a/i18npool/source/localedata/data/de_LI.xml
+++ b/i18npool/source/localedata/data/de_LI.xml
@@ -35,6 +35,7 @@
metric
+D.M.
Standard
diff --git a/i18npool/source/localedata/data/de_LU.xml
b/i18npool/source/localedata/data/de_LU.xml
index dc733c2..69a50bd 100644
--- a/i18npool/source/localedata/data/de_LU.xml
+++ b/i18npool/source/localedata/data/de_LU.xml
@@ -35,6 +35,7 @@
metric
+D.M.
Standard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/source
sw/source/core/unocore/unofield.cxx |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
New commits:
commit c69bd0ead5852967492046caa311732ebe549a7c
Author: Miklos Vajna
Date: Fri Jul 20 18:25:06 2012 +0200
SwXTextField::attachToRange: avoid unnecessary dynamic_cast
Change-Id: I76aab7b0405db206fa03e03021ac872fc435eec2
diff --git a/sw/source/core/unocore/unofield.cxx
b/sw/source/core/unocore/unofield.cxx
index 1b14610..957cb6b 100644
--- a/sw/source/core/unocore/unofield.cxx
+++ b/sw/source/core/unocore/unofield.cxx
@@ -1766,12 +1766,8 @@ void SwXTextField::attachToRange(
// The fieldmark always has a (generated) name.
pPostItField->SetName(pFieldmark->GetName());
else
-{
// The field has a name already, use it.
-sw::mark::MarkBase* pMarkBase =
dynamic_cast(pFieldmark);
-if (pMarkBase)
-pMarkBase->SetName(pPostItField->GetName());
-}
+pMarksAccess->renameMark(pFieldmark,
pPostItField->GetName());
// Make sure we always insert the field at the end
SwPaM aEnd(*aPam.End(), *aPam.End());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Changes needed for "LibreOffice 4"
Hi Randolph, On Fri, 2012-07-20 at 17:29 +0200, Randolph D. wrote: > For me the 4 Version would be different from other versions, if the > office suite includes a browser and a messenger This is a developer list. Please move this suggestion to the discuss list. It is fine to have vision & suggestions of this kind - as long as they are backed by real code, patches etc. :-) This is the 2nd time I've had to write essentially the same mail on exactly this topic to you in the same week. I love your idea - as long as it is backed by the hard-work required to produce the code, to make it happen :-) Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/core/doc/docedt.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit f573b16e7b4909d5cae129cc00f50be4b06b468d
Author: Miklos Vajna
Date: Fri Jul 20 18:17:42 2012 +0200
SwDoc::DeleteRangeImplImpl: don't touch fieldmarks when undo is not
available
Change-Id: Ia7fa4510a874a518c8bff3614a38425ee7802ad8
diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx
index 5ae2ab6..f1dedb3 100644
--- a/sw/source/core/doc/docedt.cxx
+++ b/sw/source/core/doc/docedt.cxx
@@ -1642,8 +1642,8 @@ bool SwDoc::DeleteRangeImplImpl(SwPaM & rPam)
}
}
-// Delete fieldmarks before postits.
-if (pStt->nNode == pEnd->nNode && (pEnd->nContent.GetIndex() -
pStt->nContent.GetIndex()) == 1)
+// Delete fieldmarks before postits, but let's leave them alone during
import.
+if (GetIDocumentUndoRedo().DoesUndo() && pStt->nNode == pEnd->nNode &&
(pEnd->nContent.GetIndex() - pStt->nContent.GetIndex()) == 1)
{
SwTxtNode* pTxtNd = rPam.Start()->nNode.GetNode().GetTxtNode();
xub_StrLen nIndex = rPam.Start()->nContent.GetIndex();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
git branch audit - results ...
Thanks for all the input, I tried to condense it; what I have is this. After another git remote prune origin I see we're a lot cleaner now :-) but I still have these to delete (will do that Monday absent screams): * to-kill origin/feature/external_gbuild # ~obsolete attempt to gbuild external modules origin/feature/cell-format-data-bar # obsolete now origin/feature/cell-notes # obsolete now origin/feature/line-numbers-in-basicIDE # merged to master origin/feature/masterpages # merged to master & 3.6 origin/feature/layout # obsoleted by Caolan's new work * unknown status - input appreciated origin/feature/chart_errorbars origin/feature/gbuild_mkdir origin/feature/gbuildfixes origin/feature/mork origin/feature/template-dialog Thanks ! :-) Michael. * keep: origin/feature/accfixes2 origin/feature/gsoc_test_improvements origin/feature/gsoc_test_improvements2 origin/feature/gsoc_test_improvements3 origin/feature/stub_writer origin/feature/cmclayouttrans origin/feature/unitymenus origin/feature/coretext # Norbert's coretext work origin/feature/submodules origin/features/base-preview # Lionel's ongoing work origin/feature/gsoc-calc-perf origin/feature/gsoc-calc-perf2 origin/feature/matrix-new-backend # Kohei's ongoing work origin/feature/opengl-canvas # openGL rendering origin/feature/remote # Andrezj's Android remote origin/feature/gbuild_help * already removed: origin/feature/android-x86 origin/feature/pdf-signing origin/feature/crossmsi origin/feature/kill-set_soenv origin/feature/mspub origin/feature/multiline-input origin/feature/gbuild_a11y origin/feature/gbuild_components origin/feature/gbuild_conversions origin/feature/gbuild_extensions origin/feature/gbuild_java origin/feature/gbuild_merge origin/feature/gbuild_mkdir origin/feature/gbuild_scp2 origin/feature/gbuild_sdext origin/feature/gbuild_shell origin/feature/gbuild_testtools -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/gsoc2011_wizards' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/kill-set_soenv' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/mspub' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PUSHED] Support for the checkerboard transition animation in SVG export.
Seen pushed. -- Thorsten pgpxmWnf2Nhiy.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: git branch audit ...
On Thu, 2012-07-19 at 11:36 +0100, Caolán McNamara wrote: > On Wed, 2012-07-18 at 17:51 +0100, Michael Meeks wrote: > > origin/feature/cmclayouttrans > > A work in progress, to munge translating .ui files into our localization > mechanism. Extraction of translatables done, re-insertion still a > to-do :-) Gosh - does that mean that cmclayout got merged to master ? or is it just renamed somehow ? I didn't see that, and the branch appears not to be there anymore. What's up there ? Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build light weight conversion binary
On 20/07/12 17:25, Michael Meeks wrote: > On Thu, 2012-07-19 at 22:26 -0700, Jerry Tan wrote: >> The company that I work for use LibreOffice as the main word >> processor. We convert a lot of client letters from doc/docx to open >> document format. >> - It won't work if there is already a LibreOffice instance running > > That should be easy enough to fix; it's a matter of not checking the > OSL_PIPE that we setup to send arguments to the main process. It is > possible that --nolockcheck does that, or perhaps there is a hidden > argument for that. there is no need to fix anything, just set up a separate user profile directory for your batch conversions and start soffice like this: soffice -env:UserInstallation=file:///tmp/lo_userdir_conversions >> So my boss asked me to fix these 2 issues. I managed to build the >> source code on Mac OS X Lion and then try to see what's going on >> (unfortunately specifying --headless fail to build). do you mean the configure "--enable-headless" option? that is very experimental and know to build only on the system of the guy who added it :) > So - --headless doesn't work well for Mac, there is a need for some > work there to fix it. There are really two different approaches - one is > to re-factor the font code so it is re-usable without setting up the > display / head logic, the other is to build & use freetype on mac, and > re-use the Linux code for font rendering etc. yes the --headless option in soffice, which currently works only on X11, could in theory be made to work on Mac as well (and is _completely_ independent of the configure --enable-headless option). >> - build a bare minimum/small binary (without too many dependencies) >> just for conversion to odt? also how do I link statically? >> The conversion utility doesn't need all the gui libraries I believe. >> Minimum dependency will make start up a lot quicker. > > So - those fragmented libraries help you there - the UI pieces > shouldn't be linked on startup. indeed that's why there are various *ui libraries, they contain dialogs that aren't loaded when you just convert documents. >> - what to do to allow conversion working while there is an instance of >> LibreOffice already running? Should I modify something in the source >> code? that's completely unnecessary, as i wrote above. you can't start 2 soffice with the same user profile, and trying to make that work is probably quite a large effort and would probably slow down things with file locking and such if it can be made to work at all. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH (partial)] fdo#48549 System::Beep() removal
Hi Mek, On Fri, 2012-07-20 at 16:54 +0200, Mek Otar wrote: > I've written a patch that remove all call to Sound:Beep. Thomas > Arnhold suggest me to replace the Sound:Beep by some error reporting > mechanism. My question is: What is, in your opinion, the best way to > do this? Looks great to me, the beeping is random, turns into XBell on Linux so for multi-user seats it can come out of a totally different machine, somewhere else ;-) etc. It'd be great to have a blanket MPL/LGPLv3+ license statement from you on the list that we can link into here: http://wiki.documentfoundation.org/Development/Developers Than I'd merge it ! :-) Thanks for your contribution; what's next ? :-) All the best, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: extensions/Module_extensions.mk
extensions/Module_extensions.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8c05d8b827a2c376fb419d8ae7801b6bd6e0ca14 Author: Caolán McNamara Date: Fri Jul 20 16:55:02 2012 +0100 fix probable cut-and-paste build error Change-Id: I71a3ea0fd548bb6dcaf2df823fa3d63026b1b3dc diff --git a/extensions/Module_extensions.mk b/extensions/Module_extensions.mk index 205f860..dba2d30 100644 --- a/extensions/Module_extensions.mk +++ b/extensions/Module_extensions.mk @@ -38,7 +38,7 @@ $(eval $(call gb_Module_add_targets,extensions,\ )) ifneq ($(filter-out IOS ANDROID,$(OS)),) -$(eval $(call gb_Module_add_targets,shell,\ +$(eval $(call gb_Module_add_targets,extensions,\ Library_ldapbe2 \ )) endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[REVIEW 3-6][REVIEW 3-6-0] fdo#52240 added abbreviated date acceptance patterns for [de-{AT,CH,LI,LU}]
Hi, Please review and cherry-pick to 3-6 and 3-6-0 the no-brainer http://cgit.freedesktop.org/libreoffice/core/commit/?id=d0d840c27943f976fd59a673f2de84a10ea475c9 Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpNIlfZZ0iLJ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: i18npool/source
i18npool/source/localedata/data/de_AT.xml |1 +
i18npool/source/localedata/data/de_CH.xml |1 +
i18npool/source/localedata/data/de_LI.xml |1 +
i18npool/source/localedata/data/de_LU.xml |1 +
4 files changed, 4 insertions(+)
New commits:
commit d0d840c27943f976fd59a673f2de84a10ea475c9
Author: Eike Rathke
Date: Fri Jul 20 17:51:39 2012 +0200
fdo#52240 added abbreviated date acceptance patterns for [de-{AT,CH,LI,LU}]
Change-Id: I589cedcd2db0208b03d1e28babbb493912f20c78
diff --git a/i18npool/source/localedata/data/de_AT.xml
b/i18npool/source/localedata/data/de_AT.xml
index de57ea9..d657cc5 100644
--- a/i18npool/source/localedata/data/de_AT.xml
+++ b/i18npool/source/localedata/data/de_AT.xml
@@ -52,6 +52,7 @@
metric
+D.M.
Standard
diff --git a/i18npool/source/localedata/data/de_CH.xml
b/i18npool/source/localedata/data/de_CH.xml
index 494eb69..245e57b 100644
--- a/i18npool/source/localedata/data/de_CH.xml
+++ b/i18npool/source/localedata/data/de_CH.xml
@@ -55,6 +55,7 @@
metric
+D.M.
Standard
diff --git a/i18npool/source/localedata/data/de_LI.xml
b/i18npool/source/localedata/data/de_LI.xml
index 5be436a..f927431 100644
--- a/i18npool/source/localedata/data/de_LI.xml
+++ b/i18npool/source/localedata/data/de_LI.xml
@@ -52,6 +52,7 @@
metric
+D.M.
Standard
diff --git a/i18npool/source/localedata/data/de_LU.xml
b/i18npool/source/localedata/data/de_LU.xml
index edbb008..78c85bb 100644
--- a/i18npool/source/localedata/data/de_LU.xml
+++ b/i18npool/source/localedata/data/de_LU.xml
@@ -52,6 +52,7 @@
metric
+D.M.
Standard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/android-x86' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: android/experimental bridges/inc bridges/source configure.in distro-configs/LibreOfficeAndroidX86.conf extensions/Module_extensions.mk icu/icu4c-android.patch icu/icu4c-build.
android/experimental/LibreOffice4Android/Makefile| 21 ++- bridges/inc/bridges/cpp_uno/shared/vtablefactory.hxx |2 bridges/source/cpp_uno/gcc3_linux_intel/makefile.mk |3 configure.in | 29 +++-- distro-configs/LibreOfficeAndroidX86.conf| 26 extensions/Module_extensions.mk |7 + icu/icu4c-android.patch |4 icu/icu4c-build.patch|2 openldap/makefile.mk |4 sal/android/lo-bootstrap.c | 30 +++-- solenv/gbuild/platform/ANDROID_INTEL_GCC.mk | 104 +++ solenv/inc/unx.mk|4 solenv/inc/unxandr.mk|4 sw/CppunitTest_sw_filters_test.mk|3 sw/CppunitTest_sw_subsequent_odfimport.mk|2 15 files changed, 205 insertions(+), 40 deletions(-) New commits: commit d3c4d9a0f828d42ee6cd0768607ca08b21669d70 Author: Michael Meeks Date: Mon Jul 16 17:40:25 2012 +0100 android: x86 porting work. diff --git a/android/experimental/LibreOffice4Android/Makefile b/android/experimental/LibreOffice4Android/Makefile index d2c5f8e..da87ca7 100644 --- a/android/experimental/LibreOffice4Android/Makefile +++ b/android/experimental/LibreOffice4Android/Makefile @@ -16,8 +16,13 @@ APP_PACKAGE=org.libreoffice # code are very much self-contained pre-packaged thingies. APP_DATA_PATH=/data/data/$(APP_PACKAGE) -SODEST=libs/armeabi-v7a -OBJLOCAL=obj/local/armeabi-v7a +ifeq ($(CPU),I) +ABI_PATH=x86 +else +ABI_PATH=armeabi-v7a +endif +SODEST=libs/$(ABI_PATH) +OBJLOCAL=obj/local/$(ABI_PATH) define COPYSO cp $(1) $(SODEST)$(if $(2),/$(2)) && $(STRIP) --strip-debug $(SODEST)$(if $(2),/$(2),/$(notdir $(1))) && \ @@ -34,10 +39,10 @@ all: build-ant properties: echo sdk.dir=$(ANDROID_SDK_HOME) >local.properties - echo sdk.dir=$(ANDROID_SDK_HOME) >../../Bootstrap/local.properties + echo sdk.dir=$(ANDROID_SDK_HOME) >../../Bootstrap/local.properties -copy-stuff: -# First always clean +copy-stuff: +# First always clean rm -rf libs $(OBJLOCAL) mkdir -p $(SODEST) $(OBJLOCAL) # @@ -134,7 +139,7 @@ copy-stuff: done # # Then the shared GNU C++ library - $(call COPYSO,$(ANDROID_NDK_HOME)/sources/cxx-stl/gnu-libstdc++/libs/armeabi-v7a/libgnustl_shared.so) + $(call COPYSO,$(ANDROID_NDK_HOME)/sources/cxx-stl/gnu-libstdc++/libs/$(ABI_PATH)/libgnustl_shared.so) # # Then other "assets". Let the directory structure under assets mimic # that under solver for now. @@ -234,7 +239,7 @@ copy-stuff: # Then gdbserver and gdb.setup so that we can debug with ndk-gdb. # cp $(ANDROID_NDK_HOME)/toolchains/arm-linux-androideabi-4.4.3/prebuilt/gdbserver $(SODEST) - echo set solib-search-path ./obj/local/armeabi-v7a >$(SODEST)/gdb.setup + echo set solib-search-path ./obj/local/$(ABI_PATH) >$(SODEST)/gdb.setup build-ant: copy-stuff properties # @@ -269,4 +274,4 @@ run: clean: properties $(ANT) clean - rm -rf assets libs $(SODEST) $(OBJLOCAL) + rm -rf assets libs obj diff --git a/bridges/inc/bridges/cpp_uno/shared/vtablefactory.hxx b/bridges/inc/bridges/cpp_uno/shared/vtablefactory.hxx index c21fb76..bc43fb4 100644 --- a/bridges/inc/bridges/cpp_uno/shared/vtablefactory.hxx +++ b/bridges/inc/bridges/cpp_uno/shared/vtablefactory.hxx @@ -39,7 +39,7 @@ /*See: http://people.redhat.com/drepper/selinux-mem.html*/ #if defined(LINUX) || defined(OPENBSD) || defined(FREEBSD) \ -|| defined(NETBSD) || defined(DRAGONFLY) +|| defined(NETBSD) || defined(DRAGONFLY) || defined (ANDROID) #define USE_DOUBLE_MMAP #endif diff --git a/bridges/source/cpp_uno/gcc3_linux_intel/makefile.mk b/bridges/source/cpp_uno/gcc3_linux_intel/makefile.mk index c814132..e48bfce 100644 --- a/bridges/source/cpp_uno/gcc3_linux_intel/makefile.mk +++ b/bridges/source/cpp_uno/gcc3_linux_intel/makefile.mk @@ -42,7 +42,8 @@ ENABLE_EXCEPTIONS=TRUE "$(COM)$(OS)$(CPU)$(COMNAME)" == "GCCOPENBSDIgcc3" || \ "$(COM)$(OS)$(CPU)$(COMNAME)" == "GCCFREEBSDIgcc3" || \ "$(COM)$(OS)$(CPU)$(COMNAME)" == "GCCNETBSDIgcc3" || \ -"$(COM)$(OS)$(CPU)$(COMNAME)" == "GCCDRAGONFLYIgcc3" +"$(COM)$(OS)$(CPU)$(COMNAME)" == "GCCDRAGONFLYIgcc3" || \ +"$(COM)$(OS)$(CPU)$(COMNAME)" == "GCCANDROIDIgcc3" || \ # In case someone enabled the non-standard -fomit-frame-pointer which does not # work with the .cxx sources in this directory: diff --git a/configure.in b/configure.in index b41fa09..980a2fb 100644 --- a/configure.in +++ b/configure.in @@ -129,18 +129,25 @@ ANDROID_ARCH= ANDROID_NDK_HOME= if test -n "$with_android_ndk"; then ANDROID_NDK_HOME=$with_android_ndk + # Set up a lot of pre-canned defaults # What if the NDK at some point starts including several toolchains for different # g
Re: Changes needed for "LibreOffice 4"
2012/7/20 Lubos Lunak : > On Thursday 19 of July 2012, Michael Meeks wrote: >> * 4.0 - when to call it that ? (Kendy) > So for that, we should first decide > on what "LibreOffice4" will mean. > > Summary: > - it needs to be said what we expect from "LibreOffice4" > - the wiki page with technical tasks needs to be cleaned up > - we need to decide how to deal with the fact that LO4 will break backwards > compatibility For me the 4 Version would be different from other versions, if the office suite includes a browser and a messenger http://interface.sf.net and http://dooble.sf.net Like MS Office 360 has Skype and Cloud. Regards Randolph ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - basic/inc basic/source sw/source
basic/inc/basic/sbmod.hxx|4 -
basic/inc/basic/sbobjmod.hxx | 10 ++--
basic/inc/basic/sbstar.hxx |2
basic/inc/basic/sbstdobj.hxx |8 +--
basic/inc/basic/sbx.hxx |6 +-
basic/inc/basic/sbxfac.hxx |4 -
basic/inc/basic/sbxobj.hxx |4 -
basic/source/classes/sb.cxx | 64 +++
basic/source/classes/sbunoobj.cxx| 24 --
basic/source/classes/sbxmod.cxx | 14 ++---
basic/source/inc/sbintern.hxx|4 -
basic/source/inc/sbunoobj.hxx| 14 ++---
basic/source/inc/stdobj.hxx |2
basic/source/runtime/stdobj.cxx |4 -
basic/source/runtime/stdobj1.cxx | 13 ++---
basic/source/sbx/sbxarray.cxx|2
basic/source/sbx/sbxbase.cxx | 10 +---
basic/source/sbx/sbxcoll.cxx |2
basic/source/sbx/sbxobj.cxx |4 -
basic/source/sbx/sbxstr.cxx |3 -
sw/source/core/txtnode/modeltoviewhelper.cxx |4 -
21 files changed, 95 insertions(+), 107 deletions(-)
New commits:
commit e88f6ca683a333d927b1e5a63fcae7a88a01ab6b
Author: Caolán McNamara
Date: Fri Jul 20 13:55:07 2012 +0100
behind (hinter) -> after
Change-Id: I3bc9ca4e20bfaa5d14fbd5827444071b19ad
diff --git a/sw/source/core/txtnode/modeltoviewhelper.cxx
b/sw/source/core/txtnode/modeltoviewhelper.cxx
index 945e1a2..7f33324 100644
--- a/sw/source/core/txtnode/modeltoviewhelper.cxx
+++ b/sw/source/core/txtnode/modeltoviewhelper.cxx
@@ -31,7 +31,7 @@ sal_uInt32 ConvertToViewPosition( const ConversionMap* pMap,
sal_uInt32 nModelPo
if ( !pMap )
return nRet;
-// Search for entry behind nPos:
+// Search for entry after nPos:
ConversionMap::const_iterator aIter;
for ( aIter = pMap->begin(); aIter != pMap->end(); ++aIter )
{
@@ -60,7 +60,7 @@ ModelPosition ConvertToModelPosition( const ConversionMap*
pMap, sal_uInt32 nVie
if ( !pMap )
return aRet;
-// Search for entry behind nPos:
+// Search for entry after nPos:
ConversionMap::const_iterator aIter;
for ( aIter = pMap->begin(); aIter != pMap->end(); ++aIter )
{
commit 6a45bc96f90e853abfab6bd4648f27f0e0d91800
Author: Caolán McNamara
Date: Fri Jul 20 11:00:48 2012 +0100
very suspicious combination of used SbxValues and unused aRes
Looks like a regression from 4d949990ef1438fcae98262519c6af2b47e5ccf5 where
for
every other case we did...
-XubString aRes;
+::rtl::OUString aRes;
aTmp.eType = SbxSTRING;
-aTmp.pString = &aRes;
+aTmp.pOUString = &aRes;
while for this case we did only...
SbxValues aTmp;
XubString aRes;
aTmp.eType = SbxSTRING;
-aTmp.pString = &aRes;
Change-Id: I106cfbcc0fc0b27a9adcbb243d0d69c65b167005
diff --git a/basic/source/sbx/sbxstr.cxx b/basic/source/sbx/sbxstr.cxx
index abab0ee..9576afe 100644
--- a/basic/source/sbx/sbxstr.cxx
+++ b/basic/source/sbx/sbxstr.cxx
@@ -134,8 +134,9 @@
if( ( p->eType & (~SbxBYREF) ) == SbxDOUBLE )
{
SbxValues aTmp;
-XubString aRes;
+rtl::OUString aRes;
aTmp.eType = SbxSTRING;
+aTmp.pOUString = &aRes;
if( p->eType == SbxDOUBLE )
ImpPutDouble( &aTmp, p->nDouble, sal_True );// true =
bCoreString
else
commit bfe1aa0e79cd1b849721760e89f254870b3f8000
Author: Caolán McNamara
Date: Fri Jul 20 09:54:40 2012 +0100
XubString->rtl::OUString
Change-Id: I584ff580e3c8eee401f07c858ecbd63e5b0bf980
diff --git a/basic/inc/basic/sbmod.hxx b/basic/inc/basic/sbmod.hxx
index 25d83a1..f981211 100644
--- a/basic/inc/basic/sbmod.hxx
+++ b/basic/inc/basic/sbmod.hxx
@@ -99,7 +99,7 @@ public:
virtual voidSetParent( SbxObject* );
virtual voidClear();
-virtual SbxVariable* Find( const String&, SbxClassType );
+virtual SbxVariable* Find( const rtl::OUString&, SbxClassType );
virtual const String& GetSource() const;
const ::rtl::OUString& GetSource32() const;
@@ -164,7 +164,7 @@ public:
~SbClassModuleObject();
// Overridden to support NameAccess etc.
-virtual SbxVariable* Find( const String&, SbxClassType );
+virtual SbxVariable* Find( const rtl::OUString&, SbxClassType );
virtual void SFX_NOTIFY( SfxBroadcaster&, const TypeId&, const SfxHint&
rHint, const TypeId& );
diff --git a/basic/inc/basic/sbobjmod.hxx b/basic/inc/basic/sbobjmod.hxx
index 1e37280..d1f1c0f 100644
--- a/basic/inc/basic/sbobjmod.hxx
+++ b/basic/inc/basic/sbobjmod.hxx
@@ -41,7 +41,7 @@ protected:
public:
TYPEINFO();
SbObjModule( const String& rName, const
com::sun::star::script::ModuleInfo& mInfo, bool bIsVbaCompatible );
-virtual S
Re: Build light weight conversion binary
Hi Jerry, On Thu, 2012-07-19 at 22:26 -0700, Jerry Tan wrote: > The company that I work for use LibreOffice as the main word > processor. We convert a lot of client letters from doc/docx to open > document format. Sounds like a good use-case :-) > We are on Mac OS X Lion (10.7) btw. We use: soffice --headless > --convert-to odt …. to do the batch conversion. Seems sensible. > The problems with this are: > - It takes quite a long time to start up. It becomes a problem when we > have to convert many documents. This is a matter of profiling; when you say "quite a long time" - how long are you talking ? :-) Also, is your concern cold or warm startup time ? > - It won't work if there is already a LibreOffice instance running That should be easy enough to fix; it's a matter of not checking the OSL_PIPE that we setup to send arguments to the main process. It is possible that --nolockcheck does that, or perhaps there is a hidden argument for that. > So my boss asked me to fix these 2 issues. I managed to build the > source code on Mac OS X Lion and then try to see what's going on > (unfortunately specifying --headless fail to build). So - --headless doesn't work well for Mac, there is a need for some work there to fix it. There are really two different approaches - one is to re-factor the font code so it is re-usable without setting up the display / head logic, the other is to build & use freetype on mac, and re-use the Linux code for font rendering etc. There are also some nice sillies going on; last I looked there was some considerable proportion of the time rendering a nice gradient background to a bitmap view of the window you can't see when using --headless ;-) I suspect just profiling and turning off a lot of that fluff would accelerate things for you. But -always- profile before optimisting. Callgrind-for-mac + KCachegrind on Linux would be a great pair of free tools if you have nothing better. > I found out that to just do the conversion, there are many dynamic > libraries are loaded (so I guess this is why it takes a long time). That's not obvious to me, and I've done lots of work on profiling. If you want faster cold-start, you can try using the --enable-mergelib build mode - that builds a ton of the code into a single, huge library - it may help you: I'd be interested in some hard profiling results from that. > Trying to understand what's going on in the code is not a simple task > to be honest. Can some one help or give me info on how to: :-) > - build a bare minimum/small binary (without too many dependencies) > just for conversion to odt? also how do I link statically? > The conversion utility doesn't need all the gui libraries I believe. > Minimum dependency will make start up a lot quicker. So - those fragmented libraries help you there - the UI pieces shouldn't be linked on startup. > - what to do to allow conversion working while there is an instance of > LibreOffice already running? Should I modify something in the source > code? That should be easyish cf. above. See desktop/source/app/officeipcthread.cxx and thereabouts :-) > I'm sure a lot of people would love to have this light weight > conversion utility. Thanks so much for jumping in ! Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/core/doc/docbm.cxx |2 +-
sw/source/core/doc/docedt.cxx | 20
2 files changed, 9 insertions(+), 13 deletions(-)
New commits:
commit 9c497e9ed128f341846072b1c85271d9208290a4
Author: Miklos Vajna
Date: Fri Jul 20 17:08:20 2012 +0200
SwDoc::DeleteRangeImplImpl: avoid crash on undoing comment range insert
Change-Id: I1e085448fb8fb1227794a5196e954d97af770218
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index cfc8629..f3befe4 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -593,7 +593,7 @@ namespace sw { namespace mark
isPosInRange = true, isOtherPosInRange = true;
}
-if(isPosInRange && (isOtherPosInRange || !pMark->IsExpanded() ||
IDocumentMarkAccess::GetType(*pMark) == TEXT_FIELDMARK))
+if(isPosInRange && (isOtherPosInRange || !pMark->IsExpanded()))
{
// completely in range
diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx
index 3655294..5ae2ab6 100644
--- a/sw/source/core/doc/docedt.cxx
+++ b/sw/source/core/doc/docedt.cxx
@@ -76,6 +76,7 @@
#include "editsh.hxx"
#include
#include
+#include
#include
#include
@@ -1646,21 +1647,16 @@ bool SwDoc::DeleteRangeImplImpl(SwPaM & rPam)
{
SwTxtNode* pTxtNd = rPam.Start()->nNode.GetNode().GetTxtNode();
xub_StrLen nIndex = rPam.Start()->nContent.GetIndex();
-// If there are at least two chars before the postit, we may have a
fieldmark there.
-if (pTxtNd->GetTxt().GetChar(nIndex) == CH_TXTATR_INWORD && nIndex > 1)
+// We may have a postit here.
+if (pTxtNd->GetTxt().GetChar(nIndex) == CH_TXTATR_INWORD)
{
SwTxtAttr* pTxtAttr = pTxtNd->GetTxtAttrForCharAt(nIndex,
RES_TXTATR_FIELD);
-if (pTxtAttr && pTxtAttr->GetFld().GetFld()->Which() ==
RES_POSTITFLD && pTxtNd->GetTxt().GetChar(nIndex - 1) == CH_TXT_ATR_FIELDEND)
+if (pTxtAttr && pTxtAttr->GetFld().GetFld()->Which() ==
RES_POSTITFLD)
{
-xub_StrLen nStart =
pTxtNd->GetTxt().SearchBackward(CH_TXT_ATR_FIELDSTART, nIndex - 2);
-if (nStart != STRING_NOTFOUND)
-{
-SwIndex aStart(pStt->nContent);
-aStart = nStart;
-SwIndex aEnd(pEnd->nContent);
-aEnd = nIndex - 1;
-_DelBookmarks(pStt->nNode, pEnd->nNode, NULL, &aStart,
&aEnd);
-}
+const SwPostItField* pField = dynamic_cast(pTxtAttr->GetFld().GetFld());
+IDocumentMarkAccess::const_iterator_t ppMark =
getIDocumentMarkAccess()->findMark(pField->GetName());
+if (ppMark != getIDocumentMarkAccess()->getMarksEnd())
+getIDocumentMarkAccess()->deleteMark(ppMark);
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - solenv/gdb
solenv/gdb/libreoffice/sw.py | 24
1 file changed, 24 insertions(+)
New commits:
commit 81d2dd00391dbc8a040e5c1f3059121863269d2c
Author: Miklos Vajna
Date: Fri Jul 20 16:48:11 2012 +0200
gdb: add SwIndex pretty-printer
Change-Id: I452038a80f9a091f2b7af36d236cebd5f176b5e9
diff --git a/solenv/gdb/libreoffice/sw.py b/solenv/gdb/libreoffice/sw.py
index 7ea6a66..941f56d 100644
--- a/solenv/gdb/libreoffice/sw.py
+++ b/solenv/gdb/libreoffice/sw.py
@@ -50,6 +50,17 @@ class SwNodeIndexPrinter(object):
node = self.value['pNd'].dereference();
return "%s (node %d)" % (self.typename, node['nOffset'])
+class SwIndexPrinter(object):
+'''Prints SwIndex.'''
+
+def __init__(self, typename, value):
+self.typename = typename
+self.value = value
+
+def to_string(self):
+offset = self.value['m_nIndex']
+return "%s (offset %d)" % (self.typename, offset)
+
class SwPaMPrinter(object):
'''Prints SwPaM.'''
@@ -200,6 +211,7 @@ def build_pretty_printers():
printer.add('BigPtrArray', BigPtrArrayPrinter)
printer.add('SwPosition', SwPositionPrinter)
printer.add('SwNodeIndex', SwNodeIndexPrinter)
+printer.add('SwIndex', SwIndexPrinter)
printer.add('SwPaM', SwPaMPrinter)
printer.add('SwRect', SwRectPrinter)
commit 0a31b57050b7f73e51d344a413f0171a8f6a2afd
Author: Miklos Vajna
Date: Fri Jul 20 16:41:25 2012 +0200
gdb: add SwNodeIndex pretty-printer
Change-Id: I6d233c2cf715021262a5de1bdc76f68b7eb17db3
diff --git a/solenv/gdb/libreoffice/sw.py b/solenv/gdb/libreoffice/sw.py
index 581169d..7ea6a66 100644
--- a/solenv/gdb/libreoffice/sw.py
+++ b/solenv/gdb/libreoffice/sw.py
@@ -39,6 +39,17 @@ class SwPositionPrinter(object):
offset = self.value['nContent']['m_nIndex']
return "%s (node %d, offset %d)" % (self.typename, node['nOffset'],
offset)
+class SwNodeIndexPrinter(object):
+'''Prints SwNodeIndex.'''
+
+def __init__(self, typename, value):
+self.typename = typename
+self.value = value
+
+def to_string(self):
+node = self.value['pNd'].dereference();
+return "%s (node %d)" % (self.typename, node['nOffset'])
+
class SwPaMPrinter(object):
'''Prints SwPaM.'''
@@ -188,6 +199,7 @@ def build_pretty_printers():
printer = printing.Printer("libreoffice/sw")
printer.add('BigPtrArray', BigPtrArrayPrinter)
printer.add('SwPosition', SwPositionPrinter)
+printer.add('SwNodeIndex', SwNodeIndexPrinter)
printer.add('SwPaM', SwPaMPrinter)
printer.add('SwRect', SwRectPrinter)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] Support for the checkerboard transition animation in SVG export.
On Fri, 20 Jul 2012 16:24:10 +0200, Horácio Fernandes wrote: Ported the class CheckerBoardWipe. This and any future contributions to the LibreOffice project are under LGPLv3+/MPL, unless stated otherwise. Hi Horácio, thanks for submitting your patch, I committed it to master. Really a nice addition. Go on this way and have fun! :) Cheers, -- Marco -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Changes needed for "LibreOffice 4"
On Thursday 19 of July 2012, Michael Meeks wrote: > * 4.0 - when to call it that ? (Kendy) > + extension downloads > + some quite popular PDF import 3m downloads > + mysql - 330k > + spellcheck dicts - 300k > + renaming com::sun::star a problem here, > + instead perhaps announce rolling flag-day (Caolan's plan) > + http://wiki.documentfoundation.org/Development/LibreOffice4 > + too much to do in one six-month section > + top of agenda for next week. I think one of the first things that need to be done is actually saying what "LibreOffice 4" means. Looking at the wiki page linked above, apparently that's not clear at all. I see 3 reasons for why we should have LibreOffice 4 (not necessarily exclusive): a) for marketing reasons - we want to be like Firefox, we want to match AOOi (who AFAIK might go to 4.0 somewhen soon), or similar completely non-technical reasons b) we do significant user-visible changes, such as UI rework, or something that make the new LO version quite different from the previous ones c) we break backwards compatibility As a) is not technical at all, there's not much point in discussing it on a development list. If that needs to be done, we stamp "4" on it and it's done. Option b) is actually rather similar to a) in that if it's decided to be done, we just do it and that's it, it just will be more work. I'm not aware of anything significant in this area that'd warrant this, so I think we can ignore this one (correct me if I'm wrong). Option c) can mean either stopping supporting some file formats, or breaking API/ABI compatibility. For file formats we want to do this with binfilter AFAIK, nothing else, and this is a lot like b) as well in that it's just done and that's it. Breaking API/ABI compatibility for LibreOffice means breaking (only) extensions, which depending on the changes may need recompiling, adjusting or complete overhaul. Now, if you look at http://wiki.documentfoundation.org/Development/LibreOffice4 , a lot of the stuff there does not belong to the page at all, as it has absolutely nothing to do with any of the above: - "get rid of ASCII graphics noise (//=== etc)" is actually an EasyHack that just should be created as such, and can be done at any time without affecting anything else. There are a number of items in the list like this. - "de-UNO-ize the ODF import and export filters." is a purely internal matter that does not affect anything outside of LO core (or am I wrong here?) and as such it can be done at any time. Again, nothing to do with LibreOffice 4 (unless we want to use "4.0" as an excuse if things go wrong). There are several more like that. So, as long as we decide to do c) when switching to LO4 (which AFAIK we plan to do, even if c) alone is not the reason), the page first needs to be cleaned up to contain only items that actually do have something to do with LibreOffice4. And after all this is done, it should be easier to actually talk about LO4, because we'll know what the talk is actually about. As for the technical details (i.e. c) ), we'll need to decide how to handle the breakages it'll cause for extensions. Note that as extensions use only URE (right?), affected code is actually relatively small (AFAIK sal/, salhelper/, cppu/, cppuhelper/, udkapi/ and offapi/, not sure about the last one). I see roughly several ways: 1) We say we don't care about backwards compatibility, and keep possibly breaking it every release. Extensions will need to check they run with exactly the same version they were built for. + easy for us - more work for extension developers (#ifdef's , they'll either support just newest LO, or need to provide several versions) 2) We break compatibility once for 4.0 and keep it again afterwards. IOW like we've done so far. + extensions will need to be updated once and then it'll stay the same for them - we need to manage to do this between 3. and 4.0 , which may be quite some work and risks the KDE4.0 fate and the bad options (release too late, release too buggy, get stuck with stable 3.x and never stable 4.x); I have some experience with this from the KDE times and, unless we find out we don't actually have much work in front of us, we probably don't want to go there 3) = 1)+2) - we break it at 4.0, keep going with 1) until we're confident enough we can manage 2) again + easy for us (we just should end up with decently designed APIs for extensions, or we may need to do this again) - more work for extension developer, until we enter 2) 4) We do 2), but we smooth it out with a transition period (backwards compatibility wrappers). I believe that a number of the LO4 changes can be done in a compatible way with just a little more work (I have quite some experience there from the KDE times too). For example, the com::sun::star::* -> uno:: change is probably doable i
[Libreoffice-commits] .: filter/source
filter/source/svg/presentation_engine.js | 134 +--
1 file changed, 110 insertions(+), 24 deletions(-)
New commits:
commit 6ee666c53da83982784ea59894479a8b93c8ecd7
Author: Horacio Fernandes
Date: Fri Jul 20 10:07:15 2012 -0400
Support for the checkerboard transition animation in SVG export.
Ported the class CheckerBoardWipe.
Change-Id: I990c8f417c64d22ef87c1007887e630ac19a7083
diff --git a/filter/source/svg/presentation_engine.js
b/filter/source/svg/presentation_engine.js
index 88d8de0..186ef95 100644
--- a/filter/source/svg/presentation_engine.js
+++ b/filter/source/svg/presentation_engine.js
@@ -4217,6 +4217,7 @@ PINWHEELWIPE_TRANSITION = 6; // 23
PUSHWIPE_TRANSITION = 7; // 35
SLIDEWIPE_TRANSITION= 8; // 36
FADE_TRANSITION = 9; // 37
+CHECKERBOARDWIPE_TRANSITION = 10; // 39
aTransitionTypeInMap = {
'barWipe' : BARWIPE_TRANSITION,
@@ -4227,12 +4228,13 @@ aTransitionTypeInMap = {
'pinWheelWipe' : PINWHEELWIPE_TRANSITION,
'pushWipe' : PUSHWIPE_TRANSITION,
'slideWipe' : SLIDEWIPE_TRANSITION,
-'fade' : FADE_TRANSITION
+'fade' : FADE_TRANSITION,
+'checkerBoardWipe' : CHECKERBOARDWIPE_TRANSITION
};
aTransitionTypeOutMap = [ '', 'barWipe', 'boxWipe', 'fourBoxWipe',
'ellipseWipe',
'clockWipe', 'pinWheelWipe', 'pushWipe', 'slideWipe',
- 'fade' ];
+ 'fade', 'checkerBoardWipe' ];
// Transition Subtypes
@@ -4243,25 +4245,27 @@ CORNERSIN_TRANS_SUBTYPE = 3; // 11
CORNERSOUT_TRANS_SUBTYPE= 4;
VERTICAL_TRANS_SUBTYPE = 5;
HORIZONTAL_TRANS_SUBTYPE= 6; // 14
-CIRCLE_TRANS_SUBTYPE= 7; // 27
-CLOCKWISETWELVE_TRANS_SUBTYPE = 8; // 33
-CLOCKWISETHREE_TRANS_SUBTYPE= 9;
-CLOCKWISESIX_TRANS_SUBTYPE = 10;
-CLOCKWISENINE_TRANS_SUBTYPE = 11;
-TWOBLADEVERTICAL_TRANS_SUBTYPE = 12;
-TWOBLADEHORIZONTAL_TRANS_SUBTYPE= 13;
-FOURBLADE_TRANS_SUBTYPE = 14; // 39
-FROMLEFT_TRANS_SUBTYPE = 15; // 97
-FROMTOP_TRANS_SUBTYPE = 16;
-FROMRIGHT_TRANS_SUBTYPE = 17;
-FROMBOTTOM_TRANS_SUBTYPE= 18;
-CROSSFADE_TRANS_SUBTYPE = 19;
-FADETOCOLOR_TRANS_SUBTYPE = 20;
-FADEFROMCOLOR_TRANS_SUBTYPE = 21;
-FADEOVERCOLOR_TRANS_SUBTYPE = 22;
-THREEBLADE_TRANS_SUBTYPE= 23;
-EIGHTBLADE_TRANS_SUBTYPE= 24;
-ONEBLADE_TRANS_SUBTYPE = 25; // 107
+DOWN_TRANS_SUBTYPE = 7 // 19
+CIRCLE_TRANS_SUBTYPE= 8; // 27
+CLOCKWISETWELVE_TRANS_SUBTYPE = 9; // 33
+CLOCKWISETHREE_TRANS_SUBTYPE= 10;
+CLOCKWISESIX_TRANS_SUBTYPE = 11;
+CLOCKWISENINE_TRANS_SUBTYPE = 12;
+TWOBLADEVERTICAL_TRANS_SUBTYPE = 13;
+TWOBLADEHORIZONTAL_TRANS_SUBTYPE= 14;
+FOURBLADE_TRANS_SUBTYPE = 15; // 39
+FROMLEFT_TRANS_SUBTYPE = 16; // 97
+FROMTOP_TRANS_SUBTYPE = 17;
+FROMRIGHT_TRANS_SUBTYPE = 18;
+FROMBOTTOM_TRANS_SUBTYPE= 19;
+CROSSFADE_TRANS_SUBTYPE = 20;
+FADETOCOLOR_TRANS_SUBTYPE = 21;
+FADEFROMCOLOR_TRANS_SUBTYPE = 22;
+FADEOVERCOLOR_TRANS_SUBTYPE = 23;
+THREEBLADE_TRANS_SUBTYPE= 24;
+EIGHTBLADE_TRANS_SUBTYPE= 25;
+ONEBLADE_TRANS_SUBTYPE = 26; // 107
+ACROSS_TRANS_SUBTYPE= 27;
aTransitionSubtypeInMap = {
'leftToRight' : LEFTTORIGHT_TRANS_SUBTYPE,
@@ -4270,6 +4274,7 @@ aTransitionSubtypeInMap = {
'cornersOut': CORNERSOUT_TRANS_SUBTYPE,
'vertical' : VERTICAL_TRANS_SUBTYPE,
'horizontal': HORIZONTAL_TRANS_SUBTYPE,
+'down' : DOWN_TRANS_SUBTYPE,
'circle': CIRCLE_TRANS_SUBTYPE,
'clockwiseTwelve' : CLOCKWISETWELVE_TRANS_SUBTYPE,
'clockwiseThree': CLOCKWISETHREE_TRANS_SUBTYPE,
@@ -4288,16 +4293,18 @@ aTransitionSubtypeInMap = {
'fadeOverColor' : FADEOVERCOLOR_TRANS_SUBTYPE,
'threeBlade': THREEBLADE_TRANS_SUBTYPE,
'eightBlade': EIGHTBLADE_TRANS_SUBTYPE,
-'oneBlade' : ONEBLADE_TRANS_SUBTYPE
+'oneBlade' : ONEBLADE_TRANS_SUBTYPE,
+'across': ACROSS_TRANS_SUBTYPE
};
aTransitionSubtypeOutMap = [ 'default', 'leftToRight', 'topToBottom',
'cornersIn',
- 'cornersOut', 'vertical', 'horizontal', 'circle',
+ 'cornersOut', 'vertical', 'horizontal', 'down',
'circle',
'clockwiseTwelve', 'clockwiseThree',
'clockwiseSix',
'clockwiseNine', 'twoBladeVertical',
'twoBladeHorizontal',
'fourBlade', 'fromLeft', 'fromTop', 'fromRight',
'fromBottom',
[PATCH (partial)] fdo#48549 System::Beep() removal
Hi, I've written a patch that remove all call to Sound:Beep. Thomas Arnhold suggest me to replace the Sound:Beep by some error reporting mechanism. My question is: What is, in your opinion, the best way to do this? Best regards Mek Otar 0001-fdo-48549-System-Beep-removal.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: C++11 in LibreOffice
On Fri, Jul 20, 2012 at 9:37 AM, Michael Stahl wrote: > On 20/07/12 16:31, Yi Ding wrote: >> Fair point. :-) Let me see if I can get a build working on Windows >> this weekend. I see on the wiki that building with VS 2010 is not yet >> supported: >> >> http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies >> >> Is this information still current? > > yes it is; there is actually a patch for MSVC2010 attached here: > https://bugs.freedesktop.org/show_bug.cgi?id=30655 > > but it is quite outdated and apparently even when it was written there > was some CLR thing that didn't work. > > if you know the MSVC toolchain well then you could try to get that to > work, and it would be very useful, but you will probably have to spend > some time on it; currently only MSVC 2008 is known to work. Great, thanks. I'll give it a try, although after reading the Building on Windows thread I might end up giving up and just running the build on a VM. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[GSOC][LightProof]Сonclusion
Hello folks, I'm happy to say that this summer I had some success with conversion LanguageTool rules into LightProof ones. So most likely you can easily convert most rules. More detail here: http://googleyourlanguage.blogspot.com/2012/07/most-of-rules-can-be-succefully.html Unfortunately, my project was failed. Due personal problem I won't finish it, at least soon. I hope it will be useful to someone. Feel free to use and edit my code. I wish someone will finish what I've started. May thanks to community, especially to László, Cedric, Fridrich, who helped me all time I hacked. Happy hacking! Best regards Daniel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Build light weight conversion binary
Hi, The company that I work for use LibreOffice as the main word processor. We convert a lot of client letters from doc/docx to open document format. We are on Mac OS X Lion (10.7) btw. We use: soffice --headless --convert-to odt …. to do the batch conversion. The problems with this are: - It takes quite a long time to start up. It becomes a problem when we have to convert many documents. - It won't work if there is already a LibreOffice instance running So my boss asked me to fix these 2 issues. I managed to build the source code on Mac OS X Lion and then try to see what's going on (unfortunately specifying --headless fail to build). I found out that to just do the conversion, there are many dynamic libraries are loaded (so I guess this is why it takes a long time). Trying to understand what's going on in the code is not a simple task to be honest. Can some one help or give me info on how to: - build a bare minimum/small binary (without too many dependencies) just for conversion to odt? also how do I link statically? The conversion utility doesn't need all the gui libraries I believe. Minimum dependency will make start up a lot quicker. - what to do to allow conversion working while there is an instance of LibreOffice already running? Should I modify something in the source code? I'm sure a lot of people would love to have this light weight conversion utility. Many thanks before. Jerry___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Adding new label's format
Hello. I'm working for a labels manufaturer and I would like to add our format in libreoffice. We have customers who have asked for it in the past. How is the best way to perform this ? I found in the past that all informations are in a xml file (don't remember where now). There is a description of this file to give the good informations ? Thanks in advance. Sylvain Fauveau ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE
THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE |6 ++ 1 file changed, 6 insertions(+) New commits: commit 3640338f3db6b926b78040a63e97353b04d4cd62 Author: Michael Meeks Date: Fri Jul 20 15:35:36 2012 +0100 fdo#43057 apparently. diff --git a/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE b/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE new file mode 100644 index 000..d18029b --- /dev/null +++ b/THIS_IS_OBSOLETE_FIND_NEW_REPOSITORY_LOCATION_IN_HERE @@ -0,0 +1,6 @@ +There are claims that this repository has been migrated to: + + http://github.com/tdf/ + +Which sadly excludes all the existing developers from being +able to easily commit to, and help out with website tasks. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: C++11 in LibreOffice
On 20/07/12 16:31, Yi Ding wrote: > Fair point. :-) Let me see if I can get a build working on Windows > this weekend. I see on the wiki that building with VS 2010 is not yet > supported: > > http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies > > Is this information still current? yes it is; there is actually a patch for MSVC2010 attached here: https://bugs.freedesktop.org/show_bug.cgi?id=30655 but it is quite outdated and apparently even when it was written there was some CLR thing that didn't work. if you know the MSVC toolchain well then you could try to get that to work, and it would be very useful, but you will probably have to spend some time on it; currently only MSVC 2008 is known to work. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: C++11 in LibreOffice
Fair point. :-) Let me see if I can get a build working on Windows this weekend. I see on the wiki that building with VS 2010 is not yet supported: http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies Is this information still current? On Fri, Jul 20, 2012 at 3:43 AM, Michael Meeks wrote: > Hi there, > > On Thu, 2012-07-19 at 11:21 -0500, Yi Ding wrote: >> +1 ... >> +1 ... >> +1 ... > > Thanks for your encouragement, but this is a developers list :-) which > of these do you want to work on ? There is low-hanging fruit everywhere > for developers to focus on - which would you like to look into ? Startup > performance for example: reducing the configmgr thrash by tweaking that > code to allow us to split out settings that are not commonly needed eg. > the labels data would give a measureable boost to startup. It requires > only a hacker - is it you ? :-) > > All the best, > > Michael. > > -- > michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [HELP] fdo#51239 how to debug "it is slow"
On Thu, 2012-07-19 at 18:09 +0200, Stephan Bergmann wrote: > This is about direct use of JNI, not via UNO. Ah - I wonder ... ;-) if it is the transition that is the problem; could we have a Java thread polling a loopback socket and sucking simple commands & parsing & executing them, then passing the data back in some other form ;-> It'd be hideous if that actually was quicker than a direct JNI call but ... ;-) it's possible. Particularly in the world of under-utilized multi-threaded CPUs it might not be -so- bad. Bit of a pain cross-platform, but might work for suitably chunky methods; I wonder - could we use the wonder binary-urp magic to prototype it [ though I guess we'd need a native Java implementation of that - hmm ]. Urgh ! Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Support for the checkerboard transition animation in SVG export.
Ported the class CheckerBoardWipe. This and any future contributions to the LibreOffice project are under LGPLv3+/MPL, unless stated otherwise. -- Horácio Fernandes 0001-Support-for-the-checkerboard-transition-animation-in.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
On 07/20/2012 10:04 AM, Caolán McNamara wrote: On Thu, 2012-07-19 at 17:58 +0200, Markus Mohrhard wrote: Hey Eike, Kohei, 2012/7/19 Kohei Yoshida : I'm also not fully convinced of this patch. This behavior has been in Libreoffice since the start so IMHO it is more important to keep the behavior for all the LibO users than to change it again to please potential users switching from OOo. I think the only sane solution that will please both sides is to have it as configuration option but I'm not thrilled to see the default behavior changed again. FWIW, what would the ideal situation be if had a time machine ? e.g. Would a compatibility option of TreatEmptyCellsAsZero that defaulted to true if unset, and LibreOffice >= X.Y exported it as false have made sense ? IMO the most sane solution is to make it configurable, and let the user choose which way she prefers. We could try to be smart and detect the version of the document and change the behavior, but that will open up another can of worms. I'll add this configuration option during 3.7 cycle if this can wait until 3.7. If you guys need it earlier than that I could work on it and push it as a late feature if it's desperately needed for 3.6. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-6-0] fdo#50345 accept empty string as scalar numeric 0 argument
On Thu, 2012-07-19 at 17:58 +0200, Markus Mohrhard wrote: > Hey Eike, Kohei, > 2012/7/19 Kohei Yoshida : > I'm also not fully convinced of this patch. This behavior has been in > Libreoffice since the start so IMHO it is more important to keep the > behavior for all the LibO users than to change it again to please > potential users switching from OOo. > > I think the only sane solution that will please both sides is to have > it as configuration option but I'm not thrilled to see the default > behavior changed again. FWIW, what would the ideal situation be if had a time machine ? e.g. Would a compatibility option of TreatEmptyCellsAsZero that defaulted to true if unset, and LibreOffice >= X.Y exported it as false have made sense ? I mean, if it mattered enough, I suppose one could be added that is always explicitly exported true or false and hook off the for known legacy implementations that default true/false when its not set. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - dtrans/source embedserv/source o3tl/inc sal/Library_sal_textenc.mk sal/util shell/source tools/source xmerge/source
dtrans/source/win32/dtobj/XTDataObject.cxx | 10 +---
embedserv/source/inprocserv/dllentry.cxx|6 --
o3tl/inc/o3tl/sorted_vector.hxx | 22 +---
sal/Library_sal_textenc.mk |2
sal/util/sal_textenc/saltextenc.map | 40
shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx | 36 +-
shell/source/win32/shlxthandler/prophdl/propertyhdl.cxx |3 -
shell/source/win32/shlxthandler/shlxthdl.cxx|3 -
tools/source/fsys/wntmsc.cxx|5 --
xmerge/source/activesync/XMergeFactory.cpp |6 --
xmerge/source/activesync/XMergeSync.cpp |6 --
11 files changed, 21 insertions(+), 118 deletions(-)
New commits:
commit e5a0755bc2f8129cb854367740a02c859555c033
Author: Stephan Bergmann
Date: Fri Jul 20 15:55:05 2012 +0200
new does not return null
Change-Id: Iea00f7c6435c6ae3ccbb2f97ab4407df8b86c54b
diff --git a/dtrans/source/win32/dtobj/XTDataObject.cxx
b/dtrans/source/win32/dtobj/XTDataObject.cxx
index ec3d201..a28f866 100644
--- a/dtrans/source/win32/dtobj/XTDataObject.cxx
+++ b/dtrans/source/win32/dtobj/XTDataObject.cxx
@@ -496,10 +496,9 @@ STDMETHODIMP CXTDataObject::EnumFormatEtc(
if ( DATADIR_GET == dwDirection )
{
*ppenumFormatetc = new CEnumFormatEtc( this, m_FormatEtcContainer );
-if ( NULL != *ppenumFormatetc )
-static_cast< LPUNKNOWN >( *ppenumFormatetc )->AddRef( );
+static_cast< LPUNKNOWN >( *ppenumFormatetc )->AddRef( );
-hr = ( NULL != *ppenumFormatetc ) ? S_OK : E_OUTOFMEMORY;
+hr = S_OK;
}
else
hr = E_INVALIDARG;
@@ -832,10 +831,9 @@ STDMETHODIMP CEnumFormatEtc::Clone( IEnumFORMATETC**
ppenum )
return E_INVALIDARG;
*ppenum = new CEnumFormatEtc( m_lpUnkOuter, m_FormatEtcContainer );
-if ( NULL != *ppenum )
-static_cast< LPUNKNOWN >( *ppenum )->AddRef( );
+static_cast< LPUNKNOWN >( *ppenum )->AddRef( );
-return ( NULL != *ppenum ) ? S_OK : E_OUTOFMEMORY;
+return S_OK;
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/embedserv/source/inprocserv/dllentry.cxx
b/embedserv/source/inprocserv/dllentry.cxx
index 6a43fce..6daf9bf 100644
--- a/embedserv/source/inprocserv/dllentry.cxx
+++ b/embedserv/source/inprocserv/dllentry.cxx
@@ -186,9 +186,6 @@ extern "C" STDAPI INPROC_DLLPUBLIC DllGetClassObject(
REFCLSID rclsid, REFIID ri
return E_NOINTERFACE;
*ppv = new inprocserv::InprocEmbedProvider_Impl( rclsid );
-if ( *ppv == NULL )
-return E_OUTOFMEMORY;
-
((LPUNKNOWN)*ppv)->AddRef();
return S_OK;
}
@@ -316,9 +313,6 @@ STDMETHODIMP
InprocEmbedProvider_Impl::CreateInstance(IUnknown FAR* punkOuter,
return CLASS_E_NOAGGREGATION;
InprocEmbedDocument_Impl* pEmbedDocument = new InprocEmbedDocument_Impl(
m_guid );
-if ( !pEmbedDocument )
-return E_OUTOFMEMORY;
-
pEmbedDocument->AddRef();
HRESULT hr = pEmbedDocument->Init();
if ( SUCCEEDED( hr ) )
diff --git a/shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx
b/shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx
index 9f37b3b..83df85f 100644
--- a/shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx
+++ b/shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx
@@ -817,21 +817,16 @@ SCODE STDMETHODCALLTYPE COooFilterCF::CreateInstance(
if ( 0 != pUnkOuter )
return CLASS_E_NOAGGREGATION;
pIUnk = new COooFilter();
-if ( 0 != pIUnk )
+if ( SUCCEEDED( pIUnk->QueryInterface( riid , ppvObject ) ) )
{
-if ( SUCCEEDED( pIUnk->QueryInterface( riid , ppvObject ) ) )
-{
-// Release extra refcount from QueryInterface
-pIUnk->Release();
-}
-else
-{
-delete pIUnk;
-return E_UNEXPECTED;
-}
+// Release extra refcount from QueryInterface
+pIUnk->Release();
}
else
-return E_OUTOFMEMORY;
+{
+delete pIUnk;
+return E_UNEXPECTED;
+}
return S_OK;
}
@@ -919,19 +914,14 @@ extern "C" SCODE STDMETHODCALLTYPE DllGetClassObject(
}
else
return CLASS_E_CLASSNOTAVAILABLE;
-if ( 0 != pResult )
+if( SUCCEEDED( pResult->QueryInterface( iid, ppvObj ) ) )
+// Release extra refcount from QueryInterface
+pResult->Release();
+else
{
-if( SUCCEEDED( pResult->QueryInterface( iid, ppvObj ) ) )
-// Release extra refcount from QueryInterface
-pResult->Release();
-else
-{
-delete pImpl;
-return E_UNEXPECTED;
-}
+delete pImpl;
+return E_UNEXPECTED;
}
-else
-return E_OUTOFMEMORY;
return S_OK;
}
//F--
Re: [PATCH] Change in core[libreoffice-3-6-0]: fdo#38056: ODF import: fix page style attributes:
On Fri, Jul 20, 2012 at 01:12:37PM +0200, Michael Stahl wrote: > On 20/07/12 12:34, Miklos Vajna wrote: > > On Fri, Jul 20, 2012 at 10:12:58AM +, Gerrit > > wrote: > >> Hello Miklos Vajna, > >> > >> I'd like you to do a code review. Please visit > > > > Now this is really confusing; I already signed off this patch, so I > > should not do a code review this time. ;-) > > i agree :) > > i didn't do anything explicit to add you as reviewer to this patch, so > presumably gerrit did it automatically. Well, gerrit sees the patch and it sees a 'new version' as it is cherry-picked and does not have the same identity. IIRC that mail will be gone when gerrit puts the patches on master itself (in which case it understands better what happened). Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/CppunitTest_sw_subsequent_odfexport.mk sw/Module_sw.mk sw/qa
sw/CppunitTest_sw_subsequent_odfexport.mk | 98 ++ sw/Module_sw.mk |1 sw/qa/extras/odfexport/data/fdo38244.odt |binary sw/qa/extras/odfexport/odfexport.cxx | 95 + 4 files changed, 194 insertions(+) New commits: commit c251673851b72c3b516dee6db44f1e7a8854aeb9 Author: Miklos Vajna Date: Fri Jul 20 15:34:43 2012 +0200 fdo#38244 comment range odf import/export testcase Change-Id: I8cbaa30aa222404f55f5ff49474cf93e8b1bdac2 diff --git a/sw/CppunitTest_sw_subsequent_odfexport.mk b/sw/CppunitTest_sw_subsequent_odfexport.mk new file mode 100644 index 000..0b90494 --- /dev/null +++ b/sw/CppunitTest_sw_subsequent_odfexport.mk @@ -0,0 +1,98 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +#* +# Version: MPL 1.1 / GPLv3+ / LGPLv3+ +# +# The contents of this file are subject to the Mozilla Public License Version +# 1.1 (the "License"); you may not use this file except in compliance with +# the License or as specified alternatively below. You may obtain a copy of +# the License at http://www.mozilla.org/MPL/ +# +# Software distributed under the License is distributed on an "AS IS" basis, +# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License +# for the specific language governing rights and limitations under the +# License. +# +# The Initial Developer of the Original Code is +# Miklos Vajna (SUSE, Inc.) +# Portions created by the Initial Developer are Copyright (C) 2012 the +# Initial Developer. All Rights Reserved. +# +# Major Contributor(s): +# +# For minor contributions see the git repository. +# +# Alternatively, the contents of this file may be used under the terms of +# either the GNU General Public License Version 3 or later (the "GPLv3+"), or +# the GNU Lesser General Public License Version 3 or later (the "LGPLv3+"), +# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable +# instead of those above. +#* + +$(eval $(call gb_CppunitTest_CppunitTest,sw_subsequent_odfexport)) + +$(eval $(call gb_CppunitTest_add_exception_objects,sw_subsequent_odfexport, \ +sw/qa/extras/odfexport/odfexport \ +)) + +$(eval $(call gb_CppunitTest_use_libraries,sw_subsequent_odfexport, \ +cppu \ +cppuhelper \ +sal \ + sw \ +test \ +tl \ +unotest \ +utl \ +vcl \ +$(gb_STDLIBS) \ +)) + +$(eval $(call gb_CppunitTest_use_externals,sw_subsequent_odfexport,\ +libxml2 \ +)) + +$(eval $(call gb_CppunitTest_set_include,sw_subsequent_odfexport,\ +-I$(SRCDIR)/sw/inc \ +-I$(SRCDIR)/sw/source/core/inc \ +$$(INCLUDE) \ +)) + +$(eval $(call gb_CppunitTest_use_api,sw_subsequent_odfexport,\ +offapi \ +udkapi \ +)) + +$(eval $(call gb_CppunitTest_use_ure,sw_subsequent_odfexport)) + +$(eval $(call gb_CppunitTest_use_components,sw_subsequent_odfexport,\ +comphelper/util/comphelp \ +configmgr/source/configmgr \ +fileaccess/source/fileacc \ +filter/source/config/cache/filterconfig1 \ +framework/util/fwk \ +i18npool/util/i18npool \ +package/util/package2 \ +package/source/xstor/xstor \ +sw/util/sw \ +sw/util/swd \ +sax/source/expatwrap/expwrap \ +sfx2/util/sfx \ +svl/source/fsstor/fsstorage \ +svtools/util/svt \ +toolkit/util/tk \ +ucb/source/core/ucb1 \ +ucb/source/ucp/file/ucpfile1 \ +unotools/util/utl \ +unoxml/source/service/unoxml \ +xmlhelp/util/ucpchelp1 \ +)) + +$(eval $(call gb_CppunitTest_use_configuration,sw_subsequent_odfexport)) + +$(eval $(call gb_CppunitTest_use_filter_configuration,sw_subsequent_odfexport)) + +$(eval $(call gb_CppunitTest_use_extra_configuration,sw_subsequent_odfexport,\ + $(OUTDIR)/unittest/registry \ +)) + +# vim: set noet sw=4 ts=4: diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk index 0f9d9c5..3a898f7 100644 --- a/sw/Module_sw.mk +++ b/sw/Module_sw.mk @@ -60,6 +60,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sw,\ CppunitTest_sw_subsequent_ww8import \ CppunitTest_sw_subsequent_rtfexport \ CppunitTest_sw_subsequent_rtfimport \ +CppunitTest_sw_subsequent_odfexport \ CppunitTest_sw_subsequent_odfimport \ )) diff --git a/sw/qa/extras/odfexport/data/fdo38244.odt b/sw/qa/extras/odfexport/data/fdo38244.odt new file mode 100644 index 000..0fcc168 Binary files /dev/null and b/sw/qa/extras/odfexport/data/fdo38244.odt differ diff --git a/sw/qa/extras/odfexport/odfexport.cxx b/sw/qa/extras/odfexport/odfexport.cxx new file mode 100644 index 000..4792508 --- /dev/null +++ b/sw/qa/extras/odfexport/odfexport.cxx @@ -0,0 +1,95 @@ +/* + * Version: MPL 1.1 / GPLv3+ / LGPLv3+ + * + * The contents of this file are subject to the Mozilla Public License Version + * 1.1 (the "License"); you may not use this file except in c
