date:20121014

[Libreoffice-commits] .: scp2/source

2012-10-14 Thread Libreoffice Gerrit user

 scp2/source/ooo/file_ooo.scp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6f3a300c17031c6edcf4e89cd58a08c1e21b9030
Author: David Tardon 
Date:   Mon Oct 15 08:50:25 2012 +0200

pyfax.zip has been renamed

Change-Id: I981ea3a52b8f2bbf3068d19832f1358a340bd96b

diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index 5535210..41a0486 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -491,7 +491,7 @@ End
 File gid_File_Wizards_Fax
 Dir = gid_Dir_Wizards_Fax;
 ARCHIVE_TXT_FILE_BODY;
-Name = "pyfax.zip";
+Name = "fax.zip";
 End
 
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: openldap/makefile.mk

2012-10-14 Thread Libreoffice Gerrit user

 openldap/makefile.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3425c514bc6bb1bb0eda060606120c3e063f99ab
Author: Tor Lillqvist 
Date:   Mon Oct 15 09:37:14 2012 +0300

Don't be paranoid, surely all our platforms have a working memcmp()

The openldap configury thinks it's safest to assume memcmp() isn't
working if it can't run a test program when cross-compiling. Meh.

Change-Id: I4cd580f91b83de558f841d4dba781e8551aace34

diff --git a/openldap/makefile.mk b/openldap/makefile.mk
index d152294..44b710e 100644
--- a/openldap/makefile.mk
+++ b/openldap/makefile.mk
@@ -39,7 +39,7 @@ CONFIGURE_ACTION=.$/configure
 CONFIGURE_FLAGS=--disable-slapd --with-pic --with-tls=moznss 
--without-cyrus-sasl --disable-shared --enable-static
 
 .IF "$(CROSS_COMPILING)"=="YES"
-CONFIGURE_FLAGS+=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) 
--with-yielding_select=yes
+CONFIGURE_FLAGS+=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) 
--with-yielding_select=yes ac_cv_func_memcmp_working=yes
 .ENDIF
 
 .IF "$(SYSTEM_NSS)" == "YES"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-10-14 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=6

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||53482

--- Comment #142 from Rainer Bielefeld  ---
I add "Bug 53482 - UI: Option 'Range contains column headings' ignored" makes
sort useless for many users.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date

2012-10-14 Thread David Tardon

Hi,

On Sun, Oct 14, 2012 at 07:10:35PM -0500, V Stuart Foote wrote:
> LibreOffice versions 3.6.0 and later have not correctly implemented the Java 
> Access Bridge (JAB) modules used to expose the Java Accessibility API roles 
> for Windows users.
>  
> It took me a little while to work out the testing methods, but the Oracle 
> test utilities JavaFerret-32 and JavaMonkey-32 show that LibreOffice is not 
> implementing the Java Accessibility API and therefore does not expose 
> accessibility roles to Assistive Technologies.
>  
> Neither JAB v.2.0.2 or v 2.0.3, nor current JRE version 1.6u35 or 1.7u7 will 
> make a difference.
>  
> I tested LibreOffice builds 3.6.0.4, 3.6.1.2, 3.6.2.2, and 3.6.3.1 none of 
> which are functional.

I guess that java_uno_accessbridge.dll does not export the needed
symbols after gbuildification of module accessibility, in which case
commit d475a059fc9f07f4d896bd67649c7d800fc66f6f should fix the problem.
Any testers/reviewers?

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: accessibility/bridge

2012-10-14 Thread Libreoffice Gerrit user

 accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit d475a059fc9f07f4d896bd67649c7d800fc66f6f
Author: David Tardon 
Date:   Mon Oct 15 07:13:23 2012 +0200

export symbols after gbuildification

Change-Id: I5c8ef1009a65fa5a38174898f58f9146e1367aa9

diff --git a/accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx 
b/accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx
index cb0fa44..5b66b22 100644
--- a/accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx
+++ b/accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx
@@ -68,12 +68,12 @@ jmethodID g_jmRevokeTopWindow = 0;
 // functions
 //
 
-JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM *, void *)
+SAL_DLLPUBLIC_EXPORT jint JNICALL JNI_OnLoad(JavaVM *, void *)
 {
 return JNI_VERSION_1_2;
 }
 
-JNIEXPORT jbyteArray JNICALL
+SAL_DLLPUBLIC_EXPORT jbyteArray JNICALL
 
Java_org_openoffice_accessibility_WindowsAccessBridgeAdapter_getProcessID(JNIEnv
 *pJNIEnv, jclass clazz)
 {
 // Initialize global class and method references
@@ -109,7 +109,7 @@ 
Java_org_openoffice_accessibility_WindowsAccessBridgeAdapter_getProcessID(JNIEnv
 return jbaProcessID;
 }
 
-JNIEXPORT jboolean JNICALL
+SAL_DLLPUBLIC_EXPORT jboolean JNICALL
 
Java_org_openoffice_accessibility_WindowsAccessBridgeAdapter_createMapping(JNIEnv
 *, jclass, jlong pointer)
 {
 uno_Environment * pJava_environment = NULL;
@@ -165,7 +165,7 @@ 
Java_org_openoffice_accessibility_WindowsAccessBridgeAdapter_createMapping(JNIEn
 return JNI_TRUE;
 }
 
-JNIEXPORT void JNICALL JNI_OnUnload(JavaVM *jvm, void *)
+SAL_DLLPUBLIC_EXPORT void JNICALL JNI_OnUnload(JavaVM *jvm, void *)
 {
 ::Application::RemoveEventListener(g_aEventListenerLink);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] fdo#53482 UI: Option 'Range contains column headings' ignored

2012-10-14 Thread Rainer Bielefeld


We have a patch for
,

can someone please review?

CU

Rainer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: nss/nss.patch

2012-10-14 Thread Libreoffice Gerrit user

 nss/nss.patch |   26 ++
 1 file changed, 26 insertions(+)

New commits:
commit 6885fc51b93ee94197aae5e9ae4e9be503bc9903
Author: Tor Lillqvist 
Date:   Mon Oct 15 08:06:53 2012 +0300

Ccache doesn't like several -arch flags

So make sure just one is passed to the compiler.

Change-Id: I217b7ac34ba20e35a23c18df6b497919061ca44c

diff --git a/nss/nss.patch b/nss/nss.patch
index 5d67302..d0e3318 100644
--- a/nss/nss.patch
+++ b/nss/nss.patch
@@ -26,6 +26,32 @@
  RANLIB= ranlib
  
  ifndef CPU_ARCH
+@@ -57,19 +57,25 @@
+ 
+ ifeq (,$(filter-out i%86,$(CPU_ARCH)))
+ ifdef USE_64
++ifeq (,$(findstring -arch ,$(CC)))
+ CC  += -arch x86_64
++endif
+ override CPU_ARCH = x86_64
+ else
+ OS_REL_CFLAGS = -Di386
++ifeq (,$(findstring -arch ,$(CC)))
+ CC  += -arch i386
++endif
+ override CPU_ARCH = x86
+ endif
+ else
+ ifeq (arm,$(CPU_ARCH))
+ # Nothing set for arm currently.
+ else
+ OS_REL_CFLAGS = -Dppc
++ifeq (,$(findstring -arch ,$(CC)))
+ CC  += -arch ppc
++endif
+ endif
+ endif
+ 
 --- misc/nss-3.13.5/mozilla/security/coreconf/FreeBSD.mk   2009-11-23 
05:06:29.0 -0500
 +++ misc/build/nss-3.13.5/mozilla/security/coreconf/FreeBSD.mk 2012-08-28 
20:27:20.0 -0400
 @@ -57,6 +57,7 @@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: settings.mk : subst construct

2012-10-14 Thread David Tardon

Hi,

On Sun, Oct 14, 2012 at 11:31:15PM +0200, Mat M wrote:
> Le Sat, 13 Oct 2012 04:51:26 +0200, Norbert Thiebaud
>  a écrit:
> 
> >On Fri, Oct 12, 2012 at 6:45 PM, Mat M  wrote:
> >>Is the construct legal or is there an issue here ?
> >>If it is legal, I'd love to have an explanation, because I had no great
> >>success when googling.
> >
> >http://www.openoffice.org/tools/dmake/dmake_4.3.html
> 
> Oh,  I assumed it was GNU make stuff.
> 
> >$(subst,pat,replacement data)
> >Will search for pat in data and will replace any occurrence of pat
> >with the replacement string. The expansion
> >
> >$(subst,.o,.c $(OBJECTS))
> >
> >is equivalent to:
> >
> >$(OBJECTS:s/.o/.c/)
> 
> Syntax is different from gmake, so...
> 
> Thank you Norbert
> 
> So, now I took back the code from settings.mk around line 554
> COMMON_OUTDIR:=$(OUTPATH)
> 
> LOCAL_OUT:=$(OUT)
> LOCAL_OUT_FOR_BUILD:=$(OUT_FOR_BUILD)
> LOCAL_COMMON_OUT:=$(subst,$(OUTPATH),$(COMMON_OUTDIR) $(OUT))
> .EXPORT : LOCAL_OUT LOCAL_COMMON_OUT
> 
> here LOCAL_COMMON_OUT:=$(OUT) is enough or am I missing another thing ?

No, you are right. But I would not spend any time looking for possible
improvements in solenv/inc . The old build system based on dmake is
scheduled to die.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] coverty: misuses of strncpy

2012-10-14 Thread Norbert Thiebaud (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/876

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/876/1

coverty: misuses of strncpy

Change-Id: I13b3f176fc37b49e1bb7b191e97ef657eafaebe6
---
M filter/source/graphicfilter/idxf/dxftblrd.cxx
1 file changed, 131 insertions(+), 77 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/876
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13b3f176fc37b49e1bb7b191e97ef657eafaebe6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove some unused methods

2012-10-14 Thread Marcos Souza (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/875

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/875/1

Remove some unused methods

Change-Id: Ia9ed975309c6ed677437c6e1c2d6be4a8bd6f1e9
Signed-off-by: Marcos Paulo de Souza 
---
M sd/source/ui/framework/module/ResourceManager.cxx
M sd/source/ui/framework/module/ResourceManager.hxx
M sd/source/ui/slidesorter/controller/SlsAnimationFunction.cxx
M sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx
M sd/source/ui/view/ViewShellBase.cxx
M unusedcode.easy
6 files changed, 0 insertions(+), 94 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/875
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9ed975309c6ed677437c6e1c2d6be4a8bd6f1e9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] cid 703925 : strncpy can lead to non-null terminated string

2012-10-14 Thread Norbert Thiebaud (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/874

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/874/1

cid 703925 : strncpy can lead to non-null terminated string

Change-Id: Idfe2278d0008715a2e0f06d60df9af430e4df25c
---
M vcl/source/fontsubset/cff.cxx
1 file changed, 2 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/874
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfe2278d0008715a2e0f06d60df9af430e4df25c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 5 commits - sc/inc sc/Module_sc.mk sc/qa sc/source

2012-10-14 Thread Libreoffice Gerrit user

 sc/Module_sc.mk|1 
 sc/inc/postit.hxx  |5 +-
 sc/qa/unit/ucalc.cxx   |   42 ++
 sc/source/core/data/postit.cxx |7 +--
 sc/source/core/data/table2.cxx |6 +--
 sc/source/ui/condformat/condformatdlgentry.cxx |   10 -
 sc/source/ui/inc/anyrefdg.hxx  |   24 ++---
 sc/source/ui/miscdlgs/anyrefdg.cxx |   46 -
 8 files changed, 95 insertions(+), 46 deletions(-)

New commits:
commit aa7500f2231c383e4fd49e94757faccacdde1185
Author: Markus Mohrhard 
Date:   Sat Oct 13 08:42:33 2012 +0200

add a unit test for removing rows/columns with comments

Change-Id: I91d9abdc61f75ba080e092dc9b4e18bdb89b3705

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 8eef410..a5e3a07 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -225,6 +225,8 @@ public:
 void testFindAreaPosColRight();
 void testSort();
 void testSortWithFormulaRefs();
+void testDeleteRow();
+void testDeleteCol();
 
 CPPUNIT_TEST_SUITE(Test);
 CPPUNIT_TEST(testCollator);
@@ -275,6 +277,8 @@ public:
 CPPUNIT_TEST(testFindAreaPosColRight);
 CPPUNIT_TEST(testSort);
 CPPUNIT_TEST(testSortWithFormulaRefs);
+CPPUNIT_TEST(testDeleteRow);
+CPPUNIT_TEST(testDeleteCol);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -5030,6 +5034,44 @@ void Test::testSort()
 pDoc->DeleteTab(0);
 }
 
+void Test::testDeleteRow()
+{
+ScDocument* pDoc = m_xDocShRef->GetDocument();
+rtl::OUString aSheet1("Sheet1");
+pDoc->InsertTab(0, aSheet1);
+
+rtl::OUString aHello("Hello");
+rtl::OUString aJimBob("Jim Bob");
+ScAddress rAddr(1, 1, 0);
+ScPostIt* pNote = m_pDoc->GetNotes(rAddr.Tab())->GetOrCreateNote(rAddr);
+pNote->SetText(rAddr, aHello);
+pNote->SetAuthor(aJimBob);
+
+pDoc->DeleteRow(0, 0, MAXCOL, 0, 1, 1);
+
+CPPUNIT_ASSERT(m_pDoc->GetNotes(0)->empty());
+pDoc->DeleteTab(0);
+}
+
+void Test::testDeleteCol()
+{
+ScDocument* pDoc = m_xDocShRef->GetDocument();
+rtl::OUString aSheet1("Sheet1");
+pDoc->InsertTab(0, aSheet1);
+
+rtl::OUString aHello("Hello");
+rtl::OUString aJimBob("Jim Bob");
+ScAddress rAddr(1, 1, 0);
+ScPostIt* pNote = m_pDoc->GetNotes(rAddr.Tab())->GetOrCreateNote(rAddr);
+pNote->SetText(rAddr, aHello);
+pNote->SetAuthor(aJimBob);
+
+pDoc->DeleteCol(0, 0, MAXROW, 0, 1, 1);
+
+CPPUNIT_ASSERT(m_pDoc->GetNotes(0)->empty());
+pDoc->DeleteTab(0);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 }
commit 8fb84ee62409dec8eb02982c9cf78fb42bf1747e
Author: Markus Mohrhard 
Date:   Sat Oct 13 12:28:36 2012 +0200

sal_Bool to bool in anyrefdg.[ch]xx

Change-Id: I4efa09c0185e7825d5b705ca0171f52b8aae17df

diff --git a/sc/source/ui/inc/anyrefdg.hxx b/sc/source/ui/inc/anyrefdg.hxx
index 247edc0..8b66f68 100644
--- a/sc/source/ui/inc/anyrefdg.hxx
+++ b/sc/source/ui/inc/anyrefdg.hxx
@@ -62,7 +62,7 @@ class ScFormulaReferenceHelper
 SfxBindings*m_pBindings;
 ::std::auto_ptr
 pAccel; // for Enter/Escape
-sal_Bool*   pHiddenMarks;   // Mark field for hidden 
Controls
+bool*   pHiddenMarks;   // Mark field for hidden 
Controls
 SCTAB   nRefTab;// used for ShowReference
 
 String  sOldDialogText; // Original title of the 
dialog window
@@ -72,9 +72,9 @@ class ScFormulaReferenceHelper
 Point   aOldButtonPos;  // Original position of the 
button
 Window* mpOldEditParent;// Original parent of the edit 
field and the button
 
-sal_BoolbEnableColorRef;
-sal_BoolbHighLightRef;
-sal_BoolbAccInserted;
+boolbEnableColorRef;
+boolbHighLightRef;
+boolbAccInserted;
 
 DECL_LINK( AccelSelectHdl, Accelerator* );
 
@@ -89,25 +89,25 @@ public:
 
 voidShowReference( const XubString& rStr );
 voidReleaseFocus( formula::RefEdit* pEdit, 
formula::RefButton* pButton = NULL );
-voidHideReference( sal_Bool bDoneRefMode = sal_True );
+voidHideReference( bool bDoneRefMode = true );
 voidRefInputStart( formula::RefEdit* pEdit, 
formula::RefButton* pButton = NULL );
-voidRefInputDone( sal_Bool bForced = false );
+voidRefInputDone( bool bForced = false );
 voidToggleCollapsed( formula::RefEdit* pEdit, 
formula::RefButton* pButton = NULL );
 
 inline void SetWindow(Window* _pWindow) { m_pWindow = _pWindow; }
-sal_BoolDoClose( sal_uInt16 nId );
-voidSetDispatcherLock( sal_Bool bLock );
-

[Libreoffice-commits] .: sw/inc

2012-10-14 Thread Libreoffice Gerrit user

 sw/inc/acmplwrd.hxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 00e815bd0452f6c68e3ff7a2d4050b6ad410a098
Author: Takeshi Abe 
Date:   Fri Oct 12 22:37:24 2012 +0900

Drop undefined function

Change-Id: I474371f2c35b82a9785b7fa6254bd4e60b4a73e4

diff --git a/sw/inc/acmplwrd.hxx b/sw/inc/acmplwrd.hxx
index 6d86722..09586c8 100644
--- a/sw/inc/acmplwrd.hxx
+++ b/sw/inc/acmplwrd.hxx
@@ -61,8 +61,6 @@ public:
 
 bool InsertWord( const String& rWord, SwDoc& rDoc );
 
-sal_Bool GetRange( const String& rWord, sal_uInt16& rStt, sal_uInt16& rEnd 
) const;
-
 const String& operator[](size_t n) const
 { return m_WordList[n]->GetAutoCompleteString(); }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date

2012-10-14 Thread V Stuart Foote

LibreOffice versions 3.6.0 and later have not correctly implemented the Java 
Access Bridge (JAB) modules used to expose the Java Accessibility API roles for 
Windows users.
 
It took me a little while to work out the testing methods, but the Oracle test 
utilities JavaFerret-32 and JavaMonkey-32 show that LibreOffice is not 
implementing the Java Accessibility API and therefore does not expose 
accessibility roles to Assistive Technologies.
 
Neither JAB v.2.0.2 or v 2.0.3, nor current JRE version 1.6u35 or 1.7u7 will 
make a difference.
 
I tested LibreOffice builds 3.6.0.4, 3.6.1.2, 3.6.2.2, and 3.6.3.1 none of 
which are functional.
 
In addition today I completed testing of ALL builds of LibreOffice from 3.4.5 
to 3.5.7rc2.  With exception of the 3.5.0 build they all correctly map Java 
Accessibility API roles to UNO Accessibility roles. 
 
The Java Accessibility API is not as comprehensive as the IAccessible2 role 
mappings provided by IBM Lotus Symphony 3.0.1, but it is functional for the 3.4 
and 3.5 releases of LibreOffice.  And, for these versions Windows  Assistive 
Technologies will work. For example, the Windows NVDA screen reader will 
function with cursor control and component announcements for the entire 
document tree.
 
Windows versions of LibreOffice 3.6, including the current build 3.6.3 rc1, are 
NOT USEABLE with Assistive Technologies and they have not been usable with 
Windows Assistive Technologies at any point.
 
For folks that I've mislead with my insistence that all is well with 
LibreOffice 3.6 and Java Access Bridge and JRE with use of Assistive 
Technologies like NVDA screen reader I was wrong--I apologize.
I've updated the FDO#53474 (http:  bug report 
https://bugs.freedesktop.org/show_bug.cgi?id=53474 ) and would encourage folks 
to vote, i.e. comment on, the enhancement to implement IAccessible2 API  ( 
http://wiki.documentfoundation.org/Vote_for_Enhancement ) for Windows builds by 
incorporating the IBM contributed Symphony code base as a replacement of the 
Java Accessibility API as that is probably the fastest means of bringing 
Windows builds of LibreOffice to the same functional level as Linux builds that 
use the ATK AT-SPI accessibility APIs.
 
Stuart
 
 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] More rtl::OUString cleanup in basctl

2012-10-14 Thread Ricardo Montania (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/873

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/873/1

More rtl::OUString cleanup in basctl

Change-Id: Ife2754b17e111c0e129670b95bd2e16d81ad906c
---
M basctl/source/basicide/moduldlg.hxx
M basctl/source/basicide/scriptdocument.cxx
2 files changed, 93 insertions(+), 97 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/873
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife2754b17e111c0e129670b95bd2e16d81ad906c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ANNOUNCE] Fax wizard replaced

2012-10-14 Thread Xisco Faulí

Hello all,

I've just pushed a commit to master that replace the java fax wizard with
the python wizard(1). The wizard works pretty well for me on linux but I
haven't been able to test it on windows nor mac. I'd appreciate if you can
give it a try and give me some feedbacks. Go to file -> wizards -> fax and
play a bit.
Probably you'll have to enable python debugging (2) to see the exceptions
in case they're raised.

Greetings

1:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=500edb98783fea1d8f244b0ca0d2eb5b099985e5
2: http://opengrok.libreoffice.org/xref/core/pyuno/README
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] rtl::OUString cleanup in basctl

2012-10-14 Thread Ricardo Montania (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/872

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/872/1

rtl::OUString cleanup in basctl

Change-Id: If57c184b355224f31fdf7872ab1f52c034e5c7f0
---
M basctl/source/basicide/moduldlg.cxx
M basctl/source/basicide/register.cxx
M basctl/source/basicide/sbxitem.cxx
3 files changed, 41 insertions(+), 42 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/872
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If57c184b355224f31fdf7872ab1f52c034e5c7f0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: settings.mk : subst construct

2012-10-14 Thread Mat M

Le Sat, 13 Oct 2012 04:51:26 +0200, Norbert Thiebaud   
a écrit:



On Fri, Oct 12, 2012 at 6:45 PM, Mat M  wrote:

Is the construct legal or is there an issue here ?
If it is legal, I'd love to have an explanation, because I had no great
success when googling.


http://www.openoffice.org/tools/dmake/dmake_4.3.html


Oh,  I assumed it was GNU make stuff.


$(subst,pat,replacement data)
Will search for pat in data and will replace any occurrence of pat
with the replacement string. The expansion

$(subst,.o,.c $(OBJECTS))

is equivalent to:

$(OBJECTS:s/.o/.c/)


Syntax is different from gmake, so...

Thank you Norbert

So, now I took back the code from settings.mk around line 554
COMMON_OUTDIR:=$(OUTPATH)

LOCAL_OUT:=$(OUT)
LOCAL_OUT_FOR_BUILD:=$(OUT_FOR_BUILD)
LOCAL_COMMON_OUT:=$(subst,$(OUTPATH),$(COMMON_OUTDIR) $(OUT))
.EXPORT : LOCAL_OUT LOCAL_COMMON_OUT

here LOCAL_COMMON_OUT:=$(OUT) is enough or am I missing another thing ?

PS: Sorry for single-psting you Norbert, it was too late in the night.
--
Mat M
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Proposal for fdo#42974 and moz/zipped also

2012-10-14 Thread Mathias M (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/871

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/871/1

Proposal for fdo#42974 and moz/zipped also

wget for moz and cp for VS2005 CRT.

(amend tabs 2 spaces)

Change-Id: Ie90c2d82d262b2c23b84593e7952c7d798aa65da
---
M configure.in
1 file changed, 42 insertions(+), 25 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/871
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie90c2d82d262b2c23b84593e7952c7d798aa65da
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mathias M 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Proposal for fdo#42974 and moz/zipped also

2012-10-14 Thread Mathias M (via Code Review)

Mathias M has abandoned this change.

Change subject: Proposal for fdo#42974 and moz/zipped also
..


Patch Set 1: Abandoned

Tabs instead of spaces. will resubmit

--
To view, visit https://gerrit.libreoffice.org/870
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I41554e795fc18c026b6b49e6bcb9894b5257f641
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mathias M 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Proposal for fdo#42974 and moz/zipped also

2012-10-14 Thread Mathias M (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/870

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/870/1

Proposal for fdo#42974 and moz/zipped also

wget for moz and cp for VS2005 CRT.

Change-Id: I41554e795fc18c026b6b49e6bcb9894b5257f641
---
M configure.in
1 file changed, 40 insertions(+), 23 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/870
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41554e795fc18c026b6b49e6bcb9894b5257f641
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mathias M 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

FDO#38813 Easy Hack

2012-10-14 Thread Joel Madero


Hi All,

Another potential easy hack. If a developer could comment to direct to 
appropriate code and offer to "mentor" a beginner developer if they 
choose to take it on that would be really helpful. Thanks all


https://bugs.freedesktop.org/show_bug.cgi?id=38813

Regards,
Joel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 3 commits - cairo/cairo-1.10.2.patch cairo/pixman-0.24.4.patch hunspell/makefile.mk mythes/makefile.mk xpdf/makefile.mk

2012-10-14 Thread Libreoffice Gerrit user

 cairo/cairo-1.10.2.patch  |9 +
 cairo/pixman-0.24.4.patch |9 +
 hunspell/makefile.mk  |1 +
 mythes/makefile.mk|1 +
 xpdf/makefile.mk  |8 
 5 files changed, 24 insertions(+), 4 deletions(-)

New commits:
commit 729ebb3654b2b84971f8e87fbd437bacf35068f3
Author: Tor Lillqvist 
Date:   Sun Oct 14 22:01:22 2012 +0300

Handle the CPPRUNTIME crack

Change-Id: Id2b4758d979f8b8d2273e2ba8ddbe850eecc3b04

diff --git a/hunspell/makefile.mk b/hunspell/makefile.mk
index 16721d7..16a1adb 100644
--- a/hunspell/makefile.mk
+++ b/hunspell/makefile.mk
@@ -80,6 +80,7 @@ CONFIGURE_FLAGS+=CPPFLAGS="$(EXTRA_CDEFS)"
 
 .IF "$(CROSS_COMPILING)"=="YES"
 CONFIGURE_FLAGS+=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) 
LIBS="$(STDLIBCUIMT)"
+CONFIGURE_FLAGS:=$(subst,CPPRUNTIME,$(STDLIBCPP) $(CONFIGURE_FLAGS))
 .ENDIF
 
 BUILD_ACTION=$(GNUMAKE) -j$(EXTMAXPROCESS)
diff --git a/mythes/makefile.mk b/mythes/makefile.mk
index ce1005d..a8b7439 100644
--- a/mythes/makefile.mk
+++ b/mythes/makefile.mk
@@ -83,6 +83,7 @@ CONFIGURE_FLAGS+=CFLAGS='$(LCL_CONFIGURE_CFLAGS)'
 
 .IF "$(CROSS_COMPILING)"=="YES"
 CONFIGURE_FLAGS+=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) 
gio_can_sniff=no LIBS="$(STDLIBCUIMT)"
+CONFIGURE_FLAGS:=$(subst,CPPRUNTIME,$(STDLIBCPP) $(CONFIGURE_FLAGS))
 .ENDIF
 
 BUILD_ACTION=make
commit 22bf1df8ca4be32ca368458d022d48d0adcb62d1
Author: Tor Lillqvist 
Date:   Sun Oct 14 21:47:44 2012 +0300

Filter out fairly pointless ld warning from crt1.o (!) in the 10.4 SDK

Unfortunately the pixman and cairo configury consider any non-empty
stderr indicating an error, even if it just a warning and the exit
status of the command is success.

Change-Id: I921f72fcfc127d9c34a8db448926e478a82646d6

diff --git a/cairo/cairo-1.10.2.patch b/cairo/cairo-1.10.2.patch
index d13c1e4..fce1149 100644
--- a/cairo/cairo-1.10.2.patch
+++ b/cairo/cairo-1.10.2.patch
@@ -189,6 +189,15 @@
  
cairo_cv_xml_use=$use_xml
cairo_cv_xml_cache_vars=" BASE REQUIRES CFLAGS 
NONPKGCONFIG_CFLAGS LIBS NONPKGCONFIG_LIBS NONPKGCONFIG_EXTRA_LIBS"
+@@ -32864,7 +32864,7 @@
+ $_compile_program
+ _ACEOF
+ if ac_fn_c_try_link "$LINENO"; then :
+-  cairo_cc_stderr=`test -f conftest.err && cat conftest.err`
++  cairo_cc_stderr=`test -f conftest.err && grep -v 'ld: warning: object file 
compiled with -mlong-branch which is no longer needed.' conftest.err`
+cairo_cc_flag=yes
+ else
+   cairo_cc_stderr=`test -f conftest.err && cat conftest.err`
 --- misc/cairo-1.10.2/src/cairo-deflate-stream.c   2010-06-18 
13:47:12.0 +0200
 +++ misc/build/cairo-1.10.2/src/cairo-deflate-stream.c 2010-06-18 
13:47:12.0 +0200
 @@ -37,7 +37,11 @@
diff --git a/cairo/pixman-0.24.4.patch b/cairo/pixman-0.24.4.patch
index c16ac84..88a44f9 100644
--- a/cairo/pixman-0.24.4.patch
+++ b/cairo/pixman-0.24.4.patch
@@ -112,6 +112,15 @@
   { $as_echo "$as_me:$LINENO: checking whether byte ordering is bigendian" >&5
  $as_echo_n "checking whether byte ordering is bigendian... " >&6; }
  if test "${ac_cv_c_bigendian+set}" = set; then
+@@ -24552,7 +24552,7 @@
+test "$cross_compiling" = yes ||
+$as_test_x conftest$ac_exeext
+}; then
+-  pixman_cc_stderr=`test -f conftest.err && cat conftest.err`
++  pixman_cc_stderr=`test -f conftest.err && grep -v 'ld: warning: object file 
compiled with -mlong-branch which is no longer needed.' conftest.err`
+pixman_cc_flag=yes
+ else
+   $as_echo "$as_me: failed program was:" >&5
 --- misc/pixman-0.24.4/pixman/pixman-utils.c
 +++ misc/build/pixman-0.24.4/pixman/pixman-utils.c
 @@ -27,6 +27,7 @@
commit 0683f53d019a225da7ebe18e1aabfda41c6bb442
Author: Tor Lillqvist 
Date:   Sun Oct 14 18:11:20 2012 +0300

Check for cross-compilation in general

Change-Id: I52cbef2ff90fa4af04c21f043c07fcd2aae8d273

diff --git a/xpdf/makefile.mk b/xpdf/makefile.mk
index 239912b..53b3b67 100644
--- a/xpdf/makefile.mk
+++ b/xpdf/makefile.mk
@@ -88,6 +88,10 @@ CONFIGURE_FLAGS += \
 --prefix=/@.__$(EXTRPATH)
 .END
 
+.IF "$(CROSS_COMPILING)"=="YES"
+CONFIGURE_FLAGS+=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)
+.ENDIF
+
 .IF "$(OS)$(CPU)"=="MACOSXP"
 CXXFLAGS+=-malign-natural
 .EXPORT: CXXFLAGS
@@ -102,10 +106,6 @@ LDFLAGS=-Wl,--enable-runtime-pseudo-reloc-v2
 CONFIGURE_ACTION=./configure
 CONFIGURE_FLAGS+=--without-x --enable-multithreaded --enable-exceptions 
LIBS=-lgdi32
 
-.IF "$(CROSS_COMPILING)"=="YES"
-CONFIGURE_FLAGS+=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)
-.ENDIF
-
 BUILD_ACTION=$(GNUMAKE) -j$(EXTMAXPROCESS)
 .ELSE
 CONFIGURE_ACTION=
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - sd/source svx/source

2012-10-14 Thread Libreoffice Gerrit user

 sd/source/ui/inc/ViewShellBase.hxx  |4 
 sd/source/ui/view/ViewShellBase.cxx |   18 ++
 svx/source/dialog/fntctrl.cxx   |   18 --
 3 files changed, 30 insertions(+), 10 deletions(-)

New commits:
commit 3d1f4649ee72dd85e1d994ac2bdccc3147830bbd
Author: Michael Stahl 
Date:   Sun Oct 14 21:10:38 2012 +0200

FontPrevWin_Impl::CheckScript(): assert that there is text:

If there is no preview text here then aTextWidth will have no entries
and we crash when writing to the non-existing first element.
aText should come from the current SfxViewShell, from the font name
(unless that is ambiguous, e.g. a selection of text with multiple
fonts), or the Window text (Window::GetText(), whatever that is).

diff --git a/svx/source/dialog/fntctrl.cxx b/svx/source/dialog/fntctrl.cxx
index c09f3bf..cc775a5 100644
--- a/svx/source/dialog/fntctrl.cxx
+++ b/svx/source/dialog/fntctrl.cxx
@@ -176,7 +176,6 @@ class FontPrevWin_Impl
 bool m_bCTLEnabled;
 
 
-void_CheckScript();
 public:
 inline FontPrevWin_Impl() :
 pPrinter( NULL ), bDelPrinter( sal_False ),
@@ -213,12 +212,6 @@ public:
 //  sets the 100%-Font-Widths
 };
 
-void FontPrevWin_Impl::CheckScript()
-{
-if( aText != aScriptText )
-_CheckScript();
-}
-
 inline void FontPrevWin_Impl::Invalidate100PercentFontWidth()
 {
 n100PercentFontWidth = n100PercentFontWidthCJK = n100PercentFontWidthCTL = 
-1;
@@ -237,15 +230,19 @@ inline sal_Bool 
FontPrevWin_Impl::Is100PercentFontWidthValid() const
 // class FontPrevWin_Impl ---
 
 /*
- * void FontPrevWin_Impl::_CheckScript()
  * evalutates the scripttypes of the actual string.
  * Afterwards the positions of script change are notified in aScriptChg,
  * the scripttypes in aScriptType.
  * The aTextWidth array will be filled with zero.
  */
-
-void FontPrevWin_Impl::_CheckScript()
+void FontPrevWin_Impl::CheckScript()
 {
+assert(aText.Len()); // must have a preview text here!
+if (aText == aScriptText)
+{
+return; // already initialized
+}
+
 aScriptText = aText;
 
 aScriptChg.clear();
@@ -258,6 +255,7 @@ void FontPrevWin_Impl::_CheckScript()
 xBreak = Reference< XBreakIterator >(xMSF->createInstance(
 ::rtl::OUString("com.sun.star.i18n.BreakIterator") 
),UNO_QUERY);
 }
+assert(xBreak.is()); // no can do without breakiter
 if( xBreak.is() )
 {
 sal_uInt16 nScript = xBreak->getScriptType( aText, 0 );
commit 86b6bf6e53c234e3df951ebb08513b0d4fc47a14
Author: Michael Stahl 
Date:   Sun Oct 14 21:05:15 2012 +0200

sd: fix crash in character format dialog:

When text with different fonts is selected in Draw or Impress, the
character format dialog crashes, because (among other things) the
selected text is not returned by SfxViewShell::GetSelectionText().
Crash was observed both with GraphicViewShellBase and
ImpressViewShellBase as current shell.
Override that method in sd::ViewShellBase to forward to a main shell
that happens to be a DrawViewShell which is not actually a SfxViewShell
but happens to implement GetSelectionText() for mysterious reasons.

diff --git a/sd/source/ui/inc/ViewShellBase.hxx 
b/sd/source/ui/inc/ViewShellBase.hxx
index 089368a..7d1e7d5 100644
--- a/sd/source/ui/inc/ViewShellBase.hxx
+++ b/sd/source/ui/inc/ViewShellBase.hxx
@@ -123,6 +123,10 @@ public:
 */
 virtual void GetState (SfxItemSet& rSet);
 
+/* override these from SfxViewShell */
+virtual String GetSelectionText(sal_Bool);
+virtual sal_Bool HasSelection(sal_Bool) const;
+
 SvBorder GetBorder (bool bOuterResize);
 virtual void InnerResizePixel (const Point& rOrigin, const Size& rSize);
 virtual void OuterResizePixel (const Point& rOrigin, const Size& rSize);
diff --git a/sd/source/ui/view/ViewShellBase.cxx 
b/sd/source/ui/view/ViewShellBase.cxx
index 7648841..d5d1ded 100644
--- a/sd/source/ui/view/ViewShellBase.cxx
+++ b/sd/source/ui/view/ViewShellBase.cxx
@@ -489,7 +489,25 @@ void ViewShellBase::InitializeFramework (void)
 }
 
 
+String ViewShellBase::GetSelectionText(sal_Bool bCompleteWords)
+{
+::boost::shared_ptr const pMainShell(GetMainViewShell());
+DrawViewShell *const pDrawViewShell(
+dynamic_cast(pMainShell.get()));
+return (pDrawViewShell)
+?   pDrawViewShell->GetSelectionText(bCompleteWords)
+:   SfxViewShell::GetSelectionText(bCompleteWords);
+}
 
+sal_Bool ViewShellBase::HasSelection(sal_Bool bText) const
+{
+::boost::shared_ptr const pMainShell(GetMainViewShell());
+DrawViewShell *const pDrawViewShell(
+dynamic_cast(pMainShell.get()));
+return (pDrawViewShell)
+?   pDrawViewShell->HasSelection(bText)
+:   SfxViewShell::HasSelection(bText);
+}
 
 void ViewShellBase::InnerResizePixel (const Point& rOrigin, const Size &rSize)
 {

[PATCH] comment translations german->english sd fusel.cxx and fusel....

2012-10-14 Thread Lennard Wasserthal (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/869

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/869/1

comment translations german->english sd fusel.cxx and fusel.hxx

Change-Id: Iea730a65e4c3a611e30e0f1ee34d291fbdc98c92
Signed-off-by: Lennard 
---
M sd/source/ui/func/fusel.cxx
M sd/source/ui/inc/fusel.hxx
2 files changed, 66 insertions(+), 66 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/869
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea730a65e4c3a611e30e0f1ee34d291fbdc98c92
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lennard Wasserthal 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'feature/killsdf' - solenv/gbuild

2012-10-14 Thread Libreoffice Gerrit user

 solenv/gbuild/InstallModuleTarget.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4147b2646a75add70de4c1659f66fad067c017f8
Author: Zolnai TamÃ¡s 
Date:   Sun Oct 14 17:43:32 2012 +0200

Cleanup in InstallModulTarget.mk

Use global variable directly

Change-Id: Ic8031bd748d4b9407679f83eb728a7d33551c0cf

diff --git a/solenv/gbuild/InstallModuleTarget.mk 
b/solenv/gbuild/InstallModuleTarget.mk
index 66e5ad5..4ea77c9 100644
--- a/solenv/gbuild/InstallModuleTarget.mk
+++ b/solenv/gbuild/InstallModuleTarget.mk
@@ -121,7 +121,7 @@ $(call gb_Output_announce,$(2),$(true),SUM,1)
 MERGEINPUT=`$(gb_MKTEMP)` && \
 echo $(SCP_POFILES) > $${MERGEINPUT} && \
 $(call gb_Helper_abbreviate_dirs,\
-   $(gb_ScpMergeTarget_COMMAND) -p scp2 -i $(3) -o $(1) -m $${MERGEINPUT} 
-l all ) && \
+   $(gb_ScpMergeTarget_COMMAND) -p scp2 -i $(SCP_SOURCE) -o $(1) -m 
$${MERGEINPUT} -l all ) && \
 rm -rf $${MERGEINPUT}
 
 endef
@@ -130,7 +130,7 @@ $(dir $(call gb_ScpMergeTarget_get_target,%))%/.dir :
$(if $(wildcard $(dir $@)),,mkdir -p $(dir $@))
 
 $(call gb_ScpMergeTarget_get_target,%) : $(gb_ScpMergeTarget_TARGET)
-   $(call gb_ScpMergeTarget__command,$@,$*,$(SCP_SOURCE))
+   $(call gb_ScpMergeTarget__command,$@,$*)
 
 .PHONY : $(call gb_ScpMergeTarget_get_clean_target,%)
 $(call gb_ScpMergeTarget_get_clean_target,%) :
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/killsdf' - solenv/gbuild

2012-10-14 Thread Libreoffice Gerrit user

 solenv/gbuild/ExtensionTarget.mk |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 5a898179a1533b2a625be73fa2b662f2aa742b75
Author: Zolnai TamÃ¡s 
Date:   Sun Oct 14 17:34:17 2012 +0200

Correct POFILE definition in ExtensionTarget.mk

For help and help tree files.
Result of $(or $(4),$(3)) can be only a single
filename without relative path and this case $(dir...)
retrun with './'. Otherwise $(dir...) return with the
directory of the file with '/' ending.

Change-Id: Ia636b314779b907796a3395a877e7bc7b1a47292

diff --git a/solenv/gbuild/ExtensionTarget.mk b/solenv/gbuild/ExtensionTarget.mk
index 752eba1..7c94e15 100644
--- a/solenv/gbuild/ExtensionTarget.mk
+++ b/solenv/gbuild/ExtensionTarget.mk
@@ -298,9 +298,9 @@ $(call gb_ExtensionTarget_get_rootdir,$(1))/help/$(5).done 
: \
 ifneq ($(strip $(gb_WITH_LANG)),)
 ifneq ($(filter-out en-US,$(5)),)
 $(call gb_ExtensionTarget_get_workdir,$(1))/help/$(5)/$(3) : \
-   POFILE := $(gb_POLOCATION)/$(5)$(subst $(SRCDIR),,$(2))/$(subst 
/$(lastword $(subst /, ,$(3))),.po,$(3))
+   POFILE := $(gb_POLOCATION)/$(5)$(subst $(SRCDIR),,$(2))$(patsubst 
%/,/%.po,$(patsubst ./,.po,$(dir $(or $(4),$(3)
 $(call gb_ExtensionTarget_get_workdir,$(1))/help/$(5)/$(3) : \
-$(gb_POLOCATION)/$(5)$(subst $(SRCDIR),,$(2))/$(subst /$(lastword 
$(subst /, ,$(3))),.po,$(3))
+$(gb_POLOCATION)/$(5)$(subst $(SRCDIR),,$(2))$(patsubst 
%/,/%.po,$(patsubst ./,.po,$(dir $(or $(4),$(3)
 endif
 endif
 $(call gb_ExtensionTarget_get_workdir,$(1))/help/$(5)/$(3) : \
@@ -338,9 +338,9 @@ $(call gb_ExtensionTarget_get_rootdir,$(1))/help/$(5).done 
: \
 ifneq ($(strip $(gb_WITH_LANG)),)
 ifneq ($(filter-out en-US,$(5)),)
 $(call gb_ExtensionTarget_get_rootdir,$(1))/help/$(5)/$(3) : \
-   POFILE := $(gb_POLOCATION)/$(5)/$(subst $(SRCDIR),,$(2))/$(subst 
/$(lastword $(subst /, ,$(4))),.po,$(4))
+   POFILE := $(gb_POLOCATION)/$(5)$(subst $(SRCDIR),,$(2))$(patsubst 
%/,/%.po,$(patsubst ./,.po,$(dir $(or $(4),$(3)
 $(call gb_ExtensionTarget_get_rootdir,$(1))/help/$(5)/$(3) : \
-$(gb_POLOCATION)/$(5)/$(subst $(SRCDIR),,$(2))/$(subst /$(lastword 
$(subst /, ,$(4))),.po,$(4))
+$(gb_POLOCATION)/$(5)$(subst $(SRCDIR),,$(2))$(patsubst 
%/,/%.po,$(patsubst ./,.po,$(dir $(or $(4),$(3)
 endif
 endif
 $(call gb_ExtensionTarget_get_rootdir,$(1))/help/$(5)/$(3) : \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: framework/source tools/source xmlsecurity/source

2012-10-14 Thread Libreoffice Gerrit user

 framework/source/helper/statusindicatorfactory.cxx |3 +--
 tools/source/fsys/dirent.cxx   |2 +-
 xmlsecurity/source/xmlsec/saxhelper.cxx|1 -
 3 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit a7efb9b8dd0b7deee49975961ca49f6838648614
Author: CaolÃ¡n McNamara 
Date:   Sun Oct 14 16:37:00 2012 +0100

loplugin: fix some indents and unused OUStrings

Change-Id: I1d7256eea7a79453d3cdb85d1edcf824d58d775e

diff --git a/framework/source/helper/statusindicatorfactory.cxx 
b/framework/source/helper/statusindicatorfactory.cxx
index c24aabf..d5ce604 100644
--- a/framework/source/helper/statusindicatorfactory.cxx
+++ b/framework/source/helper/statusindicatorfactory.cxx
@@ -452,8 +452,7 @@ void StatusIndicatorFactory::impl_createProgress()
 VCLStatusIndicator* pVCLProgress = new VCLStatusIndicator(xSMGR, 
xWindow);
 xProgress = css::uno::Reference< css::task::XStatusIndicator 
>(static_cast< css::task::XStatusIndicator* >(pVCLProgress), 
css::uno::UNO_QUERY);
 }
-else
-if (xFrame.is())
+else if (xFrame.is())
 {
 // use frame layouted progress implementation
 css::uno::Reference< css::beans::XPropertySet > xPropSet(xFrame, 
css::uno::UNO_QUERY);
diff --git a/tools/source/fsys/dirent.cxx b/tools/source/fsys/dirent.cxx
index aef1299..6efde8a 100644
--- a/tools/source/fsys/dirent.cxx
+++ b/tools/source/fsys/dirent.cxx
@@ -872,7 +872,7 @@ String DirEntry::GetExtension( char cSep ) const
 const char *p0 = aName.getStr();
 const char *p1 = p0 + aName.getLength() - 1;
 while ( p1 >= p0 && *p1 != cSep )
-p1--;
+p1--;
 
 if ( p1 >= p0 )
 {
diff --git a/xmlsecurity/source/xmlsec/saxhelper.cxx 
b/xmlsecurity/source/xmlsec/saxhelper.cxx
index 3276d17..dbf1b37 100644
--- a/xmlsecurity/source/xmlsec/saxhelper.cxx
+++ b/xmlsecurity/source/xmlsec/saxhelper.cxx
@@ -62,7 +62,6 @@ const xmlChar** attrlist_to_nxmlstr( const cssu::Sequence< 
cssxcsax::XMLAttribut
 xmlChar* attname = NULL ;
 xmlChar* attvalue = NULL ;
 const xmlChar** attrs = NULL ;
-rtl::OUString oustr ;
 
 sal_Int32 nLength = aAttributes.getLength();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/killsdf' - swext/Extension_wiki-publisher.mk

2012-10-14 Thread Libreoffice Gerrit user

 swext/Extension_wiki-publisher.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 72e2db3aba300aa70e47a2bc3b6cad9bcd05c0a8
Author: Zolnai TamÃ¡s 
Date:   Sun Oct 14 17:22:24 2012 +0200

Correct helptree localization in swext

Change-Id: I6d30e96cb9fb0a0800e0b3b0eaa58b98de4d9010

diff --git a/swext/Extension_wiki-publisher.mk 
b/swext/Extension_wiki-publisher.mk
index 6f4e4a3..7f518f6 100644
--- a/swext/Extension_wiki-publisher.mk
+++ b/swext/Extension_wiki-publisher.mk
@@ -68,6 +68,6 @@ $(eval $(call 
gb_Extension_add_helpfile,wiki-publisher,$(SRCDIR)/swext/mediawiki
 $(eval $(call 
gb_Extension_add_helpfile,wiki-publisher,$(SRCDIR)/swext/mediawiki/help,com.sun.wiki-publisher/wiki.xhp,wiki.xhp))
 $(eval $(call 
gb_Extension_add_helpfile,wiki-publisher,$(SRCDIR)/swext/mediawiki/help,com.sun.wiki-publisher/wikisettings.xhp,wikisettings.xhp))
 
-$(eval $(call 
gb_Extension_add_helptreefile,wiki-publisher,$(SRCDIR)/swext/mediawiki/help,/help.tree,/help.tree,com.sun.wiki-publisher))
+$(eval $(call 
gb_Extension_add_helptreefile,wiki-publisher,$(SRCDIR)/swext/mediawiki/help,help.tree,help.tree,com.sun.wiki-publisher))
 
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/killsdf' - sysui/util

2012-10-14 Thread Libreoffice Gerrit user

 sysui/util/checksize.pl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dbc5c63bb3d3855747eeb9ade3e8206aa9f74e95
Author: Zolnai TamÃ¡s 
Date:   Sun Oct 14 17:18:25 2012 +0200

Correct checksize.pl not to work with sdf

Change-Id: I644874f123079a88d0901e77b367b7a35bb44b9e

diff --git a/sysui/util/checksize.pl b/sysui/util/checksize.pl
index 33f66c0..da4104b 100644
--- a/sysui/util/checksize.pl
+++ b/sysui/util/checksize.pl
@@ -70,7 +70,7 @@ sub check   #04.02.2005 13:40
 my $file = shift;
 print "$path$file\n" if ((-e "$path$file") && $is_debug);
 # don't check dpc,flag,rpmflag,sdf [obj for UNX] files, or etc subdirectory
-return if ( ($file =~ /.+\.(dpc|\w*?flag)/) || ($file =~ /.+\.obj/ && 
$ENV{GUI} eq 'UNX') || ($path =~ /.+etc/) || ($path =~ /.+logs/) || ($path =~ 
/.+sdf/) );
+return if ( ($file =~ /.+\.(dpc|\w*?flag)/) || ($file =~ /.+\.obj/ && 
$ENV{GUI} eq 'UNX') || ($path =~ /.+etc/) || ($path =~ /.+logs/) || ($file =~ 
/.+sdf/) );
 if ( -z "$path$file" ) {
 print "Error: $path$file 0 Bytes!\n";
 $err++;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/killsdf' - sdext/Extension_presenter.mk

2012-10-14 Thread Libreoffice Gerrit user

 sdext/Extension_presenter.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5d2f601e391a9acda692f6a3f7f22c676c1379f8
Author: Zolnai TamÃ¡s 
Date:   Sun Oct 14 05:34:33 2012 +0200

Correct helpfile localization in sdext

gb_Extension_add_helpfile second parameter is the
path prefix of en-US source file so it must be in
sourcedir and not in CustomTarget.

Change-Id: Icfb4caab7f9e250b377ef3049a8030ab66454f9d

diff --git a/sdext/Extension_presenter.mk b/sdext/Extension_presenter.mk
index bdd584f..24a6add 100644
--- a/sdext/Extension_presenter.mk
+++ b/sdext/Extension_presenter.mk
@@ -137,7 +137,7 @@ $(eval $(call 
gb_Extension_add_files,presenter-screen,registry/data/org/openoffi
 $(call 
gb_XcuDataTarget_get_target,sdext/source/presenter/registry/data/org/openoffice/Office/ProtocolHandler.xcu)
 \
 ))
 
-$(eval $(call 
gb_Extension_add_helpfile,presenter-screen,$(WORKDIR)/CustomTarget/sdext/source/presenter/help/en-US,com.sun.PresenterScreen-$(PLATFORMID)/presenter.xhp,com.sun.PresenterScreen/presenter.xhp))
+$(eval $(call 
gb_Extension_add_helpfile,presenter-screen,$(SRCDIR)/sdext/source/presenter/help/en-US,com.sun.PresenterScreen-$(PLATFORMID)/presenter.xhp,com.sun.PresenterScreen/presenter.xhp))
 
 $(eval $(call 
gb_Extension_add_helptreefile,presenter-screen,$(SRCDIR)/sdext/source/presenter/help/en-US,/help.tree,com.sun.PresenterScreen/help.tree,com.sun.PresenterScreen-$(PLATFORMID)))
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sfx2/source

2012-10-14 Thread Libreoffice Gerrit user

 sfx2/source/view/viewsh.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 22a550690bc7643ba1157543e15907ebba9444a0
Author: CaolÃ¡n McNamara 
Date:   Sun Oct 14 14:33:21 2012 +0100

Related: fdo#47250 catch harder

Change-Id: Ie6b26670a6809fc07b344660111be44cb3e6a011

diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index c61e300..f6c2eb5 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -2050,7 +2050,7 @@ sal_Bool SfxViewShell::TryContextMenuInterception( Menu& 
rIn, const ::rtl::OUStr
 continue;
 }
 }
-catch (const uno::RuntimeException&)
+catch (...)
 {
 aIt.remove();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: icon-themes/tango icon-themes/tango_testing

2012-10-14 Thread Libreoffice Gerrit user

 icon-themes/tango/cmd/lc_view100.png |binary
 icon-themes/tango_testing/cmd/lc_view100.png |binary
 2 files changed

New commits:
commit a4c99d39e5f84c10eb7f7dfa6a0ad053028b70bc
Author: Ivan Timofeev 
Date:   Sun Oct 14 17:07:26 2012 +0400

fdo#55927: copy .uno:View100 icon from .uno:Zoom100Percent

Change-Id: Ia89854011db4ccfdb889da91f88ed7aef57dbec7

diff --git a/icon-themes/tango/cmd/lc_view100.png 
b/icon-themes/tango/cmd/lc_view100.png
new file mode 100644
index 000..97c325f
Binary files /dev/null and b/icon-themes/tango/cmd/lc_view100.png differ
diff --git a/icon-themes/tango_testing/cmd/lc_view100.png 
b/icon-themes/tango_testing/cmd/lc_view100.png
new file mode 100644
index 000..9761f7a
Binary files /dev/null and b/icon-themes/tango_testing/cmd/lc_view100.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] Added stream sanity checking to TGA filter

2012-10-14 Thread Norbert Thiebaud (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/864

Approvals:
  Norbert Thiebaud: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/864
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6bb9f28e76ea012ac46b74e3cea0e27fd86741e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marc-André Laverdière 
Gerrit-Reviewer: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: filter/source

2012-10-14 Thread Libreoffice Gerrit user

 filter/source/graphicfilter/itga/itga.cxx |   67 --
 1 file changed, 63 insertions(+), 4 deletions(-)

New commits:
commit 98ad35dc5ad0b603b46e0160f7fd4eed555e2a02
Author: Marc-AndrÃ© LaverdiÃ¨re 
Date:   Fri Oct 12 10:58:16 2012 -0400

Added stream sanity checking to TGA filter

Change-Id: If6bb9f28e76ea012ac46b74e3cea0e27fd86741e
Reviewed-on: https://gerrit.libreoffice.org/864
Reviewed-by: Norbert Thiebaud 
Tested-by: Norbert Thiebaud 

diff --git a/filter/source/graphicfilter/itga/itga.cxx 
b/filter/source/graphicfilter/itga/itga.cxx
index 7a00af4..cd54971 100644
--- a/filter/source/graphicfilter/itga/itga.cxx
+++ b/filter/source/graphicfilter/itga/itga.cxx
@@ -123,10 +123,14 @@ TGAReader::TGAReader(SvStream &rTGA)
 
 TGAReader::~TGAReader()
 {
-delete[] mpColorMap;
-delete mpFileHeader;
-delete mpExtension;
-delete mpFileFooter;
+if (mpColorMap != NULL)
+delete[] mpColorMap;
+if (mpFileHeader != NULL)
+delete mpFileHeader;
+if (mpExtension != NULL)
+delete mpExtension;
+if (mpFileFooter != NULL)
+delete mpFileFooter;
 }
 
 // 
---
@@ -182,6 +186,9 @@ sal_Bool TGAReader::ImplReadHeader()
 mpFileHeader->nColorMapXOrigin >> mpFileHeader->nColorMapYOrigin 
>> mpFileHeader->nImageWidth >>
 mpFileHeader->nImageHeight >> mpFileHeader->nPixelDepth >> 
mpFileHeader->nImageDescriptor;
 
+if ( !m_rTGA.good())
+return sal_False;
+
 if ( mpFileHeader->nColorMapType > 1 )
 return sal_False;
 if ( mpFileHeader->nColorMapType == 1 )
@@ -200,6 +207,10 @@ sal_Bool TGAReader::ImplReadHeader()
 mpFileFooter->nSignature[0] >> mpFileFooter->nSignature[1] >> 
mpFileFooter->nSignature[2] >>
 mpFileFooter->nSignature[3] >> mpFileFooter->nPadByte >> 
mpFileFooter->nStringTerminator;
 
+
+if ( !m_rTGA.good())
+return sal_False;
+
 // check for sal_True, VISI, ON-X, FILE in the signatures
 if ( mpFileFooter->nSignature[ 0 ] == 
(('T'<<24)|('R'<<16)|('U'<<8)|'E') &&
  mpFileFooter->nSignature[ 1 ] == 
(('V'<<24)|('I'<<16)|('S'<<8)|'I') &&
@@ -211,6 +222,8 @@ sal_Bool TGAReader::ImplReadHeader()
 {
 m_rTGA.Seek( mpFileFooter->nExtensionFileOffset );
 m_rTGA >> mpExtension->nExtensionSize;
+if ( !m_rTGA.good())
+return sal_False;
 if ( mpExtension->nExtensionSize >= SizeOfTGAExtension )
 {
 mnTGAVersion = 2;
@@ -228,6 +241,8 @@ sal_Bool TGAReader::ImplReadHeader()
 >> mpExtension->nPostageStampOffset >> 
mpExtension->nScanLineOffset
 >> mpExtension->nAttributesType;
 
+if ( !m_rTGA.good())
+return sal_False;
 }
 }
 }
@@ -309,6 +324,8 @@ sal_Bool TGAReader::ImplReadBody()
 while ( nYCount < mpFileHeader->nImageHeight )
 {
 m_rTGA >> nRunCount;
+if ( !m_rTGA.good())
+return sal_False;
 if ( nRunCount & 0x80 ) // a run length packet
 {
 m_rTGA >> nRGB16;
@@ -317,6 +334,8 @@ sal_Bool TGAReader::ImplReadBody()
 nRed = (sal_uInt8)( mpColorMap[ nRGB16 ] >> 16 );
 nGreen = (sal_uInt8)( mpColorMap[ nRGB16 ] >> 8 );
 nBlue = (sal_uInt8)( mpColorMap[ nRGB16 ] );
+if ( !m_rTGA.good())
+return sal_False;
 for ( sal_uInt16 i = 0; i < ( ( nRunCount & 0x7f ) 
+ 1 ); i++ )
 {
 mpAcc->SetPixel( nY, nX, BitmapColor( nRed, 
nGreen, nBlue ) );
@@ -339,11 +358,15 @@ sal_Bool TGAReader::ImplReadBody()
 for ( sal_uInt16 i = 0; i < ( ( nRunCount & 0x7f ) 
+ 1 ); i++ )
 {
 m_rTGA >> nRGB16;
+if ( !m_rTGA.good())
+return sal_False;
 if ( nRGB16 >= mpFileHeader->nColorMapLength )
 return sal_False;
 nRed = (sal_uInt8)( mpColorMap[ nRGB16 ] >> 16 
);
 nGreen = (sal_uInt8)( mpColorMap[ nRGB16 ] >> 
8 );
 nBlue = (sal_uInt8)( mpColorMap[ nRGB16 ] );
+if ( !m_rTGA.good())
+return sal_False;
 mpAcc->SetPixel( nY, nX, Bit

[Libreoffice-commits] .: sw/source

2012-10-14 Thread Libreoffice Gerrit user

 sw/source/filter/ww8/docxattributeoutput.cxx |2 +-
 sw/source/filter/ww8/ww8graf2.cxx|1 -
 sw/source/filter/ww8/ww8par3.cxx |4 ++--
 sw/source/filter/ww8/ww8par5.cxx |1 -
 4 files changed, 3 insertions(+), 5 deletions(-)

New commits:
commit a55b708b27f1b31c8b24da440ca7961b4f110ba8
Author: Miklos Vajna 
Date:   Sun Oct 14 14:26:50 2012 +0200

sw: fix new clang warnings in ww8 filters

Change-Id: I76db821d5388e756d6007dff9af2bc029972ea72

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 1fc4387..5ccf51d 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -650,7 +650,7 @@ void DocxAttributeOutput::WriteFFData(  const FieldInfos& 
rInfos )
 }
 else if ( rInfos.eType == ww::eFORMCHECKBOX )
 {
-rtl::OUString sName, sDefault;
+rtl::OUString sName;
 bool bChecked = false;
 
 FieldMarkParamsHelper params( rFieldmark );
diff --git a/sw/source/filter/ww8/ww8graf2.cxx 
b/sw/source/filter/ww8/ww8graf2.cxx
index 0bafbd2..81bab22 100644
--- a/sw/source/filter/ww8/ww8graf2.cxx
+++ b/sw/source/filter/ww8/ww8graf2.cxx
@@ -529,7 +529,6 @@ SwFrmFmt* SwWW8ImplReader::ImportGraf(SdrTextObj* pTextObj,
 SdrObject* pObject = 0;
 
 WW8PicDesc aPD( aPic );
-String aGrName;
 if (!pMSDffManager)
 pMSDffManager = new SwMSDffManager(*this);
 /*
diff --git a/sw/source/filter/ww8/ww8par3.cxx b/sw/source/filter/ww8/ww8par3.cxx
index 14b0ea4..c6ef0ad 100644
--- a/sw/source/filter/ww8/ww8par3.cxx
+++ b/sw/source/filter/ww8/ww8par3.cxx
@@ -2183,8 +2183,8 @@ void WW8FormulaControl::FormulaRead(SwWw8ControlType 
nWhich,
 // xstzStatText
 sToolTip = read_uInt16_BeltAndBracesString(*pDataStream);
 
-String sEntryMacro = read_uInt16_BeltAndBracesString(*pDataStream);
-String sExitMcr = read_uInt16_BeltAndBracesString(*pDataStream);
+/*String sEntryMacro =*/ read_uInt16_BeltAndBracesString(*pDataStream);
+/*String sExitMcr =*/ read_uInt16_BeltAndBracesString(*pDataStream);
 
 if (nWhich == WW8_CT_DROPDOWN)
 {
diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx
index cc9990e..f53d354 100644
--- a/sw/source/filter/ww8/ww8par5.cxx
+++ b/sw/source/filter/ww8/ww8par5.cxx
@@ -2813,7 +2813,6 @@ static void EnsureMaxLevelForTemplates(SwTOXBase& rBase)
 {
 for (sal_uInt16 nI = MAXLEVEL; nI > 0; --nI)
 {
-String sStyles(rBase.GetStyleNames(nI-1));
 if (rBase.GetStyleNames(nI-1).Len())
 {
 rBase.SetLevel(nI);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sc/source

2012-10-14 Thread Libreoffice Gerrit user

 sc/source/ui/condformat/condformatdlgentry.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 17f1e4ca172ca154aab83c74081cec5c20b532ad
Author: Julien Nabet 
Date:   Sun Oct 14 12:33:29 2012 +0200

Fix consecutive breaks

Change-Id: I341e42bc784f2e9b87a8e30de7de8ff1dc4fe6ca

diff --git a/sc/source/ui/condformat/condformatdlgentry.cxx 
b/sc/source/ui/condformat/condformatdlgentry.cxx
index 58f59bb..1588bc4 100644
--- a/sc/source/ui/condformat/condformatdlgentry.cxx
+++ b/sc/source/ui/condformat/condformatdlgentry.cxx
@@ -552,8 +552,6 @@ void SetColorScaleEntry( ScColorScaleEntry* pEntry, const 
ListBox& rType, const
 case COLORSCALE_MIN:
 case COLORSCALE_MAX:
 break;
-break;
-break;
 case COLORSCALE_PERCENTILE:
 case COLORSCALE_VALUE:
 case COLORSCALE_PERCENT:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sw/source

2012-10-14 Thread Libreoffice Gerrit user

 sw/source/ui/envelp/labimp.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 45ee4f61e16db5dddf6e4fed906900f8c475a81d
Author: Julien Nabet 
Date:   Sun Oct 14 12:11:05 2012 +0200

Fix member not initialized in the constructor in sw/source/ui/envelp

Change-Id: I78b09bb229ba4ab0c1eae276727153254045db1f

diff --git a/sw/source/ui/envelp/labimp.hxx b/sw/source/ui/envelp/labimp.hxx
index d4d98dc..ceff174 100644
--- a/sw/source/ui/envelp/labimp.hxx
+++ b/sw/source/ui/envelp/labimp.hxx
@@ -91,7 +91,7 @@
 class SwLabRec
 {
 public:
-SwLabRec() {}
+SwLabRec(): lHDist(0), lVDist(0), lWidth(0), lHeight(0), lLeft(0), 
lUpper(0), lPWidth(0), lPHeight(0), nCols(0), nRows(0), bCont(false) {}
 
 void SetFromItem( const SwLabItem& rItem );
 void FillItem( SwLabItem& rItem ) const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: compilerplugins/README

2012-10-14 Thread Libreoffice Gerrit user

 compilerplugins/README |8 
 1 file changed, 8 insertions(+)

New commits:
commit 1d5c2d83688be8b61083ba6b8f83a593b30e967e
Author: LuboÅ¡ LuÅÃ¡k 
Date:   Sun Oct 14 11:54:04 2012 +0200

document sallogareas compiler check

Change-Id: I72d25ec9a1acafa2bc451e620d5dc5721d849c42

diff --git a/compilerplugins/README b/compilerplugins/README
index 50c7505..2344efb 100644
--- a/compilerplugins/README
+++ b/compilerplugins/README
@@ -40,6 +40,14 @@ Warn about the following construct:
 
 Here either both statements should be inside {} or the second statement in 
indented wrong.
 
+ Sal log areas 
+
+- unknown log area 'foo' (check or extend sal/inc/sal/log-areas.dox) [loplugin]
+
+Check area used in SAL_INFO/SAL_WARN macros against the list in 
sal/inc/sal/log-areas.dox and
+report if the area is not listed there. The fix is either use a proper area or 
add it to the list
+if appropriate.
+
 
 == Code documentation / howtos ==
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: librsvg/ExternalProject_librsvg.mk

2012-10-14 Thread Libreoffice Gerrit user

 librsvg/ExternalProject_librsvg.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f335028a6ba4c2e2ca302a5fc45bfbc8abab0d8d
Author: Tor Lillqvist 
Date:   Sun Oct 14 12:21:50 2012 +0300

Make sure glib-mkenums is found when there is no system one

Change-Id: Ib2c246d0abba0ffe34d6adcc4d63e8fbacc41b74

diff --git a/librsvg/ExternalProject_librsvg.mk 
b/librsvg/ExternalProject_librsvg.mk
index f4d658a..6ad34d8 100755
--- a/librsvg/ExternalProject_librsvg.mk
+++ b/librsvg/ExternalProject_librsvg.mk
@@ -30,6 +30,6 @@ $(call gb_ExternalProject_get_state_target,librsvg,build) :
 LIBRSVG_LIBS="-L$(OUTDIR)/lib -lgdk_pixbuf-2.0 -lpango-1.0 
-lpangocairo-1.0 -lgthread-2.0 -lgio-2.0 -lgmodule-2.0 -lgobject-2.0 -lglib-2.0 
$(if $(filter YES,$(SYSTEM_LIBXML)),$(LIBXML_LIBS),-lxml2) -lcairo -lintl" \
CFLAGS="-I$(OUTDIR)/inc/external -I$(OUTDIR)/inc/external/glib-2.0 
-I$(OUTDIR)/inc/external/gdk-pixbuf-2.0 -I$(OUTDIR)/inc/external/pango-1.0 
-I$(OUTDIR)/inc/cairo" \
LDFLAGS="$(foreach lib,cairo.2 gio-2.0.0 glib-2.0.0 gmodule-2.0.0 
gobject-2.0.0 gthread-2.0.0 intl.8 
pango-1.0.0,-Wl,-dylib_file,@loader_path/lib$(lib).dylib:$(OUTDIR)/lib/lib$(lib).dylib)
 $(if $(filter 
YES,$(SYSTEM_LIBXML)),,-Wl,-dylib_file,@loader_path/../ure-link/lib/libxml2.2.dylib:$(OUTDIR)/lib/libxml2.2.dylib)"
 \
-   && $(GNUMAKE) -j$(EXTMAXPROCESS) \
+   && PATH=$(OUTDIR_FOR_BUILD)/bin:$$PATH $(GNUMAKE) -j$(EXTMAXPROCESS) \
&& touch $@
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] Cleanup and simplification of process.cxx

2012-10-14 Thread Arnaud Versini (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/868

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/868/1

Cleanup and simplification of process.cxx

Change-Id: I2bbc2763eca7c878ead2a325589d8c4bb9210bda
---
M sal/osl/unx/process.cxx
1 file changed, 11 insertions(+), 82 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/868
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bbc2763eca7c878ead2a325589d8c4bb9210bda
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Arnaud Versini 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

41 matches

Mail list logo