Re: GDB - Can I See Every Symbol Called?

2013-01-26 Thread Joel Madero

On 01/26/2013 03:25 AM, Michael Meeks wrote:

Hi Joel,

On Fri, 2013-01-25 at 15:13 -0800, Joel Madero wrote:

I've finally gotten comfortable with gdb as far as break points and
what not. What I want to know is if there is a way for me to see all
symbols called during a given run of soffice.

Not that I know of :-)


  Getting a log that shows every symbol called would allow me to
compare to runs of libreoffice, one where I push "Ok" the other where
I push "Cancel".

True - on the other hand - if you have a dialog - probably it is run
inside an 'Execute' method that (hopefully) is close in the code to
where ok/cancel would be different: ie. the return parameter (or some
such associated with it) from that Execute method is prolly what you
want to follow.


It is the print dialog so I think some strange stuff is happening. Joren 
and I have been working on this and basically we are confident that:


static void lcl_SavePrintUIOptionsToDocumentPrintData

is what is saving print options and that it's being called regardless of 
if cancel or ok is being pushed (no good). So I'm trying to track down 
something that is only called when Cancel is pushed so that I can move 
the above function elsewhere. But unfortunately I can't use gdb for the 
above function -- no clue why but it never appears to work with breaks).


The file in question is sw/source/ui/uno/unotxdoc.cxx

Any pointers appreciated.

Thanks


Best Regards,
Joel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: helpers/help_hid.lst source/text

2013-01-26 Thread Libreoffice Gerrit user
 helpers/help_hid.lst |2 --
 source/text/shared/optionen/01030300.xhp |2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

New commits:
commit c409b0f4447cd04b2c88253aecab3dceedc251df
Author: Caolán McNamara 
Date:   Sun Jan 27 00:22:12 2013 +

update help ids for master password dialog .ui conversion

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 28d7ace..45698c0 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -1472,7 +1472,6 @@ HID_DLG_GLOSS_DECIDE,52976,
 HID_DLG_LOGIN,35838,
 HID_DLG_MAPPING,34842,
 HID_DLG_MASTERPASSWORD_CRT,35841,
-HID_DLG_MASTERPASSWORD_UUI,35840,
 HID_DLG_NAME,33818,
 HID_DLG_NEWERVERSIONWARNING,35848,
 HID_DLG_NEW_USER_IDX,54858,
@@ -2440,7 +2439,6 @@ HID_MAIL_MERGE_CREATE_FROM,54947,
 HID_MAIL_MERGE_INSERT_FIELDS,54948,
 HID_MANAGE_STYLES,33074,
 HID_MD_COPY_TO_CLIPBOARD,53441,
-HID_MD_GLOS_CATEGORY,53435,
 HID_MD_GLOS_DEFINE,53424,
 HID_MD_GLOS_DEFINE_TEXT,53439,
 HID_MD_GLOS_DELETE,53427,
diff --git a/source/text/shared/optionen/01030300.xhp 
b/source/text/shared/optionen/01030300.xhp
index 01e6f56..d440886 100644
--- a/source/text/shared/optionen/01030300.xhp
+++ b/source/text/shared/optionen/01030300.xhp
@@ -74,7 +74,7 @@
 Opens the Enter Master Password 
dialog.
 Enter the master password.
 Enter the master password again.
-Enter the master password to continue.
+Enter the master 
password to continue.
 Connections
 Asks for the master password. If master password is 
correct, shows the Stored Web Connection Information dialog.
 The 
Stored Web Connection Information dialog shows a list of web sites and user 
names that you entered previously. You can select any entry and remove it from 
the list. You can view the password for the selected 
entry.Remove
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: helpcontent2

2013-01-26 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5e11ed7c4383d1b546e694d9b566690a581d589f
Author: Caolán McNamara 
Date:   Sun Jan 27 00:22:12 2013 +

Updated core
Project: help  c409b0f4447cd04b2c88253aecab3dceedc251df

diff --git a/helpcontent2 b/helpcontent2
index c72e13b..c409b0f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c72e13bc83d8adf973470eda98c3885ba64389cc
+Subproject commit c409b0f4447cd04b2c88253aecab3dceedc251df
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 6 commits - sc/source

2013-01-26 Thread Libreoffice Gerrit user
 sc/source/core/data/colorscale.cxx |   16 ++--
 sc/source/filter/xml/XMLStylesImportHelper.cxx |   19 ---
 sc/source/filter/xml/XMLStylesImportHelper.hxx |   12 
 sc/source/filter/xml/xmlcelli.hxx  |4 ++--
 sc/source/filter/xml/xmlcondformat.cxx |6 ++
 5 files changed, 26 insertions(+), 31 deletions(-)

New commits:
commit 6a82a9908cc5b911dd6783cab69ed3dcb6ba66bb
Author: Markus Mohrhard 
Date:   Sun Jan 27 02:34:00 2013 +0100

we need to parse the cell address after import, fdo#59843

Otherwise we may have problems with sheet names from sheets that are not
yet imported.

Change-Id: I99a6507567b7d1018b790a90019cd563fa7323a0

diff --git a/sc/source/filter/xml/xmlcondformat.cxx 
b/sc/source/filter/xml/xmlcondformat.cxx
index 1f0a31b..571426c 100644
--- a/sc/source/filter/xml/xmlcondformat.cxx
+++ b/sc/source/filter/xml/xmlcondformat.cxx
@@ -578,12 +578,10 @@ ScXMLCondContext::ScXMLCondContext( ScXMLImport& rImport, 
sal_uInt16 nPrfx,
 rtl::OUString aExpr2;
 ScConditionMode eMode;
 GetConditionData(sExpression, eMode, aExpr1, aExpr2);
-ScAddress aPos;
-sal_Int32 nIndex = 0;
-ScRangeStringConverter::GetAddressFromString(aPos, sAddress, 
GetScImport().GetDocument(), formula::FormulaGrammar::CONV_ODF, nIndex);
 
-ScCondFormatEntry* pFormatEntry = new ScCondFormatEntry(eMode, aExpr1, 
aExpr2, GetScImport().GetDocument(), aPos, sStyle,
+ScCondFormatEntry* pFormatEntry = new ScCondFormatEntry(eMode, aExpr1, 
aExpr2, GetScImport().GetDocument(), ScAddress(), sStyle,
 rtl::OUString(), 
rtl::OUString(), formula::FormulaGrammar::GRAM_ODFF, 
formula::FormulaGrammar::GRAM_ODFF);
+pFormatEntry->SetSrcString(sAddress);
 
 pFormat->AddEntry(pFormatEntry);
 }
commit 7bd35614757e4e97913ed9b9d3344f800e8514b2
Author: Markus Mohrhard 
Date:   Sun Jan 27 00:04:53 2013 +0100

prevent some unnecessary cycles for large cond format ranges

Change-Id: I48f03a897d1ca876bba0d0becf6b51a300970346

diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index 558b16c..bef5aca 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -291,9 +291,21 @@ std::vector& ScColorFormat::getValues() const
 {
 const ScRange* pRange = aRanges[i];
 SCTAB nTab = pRange->aStart.Tab();
-for(SCCOL nCol = pRange->aStart.Col(); nCol <= pRange->aEnd.Col(); 
++nCol)
+
+SCCOL nColStart = pRange->aStart.Col();
+SCROW nRowStart = pRange->aStart.Row();
+SCCOL nColEnd = pRange->aEnd.Col();
+SCROW nRowEnd = pRange->aEnd.Row();
+
+if(nRowEnd == MAXROW)
+{
+bool bShrunk = false;
+mpDoc->ShrinkToUsedDataArea(bShrunk, nTab, nColStart, 
nRowStart,
+nColEnd, nRowEnd, false);
+}
+for(SCCOL nCol = nColStart; nCol <= nColEnd; ++nCol)
 {
-for(SCROW nRow = pRange->aStart.Row(); nRow <= 
pRange->aEnd.Row(); ++nRow)
+for(SCROW nRow = nRowStart; nRow <= nRowEnd; ++nRow)
 {
 ScAddress aAddr(nCol, nRow, nTab);
 CellType eType = mpDoc->GetCellType(aAddr);
commit 6033eaf5b85e01da61628c65ee92292eb2974617
Author: Markus Mohrhard 
Date:   Sat Jan 26 23:32:03 2013 +0100

we need to use SCROW for row numbers, fdo#59894

This caused an overflow and resulted in adding endless number of values
until a bad_alloc was thrown.

Change-Id: I954acd801eb18e2c2fe6a449048856cb95d0d8b0

diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index 3d36b4d..558b16c 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -293,7 +293,7 @@ std::vector& ScColorFormat::getValues() const
 SCTAB nTab = pRange->aStart.Tab();
 for(SCCOL nCol = pRange->aStart.Col(); nCol <= pRange->aEnd.Col(); 
++nCol)
 {
-for(SCCOL nRow = pRange->aStart.Row(); nRow <= 
pRange->aEnd.Row(); ++nRow)
+for(SCROW nRow = pRange->aStart.Row(); nRow <= 
pRange->aEnd.Row(); ++nRow)
 {
 ScAddress aAddr(nCol, nRow, nTab);
 CellType eType = mpDoc->GetCellType(aAddr);
commit bfc674c2cedfa8a07a67e71d1ca976e2556bef4d
Author: Markus Mohrhard 
Date:   Sat Jan 26 15:20:18 2013 +0100

remove some parameters

Change-Id: Ib812d7092c0f375f253a3db2929b2ea6b63806fa

diff --git a/sc/source/filter/xml/XMLStylesImportHelper.cxx 
b/sc/source/filter/xml/XMLStylesImportHelper.cxx
index d2cfa21..c725de1 100644
--- a/sc/source/filter/xml/XMLStylesImportHelper.cxx
+++ b/sc/source/filter/xml/XMLStylesImportHelper.cxx
@@ -49,9 +49,7 @@ ScMyStyleRanges::~ScMyStyleRanges()
 

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/inc sc/source

2013-01-26 Thread Libreoffice Gerrit user
 sc/inc/drwlayer.hxx  |1 +
 sc/source/core/data/drwlayer.cxx |7 +++
 sc/source/ui/view/viewfun7.cxx   |8 ++--
 3 files changed, 14 insertions(+), 2 deletions(-)

New commits:
commit c4820200312e3d50a12d3605147772759938bcf6
Author: Kohei Yoshida 
Date:   Fri Jan 25 12:57:14 2013 -0500

fdo#59056: Re-calculate cell anchor position of a pasted drawing object.

Else it would re-use the anchor position of the original one (minus the
sheet index which is correctly adjusted).

Change-Id: I52d11eb9953ee7539c9d5da41edd7dd28604587c
Reviewed-on: https://gerrit.libreoffice.org/1869
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/drwlayer.hxx b/sc/inc/drwlayer.hxx
index 298d619..72b980d 100644
--- a/sc/inc/drwlayer.hxx
+++ b/sc/inc/drwlayer.hxx
@@ -166,6 +166,7 @@ public:
 String  GetNewGraphicName( long* pnCounter = NULL ) const;
 voidEnsureGraphicNames();
 
+static bool IsCellAnchored( const SdrObject& rObj );
 static void SetPageAnchored( SdrObject& );
 static void SetCellAnchored( SdrObject&, const ScDrawObjData 
&rAnchor );
 // Updates rAnchor based on position of rObj
diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index 76d6794..8ea4fca 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -1787,6 +1787,13 @@ void ScDrawLayer::UpdateCellAnchorFromPositionEnd( 
SdrObject &rObj, const ScDocu
 pAnchor->maEndOffset.X() = aCellRect.Right()-aObjRect.Left();
 }
 
+bool ScDrawLayer::IsCellAnchored( const SdrObject& rObj )
+{
+// Cell anchored object always has a user data, to store the anchor cell
+// info. If it doesn't then it's page-anchored.
+return GetFirstUserDataOfType(&rObj, SC_UD_OBJDATA) != NULL;
+}
+
 void ScDrawLayer::SetPageAnchored( SdrObject &rObj )
 {
 DeleteFirstUserDataOfType(&rObj, SC_UD_OBJDATA);
diff --git a/sc/source/ui/view/viewfun7.cxx b/sc/source/ui/view/viewfun7.cxx
index c69dc65..63e2f1a 100644
--- a/sc/source/ui/view/viewfun7.cxx
+++ b/sc/source/ui/view/viewfun7.cxx
@@ -172,8 +172,8 @@ void ScViewFunc::PasteDraw( const Point& rLogicPos, 
SdrModel* pModel,
 pDestPage->InsertObject( pNeuObj );
 pScDrawView->AddUndo(new SdrUndoInsertObj( *pNeuObj ));
 
-//  Chart braucht nicht mehr getrennt behandelt zu werden,
-//  weil es seine Daten jetzt selber hat
+if (ScDrawLayer::IsCellAnchored(*pNeuObj))
+ScDrawLayer::SetCellAnchoredFromPosition(*pNeuObj, 
*GetViewData()->GetDocument(), nTab);
 }
 }
 
@@ -238,6 +238,10 @@ void ScViewFunc::PasteDraw( const Point& rLogicPos, 
SdrModel* pModel,
 {
 if ( pObject->ISA(SdrUnoObj) && pObject->GetLayer() != 
SC_LAYER_CONTROLS )
 pObject->NbcSetLayer(SC_LAYER_CONTROLS);
+
+if (ScDrawLayer::IsCellAnchored(*pObject))
+ScDrawLayer::SetCellAnchoredFromPosition(*pObject, 
*GetViewData()->GetDocument(), nTab);
+
 pObject = aIter.Next();
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: connectivity/Library_macab1.mk setup_native/source

2013-01-26 Thread Libreoffice Gerrit user
 connectivity/Library_macab1.mk  |2 ++
 setup_native/source/win32/customactions/shellextensions/makefile.mk |1 +
 2 files changed, 3 insertions(+)

New commits:
commit 7bc44705c0974719b7a198bb5dbf8f9d782d55a8
Author: Michael Stahl 
Date:   Sun Jan 27 01:50:56 2013 +0100

still not enough boost_header

Change-Id: Ic0ee933fbee7368f0af2573ea33a5ce33f4043c4

diff --git a/connectivity/Library_macab1.mk b/connectivity/Library_macab1.mk
index cd2583a7..7126f3b 100644
--- a/connectivity/Library_macab1.mk
+++ b/connectivity/Library_macab1.mk
@@ -29,6 +29,8 @@ $(eval $(call gb_Library_Library,macab1))
 
 $(eval $(call 
gb_Library_set_componentfile,macab1,connectivity/source/drivers/macab/macab1))
 
+$(eval $(call gb_Library_use_external,macab1,boost_headers))
+
 $(eval $(call gb_Library_use_sdk_api,macab1))
 
 $(eval $(call gb_Library_use_libraries,macab1,\
diff --git 
a/setup_native/source/win32/customactions/shellextensions/makefile.mk 
b/setup_native/source/win32/customactions/shellextensions/makefile.mk
index 5840a52..5309614 100644
--- a/setup_native/source/win32/customactions/shellextensions/makefile.mk
+++ b/setup_native/source/win32/customactions/shellextensions/makefile.mk
@@ -34,6 +34,7 @@ USE_DEFFILE=TRUE
 .IF "$(OS)"=="WNT" && "$(WINDOWS_SDK_HOME)"!=""
 
 UWINAPILIB=
+CFLAGS+=-I$(WORKDIR)/UnpackedTarball/boost
 
 SLOFILES = \
 $(SLO)$/startmenuicon.obj \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-4-0' - desktop/source

2013-01-26 Thread Libreoffice Gerrit user
 desktop/source/migration/migration.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 04f2233c6c8a503147105af86ad447f70d33ec71
Author: Stephan Bergmann 
Date:   Fri Jan 25 18:30:23 2013 +0100

fdo#57061: Use a new MIGRATION4 flag file for profile migration LO 3 -> 4

...to avoid missing migrations on Windows and Mac OS X, where existing "3" 
user
profiles got the "MIGRATED" flag file erroneously added when running LO 3
already, presumably due to 6b522673373797bbf53d795d53e0ec45175a5d67 "default
config location has changed, look in old config dir when migrating."

(cherry picked from commit 67d23e3a99bbaaa5a4dff1f8f3a10bd8abd198fb)
Conflicts:
desktop/source/migration/migration.cxx

Change-Id: I8dd50a36450c167d47411834cc06a754affadf6d
Reviewed-on: https://gerrit.libreoffice.org/1867
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/desktop/source/migration/migration.cxx 
b/desktop/source/migration/migration.cxx
index 1b4115a..f56fd24 100644
--- a/desktop/source/migration/migration.cxx
+++ b/desktop/source/migration/migration.cxx
@@ -169,7 +169,7 @@ static const char ITEM_DESCRIPTOR_LABEL[] = "Label";
 
 bool MigrationImpl::alreadyMigrated()
 {
-rtl::OUString 
MIGRATION_STAMP_NAME(RTL_CONSTASCII_USTRINGPARAM("/MIGRATED"));
+rtl::OUString 
MIGRATION_STAMP_NAME(RTL_CONSTASCII_USTRINGPARAM("/MIGRATED4"));
 rtl::OUString aStr = m_aInfo.userdata + MIGRATION_STAMP_NAME;
 File aFile(aStr);
 // create migration stamp, and/or check its existence
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: basebmp/StaticLibrary_basebmp.mk connectivity/Library_macabdrv1.mk

2013-01-26 Thread Libreoffice Gerrit user
 basebmp/StaticLibrary_basebmp.mk  |5 -
 connectivity/Library_macabdrv1.mk |2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)

New commits:
commit a156e66a4f14cf8473187d6f6b7aa6225d04dc41
Author: Michael Stahl 
Date:   Sun Jan 27 01:38:43 2013 +0100

need more boost_headers

Change-Id: Ic58e334acb9d9c89e5466638286c0f42dc36df43

diff --git a/basebmp/StaticLibrary_basebmp.mk b/basebmp/StaticLibrary_basebmp.mk
index 200f46e..f4d7b08 100644
--- a/basebmp/StaticLibrary_basebmp.mk
+++ b/basebmp/StaticLibrary_basebmp.mk
@@ -13,7 +13,10 @@ $(eval $(call 
gb_StaticLibrary_use_package,basebmp,basebmp_inc))
 
 $(eval $(call gb_StaticLibrary_use_sdk_api,basebmp))
 
-$(eval $(call gb_StaticLibrary_use_external,basebmp,vigra_headers))
+$(eval $(call gb_StaticLibrary_use_externals,basebmp,\
+   boost_headers \
+   vigra_headers \
+))
 
 $(eval $(call gb_StaticLibrary_use_libraries,basebmp,\
 basegfx \
diff --git a/connectivity/Library_macabdrv1.mk 
b/connectivity/Library_macabdrv1.mk
index c4e77da..428daa1 100644
--- a/connectivity/Library_macabdrv1.mk
+++ b/connectivity/Library_macabdrv1.mk
@@ -27,6 +27,8 @@
 
 $(eval $(call gb_Library_Library,macabdrv1))
 
+$(eval $(call gb_Library_use_external,macabdrv1,boost_headers))
+
 $(eval $(call gb_Library_use_sdk_api,macabdrv1))
 
 $(eval $(call gb_Library_use_system_darwin_frameworks,macabdrv1,\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sfx2/AllLangResTarget_sfx2.mk

2013-01-26 Thread Libreoffice Gerrit user
 sfx2/AllLangResTarget_sfx2.mk |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit 37bb8bfa61b2738e07dc69532781d08ec890783a
Author: Andras Timar 
Date:   Sat Jan 26 21:46:28 2013 +0100

sfx2/source/control/templateview.src is localizable

Change-Id: Ic21abffa3a889b96e2ce03c9ad997b3924133e66
Reviewed-on: https://gerrit.libreoffice.org/1883
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sfx2/AllLangResTarget_sfx2.mk b/sfx2/AllLangResTarget_sfx2.mk
index 63a2d3a..10c0639 100644
--- a/sfx2/AllLangResTarget_sfx2.mk
+++ b/sfx2/AllLangResTarget_sfx2.mk
@@ -48,6 +48,7 @@ $(eval $(call gb_SrsTarget_add_files,sfx/res,\
 sfx2/source/appl/sfx.src \
 sfx2/source/bastyp/bastyp.src \
 sfx2/source/bastyp/fltfnc.src \
+sfx2/source/control/templateview.src \
 sfx2/source/dialog/alienwarn.src \
 sfx2/source/dialog/dialog.src \
 sfx2/source/dialog/dinfdlg.src \
@@ -77,8 +78,4 @@ $(eval $(call gb_SrsTarget_add_files,sfx/res,\
 sfx2/source/view/view.src \
 ))
 
-$(eval $(call gb_SrsTarget_add_nonlocalized_files,sfx/res,\
-sfx2/source/control/templateview.src \
-))
-
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: connectivity/Library_ado.mk extensions/CppunitTest_extensions_test_update.mk extensions/Library_updchk.mk

2013-01-26 Thread Libreoffice Gerrit user
 connectivity/Library_ado.mk  |2 ++
 extensions/CppunitTest_extensions_test_update.mk |2 ++
 extensions/Library_updchk.mk |2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 8cad36dfcd6e4ae583332bf34b8bbf0ceb19aa9d
Author: Michael Stahl 
Date:   Sat Jan 26 23:56:39 2013 +0100

fix omissions in a53586f4efe26b8875107d04001f4ecec760c343

Change-Id: I65e3fc3e34416b74365490a1cd7cba178ef7eb55

diff --git a/connectivity/Library_ado.mk b/connectivity/Library_ado.mk
index 0d83eae..08a95f5 100644
--- a/connectivity/Library_ado.mk
+++ b/connectivity/Library_ado.mk
@@ -34,6 +34,8 @@ $(eval $(call gb_Library_set_include,ado,\
$$(INCLUDE) \
 ))
 
+$(eval $(call gb_Library_use_external,ado,boost_headers))
+
 $(eval $(call gb_Library_use_sdk_api,ado))
 
 ifeq ($(COM),GCC)
diff --git a/extensions/CppunitTest_extensions_test_update.mk 
b/extensions/CppunitTest_extensions_test_update.mk
index 51e5fc4..b35921f 100644
--- a/extensions/CppunitTest_extensions_test_update.mk
+++ b/extensions/CppunitTest_extensions_test_update.mk
@@ -32,6 +32,8 @@ $(eval $(call 
gb_CppunitTest_add_exception_objects,extensions_test_update, \
extensions/qa/update/test_update \
 ))
 
+$(eval $(call 
gb_CppunitTest_use_external,extensions_test_update,boost_headers))
+
 $(eval $(call gb_CppunitTest_use_libraries,extensions_test_update, \
updchk \
cppu \
diff --git a/extensions/Library_updchk.mk b/extensions/Library_updchk.mk
index 119feda..1cd3b49 100644
--- a/extensions/Library_updchk.mk
+++ b/extensions/Library_updchk.mk
@@ -60,7 +60,7 @@ $(eval $(call gb_Library_add_exception_objects,updchk,\
 ))
 endif # OS WNT
 
-$(eval $(call gb_Library_use_external,updchk,\
+$(eval $(call gb_Library_use_externals,updchk,\
boost_headers \
 curl \
 ))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - sc/inc sc/source xmloff/source

2013-01-26 Thread Libreoffice Gerrit user
 sc/inc/unonames.hxx |1 +
 sc/source/ui/unoobj/chart2uno.cxx   |8 +++-
 xmloff/source/chart/SchXMLTools.cxx |   30 +-
 3 files changed, 33 insertions(+), 6 deletions(-)

New commits:
commit 2b641b29b55c7e8a08dcbbb10927c354059916bd
Author: Kohei Yoshida 
Date:   Wed Jan 23 22:18:05 2013 -0500

fdo#58562: Ensure internal data is always used when pasting to another doc.

Without this, pasting a chart object from one Calc doc to another may
occasionally incorrectly switch to range references *if* the destination
document contains the "right" set of sheet names.  With this fix, pasted
chart objects always switch to internal cached data source when pasting
to another document, while retaining range references when pasting within
the same document.

Change-Id: If1dbc854c5faae62f06ece155fad470b229ca0c7
Reviewed-on: https://gerrit.libreoffice.org/1835
Tested-by: Noel Power 
Reviewed-by: Noel Power 
Reviewed-on: https://gerrit.libreoffice.org/1846
Reviewed-by: Markus Mohrhard 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/unonames.hxx b/sc/inc/unonames.hxx
index ca89837..9ab1856 100644
--- a/sc/inc/unonames.hxx
+++ b/sc/inc/unonames.hxx
@@ -652,6 +652,7 @@
 #define SC_UNONAME_HIDDENVALUES "HiddenValues"
 #define SC_UNONAME_INCLUDEHIDDENCELLS   "IncludeHiddenCells"
 #define SC_UNONAME_HIDDENVALUES "HiddenValues"
+#define SC_UNONAME_USE_INTERNAL_DATA_PROVIDER "UseInternalDataProvider"
 
 // Solver
 #define SC_UNONAME_TIMEOUT  "Timeout"
diff --git a/sc/source/ui/unoobj/chart2uno.cxx 
b/sc/source/ui/unoobj/chart2uno.cxx
index 53656cb..5ea6f54 100644
--- a/sc/source/ui/unoobj/chart2uno.cxx
+++ b/sc/source/ui/unoobj/chart2uno.cxx
@@ -76,7 +76,8 @@ const SfxItemPropertyMapEntry* 
lcl_GetDataProviderPropertyMap()
 {
 static SfxItemPropertyMapEntry aDataProviderPropertyMap_Impl[] =
 {
-{MAP_CHAR_LEN(SC_UNONAME_INCLUDEHIDDENCELLS), 0,
&getBooleanCppuType(),  0, 0 },
+{ MAP_CHAR_LEN(SC_UNONAME_INCLUDEHIDDENCELLS), 0, 
&getBooleanCppuType(), 0, 0 },
+{ MAP_CHAR_LEN(SC_UNONAME_USE_INTERNAL_DATA_PROVIDER), 0, 
&getBooleanCppuType(), 0, 0 },
 {0,0,0,0,0,0}
 };
 return aDataProviderPropertyMap_Impl;
@@ -2327,6 +2328,11 @@ uno::Any SAL_CALL ScChart2DataProvider::getPropertyValue(
 uno::Any aRet;
 if ( rPropertyName == SC_UNONAME_INCLUDEHIDDENCELLS )
 aRet <<= m_bIncludeHiddenCells;
+else if (rPropertyName == SC_UNONAME_USE_INTERNAL_DATA_PROVIDER)
+{
+// This is a read-only property.
+aRet <<= static_cast(m_pDocument->PastingDrawFromOtherDoc());
+}
 else
 throw beans::UnknownPropertyException();
 return aRet;
diff --git a/xmloff/source/chart/SchXMLTools.cxx 
b/xmloff/source/chart/SchXMLTools.cxx
index 2c83c3e..e12de82 100644
--- a/xmloff/source/chart/SchXMLTools.cxx
+++ b/xmloff/source/chart/SchXMLTools.cxx
@@ -380,14 +380,34 @@ Reference< chart2::data::XDataSequence > 
CreateDataSequence(
 return xRet;
 }
 
-try
+bool bUseInternal = false;
+uno::Reference xPropSet(xDataProvider, 
uno::UNO_QUERY);
+if (xPropSet.is())
 {
-xRet.set( xDataProvider->createDataSequenceByRangeRepresentation( 
lcl_ConvertRange( rRange, xDataProvider )));
-SchXMLTools::setXMLRangePropertyAtDataSequence( xRet, rRange );
+try
+{
+sal_Bool bVal;
+uno::Any any = 
xPropSet->getPropertyValue("UseInternalDataProvider");
+if (any >>= bVal)
+bUseInternal = static_cast(bVal);
+}
+catch (const beans::UnknownPropertyException&)
+{
+// Do nothing
+}
 }
-catch( const lang::IllegalArgumentException & )
+
+if (!bUseInternal)
 {
-OSL_FAIL( "could not create data sequence" );
+try
+{
+xRet.set( xDataProvider->createDataSequenceByRangeRepresentation( 
lcl_ConvertRange( rRange, xDataProvider )));
+SchXMLTools::setXMLRangePropertyAtDataSequence( xRet, rRange );
+}
+catch( const lang::IllegalArgumentException & )
+{
+OSL_FAIL( "could not create data sequence" );
+}
 }
 
 if( !xRet.is() && !xChartDoc->hasInternalDataProvider() && 
!rRange.isEmpty() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sw/uiconfig

2013-01-26 Thread Libreoffice Gerrit user
 sw/uiconfig/swriter/ui/captionoptions.ui |   55 ---
 1 file changed, 30 insertions(+), 25 deletions(-)

New commits:
commit 46fcf807a890b0f53b416bdcc0ad1200b18fec6c
Author: Caolán McNamara 
Date:   Sat Jan 26 23:24:09 2013 +

add mnemonic widgets to caption options dialog

and recover the original short-cuts

Change-Id: I2d934cfb3b1ca0ab07489b23dde27fee073a5706

diff --git a/sw/uiconfig/swriter/ui/captionoptions.ui 
b/sw/uiconfig/swriter/ui/captionoptions.ui
index 918a2f1..4cea9a2 100644
--- a/sw/uiconfig/swriter/ui/captionoptions.ui
+++ b/sw/uiconfig/swriter/ui/captionoptions.ui
@@ -1,6 +1,20 @@
 
 
   
+  
+
+  
+  
+
+
+  
+Category first
+  
+  
+Numbering first
+  
+
+  
   
 False
 5
@@ -71,7 +85,10 @@
 True
 False
 start
-Level
+0
+_Level
+True
+level
   
   
 0
@@ -85,7 +102,10 @@
 True
 False
 start
-Separator
+0
+_Separator
+True
+separator
   
   
 0
@@ -143,7 +163,10 @@
 False
 start
 12
+0
 Character style
+True
+style
   
   
 0
@@ -167,13 +190,12 @@
 
 
   
-Apply 
border and shadow
-False
+_Apply 
border and shadow
 True
 True
 False
 start
-False
+True
 0
 True
   
@@ -233,7 +255,10 @@
 False
 start
 12
+0
 Caption 
order
+True
+caption_order
   
   
 0
@@ -292,13 +317,11 @@
 
   
 gtk-ok
-False
 True
 True
 True
 True
 True
-False
 True
   
   
@@ -310,11 +333,9 @@
 
   
 gtk-cancel
-False
 True
 True
 True
-False
 True
   
   
@@ -326,11 +347,9 @@
 
   
 gtk-help
-False
 True
 True
 True
-False
 True
   
   
@@ -355,18 +374,4 @@
   help
 
   
-  
-
-  
-  
-
-
-  
-Category first
-  
-  
-Numbering first
-  
-
-  
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 2 commits - helpers/help_hid.lst source/text

2013-01-26 Thread Libreoffice Gerrit user
 helpers/help_hid.lst   |  118 -
 source/text/shared/01/01100200.xhp |   18 ++---
 2 files changed, 9 insertions(+), 127 deletions(-)

New commits:
commit c72e13bc83d8adf973470eda98c3885ba64389cc
Author: Caolán McNamara 
Date:   Sat Jan 26 23:19:44 2013 +

remove padmin_* ids that don't appear in any help

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 9204734..28d7ace 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -6503,108 +6503,6 @@ 
framework_MultiLineEdit_DLG_LICENSE_ML_LICENSE,1077938699,
 framework_PushButton_DLG_LICENSE_PB_ACCEPT,1077940759,
 framework_PushButton_DLG_LICENSE_PB_DECLINE,1077940758,
 framework_PushButton_DLG_LICENSE_PB_PAGEDOWN,1077940754,
-padmin_CheckBox_RID_ADDP_PAGE_NAME_RID_ADDP_NAME_BOX_DEFAULT,569689095,
-padmin_CheckBox_RID_ADDP_PAGE_NAME_RID_ADDP_NAME_BOX_FAXSWALLOW,569689096,
-padmin_CheckBox_RID_FONTIMPORT_DIALOG_RID_FIMP_BOX_LINKONLY,1091191826,
-padmin_CheckBox_RID_FONTIMPORT_DIALOG_RID_FIMP_BOX_SUBDIRS,1091191827,
-padmin_CheckBox_RID_PADIALOG_RID_PA_CB_CUPSUSAGE,1090126871,
-padmin_CheckBox_RID_RTS_COMMANDPAGE_RID_RTS_CMD_BOX_SWALLOWFAXNO,602506259,
-padmin_CheckBox_RID_RTS_COMMANDPAGE_RID_RTS_CMD_CB_EXTERNAL,602506260,
-padmin_CheckBox_RID_RTS_FONTSUBSTPAGE_RID_RTS_FS_ENABLE_BTN,602489865,
-padmin_ComboBox_RID_ADDP_PAGE_COMMAND_RID_ADDP_CMD_BOX_COMMAND,569708546,
-padmin_ComboBox_RID_ADDP_PAGE_COMMAND_RID_ADDP_CMD_BOX_PDFCOMMAND,569708553,
-padmin_ComboBox_RID_PPDIMPORT_DLG_RID_PPDIMP_LB_PATH,1090195462,
-padmin_ComboBox_RID_RTS_COMMANDPAGE_RID_RTS_CMD_CB_COMMANDS,602509317,
-padmin_ComboBox_RID_RTS_COMMANDPAGE_RIT_RTS_CMD_CB_QUICKCMD,602509334,
-padmin_ComboBox_RID_RTS_FONTSUBSTPAGE_RID_RTS_FS_FROM_BOX,602492932,
-padmin_ComboBox_RID_STRINGQUERYDLG_RID_STRQRY_BOX_NEWNAME,1090179077,
-padmin_Edit_RID_ADDP_PAGE_COMMAND_RID_ADDP_CMD_EDT_PDFDIR,569706503,
-padmin_Edit_RID_ADDP_PAGE_NAME_RID_ADDP_NAME_EDT_FAXNAME,569690117,
-padmin_Edit_RID_ADDP_PAGE_NAME_RID_ADDP_NAME_EDT_NAME,569690116,
-padmin_Edit_RID_ADDP_PAGE_NAME_RID_ADDP_NAME_EDT_PDFNAME,569690118,
-padmin_Edit_RID_FONTIMPORT_DIALOG_RID_FIMP_EDT_FROM,1091192835,
-padmin_Edit_RID_RTS_COMMANDPAGE_RID_RTS_CMD_EDT_PDFDIR,602507280,
-padmin_Edit_RID_RTS_OTHERPAGE_RID_RTS_OTHER_COMMENT_EDT,602441738,
-padmin_Edit_RID_RTS_PWDIALOG_RID_RTS_PWDIALOG_PASS_EDT,1139410949,
-padmin_Edit_RID_RTS_PWDIALOG_RID_RTS_PWDIALOG_USER_EDT,1139410947,
-padmin_Edit_RID_STRINGQUERYDLG_RID_STRQRY_EDT_NEWNAME,1090177026,
-padmin_ListBox_RID_ADDP_PAGE_CHOOSEDRIVER_RID_ADDP_CHDRV_BOX_DRIVER,569675266,
-padmin_ListBox_RID_FONTIMPORT_DIALOG_RID_FIMP_BOX_NEWFONTS,1091194375,
-padmin_ListBox_RID_FONTNAMEDIALOG_RID_FNTNM_LB_FONTS,1090620932,
-padmin_ListBox_RID_PADIALOG_RID_PA_LB_DEV,1090129412,
-padmin_ListBox_RID_RTS_COMMANDPAGE_RID_RTS_CMD_LB_CONFIGURE,602508808,
-padmin_ListBox_RID_RTS_DEVICEPAGE_RID_RTS_DEVICE_DEPTH_BOX,602459660,
-padmin_ListBox_RID_RTS_DEVICEPAGE_RID_RTS_DEVICE_LEVEL_BOX,602459656,
-padmin_ListBox_RID_RTS_DEVICEPAGE_RID_RTS_DEVICE_PPDKEY_BOX,602459652,
-padmin_ListBox_RID_RTS_DEVICEPAGE_RID_RTS_DEVICE_PPDVALUE_BOX,602459654,
-padmin_ListBox_RID_RTS_DEVICEPAGE_RID_RTS_DEVICE_SPACE_BOX,602459658,
-padmin_ListBox_RID_RTS_FONTSUBSTPAGE_RID_RTS_FS_TO_BOX,602492422,
-padmin_ListBox_RID_RTS_PAPERPAGE_RID_RTS_PAPER_DUPLEX_BOX,602476038,
-padmin_ListBox_RID_RTS_PAPERPAGE_RID_RTS_PAPER_ORIENTATION_BOX,602476036,
-padmin_ListBox_RID_RTS_PAPERPAGE_RID_RTS_PAPER_PAPER_BOX,602476034,
-padmin_ListBox_RID_RTS_PAPERPAGE_RID_RTS_PAPER_SLOT_BOX,602476040,
-padmin_MetricField_RID_RTS_OTHERPAGE_RID_RTS_OTHER_BOTTOMMARGIN_BOX,602446344,
-padmin_MetricField_RID_RTS_OTHERPAGE_RID_RTS_OTHER_LEFTMARGIN_BOX,602446338,
-padmin_MetricField_RID_RTS_OTHERPAGE_RID_RTS_OTHER_RIGHTMARGIN_BOX,602446342,
-padmin_MetricField_RID_RTS_OTHERPAGE_RID_RTS_OTHER_TOPMARGIN_BOX,602446340,
-padmin_ModalDialog_RID_ADD_PRINTER_DIALOG,1106509824,
-padmin_ModalDialog_RID_FONTIMPORT_DIALOG,1091190784,
-padmin_ModalDialog_RID_FONTNAMEDIALOG,1090617344,
-padmin_ModalDialog_RID_PADIALOG,1090125824,
-padmin_ModalDialog_RID_PPDIMPORT_DLG,1090191360,
-padmin_ModalDialog_RID_RTS_PWDIALOG,1139408896,
-padmin_ModalDialog_RID_STRINGQUERYDLG,1090174976,
-padmin_ModelessDialog_RID_PROGRESS_DLG,2170421248,
-padmin_MultiListBox_RID_ADDP_PAGE_OLDPRINTERS_RID_ADDP_OLD_BOX_PRINTERS,569723906,
-padmin_MultiListBox_RID_PPDIMPORT_DLG_RID_PPDIMP_LB_DRIVER,1090194437,
-padmin_MultiListBox_RID_RTS_FONTSUBSTPAGE_RID_RTS_FS_SUBST_BOX,602491906,
-padmin_PushButton_RID_ADDP_PAGE_CHOOSEDRIVER_RID_ADDP_CHDRV_BTN_ADD,569676291,
-padmin_PushButton_RID_ADDP_PAGE_CHOOSEDRIVER_RID_ADDP_CHDRV_BTN_REMOVE,569676292,
-padmin_PushButton_RID_ADDP_PAGE_COMMAND_RID_ADDP_CMD_BTN_HELP,569709059,
-padmin_PushButton_RID_ADDP_PAGE_COMMAND_RID_ADDP_CMD_BTN_PDFDIR,569709064,
-padmin_PushButton_RID_ADDP_PAGE_OLDPRINTERS_RID_ADDP_OLD_BTN_SELECTALL,569725443,
-padmin_PushButton_RID_ADD_PRINTER_DIALOG_RID_ADDP_BTN_NEXT,1106514435,
-padmin

[Libreoffice-commits] .: helpcontent2

2013-01-26 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0111cbd6b69192aa4542fb5f39b7e40be0abf753
Author: Caolán McNamara 
Date:   Sat Jan 26 23:19:44 2013 +

Updated core
Project: help  c72e13bc83d8adf973470eda98c3885ba64389cc

diff --git a/helpcontent2 b/helpcontent2
index d6a4e01..c72e13b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d6a4e01ee6738f6a30401605ce2ee019fa94b649
+Subproject commit c72e13bc83d8adf973470eda98c3885ba64389cc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - sc/source

2013-01-26 Thread Libreoffice Gerrit user
 sc/source/ui/view/drawview.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cfd69f75cf50a8730076346ea8db54f2094a5d13
Author: Noel Power 
Date:   Wed Jan 23 15:25:41 2013 +

don't use ScDrawLayer::GetObjDataTab to get Anchor fix for fdo#59325

Seems ScDrawLayer::GetObjDataTab was used mistakenly thinking that only an 
anchor
for that tab would be returned ( but actually whatever anchor is returned 
gets the
tab set )

Change-Id: I5d240f80a9974f6e4032875ed00350c94621bde7
Reviewed-on: https://gerrit.libreoffice.org/1828
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 
Reviewed-on: https://gerrit.libreoffice.org/1837
Reviewed-by: Kohei Yoshida 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx
index 2c13e34..6900932 100644
--- a/sc/source/ui/view/drawview.cxx
+++ b/sc/source/ui/view/drawview.cxx
@@ -765,7 +765,7 @@ void ScDrawView::SyncForGrid( SdrObject* pObj )
 
 ScSplitPos eWhich = pViewData->GetActivePart();
 ScGridWindow* pGridWin = (ScGridWindow*)pViewData->GetActiveWin();
-ScDrawObjData* pData = ScDrawLayer::GetObjDataTab( pObj, nTab );
+ScDrawObjData* pData = ScDrawLayer::GetObjData( pObj );
 if ( pGridWin )
 {
 ScAddress aOldStt;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Licence - agree

2013-01-26 Thread Maxim Darak
All of my past & future contributions to LibreOffice may be licensed under the 
MPL/LGPLv3+ dual license.
--
Maxim Darak

Tel:+421918522851
e-mail:   maxim.da...@gmail.com  
Jabber:  maxim.da...@jabbim.sk
Twitter:  twitter.com/#!/max1md
--

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-qa] Minutes - QA Call 01/25/2013 - 2nd Send, Font Issues

2013-01-26 Thread Joel Madero

Time Start: 1405UTC
Present: Peter, Florian, Joel, Joren, Thorsten

*Completed Action Items*
***Wiki for Hard Hacks – on hold until after release of 4.0 (Joel)
*Wiki page for triage contest (Joel)
*Bibisect Torrent/Mirror – No longer needed with bibisect repository
*Wiki for FDO policies/rules (Joel)
*Get permissions for Joel (Bjoern & Tollef)

*Pending Action Items*
*Bugs which are not touched for long period of time (Florian)
+UNCONFIRMED
 -Not users fault, we will not automate anything and will not 
ask the user for more work on their part.

 +NEEDINFO
- Discussion lead to agreement that automating comment to remind users 
followed by automatic closer of bug after some period of time appropriate
-Follow-up email lead to moving this conversation to QA mailing 
list to get broader consensus..


*Localized BSA (Rob)
+Rob has been in contact with Florian trying to work out details

*Goals
 +Punt until after Release of 4.0

*Hard Hacks (Alll)
+Message on wiki stating that these are on hold until after release 
of 4.0

 *Funding WishList (Everyone)

*Shipping Costs
 +Marc's email thread on member mailing list possible
 - Details need ironed out but having TDF members sign up to be 
“carriers” in their region. They can be responsible for buying “locally” 
and then shipping to prize winners, etc...


*Triage Contest (Everyone)
 +Wiki page up, need to start filling it out
 - https://wiki.documentfoundation.org/Bug_Triage_Contest
 +Date
 -*AGREED: *2 Days after release of 4.1 RC1
-*AGREED: *Length will be 14 days
+*ACTION: *Joel will link page to FDO rules (see below)

*Bibisect
 +No longer need mirrors or torrents because of new bibisect repository

*Wiki Updates (Joel & Joren)
 +QA  and QA-Team 
, not much progress yet

 +*Action: *Joren will add a welcome message to QA wiki
+*Action: *Joel will email everyone on QA-Team list and see if they want 
to stay on that list


*FDO
+Mime Type (Bjoern & Joel)
-Not changed yet to Auto, no word from Tollef
-*Action: *Joel will talk to Bjoern about this
+Version Message
-Bjoern in contact with Tollef about this
+Twitter (Bjoern)
 - No Update
 +Permissions (Joel)
 -Joel now has permissions to permanently or temporarily ban users
 -New wiki describes rules and procedures
 
*https://wiki.documentfoundation.org/FreeDesktop_Rules_Procedures

 -Hopefully this is never needed
 +Metrics
 -None
 +NEW vs. REOPENED
 -Reopened discussion as previously agreed upon structure 
wasn't working
 -*ACTION: *Joel will talk with Bjoern about if we can ask 
Tollef to make it so we can set a bug back to UNCONFIRMED even after 
it's set to WFM
-*AGREED: *If above can be done, we'll ask users to reopen bugs as 
UNCONFIRMED if WFM status not correct so that other QA members can 
easily look into the bug as well. NEW will mean confirmed, REOPENED will 
only be done if the bug was marked as FIXED & is assigned a developer 
but the user says it's not fixed.
-*AGREED: *If above is not possible, we will treat REOPENED the same as 
UNCONFIRMED unless it is assigned a developer. If the bug is not 
assigned and is REOPENED, QA will mark as NEW if we can confirm the 
behavior.


*New Items*
*FDO
+Assigning Bugs
-*AGREED: *At this time QA team “pushing” bugs to developers isn't 
working, we will now only do “pull” philosophy (developers choose their 
own bugs and assign themselves
-*AGREED: *The >300 bugs that are assigned but haven't been touched in 
over 6 months is a problem as developers who could fix bugs will not 
touch bugs that are assigned to someone else. These bugs should be 
unassigned & developers should be placed in CC list.
*Assigned (status NEW or Assigned), No Movement 
6+ 
Months 
 

-*ACTION: *Joel will e-mail developer mailing list with decision, inform 
developers that we will be automating an action to unassign them from 
untouched bugs of over 6 months UNLESS they speak up and say that this 
is a bad plan.

 +FDO #59717 (Most Wanted Enhancement or some such list)
 -No discussion, will discuss at next meeting
 +Default Assignee
  -Joel doesn't like that there is a default assignee email, 
could be confusing for new developers – a friend who has started 
developing for LibreOffice recently pointed this
  -*AGREED: *No real 

[Libreoffice-qa] Minutes - QA Call 01/25/2013

2013-01-26 Thread Joel Madero

Time Start: 1405 UTC
Present: Peter, Florian, Joel, Joren, Thorsten

*Completed Action Items*
***Wiki for Hard Hacks – on hold until after release of 4.0 (Joel)
*Wiki page for triage contest (Joel)
*Bibisect Torrent/Mirror – No longer needed with bibisect repository
*Wiki for FDO policies/rules (Joel)
*Get permissions for Joel (Bjoern & Tollef)

*Pending Action Items*
*Bugs which are not touched for long period of time (Florian)
+UNCONFIRMED
-Not users fault, we will not automate anything and will not ask the 
user for more work on their part.

+NEEDINFO
- Discussion lead to agreement that automating comment to remind users 
followed by automatic closer of bug after some period of time appropriate
-Follow-up email lead to moving this conversation to QA mailing 
list to get broader consensus..


*Localized BSA (Rob)
+Rob has been in contact with Florian trying to work out details

*Goals
+Punt until after Release of 4.0

*Hard Hacks (Alll)
+Message on wiki stating that these are on hold until after release of 4.0
*Funding WishList (Everyone)

*Shipping Costs
+Marc's email thread on member mailing list possible
- Details need ironed out but having TDF members sign up to be 
“carriers” in their region. They can be responsible for buying “locally” 
and then shipping to prize winners, etc...


*Triage Contest (Everyone)
 +Wiki page up, need to start filling it out
- https://wiki.documentfoundation.org/Bug_Triage_Contest
+Date
-*AGREED: *2 Days after release of 4.1 RC1
-*AGREED: *Length will be 14 days
+*ACTION: *Joel will link page to FDO rules (see below)

*Bibisect
+No longer need mirrors or torrents because of new bibisect repository

*Wiki Updates (Joel & Joren)
 +QA  and QA-Team 
, not much progress yet

+*Action: *Joren will add a welcome message to QA wiki
+*Action: *Joel will email everyone on QA-Team list and see if they want 
to stay on that list


*FDO
+Mime Type (Bjoern & Joel)
-Not changed yet to Auto, no word from Tollef
-*Action: *Joel will talk to Bjoern about this
+Version Message
-Bjoern in contact with Tollef about this
+Twitter (Bjoern)
- No Update
+Permissions (Joel)
-Joel now has permissions to permanently or temporarily ban users
-New wiki describes rules and procedures
*https://wiki.documentfoundation.org/FreeDesktop_Rules_Procedures
-Hopefully this is never needed
+Metrics
-None
+NEW vs. REOPENED
-Reopened discussion as previously agreed upon structure wasn't working
-*ACTION: *Joel will talk with Bjoern about if we can ask Tollef to make 
it so we can set a bug back to UNCONFIRMED even after it's set to WFM
-*AGREED: *If above can be done, we'll ask users to reopen bugs as 
UNCONFIRMED if WFM status not correct so that other QA members can 
easily look into the bug as well. NEW will mean confirmed, REOPENED will 
only be done if the bug was marked as FIXED & is assigned a developer 
but the user says it's not fixed.
-*AGREED: *If above is not possible, we will treat REOPENED the same as 
UNCONFIRMED unless it is assigned a developer. If the bug is not 
assigned and is REOPENED, QA will mark as NEW if we can confirm the 
behavior.


*New Items*
*FDO
+Assigning Bugs
-*AGREED: *At this time QA team “pushing” bugs to developers isn't 
working, we will now only do “pull” philosophy (developers choose their 
own bugs and assign themselves
-*AGREED: *The >300 bugs that are assigned but haven't been touched in 
over 6 months is a problem as developers who could fix bugs will not 
touch bugs that are assigned to someone else. These bugs should be 
unassigned & developers should be placed in CC list.
*Assigned (status NEW or Assigned), No Movement 
6+ 
Months 
 

-*ACTION: *Joel will e-mail developer mailing list with decision, inform 
developers that we will be automating an action to unassign them from 
untouched bugs of over 6 months UNLESS they speak up and say that this 
is a bad plan.

+FDO #59717 (Most Wanted Enhancement or some such list)
-No discussion, will discuss at next meeting
+Default Assignee
-Joel doesn't like that there is a default assignee email, could be 
confusing for new developers – a friend who has started developing for 
LibreOffice recently pointed this
-*AGREED: *No real solution for this unfortunately, e-mail is linked to 
IRC bots and other things so removing is not possible. Changing name to 
UNASSIGNED@... would make a mess of FDO

-Solutions welcome here but no action to be taken
+QA 

Re: [PATCH] Restore menu File > Template

2013-01-26 Thread Cor Nouws

Hi Thorsten,

Thorsten Behrens wrote (25-01-13 14:45)

Cor Nouws wrote:

Would love to see this picked for 4.0.0 - therefore the whole discussion
was started.




we briefly touched on this during ESC yesterday - but since according
to https://gerrit.libreoffice.org/#/c/1787/ the patch does not seem to
quite work yet, it was deemed too risky for 4.0.0 for the while. Also
because it would require a translation update in the very last second.

Sorry for that,


It's OK. thanks for reporting.
Of course I should have started earlier on this work - especially since 
I've little experience in this field so for sure that costs a lot of time.


I expect (any way sincerely hope) that there will be improvements on the 
TemplateManager itself too - thought it looks good, functionality is not 
really finished - so that with the 4.0.1 both can be done.


Cheers,
Cor


--
 - Cor
 - http://nl.libreoffice.org
 - www.librelex.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Andras Timar  changed:

   What|Removed |Added

 Depends on|59797   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 3 commits - helpers/help_hid.lst source/text

2013-01-26 Thread Libreoffice Gerrit user
 helpers/help_hid.lst   |7 ---
 source/text/shared/01/01100100.xhp |   20 ++--
 source/text/shared/01/01100400.xhp |8 
 source/text/shared/01/01100600.xhp |   36 ++--
 4 files changed, 20 insertions(+), 51 deletions(-)

New commits:
commit d6a4e01ee6738f6a30401605ce2ee019fa94b649
Author: Caolán McNamara 
Date:   Sat Jan 26 20:51:23 2013 +

update help ids for description info page .ui conversion

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 6cfa697..8bf8491 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -1504,7 +1504,6 @@ HID_DLG_TEXT,38843,
 HID_DLG_UNKNOWNAUTH_UUI,35845,
 HID_DLG_WEBCONNECTION_INFO,39897,
 HID_DLG_WORDCOUNT,54987,
-HID_DOCINFODESC,33076,
 HID_DOCINFODOC,33077,
 HID_DOCINFO_EDT,33070,
 HID_DOCINFO_FRAME,33126,
@@ -7478,9 +7477,6 @@ sfx2_Edit_MD_DDE_LINKEDIT_ED_DDE_APP,1082214450,
 sfx2_Edit_MD_DDE_LINKEDIT_ED_DDE_ITEM,1082214452,
 sfx2_Edit_MD_DDE_LINKEDIT_ED_DDE_TOPIC,1082214451,
 sfx2_Edit_RID_URLOPEN_RID_URLOPEN_URL,1112573955,
-sfx2_Edit_TP_DOCINFODESC_ED_KEYWORDS,541181966,
-sfx2_Edit_TP_DOCINFODESC_ED_THEMA,541181964,
-sfx2_Edit_TP_DOCINFODESC_ED_TITLE,541181962,
 sfx2_Edit_TP_DOCINFODOC_ED_FILE_NAME,541198387,
 sfx2_Edit_TP_DOCINFODOC_FT_CHANGE_VAL,541198340,
 sfx2_Edit_TP_DOCINFODOC_FT_CREATE_VAL,541198344,
@@ -7512,7 +7508,6 @@ sfx2_ModalDialog_RID_WARN_PRINTTRANSPARENCY,1113047040,
 sfx2_MoreButton_DLG_NEW_FILE_BT_MORE,1107391008,
 sfx2_MultiLineEdit_DLG_COMMENTS_ME_VERSIONS,1112705550,
 sfx2_MultiLineEdit_DLG_NEW_FILE_ED_DESC,1107380807,
-sfx2_MultiLineEdit_TP_DOCINFODESC_ED_COMMENT,541182488,
 sfx2_MultiLineEdit_TP_MANAGE_STYLES_ED_DESC,541248011,
 sfx2_NumericField_TP_COMMONPRINTOPTIONS_NF_REDUCEGRADIENTS_STEPCOUNT,576165911,
 sfx2_PushButton_DLG_COMMENTS_PB_CLOSE,1112707592,
diff --git a/source/text/shared/01/01100100.xhp 
b/source/text/shared/01/01100100.xhp
index afd6319..f5c4ff4 100644
--- a/source/text/shared/01/01100100.xhp
+++ b/source/text/shared/01/01100100.xhp
@@ -28,24 +28,24 @@
 
 
 
-
+
 Description
-Contains descriptive information about 
the document.
+Contains 
descriptive information about the document.
 
 
 
 
-
+
 Title
-Enter a title for the 
document.
-
+Enter a title for the 
document.
+
 Subject
-Enter a subject for 
the document. You can use a subject to group documents with similar 
contents.
-
+Enter a subject for 
the document. You can use a subject to group documents with similar 
contents.
+
 Keywords
-Enter the words 
that you want to use to index the content of your document. Keywords must be 
separated by commas. A keyword can contain white space characters or 
semicolons.
-
+Enter the words 
that you want to use to index the content of your document. Keywords must be 
separated by commas. A keyword can contain white space characters or 
semicolons.
+
 Comments
-Enter 
comments to help identify the document.
+Enter comments to 
help identify the document.
 
 
commit 3337597be95c5d2a1ef72371da6e5f7cd7f3763b
Author: Caolán McNamara 
Date:   Sat Jan 26 20:46:39 2013 +

update help ids for statistics info page .ui conversion

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 9209957..6cfa697 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -1510,7 +1510,6 @@ HID_DOCINFO_EDT,33070,
 HID_DOCINFO_FRAME,33126,
 HID_DOCLINKEDIT_URL,38975,
 HID_DOCUMENT_CREATE_REPWIZ,38995,
-HID_DOC_STAT,53173,
 HID_DRAW_TEXT_TOOLBOX,54835,
 HID_DRAW_TOOLBOX,54832,
 HID_DROPCAPS,53168,
@@ -9372,7 +9371,6 @@ sw_PushButton_MD_EDIT_REGION_PB_OPTIONS,1405833771,
 sw_PushButton_MD_EDIT_REGION_PB_PASSWD,1405833779,
 sw_PushButton_TP_CONDCOLL_PB_ASSIGN,878449162,
 sw_PushButton_TP_CONDCOLL_PB_REMOVE,878449161,
-sw_PushButton_TP_DOC_STAT_PB_PDATE,877908499,
 sw_PushButton_TP_ENV_PRT_BTN_PRTSETUP,909677071,
 sw_PushButton_TP_FLD_DB_PB_ADDDB,878711313,
 sw_PushButton_TP_FLD_FUNC_BT_FUNCMACRO,878776910,
diff --git a/source/text/shared/01/01100400.xhp 
b/source/text/shared/01/01100400.xhp
index bca8edc..db6728b 100644
--- a/source/text/shared/01/01100400.xhp
+++ b/source/text/shared/01/01100400.xhp
@@ -42,10 +42,10 @@
 pictures;number of
 OLE objects;number of
 
-
 
+
 Statistics
-Displays statistics for the 
current file.
+Displays 
statistics for the current file.
 
 
   
@@ -88,10 +88,10 @@
 
 Number of 
lines in the file. 
 
-
+
 Update 
 
-Updates the statistics.
+Updates the 
statistics.
 
 
 
commit 4dcc26aac0a3ef12d1a5bd0327898da96b2a4bca
Author: Caolán McNamara 
Date:   Sat Jan 26 20:09:10 2013 +

update help ids for security properties .ui conversion

diff --git a/source/text/shared/01/01100600.xhp 
b/source/text/shared/01/01100600.xhp
index bc79266..03b5861 100644
--- a/source/text/shared/01/01100600.xhp
+++ b/source/text/shared/01/01100600.xhp
@@ -36,6 +36,7 @@
 saving;with password by default
 user data;removing when saving
 
+
 
 Security
 Sets password options for the current 
document.
@@ -44,44 +45,

[Libreoffice-commits] .: 4 commits - helpcontent2 sfx2/uiconfig sw/uiconfig

2013-01-26 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 sfx2/uiconfig/ui/descriptioninfopage.ui  |4 
 sfx2/uiconfig/ui/documentinfopage.ui |   21 +++--
 sfx2/uiconfig/ui/internetinfopage.ui |3 +++
 sw/uiconfig/swriter/ui/statisticsinfopage.ui |   20 ++--
 5 files changed, 37 insertions(+), 13 deletions(-)

New commits:
commit e32c5058c43865eee0d81b3635b8b4c6d8c64f53
Author: Caolán McNamara 
Date:   Sat Jan 26 20:55:48 2013 +

add mnemonic widgets to document info page

Change-Id: I286847cb0f07a416b1810450eb2c873ca19c2932

diff --git a/sfx2/uiconfig/ui/documentinfopage.ui 
b/sfx2/uiconfig/ui/documentinfopage.ui
index 47db29d..72514654 100644
--- a/sfx2/uiconfig/ui/documentinfopage.ui
+++ b/sfx2/uiconfig/ui/documentinfopage.ui
@@ -14,6 +14,7 @@
 0
 _Created:
 True
+showcreate
   
   
 0
@@ -29,6 +30,7 @@
 0
 _Modified:
 True
+showmodify
   
   
 0
@@ -44,6 +46,7 @@
 0
 _Digitally signed:
 True
+showsigned
   
   
 0
@@ -59,6 +62,7 @@
 0
 Last pri_nted:
 True
+showprint
   
   
 0
@@ -74,6 +78,7 @@
 0
 Total _editing 
time:
 True
+showedittime
   
   
 0
@@ -89,6 +94,7 @@
 0
 Re_vision number:
 True
+showrevision
   
   
 0
@@ -203,11 +209,9 @@
 
   
 _Apply user data
-False
 True
 False
 True
-False
 True
 0
 True
@@ -222,11 +226,9 @@
 
   
 Reset
-False
 True
 True
 True
-False
   
   
 2
@@ -238,11 +240,9 @@
 
   
 Di_gital 
Signature...
-False
 True
 True
 True
-False
 True
   
   
@@ -258,6 +258,8 @@
 False
 0
 Template:
+True
+showtemplate
   
   
 0
@@ -287,6 +289,7 @@
 0
 _Size:
 True
+showsize
   
   
 0
@@ -317,6 +320,7 @@
 0
 _Location:
 True
+showlocation
   
   
 0
@@ -347,6 +351,7 @@
 1
 _Type:
 True
+showtype
   
   
 0
@@ -372,11 +377,9 @@
 
   
 Change _Password
-False
 True
 True
 True
-False
 True
   
   
@@ -457,11 +460,9 @@
 
   
 _Read-only
-False
 True
 True
 False
-False
 True
 0
 True
commit b0a3c0faddcb56c6f44f93125a9dbad8f62185c0
Author: Caolán McNamara 
Date:   Sat Jan 26 20:48:36 2013 +

add mnemonic widgets to description info page

Change-Id: Ic9b5a0d39d91ee3546ab49e5c586b16b70298045

diff --git a/sfx2/uiconfig/ui/descriptioninfopage.ui 
b/sfx2/uiconfig/ui/descriptioninfopage.ui
index c4f4212..88f21d5 100644
--- a/sfx2/uiconfig/ui/descriptioninfopage.ui
+++ b/sfx2/uiconfig/ui/descriptioninfopage.ui
@@ -15,6 +15,7 @@
 0
 _Title
 True
+title
   
   
 0
@@ -30,6 +31,7 @@
 0
 _Subject
 True
+subject
   
   
 0
@@ -45,6 +47,7 @@
 0
 _Keywords
 True
+keywords
   
   
 0
@@ -61,6 +64,7 @@
 0
 _Comments
 True
+comments
   
   
 0
commit f8960c77899408a2958b6d6dc942e3b21a6996e7
Author: Caolán McNamara 
Date:   Sat Jan 26 20:43:54 2013 +

add mnemonic widgets to statistics info page

Change-Id: Ife142f262f3f78f25ba3b8b3eaa1a515b21b3da5

diff --git a/sfx2/uiconfig/ui/internetinfopage.ui 
b/sfx2/uiconfig/ui/internetinfopage.ui
index 59a7a9d..28c4e19 100644
--- a/sfx2/uiconfig/ui/internetinfopage.ui
+++ b/sfx2/uiconfig/ui/internetinfopage.ui
@@ -257,6 +257,9 @@
 •
 True
 adjustment1
+
+  
+
   
   
 0
diff --git a/sw/uiconfig/swriter/ui/statisticsinfopage.ui 
b/sw/uiconfig/swriter/ui/statisticsinfopage.ui
index a5d1a10..0fbae92 100644
--- a/sw/uiconfig/swriter/ui/statisticsinfopage.ui
+++ b/sw/uiconfig/swriter/ui/statisticsinfopage.ui
@@ -12,6 +12,8 @@
 False
 0
 Number of Pages:
+True
+nopages
   
   
 0
@@ -26,6 +28,8 @@
 False
 0
 Number of Tables:
+True
+notables
   
   
 0
@@ -40,6 +44,8 @@
 False
 0
 Number of 
Graphics:
+True
+nogrfs
   
   
 0
@@ -54,6 +60,8 @@
 False
 0
 Number of OLE 
Objects:
+True
+nooles
   
   
 

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Joren De Cuyper  changed:

   What|Removed |Added

 Depends on||59797

--- Comment #91 from Joren De Cuyper  ---
I nominate "Bug 59797 - LibreLogo: view -> toolbars: LibreLogo has name "Add-on
1"" because you can't find LibreLogo with it's proper name in the toolbar list.
(it's now called "Add-on 1"). Because this is a big feature (already wide
spread on blogs and fora) ... I nominate it to mab4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: sfx2/AllLangResTarget_sfx2.mk

2013-01-26 Thread Libreoffice Gerrit user
 sfx2/AllLangResTarget_sfx2.mk |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit a843a040ae44b65752c899cbd8179629875339d2
Author: Andras Timar 
Date:   Sat Jan 26 21:46:28 2013 +0100

sfx2/source/control/templateview.src is localizable

Change-Id: Ic21abffa3a889b96e2ce03c9ad997b3924133e66

diff --git a/sfx2/AllLangResTarget_sfx2.mk b/sfx2/AllLangResTarget_sfx2.mk
index 5f4eef1..e1ab892 100644
--- a/sfx2/AllLangResTarget_sfx2.mk
+++ b/sfx2/AllLangResTarget_sfx2.mk
@@ -48,6 +48,7 @@ $(eval $(call gb_SrsTarget_add_files,sfx/res,\
 sfx2/source/appl/sfx.src \
 sfx2/source/bastyp/bastyp.src \
 sfx2/source/bastyp/fltfnc.src \
+sfx2/source/control/templateview.src \
 sfx2/source/dialog/alienwarn.src \
 sfx2/source/dialog/dialog.src \
 sfx2/source/dialog/dinfdlg.src \
@@ -75,8 +76,4 @@ $(eval $(call gb_SrsTarget_add_files,sfx/res,\
 sfx2/source/view/view.src \
 ))
 
-$(eval $(call gb_SrsTarget_add_nonlocalized_files,sfx/res,\
-sfx2/source/control/templateview.src \
-))
-
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 2 commits - forms/source lotuswordpro/source

2013-01-26 Thread Libreoffice Gerrit user
 forms/source/richtext/richtextviewport.cxx|1 +
 lotuswordpro/source/filter/xfilter/xflinenumberconfig.hxx |1 +
 lotuswordpro/source/filter/xfilter/xfstylemanager.hxx |2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 70c88fc75f6aced47a791ce53b761d6aaf773eaf
Author: Julien Nabet 
Date:   Sat Jan 26 21:27:07 2013 +0100

Some cppcheck cleaning

Change-Id: Iab4ff990f71321b75f69bc61a5cda728956ca85c

diff --git a/lotuswordpro/source/filter/xfilter/xflinenumberconfig.hxx 
b/lotuswordpro/source/filter/xfilter/xflinenumberconfig.hxx
index cdc052d..decd260 100644
--- a/lotuswordpro/source/filter/xfilter/xflinenumberconfig.hxx
+++ b/lotuswordpro/source/filter/xfilter/xflinenumberconfig.hxx
@@ -103,6 +103,7 @@ private:
 
 inline XFLineNumberConfig::XFLineNumberConfig()
 {
+m_ePosition = enumXFLineNumberLeft;
 m_fOffset = 0;
 m_nIncrement = 5;
 m_nSepIncrement = 3;
diff --git a/lotuswordpro/source/filter/xfilter/xfstylemanager.hxx 
b/lotuswordpro/source/filter/xfilter/xfstylemanager.hxx
index 0a90560..c4bdeae 100644
--- a/lotuswordpro/source/filter/xfilter/xfstylemanager.hxx
+++ b/lotuswordpro/source/filter/xfilter/xfstylemanager.hxx
@@ -85,7 +85,7 @@ class XFStyleManager// : public IXFObject
 public:
 XFStyleManager();
 ~XFStyleManager();
-XFStyleManager(XFStyleManager&){}
+XFStyleManager(XFStyleManager&);
 
 public:
 /**
commit bc3be8493e3e14f85cedf175edff6db9a786d4dc
Author: Julien Nabet 
Date:   Sat Jan 26 21:15:10 2013 +0100

Fix Member variable m_pView is not initialized in the constructor

Change-Id: I0b18698f23f7c2c446e60069d0efcb6d89b1e5d3

diff --git a/forms/source/richtext/richtextviewport.cxx 
b/forms/source/richtext/richtextviewport.cxx
index 5e190a1..943628e 100644
--- a/forms/source/richtext/richtextviewport.cxx
+++ b/forms/source/richtext/richtextviewport.cxx
@@ -31,6 +31,7 @@ namespace frm
 //
 RichTextViewPort::RichTextViewPort( Window* _pParent )
 :Control ( _pParent )
+,m_pView(NULL)
 ,m_bHideInactiveSelection( true )
 {
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: src/lib

2013-01-26 Thread Libreoffice Gerrit user
 src/lib/VSDContentCollector.cpp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c568de8af9da8e46e789074bfc099bc2d0854ae4
Author: Julien Nabet 
Date:   Sat Jan 26 20:14:31 2013 +0100

Some cppcheck cleaning

diff --git a/src/lib/VSDContentCollector.cpp b/src/lib/VSDContentCollector.cpp
index 1d6915a..cbe2bcb 100644
--- a/src/lib/VSDContentCollector.cpp
+++ b/src/lib/VSDContentCollector.cpp
@@ -1307,7 +1307,7 @@ void 
libvisio::VSDContentCollector::collectNURBSTo(unsigned /* id */, unsigned l
 {
   _handleLevelChange(level);
 
-  if (!knotVector.size() || !controlPoints.size() || !weights.size())
+  if (knotVector.empty() || controlPoints.empty() || weights.empty())
 // Here, maybe we should just draw line to (x2,y2)
 return;
 
@@ -1380,7 +1380,7 @@ void 
libvisio::VSDContentCollector::collectNURBSTo(unsigned /* id */, unsigned l
 double libvisio::VSDContentCollector::_NURBSBasis(unsigned knot, unsigned 
degree, double point, const std::vector &knotVector)
 {
   double basis = 0;
-  if (!knotVector.size())
+  if (knotVector.empty())
 return basis;
   if (degree == 0)
   {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: store/workben

2013-01-26 Thread Libreoffice Gerrit user
 store/workben/t_page.cxx  |   88 ++
 store/workben/t_store.cxx |2 -
 2 files changed, 44 insertions(+), 46 deletions(-)

New commits:
commit b780e8307bfeabf182225f302bb9d62934f0c597
Author: Julien Nabet 
Date:   Sat Jan 26 20:50:51 2013 +0100

Some cppcheck cleaning

diff --git a/store/workben/t_page.cxx b/store/workben/t_page.cxx
index 83be150..d36df00 100644
--- a/store/workben/t_page.cxx
+++ b/store/workben/t_page.cxx
@@ -1305,60 +1305,58 @@ void MappedPageAccess::unmapFile (sal_uInt8 * pData, 
sal_uInt32 nSize)
 
 int SAL_CALL main (int argc, char ** argv)
 {
-  OSL_PRECOND(argc >= 1, "t_page: error: insufficient number of arguments.");
-  if (argc < 1)
-return 0;
+OSL_PRECOND(argc >= 1, "t_page: error: insufficient number of arguments.");
+if (argc < 1)
+return 0;
 
-  {
-void *a = (void*)1, *b = (void*)2;
-swap(a, b);
-  }
-  {
-PageObject a;
-PageObject b (a);
-PageObject c;
-
-c = b;
-a = a;
+{
+void *a = (void*)1, *b = (void*)2;
+swap(a, b);
+}
+{
+PageObject a;
+PageObject b (a);
+PageObject c;
 
-  }
-  {
-  TestBIOS aBIOS;
-  TestClient aClient;
-  aClient.dwim (aBIOS);
-  }
+c = b;
+a = a;
+}
+{
+TestBIOS aBIOS;
+TestClient aClient;
+aClient.dwim (aBIOS);
+}
 
-  if (argc > 1)
-  {
-rtl_uString * pFilename = 0;
-rtl_uString_newFromAscii (&pFilename, argv[1]);
-storeAccessMode eAccessMode = store_AccessReadOnly;
-
-// Acquire file handle.
-ResourceHolder h1;
-oslFileError result = h1.get().initialize (pFilename, 
FilePageAccess::MODE_TO_NATIVE(eAccessMode));
-if (result == osl_File_E_None)
+if (argc > 1)
 {
-  ResourceHolder h2 (h1);
-  h1 = h2;
+rtl_uString * pFilename = 0;
+rtl_uString_newFromAscii (&pFilename, argv[1]);
+storeAccessMode eAccessMode = store_AccessReadOnly;
+
+// Acquire file handle.
+ResourceHolder h1;
+oslFileError result = h1.get().initialize (pFilename, 
FilePageAccess::MODE_TO_NATIVE(eAccessMode));
+if (result == osl_File_E_None)
+{
+ResourceHolder h2 (h1);
+h1 = h2;
 
-  if (eAccessMode == store_AccessReadOnly)
-  {
-ResourceHolder m1;
-result = m1.get().initialize (h1.get());
+if (eAccessMode == store_AccessReadOnly)
+{
+ResourceHolder m1;
+result = m1.get().initialize (h1.get());
 
-const sal_uInt32 nSize = 
sal::static_int_cast(m1.get().m_uSize);
-(void) nSize; // UNUSED
+const sal_uInt32 nSize = 
sal::static_int_cast(m1.get().m_uSize);
+(void) nSize; // UNUSED
 
-ResourceHolder m2 (m1);
-m1 = m2;
+ResourceHolder m2 (m1);
+m1 = m2;
 
-result = osl_File_E_None;
-  }
+return result;
+}
+}
 }
-  }
-
-  return 0;
+return 0;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/store/workben/t_store.cxx b/store/workben/t_store.cxx
index 6e7bc63..7709c58 100644
--- a/store/workben/t_store.cxx
+++ b/store/workben/t_store.cxx
@@ -182,7 +182,7 @@ sal_Bool DirectoryTraveller::visit (const iter& it)
 if (m_nOptions & OPTION_DUMP)
 {
 rtl::OString aName (it.m_pszName, it.m_nLength, RTL_TEXTENCODING_UTF8);
-printf ("Visit(%d,%d): %s [0x%08x] %d [Bytes]\n",
+printf ("Visit(%u,%u): %s [0x%08x] %d [Bytes]\n",
 m_nLevel, m_nCount,
 aName.pData->buffer, (unsigned int)(it.m_nAttrib), (unsigned 
int)(it.m_nSize));
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6

Bug 6 depends on bug 55842, which changed state.

Bug 55842 Summary: no focus on frame outside of page margins for editing
https://bugs.freedesktop.org/show_bug.cgi?id=55842

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 2 commits - helpers/help_hid.lst source/text

2013-01-26 Thread Libreoffice Gerrit user
 helpers/help_hid.lst   |   16 
 source/text/shared/01/01100300.xhp |   14 +-
 source/text/shared/01/01100500.xhp |   37 ++---
 3 files changed, 23 insertions(+), 44 deletions(-)

New commits:
commit a01238220f1bfa2619f9ac37ef82a2f2800e8f16
Author: Caolán McNamara 
Date:   Sat Jan 26 17:31:12 2013 +

update help ids for internet properties .ui conversion

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 0f64dfd..9209957 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -1506,7 +1506,6 @@ HID_DLG_WEBCONNECTION_INFO,39897,
 HID_DLG_WORDCOUNT,54987,
 HID_DOCINFODESC,33076,
 HID_DOCINFODOC,33077,
-HID_DOCINFORELOAD,33092,
 HID_DOCINFO_EDT,33070,
 HID_DOCINFO_FRAME,33126,
 HID_DOCLINKEDIT_URL,38975,
@@ -7466,7 +7465,6 @@ sfx2_CheckBox_TP_HELP_SEARCH_CB_SCOPE,546997263,
 sfx2_CheckBox_TP_MANAGE_STYLES_CB_AUTO,541246476,
 sfx2_ComboBox_DLG_NEW_STYLE_BY_EXAMPLE_LB_COL,805953,
 sfx2_ComboBox_RID_DLG_SEARCH_ED_SEARCH,2187087883,
-sfx2_ComboBox_TP_DOCINFORELOAD_CB_FRAME,541347913,
 sfx2_ComboBox_TP_HELP_INDEX_CB_INDEX,546983947,
 sfx2_ComboBox_TP_HELP_SEARCH_ED_SEARCH,547000331,
 sfx2_Edit_DLG_DOCINFO_EDT_ED_INFO1,1078102021,
@@ -7495,7 +7493,6 @@ sfx2_Edit_TP_DOCINFODOC_FT_PRINT_VAL,541198395,
 sfx2_Edit_TP_DOCINFODOC_FT_SIGNED_VAL,541198413,
 sfx2_Edit_TP_DOCINFODOC_FT_TEMPL_VAL,541198369,
 sfx2_Edit_TP_DOCINFODOC_FT_TIMELOG_VAL,541198372,
-sfx2_Edit_TP_DOCINFORELOAD_ED_URL,541345836,
 sfx2_Edit_TP_MANAGE_STYLES_ED_NAME,541247490,
 sfx2_FT_DOCNAME_DLG_PRINTMONITOR,2218852352,
 sfx2_FloatingWindow_SID_RECORDING_FLOATWINDOW,1705639936,
@@ -7519,8 +7516,6 @@ sfx2_MultiLineEdit_DLG_NEW_FILE_ED_DESC,1107380807,
 sfx2_MultiLineEdit_TP_DOCINFODESC_ED_COMMENT,541182488,
 sfx2_MultiLineEdit_TP_MANAGE_STYLES_ED_DESC,541248011,
 sfx2_NumericField_TP_COMMONPRINTOPTIONS_NF_REDUCEGRADIENTS_STEPCOUNT,576165911,
-sfx2_NumericField_TP_DOCINFORELOAD_ED_FORWARD,541349958,
-sfx2_NumericField_TP_DOCINFORELOAD_ED_RELOAD,541349955,
 sfx2_PushButton_DLG_COMMENTS_PB_CLOSE,1112707592,
 sfx2_PushButton_DLG_NEW_FILE_PB_LOAD_FILE,1107382822,
 sfx2_PushButton_DLG_VERSIONS_PB_COMPARE,1112691217,
@@ -7533,7 +7528,6 @@ 
sfx2_PushButton_RID_WARN_PRINTTRANSPARENCY_BTN_PRINTTRANS_NO,1113051711,
 sfx2_PushButton_TP_CUSTOMPROPERTIES_BTN_ADD,541364830,
 sfx2_PushButton_TP_DOCINFODOC_BTN_DELETE,541200958,
 sfx2_PushButton_TP_DOCINFODOC_BTN_SIGNATURE,541200975,
-sfx2_PushButton_TP_DOCINFORELOAD_PB_BROWSEURL,541348426,
 sfx2_PushButton_TP_HELP_BOOKMARKS_PB_BOOKMARKS,547017228,
 sfx2_PushButton_TP_HELP_INDEX_PB_OPEN_INDEX,546984460,
 sfx2_PushButton_TP_HELP_SEARCH_PB_OPEN_SEARCH,547000849,
@@ -7547,9 +7541,6 @@ 
sfx2_RadioButton_TP_COMMONPRINTOPTIONS_RB_REDUCEGRADIENTS_COLOR,576160278,
 sfx2_RadioButton_TP_COMMONPRINTOPTIONS_RB_REDUCEGRADIENTS_STRIPES,576160277,
 sfx2_RadioButton_TP_COMMONPRINTOPTIONS_RB_REDUCETRANSPARENCY_AUTO,576160267,
 sfx2_RadioButton_TP_COMMONPRINTOPTIONS_RB_REDUCETRANSPARENCY_NONE,576160268,
-sfx2_RadioButton_TP_DOCINFORELOAD_RB_FORWARDUPDATE,541344321,
-sfx2_RadioButton_TP_DOCINFORELOAD_RB_NOAUTOUPDATE,541344319,
-sfx2_RadioButton_TP_DOCINFORELOAD_RB_RELOADUPDATE,541344320,
 starmath_CheckBox_RID_DISTANCEDIALOG_1,1401504769,
 starmath_CheckBox_RID_FONTDIALOG_1,1401455617,
 starmath_CheckBox_RID_FONTDIALOG_2,1401455618,
diff --git a/source/text/shared/01/01100500.xhp 
b/source/text/shared/01/01100500.xhp
index 11b72e5..c6115f1 100644
--- a/source/text/shared/01/01100500.xhp
+++ b/source/text/shared/01/01100500.xhp
@@ -37,38 +37,37 @@
 loading; HTML documents, automatically
 HTML documents; auto reloading
 
-
+
 Internet
-Sets the refresh and redirect options 
for an HTML page.
+Sets the 
refresh and redirect options for an HTML page.
 
 
   
 
-
+
 Do not refresh automatically
-User 
must refresh the page manually.
-
+User must 
refresh the page manually.
+
 Refresh this document
-Reloads the HTML page 
after the number of seconds that you enter in the seconds box. To 
observe the result, open the page in a browser.
-
+Reloads the HTML 
page after the number of seconds that you enter in the seconds 
box. To observe the result, open the page in a browser.
+
 Seconds
-Enter the 
number of seconds to wait before the page is reloaded.
-
+Enter the number of 
seconds to wait before the page is reloaded.
+
 Redirect from this document
-Loads a page that you 
specify after the number of seconds that you enter in the seconds 
box.
-
+Loads a page 
that you specify after the number of seconds that you enter in the 
seconds box.
+
 after ... seconds
-Enter the number of 
seconds to wait before redirecting the browser to a different 
file.
-
+Enter the number of 
seconds to wait before redirecting the browser to a different 
file.
+
 to URL
-Enter the URL 
address of the file that you want to open.
-
+Enter the URL 
address of the file that you want to open.
+
 ...
-Locate the file that 
you want to open, and then click Open.
-
-
+Lo

[Libreoffice-commits] .: 2 commits - helpcontent2 sfx2/uiconfig

2013-01-26 Thread Libreoffice Gerrit user
 helpcontent2 |2 -
 sfx2/uiconfig/ui/internetinfopage.ui |   42 ---
 2 files changed, 21 insertions(+), 23 deletions(-)

New commits:
commit d77bcb13c4afce1f894aadc6a3b058695641c2e1
Author: Caolán McNamara 
Date:   Sat Jan 26 14:08:05 2013 +

add mnemonic widgets to internet info page

Change-Id: Ic28d8e0918d81086232424fe98e34636f4f83233

diff --git a/sfx2/uiconfig/ui/internetinfopage.ui 
b/sfx2/uiconfig/ui/internetinfopage.ui
index 03951a3..59a7a9d 100644
--- a/sfx2/uiconfig/ui/internetinfopage.ui
+++ b/sfx2/uiconfig/ui/internetinfopage.ui
@@ -1,6 +1,20 @@
 
 
   
+  
+1
+65535
+60
+1
+10
+  
+  
+1
+65535
+5
+1
+10
+  
   
 True
 False
@@ -10,11 +24,9 @@
 
   
 Do not refresh 
automatically
-False
 True
 True
 False
-False
 True
 0
 True
@@ -31,11 +43,9 @@
 
   
 Refresh this 
document
-False
 True
 True
 False
-False
 0
 True
 forwardupdate
@@ -50,11 +60,9 @@
 
   
 Redirect from this 
document
-False
 True
 True
 False
-False
 0
 True
 noautoupdate
@@ -73,6 +81,8 @@
 12
 0
 every 
+True
+reloadnf
   
   
 0
@@ -103,6 +113,8 @@
 12
 0
 to URL 
+True
+forwarded
   
   
 0
@@ -118,6 +130,8 @@
 12
 0
 to frame
+True
+framecb
   
   
 0
@@ -169,12 +183,10 @@
 
   
 ...
-False
 True
 True
 True
 end
-False
   
   
 1
@@ -277,18 +289,4 @@
   
 
   
-  
-1
-65535
-60
-1
-10
-  
-  
-1
-65535
-5
-1
-10
-  
 
commit cdf590bbdcfa3062069b2f36687fac7df9124560
Author: Caolán McNamara 
Date:   Sat Jan 26 17:31:12 2013 +

Updated core
Project: help  a01238220f1bfa2619f9ac37ef82a2f2800e8f16

diff --git a/helpcontent2 b/helpcontent2
index 3a5cdb2..a012382 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3a5cdb25465c2f423892c184755dad7c0075c1eb
+Subproject commit a01238220f1bfa2619f9ac37ef82a2f2800e8f16
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: source/auxiliary

2013-01-26 Thread Libreoffice Gerrit user
 source/auxiliary/makefile.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3a5cdb25465c2f423892c184755dad7c0075c1eb
Author: Andras Timar 
Date:   Sat Jan 26 17:04:34 2013 +0100

we don't produce KeyID help packs (not useful)

Change-Id: Ie6d2fcab4d419e097557522621eb96a56b87ddf8

diff --git a/source/auxiliary/makefile.mk b/source/auxiliary/makefile.mk
index c7d3545..822f132 100644
--- a/source/auxiliary/makefile.mk
+++ b/source/auxiliary/makefile.mk
@@ -38,7 +38,7 @@ ALLTAR : aux_dirs $(COMMONBIN)$/helpimg.ilst
 t_aux_langdirs:=$(shell @find ./ -name "*.cfg" | sed "s/\.\/\///" | sed 
"s/\.\///" )
 
 aux_langdirs:=$(uniq $(t_aux_langdirs:d:d))
-help_exist:=$(shell @find $(L10N_MODULE)/source/ -type d -name "helpcontent2" 
| sed -e "s|/helpcontent2||" -e "s|^.*/||" ) en-US qtz
+help_exist:=$(shell @find $(L10N_MODULE)/source/ -type d -name "helpcontent2" 
| sed -e "s|/helpcontent2||" -e "s|^.*/||" ) en-US
 
 .ELSE  #IF "$(WITH_LANG)"!=""
 aux_langdirs:=en-US
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: helpcontent2

2013-01-26 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c0b6fa74337ff3db7a4e489330250c4f6e69f7c3
Author: Andras Timar 
Date:   Sat Jan 26 17:04:34 2013 +0100

Updated core
Project: help  3a5cdb25465c2f423892c184755dad7c0075c1eb

diff --git a/helpcontent2 b/helpcontent2
index b8c5136..3a5cdb2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b8c513606f96dac3a5f10dfba008ec6c45830cb9
+Subproject commit 3a5cdb25465c2f423892c184755dad7c0075c1eb
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Change in core[master]: Remove more STRINGPARAM macros form dbaccess

2013-01-26 Thread Marcos Souza (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1878

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/1878/1

Remove more STRINGPARAM macros form dbaccess

Change-Id: I283ccd03dc811dda2f10963f400cd517f42ea7b3
---
M dbaccess/source/core/dataaccess/databasecontext.cxx
M dbaccess/source/core/dataaccess/databaseregistrations.cxx
M dbaccess/source/core/dataaccess/definitioncontainer.cxx
M dbaccess/source/core/dataaccess/documentcontainer.cxx
M dbaccess/source/core/dataaccess/intercept.cxx
M dbaccess/source/core/dataaccess/myucp_datasupplier.cxx
M dbaccess/source/core/misc/DatabaseDataProvider.cxx
M dbaccess/source/core/misc/dsntypes.cxx
M dbaccess/source/core/misc/sdbcoretools.cxx
M dbaccess/source/core/recovery/dbdocrecovery.cxx
M dbaccess/source/core/recovery/settingsimport.cxx
M dbaccess/source/core/recovery/storagetextstream.cxx
M dbaccess/source/core/recovery/subcomponentloader.cxx
M dbaccess/source/core/recovery/subcomponentrecovery.cxx
14 files changed, 95 insertions(+), 126 deletions(-)



diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx 
b/dbaccess/source/core/dataaccess/databasecontext.cxx
index b5372d4..8144f82 100644
--- a/dbaccess/source/core/dataaccess/databasecontext.cxx
+++ b/dbaccess/source/core/dataaccess/databasecontext.cxx
@@ -204,10 +204,9 @@
 }
 
 // Helper
-rtl::OUString ODatabaseContext::getImplementationName_static() throw( 
RuntimeException )
-
+OUString ODatabaseContext::getImplementationName_static() throw( 
RuntimeException )
 {
-return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.comp.dba.ODatabaseContext"));
+return OUString("com.sun.star.comp.dba.ODatabaseContext");
 }
 
 Reference< XInterface > ODatabaseContext::Create(const Reference< 
XComponentContext >& _rxContext)
diff --git a/dbaccess/source/core/dataaccess/databaseregistrations.cxx 
b/dbaccess/source/core/dataaccess/databaseregistrations.cxx
index 344c15c..5886fbd 100644
--- a/dbaccess/source/core/dataaccess/databaseregistrations.cxx
+++ b/dbaccess/source/core/dataaccess/databaseregistrations.cxx
@@ -53,21 +53,21 @@
 using ::com::sun::star::uno::XAggregation;
 /** === end UNO using === **/
 
-static const ::rtl::OUString& getConfigurationRootPath()
+static const OUString& getConfigurationRootPath()
 {
-static ::rtl::OUString 
s_sNodeName(RTL_CONSTASCII_USTRINGPARAM("org.openoffice.Office.DataAccess/RegisteredNames"));
+static OUString 
s_sNodeName("org.openoffice.Office.DataAccess/RegisteredNames");
 return s_sNodeName;
 }
 
-const ::rtl::OUString& getLocationNodeName()
+const OUString& getLocationNodeName()
 {
-static ::rtl::OUString 
s_sNodeName(RTL_CONSTASCII_USTRINGPARAM("Location"));
+static OUString s_sNodeName("Location");
 return s_sNodeName;
 }
 
-const ::rtl::OUString& getNameNodeName()
+const OUString& getNameNodeName()
 {
-static ::rtl::OUString 
s_sNodeName(RTL_CONSTASCII_USTRINGPARAM("Name"));
+static OUString s_sNodeName("Name");
 return s_sNodeName;
 }
 
diff --git a/dbaccess/source/core/dataaccess/definitioncontainer.cxx 
b/dbaccess/source/core/dataaccess/definitioncontainer.cxx
index 928f2cf..8c8cd98 100644
--- a/dbaccess/source/core/dataaccess/definitioncontainer.cxx
+++ b/dbaccess/source/core/dataaccess/definitioncontainer.cxx
@@ -159,16 +159,16 @@
 IMPLEMENT_FORWARD_XINTERFACE2( 
ODefinitionContainer,OContentHelper,ODefinitionContainer_Base)
 
IMPLEMENT_TYPEPROVIDER2(ODefinitionContainer,OContentHelper,ODefinitionContainer_Base);
 // XServiceInfo
-::rtl::OUString SAL_CALL ODefinitionContainer::getImplementationName(  ) 
throw(RuntimeException)
+OUString SAL_CALL ODefinitionContainer::getImplementationName(  ) 
throw(RuntimeException)
 {
-return 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.sdb.ODefinitionContainer"));
+return OUString("com.sun.star.sdb.ODefinitionContainer");
 }
 
-Sequence< ::rtl::OUString > SAL_CALL 
ODefinitionContainer::getSupportedServiceNames(  ) throw(RuntimeException)
+Sequence< OUString > SAL_CALL ODefinitionContainer::getSupportedServiceNames(  
) throw(RuntimeException)
 {
-Sequence< ::rtl::OUString > aReturn(2);
-aReturn.getArray()[0] = 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.sdb.DefinitionContainer"));
-aReturn.getArray()[1] = 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.Content"));
+Sequence< OUString > aReturn(2);
+aReturn.getArray()[0] = "com.sun.star.sdb.DefinitionContainer";
+aReturn.getArray()[1] = "com.sun.star.ucb.Content";
 return aReturn;
 }
 
diff --git a/dbaccess/source/core/dataaccess/documentcontainer.cxx 
b/dbaccess/source/core/dataaccess/documentcontainer.cxx
index 9e91fd4..90a8af5 100644
--- a/dbaccess/source/core/dataaccess/documentcontainer.cxx
+++ b/dbaccess/source/core/dataaccess/documentcontainer.cxx
@@ -733,7 +733,7 @@
 {
 

Change in core[libreoffice-4-0]: export page/cell anchoring for xls drawing objects fdo#58360

2013-01-26 Thread Julien Nabet (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1877

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/1877/1

export page/cell anchoring for xls drawing objects fdo#58360

Change-Id: I8f12ce4fedd3da76bab683ac85169186deeb89dc
---
M sc/source/filter/excel/xeescher.cxx
1 file changed, 5 insertions(+), 3 deletions(-)



diff --git a/sc/source/filter/excel/xeescher.cxx 
b/sc/source/filter/excel/xeescher.cxx
index 32afdab..4221d0c 100644
--- a/sc/source/filter/excel/xeescher.cxx
+++ b/sc/source/filter/excel/xeescher.cxx
@@ -257,9 +257,11 @@
 
 void XclExpDffSheetAnchor::ImplSetFlags( const SdrObject& rSdrObj )
 {
-// Special case "page anchor" (X==0,Y==1) -> lock pos and size.
-const Point& rPos = rSdrObj.GetAnchorPos();
-mnFlags = ((rPos.X() == 0) && (rPos.Y() == 1)) ? EXC_ESC_ANCHOR_LOCKED : 0;
+// set flags for cell/page anchoring
+if ( ScDrawLayer::GetAnchorType( rSdrObj ) == SCA_CELL )
+mnFlags = 0;
+else
+mnFlags = EXC_ESC_ANCHOR_LOCKED;
 }
 
 void XclExpDffSheetAnchor::ImplCalcAnchorRect( const Rectangle& rRect, MapUnit 
eMapUnit )

-- 
To view, visit https://gerrit.libreoffice.org/1877
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f12ce4fedd3da76bab683ac85169186deeb89dc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Julien Nabet 
Gerrit-Reviewer: Noel Power 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: accessibility/source codemaker/source cppuhelper/source cppu/source idlc/source registry/source sal/qa stoc/source tools/source ucb/source ucb/workben

2013-01-26 Thread Libreoffice Gerrit user
 accessibility/source/extended/textwindowaccessibility.cxx |   15 ++--
 codemaker/source/codemaker/dependencies.cxx   |   10 +-
 codemaker/source/cppumaker/cpputype.cxx   |   32 -
 codemaker/source/cppumaker/includes.cxx   |6 -
 codemaker/source/javamaker/classfile.cxx  |   36 +-
 codemaker/source/javamaker/javatype.cxx   |   48 +++---
 cppu/source/typelib/typelib.cxx   |   18 ++---
 cppuhelper/source/tdmgr.cxx   |8 +-
 idlc/source/astdump.cxx   |6 -
 registry/source/regimpl.cxx   |   16 ++--
 sal/qa/rtl/uri/rtl_testuri.cxx|   16 ++--
 stoc/source/registry_tdprovider/tdiface.cxx   |   12 +--
 stoc/source/registry_tdprovider/tdprovider.cxx|8 +-
 tools/source/fsys/urlobj.cxx  |3 
 ucb/source/ucp/ftp/ftpdirp.cxx|4 -
 ucb/workben/cachemap/cachemaptest.cxx |   30 +---
 16 files changed, 141 insertions(+), 127 deletions(-)

New commits:
commit f1bca26afcc7593d0124c216c0400a9e2e47fc1d
Author: Stephan Bergmann 
Date:   Sat Jan 26 16:31:43 2013 +0100

Remove redundant braces around for loops

...that had once been workarounds for compilers that did not yet support the
C++98 scoping rules for declarations in for-init-statements.

Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe

diff --git a/accessibility/source/extended/textwindowaccessibility.cxx 
b/accessibility/source/extended/textwindowaccessibility.cxx
index 6691856..f27fc8f 100644
--- a/accessibility/source/extended/textwindowaccessibility.cxx
+++ b/accessibility/source/extended/textwindowaccessibility.cxx
@@ -1725,8 +1725,9 @@ void Document::notifyVisibleRangeChanges(
 {
 // XXX  Replace this code that determines which paragraphs have changed 
from
 // invisible to visible or vice versa with a better algorithm.
-{for (Paragraphs::iterator aIt(rOldVisibleBegin); aIt != rOldVisibleEnd;
-  ++aIt)
+for (Paragraphs::iterator aIt(rOldVisibleBegin); aIt != rOldVisibleEnd;
+ ++aIt)
+{
 if (aIt != rInserted
 && (aIt < m_aVisibleBegin || aIt >= m_aVisibleEnd))
 NotifyAccessibleEvent(
@@ -1735,8 +1736,9 @@ void Document::notifyVisibleRangeChanges(
 ::css::uno::makeAny(getAccessibleChild(aIt)),
 ::css::uno::Any());
 }
-{for (Paragraphs::iterator aIt(m_aVisibleBegin); aIt != m_aVisibleEnd;
-  ++aIt)
+for (Paragraphs::iterator aIt(m_aVisibleBegin); aIt != m_aVisibleEnd;
+ ++aIt)
+{
 if (aIt == rInserted
 || aIt < rOldVisibleBegin || aIt >= rOldVisibleEnd)
 NotifyAccessibleEvent(
@@ -1829,8 +1831,9 @@ void Document::handleParagraphNotifications()
 ::sal_uLong n = aHint.GetValue();
 if (n == TEXT_PARA_ALL)
 {
-{for (Paragraphs::iterator aIt(m_aVisibleBegin);
-  aIt != m_aVisibleEnd; ++aIt)
+for (Paragraphs::iterator aIt(m_aVisibleBegin);
+ aIt != m_aVisibleEnd; ++aIt)
+{
 NotifyAccessibleEvent(
 ::css::accessibility::AccessibleEventId::
 CHILD,
diff --git a/codemaker/source/codemaker/dependencies.cxx 
b/codemaker/source/codemaker/dependencies.cxx
index 9d2e769..f3baf1c 100644
--- a/codemaker/source/codemaker/dependencies.cxx
+++ b/codemaker/source/codemaker/dependencies.cxx
@@ -65,13 +65,13 @@ Dependencies::Dependencies(
 }
 }
 if (tc != RT_TYPE_ENUM) {
-{for (sal_Int16 i = 0; i < reader.getFieldCount(); ++i) {
+for (sal_Int16 i = 0; i < reader.getFieldCount(); ++i) {
 if ((reader.getFieldFlags(i) & 
RT_ACCESS_PARAMETERIZED_TYPE)
 == 0)
 {
 insert(reader.getFieldTypeName(i), false);
 }
-}}
+}
 }
 for (sal_Int16 i = 0; i < reader.getMethodCount(); ++i) {
 insert(reader.getMethodReturnTypeName(i), false);
@@ -249,11 +249,11 @@ void Dependencies::insert(rtl::OString const & type, bool 
base) {
 
 case UnoType::SORT_COMPLEX:
 {
-{for (std::vector< rtl::OString >::iterator i(args.begin());
-  i != args.end(); ++i)
+for (std::vector< rtl::OString >::iterator i(args.begin());
+ i != args.end(); ++i)
 {
 insert(*i, false);
-}}
+}
 Map::iterator i(m_map.find(t));
 if (i == m_map.end()) {
 m_map.ins

Re: [PUSHED] fdo#59101 - [Feature Request] Make Find hotkey (Ctrl+F) a to...

2013-01-26 Thread Joren

Op 26/01/13 02:20, Pedro schreef:

Samuel Mehrbrodt-2 wrote

Do we really want Ctl+F to be a toggle command? I would expect Ctl+F to
always open the Findbar, and if it's already open, put the cursor in the
search field (that's what Firefox e.g. also does)

It already does all that ;) If you leave it open, pressing Ctrl+F puts focus
on the input box.
I made that code change and I can confirm it now has that behavior. If 
your cursor is in your document and the findbar is opened, hitting 
ctrl+F (or cmd+F) will select the search field. (If the findbar wasn't 
open, it'll open off course)... And if your cursor is IN the findbar 
it'll close once you press ESC or ctrl+F.


Kind regards,
Joren
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: helpers/help_hid.lst source/text

2013-01-26 Thread Libreoffice Gerrit user
 helpers/help_hid.lst|   15 --
 source/text/shared/01/05030700.xhp  |7 ++--
 source/text/swriter/01/05040500.xhp |   54 ++--
 3 files changed, 30 insertions(+), 46 deletions(-)

New commits:
commit b8c513606f96dac3a5f10dfba008ec6c45830cb9
Author: Caolán McNamara 
Date:   Sat Jan 26 13:44:36 2013 +

update help ids for column page .ui conversion

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index ebbf61f..9caa9c4 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -1085,7 +1085,6 @@ HID_COLORPAGE_WRITERTEXTGRID_CB,39947,
 HID_COLORPAGE_WRITERTEXTGRID_LB,39907,
 HID_COLOR_CTL_COLORS,33887,
 HID_COLROWNAMERANGES,58931,
-HID_COLUMN,53172,
 HID_COMPATIBILITY_OPTIONS_BOX,53252,
 HID_COND_COLL,53194,
 HID_COND_COLL_TABLIST,54844,
@@ -8814,8 +8813,6 @@ 
sw_CheckBox_DLG_MM_SERVERAUTHENTICATION_CB_AUTHENTICATION,1427145778,
 sw_CheckBox_DLG_ROW_HEIGHT_CB_AUTOHEIGHT,1425245186,
 sw_CheckBox_MD_EDIT_REGION_CB_DDE,1405830145,
 sw_CheckBox_MD_EDIT_REGION_CB_PASSWD,1405830153,
-sw_CheckBox_TP_COLUMN_CB_AUTO_WIDTH,877872132,
-sw_CheckBox_TP_COLUMN_CB_BALANCECOLS,877872186,
 sw_CheckBox_TP_CONDCOLL_CB_CONDITION,878445569,
 sw_CheckBox_TP_CONTENT_OPT_CB_ANY_RULER,878396428,
 sw_CheckBox_TP_CONTENT_OPT_CB_CROSS,878396430,
@@ -9069,8 +9066,6 @@ 
sw_ImageButton_DLG_MM_CUSTOMIZE_ADDRESS_LIST_PB_DOWN,1435299335,
 sw_ImageButton_DLG_MM_CUSTOMIZE_ADDRESS_LIST_PB_UP,1435299334,
 sw_ImageButton_DLG_MM_GREETINGS_PAGE_IB_NEXTSET,898264597,
 sw_ImageButton_DLG_MM_GREETINGS_PAGE_IB_PREVSET,898264596,
-sw_ImageButton_TP_COLUMN_BTN_DOWN,877882911,
-sw_ImageButton_TP_COLUMN_BTN_UP,877882910,
 sw_ImageButton_TP_ENV_ENV_BTN_INSERT,909651463,
 sw_ImageButton_TP_LAB_LAB_BTN_INSERT,909700627,
 sw_ImageButton_TP_TABLE_COLUMN_COL_BTN_DOWN,888499833,
@@ -9116,9 +9111,6 @@ sw_ListBox_DLG_MM_OUTPUT_PAGE_LB_SENDAS,898305573,
 sw_ListBox_DLG_MULTMRK_LB_TOX,1433456132,
 sw_ListBox_DLG_NUM_NAMES_LB_FORM,1428754026,
 sw_ListBox_DLG_SEL_GLOS_LB_GLOS,1436749313,
-sw_ListBox_TP_COLUMN_LB_POSITION,877874726,
-sw_ListBox_TP_COLUMN_LB_STYLE,877874722,
-sw_ListBox_TP_COLUMN_LB_TEXTDIRECTION,877874749,
 sw_ListBox_TP_CONDCOLL_LB_FILTER,878448136,
 sw_ListBox_TP_CONDCOLL_LB_STYLE,878448135,
 sw_ListBox_TP_CONTENT_OPT_LB_HMETRIC,878399064,
@@ -9228,12 +9220,6 @@ 
sw_MetricField_DLG_PAGEPREVIEW_PRINTOPTIONS_MF_RMARGIN,1411291663,
 sw_MetricField_DLG_PAGEPREVIEW_PRINTOPTIONS_MF_TMARGIN,1411291665,
 sw_MetricField_DLG_PAGEPREVIEW_PRINTOPTIONS_MF_VMARGIN,1411291671,
 sw_MetricField_DLG_ROW_HEIGHT_ED_HEIGHT,1425250817,
-sw_MetricField_TP_COLUMN_ED_1,877877785,
-sw_MetricField_TP_COLUMN_ED_2,877877786,
-sw_MetricField_TP_COLUMN_ED_3,877877787,
-sw_MetricField_TP_COLUMN_ED_DIST1,877877806,
-sw_MetricField_TP_COLUMN_ED_DIST2,877877807,
-sw_MetricField_TP_COLUMN_ED_HEIGHT,877877796,
 sw_MetricField_TP_DROPCAPS_FLD_DISTANCE,877828614,
 sw_MetricField_TP_ENV_FMT_FLD_ADDR_LEFT,909662734,
 sw_MetricField_TP_ENV_FMT_FLD_ADDR_TOP,909662736,
@@ -9310,7 +9296,6 @@ 
sw_NumericField_DLG_PAGEPREVIEW_PRINTOPTIONS_NF_COLS,1411291141,
 sw_NumericField_DLG_PAGEPREVIEW_PRINTOPTIONS_NF_ROWS,1411291139,
 sw_NumericField_DLG_PAGEPREVIEW_ZOOM_ED_COL,1411274756,
 sw_NumericField_DLG_PAGEPREVIEW_ZOOM_ED_ROW,1411274757,
-sw_NumericField_TP_COLUMN_ED_NUMBER,877877250,
 sw_NumericField_TP_DROPCAPS_FLD_DROPCAPS,877828098,
 sw_NumericField_TP_DROPCAPS_FLD_LINES,877828100,
 sw_NumericField_TP_FLD_DOK_ED_DOKDATEOFF,878762041,
diff --git a/source/text/shared/01/05030700.xhp 
b/source/text/shared/01/05030700.xhp
index a797b07..4fcea39 100644
--- a/source/text/shared/01/05030700.xhp
+++ b/source/text/shared/01/05030700.xhp
@@ -92,11 +92,10 @@
 
 Properties
 
-
-
-
+
+
 Text direction
-Specify the text 
direction for a paragraph that uses complex text layout (CTL). This feature is 
only available if complex text layout support is enabled.
+Specify the text 
direction for a paragraph that uses complex text layout (CTL). This feature is 
only available if complex text layout support is enabled.
 
 
 
diff --git a/source/text/swriter/01/05040500.xhp 
b/source/text/swriter/01/05040500.xhp
index 61e612e..73c4907 100644
--- a/source/text/swriter/01/05040500.xhp
+++ b/source/text/swriter/01/05040500.xhp
@@ -29,10 +29,10 @@

   
 
-
+
 added two Help IDs, see 
i97180
 Columns
- Specifies the number of columns and the column layout for a 
page style, frame, or section.
+ Specifies the number of columns 
and the column layout for a page style, frame, or section.
 
   
   
@@ -40,14 +40,14 @@
   
   Default settings
   You can select from predefined column layouts, or create your own. 
When you apply a layout to a page style, all pages that use the style are 
updated. Similarly, when you apply a column layout to a frame style, all frames 
that use that style are updated. You can also change the column layout for a 
single frame.
-
-
+
+
 Columns
-  Enter the number of 
columns 

[Libreoffice-commits] .: 2 commits - helpcontent2 sw/uiconfig

2013-01-26 Thread Libreoffice Gerrit user
 helpcontent2 |2 -
 sw/uiconfig/swriter/ui/columnpage.ui |   65 +++
 2 files changed, 38 insertions(+), 29 deletions(-)

New commits:
commit 8e681942f771d7beae52b1e786fab16e6a653ab1
Author: Caolán McNamara 
Date:   Sat Jan 26 12:26:29 2013 +

add mnemonic widgets to column page

Change-Id: I1156a4785b96efb44bc98623e9a7f2cbbb5ee84a

diff --git a/sw/uiconfig/swriter/ui/columnpage.ui 
b/sw/uiconfig/swriter/ui/columnpage.ui
index 31576a9..1565167 100644
--- a/sw/uiconfig/swriter/ui/columnpage.ui
+++ b/sw/uiconfig/swriter/ui/columnpage.ui
@@ -79,6 +79,8 @@
 False
 0
 Columns
+True
+colsnf
   
   
 0
@@ -122,6 +124,7 @@
 0
 _Apply 
to
 True
+applytolb
   
   
 0
@@ -154,6 +157,7 @@
 0
 Text 
_direction
 True
+textdirectionlb
   
   
 0
@@ -603,6 +607,7 @@
 0
 St_yle
 True
+linestylelb
   
   
 0
@@ -618,6 +623,7 @@
 0
 _Width
 True
+linewidthmf:0.00pt
   
   
 0
@@ -633,6 +639,7 @@
 0
 H_eight
 True
+linewidthmf:0.00pt
   
   
 2
@@ -648,6 +655,7 @@
 0
 _Position
 True
+lineposlb
   
   
 2
@@ -663,6 +671,7 @@
 0
 _Color
 True
+colorlb
   
   
 4
@@ -774,7 +783,19 @@
   
 
   
-  
+  
+True
+False
+gtk-go-back
+1
+  
+  
+True
+False
+gtk-go-forward
+1
+  
+  
 
   
   
@@ -783,40 +804,20 @@
 
 
   
-Selection
+Left-to-right
 0
   
   
-Current Section
+Right-to-left
 1
   
   
-Selected section
-2
-  
-  
-Frame
+Use superordinate object settings
 4
   
-  
-Page Style: 
-3
-  
 
   
-  
-True
-False
-gtk-go-back
-1
-  
-  
-True
-False
-gtk-go-forward
-1
-  
-  
+  
 
   
   
@@ -825,17 +826,25 @@
 
 
   
-Left-to-right
+Selection
 0
   
   
-Right-to-left
+Current Section
 1
   
   
-Use superordinate object settings
+Selected section
+2
+  
+  
+Frame
 4
   
+  
+Page Style: 
+3
+  
 
   
 
commit 53f0752535e1e23481ebe7632afd59beee8a311d
Author: Caolán McNamara 
Date:   Sat Jan 26 13:44:36 2013 +

Updated core
Project: help  b8c513606f96dac3a5f10dfba008ec6c45830cb9

diff --git a/helpcontent2 b/helpcontent2
index 07bf3f5..b8c5136 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 07bf3f5029f799b26d8a663de53c280094e84fb3
+Subproject commit b8c513606f96dac3a5f10dfba008ec6c45830cb9
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Email Flood

2013-01-26 Thread Florian Effenberger

Hi,

Norbert Thiebaud wrote on 2013-01-26 14:13:

Ok so after some hunting and some tyding up hofully we should be ok now...


thanks so much to you, David and Norbert, for working on this! Glad you 
sorted it out. :-)


Florian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Email Flood

2013-01-26 Thread Norbert Thiebaud
Ok so after some hunting and some tyding up hofully we should be ok now...

what is expected is that the dev ML should receive one and only one
email for all changes in gerrit for the project 'core'.

please let me know if that is not the case.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] API CHANGE: add a "position" parameter to XParagraph/TextPor...

2013-01-26 Thread Miklos Vajna (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1159

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/1159/1

API CHANGE: add a "position" parameter to XParagraph/TextPortionAppend methods

So we can use the new RTF import for clipboard pastes in Writer without
inserting text content to the end of the document only.

Notes:

- SwXText::insertTextPortion: the MovePara() call is removed, as all it
  did was
  trying to move the cursor beyond the end of the document.
- SwRTFReader::Read: the double fake paragraph insertion / deletion is
  motivated by the ODT filter.
- RtfFilter::filter: if TextInsertModeRange is not passed, then the
  behaviour
  is not changed.

Change-Id: I24cddb00a78e3b798e7d88764e59e6a77a6e98a4
Helped-by: Michael Stahl 
---
M editeng/inc/editeng/unotext.hxx
M editeng/source/uno/unotext.cxx
M offapi/com/sun/star/text/XParagraphAppend.idl
M offapi/com/sun/star/text/XTextPortionAppend.idl
M sw/inc/unotext.hxx
M sw/inc/unotextrange.hxx
M sw/source/core/unocore/unotext.cxx
M sw/source/filter/rtf/swparrtf.cxx
M writerfilter/inc/dmapper/DomainMapper.hxx
M writerfilter/source/dmapper/DomainMapper.cxx
M writerfilter/source/dmapper/DomainMapper_Impl.cxx
M writerfilter/source/dmapper/DomainMapper_Impl.hxx
M writerfilter/source/filter/ImportFilter.cxx
M writerfilter/source/filter/RtfFilter.cxx
14 files changed, 266 insertions(+), 36 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1159
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24cddb00a78e3b798e7d88764e59e6a77a6e98a4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Miklos Vajna 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Email Flood

2013-01-26 Thread Florian Effenberger

Hi,

Norbert Thiebaud wrote on 2013-01-26 12:49:

Eike reported something similar...  I did not notice this... but then
maybe google mail is hiding that from me somehow...
I must admit that I'm ill equiped for this one as I have littel
control on the mail system itself... that is more a florian things...
and it is bjoern that did set-up the mail spaming in gerrit
originally... and I'm not really sure which trick was chosen.
I've done some reading since then, and found how we were supposed to
set-it up gerrit wise... but that surely was not set-up that way.

But clearly the one thing that changed recently is the system layer of
vm2 (the virtual machine that run gerrit-prod)
we have not changed any of gerrit conf regarding email...


so, I tested the mail system, and it seems to work. However, before it 
did NOT work, which may be why you did not receive any e-mails, the VM 
simply was not capable of mailing that out... this is fixed now. :-)


Can you tell me what you were receiving before? No e-mail at all, or 
only one of the samples you attached?


Florian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Email Flood

2013-01-26 Thread Norbert Thiebaud
On Sat, Jan 26, 2013 at 5:26 AM, Michael Meeks  wrote:
>
> On Fri, 2013-01-25 at 14:17 -0800, matthew lange wrote:
>> Does anyone know why I am suddenly getting email floods from this
>> list? I have changed no settings at my end.
>
> Perhaps two reasons ? it is LibreOffice 4.0.0 time - and so lots of
> patches are going through review that would normally go to master: that
> bulks up the mail flow. Also - I've started getting tripple copies (I
> assume in error) of some PUSHED messages from gerrit: no idea why - I
> poked Norbert but perhaps it's just me.

Eike reported something similar...  I did not notice this... but then
maybe google mail is hiding that from me somehow...
I must admit that I'm ill equiped for this one as I have littel
control on the mail system itself... that is more a florian things...
and it is bjoern that did set-up the mail spaming in gerrit
originally... and I'm not really sure which trick was chosen.
I've done some reading since then, and found how we were supposed to
set-it up gerrit wise... but that surely was not set-up that way.

But clearly the one thing that changed recently is the system layer of
vm2 (the virtual machine that run gerrit-prod)
we have not changed any of gerrit conf regarding email...

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Michael Meeks  changed:

   What|Removed |Added

 Depends on||59881

--- Comment #90 from Michael Meeks  ---
add sdremote deadlock: bug#59881 - it's pretty annoying to kill soffice
remotely[sic] while presenting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


BUG #59397

2013-01-26 Thread Janit Anjaria
Can someone please help me with the bug?

Regards,
Janit
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[REVIEW 4-0, 4-0-0] crash for sdremote ...

2013-01-26 Thread Michael Meeks
Hi guys,

A trivial broken allocator usage in the dbus usage for the sdremote: it
may be behind fdo#58699 - but perhaps not; it's certainly wrong. I'd
love to have it picked to 4-0 and 4-0-0

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e99b540d8985b87247519c951e6ef65a01b1f5c9

The symptom is - it crashes the Slideshow->Remote Control menu item
100% of the time unless you have ooenv sourced (ie. export
G_SLICE=always-malloc - means the g_free doesn't stamp on the slice
allocator as it does for normal users ;-)

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Email Flood

2013-01-26 Thread Michael Meeks

On Fri, 2013-01-25 at 14:17 -0800, matthew lange wrote:
> Does anyone know why I am suddenly getting email floods from this
> list? I have changed no settings at my end.

Perhaps two reasons ? it is LibreOffice 4.0.0 time - and so lots of
patches are going through review that would normally go to master: that
bulks up the mail flow. Also - I've started getting tripple copies (I
assume in error) of some PUSHED messages from gerrit: no idea why - I
poked Norbert but perhaps it's just me.

I expect the quantity of patch mail to subside around 4.0.2

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: GDB - Can I See Every Symbol Called?

2013-01-26 Thread Michael Meeks
Hi Joel,

On Fri, 2013-01-25 at 15:13 -0800, Joel Madero wrote:
> I've finally gotten comfortable with gdb as far as break points and
> what not. What I want to know is if there is a way for me to see all
> symbols called during a given run of soffice.

Not that I know of :-)

>  Getting a log that shows every symbol called would allow me to
> compare to runs of libreoffice, one where I push "Ok" the other where
> I push "Cancel".

True - on the other hand - if you have a dialog - probably it is run
inside an 'Execute' method that (hopefully) is close in the code to
where ok/cancel would be different: ie. the return parameter (or some
such associated with it) from that Execute method is prolly what you
want to follow.

It is possible that using 'ltrace' would show you something useful -
though you'd prolly want to pipe the output through c++filt - but I've
never had much joy with ltrace for whatever reason.

HTH,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 3 commits - sw/source

2013-01-26 Thread Libreoffice Gerrit user
 sw/source/ui/app/swmodule.cxx|4 ++--
 sw/source/ui/config/barcfg.cxx   |2 +-
 sw/source/ui/config/caption.cxx  |2 +-
 sw/source/ui/dialog/ascfldlg.cxx |6 +++---
 sw/source/ui/fldui/fldfunc.cxx   |   14 +++---
 sw/source/ui/fldui/fldvar.cxx|8 
 sw/source/ui/frmdlg/colex.cxx|6 +++---
 sw/source/ui/frmdlg/column.cxx   |   34 +-
 sw/source/ui/frmdlg/cption.cxx   |6 +++---
 sw/source/ui/frmdlg/frmmgr.cxx   |2 +-
 sw/source/ui/frmdlg/frmpage.cxx  |   38 +++---
 sw/source/ui/inc/ascfldlg.hxx|2 +-
 sw/source/ui/inc/barcfg.hxx  |2 +-
 sw/source/ui/inc/basesh.hxx  |2 +-
 sw/source/ui/inc/bmpwin.hxx  |4 ++--
 sw/source/ui/inc/caption.hxx |6 +++---
 sw/source/ui/inc/cnttab.hxx  |2 +-
 sw/source/ui/inc/colex.hxx   |4 ++--
 sw/source/ui/inc/colmgr.hxx  |4 ++--
 sw/source/ui/inc/column.hxx  |   10 +-
 sw/source/ui/inc/condedit.hxx|7 +++
 sw/source/ui/inc/frmmgr.hxx  |2 +-
 sw/source/ui/inc/frmpage.hxx |2 +-
 sw/source/ui/inc/pggrid.hxx  |2 +-
 sw/source/ui/misc/pggrid.cxx |2 +-
 sw/source/ui/shells/textsh2.cxx  |2 --
 sw/source/ui/utlui/condedit.cxx  |3 +--
 27 files changed, 87 insertions(+), 91 deletions(-)

New commits:
commit 1f531d4f68b41044bdb38f90149b4d81e3024da7
Author: Takeshi Abe 
Date:   Sat Jan 26 20:14:11 2013 +0900

sal_Bool to bool

Change-Id: Ie452042fafd4d795b9830f9d8416c568a76b3d8f

diff --git a/sw/source/ui/app/swmodule.cxx b/sw/source/ui/app/swmodule.cxx
index 3c61ac7..9d4bc1d 100644
--- a/sw/source/ui/app/swmodule.cxx
+++ b/sw/source/ui/app/swmodule.cxx
@@ -184,8 +184,8 @@ SwModule::SwModule( SfxObjectFactory* pWebFact,
 pModuleConfig = new SwModuleOptions;
 
 // We need them anyways
-pToolbarConfig = new SwToolbarConfigItem( sal_False );
-pWebToolbarConfig = new SwToolbarConfigItem( sal_True );
+pToolbarConfig = new SwToolbarConfigItem( false );
+pWebToolbarConfig = new SwToolbarConfigItem( true );
 
 pStdFontConfig = new SwStdFontConfig;
 
diff --git a/sw/source/ui/config/barcfg.cxx b/sw/source/ui/config/barcfg.cxx
index 12c2515..95da3e4 100644
--- a/sw/source/ui/config/barcfg.cxx
+++ b/sw/source/ui/config/barcfg.cxx
@@ -35,7 +35,7 @@ using namespace com::sun::star::uno;
 #define SEL_TYPE_BEZIER 3
 #define SEL_TYPE_GRAPHIC4
 
-SwToolbarConfigItem::SwToolbarConfigItem( sal_Bool bWeb ) :
+SwToolbarConfigItem::SwToolbarConfigItem( bool bWeb ) :
 ConfigItem(bWeb ? OUString("Office.WriterWeb/ObjectBar") : 
OUString("Office.Writer/ObjectBar"),
 CONFIG_MODE_DELAYED_UPDATE|CONFIG_MODE_RELEASE_TREE)
 {
diff --git a/sw/source/ui/config/caption.cxx b/sw/source/ui/config/caption.cxx
index 9fb8b63..44f4b69 100644
--- a/sw/source/ui/config/caption.cxx
+++ b/sw/source/ui/config/caption.cxx
@@ -31,7 +31,7 @@ InsCaptionOpt::InsCaptionOpt(const SwCapObjType eType, const 
SvGlobalName* pOleI
 nPos(1),
 nLevel(0),
 sSeparator( rtl::OUString(": ") ),
-bIgnoreSeqOpts(sal_False),
+bIgnoreSeqOpts(false),
 bCopyAttributes(sal_False)
 {
 if (pOleId)
diff --git a/sw/source/ui/dialog/ascfldlg.cxx b/sw/source/ui/dialog/ascfldlg.cxx
index d7f2fda..5f6ab9a 100644
--- a/sw/source/ui/dialog/ascfldlg.cxx
+++ b/sw/source/ui/dialog/ascfldlg.cxx
@@ -68,7 +68,7 @@ SwAsciiFilterDlg::SwAsciiFilterDlg( Window* pParent, 
SwDocShell& rDocSh,
 aCancelPB( this, SW_RES( PB_CANCEL )),
 aHelpPB( this, SW_RES( PB_HELP )),
 sSystemCharSet( SW_RES( STR_SYS_CHARSET )),
-bSaveLineStatus( sal_True )
+bSaveLineStatus( true )
 {
 FreeResource();
 
@@ -387,7 +387,7 @@ IMPL_LINK( SwAsciiFilterDlg, CharSetSelHdl, 
SvxTextEncodingBox*, pBox )
 }
 }
 
-bSaveLineStatus = sal_False;
+bSaveLineStatus = false;
 if( eEnd != (LineEnd)-1 )   // changed?
 {
 if( eOldEnd != eEnd )
@@ -400,7 +400,7 @@ IMPL_LINK( SwAsciiFilterDlg, CharSetSelHdl, 
SvxTextEncodingBox*, pBox )
 aCR_RB.Check( aCR_RB.GetSavedValue() );
 aLF_RB.Check( aLF_RB.GetSavedValue() );
 }
-bSaveLineStatus = sal_True;
+bSaveLineStatus = true;
 
 if( nOldLng != nLng && aFontLB.IsVisible() )
 aLanguageLB.SelectLanguage( nLng );
diff --git a/sw/source/ui/fldui/fldfunc.cxx b/sw/source/ui/fldui/fldfunc.cxx
index 363628f..a631230 100644
--- a/sw/source/ui/fldui/fldfunc.cxx
+++ b/sw/source/ui/fldui/fldfunc.cxx
@@ -79,8 +79,8 @@ SwFldFuncPage::SwFldFuncPage(Window* pParent, const 
SfxItemSet& rCoreSet ) :
 sOldValueFT = aValueFT.GetText();
 sOldNameFT = aNameFT.GetText();
 
-aCond1ED.ShowBrackets(sal_False);
-aCond2ED.ShowBrackets(sal_False);
+aCond1ED.ShowBrackets(false);
+aCond2ED.ShowBrackets(false);
 
 }
 
@@ -245,7 +245,7 @@ IMPL_LINK_NOARG(SwFldFuncPage, TypeHdl)
 aListNameFT.Show(bDropDown);
 aListNameED.Show(bDropDown

[PATCH] Change in core[libreoffice-4-0]: unify the spelling of 'Kazakh' language name

2013-01-26 Thread Andras Timar (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1876

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/1876/1

unify the spelling of 'Kazakh' language name

While 'Kazakh' can be written as 'Kazak' or 'Qazaq', the 'Kazakh' form
is the most widespread according to online sources (Wikipedia,
LCID list from Microsoft). Also the 'Kazakh' form is preferred by a
Kazakh contributor, see 
http://listarchives.libreoffice.org/global/l10n/msg05444.html
In LibreOffice both 'Kazak' and 'Kazakh' was used at different places.

Change-Id: Ief83eb05e92af16cb5b795f2bbb1e3d6f7c9659a
---
M filter/source/msfilter/countryid.cxx
M i18npool/inc/i18npool/lang.h
M i18npool/source/isolang/isolang.cxx
M i18npool/source/isolang/mslangid.cxx
M shell/source/win32/shlxthandler/util/utilities.cxx
M svtools/source/misc/langtab.src
6 files changed, 6 insertions(+), 6 deletions(-)



diff --git a/filter/source/msfilter/countryid.cxx 
b/filter/source/msfilter/countryid.cxx
index 31915d3..eac02e5 100644
--- a/filter/source/msfilter/countryid.cxx
+++ b/filter/source/msfilter/countryid.cxx
@@ -84,7 +84,7 @@
 { COUNTRY_CANADA,   LANGUAGE_ENGLISH_CAN,   
true},
 { COUNTRY_CANADA,   LANGUAGE_FRENCH_CANADIAN,   
true},
 { COUNTRY_RUSSIA,   LANGUAGE_RUSSIAN,   
false   },
-{ COUNTRY_KAZAKHSTAN,   LANGUAGE_KAZAK, 
false   },
+{ COUNTRY_KAZAKHSTAN,   LANGUAGE_KAZAKH,
false   },
 { COUNTRY_TATARSTAN,LANGUAGE_TATAR, 
false   },
 { COUNTRY_EGYPT,LANGUAGE_ARABIC_EGYPT,  
true},
 { COUNTRY_SOUTH_AFRICA, LANGUAGE_AFRIKAANS, 
false   },
diff --git a/i18npool/inc/i18npool/lang.h b/i18npool/inc/i18npool/lang.h
index 932f92b..dc55f3f 100644
--- a/i18npool/inc/i18npool/lang.h
+++ b/i18npool/inc/i18npool/lang.h
@@ -234,7 +234,7 @@
 #define LANGUAGE_KANURI_NIGERIA 0x0471
 #define LANGUAGE_KASHMIRI   0x0460
 #define LANGUAGE_KASHMIRI_INDIA 0x0860
-#define LANGUAGE_KAZAK  0x043F
+#define LANGUAGE_KAZAKH 0x043F
 #define LANGUAGE_KHMER  0x0453
 #define LANGUAGE_KICHE_GUATEMALA0x0486  /* AKA K'iche', West 
Central Quiche,  */
 #define LANGUAGE_KINYARWANDA_RWANDA 0x0487  /* obsoletes 
LANGUAGE_USER_KINYARWANDA 0x0621 */
diff --git a/i18npool/source/isolang/isolang.cxx 
b/i18npool/source/isolang/isolang.cxx
index bbe3e0f..1ae850d 100644
--- a/i18npool/source/isolang/isolang.cxx
+++ b/i18npool/source/isolang/isolang.cxx
@@ -248,7 +248,7 @@
 { LANGUAGE_BENGALI_BANGLADESH,  "bn", "BD" },
 { LANGUAGE_BENGALI, "bn", "IN" },
 { LANGUAGE_BURMESE, "my", "MM" },
-{ LANGUAGE_KAZAK,   "kk", "KZ" },
+{ LANGUAGE_KAZAKH,  "kk", "KZ" },
 { LANGUAGE_ENGLISH_INDIA,   "en", "IN" },
 { LANGUAGE_URDU,"ur", ""   },
 { LANGUAGE_URDU_INDIA,  "ur", "IN" },
diff --git a/i18npool/source/isolang/mslangid.cxx 
b/i18npool/source/isolang/mslangid.cxx
index 2395d35..b3319aa 100644
--- a/i18npool/source/isolang/mslangid.cxx
+++ b/i18npool/source/isolang/mslangid.cxx
@@ -389,7 +389,7 @@
 /*
 #define LANGUAGE_ARMENIAN   0x042B
 #define LANGUAGE_INDONESIAN 0x0421
-#define LANGUAGE_KAZAK  0x043F
+#define LANGUAGE_KAZAKH 0x043F
 #define LANGUAGE_KONKANI0x0457
 #define LANGUAGE_MACEDONIAN 0x042F
 #define LANGUAGE_TATAR  0x0444
diff --git a/shell/source/win32/shlxthandler/util/utilities.cxx 
b/shell/source/win32/shlxthandler/util/utilities.cxx
index c62ec83..6fc7800 100644
--- a/shell/source/win32/shlxthandler/util/utilities.cxx
+++ b/shell/source/win32/shlxthandler/util/utilities.cxx
@@ -519,7 +519,7 @@
 usSubLang = SUBLANG_DEFAULT;   //default sub 
language
 }
 else if ( wsLanguage == L"kk" )
-usPrimaryLang = LANG_KAZAK;   //Kazak
+usPrimaryLang = LANG_KAZAK;   //Kazakh
 else if ( wsLanguage == L"ky" )
 usPrimaryLang = LANG_KYRGYZ;  //Kyrgyz
 else if ( wsLanguage == L"sw" )
diff --git a/svtools/source/misc/langtab.src b/svtools/source/misc/langtab.src
index 316b3d6..23cb311 100644
--- a/svtools/source/misc/langtab.src
+++ b/svtools/source/misc/langtab.src
@@ -124,7 +124,7 @@
 < "Kannada" ; LANGUAGE_KANNADA ; > ;
 < "Kashmiri (Kashmir)" ; LANGUAGE_KASHMIRI ; > ;
 < "Kashmiri (India)" ; LANGUAGE_KASHMIRI_INDIA ; > ;
-< "Kazak" ; LANGUAGE_KAZAK ; > ;
+< "Kazakh" ; LANGUAGE_K

[Libreoffice-commits] .: filter/source i18npool/inc i18npool/source shell/source svtools/source

2013-01-26 Thread Libreoffice Gerrit user
 filter/source/msfilter/countryid.cxx   |2 +-
 i18npool/inc/i18npool/lang.h   |2 +-
 i18npool/source/isolang/isolang.cxx|2 +-
 i18npool/source/isolang/mslangid.cxx   |2 +-
 shell/source/win32/shlxthandler/util/utilities.cxx |2 +-
 svtools/source/misc/langtab.src|2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 828dfdd4fb9fc133f4e3241e9722f23f3778db08
Author: Andras Timar 
Date:   Sat Jan 26 11:17:10 2013 +0100

unify the spelling of 'Kazakh' language name

While 'Kazakh' can be written as 'Kazak' or 'Qazaq', the 'Kazakh' form
is the most widespread according to online sources (Wikipedia,
LCID list from Microsoft). Also the 'Kazakh' form is preferred by a
Kazakh contributor, see 
http://listarchives.libreoffice.org/global/l10n/msg05444.html
In LibreOffice both 'Kazak' and 'Kazakh' was used at different places.

Change-Id: Ief83eb05e92af16cb5b795f2bbb1e3d6f7c9659a

diff --git a/filter/source/msfilter/countryid.cxx 
b/filter/source/msfilter/countryid.cxx
index 31915d3..eac02e5 100644
--- a/filter/source/msfilter/countryid.cxx
+++ b/filter/source/msfilter/countryid.cxx
@@ -84,7 +84,7 @@ static const CountryEntry pTable[] =
 { COUNTRY_CANADA,   LANGUAGE_ENGLISH_CAN,   
true},
 { COUNTRY_CANADA,   LANGUAGE_FRENCH_CANADIAN,   
true},
 { COUNTRY_RUSSIA,   LANGUAGE_RUSSIAN,   
false   },
-{ COUNTRY_KAZAKHSTAN,   LANGUAGE_KAZAK, 
false   },
+{ COUNTRY_KAZAKHSTAN,   LANGUAGE_KAZAKH,
false   },
 { COUNTRY_TATARSTAN,LANGUAGE_TATAR, 
false   },
 { COUNTRY_EGYPT,LANGUAGE_ARABIC_EGYPT,  
true},
 { COUNTRY_SOUTH_AFRICA, LANGUAGE_AFRIKAANS, 
false   },
diff --git a/i18npool/inc/i18npool/lang.h b/i18npool/inc/i18npool/lang.h
index 932f92b..dc55f3f 100644
--- a/i18npool/inc/i18npool/lang.h
+++ b/i18npool/inc/i18npool/lang.h
@@ -234,7 +234,7 @@ typedef unsigned short LanguageType;
 #define LANGUAGE_KANURI_NIGERIA 0x0471
 #define LANGUAGE_KASHMIRI   0x0460
 #define LANGUAGE_KASHMIRI_INDIA 0x0860
-#define LANGUAGE_KAZAK  0x043F
+#define LANGUAGE_KAZAKH 0x043F
 #define LANGUAGE_KHMER  0x0453
 #define LANGUAGE_KICHE_GUATEMALA0x0486  /* AKA K'iche', West 
Central Quiche,  */
 #define LANGUAGE_KINYARWANDA_RWANDA 0x0487  /* obsoletes 
LANGUAGE_USER_KINYARWANDA 0x0621 */
diff --git a/i18npool/source/isolang/isolang.cxx 
b/i18npool/source/isolang/isolang.cxx
index bbe3e0f..1ae850d 100644
--- a/i18npool/source/isolang/isolang.cxx
+++ b/i18npool/source/isolang/isolang.cxx
@@ -248,7 +248,7 @@ static MsLangId::IsoLangEntry const aImplIsoLangEntries[] =
 { LANGUAGE_BENGALI_BANGLADESH,  "bn", "BD" },
 { LANGUAGE_BENGALI, "bn", "IN" },
 { LANGUAGE_BURMESE, "my", "MM" },
-{ LANGUAGE_KAZAK,   "kk", "KZ" },
+{ LANGUAGE_KAZAKH,  "kk", "KZ" },
 { LANGUAGE_ENGLISH_INDIA,   "en", "IN" },
 { LANGUAGE_URDU,"ur", ""   },
 { LANGUAGE_URDU_INDIA,  "ur", "IN" },
diff --git a/i18npool/source/isolang/mslangid.cxx 
b/i18npool/source/isolang/mslangid.cxx
index 2395d35..b3319aa 100644
--- a/i18npool/source/isolang/mslangid.cxx
+++ b/i18npool/source/isolang/mslangid.cxx
@@ -389,7 +389,7 @@ sal_Int16 MsLangId::getScriptType( LanguageType nLang )
 /*
 #define LANGUAGE_ARMENIAN   0x042B
 #define LANGUAGE_INDONESIAN 0x0421
-#define LANGUAGE_KAZAK  0x043F
+#define LANGUAGE_KAZAKH 0x043F
 #define LANGUAGE_KONKANI0x0457
 #define LANGUAGE_MACEDONIAN 0x042F
 #define LANGUAGE_TATAR  0x0444
diff --git a/shell/source/win32/shlxthandler/util/utilities.cxx 
b/shell/source/win32/shlxthandler/util/utilities.cxx
index c62ec83..6fc7800 100644
--- a/shell/source/win32/shlxthandler/util/utilities.cxx
+++ b/shell/source/win32/shlxthandler/util/utilities.cxx
@@ -519,7 +519,7 @@ LCID LocaleSetToLCID( const LocaleSet_t & Locale )
 usSubLang = SUBLANG_DEFAULT;   //default sub 
language
 }
 else if ( wsLanguage == L"kk" )
-usPrimaryLang = LANG_KAZAK;   //Kazak
+usPrimaryLang = LANG_KAZAK;   //Kazakh
 else if ( wsLanguage == L"ky" )
 usPrimaryLang = LANG_KYRGYZ;  //Kyrgyz
 else if ( wsLanguage == L"sw" )
diff --git a/svtools/source/misc/langtab.src b/svtools/source/misc/langtab.src
index 316b3d6..23c

Code pointers for fdo#43650

2013-01-26 Thread Samuel Mehrbrodt

Hi,

I would like to work on Bug #43650 [1].

The bug is about disabling the tooltip showing Title/Page number when 
scrolling in Writer. But it should only be disabled when scrolling with 
the mouse wheel, not when dragging the scroll bar. From this Apache 
patch [2] I can see where the tool tip is drawn.


What I want to do different than Apache does, is that whether the tool 
tip is shown or not, should not be based on a configuration setting, but 
on whether one is using the mouse wheel.


Can someone please have a look at it and give me a code pointer for that?

Thanks
Samuel

[1] https://bugs.freedesktop.org/show_bug.cgi?id=43650
[2] http://svn.apache.org/viewvc?view=revision&revision=1419993
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Combobox rebuild error

2013-01-26 Thread Ruslan Kabatsayev
Hi,

On Fri, Jan 25, 2013 at 11:05 PM, Rushi Shukla  wrote:
> Hello
>
> I am trying to make code changes to the file
> core/vcl/source/control/combobox.cxx but I have the following errors :
>
>
> core/vcl/source/control/combobox.cxx: In member function ‘virtual void
> ComboBox::Resize()’:
> core/vcl/source/control/combobox.cxx:601:9: error: ‘ComboBoxBounds’ was not
> declared in this scope
> core/vcl/source/control/combobox.cxx:601:24: error: expected ‘;’ before
> ‘aBounds’
> core/vcl/source/control/combobox.cxx:603:36: error: ‘aBounds’ was not
> declared in this scope
> core/vcl/source/control/combobox.cxx: In member function ‘virtual Size
> ComboBox::CalcMinimumSize() const’:
> core/vcl/source/control/combobox.cxx:1072:9: error: ‘ComboBoxBounds’ was not
> declared in this scope
> core/vcl/source/control/combobox.cxx:1072:24: error: expected ‘;’ before
> ‘aBounds’
> core/vcl/source/control/combobox.cxx:1073:24: error: ‘aBounds’ was not
> declared in this scope
> core/vcl/source/control/combobox.cxx: At global scope:
> core/vcl/source/control/combobox.cxx:1498:1: error: ‘ComboBoxBounds’ in
> ‘class ComboBox’ does not name a type
>
> None of my code changes is shown in the errors list and maybe I think the
> commit here produces some changes which might be the cause of the errors :
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=d19eab221f168aed12249ffc8a36a9f1aca5a94e
>

What do your changes look like? You might have added a new data member
before struct ComboBoxBounds declaration, but missing a semicolon,
which would make the struct appear undeclared.
This could in fact be anything. If this code does compile when
unchanged (and it does for me), then we can't tell anything without
seeing your changes.

> Need help on this . Any sort of assistance is appreciated .
>
> Regards ,
> Rushi
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Repeated call to namespace table

2013-01-26 Thread gokul s (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1875

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/1875/1

Repeated call to namespace table

Change-Id: I7cde7c609ee4e5e2cd9ab0be8f973b2626670f13
---
M svx/source/table/tablelayouter.cxx
1 file changed, 0 insertions(+), 1 deletion(-)



diff --git a/svx/source/table/tablelayouter.cxx 
b/svx/source/table/tablelayouter.cxx
index 27bf185..050ba39 100644
--- a/svx/source/table/tablelayouter.cxx
+++ b/svx/source/table/tablelayouter.cxx
@@ -42,7 +42,6 @@
 using ::rtl::OUString;
 using ::com::sun::star::awt::XLayoutConstrains;
 using namespace ::com::sun::star::uno;
-using namespace ::com::sun::star::table;
 using namespace ::com::sun::star::lang;
 using namespace ::com::sun::star::container;
 using namespace ::com::sun::star::beans;

-- 
To view, visit https://gerrit.libreoffice.org/1875
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cde7c609ee4e5e2cd9ab0be8f973b2626670f13
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: gokul s 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice