[Libreoffice-bugs] [Bug 125570] cmd+v and "Edit > Paste" don't behave in the same way

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125570

--- Comment #2 from Nicolas Christener  ---
Tested again in 4.2.4 (50); it's fixed and now works as expected.

I believe, this issue can be closed!

Thanks a lot to the Collabora team ans especially Tor for taking care of this
(through the ongoing development of the iOS app).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa sw/source

[Michael Stahl (via logerrit)]

 sw/qa/extras/unowriter/unowriter.cxx |   51 +++
 sw/source/core/undo/undobj.cxx   |4 +-
 2 files changed, 53 insertions(+), 2 deletions(-)

New commits:
commit 971205dc2110c1c23ff1db1fc4041e2babf6fa9f
Author: Michael Stahl 
AuthorDate: Thu Apr 9 18:31:50 2020 +0200
Commit: Michael Stahl 
CommitDate: Tue Apr 14 16:59:00 2020 +0200

sw: fix fly at-char deletion API behaviour change

28b77c89dfcafae82cf2a6d85731b643ff9290e5 changed at-char anchored fly
selection.

WollMux calls setString("") to remove one character in the first
paragraph and a fly anchored at the start of the body text is deleted
due to the new IsAtStartOfSection() check.

It would be possible to treat deletion via API differently than via UI,
as there is already a flag ExcludeFlyAtStartEnd but it would require
passing the flag through 10 functions and also to store it in
SwUndoDelete...

The main intent of the IsAtStartOfSection() check was that Ctrl+A should
delete every fly; this can be achieved by checking that everything was
selected, so that selections only inside the first/last paragraph don't
delete the flys at the edges.

Change-Id: Id62e7d99a10b42eaecea5564372d29b6c43e3f7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91993
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/unowriter/unowriter.cxx 
b/sw/qa/extras/unowriter/unowriter.cxx
index 4f4c93a13f01..6e67892a027f 100644
--- a/sw/qa/extras/unowriter/unowriter.cxx
+++ b/sw/qa/extras/unowriter/unowriter.cxx
@@ -16,6 +16,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -454,6 +455,56 @@ CPPUNIT_TEST_FIXTURE(SwUnoWriter, testSetPagePrintSettings)
 CPPUNIT_ASSERT_EQUAL(true, aMap.getValue("IsLandscape").get());
 }
 
+CPPUNIT_TEST_FIXTURE(SwUnoWriter, testDeleteFlyAtCharAtStart)
+{
+loadURL("private:factory/swriter", nullptr);
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwWrtShell* const pWrtShell(pTextDoc->GetDocShell()->GetWrtShell());
+SwDoc* const pDoc(pWrtShell->GetDoc());
+
+// insert some text
+IDocumentContentOperations& rIDCO(pDoc->getIDocumentContentOperations());
+rIDCO.InsertString(*pWrtShell->GetCursor(), "foo bar baz");
+
+// insert fly anchored at start of body text
+pWrtShell->ClearMark();
+pWrtShell->SttEndDoc(true);
+SfxItemSet frameSet(pDoc->GetAttrPool(), svl::Items{});
+SfxItemSet grfSet(pDoc->GetAttrPool(), svl::Items{});
+SwFormatAnchor anchor(RndStdIds::FLY_AT_CHAR);
+frameSet.Put(anchor);
+GraphicObject grf;
+CPPUNIT_ASSERT(rIDCO.InsertGraphicObject(*pWrtShell->GetCursor(), grf, 
, ));
+
+// check fly
+uno::Reference xDrawPageSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference xDrawPage = 
xDrawPageSupplier->getDrawPage();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xDrawPage->getCount());
+uno::Reference const xShape(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
+// anchored at start of body text?
+uno::Reference const xText(pTextDoc->getText());
+uno::Reference const xTextRC(xText, 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(0),
+ xTextRC->compareRegionStarts(xText->getStart(), 
xShape->getAnchor()));
+
+// delete 1st character
+uno::Reference const xCursor(xText->createTextCursor());
+xCursor->goRight(1, true);
+xCursor->setString("");
+
+// there is exactly one fly
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xDrawPage->getCount());
+
+// select entire body text
+xCursor->gotoStart(true);
+xCursor->gotoEnd(true);
+xCursor->setString("");
+
+// there is no fly
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), xDrawPage->getCount());
+}
+
 CPPUNIT_TEST_FIXTURE(SwUnoWriter, testSelectionInTableEnum)
 {
 load(mpTestDocumentPath, "selection-in-table-enum.odt");
diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx
index 1a3c85d921ee..0ba193fbc65c 100644
--- a/sw/source/core/undo/undobj.cxx
+++ b/sw/source/core/undo/undobj.cxx
@@ -1571,14 +1571,14 @@ bool IsDestroyFrameAnchoredAtChar(SwPosition const & 
rAnchorPos,
 && ((rStart.nNode != rEnd.nNode && rStart.nContent == 0
 // but not if the selection is backspace/delete!
 && IsNotBackspaceHeuristic(rStart, rEnd))
-|| IsAtStartOfSection(rAnchorPos
+|| (IsAtStartOfSection(rAnchorPos) && 
IsAtEndOfSection(rEnd)
 && ((rAnchorPos < rEnd)
 || (rAnchorPos == rEnd
 && !(nDelContentType & DelContentType::ExcludeFlyAtStartEnd)
 // special case: fully deleted node
 && ((rEnd.nNode != rStart.nNode && rEnd.nContent == 
rEnd.nNode.GetNode().GetTextNode()->Len()
 && 

Re: Corrupted commits prevent import/export of this repo

[Phil Turmel]

Hi Josh,

Git is a blockchain.  You cannot change these without redoing history 
completely from those points onwards, invalidating *everyone's* repos.


Don't hold your breath for this to happen.  Ask Microsoft to fix Devops.

On 4/14/20 4:56 AM, Josh wrote:

Hi there,

I was hoping someone would help me with the trouble I have 
importing/exporting this repo. To setup context I'm trying to import 
this repo to Azure Devops where our team will work and then I would 
periodically push updates made to the main repo 
(https://github.com/LibreOffice/core.git) to my azure devops repo.


The problem I get is that Azure Devops won't allow the import of this 
repo due to corrupted commits. The error can be seen below:


|Oops! Your import of https://github.com/LibreOffice/core.git repository 
failed due to The commit object 657924e4d73d6d501c9a3ceaf62e29b8f243cead 
was rejected: Commit parse failed due to author identity failed to 
parse: Andre FischerFischermailto:andre.f.fisc...@oracle.com>>>|



I may add that this is also the case if you try to import to GitHub as 
well (I understand you can fork in the case of github). You will also 
get this error if you clone locally and try to push to an empty repo 
(github or azure devops).


I've done some investigating as best I can and I'm almost certain it's 
due to the inconsistent use of angle brackets or spaces. By running 
tests locally with fast-export and import I think I've located all the 
corrupted authors below:


Andre Fischer>>

Andre Fischer>
Gregor Hartmann>>
Joerg Skottke >>


Is there a way we could update these in the main repo so that me and 
others wishing to export/import the repo could do so? If so I'm not sure 
on the best way to go about it my knowledge of git is not particularly 
advanced?


Appreciate you reading into this

Thanks,

Josh



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 131446] Fileopen DOCX: 1 page opens as 3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131446

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91565] REPORT BUILDER: Missing insert field icon in Add Field dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91565

Heiko Tietze  changed:

   What|Removed |Added

 CC|heiko.tietze@documentfounda |libreoffice-ux-advise@lists
   |tion.org|.freedesktop.org

--- Comment #17 from Heiko Tietze  ---
(In reply to Rizal Muttaqin from comment #15)
> I have tried to copy Galaxy icons to the dev directory and the result is the
> same: there's no icons appear.
> 
> Just tell us which icon should be added.

Rather a question to dev.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 91565] REPORT BUILDER: Missing insert field icon in Add Field dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91565

Heiko Tietze  changed:

   What|Removed |Added

 CC|heiko.tietze@documentfounda |libreoffice-ux-advise@lists
   |tion.org|.freedesktop.org

--- Comment #17 from Heiko Tietze  ---
(In reply to Rizal Muttaqin from comment #15)
> I have tried to copy Galaxy icons to the dev directory and the result is the
> same: there's no icons appear.
> 
> Just tell us which icon should be added.

Rather a question to dev.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 132076] Calc Chart X-axis format lost with xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132076

Balázs Varga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |balazs.varga...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: cypress_test/integration_tests

[Tamás Zolnai (via logerrit)]

 cypress_test/integration_tests/common/helper.js |  
 22 --
 cypress_test/integration_tests/common/mobile_helper.js  |  
  4 -
 cypress_test/integration_tests/desktop/copy_paste_spec.js   |  
  2 
 cypress_test/integration_tests/mobile/calc/apply_font_spec.js   |  
  4 -
 cypress_test/integration_tests/mobile/calc/insertion_wizard_spec.js |  
 14 ++--
 cypress_test/integration_tests/mobile/calc/number_format_spec.js|  
  4 -
 cypress_test/integration_tests/mobile/calc/spellchecking_spec.js|  
 14 ++--
 cypress_test/integration_tests/mobile/impress/spellchecking_spec.js |  
 14 ++--
 cypress_test/integration_tests/mobile/writer/apply_font_spec.js |  
  6 -
 cypress_test/integration_tests/mobile/writer/focus_spec.js  |  
  6 -
 cypress_test/integration_tests/mobile/writer/insert_field_spec.js   |  
 16 ++---
 cypress_test/integration_tests/mobile/writer/insert_formatting_mark_spec.js |  
 16 ++---
 cypress_test/integration_tests/mobile/writer/insert_object_spec.js  |  
 32 +-
 cypress_test/integration_tests/mobile/writer/mobile_wizard_state_spec.js|  
  4 -
 cypress_test/integration_tests/mobile/writer/shape_properties_spec.js   |  
  4 -
 cypress_test/integration_tests/mobile/writer/spellchecking_spec.js  |  
 30 -
 cypress_test/integration_tests/mobile/writer/writer_helper.js   |  
  5 -
 17 files changed, 87 insertions(+), 110 deletions(-)

New commits:
commit e73c240dd58633f3e8a16349a4194294a464d64b
Author: Tamás Zolnai 
AuthorDate: Tue Apr 14 16:09:22 2020 +0200
Commit: Tamás Zolnai 
CommitDate: Tue Apr 14 16:45:31 2020 +0200

cypress: selectItemByContent() -> cy.contains()

This helper method was introduced as a reliable
alternative of cy.get().contains().
However we can have the same result using contains()
differently: cy.contains(, ), which
works reliable.

Change-Id: I11553f7d280a0f3a94a8f353410308113dd1c825
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92194
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/cypress_test/integration_tests/common/helper.js 
b/cypress_test/integration_tests/common/helper.js
index 6b2ad80c1..61237c81a 100644
--- a/cypress_test/integration_tests/common/helper.js
+++ b/cypress_test/integration_tests/common/helper.js
@@ -160,27 +160,6 @@ function afterAll(fileName) {
cy.log('Waiting for closing the document - end.');
 }
 
-// There is no css selector for filtering based on
-// the content of an item. cypress has Contains()
-// method for that, but it sometimes behaves unexpectedly
-// because it selects the elements first and waits until
-// the existing items gets the specified text, instead of
-// waiting for an item with the right content.
-function selectItemByContent(selector, content) {
-   cy.log('Selecting item by content - start.');
-   cy.log('Param - selector: ' + selector);
-   cy.log('Param - content: ' + content);
-
-   // Wait for the content to appear
-   cy.get(selector)
-   .should('contain.text', content);
-
-   cy.log('Selecting item by content - end.');
-
-   // Select the right item (selector can point to more items)
-   return cy.get(selector).contains(content.replace('\u00a0', ' '));
-}
-
 module.exports.loadTestDoc = loadTestDoc;
 module.exports.assertCursorAndFocus = assertCursorAndFocus;
 module.exports.assertNoKeyboardInput = assertNoKeyboardInput;
@@ -190,4 +169,3 @@ module.exports.clearAllText = clearAllText;
 module.exports.getTextForClipboard = getTextForClipboard;
 module.exports.expectTextForClipboard = expectTextForClipboard;
 module.exports.afterAll = afterAll;
-module.exports.selectItemByContent = selectItemByContent;
diff --git a/cypress_test/integration_tests/common/mobile_helper.js 
b/cypress_test/integration_tests/common/mobile_helper.js
index 1c67b85ef..55639460c 100644
--- a/cypress_test/integration_tests/common/mobile_helper.js
+++ b/cypress_test/integration_tests/common/mobile_helper.js
@@ -34,7 +34,7 @@ function detectLOCoreVersion() {
openHamburgerMenu();
 
// Open about dialog
-   helper.selectItemByContent('.ui-header.level-0 
.menu-entry-with-icon', 'About')
+   cy.contains('.ui-header.level-0 .menu-entry-with-icon', 'About')
.click();
 
cy.get('.vex-content')
@@ -172,7 +172,7 @@ function executeCopyFromContextMenu(XPos, YPos) {
longPressOnDocument(XPos, YPos);
 
// Execute copy
-   helper.selectItemByContent('.menu-entry-with-icon', 'Copy')
+   cy.contains('.menu-entry-with-icon', 'Copy')
.click();
 
// Close warning about clipboard operations
diff --git a/cypress_test/integration_tests/desktop/copy_paste_spec.js 

Re: RFC removing the XPrimitive2D (and related) UNO classes

[Thorsten Behrens]

Hi Tomaž,

Tomaž Vajngerl wrote:
> I'd call it a flaw in the dependency hierarchy, which means something is
> located at a wrong place.
>
Not necessarily. Sometimes it's the lesser evil (and there's always
other design constraints). Not saying this is the case here (haven't
looked in any detail if/how this can be disentangled).

> I know that this can be a "standard-issue" but mostly because a lot
> of times fixing the hierarchy is a lot of work and moving things
> around, but this doesn't mean breaking a circular dependency in such
> a way should be taken lightly or is a good thing.
>
Yep.

> As for UNO - to me UNO API is for making the functionality available
> to extensions, macros, tests. If we use UNO just to circumvent a
> circular dependency, how is that anything but a misuse of UNO API?
>
It's the standard component model for LibreOffice, for better or for
worse. And it's fairly complete with stuff like factories, and more
subtle things like thread apartements.

So using UNO for a bit of fairly self-contained code, that can
usefully be employed by extensions (this "it is not perfect yet, you
cannot use it as-is" is a red herring really), and gives you a factory
that breaks the dependency chain is IMO not a bad thing. Hand-rolling
DLL loading to work around it would be.

> If we extend the UNO API from the point were it is not required for
> extension development, it is prone to be used for things that were
> never meant to be used externally and also YAGNI.
>
There's some truth to that. But it's very hard to draw lines in the
sand here; there's historically been extensions trying to integrate
_very_ intricately even with document views.

The discussion at hand is a different one though: should we
deliberately _remove_ UNO API, despite there being no technical need,
because we _think_ extension authors wouldn't/shouldn't use it?

(the icing of the cake is of course doing that, and then noticing now
you need to code something like the component factory yourself to get
dependency inversion working)

Cheers,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: canvas/source chart2/source comphelper/source compilerplugins/clang connectivity/source cppcanvas/source cppuhelper/source cppu/source cui/source

[Noel Grandin (via logerrit)]

 canvas/source/factory/cf_service.cxx   
|   24 
 canvas/source/tools/canvastools.cxx
|5 
 
chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
 |4 
 chart2/source/tools/ObjectIdentifier.cxx   
|3 
 comphelper/source/misc/threadpool.cxx  
|9 
 compilerplugins/clang/buriedassign.cxx 
|  558 --
 compilerplugins/clang/test/buriedassign.cxx
|   43 
 connectivity/source/commontools/FDatabaseMetaDataResultSetMetaData.cxx 
|   26 
 connectivity/source/commontools/dbtools2.cxx   
|7 
 connectivity/source/commontools/parameters.cxx 
|2 
 connectivity/source/drivers/dbase/DIndexIter.cxx   
|   29 
 connectivity/source/drivers/dbase/dindexnode.cxx   
|7 
 connectivity/source/drivers/firebird/Util.cxx  
|   10 
 connectivity/source/drivers/mysql_jdbc/YTable.cxx  
|   14 
 connectivity/source/drivers/odbc/OFunctions.cxx
|3 
 connectivity/source/drivers/odbc/OResultSetMetaData.cxx
|3 
 connectivity/source/drivers/postgresql/pq_tools.cxx
|   14 
 cppcanvas/source/mtfrenderer/implrenderer.cxx  
|6 
 cppu/source/typelib/static_types.cxx   
|9 
 cppu/source/typelib/typelib.cxx
|   59 -
 cppu/source/uno/copy.hxx   
|8 
 cppu/source/uno/lbenv.cxx  
|7 
 cppu/source/uno/sequence.cxx   
|4 
 cppuhelper/source/tdmgr.cxx
|   16 
 cui/source/dialogs/insdlg.cxx  
|6 
 cui/source/tabpages/backgrnd.cxx   
|   15 
 26 files changed, 654 insertions(+), 237 deletions(-)

New commits:
commit 11785217594d863efb518aa8b8f2910cdcb9c59d
Author: Noel Grandin 
AuthorDate: Tue Apr 14 14:55:22 2020 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 14 16:35:38 2020 +0200

loplugin:buriedassign in c*

Change-Id: Id14fed7e5c0f588ad3c927f12251432d12c1a7c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92190
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/factory/cf_service.cxx 
b/canvas/source/factory/cf_service.cxx
index 86dbc2f12aeb..936c99885f20 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -321,13 +321,13 @@ Reference CanvasFactory::lookupAndUse(
 
 // try to reuse last working implementation for given service name
 const CacheVector::iterator aEnd(m_aCachedImplementations.end());
-CacheVector::iterator aMatch;
-if( (aMatch=std::find_if(
+auto aMatch = std::find_if(
 m_aCachedImplementations.begin(),
 aEnd,
 [](CachePair const& cp)
 { return serviceName == cp.first; }
-)) != aEnd) {
+);
+if( aMatch != aEnd ) {
 Reference xCanvas( use( aMatch->second, args, xContext ) );
 if(xCanvas.is())
 return xCanvas;
@@ -335,35 +335,35 @@ Reference CanvasFactory::lookupAndUse(
 
 // lookup in available service list
 const AvailVector::const_iterator 
aAvailEnd(m_aAvailableImplementations.end());
-AvailVector::const_iterator aAvailImplsMatch;
-if( (aAvailImplsMatch=std::find_if(
+auto aAvailImplsMatch = std::find_if(
 m_aAvailableImplementations.begin(),
 aAvailEnd,
 [](AvailPair const& ap)
 { return serviceName == ap.first; }
-)) == aAvailEnd ) {
+);
+if( aAvailImplsMatch == aAvailEnd ) {
 return Reference();
 }
 
 const AvailVector::const_iterator aAAEnd(m_aAAImplementations.end());
-AvailVector::const_iterator aAAImplsMatch;
-if( (aAAImplsMatch=std::find_if(
+auto aAAImplsMatch = std::find_if(
 m_aAAImplementations.begin(),
 aAAEnd,
 [](AvailPair const& ap)
 { return serviceName == ap.first; }
-)) == aAAEnd) {
+);
+if( aAAImplsMatch == aAAEnd ) {
 return Reference();
 }
 
   

[Libreoffice-bugs] [Bug 132083] FORMATTING - Wrong date substraction in cell's operation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132083

--- Comment #12 from ja...@sortsk.pl ---
All these are consequences of the use of floating point numbers, while best
fits integers.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91565] REPORT BUILDER: Missing insert field icon in Add Field dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91565

Julien Nabet  changed:

   What|Removed |Added

   Keywords||needsUXEval

--- Comment #16 from Julien Nabet  ---
Let's put needsUXEval following Rizal's comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130844] data range in chart creation fail

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130844

azarshaik...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEEDINFO|RESOLVED

--- Comment #3 from azarshaik...@gmail.com ---
i will say it is not a feature

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132098] New: Custom InteractionHandler

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132098

Bug ID: 132098
   Summary: Custom InteractionHandler
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: prrv...@gmail.com

Created attachment 159557
  --> https://bugs.documentfoundation.org/attachment.cgi?id=159557=edit
IDL file for Execption of type com.sun.star.auth.OAuth2Request

I wan to implement a custom InteractionHandler who handle request of type 
com.sun.star.auth.OAuth2Request (see attached IDL file).

When I handle the request in my XInteractionHandler2 interface
handleInteractionRequest(), I cannot access the request by
interaction.getRequest() it throw an exception:
AttributeError: "args" on File "/usr/lib/python3/dist-packages/uno.py" at line
525 in "_uno_struct__setattr__"

As a workaround I must set an "args" property of type "sequence" to the
IDL file of com.sun.star.auth.OAuth2Request Exception who is normally returned
by interaction.getRequest()...
(see attached IDL file)

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: cypress_test/integration_tests cypress_test/Makefile.am

[Tamás Zolnai (via logerrit)]

 cypress_test/Makefile.am|   30 +++-
 cypress_test/integration_tests/common/helper.js |   10 ++--
 2 files changed, 12 insertions(+), 28 deletions(-)

New commits:
commit 96819f81cb509e61b0988bd4fcf0d1a1ac2cfe0d
Author: Tamás Zolnai 
AuthorDate: Tue Apr 14 12:29:30 2020 +0200
Commit: Tamás Zolnai 
CommitDate: Tue Apr 14 16:22:35 2020 +0200

cypress: generate test names dynamically for the parallel build.

Also improve afterAll(). Having test files with the same suffix
led to test failure. We can have better result with a regex.

Change-Id: I8d678aa17eb0e28e643cc86f584aab713ca153ca
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92157
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/cypress_test/Makefile.am b/cypress_test/Makefile.am
index 40f53c10b..5b616084b 100644
--- a/cypress_test/Makefile.am
+++ b/cypress_test/Makefile.am
@@ -34,32 +34,10 @@ export DISPLAY=$(if 
$(HEADLESS_BUILD),:$(DISPLAY_NUMBER),$(shell echo $$DISPLAY)
 WSD_VERSION_HASH := ""
 
 if HAVE_LO_PATH
-MOBILE_TEST_FILES= \
-   calc/alignment_options_spec.js \
-   calc/apply_font_spec.js \
-   calc/focus_spec.js \
-   calc/insertion_wizard_spec.js \
-   calc/number_format_spec.js \
-   calc/spellchecking_spec.js \
-   impress/impress_focus_spec.js \
-   impress/spellchecking_spec.js \
-   writer/apply_font_spec.js \
-   writer/apply_paragraph_properties_spec.js \
-   writer/bottom_toolbar_spec.js \
-   writer/focus_spec.js \
-   writer/insert_field_spec.js \
-   writer/insert_formatting_mark_spec.js \
-   writer/insert_object_spec.js \
-   writer/mobile_wizard_state_spec.js \
-   writer/shape_properties_spec.js \
-   writer/spellchecking_spec.js \
-   writer/table_properties_spec.js \
-   writer/toolbar_spec.js
-
-DEKSTOP_TEST_FILES= \
-   copy_paste_spec.js \
-   example_desktop_test_spec.js \
-   shape_operations_spec.js
+
+MOBILE_TEST_FILES=$(subst $(MOBILE_TEST_FOLDER)/,,$(wildcard 
$(MOBILE_TEST_FOLDER)/*_spec.js) $(wildcard $(MOBILE_TEST_FOLDER)/*/*_spec.js))
+
+DEKSTOP_TEST_FILES=$(subst $(DESKTOP_TEST_FOLDER)/,,$(wildcard 
$(DESKTOP_TEST_FOLDER)/*_spec.js) $(wildcard 
$(DESKTOP_TEST_FOLDER)/*/*_spec.js))
 
 MOBILE_TEST_FILES_DONE= \
$(foreach 
test_file,$(MOBILE_TEST_FILES),$(MOBILE_TRACK_FOLDER)/$(test_file).done)
diff --git a/cypress_test/integration_tests/common/helper.js 
b/cypress_test/integration_tests/common/helper.js
index 9eab3b5b1..6b2ad80c1 100644
--- a/cypress_test/integration_tests/common/helper.js
+++ b/cypress_test/integration_tests/common/helper.js
@@ -148,8 +148,14 @@ function afterAll(fileName) {
cy.get('#uptime')
.should('not.have.text', '0');
 
-   cy.get('#doclist td:nth-child(2)')
-   .should('not.contain.text', fileName);
+   // We have all lines of document infos as one long string.
+   // We have PID number before the file names, with matching
+   // also on the PID number we can make sure to match on the
+   // whole file name, not on a suffix of a file name.
+   var regex = new RegExp('[0-9]' + fileName);
+   cy.get('#docview')
+   .invoke('text')
+   .should('not.match', regex);
 
cy.log('Waiting for closing the document - end.');
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basegfx/source basic/source bean/native bridges/source

[Noel Grandin (via logerrit)]

 basegfx/source/point/b2dpoint.cxx|3 
 basegfx/source/point/b3dpoint.cxx|3 
 basegfx/source/range/b2drange.cxx|3 
 basegfx/source/range/b3drange.cxx|3 
 basegfx/source/vector/b2dvector.cxx  |3 
 basegfx/source/vector/b3dvector.cxx  |3 
 basic/source/comp/exprtree.cxx   |3 
 basic/source/comp/token.cxx  |   44 +++
 basic/source/runtime/runtime.cxx |   11 +-
 basic/source/uno/namecont.cxx|6 +
 bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c |5 -
 bridges/source/cpp_uno/shared/component.cxx  |3 
 12 files changed, 60 insertions(+), 30 deletions(-)

New commits:
commit 14471a694271777440c19916055d659337c0fb8d
Author: Noel Grandin 
AuthorDate: Tue Apr 14 14:54:45 2020 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 14 16:17:55 2020 +0200

loplugin:buriedassign in b*

Change-Id: Ic20f46105a30b54bc5a991b4070e6c8edb15376e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92189
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basegfx/source/point/b2dpoint.cxx 
b/basegfx/source/point/b2dpoint.cxx
index 9775e1476740..0dc18b513db1 100644
--- a/basegfx/source/point/b2dpoint.cxx
+++ b/basegfx/source/point/b2dpoint.cxx
@@ -65,7 +65,8 @@ namespace basegfx
 B2DPoint operator*( const ::basegfx::B2DHomMatrix& rMat, const B2DPoint& 
rPoint )
 {
 B2DPoint aRes( rPoint );
-return aRes *= rMat;
+aRes *= rMat;
+return aRes;
 }
 } // end of namespace basegfx
 
diff --git a/basegfx/source/point/b3dpoint.cxx 
b/basegfx/source/point/b3dpoint.cxx
index 0e44dad13d79..ff70b501ed7a 100644
--- a/basegfx/source/point/b3dpoint.cxx
+++ b/basegfx/source/point/b3dpoint.cxx
@@ -68,7 +68,8 @@ namespace basegfx
 B3DPoint operator*( const ::basegfx::B3DHomMatrix& rMat, const B3DPoint& 
rPoint )
 {
 B3DPoint aRes( rPoint );
-return aRes *= rMat;
+aRes *= rMat;
+return aRes;
 }
 } // end of namespace basegfx
 
diff --git a/basegfx/source/range/b2drange.cxx 
b/basegfx/source/range/b2drange.cxx
index a5f0db728eb5..55b545933d88 100644
--- a/basegfx/source/range/b2drange.cxx
+++ b/basegfx/source/range/b2drange.cxx
@@ -74,7 +74,8 @@ namespace basegfx
 B2DRange operator*( const ::basegfx::B2DHomMatrix& rMat, const B2DRange& 
rB2DRange )
 {
 B2DRange aRes( rB2DRange );
-return aRes *= rMat;
+aRes *= rMat;
+return aRes;
 }
 
 } // end of namespace basegfx
diff --git a/basegfx/source/range/b3drange.cxx 
b/basegfx/source/range/b3drange.cxx
index 40e2f7ddf419..a8e5f359c3e3 100644
--- a/basegfx/source/range/b3drange.cxx
+++ b/basegfx/source/range/b3drange.cxx
@@ -55,7 +55,8 @@ namespace basegfx
 B3DRange operator*( const ::basegfx::B3DHomMatrix& rMat, const B3DRange& 
rB3DRange )
 {
 B3DRange aRes( rB3DRange );
-return aRes *= rMat;
+aRes *= rMat;
+return aRes;
 }
 
 } // end of namespace basegfx
diff --git a/basegfx/source/vector/b2dvector.cxx 
b/basegfx/source/vector/b2dvector.cxx
index a9223175e4ee..1ad51a9b5a4c 100644
--- a/basegfx/source/vector/b2dvector.cxx
+++ b/basegfx/source/vector/b2dvector.cxx
@@ -161,7 +161,8 @@ namespace basegfx
 B2DVector operator*( const B2DHomMatrix& rMat, const B2DVector& rVec )
 {
 B2DVector aRes( rVec );
-return aRes*=rMat;
+aRes *= rMat;
+return aRes;
 }
 
 B2VectorContinuity getContinuity(const B2DVector& rBackVector, const 
B2DVector& rForwardVector )
diff --git a/basegfx/source/vector/b3dvector.cxx 
b/basegfx/source/vector/b3dvector.cxx
index 22a7c6220960..7dd5acf57f36 100644
--- a/basegfx/source/vector/b3dvector.cxx
+++ b/basegfx/source/vector/b3dvector.cxx
@@ -68,7 +68,8 @@ namespace basegfx
 B3DVector operator*( const ::basegfx::B3DHomMatrix& rMat, const B3DVector& 
rVec )
 {
 B3DVector aRes( rVec );
-return aRes*=rMat;
+aRes *= rMat;
+return aRes;
 }
 
 bool areParallel( const B3DVector& rVecA, const B3DVector& rVecB )
diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx
index 4fe389983d28..cd6094db736b 100644
--- a/basic/source/comp/exprtree.cxx
+++ b/basic/source/comp/exprtree.cxx
@@ -210,7 +210,8 @@ std::unique_ptr SbiExpression::Term( const 
KeywordSymbolInfo* pKeyw
 bError = true;
 }
 
-if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )
+eTok = eNextTok;
+if( DoParametersFollow( pParser, eCurExpr, eTok ) )
 {
 bool bStandaloneExpression = (m_eMode == EXPRMODE_STANDALONE);
 pPar = SbiExprList::ParseParameters( pParser, bStandaloneExpression );
diff --git 

[Libreoffice-bugs] [Bug 131718] Deleting a chart of a large dataset quite slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131718

ian  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1

--- Comment #1 from ian  ---
Hey, Telesto. 

Can you please attach the file associated with your bug report?

I have set the status to "NEEDINFO." 

Please change it back after attaching the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132083] FORMATTING - Wrong date substraction in cell's operation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132083

--- Comment #11 from Mike Kaganski  ---
(In reply to jarko from comment #10)
> The whole discussion is about what kind of method is preferred when
> presenting data: impossible exact binary representation of given number or
> exact number known to user. If program/procedure/script assumes that "user
> has always right", than it proceed with any operation needed to finally get
> that exact number. If not - simply do the best with arithmetic, but with
> rounding error.

Sigh. You seem to not follow the "discussion".

First, you confuse "presenting data" and storing the data. Then you mix the
specific issue raised here in this tdf#132083 (which is about changed *display*
- presentation - of the very same data that was already in previous versions)
with an irrelevant "discussion" about "any operation needed to finally get that
exact number" (this is not about representation, but about calculations), which
is explained in the FAQ. In the end, you don't realize that there's *no* way to
do what you think is doable ("any operation needed to finally get that exact
number"). Very often, simple (for a basic school pupil) mathematics would need
infinite time and memory to be calculated exactly in existing computers. So
this is not some meaningful "discussion" about what "kind of method" to use,
but rather about "what this world is" vs "what I want it to be", which is
absolutely useless in this issue - it's simply offtopic. You *can not* make
calculations with data with infinite precision. You can't even have a true Pi
in a modern computer, no matter how long will you calculate that to "assume
that user has always right".

*Sometimes* some *small subset* - not all - of operations could be calculated
exactly if done differently (it means, not using the computer's arithmetic
processor, but with in software algorithms requiring much extra memory, and
much extra time). But even that is *not* "assuming that user has always right",
because the primary goal of spreadsheet software is *massive calculations* on
big amounts of data represented in tabular form. The user for whom the software
is created needs it to process those big amounts in timely fashion, and it's
*that* user who the software assumes is right in that expectation. If Calc
would try to give exact results even in theoretically possible cases, its users
(who use it for real job, not as a calculator for two numbers) would say "It
must give us answers, not f**k up our precious time for own enjoyment
calculating with full precision, which taking years to complete".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

--- Comment #6 from V Stuart Foote  ---
(In reply to Telesto from comment #2)
> Safe mode has already a link to the User profile, under Advanced. 
> A similar link as 'show user profile' could be added there 

But, you'd really have to drill down to it... so would need Wiki guidance
anyhow.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116679] All modules crash in Format > Character, or opening Print dialog (Crash in: RC96E100.DLL driver) with RICOH RPCS Printer selected for use (comment 14 for workaround)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116679

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Status|NEW |NEEDINFO

--- Comment #20 from Julien Nabet  ---
Following last Mike's comment, let's put this one to NEEDINFO?

Also, you can give a try to 6.3.5 or last 6.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

--- Comment #6 from V Stuart Foote  ---
(In reply to Telesto from comment #2)
> Safe mode has already a link to the User profile, under Advanced. 
> A similar link as 'show user profile' could be added there 

But, you'd really have to drill down to it... so would need Wiki guidance
anyhow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

--- Comment #5 from Telesto  ---
(In reply to Julien Nabet from comment #4)
> What about adding a paragraph in this page
> https://wiki.documentfoundation.org/QA/FirstSteps ?
> I often provide this link for bug reporters who got some errors.

The current wiki isn't really helpful
/cache/opengl_device.log,

Which again refers to:
https://wiki.documentfoundation.org/UserProfile#User_profile_location

And everything is in English (without translation).. Yes of course people
report bug report will... It's only helpful instrument for blacklisting drivers
if people can easily find the log [probably overstating the issue]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

--- Comment #5 from Telesto  ---
(In reply to Julien Nabet from comment #4)
> What about adding a paragraph in this page
> https://wiki.documentfoundation.org/QA/FirstSteps ?
> I often provide this link for bug reporters who got some errors.

The current wiki isn't really helpful
/cache/opengl_device.log,

Which again refers to:
https://wiki.documentfoundation.org/UserProfile#User_profile_location

And everything is in English (without translation).. Yes of course people
report bug report will... It's only helpful instrument for blacklisting drivers
if people can easily find the log [probably overstating the issue]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132066] UI: Don't translate the vulkan/raster specifier in about window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132066

Telesto  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #5 from Telesto  ---
(In reply to Luboš Luňák from comment #4)
> (In reply to Telesto from comment #3)
> > I can't read Russian, Chinese, Japanese, etc. It's essential to know if it's
> > Skia Raster or Vulkan. It makes QA unnecessary hard
> 
> All I am saying is that Skia is not special here. If there is a problem with
> "Skia/Vulkan", then presumably there is also a problem with "gen",
> "threaded" or "default".

A, sorry for the noise. Yes, you're correct "threaded" or "default" are also
translated.

The (Dutch) translation is also mix of Dutch/English (probably because of
lacking equivalents [or incomplete translation?]. And confusing too. Calc: CL

These view lines in about containing the technical information should be
translated at all. Adding the UX-department to the loop.

[There must be objections in the area of  GUI translation consistency etc etc.]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 132066] UI: Don't translate the vulkan/raster specifier in about window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132066

Telesto  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #5 from Telesto  ---
(In reply to Luboš Luňák from comment #4)
> (In reply to Telesto from comment #3)
> > I can't read Russian, Chinese, Japanese, etc. It's essential to know if it's
> > Skia Raster or Vulkan. It makes QA unnecessary hard
> 
> All I am saying is that Skia is not special here. If there is a problem with
> "Skia/Vulkan", then presumably there is also a problem with "gen",
> "threaded" or "default".

A, sorry for the noise. Yes, you're correct "threaded" or "default" are also
translated.

The (Dutch) translation is also mix of Dutch/English (probably because of
lacking equivalents [or incomplete translation?]. And confusing too. Calc: CL

These view lines in about containing the technical information should be
translated at all. Adding the UX-department to the loop.

[There must be objections in the area of  GUI translation consistency etc etc.]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

[Noel Grandin (via logerrit)]

 filter/source/config/cache/basecontainer.cxx |   32 
 filter/source/config/cache/configflush.cxx   |   32 
 filter/source/config/cache/typedetection.cxx |   24 
 filter/source/flash/swfwriter.cxx|   22 
 filter/source/flash/swfwriter1.cxx   |  304 +-
 filter/source/graphic/GraphicExportFilter.cxx|   28 
 filter/source/graphicfilter/egif/egif.cxx|  358 +-
 filter/source/graphicfilter/egif/giflzwc.cxx |  122 
 filter/source/graphicfilter/eps/eps.cxx  |  222 -
 filter/source/graphicfilter/icgm/actimpr.cxx |  794 ++---
 filter/source/graphicfilter/icgm/cgm.cxx |  278 -
 filter/source/graphicfilter/idxf/dxf2mtf.cxx |  428 +--
 filter/source/graphicfilter/itiff/itiff.cxx  |   30 
 filter/source/msfilter/escherex.cxx  | 2656 +--
 filter/source/msfilter/eschesdo.cxx  |   54 
 filter/source/msfilter/mscodec.cxx   |   38 
 filter/source/msfilter/msdffimp.cxx  |  580 ++--
 filter/source/msfilter/mstoolbar.cxx |   48 
 filter/source/msfilter/svdfppt.cxx   | 1810 ++--
 filter/source/pdf/impdialog.cxx  |   80 
 filter/source/pdf/pdfexport.cxx  |   34 
 filter/source/svg/svgexport.cxx  |  456 +--
 filter/source/svg/svgfontexport.cxx  |  150 -
 filter/source/svg/svgwriter.cxx  |  874 +++---
 filter/source/t602/t602filter.cxx|   41 
 filter/source/xsltdialog/typedetectionimport.cxx |   50 
 filter/source/xsltdialog/xmlfilterjar.cxx|   28 
 filter/source/xsltdialog/xmlfiltersettingsdialog.cxx |  144 -
 filter/source/xsltdialog/xmlfiltertabpagebasic.cxx   |   76 
 filter/source/xsltdialog/xmlfiltertestdialog.cxx |   38 
 30 files changed, 4920 insertions(+), 4911 deletions(-)

New commits:
commit e6b8be25a6fb5afbd1649489318a7a2d7ae62efa
Author: Noel Grandin 
AuthorDate: Tue Apr 14 14:47:34 2020 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 14 15:44:42 2020 +0200

loplugin:flatten in filter

Change-Id: I24861f7401c0046962d536950fe8b2b6bdbad969
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92186
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/filter/source/config/cache/basecontainer.cxx 
b/filter/source/config/cache/basecontainer.cxx
index 60b8332314c2..4f7b4f04ca49 100644
--- a/filter/source/config/cache/basecontainer.cxx
+++ b/filter/source/config/cache/basecontainer.cxx
@@ -454,24 +454,24 @@ void SAL_CALL BaseContainer::flush()
 // if an outside object is called :-)
 css::lang::EventObject aSource(static_cast< 
css::util::XFlushable* >(this));
 ::cppu::OInterfaceContainerHelper* pContainer = 
m_lListener.getContainer(cppu::UnoType::get());
-if (pContainer)
+if (!pContainer)
+return;
+
+::cppu::OInterfaceIteratorHelper pIterator(*pContainer);
+while (pIterator.hasMoreElements())
 {
-::cppu::OInterfaceIteratorHelper pIterator(*pContainer);
-while (pIterator.hasMoreElements())
+try
+{
+// ... this pointer can be interesting to find out, where will be 
called as listener
+// Don't optimize it to a direct iterator cast :-)
+css::util::XFlushListener* pListener = 
static_cast(pIterator.next());
+pListener->flushed(aSource);
+}
+catch(const css::uno::Exception&)
 {
-try
-{
-// ... this pointer can be interesting to find out, where will 
be called as listener
-// Don't optimize it to a direct iterator cast :-)
-css::util::XFlushListener* pListener = 
static_cast(pIterator.next());
-pListener->flushed(aSource);
-}
-catch(const css::uno::Exception&)
-{
-// ignore any "damaged" flush listener!
-// May its remote reference is broken ...
-pIterator.remove();
-}
+// ignore any "damaged" flush listener!
+// May its remote reference is broken ...
+pIterator.remove();
 }
 }
 }
diff --git a/filter/source/config/cache/configflush.cxx 
b/filter/source/config/cache/configflush.cxx
index f9193712c7dd..97699c2c0508 100644
--- a/filter/source/config/cache/configflush.cxx
+++ b/filter/source/config/cache/configflush.cxx
@@ -58,24 +58,24 @@ void SAL_CALL ConfigFlush::refresh()
 // if an outside object is called :-)
 css::lang::EventObject aSource(static_cast< 
css::util::XRefreshable* >(this));
 ::cppu::OInterfaceContainerHelper* pContainer = 
m_lListener.getContainer(cppu::UnoType::get());
-if (pContainer)
+if (!pContainer)
+return;
+
+::cppu::OInterfaceIteratorHelper 

[Libreoffice-bugs] [Bug 131931] No version history shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131931

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #4 from Xisco Faulí  ---
Verified in

Version: 7.0.0.0.alpha0+
Build ID: 35fc5ef0a759884b24ed8b83cd05702a0fab64cc
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

@Noel, thanks for fixing this issue!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: kit/ChildSession.cpp

[Tomaž Vajngerl (via logerrit)]

 kit/ChildSession.cpp |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 1e97fdf799b925c34da2c800fd3b20922d89e7aa
Author: Tomaž Vajngerl 
AuthorDate: Tue Apr 14 07:47:39 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 14 15:41:07 2020 +0200

handle tabstop callback and send it as "tabstoplistupdate"

Handle LOK_CALLBACK_TAB_STOP_LIST and send the payload to the
loleaflet side under "tabstoplistupdate" identifier.

Change-Id: I4bf8c48bd825dec81ef766b7bce536dd399e8b86
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92141
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tomaž Vajngerl 

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 9ccaa20f9..780efb18f 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -2564,6 +2564,9 @@ void ChildSession::loKitCallback(const int type, const 
std::string& payload)
 case LOK_CALLBACK_CALC_FUNCTION_LIST:
 sendTextFrame("calcfunctionlist: " + payload);
 break;
+case LOK_CALLBACK_TAB_STOP_LIST:
+sendTextFrame("tabstoplistupdate: " + payload);
+break;
 
 #if !ENABLE_DEBUG
 // we want a compilation-time failure in the debug builds; but ERR in the
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
What about adding a paragraph in this page
https://wiki.documentfoundation.org/QA/FirstSteps ?
I often provide this link for bug reporters who got some errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
What about adding a paragraph in this page
https://wiki.documentfoundation.org/QA/FirstSteps ?
I often provide this link for bug reporters who got some errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
Bug 129062 depends on bug 132013, which changed state.

Bug 132013 Summary: Dragging a smiley around with Skia Raster mode noticeable 
slower compared to GDI/OpenGL/Vulkan
https://bugs.documentfoundation.org/show_bug.cgi?id=132013

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132013] Dragging a smiley around with Skia Raster mode noticeable slower compared to GDI/OpenGL/Vulkan

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132013

Luboš Luňák  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Luboš Luňák  ---


*** This bug has been marked as a duplicate of bug 131697 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131697] Slow scrolling if shapes are visible in Calc with Skia enabled in Software mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131697

--- Comment #6 from Luboš Luňák  ---
*** Bug 132013 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122565] Classification dialog - Button "bold" works only in dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122565

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #4 from Xisco Faulí  ---
Verified in

Version: 7.0.0.0.alpha0+
Build ID: 35fc5ef0a759884b24ed8b83cd05702a0fab64cc
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

I've created a uitest for it < https://gerrit.libreoffice.org/c/core/+/92191 >
however the click on bold button doesn't work properly...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132083] FORMATTING - Wrong date substraction in cell's operation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132083

--- Comment #10 from ja...@sortsk.pl ---
The whole discussion is about what kind of method is preferred when presenting
data: impossible exact binary representation of given number or exact number
known to user. If program/procedure/script assumes that "user has always
right", than it proceed with any operation needed to finally get that exact
number. If not - simply do the best with arithmetic, but with rounding error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122565] Classification dialog - Button "bold" works only in dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122565

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2491

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122491] Classification: dialog (Paragraph) Classification doesn't show previously chosen classification

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122491

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2565

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131605] Crash in: swlo.dll

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131605

--- Comment #3 from Dieter  ---
*** Bug 132030 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132030] Crash in: swlo.dll

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132030

Dieter  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEEDINFO|RESOLVED

--- Comment #3 from Dieter  ---
Porscholz, thank you for your response. I'll close this bug as duplicate.
Please add some steps to reproduce at bug 131605. For example there are no
informations, that it is about field names. It might also be helpful to add a
document that shows the bug.

*** This bug has been marked as a duplicate of bug 131605 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122894] FILEOPEN DOC: Crash: SwFrame::RemoveFromLayout()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122894

--- Comment #12 from Jan-Marek Glogowski  ---
(In reply to Xisco Faulí from comment #7)
> The crash got fixed by
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=1052acae9a599c54e518c8fc17d6a994d8778757, however, it still hangs at
> import time...

So I had a look at this. If I revert the whole five patches it crashes:

Initial positioning text wrap:
 * commit dc3e213dcd81be3eee8d139ea5ad55606a44eeff
 * commit f497d1dc27b4fee3db1e2228647a00971922eb5f
 * commit 1052acae9a599c54e518c8fc17d6a994d8778757

Footnote refactoring:
 * commit 642cdf2d8341f0b202f01718ccb63ac1b976e18e
 * commit 24caeee8236576abd92086974c1dbbf15b81a4c5

If I keep that revert and just apply the two broken patches:

 * commit 1052acae9a599c54e518c8fc17d6a994d8778757
 * commit 24caeee8236576abd92086974c1dbbf15b81a4c5

it hangs, but that's the same hang as bug 131530, which I fixed with

 * commit 642cdf2d8341f0b202f01718ccb63ac1b976e18e

which was a Copy'n'Paste bug in my refactoring commit to begin with.

So while comment 7 is correct from the "user perspective", it's simply not true
that the crash was ever "fixed" from the code perspective.

And the valgrind log is the same with or without the whole patchset. See the
attachment 159556.

Just an info for someone trying to fix this, as I just have a symbol build and
the optimization makes this hard to debug further.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote  ---
a Wiki write-up off the QA pages is probably better--and this => WF

but if we had to provide, perhaps URI off the Help -> About dialog?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote  ---
a Wiki write-up off the QA pages is probably better--and this => WF

but if we had to provide, perhaps URI off the Help -> About dialog?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 131645] Wrong line width representation in an ole draw object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131645

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #2 from Dieter  ---
I can't confirm it with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 962b415edb47187737a5f05c4ff3f6724a19c564
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

Tested with a width of 0,02 cm.

Could you please add a sample document? Pershaps this makes it easier wo
reproduce the bug. Thank you.

=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122894] FILEOPEN DOC: Crash: SwFrame::RemoveFromLayout()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122894

--- Comment #11 from Jan-Marek Glogowski  ---
Created attachment 159556
  --> https://bugs.documentfoundation.org/attachment.cgi?id=159556=edit
First valgrind block accessing freed memory

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132030] Crash in: swlo.dll

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132030

--- Comment #2 from porscholz  ---
Earlier bug report was 131605. After days and nights of struggeling with this
crashs I found on http://www.ooowiki.de/BedingungenPr(c3bc)fen.html #2
specifications about fieldnames. The original fieldnames of Thunderbird
addressbook (in German) don't match these specifications.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132022] Remove Tango Icon Completely and Make It As Extension

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132022

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||7755

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127755] Tango icon theme needs different icons for module and library

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127755

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2022

--- Comment #11 from Heiko Tietze  ---
(In reply to Adolfo Jayme from comment #10)
> Tango is removed from 7.0. → WONTFIX

It might be removed, see 132022.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 127755] Tango icon theme needs different icons for module and library

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127755

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2022

--- Comment #11 from Heiko Tietze  ---
(In reply to Adolfo Jayme from comment #10)
> Tango is removed from 7.0. → WONTFIX

It might be removed, see 132022.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

--- Comment #2 from Telesto  ---
Safe mode has already a link to the User profile, under Advanced. 
A similar link as 'show user profile' could be added there 

Or change the link of Show user profile directory to show
AppData\Roaming\LibreOfficeDev\4\ instead of 'folder'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

--- Comment #2 from Telesto  ---
Safe mode has already a link to the User profile, under Advanced. 
A similar link as 'show user profile' could be added there 

Or change the link of Show user profile directory to show
AppData\Roaming\LibreOfficeDev\4\ instead of 'folder'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 132004] Keep current chapter on top of the screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132004

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
agree with => WFM, visual indicator of position is available in the Navigator
deck.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132004] Keep current chapter on top of the screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132004

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
agree with => WFM, visual indicator of position is available in the Navigator
deck.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - include/LibreOfficeKit include/svx libreofficekit/source svx/sdi sw/sdi sw/source

[Tomaž Vajngerl (via logerrit)]

 include/LibreOfficeKit/LibreOfficeKitEnums.h |9 +++
 include/svx/svxids.hrc   |3 +
 libreofficekit/source/gtk/lokdocview.cxx |1 
 svx/sdi/svx.sdi  |   19 +++
 sw/sdi/_viewsh.sdi   |4 +
 sw/source/uibase/uiview/viewtab.cxx  |   70 ++-
 6 files changed, 103 insertions(+), 3 deletions(-)

New commits:
commit d6a15427a15166c4910e28645346cd47135b706a
Author: Tomaž Vajngerl 
AuthorDate: Tue Apr 14 07:35:02 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 14 15:03:22 2020 +0200

lok: add tabstop changing and callback to send tabstop updates

This adds callback LOK_CALLBACK_TAB_STOP_LIST to send the tabstops
for the current paragraph.
In addition it adds .uno:ChangeTabStop action, with which it is
possible to change just one tabstop identified by the index.

Change-Id: I7762ead12e47288cbb0b0a1c8ffb8e9872cee8e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92139
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index de547df505ea..401b5f24dc0b 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -720,7 +720,12 @@ typedef enum
  * Send the list of functions whose name starts with the characters entered
  * by the user in the formula input bar.
  */
-LOK_CALLBACK_CALC_FUNCTION_LIST = 47
+LOK_CALLBACK_CALC_FUNCTION_LIST = 47,
+
+/**
+ * Sends the tab stop list for the current of the current cursor position.
+ */
+LOK_CALLBACK_TAB_STOP_LIST = 48,
 }
 LibreOfficeKitCallbackType;
 
@@ -845,6 +850,8 @@ static inline const char* lokCallbackTypeToString(int nType)
 return "LOK_CALLBACK_JSDIALOG";
 case LOK_CALLBACK_CALC_FUNCTION_LIST:
 return "LOK_CALLBACK_CALC_FUNCTION_LIST";
+case LOK_CALLBACK_TAB_STOP_LIST:
+return "LOK_CALLBACK_TAB_STOP_LIST";
 }
 
 assert(!"Unknown LibreOfficeKitCallbackType type.");
diff --git a/include/svx/svxids.hrc b/include/svx/svxids.hrc
index d429b17f2af0..7d9d69e08dfe 100644
--- a/include/svx/svxids.hrc
+++ b/include/svx/svxids.hrc
@@ -529,6 +529,9 @@ class SfxStringItem;
 #define SID_ATTR_ALIGN_DEGREES  ( SID_SVX_START + 577 )
 #define SID_ATTR_ALIGN_LOCKPOS  ( SID_SVX_START + 578 )
 #define SID_ATTR_NUMBERFORMAT_ONE_AREA  ( SID_SVX_START + 580 )
+#define SID_TABSTOP_ADD_OR_CHANGE   ( SID_SVX_START + 581 )
+#define SID_TABSTOP_ATTR_INDEX  ( SID_SVX_START + 582 )
+#define SID_TABSTOP_ATTR_POSITION   ( SID_SVX_START + 583 )
 
 // CAUTION! Range <587 .. 587> used by EditEngine (!)
 
diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 87fe7689ce0e..6284d85ee9b1 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -1377,6 +1377,7 @@ callback (gpointer pData)
 case LOK_CALLBACK_TABLE_SELECTED:
 case LOK_CALLBACK_JSDIALOG:
 case LOK_CALLBACK_CALC_FUNCTION_LIST:
+case LOK_CALLBACK_TAB_STOP_LIST:
 {
 // TODO: Implement me
 break;
diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index 6f85de054c85..5261f616308b 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -7175,6 +7175,25 @@ SfxVoidItem RulerChangeState SID_RULER_CHANGE_STATE
 GroupId = ;
 ]
 
+SfxVoidItem ChangeTabStop SID_TABSTOP_ADD_OR_CHANGE
+(SfxInt32Item Index SID_TABSTOP_ATTR_INDEX,
+ SfxInt32Item Position SID_TABSTOP_ATTR_POSITION)
+[
+AutoUpdate = FALSE,
+FastCall = TRUE,
+ReadOnlyDoc = TRUE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+
+
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
+GroupId = ;
+]
+
 SfxVoidItem TableChangeCurrentBorderPosition 
SID_TABLE_CHANGE_CURRENT_BORDER_POSITION
 (SfxStringItem BorderType SID_TABLE_BORDER_TYPE,
  SfxUInt16Item Index SID_TABLE_BORDER_INDEX,
diff --git a/sw/sdi/_viewsh.sdi b/sw/sdi/_viewsh.sdi
index 824eb2f0e6e3..b4c3803e0a0d 100644
--- a/sw/sdi/_viewsh.sdi
+++ b/sw/sdi/_viewsh.sdi
@@ -631,6 +631,10 @@ interface BaseTextEditView
 StateMethod = StateTabWin ;
 DisableFlags="SfxDisableFlags::SwOnProtectedCursor";
 ]
+SID_TABSTOP_ADD_OR_CHANGE // status()
+[
+ExecMethod = ExecTabWin;
+]
 // from here  Export = FALSE;
 FID_SEARCH_ON // status()
 [
diff --git a/sw/source/uibase/uiview/viewtab.cxx 
b/sw/source/uibase/uiview/viewtab.cxx
index d9b61426b9e1..7b51c2331408 100644
--- a/sw/source/uibase/uiview/viewtab.cxx
+++ b/sw/source/uibase/uiview/viewtab.cxx
@@ -57,6 +57,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 

[Libreoffice-commits] core.git: include/LibreOfficeKit include/svx libreofficekit/source svx/sdi sw/sdi sw/source

[Tomaž Vajngerl (via logerrit)]

 include/LibreOfficeKit/LibreOfficeKitEnums.h |9 +++
 include/svx/svxids.hrc   |3 +
 libreofficekit/source/gtk/lokdocview.cxx |1 
 svx/sdi/svx.sdi  |   19 +++
 sw/sdi/_viewsh.sdi   |4 +
 sw/source/uibase/uiview/viewtab.cxx  |   72 ++-
 6 files changed, 105 insertions(+), 3 deletions(-)

New commits:
commit a60b18a8c5d5c11c87dbbaaf884de138dfeb6c8f
Author: Tomaž Vajngerl 
AuthorDate: Tue Apr 14 07:35:02 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 14 15:03:04 2020 +0200

lok: add tabstop changing and callback to send tabstop updates

This adds callback LOK_CALLBACK_TAB_STOP_LIST to send the tabstops
for the current paragraph.
In addition it adds .uno:ChangeTabStop action, with which it is
possible to change just one tabstop identified by the index.

Change-Id: I7762ead12e47288cbb0b0a1c8ffb8e9872cee8e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92147
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index 5ad801a7a74f..53bc3099e282 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -720,7 +720,12 @@ typedef enum
  * Send the list of functions whose name starts with the characters entered
  * by the user in the formula input bar.
  */
-LOK_CALLBACK_CALC_FUNCTION_LIST = 47
+LOK_CALLBACK_CALC_FUNCTION_LIST = 47,
+
+/**
+ * Sends the tab stop list for the current of the current cursor position.
+ */
+LOK_CALLBACK_TAB_STOP_LIST = 48,
 }
 LibreOfficeKitCallbackType;
 
@@ -845,6 +850,8 @@ static inline const char* lokCallbackTypeToString(int nType)
 return "LOK_CALLBACK_JSDIALOG";
 case LOK_CALLBACK_CALC_FUNCTION_LIST:
 return "LOK_CALLBACK_CALC_FUNCTION_LIST";
+case LOK_CALLBACK_TAB_STOP_LIST:
+return "LOK_CALLBACK_TAB_STOP_LIST";
 }
 
 assert(!"Unknown LibreOfficeKitCallbackType type.");
diff --git a/include/svx/svxids.hrc b/include/svx/svxids.hrc
index 32b0f5ba8350..1aa3111beeba 100644
--- a/include/svx/svxids.hrc
+++ b/include/svx/svxids.hrc
@@ -533,6 +533,9 @@ class SvxSetItem;
 #define SID_ATTR_ALIGN_DEGREES  ( SID_SVX_START + 577 )
 #define SID_ATTR_ALIGN_LOCKPOS  ( SID_SVX_START + 578 )
 #define SID_ATTR_NUMBERFORMAT_ONE_AREA  ( SID_SVX_START + 580 )
+#define SID_TABSTOP_ADD_OR_CHANGE   ( SID_SVX_START + 581 )
+#define SID_TABSTOP_ATTR_INDEX  ( SID_SVX_START + 582 )
+#define SID_TABSTOP_ATTR_POSITION   ( SID_SVX_START + 583 )
 
 // CAUTION! Range <587 .. 587> used by EditEngine (!)
 
diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 0d7ad9b9e7a6..c9235f41b2a4 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -1398,6 +1398,7 @@ callback (gpointer pData)
 case LOK_CALLBACK_TABLE_SELECTED:
 case LOK_CALLBACK_JSDIALOG:
 case LOK_CALLBACK_CALC_FUNCTION_LIST:
+case LOK_CALLBACK_TAB_STOP_LIST:
 {
 // TODO: Implement me
 break;
diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index 75d2993297ee..ad31871008af 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -7207,6 +7207,25 @@ SfxVoidItem RulerChangeState SID_RULER_CHANGE_STATE
 GroupId = ;
 ]
 
+SfxVoidItem ChangeTabStop SID_TABSTOP_ADD_OR_CHANGE
+(SfxInt32Item Index SID_TABSTOP_ATTR_INDEX,
+ SfxInt32Item Position SID_TABSTOP_ATTR_POSITION)
+[
+AutoUpdate = FALSE,
+FastCall = TRUE,
+ReadOnlyDoc = TRUE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+
+
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
+GroupId = ;
+]
+
 SfxVoidItem TableChangeCurrentBorderPosition 
SID_TABLE_CHANGE_CURRENT_BORDER_POSITION
 (SfxStringItem BorderType SID_TABLE_BORDER_TYPE,
  SfxUInt16Item Index SID_TABLE_BORDER_INDEX,
diff --git a/sw/sdi/_viewsh.sdi b/sw/sdi/_viewsh.sdi
index acef4c75f26a..47b95ab80409 100644
--- a/sw/sdi/_viewsh.sdi
+++ b/sw/sdi/_viewsh.sdi
@@ -643,6 +643,10 @@ interface BaseTextEditView
 StateMethod = StateTabWin ;
 DisableFlags="SfxDisableFlags::SwOnProtectedCursor";
 ]
+SID_TABSTOP_ADD_OR_CHANGE // status()
+[
+ExecMethod = ExecTabWin;
+]
 // from here  Export = FALSE;
 FID_SEARCH_ON // status()
 [
diff --git a/sw/source/uibase/uiview/viewtab.cxx 
b/sw/source/uibase/uiview/viewtab.cxx
index 844bbfce782b..6b7dee96379b 100644
--- a/sw/source/uibase/uiview/viewtab.cxx
+++ b/sw/source/uibase/uiview/viewtab.cxx
@@ -55,6 +55,9 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 
 #include 

[Libreoffice-bugs] [Bug 132048] CROSS-REFERENCE: Cutting a referenced title breaks the cross-reference to that title

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132048

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks|107733  |108905
Summary|Cutting a   |CROSS-REFERENCE:
   |referenced title breaks the |Cutting a
   |hyperlink to that title |referenced title breaks the
   ||cross-reference to that
   ||title

--- Comment #4 from Dieter  ---
Roberto, thanks for your testcase. Now it is clear, that yoour bug is about
cross-references and not about Hyperlinks (Insert => Hyperlink).

I can confirm the problem with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 962b415edb47187737a5f05c4ff3f6724a19c564
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

Steps to reproduce
1. Open an new document
2. Insert a heading
3. Insert cross-reference to that heading (Insert => Field => More Fields =>
Crosse-references => Type: headings)
3. Cut & Paste heading

Actual result: Cross-reference gets lost
Desired result: Cross-references reappears after pasting heading

I don't recieve the error message I can see in your second document, Roberto.
If you used different steps, it would be nice, if you can add them.

I'm not a developer, but I cam imagine, that it is not trivial to fix it. But
since it seems to be possible for hyperlinks, it should be feasible.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
[Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108905
[Bug 108905] UI: Imported Page Area Bitmap background resets to default after
having applied Transparency or other page property
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132014] Set a shape as default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132014

--- Comment #6 from Tomaz Vajngerl  ---
The blue color is just the default for a new document. If you want you can
create a template and set it as the one that should be used for new documents
(default template). With that you can even override what the style for the
shape are when you create a new document.

As for the shape styles in context menu, I think it should be possible - in the
same way as with character styles and paragraph styles, but I'm not sure
exactly. Sometimes all LO modules work the same, then other time writer is
special :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107733

Dieter  changed:

   What|Removed |Added

 Depends on|132048  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=132048
[Bug 132048] CROSS-REFERENCE: Cutting a referenced title breaks the
cross-reference to that title
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132014] Set a shape as default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132014

--- Comment #6 from Tomaz Vajngerl  ---
The blue color is just the default for a new document. If you want you can
create a template and set it as the one that should be used for new documents
(default template). With that you can even override what the style for the
shape are when you create a new document.

As for the shape styles in context menu, I think it should be possible - in the
same way as with character styles and paragraph styles, but I'm not sure
exactly. Sometimes all LO modules work the same, then other time writer is
special :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 108905] UI: Imported Page Area Bitmap background resets to default after having applied Transparency or other page property

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108905

Dieter  changed:

   What|Removed |Added

 Depends on||132048


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=132048
[Bug 132048] CROSS-REFERENCE: Cutting a referenced title breaks the
cross-reference to that title
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132056] FORMATTING: Change cursor to indicate whole line is selectable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132056

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote  ---
agree => WF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132056] FORMATTING: Change cursor to indicate whole line is selectable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132056

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote  ---
agree => WF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

--- Comment #1 from Heiko Tietze  ---
Not specific to Skia and asked from time to time:
https://ask.libreoffice.org/en/question/385/libreoffice-logs/
https://ask.libreoffice.org/en/question/38643/where-does-libre-office-write-log-path-in-linux/

But I'd still prefer a wiki page that explains where to look for the log files
than adding an interaction.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 132096] ENHANCEMENT: Some easy way to access skia.log/opengl.log

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132096

--- Comment #1 from Heiko Tietze  ---
Not specific to Skia and asked from time to time:
https://ask.libreoffice.org/en/question/385/libreoffice-logs/
https://ask.libreoffice.org/en/question/38643/where-does-libre-office-write-log-path-in-linux/

But I'd still prefer a wiki page that explains where to look for the log files
than adding an interaction.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkframe.cxx |   16 ++--
 vcl/unx/gtk3/gtk3gtkinst.cxx  |4 ++--
 2 files changed, 12 insertions(+), 8 deletions(-)

New commits:
commit fb3a41b328f5e221e96e7f90e28f84988188cbe2
Author: Caolán McNamara 
AuthorDate: Tue Apr 14 09:59:02 2020 +0100
Commit: Caolán McNamara 
CommitDate: Tue Apr 14 14:51:00 2020 +0200

use gdk_window_move_to_rect if available at runtime

vs at buildtime

Change-Id: I22fdf5f98058bf5212248f33cf879e1420748ba3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92152
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 9b221311a8b3..18db569607ee 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -45,6 +45,8 @@
 
 #include 
 
+#include 
+
 #include 
 
 #if OSL_DEBUG_LEVEL > 1
@@ -2908,7 +2910,6 @@ void GtkSalFrame::sizeAllocated(GtkWidget* pWidget, 
GdkRectangle *pAllocation, g
 pThis->TriggerPaintEvent();
 }
 
-#if GTK_CHECK_VERSION(3,23,0)
 namespace {
 
 void swapDirection(GdkGravity& gravity)
@@ -2924,7 +2925,6 @@ void swapDirection(GdkGravity& gravity)
 }
 
 }
-#endif
 
 void GtkSalFrame::signalRealize(GtkWidget*, gpointer frame)
 {
@@ -2934,8 +2934,13 @@ void GtkSalFrame::signalRealize(GtkWidget*, gpointer 
frame)
 return;
 pThis->TriggerPaintEvent();
 
-#if GTK_CHECK_VERSION(3,23,0)
-if (gtk_check_version(3, 23, 0) == nullptr && pThis->m_bFloatPositioned)
+if (!pThis->m_bFloatPositioned)
+return;
+
+static auto window_move_to_rect = reinterpret_cast(
+
dlsym(nullptr, "gdk_window_move_to_rect"));
+if (window_move_to_rect)
 {
 GdkGravity rect_anchor = GDK_GRAVITY_SOUTH_WEST, menu_anchor = 
GDK_GRAVITY_NORTH_WEST;
 
@@ -2969,9 +2974,8 @@ void GtkSalFrame::signalRealize(GtkWidget*, gpointer 
frame)
static_cast(aFloatRect.GetWidth()), 
static_cast(aFloatRect.GetHeight())};
 
 GdkWindow* gdkWindow = gtk_widget_get_window(pThis->m_pWindow);
-gdk_window_move_to_rect(gdkWindow, , rect_anchor, menu_anchor, 
GDK_ANCHOR_FLIP, 0, 0);
+window_move_to_rect(gdkWindow, , rect_anchor, menu_anchor, 
GDK_ANCHOR_FLIP, 0, 0);
 }
-#endif
 }
 
 gboolean GtkSalFrame::signalConfigure(GtkWidget*, GdkEventConfigure* pEvent, 
gpointer frame)
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 8700a948e28f..809a67c9373d 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1623,7 +1623,7 @@ OpenGLContext* GtkInstance::CreateOpenGLContext()
 // tdf#123800 avoid requiring wayland at runtime just because it existed at 
buildtime
 bool DLSYM_GDK_IS_WAYLAND_DISPLAY(GdkDisplay* pDisplay)
 {
-auto get_type = reinterpret_cast(dlsym(nullptr, 
"gdk_wayland_display_get_type"));
+static auto get_type = reinterpret_cast(dlsym(nullptr, 
"gdk_wayland_display_get_type"));
 if (!get_type)
 return false;
 return G_TYPE_CHECK_INSTANCE_TYPE(pDisplay, get_type());
@@ -1631,7 +1631,7 @@ bool DLSYM_GDK_IS_WAYLAND_DISPLAY(GdkDisplay* pDisplay)
 
 bool DLSYM_GDK_IS_X11_DISPLAY(GdkDisplay* pDisplay)
 {
-auto get_type = reinterpret_cast(dlsym(nullptr, 
"gdk_x11_display_get_type"));
+static auto get_type = reinterpret_cast(dlsym(nullptr, 
"gdk_x11_display_get_type"));
 if (!get_type)
 return false;
 return G_TYPE_CHECK_INSTANCE_TYPE(pDisplay, get_type());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: RFC removing the XPrimitive2D (and related) UNO classes

[Tomaž Vajngerl]

Hi,

On Tue, Apr 14, 2020 at 1:38 PM Thorsten Behrens 
wrote:

> Noel Grandin wrote:
> > It seems to me that in quite a few places we are using UNO as a
> > means of papering over circular dependencies.
> >
> Would call that papering over - ain't that quite standard-issue
> dependency-inversion?
>

I'd call it a flaw in the dependency hierarchy, which means something is
located at a wrong place. I know that this can be a "standard-issue" but
mostly because a lot of times fixing the hierarchy is a lot of work and
moving things around, but this doesn't mean breaking a circular dependency
in such a way should be taken lightly or is a good thing.

As for UNO - to me UNO API is for making the functionality available to
extensions, macros, tests. If we use UNO just to circumvent a circular
dependency, how is that anything but a misuse of UNO API? If we extend the
UNO API from the point were it is not required for extension development,
it is prone to be used for things that were never meant to be used
externally and also YAGNI.


> Cheers,
>
> -- Thorsten
>

Best regards, Tomaž
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 87720] Default insert image anchor, wrapping, and spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87720

--- Comment #43 from Heiko Tietze  ---
Summarizing, we have in v7 (actually since 6.4)

new defaults:
* Anchor: To Character (drawback: no means to drag, see bug 87719)

remaining defaults:
* Position: Horizontal=Center, Vertical=Top (relevant at bug 87742)
* Wrap: Optimal
* Spacing: 0 (bug 102011)
* Borders: 0

Still in discussion is:
* comment 33: Choose default per tools > options 
  + rather keep the last selection, see bug 109265 and comment 35

So we can resolve as fixed and open another ticket with the RFE to store last
used option (could be done at bug 99646). Or just keep this ticket until it's
done (and make 99646 a duplicate). Or reject this RFE.

Related tickets:
* bug 82873: Default behavior of inserting an image in a list
  + resolve as WFM or introduce special styles)
* bug 45778:  [RFE] Insert image not in a new paragraph but in the current
position or as character
  + make as duplicate to this ticket
* bug 87742: When image anchor is set to 'As Character' it should set vertical
align to top
  + same as bug 82873, WFM or styles

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 87720] Default insert image anchor, wrapping, and spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87720

--- Comment #43 from Heiko Tietze  ---
Summarizing, we have in v7 (actually since 6.4)

new defaults:
* Anchor: To Character (drawback: no means to drag, see bug 87719)

remaining defaults:
* Position: Horizontal=Center, Vertical=Top (relevant at bug 87742)
* Wrap: Optimal
* Spacing: 0 (bug 102011)
* Borders: 0

Still in discussion is:
* comment 33: Choose default per tools > options 
  + rather keep the last selection, see bug 109265 and comment 35

So we can resolve as fixed and open another ticket with the RFE to store last
used option (could be done at bug 99646). Or just keep this ticket until it's
done (and make 99646 a duplicate). Or reject this RFE.

Related tickets:
* bug 82873: Default behavior of inserting an image in a list
  + resolve as WFM or introduce special styles)
* bug 45778:  [RFE] Insert image not in a new paragraph but in the current
position or as character
  + make as duplicate to this ticket
* bug 87742: When image anchor is set to 'As Character' it should set vertical
align to top
  + same as bug 82873, WFM or styles

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34804

Dieter  changed:

   What|Removed |Added

URL|https://mywifiext-net.suppo |
   |rt/netgear-extender-setup/  |
   Keywords|accessibility   |dataLoss

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132059] Words lose border with shadow style when re-opening document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132059

--- Comment #7 from eddy...@gmail.com ---
Sounds good, I'll reopen it again if I encounter this behavior in documents
that were made with newer versions of LibreOffice.
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132097] Find Previous with direction columns crashes in specific condition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132097

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #3 from Julien Nabet  ---
Let's give a try with:
https://gerrit.libreoffice.org/c/core/+/92165

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: fpicker/source

[Noel Grandin (via logerrit)]

 fpicker/source/office/OfficeControlAccess.cxx |   84 +++---
 fpicker/source/office/RemoteFilesDialog.cxx   |  144 
 fpicker/source/office/iodlg.cxx   |  151 +-
 3 files changed, 190 insertions(+), 189 deletions(-)

New commits:
commit 89b2fd604420d53b6d6ccc6e7656c3bcf282703d
Author: Noel Grandin 
AuthorDate: Tue Apr 14 12:05:09 2020 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 14 14:25:24 2020 +0200

loplugin:flatten in fpicker

Change-Id: Icfad1871686c894379b0e703194307a5bd72b2f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92160
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/fpicker/source/office/OfficeControlAccess.cxx 
b/fpicker/source/office/OfficeControlAccess.cxx
index 296e9368779a..e8f4e3929d79 100644
--- a/fpicker/source/office/OfficeControlAccess.cxx
+++ b/fpicker/source/office/OfficeControlAccess.cxx
@@ -340,52 +340,52 @@ namespace svt
 {
 weld::Widget* pControl = m_pFilePickerController->getControl( 
nControlId );
 DBG_ASSERT( pControl, "OControlAccess::SetValue: don't have this 
control in the current mode!" );
-if ( pControl )
+if ( !pControl )
+return;
+
+PropFlags nPropertyId = PropFlags::Unknown;
+if ( ControlActions::SET_HELP_URL == nControlAction )
 {
-PropFlags nPropertyId = PropFlags::Unknown;
-if ( ControlActions::SET_HELP_URL == nControlAction )
-{
-nPropertyId = PropFlags::HelpUrl;
-}
-else
+nPropertyId = PropFlags::HelpUrl;
+}
+else
+{
+switch ( nControlId )
 {
-switch ( nControlId )
-{
-case CHECKBOX_AUTOEXTENSION:
-case CHECKBOX_PASSWORD:
-case CHECKBOX_FILTEROPTIONS:
-case CHECKBOX_READONLY:
-case CHECKBOX_LINK:
-case CHECKBOX_PREVIEW:
-case CHECKBOX_SELECTION:
-nPropertyId = PropFlags::Checked;
-break;
-
-case LISTBOX_FILTER:
-SAL_WARN( "fpicker.office", "Use the XFilterManager to 
access the filter listbox" );
-break;
-
-case LISTBOX_VERSION:
-case LISTBOX_TEMPLATE:
-case LISTBOX_IMAGE_TEMPLATE:
-case LISTBOX_IMAGE_ANCHOR:
-if ( ControlActions::SET_SELECT_ITEM == nControlAction 
)
-{
-nPropertyId = PropFlags::SelectedItemIndex;
-}
-else
-{
-weld::ComboBox* pComboBox = 
dynamic_cast(pControl);
-assert(pComboBox && "OControlAccess::SetValue: 
implGetControl returned nonsense!");
-implDoListboxAction(pComboBox, nControlAction, 
rValue);
-}
-break;
-}
+case CHECKBOX_AUTOEXTENSION:
+case CHECKBOX_PASSWORD:
+case CHECKBOX_FILTEROPTIONS:
+case CHECKBOX_READONLY:
+case CHECKBOX_LINK:
+case CHECKBOX_PREVIEW:
+case CHECKBOX_SELECTION:
+nPropertyId = PropFlags::Checked;
+break;
+
+case LISTBOX_FILTER:
+SAL_WARN( "fpicker.office", "Use the XFilterManager to 
access the filter listbox" );
+break;
+
+case LISTBOX_VERSION:
+case LISTBOX_TEMPLATE:
+case LISTBOX_IMAGE_TEMPLATE:
+case LISTBOX_IMAGE_ANCHOR:
+if ( ControlActions::SET_SELECT_ITEM == nControlAction )
+{
+nPropertyId = PropFlags::SelectedItemIndex;
+}
+else
+{
+weld::ComboBox* pComboBox = 
dynamic_cast(pControl);
+assert(pComboBox && "OControlAccess::SetValue: 
implGetControl returned nonsense!");
+implDoListboxAction(pComboBox, nControlAction, rValue);
+}
+break;
 }
-
-if ( PropFlags::Unknown != nPropertyId )
-implSetControlProperty( nControlId, pControl, nPropertyId, 
rValue );
 }
+
+if ( PropFlags::Unknown != nPropertyId )
+implSetControlProperty( nControlId, pControl, nPropertyId, rValue 
);
 }
 
 Any OControlAccess::getValue( sal_Int16 nControlId, sal_Int16 
nControlAction ) const
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx 

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34804

Chris Woris  changed:

   What|Removed |Added

URL||https://mywifiext-net.suppo
   ||rt/netgear-extender-setup/
   Keywords|dataLoss|accessibility

--- Comment #45 from Chris Woris  ---
Facing issue with your WiFi extender setup via mywifiext.net? We are one of the
best New extender setup support service providers who provides various kinds of
Netgear_ext setup services. If you face any kind of issue related to your
Netgear Extender setup then you can contact our professional technicians at 1
866-606-3055. They can resolve your all issues in a minimum amount of time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34804

--- Comment #46 from Chris Woris  ---
Facing issue with your WiFi extender setup via mywifiext.net? We are one of the
best New extender setup support service providers who provides various kinds of
Netgear_ext setup services. If you face any kind of issue related to your
Netgear Extender setup then you can contact our professional technicians at 1
866-606-3055. They can resolve your all issues in a minimum amount of time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132097] Find Previous with direction columns crashes in specific condition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132097

Julien Nabet  changed:

   What|Removed |Added

Summary|Find Previous crashes.  |Find Previous with
   |EDITING.|direction columns crashes
   ||in specific condition

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128689] Request to Localize More Formatting Icons into Korean UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128689

--- Comment #12 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5431e8e25c6668480ebac11248f2aecbc0bda431

Sifr: Add Korean UI tdf#128689

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_dark_svg icon-themes/sifr_svg

[Rizal Muttaqin (via logerrit)]

 icon-themes/sifr/cmd/32/ko/bold.png  |binary
 icon-themes/sifr/cmd/32/ko/charfontname.png  |binary
 icon-themes/sifr/cmd/32/ko/color.png |binary
 icon-themes/sifr/cmd/32/ko/fontdialog.png|binary
 icon-themes/sifr/cmd/32/ko/insertfixedtext.png   |binary
 icon-themes/sifr/cmd/32/ko/italic.png|binary
 icon-themes/sifr/cmd/32/ko/outlinefont.png   |binary
 icon-themes/sifr/cmd/32/ko/overline.png  |binary
 icon-themes/sifr/cmd/32/ko/scaletext.png |binary
 icon-themes/sifr/cmd/32/ko/shadowed.png  |binary
 icon-themes/sifr/cmd/32/ko/strikeout.png |binary
 icon-themes/sifr/cmd/32/ko/textdirectionlefttoright.png  |binary
 icon-themes/sifr/cmd/32/ko/textdirectiontoptobottom.png  |binary
 icon-themes/sifr/cmd/32/ko/underline.png |binary
 icon-themes/sifr/cmd/32/ko/underlinedouble.png   |binary
 icon-themes/sifr/cmd/ko/lc_bold.png  |binary
 icon-themes/sifr/cmd/ko/lc_charfontname.png  |binary
 icon-themes/sifr/cmd/ko/lc_color.png |binary
 icon-themes/sifr/cmd/ko/lc_fontdialog.png|binary
 icon-themes/sifr/cmd/ko/lc_insertfixedtext.png   |binary
 icon-themes/sifr/cmd/ko/lc_italic.png|binary
 icon-themes/sifr/cmd/ko/lc_outlinefont.png   |binary
 icon-themes/sifr/cmd/ko/lc_overline.png  |binary
 icon-themes/sifr/cmd/ko/lc_scaletext.png |binary
 icon-themes/sifr/cmd/ko/lc_shadowed.png  |binary
 icon-themes/sifr/cmd/ko/lc_strikeout.png |binary
 icon-themes/sifr/cmd/ko/lc_textdirectionlefttoright.png  |binary
 icon-themes/sifr/cmd/ko/lc_textdirectiontoptobottom.png  |binary
 icon-themes/sifr/cmd/ko/lc_underline.png |binary
 icon-themes/sifr/cmd/ko/lc_underlinedouble.png   |binary
 icon-themes/sifr/cmd/ko/sc_bold.png  |binary
 icon-themes/sifr/cmd/ko/sc_charfontname.png  |binary
 icon-themes/sifr/cmd/ko/sc_color.png |binary
 icon-themes/sifr/cmd/ko/sc_fontdialog.png|binary
 icon-themes/sifr/cmd/ko/sc_insertfixedtext.png   |binary
 icon-themes/sifr/cmd/ko/sc_italic.png|binary
 icon-themes/sifr/cmd/ko/sc_outlinefont.png   |binary
 icon-themes/sifr/cmd/ko/sc_overline.png  |binary
 icon-themes/sifr/cmd/ko/sc_scaletext.png |binary
 icon-themes/sifr/cmd/ko/sc_shadowed.png  |binary
 icon-themes/sifr/cmd/ko/sc_strikeout.png |binary
 icon-themes/sifr/cmd/ko/sc_textdirectionlefttoright.png  |binary
 icon-themes/sifr/cmd/ko/sc_textdirectiontoptobottom.png  |binary
 icon-themes/sifr/cmd/ko/sc_underline.png |binary
 icon-themes/sifr/cmd/ko/sc_underlinedouble.png   |binary
 icon-themes/sifr_dark/cmd/32/ko/bold.png |binary
 icon-themes/sifr_dark/cmd/32/ko/charfontname.png |binary
 icon-themes/sifr_dark/cmd/32/ko/color.png|binary
 icon-themes/sifr_dark/cmd/32/ko/fontdialog.png   |binary
 icon-themes/sifr_dark/cmd/32/ko/insertfixedtext.png  |binary
 icon-themes/sifr_dark/cmd/32/ko/italic.png   |binary
 icon-themes/sifr_dark/cmd/32/ko/outlinefont.png  |binary
 icon-themes/sifr_dark/cmd/32/ko/overline.png |binary
 icon-themes/sifr_dark/cmd/32/ko/scaletext.png|binary
 icon-themes/sifr_dark/cmd/32/ko/shadowed.png |binary
 icon-themes/sifr_dark/cmd/32/ko/strikeout.png|binary
 icon-themes/sifr_dark/cmd/32/ko/textdirectionlefttoright.png |binary
 icon-themes/sifr_dark/cmd/32/ko/textdirectiontoptobottom.png |binary
 icon-themes/sifr_dark/cmd/32/ko/underline.png|binary
 icon-themes/sifr_dark/cmd/32/ko/underlinedouble.png  |binary
 icon-themes/sifr_dark/cmd/ko/lc_bold.png |binary
 icon-themes/sifr_dark/cmd/ko/lc_charfontname.png |binary
 icon-themes/sifr_dark/cmd/ko/lc_color.png|binary
 icon-themes/sifr_dark/cmd/ko/lc_fontdialog.png   |binary
 icon-themes/sifr_dark/cmd/ko/lc_insertfixedtext.png  |binary
 icon-themes/sifr_dark/cmd/ko/lc_italic.png   |binary
 icon-themes/sifr_dark/cmd/ko/lc_outlinefont.png  |binary
 

[Libreoffice-ux-advise] [Bug 132014] Set a shape as default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132014

--- Comment #5 from andreas_k  ---
oh I didn't know that the shapes are styles. That's very interested and cool.
Thanks for the feedback. That's really great news for me. So I can make/use
Status styles like in calc.

So would it be possible to have styles available with the right click
behaviour, like we have them in writer.

I really didn't realize that Standard is the style of the (standard) shape. I
thought you can use styles if you want, but by default it's always blue/blue
area and line color.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 108160] [META] Tango icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108160

--- Comment #2 from Rizal Muttaqin  ---
(In reply to Adolfo Jayme from comment #1)
> Tango is removed from 7.0. → WONTFIX

I have not hear the decision made from ESC. Could you explain?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132014] Set a shape as default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132014

--- Comment #5 from andreas_k  ---
oh I didn't know that the shapes are styles. That's very interested and cool.
Thanks for the feedback. That's really great news for me. So I can make/use
Status styles like in calc.

So would it be possible to have styles available with the right click
behaviour, like we have them in writer.

I really didn't realize that Standard is the style of the (standard) shape. I
thought you can use styles if you want, but by default it's always blue/blue
area and line color.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 132014] Set a shape as default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132014

--- Comment #4 from Tomaz Vajngerl  ---
Well we have the style sidebar for that things, where you apply current shape
style to the selected "Default" style. I don't see a need for this in "context
menu" - for example we also don't have something like this for updating the
default paragraph style in Writer either. 

This is just my opinion and I'm not necessarily against it either.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 132014] Set a shape as default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132014

--- Comment #4 from Tomaz Vajngerl  ---
Well we have the style sidebar for that things, where you apply current shape
style to the selected "Default" style. I don't see a need for this in "context
menu" - for example we also don't have something like this for updating the
default paragraph style in Writer either. 

This is just my opinion and I'm not necessarily against it either.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127755] Tango icon theme needs different icons for module and library

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127755

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #10 from Adolfo Jayme  ---
Tango is removed from 7.0. → WONTFIX

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 108160] [META] Tango icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108160
Bug 108160 depends on bug 127755, which changed state.

Bug 127755 Summary: Tango icon theme needs different icons for module and 
library
https://bugs.documentfoundation.org/show_bug.cgi?id=127755

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132048] Cutting a referenced title breaks the hyperlink to that title

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132048

Roberto Cantù  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108160] [META] Tango icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108160

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Adolfo Jayme  ---
Tango is removed from 7.0. → WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127755] Tango icon theme needs different icons for module and library

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127755

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #10 from Adolfo Jayme  ---
Tango is removed from 7.0. → WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106228] [META] Icon theme issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106228
Bug 106228 depends on bug 108160, which changed state.

Bug 108160 Summary: [META] Tango icons
https://bugs.documentfoundation.org/show_bug.cgi?id=108160

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122247] [META] Icon requests

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122247
Bug 122247 depends on bug 127755, which changed state.

Bug 127755 Summary: Tango icon theme needs different icons for module and 
library
https://bugs.documentfoundation.org/show_bug.cgi?id=127755

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132048] Cutting a referenced title breaks the hyperlink to that title

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132048

--- Comment #3 from Roberto Cantù  ---
Created attachment 159555
  --> https://bugs.documentfoundation.org/attachment.cgi?id=159555=edit
Test Case - After the cut

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132048] Cutting a referenced title breaks the hyperlink to that title

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132048

--- Comment #2 from Roberto Cantù  ---
Created attachment 159554
  --> https://bugs.documentfoundation.org/attachment.cgi?id=159554=edit
Test Case - Before the cut

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95095] Do not generate thumbnail on load of a document if not necessary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95095

Serge Krot (CIB)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1437

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132063] No CLOSE button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132063

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Aron Budea  ---
Indeed, I could reproduce this with the docker image, though not with a local
build. Thanks for reporting!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132034] documentation page with community documentation links

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132034

--- Comment #2 from Mike Saunders  ---
Documentation is really Olivier's area, so I'd see what he thinks. But yes, we
could certainly expand https://documentation.libreoffice.org to add YouTube
tutorials and other resources...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: RFC removing the XPrimitive2D (and related) UNO classes

[Thorsten Behrens]

Hi Noel,

Noel Grandin wrote:
> That is kind of my point - here we have gratutious use of UNO, with
> no real means of an extension using it, which is just making it
> harder to optimise an important of our system.
>
The main point I'm disputing is the 'making it harder to
optimise'. From the patch, nothing prevents you from granting direct,
c++-level access to internal data, _and_ keeping UNO in place.

So without arguing the merits of whether UNO is useful for
drawinglayer/svg, you're mixing two unrelated changes into one patch.

> (1) Unnecessary copying because of UNO shows up heavily in various places.
> Mostly because we can't pass large complex data directly.
>
Problem of API design. We have examples of complex data structures
wrapped in UNO interfaces (and direct, c++-level access to
implementation if necessary for speed).

> (2) Lots of UNO classes need to have their own Mutex object because
> they can get called from multiple threads, so it is not just
> SolarMutex.
>
For graphics stuff, that's a non sequitur - we can just grab
SolarMutex on the outer layer.

> (3) Even where UNO is not itself a perf problem, it introduces
> indirection because it is much harder to figure out what code is
> being called and who is calling it
>
That's mostly true for the heavily property-based interfaces for our
document APIs, that then largely affect filter code.

> (4) Touching UNO is an expensive exercise, involving attempted
> analysis of external usage, awkardness introducing modifications
> to API, etc, etc (and this coming from someone who __likes__
> UNO)
>
Yep, that's true.

Cheers,

-- Thorsten

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: common/Util.cpp

[Miklos Vajna (via logerrit)]

 common/Util.cpp |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 61790f6bb55c87b01814a6d4d5dd9247c048145c
Author: Miklos Vajna 
AuthorDate: Tue Apr 14 09:54:04 2020 +0200
Commit: Miklos Vajna 
CommitDate: Tue Apr 14 13:41:55 2020 +0200

common: it's enough to look up PRETTY_NAME once

Also add the missing newlines before the opening braces, the surrounding
code has that style.

Change-Id: I23bd26ba6d2446858ae3213212e2813a38fd1d46
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92146
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/common/Util.cpp b/common/Util.cpp
index 703bfdd4b..7b71da598 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -963,10 +963,13 @@ namespace Util
 std::vector infoList = Util::splitStringToVector(str, 
'\n');
 std::map releaseInfo = 
Util::stringVectorToMap(infoList, '=');
 
-if (releaseInfo.find("PRETTY_NAME") != releaseInfo.end()) {
-return releaseInfo["PRETTY_NAME"];
+auto it = releaseInfo.find("PRETTY_NAME");
+if (it != releaseInfo.end())
+{
+return it->second;
 }
-else{
+else
+{
 return "unknown";
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 132083] FORMATTING - Wrong date substraction in cell's operation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132083

--- Comment #9 from Mike Kaganski  ---
(In reply to jarko from comment #8)
> But in example, we have 2 well defined points, strict up to second. Time
> lapse is 10 minutes. No more, no less. No need to truncate or round fraction
> of time. Exactly, physically 10 minutes. So one may expect the "conversion"
> between time span to time spot will run - I would say - seamlessly. In the
> matter of obtaining same results.

We have two points in time:

2020-04-13 12:18:00 in LibreOffice is "43934 days since day zero + 12/24 (12 h)
+ 18/1440 (18 min)" = 43934.5125 (exactly; this is also exactly representable
in binary double).

2020-04-13 12:08:00 in LibreOffice is "43934 days since day zero + 12/24 (12 h)
+ 8/1440 (8 min)" = 43934.50... - periodic decimal, not
representable exactly in binary (closest binary representation is
43934.50591126903891563, which is slightly *larger* than exact value
you intended).

Now LibreOffice subtracts these *binary* values (which are approximations of
original values; the first approximation happened by accident to be exact,
while the second is more usual case, with a small error).

The result of subtraction a slightly larger value from exact value is slightly
lesser value, right? That is the case here. The result is not exact 00:10:00
(which is 0.00694... periodic decimal, not representable exactly in
binary double), but 00:09:59.99... (0.0069443287037... in decimal).
Note that this was *always* the case, even before the commit mentioned in
comment 2! What has changed after that commit was only the display of that
value when using *wall clock* formatting. 09 min 59.... s is no more
rounded up toward 10 min, but truncated to 09 min *on display*.

I had already mentioned that this is the result of inherent floating-point
arithmetics operations, which is covered in FAQ (see comment 1). You just need
to realize that times are *always* fractional numbers (represented in binary
floating points as per IEEE 754), no matter if you think that you enter some
"whole numbers" of hours or minutes; and any operations with times are subject
to universal floating-point handling rules and gotchas.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: RFC removing the XPrimitive2D (and related) UNO classes

[Thorsten Behrens]

Noel Grandin wrote:
> It seems to me that in quite a few places we are using UNO as a
> means of papering over circular dependencies.
>
Would call that papering over - ain't that quite standard-issue
dependency-inversion?

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: formula/source

[Noel Grandin (via logerrit)]

 formula/source/core/api/FormulaCompiler.cxx |  102 +++---
 formula/source/ui/dlg/formula.cxx   |  450 ++--
 formula/source/ui/dlg/parawin.cxx   |  114 +++
 formula/source/ui/dlg/structpg.cxx  |   24 -
 4 files changed, 345 insertions(+), 345 deletions(-)

New commits:
commit bf207a0ed79c4b606ad1a6e2d5ca0fb00a6feeb8
Author: Noel Grandin 
AuthorDate: Tue Apr 14 12:08:06 2020 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 14 13:37:01 2020 +0200

loplugin:flatten in formula

Change-Id: I90054df6949cf966b9edc706b2e29c2a57553be9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92161
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/formula/source/core/api/FormulaCompiler.cxx 
b/formula/source/core/api/FormulaCompiler.cxx
index fedd6b36fcf4..e8c92c990509 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -932,19 +932,19 @@ void FormulaCompiler::InitSymbolsOOXML() const
 void FormulaCompiler::loadSymbols(const std::pair* pSymbols, 
FormulaGrammar::Grammar eGrammar,
 NonConstOpCodeMapPtr& rxMap, SeparatorType eSepType) const
 {
-if ( !rxMap.get() )
-{
-// not Core
-rxMap = std::make_shared( SC_OPCODE_LAST_OPCODE_ID + 1, 
eGrammar != FormulaGrammar::GRAM_ODFF, eGrammar );
-OpCodeList aOpCodeList(false, pSymbols, rxMap, eSepType);
+if ( rxMap.get() )
+return;
 
-fillFromAddInMap( rxMap, eGrammar);
-// Fill from collection for AddIns not already present.
-if ( FormulaGrammar::GRAM_ENGLISH != eGrammar )
-fillFromAddInCollectionUpperName( rxMap);
-else
-fillFromAddInCollectionEnglishName( rxMap);
-}
+// not Core
+rxMap = std::make_shared( SC_OPCODE_LAST_OPCODE_ID + 1, 
eGrammar != FormulaGrammar::GRAM_ODFF, eGrammar );
+OpCodeList aOpCodeList(false, pSymbols, rxMap, eSepType);
+
+fillFromAddInMap( rxMap, eGrammar);
+// Fill from collection for AddIns not already present.
+if ( FormulaGrammar::GRAM_ENGLISH != eGrammar )
+fillFromAddInCollectionUpperName( rxMap);
+else
+fillFromAddInCollectionEnglishName( rxMap);
 }
 
 void FormulaCompiler::fillFromAddInCollectionUpperName( const 
NonConstOpCodeMapPtr& /*xMap */) const
@@ -2142,26 +2142,26 @@ bool FormulaCompiler::CompileTokenArray()
 
 void FormulaCompiler::PopTokenArray()
 {
-if( pStack )
-{
-FormulaArrayStack* p = pStack;
-pStack = p->pNext;
-// obtain special RecalcMode from SharedFormula
-if ( pArr->IsRecalcModeAlways() )
-p->pArr->SetExclusiveRecalcModeAlways();
-else if ( !pArr->IsRecalcModeNormal() && p->pArr->IsRecalcModeNormal() 
)
-p->pArr->SetMaskedRecalcMode( pArr->GetRecalcMode() );
-p->pArr->SetCombinedBitsRecalcMode( pArr->GetRecalcMode() );
-if ( pArr->IsHyperLink() )  // fdo 87534
-p->pArr->SetHyperLink( true );
-if( p->bTemp )
-delete pArr;
-pArr = p->pArr;
-maArrIterator = FormulaTokenArrayPlainIterator(*pArr);
-maArrIterator.Jump(p->nIndex);
-mpLastToken = p->mpLastToken;
-delete p;
-}
+if( !pStack )
+return;
+
+FormulaArrayStack* p = pStack;
+pStack = p->pNext;
+// obtain special RecalcMode from SharedFormula
+if ( pArr->IsRecalcModeAlways() )
+p->pArr->SetExclusiveRecalcModeAlways();
+else if ( !pArr->IsRecalcModeNormal() && p->pArr->IsRecalcModeNormal() )
+p->pArr->SetMaskedRecalcMode( pArr->GetRecalcMode() );
+p->pArr->SetCombinedBitsRecalcMode( pArr->GetRecalcMode() );
+if ( pArr->IsHyperLink() )  // fdo 87534
+p->pArr->SetHyperLink( true );
+if( p->bTemp )
+delete pArr;
+pArr = p->pArr;
+maArrIterator = FormulaTokenArrayPlainIterator(*pArr);
+maArrIterator.Jump(p->nIndex);
+mpLastToken = p->mpLastToken;
+delete p;
 }
 
 void FormulaCompiler::CreateStringFromTokenArray( OUString& rFormula )
@@ -2738,28 +2738,28 @@ void FormulaCompiler::ForceArrayOperator( 
FormulaTokenRef const & rCurr )
 return;
 }
 
-if (nCurrentFactorParam > 0)
+if (nCurrentFactorParam <= 0)
+return;
+
+// Actual current parameter's class.
+const formula::ParamClass eType = GetForceArrayParameter(
+pCurrentFactorToken.get(), 
static_cast(nCurrentFactorParam - 1));
+if (eType == ParamClass::ForceArray)
+rCurr->SetInForceArray( eType);
+else if (eType == ParamClass::ReferenceOrForceArray)
 {
-// Actual current parameter's class.
-const formula::ParamClass eType = GetForceArrayParameter(
-pCurrentFactorToken.get(), 
static_cast(nCurrentFactorParam - 1));
-if (eType == ParamClass::ForceArray)
+if (GetForceArrayParameter( rCurr.get(), SAL_MAX_UINT16) != 
ParamClass::Reference)
 

[Libreoffice-bugs] [Bug 132097] Find Previous crashes. EDITING.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132097

--- Comment #2 from Julien Nabet  ---
Created attachment 159553
  --> https://bugs.documentfoundation.org/attachment.cgi?id=159553=edit
bt with debug symbols

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 132097] Find Previous crashes. EDITING.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132097

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace
   Severity|normal  |major
   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs