2012/8/12 Philipp Riemer ruderphil...@gmail.com:
Hey Oliver,
2012/8/12 Oliver Günther m...@oliverguenther.de:
Hi,
I finished translation all german comments in the core/tools folder.
Please find the patch attached.
Sorry for messing up with the whitespace, I was simply missing the
approriate Vim highlights and git warnings.
I hope the new patch is more conformant.
Cheers,
Oliver
I tried applying your patch. While this worked like a charm, I
realized some stuff (also citing mmeeks here):
Some of the original German comments are sometimes a bit cute / un-necessary:
// class FooBaa //
class FooBaa {
...
};
In that case you can delete the comment completely. If there is some
valueable info in the box than please remove all the ascii art and
just keep the pure commit content. Also the blank line between comment
and class definition is not needed.
In addition, feel free to clean-out redundant cruft like (can also be
completely removed):
// hole Beschreibung vom Objekt FooBaa
rtl::OUString FooBaa::getDescription()
{
}
A super plus would be if you could also format the patches to conform
to Doxygen style (see http://doxygen.org/) if they are in a header
(.hxx etc.) file. This means that one-liners have three slashes
(instead of two) and multi-line comments have a /** */ frame with
@param etc.
So, I am currently going through all the files and clean them up
as well before submitting your patch. Thus, please do not wonder why
it is still not integrated yet.
Cheers,
Philipp
Hey Oliver,
I integrated your patch (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c8b7aa55138848fe07108779099267424bc03e3d).
After that I started cleaning up the first parts:
* 7dfba55bfd15b3c3b080a13b63073e6d2ab808b7 doxygenized comments in tools/inc
* 731f3ce64a84b14b43a2a8ca3d455dd8711781b9 clean-up of existing
comments in tools/inc
* 70fc650319f8cfc0b3230ad2dea584eb1368a238 remove ascii art and blank
lines in tools/inc/
Having done inc, I will now continue with my cleanup of the other
subfolders of tools/ over the following evenings...
Waiting for more such great translations from you ;-)
Philipp
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
