[REVIEW][3-5] fdo#39415 Writer collapsing table border painting fixes

2012-06-28 Thread Michael Stahl

hi all, to fix this LO 3.4 regression i've committed 3 patches, which
should be applied to libreoffice-3-5.

i've just pushed these to gerrit, which has strangely resulted in 3
reviews instead of the expected one, but you can look at these here:

https://gerrit.libreoffice.org/239
https://gerrit.libreoffice.org/240
https://gerrit.libreoffice.org/241

the thing i don't understand is how you would add sign-offs to these
before pushing them, but i haven't actually pushed a gerrit patch yet so
probably i don't understand it yet :)

in case gerrit doesn't work for the reviewer, the commit messages
contain the original master commit ids anyway for git-cherry-pick.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [REVIEW][3-5] fdo#39415 Writer collapsing table border painting fixes

2012-06-28 Thread Bjoern Michaelsen
On Thu, Jun 28, 2012 at 02:59:46PM +0200, Michael Stahl wrote:
 i've just pushed these to gerrit, which has strangely resulted in 3
 reviews instead of the expected one, but you can look at these here:

That is to be expected as every change can be reviewed on its own. The patches
are marked as depending on each other, so if you would submit them with gerrit,
the second would wait for the first to be reviewed to even if it is deemed good
to go.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice