Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, Nov 18, 2010 at 01:01:42PM +0100, David Tardon wrote: > Hi all, > > currently, configuring with --enable-debug means that dbglevel is set to > 2, which in turns means that OSL_DEBUG_LEVEL is set to 2. This enables > all the OSL_ debugging stuff there is (well, maybe there is some really > rare stuff that is only enabled for OSL_DEBUG_LEVEL > 2, but I don't > know about any), which spews unbelievable amount of stuff on stdout. > > If we used dbglevel=1 as default, only assertions would be enabled and > the output would be much more manageable (practically nonexistent in > most cases, from my experience). My hope is that more devs would just be > configuring with --enable-debug and using/fixing assertions. The full > debug build would still be easily available: one would just run > build -- dbglevel=2 in the desired module similarly as one runs > build -- debug=true today. > > From impl. standpoint: AFAIK this would require one-line change in > solenv/inc/settins.mk . > The few replies support the idea, so I've committed it. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, Nov 18, 2010 at 01:08:49PM +0100, Sebastian Spaeth wrote: > On Thu, 18 Nov 2010 13:01:42 +0100, David Tardon wrote: > 1) > > one would just run build -- dbglevel=2 in the desired module similarly > > as one runs build -- debug=true today. > > 2) > > As an alternative, we could add optional level argument to > > --enable-debug or add another option, say, --enable-assertions, that > > would do the same thing as --enable-debug and export dbglevel=1 in > > addition. > > 2) is more complicated, but also more discoverable and explicitely > documented. I dislike secret ENVVARIABLE incarnations that enable things > and not easily discoverable without trawling through READMEs. But you'd need the variable anyway, because, as I have said, full dbglevel=2 build is hardly a sensible thing to do. You'd be drowned in the output :-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, 2010-11-18 at 13:01 +0100, David Tardon wrote: > Hi all, > > currently, configuring with --enable-debug means that dbglevel is set to > 2, which in turns means that OSL_DEBUG_LEVEL is set to 2. This enables > all the OSL_ debugging stuff there is (well, maybe there is some really > rare stuff that is only enabled for OSL_DEBUG_LEVEL > 2, but I don't > know about any), which spews unbelievable amount of stuff on stdout. > > If we used dbglevel=1 as default, only assertions would be enabled and > the output would be much more manageable (practically nonexistent in > most cases, from my experience). I never use --enable-debug ( some my opinion aint worth much ) but the above seems more sensible that adding even more options Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, 2010-11-18 at 13:01 +0100, David Tardon wrote: > Hi all, > > currently, configuring with --enable-debug means that dbglevel is set to > 2 > If we used dbglevel=1 as default, only assertions would be enabled and > the output would be much more manageable (practically nonexistent in > most cases, from my experience). My hope is that more devs would just be > configuring with --enable-debug and using/fixing assertions. Yeah, that sound reasonable to me. Having the default "debug" build tuned to level 1, and then we can treat any output as "a bug which should be fixed". C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, 2010-11-18 at 13:01 +0100, David Tardon wrote: > Opinions? I've trained myself to ignore all those messages coming from DBG_* OSL_* and almost always insert my own debug messages. So, to me less of those messages the better. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, 18 Nov 2010 13:01:42 +0100, David Tardon wrote: 1) > one would just run build -- dbglevel=2 in the desired module similarly > as one runs build -- debug=true today. 2) > As an alternative, we could add optional level argument to > --enable-debug or add another option, say, --enable-assertions, that > would do the same thing as --enable-debug and export dbglevel=1 in > addition. 2) is more complicated, but also more discoverable and explicitely documented. I dislike secret ENVVARIABLE incarnations that enable things and not easily discoverable without trawling through READMEs. So: --enable-debug=2 (with 1 being the default) or --enable-assertions (==--enable-debug=1) would be my preferred choice. Sebastian pgpPBkfWTofTh.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
