date:20120122

Re: [Libreoffice] [libo-marketing-priv] Nl Libre marketing

2012-01-22 Thread Cor Nouws


Luc Castermans wrote (21-01-12 14:40)

2012/1/20 Cor Nouws:



3.4.3 and up are as stable as 3.3.4 and have many advantages.



I think you miss my point.


Hmm, I'm not sure I missed it. I just would not call 3.4.3 (and up) 
unstable.


I agree with our mutual attempt to make a better download experience.
As you may have noticed, Hans de Vries is willing and able to help out 
with this, after February 5th.



[..]   [skipped the rest, but will not dump it ;-) ]


--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libo-marketing-priv] Nl Libre marketing

2012-01-22 Thread Luc Castermans


Op 22-01-12 10:30, Cor Nouws schreef:

Luc Castermans wrote (21-01-12 14:40)

2012/1/20 Cor Nouws:



3.4.3 and up are as stable as 3.3.4 and have many advantages.



I think you miss my point.


Hmm, I'm not sure I missed it. I just would not call 3.4.3 (and up) 
unstable.


indeed:

3.5 is the unstable one
3.4.5 is the last stable one
everything before is just "old"

cheers

Luc

<>___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] note about untouched 37361 issues

2012-01-22 Thread Cor Nouws


Hi,

I see that both fdo#43480 and fdo#43869 are still untouched.

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] validation documents for writer

2012-01-22 Thread Luc Castermans


Hi,

Below documents could be used in the test-suite for writer:

The first one contains a 2 column layout, but shows 4 columns in 3.5rc1, 
and triggered

a crash in earlier versions, incl. 3.3.4:

http://members.ziggo.nl/enouwens/permanente%20dingen/odt-docx/kubus.docx


The odt version, triggered a crash in 3.5 beta version, is ok in 3.5rc1

http://members.ziggo.nl/enouwens/permanente%20dingen/odt-docx/kubus.odt


Is there is place for these, or just hand-try with each validation test?

Luc
<>___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] validation documents for writer

2012-01-22 Thread Noel Grandin

I thought someone was running a test-bot that downloaded all of the
documents from bugzilla and loaded them?

Maybe the best place is just to attach them to the relevant bug
entries in bugzilla?

On Sun, Jan 22, 2012 at 12:12, Luc Castermans  wrote:
> Hi,
>
> Below documents could be used in the test-suite for writer:
>
> The first one contains a 2 column layout, but shows 4 columns in 3.5rc1, and
> triggered
> a crash in earlier versions, incl. 3.3.4:
>
> http://members.ziggo.nl/enouwens/permanente%20dingen/odt-docx/kubus.docx
>
>
> The odt version, triggered a crash in 3.5 beta version, is ok in 3.5rc1
>
> http://members.ziggo.nl/enouwens/permanente%20dingen/odt-docx/kubus.odt
>
>
> Is there is place for these, or just hand-try with each validation test?
>
> Luc
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Removed nonexistent items from unusedcode.easy

2012-01-22 Thread Mariusz Dykierek

Hi,

Attached patch removes from "unusedcode.easy" a number of methods that cannot 
be found in the
sources within the "core" directory.

Can someone more experienced than I am confirm that items:
 - CIcc*::*
 - boost::gregorian::*
are really supposed to be enumerated in the "unusedcode.easy"?

-- 
Mariusz Dykerek

diff --git a/unusedcode.easy b/unusedcode.easy
index f3f518b..758f268 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -1,52 +1,20 @@
-AtomDocument::AtomDocument(AtomPubSession*, std::basic_string, std::allocator >)
-AtomFolder::AtomFolder(AtomPubSession*, std::basic_string, std::allocator >)
-AtomPubSession::getCollectionUrl(Collection::Type)
 ByteString::Assign(char const*, unsigned short)
 ByteString::Assign(char)
 ByteString::ByteString(char const*, unsigned short)
 ByteString::SetToken(unsigned short, char, ByteString const&, unsigned short)
-CIccCLUT::Interp3dTetra(float*, float const*)
 CIccCLUT::Iterate(IIccCLUTExec*)
 CIccFormulaCurveSegment::SetFunction(unsigned short, unsigned char, float*)
 CIccIO::ReadLine(void*, int)
-CIccInfo::GetSpotShapeName(icSpotShape)
 CIccMBB::Init(unsigned char, unsigned char)
-CIccMBB::NewCLUT(unsigned char*, unsigned char)
-CIccMBB::NewCLUT(unsigned char, unsigned char)
 CIccMemIO::Alloc(unsigned int, bool)
-CIccMpeCLUT::SetCLUT(CIccCLUT*)
-CIccMpeCreator::DoGetElementSigName(std::basic_string, std::allocator >&, icElemTypeSignature)
-CIccMpeCurveSet::SetCurve(int, CIccCurveSetCurve*)
-CIccProfile::DeleteTag(unsigned int)
 CIccProfile::Detach()
-CIccProfile::GetSpaceSamples() const
-CIccProfileIdDesc::CIccProfileIdDesc(CIccProfile&)
-CIccProfileIdDesc::CIccProfileIdDesc(icProfileID, CIccTagMultiLocalizedUnicode)
 CIccSegmentedCurve::Insert(CIccCurveSegment*)
 CIccTagCurve::SetGamma(float)
-CIccTagFixedNum::GetSize() const
-CIccTagFixedNum::GetSize() const
 CIccTagMultiLocalizedUnicode::SetText(unsigned short const*, unsigned short, unsigned short)
 CIccTagMultiProcessElement::GetElement(int)
-CIccTagNamedColor2::FindColor(char const*)
-CIccTagNamedColor2::FindDeviceColor(float*)
-CIccTagNamedColor2::FindPCSColor(float*, float)
-CIccTagNamedColor2::FindRootColor(char const*)
 CIccTagNamedColor2::GetColorName(std::basic_string, std::allocator >&, int)
-CIccTagNamedColor2::Lab4ToLab2(float*, float const*)
-CIccTagNamedColor2::NegClip(float)
-CIccTagNum::GetSize() const
-CIccTagNum::GetSize() const
-CIccTagNum::GetSize() const
-CIccTagNum::GetSize() const
-CIccTagProfileSequenceId::AddProfileDescription(CIccProfileIdDesc const&)
 CIccTagProfileSequenceId::GetFirst()
 CIccTagProfileSequenceId::GetLast()
-CIccTagProfileSequenceId::ParseMem(unsigned char*, unsigned int)
-CIccTagResponseCurveSet16::GetFirstCurves()
-CIccTagResponseCurveSet16::GetNextCurves()
-CIccTagResponseCurveSet16::NewResponseCurves(icMeasurementUnitSig)
-CIccTagResponseCurveSet16::SetNumChannels(unsigned short)
 CalendarWrapper::setFirstDayOfWeek(short)
 CalendarWrapper::setMinimumNumberOfDaysForFirstWeek(short)
 CertificateContainer::impl_createFactory(com::sun::star::uno::Reference const&)
@@ -130,8 +98,6 @@ MSFilterTracer::SetProperty(rtl::OUString const&, com::sun::star::uno::Any const
 MSFilterTracer::StartElement(rtl::OUString const&, com::sun::star::uno::Reference)
 MachineSettings::CopyData()
 MailDispatcher::removeListener(rtl::Reference)
-Matrix3d::Inverse() const
-Matrix3d::Matrix3d()
 MenuBar::MenuBar(ResId const&)
 MergeData::~MergeData()
 MergeDataFile::Dump()
@@ -254,7 +220,6 @@ ScLeftHeaderEditPage::GetRanges()
 ScMyCellInfo::ScMyCellInfo()
 ScMyStyleRanges::SetStylesToRanges(ScRangeList*, rtl::OUString const*, short, rtl::OUString const*, ScXMLImport&)
 ScMyStyleRanges::SetStylesToRanges(ScRangeListRef, rtl::OUString const*, short, rtl::OUString const*, ScXMLImport&)
-ScNameDefDlg::LinkStubEdModifyHdl(void*, void*)
 ScNamedRangeObj::SetContentWithGrammar(rtl::OUString const&, formula::FormulaGrammar::Grammar)
 ScNamedRangeObj::getImplementation(com::sun::star::uno::Reference)
 ScOutputData::DrawEditParam::getEngineWidth(ScFieldEditEngine*) const
@@ -360,7 +325,6 @@ SfxOleString16Property::SfxOleString16Property(int, String const&)
 SfxOrganizeDlg_Impl::OkHdl(Button*)
 SfxPartChildWnd_Impl::GetChildWindowId()
 SfxPasswordDialog::SetMaxLen(unsigned short)
-SfxPopupWindow::LinkStubDelete(void*, void*)
 SfxPopupWindow::RemoveStatusListener(rtl::OUString const&)
 SfxProgress::Lock()
 SfxRangeItem::SfxRangeItem(unsigned short, SvStream&)
@@ -485,15 +449,8 @@ SvtScriptedTextHelper::GetTextHeight() const
 SvtScriptedTextHelper::GetTextWidth() const
 SvtTabAppearanceCfg::SetDragMode(unsigned short)
 Svx3DLightControl::Svx3DLightControl(Window*, ResId const&)
-Svx3DWin::LinkStubClickLightHdl(void*, void*)
-Svx3DWin::LinkStubDoubleClickHdl(void*, void*)
 SvxAccessibleTextIndex::IsEditable() const
 SvxAccessibleTextPropertySet::getServiceName()
-SvxAreaTabPage::LinkStubClickBitmapHdl_Impl(void*, void*)
-SvxAreaTabPage::LinkStubClickColorHdl_Impl(void*, void*)
-SvxAreaTabPage::LinkS

Re: [Libreoffice] [libo-marketing-priv] Nl Libre marketing

2012-01-22 Thread Tommy

On Sun, 22 Jan 2012 10:47:39 +0100, Luc Castermans  
 wrote:




indeed:

3.5 is the unstable one
3.4.5 is the last stable one
everything before is just "old"

cheers

Luc




I agree with Luc.
IMHO there no valid reason to leave the 3.3.4 download in the
download page: http://www.libreoffice.org/download

the 3.4.x is already mature after 5 micro-releases
and 3.5.x is imminent.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libo-marketing-priv] Nl Libre marketing

2012-01-22 Thread Tommy


On Sun, 22 Jan 2012 11:58:38 +0100, Tommy  wrote:



the 3.4.x is already mature after 5 micro-releases
and 3.5.x is imminent.



and 3.3.x is old

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW 3-5] fdo#43705: fix incomplete updating of the page preview pane in Draw

2012-01-22 Thread Ivan Timofeev


Hi,

https://bugs.freedesktop.org/show_bug.cgi?id=43705 (regression since 3.4)

The fix for review:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=799f2de5d1085d845ec498af0a7932965c42ed68

Thanks,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] EasyHack: remove obsolete BOOTSTRAP defines

2012-01-22 Thread Thomas Collerton

Hello, this patch addresses the EasyHack described at
https://bugs.freedesktop.org/show_bug.cgi?id=44988.
This and all my future contributions are licensed under the LGPLv3 / MPL
1.1 or later versions.
Cheers,
Thomas
From ad48bdadaa058ae8ca81f855002f88d5bf07bdb0 Mon Sep 17 00:00:00 2001
From: Thomas Collerton 
Date: Sun, 22 Jan 2012 12:33:18 +0100
Subject: [PATCH] Remove obsolete BOOTSTRAP defines

---
 tools/inc/tools/fsys.hxx|4 
 tools/source/fsys/comdep.hxx|2 --
 tools/source/fsys/dirent.cxx|   22 --
 tools/source/fsys/tdir.cxx  |2 --
 tools/source/fsys/wntmsc.cxx|2 --
 tools/source/stream/strmunx.cxx |8 
 tools/source/stream/strmwnt.cxx |2 --
 7 files changed, 0 insertions(+), 42 deletions(-)

diff --git a/tools/inc/tools/fsys.hxx b/tools/inc/tools/fsys.hxx
index 3d2dfa8..3ec1799 100644
--- a/tools/inc/tools/fsys.hxx
+++ b/tools/inc/tools/fsys.hxx
@@ -425,9 +425,6 @@ public:
 DirEntry&   operator []( size_t nIndex ) const;
 };
 
-// we don't need this stuff for bootstraping
-#ifndef BOOTSTRAP
-
 //
 
 /** FSysRedirector is an abstract base class for a hook to redirect
@@ -464,7 +461,6 @@ public:
 static void DoRedirect( String &rPath );
 };
 
-#endif // BOOTSTRP
 
 #if defined(DBG_UTIL)
 void FSysTest();
diff --git a/tools/source/fsys/comdep.hxx b/tools/source/fsys/comdep.hxx
index 1728116..193041b 100644
--- a/tools/source/fsys/comdep.hxx
+++ b/tools/source/fsys/comdep.hxx
@@ -76,10 +76,8 @@ struct DirReader_Impl
 bReady ( sal_False ),
 bInUse( sal_False )
 {
-#ifndef BOOTSTRAP
 // Redirection
 FSysRedirector::DoRedirect( aPath );
-#endif
 
 // nur den String der Memer-Var nehmen!
 
diff --git a/tools/source/fsys/dirent.cxx b/tools/source/fsys/dirent.cxx
index a0d3d8e..38138f8 100644
--- a/tools/source/fsys/dirent.cxx
+++ b/tools/source/fsys/dirent.cxx
@@ -128,8 +128,6 @@ int Sys2SolarError_Impl( int nSysErr )
 
 //
 
-#ifndef BOOTSTRAP
-
 FSysRedirector* FSysRedirector::_pRedirector = 0;
 sal_Bool FSysRedirector::_bEnabled = sal_True;
 #ifdef UNX
@@ -184,8 +182,6 @@ void FSysRedirector::DoRedirect( String &rPath )
 return;
 }
 
-#endif // BOOTSTRAP
-
 //
 
 class DirEntryStack
@@ -738,11 +734,9 @@ DirEntry::DirEntry( const String& rInitName, FSysPathStyle eStyle )
 rtl::OString aTmpName(rtl::OUStringToOString(rInitName, osl_getThreadTextEncoding()));
 if (comphelper::string::matchIgnoreAsciiCaseL(aTmpName, RTL_CONSTASCII_STRINGPARAM("file:")))
 {
-#ifndef BOOTSTRAP
 DBG_WARNING( "File URLs are not permitted but accepted" );
 aTmpName = rtl::OUStringToOString(INetURLObject( rInitName ).PathToFileName(), osl_getThreadTextEncoding());
 eStyle = FSYS_STYLE_HOST;
-#endif // BOOTSTRAP
 }
 else
 {
@@ -792,11 +786,9 @@ DirEntry::DirEntry( const rtl::OString& rInitName, FSysPathStyle eStyle )
 rtl::OString aTmpName( rInitName );
 if (comphelper::string::matchIgnoreAsciiCaseL(aTmpName, RTL_CONSTASCII_STRINGPARAM("file:")))
 {
-#ifndef BOOTSTRAP
 DBG_WARNING( "File URLs are not permitted but accepted" );
 aTmpName = rtl::OUStringToOString(INetURLObject( rInitName ).PathToFileName(), osl_getThreadTextEncoding());
 eStyle = FSYS_STYLE_HOST;
-#endif
 }
 #ifdef DBG_UTIL
 else
@@ -916,10 +908,8 @@ DirEntry* DirEntry::ImpChangeParent( DirEntry* pNewParent, sal_Bool bNormalize )
 
 sal_Bool DirEntry::Exists( FSysAccess nAccess ) const
 {
-#ifndef BOOTSTRAP
 static osl::Mutex aLocalMutex;
 osl::MutexGuard aGuard( aLocalMutex );
-#endif
 if ( !IsValid() )
 return sal_False;
 
@@ -968,9 +958,7 @@ sal_Bool DirEntry::First()
 FSysFailOnErrorImpl();
 
 StringaUniPathName( GetPath().GetFull() );
-#ifndef BOOTSTRAP
 FSysRedirector::DoRedirect( aUniPathName );
-#endif
 rtl::OString aPathName(rtl::OUStringToOString(aUniPathName, osl_getThreadTextEncoding()));
 
 DIR *pDir = opendir(aPathName.getStr());
@@ -1724,9 +1712,7 @@ DirEntry DirEntry::TempName( DirEntryKind eKind ) const
 // Redirect
 String aRetVal(ret_val, osl_getThreadTextEncoding());
 String aRedirected (aRetVal);
-#ifndef BOOTSTRAP
 FSysRedirector::DoRedirect( aRedirected );
-#endif
 if ( FSYS_KIND_DIR == eKind )
 {
 if (0 == _mkdir(rtl::OUStringToOString(aRedirected, osl_getThreadTextEncoding()).getStr()))
@@ -1823,9 +1809,7 @@ sal_Bool DirEntry::M

[Libreoffice] [PATCH] Removed LineListBox methods listed in unusedcode.easy

2012-01-22 Thread Mariusz Dykierek

Hi,

Attached patch removes:
 - LineListBox::GetEntryLine1
 - LineListBox::GetEntryLine2
 - LineListBox::GetEntryDistance
 - LineListBox::GetSelectEntryLine1
 - LineListBox::GetSelectEntryLine2
 - LineListBox::GetSelectEntryDistance
and corresponding entries in unusedcode.easy.

-- 
Pozdrawiam,
Mariusz Dykerek

diff --git a/svtools/inc/svtools/ctrlbox.hxx b/svtools/inc/svtools/ctrlbox.hxx
index 5815719..a4d9eff 100644
--- a/svtools/inc/svtools/ctrlbox.hxx
+++ b/svtools/inc/svtools/ctrlbox.hxx
@@ -352,16 +352,10 @@ public:
 
 using ListBox::GetEntryPos;
 virtual sal_uInt16  GetEntryPos( sal_uInt16 nStyle = STYLE_SOLID ) const;
-longGetEntryLine1( sal_uInt16 nPos ) const;
-longGetEntryLine2( sal_uInt16 nPos ) const;
-longGetEntryDistance( sal_uInt16 nPos ) const;
 sal_uInt16  GetEntryStyle( sal_uInt16 nPos ) const;
 
 voidSelectEntry( const XubString& rStr, sal_Bool bSelect = sal_True ) { ListBox::SelectEntry( rStr, bSelect ); }
 voidSelectEntry( sal_uInt16 nStyle = STYLE_SOLID, sal_Bool bSelect = sal_True );
-longGetSelectEntryLine1( sal_uInt16 nSelIndex = 0 ) const;
-longGetSelectEntryLine2( sal_uInt16 nSelIndex = 0 ) const;
-longGetSelectEntryDistance( sal_uInt16 nSelIndex = 0 ) const;
 sal_uInt16  GetSelectEntryStyle( sal_uInt16 nSelIndex = 0 ) const;
 inline sal_Bool IsEntrySelected( const XubString& rStr ) const { return ListBox::IsEntrySelected( rStr ); }
 sal_BoolIsEntrySelected( sal_uInt16 nStyle1 = STYLE_SOLID ) const;
@@ -389,33 +383,6 @@ private:
 void*   GetEntryData( sal_uInt16 nPos ) const;
 };
 
-inline long LineListBox::GetSelectEntryLine1( sal_uInt16 nSelIndex ) const
-{
-sal_uInt16 nPos = GetSelectEntryPos( nSelIndex );
-if ( nPos != LISTBOX_ENTRY_NOTFOUND )
-return GetEntryLine1( nPos );
-else
-return 0;
-}
-
-inline long LineListBox::GetSelectEntryLine2( sal_uInt16 nSelIndex ) const
-{
-sal_uInt16 nPos = GetSelectEntryPos( nSelIndex );
-if ( nPos != LISTBOX_ENTRY_NOTFOUND )
-return GetEntryLine2( nPos );
-else
-return 0;
-}
-
-inline long LineListBox::GetSelectEntryDistance( sal_uInt16 nSelIndex ) const
-{
-sal_uInt16 nPos = GetSelectEntryPos( nSelIndex );
-if ( nPos != LISTBOX_ENTRY_NOTFOUND )
-return GetEntryDistance( nPos );
-else
-return 0;
-}
-
 inline sal_Bool LineListBox::IsEntrySelected( sal_uInt16 nStyle ) const
 {
 sal_uInt16 nPos = GetEntryPos( nStyle );
diff --git a/svtools/source/control/ctrlbox.cxx b/svtools/source/control/ctrlbox.cxx
index d4959ec..ce72cdc 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -851,30 +851,6 @@ sal_uInt16 LineListBox::GetEntryPos( sal_uInt16 nStyle ) const
 
 // ---
 
-long LineListBox::GetEntryLine1( sal_uInt16 nPos ) const
-{
-ImpLineListData* pData = (nPos < pLineList->size()) ? (*pLineList)[ nPos ] : NULL;
-return ( pData ) ? pData->GetLine1ForWidth( m_nWidth ) : 0;
-}
-
-// ---
-
-long LineListBox::GetEntryLine2( sal_uInt16 nPos ) const
-{
-ImpLineListData* pData = (nPos < pLineList->size()) ? (*pLineList)[ nPos ] : NULL;
-return ( pData ) ? pData->GetLine2ForWidth( m_nWidth ) : 0;
-}
-
-// ---
-
-long LineListBox::GetEntryDistance( sal_uInt16 nPos ) const
-{
-ImpLineListData* pData = (nPos < pLineList->size()) ? (*pLineList)[ nPos ] : NULL;
-return ( pData ) ? pData->GetDistForWidth( m_nWidth ) : 0;
-}
-
-// ---
-
 sal_uInt16 LineListBox::GetEntryStyle( sal_uInt16 nPos ) const
 {
 ImpLineListData* pData = (nPos < pLineList->size()) ? (*pLineList)[ nPos ] : NULL;
diff --git a/unusedcode.easy b/unusedcode.easy
index f613cb4..b427d5b 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -80,9 +80,6 @@ InsCapOptArr::Remove(InsCaptionOpt* const&, unsigned short)
 InsCapOptArr::Remove(unsigned short, unsigned short)
 ItemList::FindAttrib(unsigned short)
 KeyboardSettings::CopyData()
-LineListBox::GetEntryDistance(unsigned short) const
-LineListBox::GetEntryLine1(unsigned short) const
-LineListBox::GetEntryLine2(unsigned short) const
 LinkStructArr::DeleteAndDestroy(unsigned short, unsigned short)
 LngSvcMgr::RemoveLngSvcEvtBroadcaster(com::sun::star::uno::Reference const&)
 LocaleDataWrapper::getCollatorImplementations() const
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

2012-01-22 Thread Stefan Knorr (Astron)

Hi Tim,

finally got around to compiling with your patch in and testing the
whole thing a bit and think I like the experience. Although, I would
still love if you could make sure that we in all cases reach exactly
25% zoom at some point (not just 24 and 26).
Thanks for your work.

Astron.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

libreoffice@lists.freedesktop.org

2012-01-22 Thread Mariusz Dykierek

Attached patch removes 
NfCurrencyEntry::ApplyVariableInformation(NfCurrencyEntry const&) as
listed in unusedcode.easy.

-- 
Mariusz Dykerek

diff --git a/svl/inc/svl/zforlist.hxx b/svl/inc/svl/zforlist.hxx
index aa68fc1..ac387d4 100644
--- a/svl/inc/svl/zforlist.hxx
+++ b/svl/inc/svl/zforlist.hxx
@@ -260,10 +260,6 @@ public:
 /// Symbols and language identical
 booloperator==( const NfCurrencyEntry& r ) const;
 
-/** Apply format information (nPositiveFormat,
- nNegativeFormat, nDigits, cZeroChar) of another format. */
-voidApplyVariableInformation( const NfCurrencyEntry& );
-
 const String&   GetSymbol() const   { return aSymbol; }
 const String&   GetBankSymbol() const   { return aBankSymbol; }
 LanguageTypeGetLanguage() const { return eLanguage; }
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index eecd743..1f5085d 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -3852,14 +3852,6 @@ bool NfCurrencyEntry::operator==( const NfCurrencyEntry& r ) const
 ;
 }
 
-void NfCurrencyEntry::ApplyVariableInformation( const NfCurrencyEntry& r )
-{
-nPositiveFormat = r.nPositiveFormat;
-nNegativeFormat = r.nNegativeFormat;
-cZeroChar   = r.cZeroChar;
-}
-
-
 void NfCurrencyEntry::BuildSymbolString( String& rStr, bool bBank,
 bool bWithoutExtension ) const
 {
diff --git a/unusedcode.easy b/unusedcode.easy
index b427d5b..4c9c46d7 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -113,7 +113,6 @@ MultiLineEdit::IsFocusSelectionHideEnabled() const
 MultiSelection::Append(long)
 MultiSelection::PrevSelected()
 NativeNumberWrapper::isValidNatNum(com::sun::star::lang::Locale const&, short) const
-NfCurrencyEntry::ApplyVariableInformation(NfCurrencyEntry const&)
 NfCurrencyEntry::NfCurrencyEntry()
 NotificationSettings::CopyData()
 NumberFormatCodeWrapper::getDefault(short, short) const
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Compiling question by a complete beginner

2012-01-22 Thread Bruno Girin


On 21/01/12 20:49, Bar?s, Akkurt wrote:
Hi, I'm a complete beginner in LibreOffice development and at the 
compiling step now. I tried instructions here: 
http://wiki.documentfoundation.org/Development/Native_Build But 
compilation failed while building the moz module. I tried instructions 
here: https://www.libreoffice.org/bugzilla/show_bug.cgi?id=39852 but 
the result is the same.


Then, i found this blog post and restarted compilation from the 
beginning: 
http://www.vogella.de/blog/2011/02/10/how-to-compile-libreoffice/ I 
got an error about helpcontent2.


Error message:
---
ERROR: error 65280 occurred while making 
/home/baris/libo/helpcontent2/source/auxiliary


 it seems that the error is inside 'helpcontent2', please re-run build
 inside this module to isolate the error and/or test your fix:
---

rm -Rf /home/baris/libo/helpcontent2/unxlngi6.pro 
 # optional module 'clean'

/bin/bash
cd /home/baris/libo
source ./Env.Host.sh 
cd helpcontent2
build

when the problem is isolated and fixed exit and re-run 'make' from the 
top-level

---
I tried ./autogen.sh --with-languages and ./download and the commands 
above but, result is negative. I have directories such as artwork, 
base, calc in clone directory but i have no l10n directory there.


By the way, second way of compilation took 20 hours until the error. 
Isn't this a bit long? The first one took only 8-9 hours.


I'm using Ubuntu 11.04. Do you have any suggestions? Thanks, in advance.


Hi Baris,

I had exactly the same problem with Ubuntu 11.10 and it appears that for 
some reason moz doesn't build on Ubuntu. This was reported on this list 
in October: 
http://lists.freedesktop.org/archives/libreoffice/2011-October/019597.html


Now considering that moz is used for macro security settings and digital 
signatures, it's not essential to build it in order to have a working 
build. You can disable it as explained here: 
http://wiki.documentfoundation.org/Development/Native_Build#Disable_mozilla


In my case for instance, I run the following to get it to build:
./autogen.sh --with-num-cpus=4 --disable-mozilla

Happy building!

Bruno



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-22 Thread Marcel Metz

Hello lo-devs,

the attached patches replace some of the ENSURE_OR_* macros, with
regular code. I can't see any advantage in these macros aside from save
some typing.

regards Marcel Metz
>From 1d0aeb0f7266646da553ea7d120afcc9065118e5 Mon Sep 17 00:00:00 2001
Message-Id: <1d0aeb0f7266646da553ea7d120afcc9065118e5.1327236163.git.mm...@adrian-broher.net>
From: Marcel Metz 
Date: Sun, 15 Jan 2012 11:30:24 +0100
Subject: [PATCH 1/2] Replaced diagnore ENSURE_OR_BREAK with regular code.
To: libreoffice@lists.freedesktop.org
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="true"

This is a multi-part message in MIME format.
--true
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit

---
 basctl/source/basicide/basobj2.cxx |   18 +++--
 svtools/source/contnr/svtreebx.cxx |7 -
 svtools/source/uno/svtxgridcontrol.cxx |   42 +++
 svx/source/form/fmpgeimp.cxx   |6 -
 ucb/source/ucp/ext/ucpext_content.cxx  |   21 +--
 xmloff/source/forms/elementimport.cxx  |   42 +--
 6 files changed, 114 insertions(+), 22 deletions(-)


--true
Content-Type: text/x-patch; name="0001-Replaced-diagnore-ENSURE_OR_BREAK-with-regular-code.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Replaced-diagnore-ENSURE_OR_BREAK-with-regular-code.patch"

diff --git a/basctl/source/basicide/basobj2.cxx b/basctl/source/basicide/basobj2.cxx
index 646c40c..36ee590 100644
--- a/basctl/source/basicide/basobj2.cxx
+++ b/basctl/source/basicide/basobj2.cxx
@@ -305,13 +305,25 @@ namespace
 break;
 
 SbModule* pModule = pMethod->GetModule();
-ENSURE_OR_BREAK( pModule, "BasicIDE::ChooseMacro: No Module found!" );
+if ( !pModule )
+{
+SAL_WARN( "basctl.basicide", "BasicIDE::ChooseMacro: No Module found!" );
+break;
+}
 
 StarBASIC* pBasic = dynamic_cast(pModule->GetParent());
-ENSURE_OR_BREAK( pBasic, "BasicIDE::ChooseMacro: No Basic found!" );
+if ( !pBasic )
+{
+SAL_WARN( "basctl.basicide", "BasicIDE::ChooseMacro: No Basic found!" );
+break;
+}
 
 BasicManager* pBasMgr = BasicIDE::FindBasicManager( pBasic );
-ENSURE_OR_BREAK( pBasMgr, "BasicIDE::ChooseMacro: No BasicManager found!" );
+if ( !pBasMgr )
+{
+SAL_WARN( "basctl.basicide", "BasicIDE::ChooseMacro: No BasicManager found!" );
+break;
+}
 
 // name
 String aName;
diff --git a/svtools/source/contnr/svtreebx.cxx b/svtools/source/contnr/svtreebx.cxx
index 5fa9bde..9bcbeb9 100644
--- a/svtools/source/contnr/svtreebx.cxx
+++ b/svtools/source/contnr/svtreebx.cxx
@@ -2209,7 +2209,12 @@ void SvTreeListBox::ModelNotification( sal_uInt16 nActionId, SvListEntry* pEntry
 case LISTACTION_INSERTED:
 {
 SvLBoxEntry* pEntry( dynamic_cast< SvLBoxEntry* >( pEntry1 ) );
-ENSURE_OR_BREAK( pEntry, "SvTreeListBox::ModelNotification: invalid entry!" );
+if ( !pEntry )
+{
+SAL_WARN( "svtools.contnr", "SvTreeListBox::ModelNotification: invalid entry!" );
+break;
+}
+
 SvLBoxContextBmp* pBmpItem = static_cast< SvLBoxContextBmp* >( pEntry->GetFirstItem( SV_ITEM_ID_LBOXCONTEXTBMP ) );
 if ( !pBmpItem )
 break;
diff --git a/svtools/source/uno/svtxgridcontrol.cxx b/svtools/source/uno/svtxgridcontrol.cxx
index c6ce75f..2452c15 100644
--- a/svtools/source/uno/svtxgridcontrol.cxx
+++ b/svtools/source/uno/svtxgridcontrol.cxx
@@ -152,7 +152,12 @@ void SVTXGridControl::setProperty( const ::rtl::OUString& PropertyName, const An
 {
 sal_Int32 rowHeaderWidth( -1 );
 aValue >>= rowHeaderWidth;
-ENSURE_OR_BREAK( rowHeaderWidth > 0, "SVTXGridControl::setProperty: illegal row header width!" );
+if ( rowHeaderWidth <= 0 )
+{
+SAL_WARN( "svtools.uno", "SVTXGridControl::setProperty: illegal row header width!" );
+break;
+}
+
 m_pTableModel->setRowHeaderWidth( rowHeaderWidth );
 // TODO: the model should broadcast this change itself, and the table should invalidate itself as needed
 pTable->Invalidate();
@@ -170,7 +175,12 @@ void SVTXGridControl::setProperty( const ::rtl::OUString& PropertyName, const An
 {
 aValue >>= columnHeaderHeight;
 }
-ENSURE_OR_BREAK( columnHeaderHeight > 0, "SVTXGridControl::setProperty: illegal column header height!" );
+if ( columnHeaderHeight <= 0 )
+{
+SAL_WARN( "svtools.uno", "SVTXGridControl::setProperty: i

[Libreoffice] Important details for easy woking on LibreOffice

2012-01-22 Thread Danylo Sa

Hello.

People who used MS Office before has some complaints about LibreOffice:

 1 - Insert number of pages is a pain in LibreOffice Writer.
 Why all this complication for a simple task?

   SOLUTION
   --> Why don't you include the old "pagination" extension in main release?


 2 - Printing only even pages or odd pages is a pain in LibreOffice.
 Lots of people doesn't know that left pages means "even" and right pages 
means "odd"

   SOLUTION
   --> Why don't you include the terms "odd" and "even" beside the "right" and 
"left" terms? It would be like this:

 [ ] print only left pages (even)
 [ ] print only right pages (odd)

Your office suite is the best; however, it needs some tweaks.
I love LibreOffice and God bless you all.
-- 
Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Volker Merschmann  changed:

   What|Removed |Added

 Depends on||45068

--- Comment #119 from Volker Merschmann  2012-01-22 
06:12:55 PST ---
Nominating Bug 45068 - Update installation from 3.4 fails on most windows
systems

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 44025, which changed state.

Bug 44025 Summary: SEARCH does not go beyond prefetch window if row count is 
not final
https://bugs.freedesktop.org/show_bug.cgi?id=44025

   What|Old Value   |New Value

 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 45068, which changed state.

Bug 45068 Summary: Update from 3.4 to 3.5rc1 is not working
https://bugs.freedesktop.org/show_bug.cgi?id=45068

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Windows porter for fdo#45058: postgresl-sdbc "no driver for URL"

2012-01-22 Thread Lionel Elie Mamane

Hi,

Could a LibreOffice/Windows developer please take a look at
https://bugs.freedesktop.org/show_bug.cgi?id=45058 ?

I think I ruled out any missing / not found DLL problem (see bug
log). I'm rather unfamiliar with Microsoft Windows, so I'm not sure
what to do next as debugging step.

Thanks.

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Lionel Elie Mamane

Hi,

With respect to fdo#45090, that is the GNU/Linux dlopen() does not
find libldap50.so when loading PostgreSQL-SDBC's
postgresql-sdbc-impl.uno.so.

"Naturally", libldap50.so is in $INSTALL_DIR/program/.

Have we already solved this problem, and if yes, how do I apply the
solution to PostgreSQL-SDBC?


If not:

As I understand the problem, in DT_R(UN)PATH, when loading
postgresql-sdbc-impl.uno.so, $ORIGIN is the directory contained that
.so file, not the directory containing soffice.bin. So in some sense,
postgresql-sdbc-impl.uno.so has the "wrong' DT_RUNPATH:

(RPATH)  Library rpath: [$ORIGIN:$ORIGIN/../ure-link/lib]
(RUNPATH)Library runpath: [$ORIGIN:$ORIGIN/../ure-link/lib]

Thinking of PostgreSQL-SDBC as a bundled extension, it should be:
 $ORIGIN/../../../program:$ORIGIN/../../../ure-link/lib
because it sits in $INSTALL_DIR/share/extensions/postgresql-sdbc

But if it is installed as a shared extension, then it needs to be:
 
$ORIGIN/../../../../../../../../program:$ORIGIN/../../../../../../../../ure-link/lib
because it is in 
$INSTALL_DIR/share/uno_packages/cache/uno_packages/FOO.tmp_/postgresql-sdbc-0.8.2.oxt/postgresql-sdbc-0.8.2/linux_x64.plt

So far, so good, we could just merge these four entries. But if it is
installed as a user extension? Then no amount of fiddling with $ORIGIN
will help, since it is in the user's home directory (and where depends
on the LibreOffice version... could be .config/libreoffice/3/... or in
.libreoffice/3/...), and there is no relationship between the
$INSTALL_DIR and that.


So, what can we do?

Either we change the soffice script to set LD_LIBRARY_PATH also on
GNU/Linux, or PostgreSQL-SDBC ships a second copy of libldap50.so.

Now that I think of it, only the copy solution will make it work with
a LibreOffice compiled with --with-openldap, since that LibreOffice
won't ship libldap50.so. But distros will hate that, so they need a
way to disable that... I'd say do it only if LibreOffice is not
configured to use its internal mozldap.

Any opinions, vetos, agreements?

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on|45068   |

--- Comment #120 from Rainer Bielefeld  
2012-01-22 09:06:49 PST ---
> Nominating Bug 45068 - Update installation from 3.4 fails on most windows

@Volker:
It's as Lionel wrote in the bug, we can't do a Fix for the 3.4.4 and older
versions. But we urgently will need a hint in the installations manual that
Versions before 3.4.5 will have to be uninstalled on 64 Bit WIN

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Lionel Elie Mamane

On Sun, Jan 22, 2012 at 05:55:07PM +0100, Lionel Elie Mamane wrote:

> With respect to fdo#45090, that is the GNU/Linux dlopen() does not
> find libldap50.so when loading PostgreSQL-SDBC's
> postgresql-sdbc-impl.uno.so.

> Now that I think of it, only the copy solution will make it work with
> a LibreOffice compiled with --with-openldap, since that LibreOffice
> won't ship libldap50.so. But distros will hate that, so they need a
> way to disable that... I'd say do it only if LibreOffice is not
> configured to use its internal mozldap.

I'm thinking of something along the lines of the attached patch.

-- 
Lionel
>From 27e7993fde6154e0a7b13323cb854d99d8e3af63 Mon Sep 17 00:00:00 2001
From: Lionel Elie Mamane 
Date: Sun, 22 Jan 2012 18:48:22 +0100
Subject: [PATCH] fdo#45090: copy LDAP library to postgresql-sdbc .oxt file

---
 connectivity/source/drivers/postgresql/makefile.mk |   18 +++---
 1 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/connectivity/source/drivers/postgresql/makefile.mk b/connectivity/source/drivers/postgresql/makefile.mk
index cc6a4df..dcd5842 100644
--- a/connectivity/source/drivers/postgresql/makefile.mk
+++ b/connectivity/source/drivers/postgresql/makefile.mk
@@ -88,13 +88,13 @@ LIBPQ_DEP_LIBS += \
 .IF "$(WITH_LDAP)" == "YES"
 LIBPQ_DEP_LIBS+=\
 $(LDAPSDKLIB)
-.ENDIF
-.ELSE
+.ENDIF # WITH_LDAP == YES
+.ELSE # Not MSVC on MSWindows
 LIBPQ_LINK=$(OUTDIR)/lib/libpq.a
 LIBPQ_DEP_LIBS+=$(eq,$(OS),MACOSX $(NULL) -Wl,--as-needed)
 .INCLUDE : $(OUTDIR_FOR_BUILD)/inc/postgresql/libpq-flags.mk
 LIBPQ_DEP_LIBS+=$(eq,$(OS),MACOSX $(NULL) -Wl,--no-as-needed)
-.ENDIF
+.ENDIF # MSVC on MSWindows
 POSTGRESQL_INC=-I$(OUTDIR)/inc/postgresql
 POSTGRESQL_LIB=
 .ENDIF # SYSTEM_POSTGRESQL
@@ -191,11 +191,22 @@ INI_EXT=.ini
 $(DLLDEST)$/$(SHL1TARGET)$(INI_EXT): $(SHL1TARGET)
 +cp $? $@
 
+LDAP_LIBFILE_OUTDIR=
+LDAP_LIBFILE_FNAME=
+.IF "$(GUI)"!="WNT" && "$(SYSTEM_POSTGRESQL)"!="YES" && "$(WITH_LDAP)" == "YES" && "$(WITH_OPENLDAP)" != "YES" && "$(SYSTEM_MOZILLA)" != "YES"
+LDAP_LIBFILE_FULLPATH := $(OUTDIR)$/lib$/$(shell echo '$(LDAPSDKLIB)' | sed -e 's/^-l/lib/' -e 's/\.lib$//' )$(DLLPOST)
+LDAP_LIBFILE_FNAME := $(LDAP_LIBFILE_FULLPATH:f)
+LDAP_LIBFILE_OUTDIR += $(DLLDEST)$/$(LDAP_LIBFILE_FNAME)
+$(LDAP_LIBFILE_OUTDIR): $(LDAP_LIBFILE_FULLPATH)
++cp $? $@
+.ENDIF
+
 $(DLLDEST)$/$(DRIVERNAME): \
 $(DLLDEST)$/META-INF$/manifest.xml \
 $(DLLDEST)$/description.xml \
 $(DLLDEST)$/description/description_en-US.txt \
 $(DLLDEST)$/postgresql.xcu \
+$(LDAP_LIBFILE_OUTDIR) \
 $(DLLDEST)$/$(SHL1TARGET)$(DLLPOST) \
 $(DLLDEST)$/$(SHL2TARGET)$(DLLPOST) \
 $(DLLDEST)$/$(SHL1TARGET)$(INI_EXT)
@@ -205,6 +216,7 @@ $(DLLDEST)$/$(DRIVERNAME): \
 $(SHL1TARGET)$(DLLPOST) \
 $(SHL2TARGET)$(DLLPOST) \
 $(SHL1TARGET)$(INI_EXT) \
+$(LDAP_LIBFILE_FNAME) \
 description.xml \
 description/description_en-US.txt \
 postgresql.xcu
-- 
1.7.7.3

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] 3-5 and 3-4, fdo#45032 Calc export to HTML

2012-01-22 Thread Eike Rathke

Hi,

Please review and cherry-pick to 3.5.0 and 3-4
http://cgit.freedesktop.org/libreoffice/core/commit/?id=d180de79b82d1a73cfd914dd9a1524109c5e78ee

Resolves https://bugs.freedesktop.org/show_bug.cgi?id=45032
Calc export to HTML with graphics failed

Thanks
  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpFb9gNd91v2.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Carlo Strata  changed:

   What|Removed |Added

 Depends on||36742, 40289, 45078

--- Comment #252 from Carlo Strata  2012-01-22 
12:49:37 PST ---
I think that bug 40289, bug 36742 and bug 45078 are the same one.

I just test them with:
- LibreOffice 3.4.5 rc2 (= final), linux x86-64 rpm build, on OpenSuSE 12.1,
kernel 3.1.0, updated, Gnome, ita GUIed;

- LibreOffice 3.5.0 beta3 and rc1, win32 build, on my Windows Vista
64 bit, SP2, updated, ita GUIed;

and I obtained always the same result: the bug is still here.

Now I try with 3.5.0 RC1, I posti here test results and then I add them to Most
Annoying 3.4 and 3.5 ones.

I think they may hide a bad table width initialization and tick and color
management. This affect quality and people LibreOffice quality ideas.

Tables and default table width are too often used to yield many document and
their exported PDFs so that people may easily decide because the border bug
that LibreOffice is still too young to be adopted and so they may decide to
unistall it putting all our efforts trough the window!

It's a big pity! So that I add them to most annoying one.

Carlo

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Carlo Strata  changed:

   What|Removed |Added

 Depends on||36742, 40289, 45078

--- Comment #121 from Carlo Strata  2012-01-22 
12:52:11 UTC ---
I think that bug 40289, bug 36742 and bug 45078 are the same one.

I just test them with:
- LibreOffice 3.4.5 rc2 (= final), linux x86-64 rpm build, on OpenSuSE 12.1,
kernel 3.1.0, updated, Gnome, ita GUIed;

- LibreOffice 3.5.0 beta3 and rc1, win32 build, on my Windows Vista
64 bit, SP2, updated, ita GUIed;

and I obtained always the same result: the bug is still here.

Now I try with 3.5.0 RC1, I posti here test results and then I add them to Most
Annoying 3.4 and 3.5 ones.

I think they may hide a bad table width initialization and tick and color
management. This affect quality and people LibreOffice quality ideas.

Tables and default table width are too often used to yield many document and
their exported PDFs so that people may easily decide because the border bug
that LibreOffice is still too young to be adopted and so they may decide to
unistall it putting all our efforts trough the window!

It's a big pity! So that I add them to most annoying one.

Carlo

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] fdo#44983 Fix RTF import of \paperh and \paperw

2012-01-22 Thread Miklos Vajna

-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fdo#44983 Fix RTF import of \paperh and \paperw

2012-01-22 Thread Miklos Vajna

Hi,

See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c39e891d4dc963d2cac9843b426494e4dc490278

Could somebody sign-off and push to -3-5, please?   
  

Thanks,

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Fix RTF import of dotted and word underline

2012-01-22 Thread Miklos Vajna

Marking as pushed.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Fridrich Strba

Lionel,

I would guess that maybe there would be a way to generally ask the
extension manager to look for dependent libraries of the extensions in
other place then URE/lib only. Let us see what Stephan answers in the
Windows bug. I guess that generic solution involving loading of shared
objects from program directory could be found. I really don't like
copying over libraries like this.

Just let us wait for Stephan


On 22/01/12 19:12, Lionel Elie Mamane wrote:
> On Sun, Jan 22, 2012 at 05:55:07PM +0100, Lionel Elie Mamane wrote:
> 
>> With respect to fdo#45090, that is the GNU/Linux dlopen() does not
>> find libldap50.so when loading PostgreSQL-SDBC's
>> postgresql-sdbc-impl.uno.so.
> 
>> Now that I think of it, only the copy solution will make it work with
>> a LibreOffice compiled with --with-openldap, since that LibreOffice
>> won't ship libldap50.so. But distros will hate that, so they need a
>> way to disable that... I'd say do it only if LibreOffice is not
>> configured to use its internal mozldap.
> 
> I'm thinking of something along the lines of the attached patch.
> 
> 
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] A copy-paste bug detected by cppcheck at sdext/source/presenter/PresenterTimer.cxx:512

2012-01-22 Thread Mariusz Dykierek

Attached patch fixes a copy-paste error in the condition.
Seconds used twice instead of Hours.

-- 
Pozdrawiam,
Mariusz Dykerek

diff --git a/sdext/source/presenter/PresenterTimer.cxx b/sdext/source/presenter/PresenterTimer.cxx
index 6c5f8d9..3757bd0 100644
--- a/sdext/source/presenter/PresenterTimer.cxx
+++ b/sdext/source/presenter/PresenterTimer.cxx
@@ -511,7 +511,7 @@ void PresenterClockTimer::CheckCurrentTime (const TimeValue& rCurrentTime)
 {
 if (aDateTime.Seconds != maDateTime.Seconds
 || aDateTime.Minutes != maDateTime.Minutes
-|| aDateTime.Seconds != maDateTime.Seconds)
+|| aDateTime.Hours != maDateTime.Hours)
 {
 // The displayed part of the current time has changed.
 // Prepare to call the listeners.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 45078, which changed state.

Bug 45078 Summary: upper table border lost in .pdf export. Regression from 3.3.4
https://bugs.freedesktop.org/show_bug.cgi?id=45078

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|NEEDINFO|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 45078, which changed state.

Bug 45078 Summary: upper table border lost in .pdf export. Regression from 3.3.4
https://bugs.freedesktop.org/show_bug.cgi?id=45078

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|NEEDINFO|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Lionel Elie Mamane

On Sun, Jan 22, 2012 at 10:03:24PM +0100, Fridrich Strba wrote:

> I would guess that maybe there would be a way to generally ask the
> extension manager to look for dependent libraries of the extensions in
> other place then URE/lib only.

LD_LIBRARY_PATH envvar? With GNU ld, it is the only one I see. MacOS X
has "@executable_path" which is *exactly* what we want in this
situation: It is replaced by the path to the directory containing the
*main* executable, not the path to the shared library; from reading
the manpage, GNU ld-linux has only $ORIGIN, which is the path to the
shared library (that is called @loader_path on MacOS X).

> I really don't like copying over libraries like this.

OTOH, even if we find a good way to handle "library load path" issue,
it still does not solve the problem of how the .oxt will work with a
LibreOffice compiled with --with-openldap, such as e.g. Debian's one.

> On 22/01/12 19:12, Lionel Elie Mamane wrote:
>> On Sun, Jan 22, 2012 at 05:55:07PM +0100, Lionel Elie Mamane wrote:

>>> With respect to fdo#45090, that is the GNU/Linux dlopen() does not
>>> find libldap50.so when loading PostgreSQL-SDBC's
>>> postgresql-sdbc-impl.uno.so.

>>> Now that I think of it, only the copy solution will make it work with
>>> a LibreOffice compiled with --with-openldap, since that LibreOffice
>>> won't ship libldap50.so. But distros will hate that, so they need a
>>> way to disable that... I'd say do it only if LibreOffice is not
>>> configured to use its internal mozldap.

>> I'm thinking of something along the lines of the attached patch.

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Redundant condition at sc/source/filter/starcalc/scflt.cxx:1837 detected by cppcheck + comment translation

2012-01-22 Thread Mariusz Dykierek

Subject explains almost everything.

-- 
Mariusz Dykerek

diff --git a/sc/source/filter/starcalc/scflt.cxx b/sc/source/filter/starcalc/scflt.cxx
index 1d30ea2..2086bf5 100644
--- a/sc/source/filter/starcalc/scflt.cxx
+++ b/sc/source/filter/starcalc/scflt.cxx
@@ -1708,7 +1708,7 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
 sal_uInt16 nValue1;
 Sc10ColData *pColData;
 
-// Font (Name, Groesse)
+// Font (Name, Size)
 nStart = 0;
 nEnd = 0;
 nLimit = aFont.Count;
@@ -1739,7 +1739,7 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
 nStart = nEnd + 1;
 }
 
-// Fontfarbe
+// Font color
 nStart = 0;
 nEnd = 0;
 nLimit = aColor.Count;
@@ -1758,7 +1758,7 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
 nStart = nEnd + 1;
 }
 
-// Fontattribute (Fett, Kursiv...)
+// Font attributes (Bold, Italic...)
 nStart = 0;
 nEnd = 0;
 nLimit = aAttr.Count;
@@ -1783,7 +1783,7 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
 nStart = nEnd + 1;
 }
 
-// Zellausrichtung
+// Cell alignment
 nStart = 0;
 nEnd = 0;
 nLimit = aJustify.Count;
@@ -1834,15 +1834,15 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
 aScPattern.GetItemSet().Put(SfxInt32Item(ATTR_ROTATE_VALUE,27000));
 
 sal_Int16 Margin = Max((sal_uInt16)20, (sal_uInt16)(EJustify * 20));
-if (((OJustify & ojBottomTop) == ojBottomTop) || ((OJustify & ojBottomTop) == ojBottomTop))
+if ( (OJustify & ojBottomTop) == ojBottomTop )
 aScPattern.GetItemSet().Put(SvxMarginItem(20, Margin, 20, Margin, ATTR_MARGIN));
 else
 aScPattern.GetItemSet().Put(SvxMarginItem(Margin, 20, Margin, 20, ATTR_MARGIN));
 pDoc->ApplyPatternAreaTab(Col, nStart, Col, nEnd, Tab, aScPattern);
 }
-nStart = nEnd + 1;
+nStart = nEnd + 1;
 }
-// Umrandung
+// Border
 sal_BoolbEnd = false;
 sal_uInt16  nColorIndex = 0;
 sal_uInt16  nFrameIndex = 0;
@@ -1966,9 +1966,9 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
 pColData++;
 }
 
-// ACHTUNG: Code bis hier ueberarbeitet ... jetzt hab' ich keinen Bock mehr! (GT)
+// ATTENTION: Code up to here works more or less ... from here I've had enough ! (GT)
 
-// Hintergrund (Farbe, Raster)
+// Background (Color, Raster)
 sal_uInt16  nRasterIndex = 0;
 bEnd= false;
 nColorIndex = 0;
@@ -2056,7 +2056,7 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
 nHelpMe--;
 }
 
-// Zahlenformate
+// Number format
 nStart = 0;
 nEnd = 0;
 nLimit = aValue.Count;
@@ -2078,7 +2078,7 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
 nStart = nEnd + 1;
 }
 
-// Zellattribute (Schutz, Versteckt...)
+// Cell attributes (Protected, hidden...)
 nStart = 0;
 nEnd = 0;
 for (i=0; iGetStyleSheetPool();
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-22 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Cor Nouws  changed:

   What|Removed |Added

 Depends on||45084

--- Comment #122 from Cor Nouws  2012-01-22 14:12:32 PST ---
adding regression Bug 45084 - FILEOPEN: Cannot open HTML Files in Calc

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Same expression on both sides of || in if condition at libreoffice@lists.freedesktop.org (cppcheck)

2012-01-22 Thread Mariusz Dykierek

I guess this is what author intended.
The other solution is to remove the copy.

-- 
Mariusz Dykerek

diff --git a/svtools/source/misc/filechangedchecker.cxx b/svtools/source/misc/filechangedchecker.cxx
index 514841f..7a99f15 100644
--- a/svtools/source/misc/filechangedchecker.cxx
+++ b/svtools/source/misc/filechangedchecker.cxx
@@ -83,7 +83,7 @@ bool FileChangedChecker::hasFileChanged()
 // Check if the seconds time stamp has any difference
 // If so, then our file has changed meanwhile
 if( newTime.Seconds != mLastModTime.Seconds ||
-newTime.Seconds != mLastModTime.Seconds )
+newTime.Minutes != mLastModTime.Minutes )
 {
 // Since the file has changed, set the new status as the file status and
 // return True
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] "make check" fails with lots of missing dictionaries

2012-01-22 Thread Chr. Rossmanith


Hi,

what can I do to make "make check" succeed? Currently it fails with:

... languages en-US ...
... analyzing files ...
ERROR: The following files could not be found:
ERROR: File not found: dict-an.oxt
ERROR: File not found: dict-ar.oxt
ERROR: File not found: dict-be.oxt
ERROR: File not found: dict-bg.oxt
ERROR: File not found: dict-bn.oxt
ERROR: File not found: dict-de.oxt
ERROR: File not found: dict-el.oxt
ERROR: File not found: dict-gd.oxt
ERROR: File not found: dict-gu.oxt
ERROR: File not found: dict-hi.oxt
ERROR: File not found: dict-lv.oxt
ERROR: File not found: dict-pt-pt.oxt
ERROR: File not found: dict-si.oxt
ERROR: File not found: dict-te.oxt
... cleaning the output tree ...
... removing directory /tmp/ooopackaging/i_150701327301978 ...
Mon Jan 23 07:59:43 2012 (00:05 min.)
Failed to install:  at 
/Space/LibreOffice_OneGit/core/solenv/bin/ooinstall line 129.

dmake:  Error code 255, while making 'localinstall'


I don't think that this is related to modifications I've made during 
replacing ByteString with OString...


Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] "make check" fails with lots of missing dictionaries

2012-01-22 Thread Noel Grandin


I had the same problem.
Doing a make clean and then updating to HEAD fixed it for me, but can't 
say exactly why...


On 2012-01-23 09:28, Chr. Rossmanith wrote:

Hi,

what can I do to make "make check" succeed? Currently it fails with:

... languages en-US ...
... analyzing files ...
ERROR: The following files could not be found:
ERROR: File not found: dict-an.oxt
ERROR: File not found: dict-ar.oxt
ERROR: File not found: dict-be.oxt
ERROR: File not found: dict-bg.oxt
ERROR: File not found: dict-bn.oxt
ERROR: File not found: dict-de.oxt
ERROR: File not found: dict-el.oxt
ERROR: File not found: dict-gd.oxt
ERROR: File not found: dict-gu.oxt
ERROR: File not found: dict-hi.oxt
ERROR: File not found: dict-lv.oxt
ERROR: File not found: dict-pt-pt.oxt
ERROR: File not found: dict-si.oxt
ERROR: File not found: dict-te.oxt
... cleaning the output tree ...
... removing directory /tmp/ooopackaging/i_150701327301978 ...
Mon Jan 23 07:59:43 2012 (00:05 min.)
Failed to install:  at 
/Space/LibreOffice_OneGit/core/solenv/bin/ooinstall line 129.

dmake:  Error code 255, while making 'localinstall'


I don't think that this is related to modifications I've made during 
replacing ByteString with OString...


Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



Disclaimer: http://www.peralex.com/disclaimer.html


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-22 Thread Stephan Bergmann


On 01/22/2012 05:55 PM, Lionel Elie Mamane wrote:

Hi,

With respect to fdo#45090, that is the GNU/Linux dlopen() does not
find libldap50.so when loading PostgreSQL-SDBC's
postgresql-sdbc-impl.uno.so.

"Naturally", libldap50.so is in $INSTALL_DIR/program/.

Have we already solved this problem, and if yes, how do I apply the
solution to PostgreSQL-SDBC?


The "solution" is that extensions must only link against the handful of 
libraries in the URE interface (basically cppu, cppuhelper, sal, 
salhelper) and not against any others provided by LO.  Everything else 
is not supported and is an error.


The best fix would probably be to change postgresql-sdbc.oxt from a 
bundled extension into an -- optionally installable, but "proper" -- 
part of the installation.


A workaround hack for Linux would indeed be to modify RPATH, see 
 
(RUNPATH is link-time only, btw.).


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Pushed] [PATCH] Redundant condition at sc/source/filter/starcalc/scflt.cxx:1837 detected by cppcheck + comment translation

2012-01-22 Thread Muthu Subramanian K

Pushed it with slight modifications. Thank you so much for the patch!
Looking forward for more... :)

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9042c4d0740c5b222b27d189e526b74fbd740b6f

On 01/23/2012 03:32 AM, Mariusz Dykierek wrote:
> Subject explains almost everything.
> 
> 
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

41 matches

Mail list logo