[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.0.0.0.beta1'

[Christian Lohmaier]

Tag 'libreoffice-6.0.0.0.beta1' created by Christian Lohmaier 
 at 2017-11-25 16:16 +

Tag libreoffice-6.0.0.0.beta1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaGZdqAAoJEPQ0oe+v7q6j/zIP/2Fr9PswUt0QXbIWrHROLAy7
XEWdbosXPKTcvmoRwM6Y/qWPFgfUCEUOdhXfwl3y5dcIZMnTwSH037cCAus0BK9E
cxP+zww1u+n1iq7eNc9NEVeyg+5m921oW4J7bKKXyDCOsLMjn8N0DnnUya8hy/eh
o6kRQ+cQJERTGmGsPj1s00Y4w3RlrVWFwOp+jSTY6e7Cl+4qBlfL0Y/PIE0EvDV/
RkKJOY0nPlWZHGkMKw4fKx9Tllp0EG0RrxNVbT5hM3L8hSb8pnVlPwDxzvifugFN
qXlMJX2IDIvREm3RgDzvAgiXf+ibA6CIEA+jjDd0pEnIymfAQZKpLPlxuss9h0RC
2mTYE4ynPozKGrHPtB9KvsmaxgEANE9A0jZNOzkrA9lBJf9fK9aeLEXV+UuLGUdS
aEcRbo5CJZGIxjbdPead6yYteQ2G0vcYSunblYdV1sC2lpaFV4CzA+Wd7Scop5mv
dpGulbg2Cg+7LeeNkqIPl1Nt3piLgJHCZli8wIDI3M9WB0yHqXQyRf+i5ryz3g2+
G4BaAD5WMoA+JAdkW5pC8w8ZwWzWGSaytRbZ9s1WkINfdV6uv9yf0IsHxIx7mhnd
Qbfs/Jt63XnWOOhYSUUwb0zN3NR6SJK7+7C9hmqTL6rasdqCL/+datTkxAyiJ9p8
CkJg/4aWbFEiOwzCk4fY
=eKJA
-END PGP SIGNATURE-

Changes since gpg4libre-review-5.4.99-1957:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

CppCheck Report Update

[cppcheck.libreoff...@gmail.com]

A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2017-26-11_02:19:28 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
21 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1423309:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/unoidl/SdUnoDrawView.cxx: 95 in 
sd::SdUnoDrawView::getActiveLayer()()



*** CID 1423309:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/unoidl/SdUnoDrawView.cxx: 95 in 
sd::SdUnoDrawView::getActiveLayer()()
89 mrDrawViewShell.ChangeEditMode (
90 mrDrawViewShell.GetEditMode(),
91 bLayerMode);
92 }
93 }
94 
>>> CID 1423309:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown 
>>> but the throw list "throw()" doesn't allow it to be thrown. This will cause 
>>> a call to unexpected() which usually calls terminate().
95 Reference SdUnoDrawView::getActiveLayer() throw ()
96 {
97 Reference xCurrentLayer;
98 
99 do
100 {



To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyCUHqvh-2F4bYa-2BfV9m86WqrQgdp8cEgI-2FpmJ4QclW3n-2BIOTQ9woZZynnTNobrko1kTVe3O45n61MQ-2FlsN9ZdeF5ZGn5JVn3D1x5k99aiiXqxvjwNjZAcAvT2-2F7Bgn-2BytwKT1LAN0phmWim5ixDRlbLwtNxTMCjbhj4h6zfcouAhxg-3D

To manage Coverity Scan email notifications for 
"libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyCUHqvh-2F4bYa-2BfV9m86WqrUfrjrPmpXtojMrhkdgmHAIWCbDIq8bpUQwD2kT58S7YccfW9jXghYKOicM45kMhVtM9A1FXlvrRvQfyuoalDn2iYyafBfSrFrW4g86sWAhvqimjlne616-2FmYF2w9518fPXFxr3RSoLfJwU-2Bvc-2Fyz7g-3D

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/filter/ww8/ww8scan.cxx |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

New commits:
commit 25622034bcef0b6bc3a8e6c150189f85672b2c9e
Author: Caolán McNamara 
Date:   Sat Nov 25 15:03:02 2017 +

ofz#4419 Integer-overflow

Change-Id: I922fb5195e2ed9311ada006beac6918136154a19
Reviewed-on: https://gerrit.libreoffice.org/45270
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 4991e63fb6f5..e52a14b9671a 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -1498,11 +1498,18 @@ WW8_CP WW8ScannerBase::WW8Fc2Cp( WW8_FC nFcPos ) const
 return nFallBackCpEnd;
 }
 
+WW8_FC nFcDiff;
+if (o3tl::checked_sub(nFcPos, m_pWw8Fib->m_fcMin, nFcDiff))
+{
+SAL_WARN("sw.ww8", "broken offset, ignoring");
+return WW8_CP_MAX;
+}
+
 // No complex file
 if (!bIsUnicode)
-nFallBackCpEnd = (nFcPos - m_pWw8Fib->m_fcMin);
+nFallBackCpEnd = nFcDiff;
 else
-nFallBackCpEnd = (nFcPos - m_pWw8Fib->m_fcMin + 1) / 2;
+nFallBackCpEnd = (nFcDiff + 1) / 2;
 
 return nFallBackCpEnd;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Caolán McNamara]

 svx/source/table/tablelayouter.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3d4a0e5cf5b7dca6a62508521849ac3908c2af05
Author: Caolán McNamara 
Date:   Sat Nov 25 15:05:20 2017 +

ofz#4422 Integer-overflow

Change-Id: I1f3a09e34253de7f7a221e2c88d61c293cb69d03
Reviewed-on: https://gerrit.libreoffice.org/45271
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svx/source/table/tablelayouter.cxx 
b/svx/source/table/tablelayouter.cxx
index 2b150e365456..e0ba76552c61 100644
--- a/svx/source/table/tablelayouter.cxx
+++ b/svx/source/table/tablelayouter.cxx
@@ -85,7 +85,7 @@ basegfx::B2ITuple TableLayouter::getCellSize( const CellRef& 
xCell, const CellPo
 if( ((sal_Int32)maRows.size()) <= aPos.mnRow )
 break;
 
-height += maRows[aPos.mnRow++].mnSize;
+height = o3tl::saturating_add(height, 
maRows[aPos.mnRow++].mnSize);
 nRowSpan--;
 }
 
@@ -96,7 +96,7 @@ basegfx::B2ITuple TableLayouter::getCellSize( const CellRef& 
xCell, const CellPo
 if( ((sal_Int32)maColumns.size()) <= aPos.mnCol )
 break;
 
-width += maColumns[aPos.mnCol++].mnSize;
+width = o3tl::saturating_add(width, 
maColumns[aPos.mnCol++].mnSize);
 nColSpan--;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - cppuhelper/source ios/CustomTarget_iOS_setup.mk ios/loApp.xcconfig.in

[jan Iversen]

 cppuhelper/source/servicemanager.cxx |2 ++
 ios/CustomTarget_iOS_setup.mk|   17 +
 ios/loApp.xcconfig.in|   27 ---
 3 files changed, 3 insertions(+), 43 deletions(-)

New commits:
commit 6eeac3539ea4cac32d126c5e24141f262eb5a4d9
Author: jan Iversen 
Date:   Sat Nov 25 17:02:01 2017 +0100

iOS, simplifyModule in cppuhelper is unused

function simplifyModule is reported unused == error on iOS,
therefore guarded with an #ifndef IOS

Change-Id: I751cf68bd46ed17032251fede030f9082ce4e4f5

diff --git a/cppuhelper/source/servicemanager.cxx 
b/cppuhelper/source/servicemanager.cxx
index 163e0e631d37..09e555a4ff43 100644
--- a/cppuhelper/source/servicemanager.cxx
+++ b/cppuhelper/source/servicemanager.cxx
@@ -1809,6 +1809,7 @@ cppuhelper::ServiceManager::findServiceImplementation(
 }
 
 /// Make a simpler unique name for preload / progress reporting.
+#ifndef IOS
 static rtl::OUString simplifyModule(const rtl::OUString )
 {
 sal_Int32 nIdx;
@@ -1833,6 +1834,7 @@ static rtl::OUString simplifyModule(const rtl::OUString 
)
 edit.remove(0,3);
 return edit.makeStringAndClear();
 }
+#endif
 
 /// Used only by LibreOfficeKit when used by Online to pre-initialize
 void cppuhelper::ServiceManager::preloadImplementations() {
commit 64c38401971eba6b7c2eb6dc1af978c8a6110ef8
Author: jan Iversen 
Date:   Sat Nov 25 13:10:41 2017 +0100

iOS, remove app xcconfig

This is now handled directly in the project

Change-Id: I1a57521ff8fe733d56154d186c98f68556128ebd

diff --git a/ios/CustomTarget_iOS_setup.mk b/ios/CustomTarget_iOS_setup.mk
index f32e85be3b9f..b6796d5d4721 100644
--- a/ios/CustomTarget_iOS_setup.mk
+++ b/ios/CustomTarget_iOS_setup.mk
@@ -8,7 +8,6 @@
 #- Env 
 IOSGEN := $(SRCDIR)/ios/generated
 IOSRES := $(IOSGEN)/resources
-IOSAPPXC := $(WORKDIR)/ios/loApp.xcconfig
 
 
 #- Top level  -
@@ -16,25 +15,11 @@ $(eval $(call gb_CustomTarget_CustomTarget,ios/iOS_setup))
 
 
 
-$(call gb_CustomTarget_get_target,ios/iOS_setup): $(IOSAPPXC) 
$(IOSGEN)/native-code.h
+$(call gb_CustomTarget_get_target,ios/iOS_setup): $(IOSGEN)/native-code.h
 
 
 
 #- Generate dynamic files  ---
-$(IOSAPPXC): $(SRCDIR)/ios/loApp.xcconfig.in $(BUILDDIR)/config_host.mk 
$(SRCDIR)/ios/CustomTarget_iOS_setup.mk
-   $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),ENV,2)
-   @mkdir -p $(WORKDIR)/ios
-   sed -e "s'@BUILDDIR@'$(BUILDDIR)'g" \
-   -e "s'@INSTDIR@'$(INSTDIR)'g" \
-   -e "s'@SRCDIR@'$(SRC_ROOT)'g" \
-   -e "s'@WORKDIR@'$(WORKDIR)'g" \
-   -e "s'@CFLAGS@'$(gb_GLOBALDEFS)'g" \
-   -e "s'@CPLUSPLUSFLAGS@'$(gb_GLOBALDEFS)'g" \
-   -e "s'@SYMROOT@'$(WORKDIR)/ios/build'g" \
-   $(SRCDIR)/ios/loApp.xcconfig.in > $(IOSAPPXC)
-
-
-
 $(IOSGEN)/native-code.h: $(BUILDDIR)/config_host.mk 
$(SRCDIR)/ios/CustomTarget_iOS_setup.mk
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),ENV,2)
mkdir -p $(IOSGEN) $(IOSRES) $(IOSRES)/services \
diff --git a/ios/loApp.xcconfig.in b/ios/loApp.xcconfig.in
deleted file mode 100644
index 0c0fc98dac79..
--- a/ios/loApp.xcconfig.in
+++ /dev/null
@@ -1,27 +0,0 @@
-//
-// This file is part of the LibreOffice project.
-//
-// This Source Code Form is subject to the terms of the Mozilla Public
-// License, v. 2.0. If a copy of the MPL was not distributed with this
-// file, You can obtain one at http://mozilla.org/MPL/2.0/.
-//
-// Xcode configuration properties
-LO_BUILDDIR = @BUILDDIR@
-LO_INSTDIR = @INSTDIR@
-LO_SRCDIR = @SRCDIR@
-LO_WORKDIR = @WORKDIR@
-OTHER_CFLAGS = @CFLAGS@
-OTHER_CPLUSPLUSFLAGS = @CPLUSPLUSFLAGS@
-SYMROOT = @SYMROOT@
-
-//:configuration = Debug
-LINK_LDFLAGS= $(LO_SRCDIR)/ios/generated/libLibreOfficeKit_ARM64_debug.a -g
-
-//:configuration = Release
-LINK_LDFLAGS= $(LO_SRCDIR)/ios/generated/libLibreOfficeKit_ARM64.a
-
-//:configuration = Simulator
-LINK_LDFLAGS= $(LO_SRCDIR)/ios/generated/libLibreOfficeKit_X86_64_debug.a -g
-
-//:completeSettings = some
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

[Tor Lillqvist]

 sc/inc/colorscale.hxx|6 ++---
 sc/inc/conditio.hxx  |   29 +++
 sc/qa/unit/helper/shared_test_impl.hxx   |6 ++---
 sc/qa/unit/subsequent_filters-test.cxx   |   16 +++---
 sc/source/core/data/colorscale.cxx   |   12 +--
 sc/source/core/data/conditio.cxx |   24 +++---
 sc/source/core/data/table2.cxx   |6 ++---
 sc/source/filter/excel/xecontent.cxx |   10 -
 sc/source/filter/excel/xeextlst.cxx  |8 +++
 sc/source/filter/excel/xestyle.cxx   |6 ++---
 sc/source/filter/inc/orcusinterface.hxx  |2 -
 sc/source/filter/oox/extlstcontext.cxx   |2 -
 sc/source/filter/orcus/interface.cxx |   24 +++---
 sc/source/filter/xml/xmlexprt.cxx|   10 -
 sc/source/ui/condformat/condformatdlg.cxx|   10 -
 sc/source/ui/condformat/condformathelper.cxx |   10 -
 sc/source/ui/unoobj/condformatuno.cxx|   10 -
 sc/source/ui/unoobj/fmtuno.cxx   |2 -
 18 files changed, 94 insertions(+), 99 deletions(-)

New commits:
commit 2618e4a13d719122e6358d9d96864d1691e56a02
Author: Tor Lillqvist 
Date:   Thu Nov 23 18:21:42 2017 +0200

Convert ScFormatEntryType to scoped enum

Change-Id: I9a6b3fb05255630852a96ebf74d901b869a581f4
Reviewed-on: https://gerrit.libreoffice.org/45276
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/sc/inc/colorscale.hxx b/sc/inc/colorscale.hxx
index 0d33f1bb7146..19f00d7087e8 100644
--- a/sc/inc/colorscale.hxx
+++ b/sc/inc/colorscale.hxx
@@ -275,7 +275,7 @@ public:
 virtual void UpdateDeleteTab( sc::RefUpdateDeleteTabContext& rCxt ) 
override;
 virtual void UpdateMoveTab( sc::RefUpdateMoveTabContext& rCxt ) override;
 
-virtual condformat::ScFormatEntryType GetType() const override;
+virtual Type GetType() const override;
 ScColorScaleEntries::iterator begin();
 ScColorScaleEntries::const_iterator begin() const;
 ScColorScaleEntries::iterator end();
@@ -313,7 +313,7 @@ public:
 virtual void UpdateDeleteTab( sc::RefUpdateDeleteTabContext& rCxt ) 
override;
 virtual void UpdateMoveTab( sc::RefUpdateMoveTabContext& rCxt ) override;
 
-virtual condformat::ScFormatEntryType GetType() const override;
+virtual Type GetType() const override;
 
 /**
  * Makes sure that the mpFormatData does not contain valid entries.
@@ -375,7 +375,7 @@ public:
 virtual void UpdateDeleteTab( sc::RefUpdateDeleteTabContext& rCxt ) 
override;
 virtual void UpdateMoveTab( sc::RefUpdateMoveTabContext& rCxt ) override;
 
-virtual condformat::ScFormatEntryType GetType() const override;
+virtual Type GetType() const override;
 
 static const ScIconSetMap g_IconSetMap[];
 static BitmapEx& getBitmap(sc::IconSetBitmapMap& rBitmapMap, ScIconSetType 
eType, sal_Int32 nIndex);
diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index 9094add488ab..bad7b3dba18c 100644
--- a/sc/inc/conditio.hxx
+++ b/sc/inc/conditio.hxx
@@ -113,20 +113,6 @@ class ScConditionalFormat;
 struct ScDataBarInfo;
 struct ScIconSetInfo;
 
-namespace condformat
-{
-
-enum ScFormatEntryType
-{
-CONDITION,
-COLORSCALE,
-DATABAR,
-ICONSET,
-DATE
-};
-
-}
-
 struct ScCondFormatData
 {
 ScCondFormatData():
@@ -146,7 +132,16 @@ public:
 ScFormatEntry(ScDocument* pDoc);
 virtual ~ScFormatEntry() {}
 
-virtual condformat::ScFormatEntryType GetType() const = 0;
+enum class Type
+{
+Condition,
+Colorscale,
+Databar,
+Iconset,
+Date
+};
+
+virtual Type GetType() const = 0;
 virtual void UpdateReference( sc::RefUpdateContext& rCxt ) = 0;
 virtual void UpdateInsertTab( sc::RefUpdateInsertTabContext& rCxt ) = 0;
 virtual void UpdateDeleteTab( sc::RefUpdateDeleteTabContext& rCxt ) = 0;
@@ -266,7 +261,7 @@ public:
 
 boolMarkUsedExternalReferences() const;
 
-virtual condformat::ScFormatEntryType GetType() const override { return 
condformat::CONDITION; }
+virtual Type GetType() const override { return Type::Condition; }
 
 virtual ScFormatEntry* Clone(ScDocument* pDoc) const override;
 
@@ -382,7 +377,7 @@ public:
 const OUString& GetStyleName() const { return maStyleName;}
 void SetStyleName( const OUString& rStyleName );
 
-virtual condformat::ScFormatEntryType GetType() const override { return 
condformat::DATE; }
+virtual Type GetType() const override { return Type::Date; }
 virtual void UpdateReference( sc::RefUpdateContext& ) override {}
 virtual void UpdateInsertTab( sc::RefUpdateInsertTabContext& ) override {}
 virtual void UpdateDeleteTab( sc::RefUpdateDeleteTabContext& ) override {}
diff --git a/sc/qa/unit/helper/shared_test_impl.hxx 

Re: unrestricted access

[Markus Mohrhard]

Hey,

On Fri, Nov 24, 2017 at 8:45 AM, Valerii Goncharuk  wrote:

> Hi,
>
> Can I get unrestricted commit access?
> My patches are
> https://gerrit.libreoffice.org/gitweb?p=core.git;a=search;h=
> 014a3ab73683f4e190f5e2dd26788ee1a3a0d683;s=lera.goncharuk@
> gmail.com;st=author
>

Usually getting full commit access happens after one or several experienced
developers have reviewed a number of your patches and are mostly happy with
what they have seen. Keep in mind that full commit access does not mean
that you should push directly to the repository. The biggest difference is
that we trust you to judge when your own code and the code of other people
is in a state that it can be merged.
In general I think people nowadays expect too much from getting full commit
access. We no longer use the wild west development style that we used in
the beginning of the project and even experienced developers are nowadays
expected to use CI and possibly get a review of a controversial patch.

Looking through your patch list I think there is still a bit missing. There
are only 5 patches in the last 3 months and overall not that many patches
to the core repository at all. Keep up the good work and show that you
understand the development process, provide some good patches and at some
point the ESC will ask you if you are happy with getting commit access.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6-0-branch-point'

[David Tardon]

Tag 'libreoffice-6-0-branch-point' created by Christian Lohmaier 
 at 2017-11-25 22:58 +

Tag libreoffice-6-0-branch-point
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaGfWiAAoJEPQ0oe+v7q6jKcoQANJjNzn+wPDxl0Xv3wDRZFJK
bDqVDXWxpLxN5Au4KJ6HkOqGfEbITU6yrbdS88/OG5WpNB3Bma6Bmm+OysQs6FS+
12R49whZekxhWfU8SMBwESNtaP6C7eW9bxUFpfOuXF9Eo9N85TzGoRY3E4gLeOef
pPgeZ6hdC8kw5v8wyVnc/PnaKg10MRCW2WAicD9MOagqhY6+D8a9pT87m/mUCy6k
1iOZSRwTYITxsmtoc+Kgqki2FAmC8YZBs+/d1E+wSSWVcrK/MPCszZXqoCumTyFQ
t6Va5g5OBv55jNSiatdIsXR8fNm/XxTs9VZSZoNKS1W9jO6vfZPMXVtDFQERqJWK
JGVV7x/HxFVeC7AWHnw+2gU3NnFcHX7TZQEUPDH8noliuYZxR/tFsuuAKSZjlYxp
pCefSivcUcIIsDS1vt/gbDBfRpmTzfx2pZ3Fq4wwyHrdhbeAOnBRSf4Rpm3twlGZ
oKyma8P6TfJeXfmWZU+yCMySsS7UjXh53rZEtWlacFFKZmWCCc9Ac9edEMeva9ES
8wG7YQo9wqGRZwmHZ5kaBBhXEAQiRWLFCjhTS76jWWA60kiUAzG/SkLxRnAf0ZAd
Dl1ynazDouP/0GhmCbttJw+Vk2Y1uxE+XHmD1AJ+TCo7d1HTUWtjKVoHkaclh25q
tsT++9/MQFAlw2R5Nock
=PvPQ
-END PGP SIGNATURE-

Changes since libreoffice-5-4-branch-point-198:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6-0-branch-point'

[jan Iversen]

Tag 'libreoffice-6-0-branch-point' created by Christian Lohmaier 
 at 2017-11-25 22:58 +

Tag libreoffice-6-0-branch-point
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaGfWpAAoJEPQ0oe+v7q6joqAP/3A/I7Xkfv3lmBCEVtyWO63b
aAhyJIR5IprwH4BJ61v+VF8G9khxGWQzhA+jyUyXJtdeYp0OE1c+PH8//RLXEz5K
dEXOSH3VIuzVFfhnPSvfvlcKw/WH9jkw/aQGgAVdgWC+RjYLFAY0pZQDbRxsPB70
iFn3vReWEF5epm2h4nZZDy7Dqh2ZB4LoSegLudzw5zo8Ajh5XcVeyCE7jt2c6yA9
RiS0z6xe2Xz0GJpMf0/nkbfLwCuRfE1io3LcSXeHPjuQFPdG9drIP7nnYklji9gG
afTFUOZ2L33MpE9iav5CQ53jEBK28v+wPrOo7b+2dbA+h5uefI8o+JGfhA7egWsD
930OISacqrb8/O8rBy1l+2WuaqjzXQw3Dgbd17rXltJyX4FEP7MQS5aITUZmMQFl
8W2ZrAxevnG70kXfSM6w7O0ZBdXuEyPGYjuPuDzLf8LqXGN91qu/tUu7YAaJOazY
4l9wI+RtSGhNwETZwGDoNhkuI5l6WO/WEVxaOVsYxP0QRvM3/IdhSwwMP8rb+huX
HM0aa1mJ5bojjAicPLVvaZSh4H077phhONvqxYkJfTImyG92ZBT71kx0KKVhJMZp
D8VOn0aGVj8251QUk6sQIxLGNFOKAI0wjMEU/pFJPtKFtE0pgdYCfzusOU0Yp610
nCcAcP2cAvn2CYBXzd5h
=9S1a
-END PGP SIGNATURE-

Changes since gpg4libre-review-5.4.99-1954:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6-0-branch-point'

[László Németh]

Tag 'libreoffice-6-0-branch-point' created by Christian Lohmaier 
 at 2017-11-25 22:58 +

Tag libreoffice-6-0-branch-point
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaGfWdAAoJEPQ0oe+v7q6jKLkP/i+zb9ZHKPEu60KgaJ3w0wKJ
gAiA8nhTiNgPFzCIVfvmuufNHgtXiJ8CUUwR156LqXSfIKf+sqoJA2peuxkyoB6K
vRWmWd7GAcMEneO4Q3qTsqpIocNBkHqHw4dOjnjMWFe4TBy3t5CYCICZ0F2vp1+i
6MDHF3TG0WLfXeDGmWdJJ/7ljrfJ1gDDmn4dlNPqP6iqNwjCl/ZG2WXlIrNyL2Ao
93Iy/Tjw/ydBqENM3BeTwbXp3MUWZeEpfdecjc4QSulid7D7qgeGbtgIz7X6LRDQ
Och9Ck1/eRnoKM2N/1XDN2BXPtLx9eYcFQ9/JivH/IcTlGtjkfvVrjLiYOsPbJAw
I0JzGlmB9Ib72KDaCyILVjnTxFmDMR9s3CVCi5fwPvxhwVJmKqjmONdzvN7cOzqo
GfDu2kuTXnRr6SlGGYp2eGP8DU5RRFC11HgwTC+byBKwWf/5dR1XaXqTiF1indDc
OLxdvEvKu6FK9iZIcGldK50udpLIup/eaIXJn5/IukcazAtGlVAUSNytN//Ultd4
vsPbXzbuP6y4EbJxGOxOOcfv2i1pJhGWOax9DKTHHuED17F1WypMw/8QmGkpL1Of
Gl8qdKmWPNdUnEzThTnQD3I/1vTb6LxY5OTOrXLNelChLfdtT9dVtzT0hv35xPDF
F2iBeGOQ+/i/g8nov2zJ
=IRhx
-END PGP SIGNATURE-

Changes since libreoffice-5-4-branch-point-13:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6-0-branch-point'

[Christian Lohmaier]

Tag 'libreoffice-6-0-branch-point' created by Christian Lohmaier 
 at 2017-11-25 22:58 +

Tag libreoffice-6-0-branch-point
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaGfWmAAoJEPQ0oe+v7q6jNkMQAIA4hrHV7YmHxJenHlzQ+b+/
IWIFT0QYgi9iVcFjId5rE+pMYiX5vjg+jcuJBeSShIK6JfLsrKiG/D+szgQ/Q9o1
VBsW9sd5lWuOjUnmDrBACDkMtbyfs6bcyHqHngfzQhaIwqhbXpcndJ47N4TDni2E
pLdCUY3id6XVEhW4Uf55NilWIbbQ3xEMctz+I2DTHGhMLmhiD/qdqd5liLYxHQa7
1AeTEOT007U+JP+GxGinDvVeRHS4PFIbr0FrhZOyqyYfeIS9SnHbzhUDJ0ZE/vNq
pwXsQNgM8Yt1+8V8EFzSurtvguji2X6B2GrfV3S2u45Xhp9u4lRwaT4RBEQAzPnN
6+6S4gULOuwp8JqKvmv8Be8IbmdQi7GDP/wAKN6GoUG54zCm/YhSlucjjjZAWsjO
j2SfAZlLYSGMvh774VYc0ctp2niU9+C0NTZqi3NJYjXqvTvfo7RLhwfa1zRhmIUC
jGWAiCQXXIxfVB16LQ9iZDy6lqvJZl1Bfk88gf1hJcLD213FuF0Gjh5fj4BPqJHu
t+PFAKQ9H52TsWUG3WIp3gbhzaLAd6pE3F/SZbdmUuH5QJN6L6IxToVbCp2+IKx9
z0HnwMrJW9RA6HGWGeh6seHdHI2VXmtTy2+lELVoJvtt1XFgibmERl1S2Emcui0I
hWQk71hByZETkQIzm5oB
=1cZY
-END PGP SIGNATURE-

Changes since libreoffice-5-4-branch-point-21:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - configure.ac

[Christian Lohmaier]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9d952bdfbd226cadd15cb7ee28188c0e2b75f747
Author: Christian Lohmaier 
Date:   Sat Nov 25 17:17:25 2017 +0100

bump product version to 6.0.0.0.beta1+

Change-Id: Ied8e3648bd67ab9a85f8cc77b1797d04e0274471

diff --git a/configure.ac b/configure.ac
index a4140c7b7f24..c5adc3aa5aa9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.0.0.0.alpha1+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.0.0.0.beta1+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.0.0.0.beta1'

[Christian Lohmaier]

Tag 'libreoffice-6.0.0.0.beta1' created by Christian Lohmaier 
 at 2017-11-25 16:16 +

Tag libreoffice-6.0.0.0.beta1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaGZdgAAoJEPQ0oe+v7q6jze4P/A24y3KKl8XsWYopORH5/gid
43M41oL1SyEcY8t0QQl7UPgkxkQdctjbu5wJ0iKpW502XgYGcX9X9OjMAWqWXBRQ
5R37p/AeCYEmRwv4wxTiwx0Yyy9EcbcJQZ8/WtE3fBU84bxPFsnEvK1jlXOfsNQa
jcnmOHXUurIPM0OzbnuoeZeS4RMRoq5Oaf8qaO3pP2Q+kqq7+kMgay/F+y+PPqpS
lslJ6YTw5VauZYCNP/bGUil5SgQahSBz5G7D9BSjgCQ+FanqTeM+wBRjMfUSVUX3
5Q2boYQ2/FRSEbj5UVbnPzMJEL/FS089hF6+N5tiRe4xxUkOjptLpv8UlySj/Huy
Hk9NM7+Ni4LRyzuxM9jOOgWfZYn2tfqnB8ysX6N48EoAegxwPk2ZhVlHLDnOgCSE
nOOzwaW3phg6af3hVA7vI9IqaEDbZ38aFppLJxlvHx1fY93Xa0hDxQSUX0iuBlBl
XOv4hX1FH8M5DisLh16te9Hy5n1DqtAphX7dX+RBWlNY0YgSV77Hc5it9gKzWXUk
NimigJXuW19h7U/Z12vdXABO71zS57896M8kHsdMjeqsd2sCAgP9M8TvTP85CcLh
dofdQp1AUIVL0LeKrMsFaqlzV+I3o3aOcSU9plyxF9kXgAPBbarmmsuY2Aa+iFZ7
wKzy5u79p99CiV7mAWjp
=+a3H
-END PGP SIGNATURE-

Changes since libreoffice-5-4-branch-point-15:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.0.0.0.beta1'

[Christian Lohmaier]

Tag 'libreoffice-6.0.0.0.beta1' created by Christian Lohmaier 
 at 2017-11-25 16:16 +

Tag libreoffice-6.0.0.0.beta1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaGZdkAAoJEPQ0oe+v7q6jiQAP/3CbwXKEICZVICTrzkkkPTfT
JlQ42rlSbk2gd2b5gO9wUWyAuVQY2o+blqT6aq3D1w29SI7g+HFvVj43bey6VmW9
RaGEukK6y0oCwF5g+t5itp1Aavi9HuGWA3/aZpOEsR4JTbRisOj631pfN0iV6zQo
A1ZaCjm9tSUHOWhImtgHpdLf4vz9mTjoBvqcK8QRa0e0pfS4TBysxecwqfu/ozdk
LW7cIeXA44ziDgs1LB6VXAocsRRcFAekmWIqMu5m1K5/GIZ/exXBIf116eJ9AWMi
9MshIi3MUsdrdVJVbWexPSsHVLvhJYywEQ+H63GPV9ikxPAq1IFJ5xUA7T8IFr5F
t3uK3U/5XcYrvXNyA0nYn1+xmJkJ5Hi7vL3tedLu0h2/Npzs7790gHkMNTEU09gB
N/glt3tzgdIVDf4MVW0I9viRsHBd8zvB3FpYnZLd6hIgKRL0+SqOffwmwTP6uvOy
eGNXTa5KQRQn3IILggxWExQp5uV44mtW1OlHkZ9AQy8I4EOVqZewG1UFD2G/V5C4
pq6LzMrivYlytuDdCe3N/26jLq/CNYVxc7sHRiLEAumBQlcFBEB02Qbp/uSNA1ng
48PV0srfVXi7NNpVQYZkHmsDsC3K5nvrgn85GwKpMtnAeagmHmzXhAWU7I3Ll1dx
a+T6C6GZPO0kmQC2Ij1t
=0b7n
-END PGP SIGNATURE-

Changes since libreoffice-5-4-branch-point-200:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.0.0.0.beta1'

[Christian Lohmaier]

Tag 'libreoffice-6.0.0.0.beta1' created by Christian Lohmaier 
 at 2017-11-25 16:16 +

Tag libreoffice-6.0.0.0.beta1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaGZdnAAoJEPQ0oe+v7q6jDiQP/As+X9vU73G+d7pa8ix66nZd
J8sroFSzWBqCzt6wPSCTamA4GOcEcgWKYWWNx1UnqWctqyaLxLnt2d5XQ1ehlXs2
yqmPHNxaiF4RKqQgpLmeUsts3xWE3R6KVTNO2dI6JqR5yhsKaRUePwCx5v8z6AXv
kh/pj0mkpdd7icBh5S7wmh9aUuUIRctgA//KjyF25GKfmAL45bKippoYCrT1Z8CH
ZHX1nvshc9cAx3wy0YiLuQyAAfL7JIrO+6EBD6tHRVKOMS5Uab//00daa/Q38VAX
FGcl6TZRSVk3rWHPgDFuQHUHTQ2rECVjb6Id11s0k9mvSD65jW+jfcCHCDENC0Nt
YESY/96PJTgKdomwkJWn/QtcrGR7pv56e+qYBV5+j20qKqXZ7Q3AHS/iRDCVBvYu
PI+moQJFA3DizFFXQavIvBx07iVhZz2y3nGX10pz4d7OzyO17cqjxbpvLL1fUfyN
+ByA5DLqAkskiyiR8NElbbGjomcM0nWUwJ3ER0dk7QXhwDH1R6V77HihAxGH64Uf
X+XD+u5sbZOd1pT47BQTVFJc77iJUs/46p1K5S4f4jtR+eWOeDMLYlCbFr9FKpwU
kkgj5mQ5Y9r0wzEnx1zPGvyQKfg+AoltcDxbf9IWKd5Q2Sg14JBeNWObaD04JsSV
Imfhdu9CpwLSBclmPFUh
=eGM+
-END PGP SIGNATURE-

Changes since libreoffice-5-4-branch-point-24:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: codemaker/source

[Julien Nabet]

 codemaker/source/javamaker/classfile.cxx |8 
 codemaker/source/javamaker/classfile.hxx |5 ++---
 codemaker/source/javamaker/javatype.cxx  |5 ++---
 3 files changed, 8 insertions(+), 10 deletions(-)

New commits:
commit 10593acac0bc42878fea34fe7da3f389f256c317
Author: Julien Nabet 
Date:   Sat Nov 25 18:33:25 2017 +0100

Replace most lists by vectors in codemaker

Change-Id: Id867b497514d2d795504ae5c9e7d0ad356524ad5
Reviewed-on: https://gerrit.libreoffice.org/45274
Reviewed-by: Noel Grandin 
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/codemaker/source/javamaker/classfile.cxx 
b/codemaker/source/javamaker/classfile.cxx
index 37858991edec..1df31aea6947 100644
--- a/codemaker/source/javamaker/classfile.cxx
+++ b/codemaker/source/javamaker/classfile.cxx
@@ -227,12 +227,12 @@ void ClassFile::Code::instrInvokevirtual(
 
 void ClassFile::Code::instrLookupswitch(
 Code const * defaultBlock,
-std::list< std::pair< sal_Int32, Code * > > const & blocks)
+std::vector< std::pair< sal_Int32, Code * > > const & blocks)
 {
 // lookupswitch <0--3 byte pad>   

 // 
 // :
-std::list< std::pair< sal_Int32, Code * > >::size_type size = 
blocks.size();
+std::vector< std::pair< sal_Int32, Code * > >::size_type size = 
blocks.size();
 if (size > SAL_MAX_INT32) {
 throw CannotDumpException("Lookup-switch too large for Java class file 
format");
 }
@@ -312,7 +312,7 @@ void ClassFile::Code::instrSwap() {
 
 void ClassFile::Code::instrTableswitch(
 Code const * defaultBlock, sal_Int32 low,
-std::list< Code * > const & blocks)
+std::vector< Code * > const & blocks)
 {
 // tableswitch <0--3 byte pad>   
 //  
@@ -323,7 +323,7 @@ void ClassFile::Code::instrTableswitch(
 for (int i = 0; i < pad; ++i) {
 appendU1(m_code, 0);
 }
-std::list< Code * >::size_type size = blocks.size();
+std::vector< Code * >::size_type size = blocks.size();
 Position pos2 = pos1 + 1 + pad + 12 + size * 4; //FIXME: overflow
 sal_uInt32 defaultOffset = static_cast< sal_uInt32 >(pos2 - pos1);
 //FIXME: overflow
diff --git a/codemaker/source/javamaker/classfile.hxx 
b/codemaker/source/javamaker/classfile.hxx
index 6e5466d5b701..be6e3a36abe4 100644
--- a/codemaker/source/javamaker/classfile.hxx
+++ b/codemaker/source/javamaker/classfile.hxx
@@ -23,7 +23,6 @@
 #include 
 #include 
 
-#include 
 #include 
 #include 
 #include 
@@ -89,7 +88,7 @@ public:
 
 void instrLookupswitch(
 Code const * defaultBlock,
-std::list< std::pair< sal_Int32, Code * > > const & blocks);
+std::vector< std::pair< sal_Int32, Code * > > const & blocks);
 
 void instrNew(rtl::OString const & type);
 void instrNewarray(codemaker::UnoType::Sort sort);
@@ -108,7 +107,7 @@ public:
 
 void instrTableswitch(
 Code const * defaultBlock, sal_Int32 low,
-std::list< Code * > const & blocks);
+std::vector< Code * > const & blocks);
 
 void loadIntegerConstant(sal_Int32 value);
 void loadStringConstant(rtl::OString const & value);
diff --git a/codemaker/source/javamaker/javatype.cxx 
b/codemaker/source/javamaker/javatype.cxx
index dae125e7a3bb..71f4faa16117 100644
--- a/codemaker/source/javamaker/javatype.cxx
+++ b/codemaker/source/javamaker/javatype.cxx
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -752,7 +751,7 @@ void handleEnumType(
 std::unique_ptr< ClassFile::Code > defCode(cf->newCode());
 defCode->instrAconstNull();
 defCode->instrAreturn();
-std::list< ClassFile::Code * > blocks;
+std::vector< ClassFile::Code * > blocks;
 //FIXME: pointers contained in blocks may leak
 sal_Int32 last = SAL_MAX_INT32;
 for (const auto& pair : map)
@@ -779,7 +778,7 @@ void handleEnumType(
 std::unique_ptr< ClassFile::Code > defCode(cf->newCode());
 defCode->instrAconstNull();
 defCode->instrAreturn();
-std::list< std::pair< sal_Int32, ClassFile::Code * > > blocks;
+std::vector< std::pair< sal_Int32, ClassFile::Code * > > blocks;
 //FIXME: pointers contained in blocks may leak
 for (const auto& pair : map )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-6-0'

[Christian Lohmaier]

New branch 'libreoffice-6-0' available with the following commits:
commit 1773e0e987d4ebe4b328b87a40f8f7155d12606d
Author: Christian Lohmaier 
Date:   Sat Nov 25 17:06:49 2017 +0100

Branch libreoffice-6-0

This is 'libreoffice-6-0' - the stable branch for the 6.0.x releases.
The commit rules are different according to the development phase:

A. 6.0.0 beta phase:

   A. any bug fixes are allowed without review
   B. late features need approval by 3 people with different affiliation

B. 6.0.0 rc phase and later:

   A. fixes need approval by one reviewer
   B. late features need approval by 3 more people with different 
affiliation

IMPORTANT: Every developer is responsible for pushing the fixes into all
  appropriate branches. Note that we do not plan any merge
  from this branch to master or vice versa.

Please, help use to make stable and usable release. If you want to build
something cool, unstable, and risky, use master.

Change-Id: I3e5cbfbfa6bec42fa342a6f0878464ca42a2d854

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'libreoffice-6-0'

[Christian Lohmaier]

New branch 'libreoffice-6-0' available with the following commits:
commit 06b521618b1abac6edb0f7131bce92c887767922
Author: Christian Lohmaier 
Date:   Sat Nov 25 17:06:49 2017 +0100

Branch libreoffice-6-0

This is 'libreoffice-6-0' - the stable branch for the 6.0.x releases.
The commit rules are different according to the development phase:

A. 6.0.0 beta phase:

   A. any bug fixes are allowed without review
   B. late features need approval by 3 people with different affiliation

B. 6.0.0 rc phase and later:

   A. fixes need approval by one reviewer
   B. late features need approval by 3 more people with different 
affiliation

IMPORTANT: Every developer is responsible for pushing the fixes into all
  appropriate branches. Note that we do not plan any merge
  from this branch to master or vice versa.

Please, help use to make stable and usable release. If you want to build
something cool, unstable, and risky, use master.

Change-Id: Ibd36568eb070b0c0f5a9e231e80287e8ac12822e

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'libreoffice-6-0'

[Christian Lohmaier]

New branch 'libreoffice-6-0' available with the following commits:
commit c7a86de26fccaaffa80e8ed9141c668cc718dc34
Author: Christian Lohmaier 
Date:   Sat Nov 25 17:06:49 2017 +0100

Branch libreoffice-6-0

This is 'libreoffice-6-0' - the stable branch for the 6.0.x releases.
The commit rules are different according to the development phase:

A. 6.0.0 beta phase:

   A. any bug fixes are allowed without review
   B. late features need approval by 3 people with different affiliation

B. 6.0.0 rc phase and later:

   A. fixes need approval by one reviewer
   B. late features need approval by 3 more people with different 
affiliation

IMPORTANT: Every developer is responsible for pushing the fixes into all
  appropriate branches. Note that we do not plan any merge
  from this branch to master or vice versa.

Please, help use to make stable and usable release. If you want to build
something cool, unstable, and risky, use master.

Change-Id: I44171e038a6887578e79c683781d9b28b828237b

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'libreoffice-6-0'

[Christian Lohmaier]

New branch 'libreoffice-6-0' available with the following commits:
commit b4de69aa53c5baddaf1b375d7c951b77f20a4662
Author: Christian Lohmaier 
Date:   Sat Nov 25 17:07:28 2017 +0100

Branch libreoffice-6-0

This is 'libreoffice-6-0' - the stable branch for the 6.0.x releases.
The commit rules are different according to the development phase:

A. 6.0.0 beta phase:

   A. any bug fixes are allowed without review
   B. late features need approval by 3 people with different affiliation

B. 6.0.0 rc phase and later:

   A. fixes need approval by one reviewer
   B. late features need approval by 3 more people with different 
affiliation

IMPORTANT: Every developer is responsible for pushing the fixes into all
  appropriate branches. Note that we do not plan any merge
  from this branch to master or vice versa.

Please, help use to make stable and usable release. If you want to build
something cool, unstable, and risky, use master.

Change-Id: I393c97653664be3c7757d68fe5a7409319b10e3d

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: bin/oss-fuzz-build.sh bin/sanitize-blacklist.txt

[Caolán McNamara]

 bin/oss-fuzz-build.sh  |2 +-
 bin/sanitize-blacklist.txt |5 +
 2 files changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 5efc05bf398ace1170b3e6e2276d79342f1f607a
Author: Caolán McNamara 
Date:   Sat Nov 25 15:55:18 2017 +

ofz#4424 black list the div by zero calc cases

Change-Id: I30d06e762901027a50586fcd17398d74ab349373
Reviewed-on: https://gerrit.libreoffice.org/45272
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/bin/oss-fuzz-build.sh b/bin/oss-fuzz-build.sh
index 812d632316bd..1dd26028e203 100755
--- a/bin/oss-fuzz-build.sh
+++ b/bin/oss-fuzz-build.sh
@@ -7,7 +7,7 @@ fi
 
 #shuffle CXXFLAGS -stdlib=libc++ arg into CXX as well because we use
 #the CXX as the linker and need to pass -stdlib=libc++ to build
-export CXX="$CXX -stdlib=libc++"
+export CXX="$CXX -stdlib=libc++ 
-fsanitize-blacklist=$SRC/libreoffice/bin/sanitize-blacklist.txt"
 #similarly force the -fsanitize etc args in as well as pthread to get
 #things to link successfully during the build
 export LDFLAGS="$CFLAGS -lpthread"
diff --git a/bin/sanitize-blacklist.txt b/bin/sanitize-blacklist.txt
new file mode 100644
index ..7c97ff4abd51
--- /dev/null
+++ b/bin/sanitize-blacklist.txt
@@ -0,0 +1,5 @@
+[float-divide-by-zero]
+src:*/sc/source/core/tool/interpr1.cxx
+src:*/sc/source/core/tool/interpr2.cxx
+src:*/scaddins/source/analysis/analysis.cxx
+src:*/scaddins/source/analysis/financial.cxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/elementary

[Simon Steinbeiss]

 icon-themes/elementary/res/savemodified_extralarge.png |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 37603b90be911edda5fc1c80bf194b67cf3b89e6
Author: Simon Steinbeiss 
Date:   Thu Nov 23 00:42:02 2017 +0100

elementary-icon-theme: Add missing savemodified icon symlink

Change-Id: I54c16df71ae5b5f4944bb2384fed0c5b205af557
Reviewed-on: https://gerrit.libreoffice.org/45175
Tested-by: Jenkins 
Reviewed-by: Simon Steinbeiß 
Reviewed-by: Heiko Tietze 

diff --git a/icon-themes/elementary/res/savemodified_extralarge.png 
b/icon-themes/elementary/res/savemodified_extralarge.png
new file mode 12
index ..ead8c0d1b067
--- /dev/null
+++ b/icon-themes/elementary/res/savemodified_extralarge.png
@@ -0,0 +1 @@
+savemodified_large.png
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolkitconfig.xcu

[Michael Meeks]

 loolkitconfig.xcu |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 43e2c98d7c83cf0cd983c1479ba2c8a880882f14
Author: Michael Meeks 
Date:   Sat Nov 25 19:10:14 2017 +

Disable word autocomplete by default.

The feature is problematic in terms of editing anyway, and burns RAM.

Change-Id: I3a078c16fb450e7b38e15ad1c76563d130d2b277

diff --git a/loolkitconfig.xcu b/loolkitconfig.xcu
index 712311ac..6edaacc3 100644
--- a/loolkitconfig.xcu
+++ b/loolkitconfig.xcu
@@ -7,4 +7,7 @@
 
 true
 
+
+false
+
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configure.ac

[Christian Lohmaier]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2569e688ed34dac7282e362a6f0432e1e26cfae4
Author: Christian Lohmaier 
Date:   Sat Nov 25 17:10:47 2017 +0100

bump product version to 6.1.0.0.alpha0+

Change-Id: I31fcaac33c773752c845628792e0491c8b8f4ccf

diff --git a/configure.ac b/configure.ac
index a4140c7b7f24..42239059cdcd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.0.0.0.alpha1+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.1.0.0.alpha0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/source

[Tor Lillqvist]

 sc/inc/conditio.hxx  |3 +--
 sc/source/core/data/conditio.cxx |   26 +-
 2 files changed, 14 insertions(+), 15 deletions(-)

New commits:
commit 2e4805442a9eeedb32d6b570c4c11594aca7c642
Author: Tor Lillqvist 
Date:   Thu Nov 23 17:32:40 2017 +0200

Avoid a trivial typedef

Change-Id: Iea8700f168c5d13ebf1b98f435eeabea425b8259
Reviewed-on: https://gerrit.libreoffice.org/45275
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index 10906f0dbacb..9094add488ab 100644
--- a/sc/inc/conditio.hxx
+++ b/sc/inc/conditio.hxx
@@ -409,8 +409,7 @@ class SC_DLLPUBLIC ScConditionalFormat
 ScDocument* pDoc;
 sal_uInt32  nKey;   // Index in attributes
 
-typedef std::vector CondFormatContainer;
-CondFormatContainer maEntries;
+std::vector maEntries;
 ScRangeList maRanges;// Ranges for conditional format
 
 public:
diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx
index 7e2d9a30b372..8170d1fcec6f 100644
--- a/sc/source/core/data/conditio.cxx
+++ b/sc/source/core/data/conditio.cxx
@@ -1778,7 +1778,7 @@ ScConditionalFormat* 
ScConditionalFormat::Clone(ScDocument* pNewDoc) const
 ScConditionalFormat* pNew = new ScConditionalFormat(nKey, pNewDoc);
 pNew->SetRange( maRanges ); // prerequisite for listeners
 
-for (CondFormatContainer::const_iterator itr = maEntries.begin(); itr != 
maEntries.end(); ++itr)
+for (auto itr = maEntries.cbegin(); itr != maEntries.cend(); ++itr)
 {
 ScFormatEntry* pNewEntry = (*itr)->Clone(pNewDoc);
 pNew->maEntries.push_back( std::unique_ptr(pNewEntry) );
@@ -1849,7 +1849,7 @@ const ScFormatEntry* ScConditionalFormat::GetEntry( 
sal_uInt16 nPos ) const
 
 const OUString& ScConditionalFormat::GetCellStyle( ScRefCellValue& rCell, 
const ScAddress& rPos ) const
 {
-for (CondFormatContainer::const_iterator itr = maEntries.begin(); itr != 
maEntries.end(); ++itr)
+for (auto itr = maEntries.cbegin(); itr != maEntries.cend(); ++itr)
 {
 if((*itr)->GetType() == condformat::CONDITION)
 {
@@ -1871,7 +1871,7 @@ const OUString& ScConditionalFormat::GetCellStyle( 
ScRefCellValue& rCell, const
 ScCondFormatData ScConditionalFormat::GetData( ScRefCellValue& rCell, const 
ScAddress& rPos ) const
 {
 ScCondFormatData aData;
-for(CondFormatContainer::const_iterator itr = maEntries.begin(); itr != 
maEntries.end(); ++itr)
+for(auto itr = maEntries.cbegin(); itr != maEntries.cend(); ++itr)
 {
 if((*itr)->GetType() == condformat::CONDITION && 
aData.aStyleName.isEmpty())
 {
@@ -1912,21 +1912,21 @@ void ScConditionalFormat::DoRepaint()
 
 void ScConditionalFormat::CompileAll()
 {
-for(CondFormatContainer::iterator itr = maEntries.begin(); itr != 
maEntries.end(); ++itr)
+for(auto itr = maEntries.cbegin(); itr != maEntries.cend(); ++itr)
 if((*itr)->GetType() == condformat::CONDITION)
 static_cast(**itr).CompileAll();
 }
 
 void ScConditionalFormat::CompileXML()
 {
-for(CondFormatContainer::iterator itr = maEntries.begin(); itr != 
maEntries.end(); ++itr)
+for(auto itr = maEntries.cbegin(); itr != maEntries.cend(); ++itr)
 if((*itr)->GetType() == condformat::CONDITION)
 static_cast(**itr).CompileXML();
 }
 
 void ScConditionalFormat::UpdateReference( sc::RefUpdateContext& rCxt, bool 
bCopyAsMove )
 {
-for(CondFormatContainer::iterator itr = maEntries.begin(); itr != 
maEntries.end(); ++itr)
+for(auto itr = maEntries.cbegin(); itr != maEntries.cend(); ++itr)
 (*itr)->UpdateReference(rCxt);
 
 if (rCxt.meMode == URM_COPY && bCopyAsMove)
@@ -1961,7 +1961,7 @@ void ScConditionalFormat::UpdateInsertTab( 
sc::RefUpdateInsertTabContext& rCxt )
 pRange->aEnd.IncTab(rCxt.mnSheets);
 }
 
-for (CondFormatContainer::iterator it = maEntries.begin(); it != 
maEntries.end(); ++it)
+for (auto it = maEntries.cbegin(); it != maEntries.cend(); ++it)
 (*it)->UpdateInsertTab(rCxt);
 }
 
@@ -1990,7 +1990,7 @@ void ScConditionalFormat::UpdateDeleteTab( 
sc::RefUpdateDeleteTabContext& rCxt )
 pRange->aEnd.IncTab(-1*rCxt.mnSheets);
 }
 
-for (CondFormatContainer::iterator it = maEntries.begin(); it != 
maEntries.end(); ++it)
+for (auto it = maEntries.cbegin(); it != maEntries.cend(); ++it)
 (*it)->UpdateDeleteTab(rCxt);
 }
 
@@ -2027,7 +2027,7 @@ void ScConditionalFormat::UpdateMoveTab( 
sc::RefUpdateMoveTabContext& rCxt )
 }
 }
 
-for (CondFormatContainer::iterator it = maEntries.begin(); it != 
maEntries.end(); ++it)
+for (auto it = maEntries.cbegin(); it != maEntries.cend(); ++it)
 (*it)->UpdateMoveTab(rCxt);
 }
 
@@ -2042,7 +2042,7 @@ void 

[Libreoffice-commits] core.git: uitest/writer_tests

[Rene Engelhard]

 uitest/writer_tests/data/3pages.odt |binary
 1 file changed

New commits:
commit b03f7cdc04f9df778e2da93eadfe1d44f7665caf
Author: Rene Engelhard 
Date:   Sat Nov 25 15:27:25 2017 +0100

fix uitest/writer_tests/data/3pages.odt

This in uitest/writer_tests/goToPage.py is supposed to be a uitest for
"go to page 2 and 3" but uses hardoded enters until page flips over. Looks
overly flaky to me. Replaced by proper page breaks

Change-Id: I8c0ea5809bd24d4122cfd956fcd048af97c01480

diff --git a/uitest/writer_tests/data/3pages.odt 
b/uitest/writer_tests/data/3pages.odt
index 73097d91305e..0f2512903981 100644
Binary files a/uitest/writer_tests/data/3pages.odt and 
b/uitest/writer_tests/data/3pages.odt differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svtools/source

[Caolán McNamara]

 svtools/source/graphic/grfmgr.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit d7b4408886f26c1c66d070918b4c9998a13fb8fe
Author: Caolán McNamara 
Date:   Fri Nov 24 16:52:30 2017 +

coverity#1421068 Uncaught exception

see if using copy ctor rather than default dtor keeps it happy

Change-Id: I539271a569fa769a4cb33f71b8bf871dee810abf
Reviewed-on: https://gerrit.libreoffice.org/45248
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svtools/source/graphic/grfmgr.cxx 
b/svtools/source/graphic/grfmgr.cxx
index b65f092a6964..5d20b4128c6a 100644
--- a/svtools/source/graphic/grfmgr.cxx
+++ b/svtools/source/graphic/grfmgr.cxx
@@ -94,6 +94,7 @@ GraphicObject::GraphicObject(const Graphic& rGraphic)
 GraphicObject::GraphicObject(const GraphicObject& rGraphicObj)
 : maGraphic(rGraphicObj.GetGraphic())
 , maAttr(rGraphicObj.maAttr)
+, maPrefMapMode(rGraphicObj.maPrefMapMode)
 , maLink(rGraphicObj.maLink)
 , maUserData(rGraphicObj.maUserData)
 , mbAutoSwapped(false)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cppuhelper/CppunitTest_cppuhelper_qa_misc.mk cppuhelper/Module_cppuhelper.mk cppuhelper/qa

[Caolán McNamara]

 cppuhelper/CppunitTest_cppuhelper_qa_misc.mk |   28 
 cppuhelper/Module_cppuhelper.mk  |1 
 cppuhelper/qa/misc/test_misc.cxx |   59 +++
 3 files changed, 88 insertions(+)

New commits:
commit 3511baaf9440fedbf2d0c39dfe890123f459ae97
Author: Caolán McNamara 
Date:   Fri Nov 24 15:47:45 2017 +

add cppu::throwException test case

that is definitely run by the ubsan tinderbox to flush out

cppuhelper/source/exc_thrower.cxx:201:15: runtime error: member call on 
address
"foo" which does not point to an object of type 
'cppuhelper::detail::XExceptionThrower'

Change-Id: Ia798cc6695011480717c1a80d0ab7830080b5de1
Reviewed-on: https://gerrit.libreoffice.org/45244
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cppuhelper/CppunitTest_cppuhelper_qa_misc.mk 
b/cppuhelper/CppunitTest_cppuhelper_qa_misc.mk
new file mode 100644
index ..980f40e9571c
--- /dev/null
+++ b/cppuhelper/CppunitTest_cppuhelper_qa_misc.mk
@@ -0,0 +1,28 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,cppuhelper_qa_misc))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,cppuhelper_qa_misc,\
+cppuhelper/qa/misc/test_misc \
+))
+
+$(eval $(call gb_CppunitTest_use_api,cppuhelper_qa_misc,\
+   offapi \
+   udkapi \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,cppuhelper_qa_misc,\
+   cppu \
+cppuhelper \
+   sal \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/cppuhelper/Module_cppuhelper.mk b/cppuhelper/Module_cppuhelper.mk
index 7978aaba96a7..296b85daf3f9 100644
--- a/cppuhelper/Module_cppuhelper.mk
+++ b/cppuhelper/Module_cppuhelper.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_Module_add_check_targets,cppuhelper,\
 
 # CppunitTest_cppuhelper_qa_weak depends on module bridges
 $(eval $(call gb_Module_add_subsequentcheck_targets,cppuhelper,\
+   CppunitTest_cppuhelper_qa_misc \
CppunitTest_cppuhelper_qa_weak \
 ))
 
diff --git a/cppuhelper/qa/misc/test_misc.cxx b/cppuhelper/qa/misc/test_misc.cxx
new file mode 100644
index ..151eb15ea1f6
--- /dev/null
+++ b/cppuhelper/qa/misc/test_misc.cxx
@@ -0,0 +1,59 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+
+namespace
+{
+class Test : public ::CppUnit::TestFixture
+{
+public:
+void testCatchThrow();
+
+CPPUNIT_TEST_SUITE(Test);
+CPPUNIT_TEST(testCatchThrow);
+CPPUNIT_TEST_SUITE_END();
+};
+
+void Test::testCatchThrow()
+{
+css::uno::Any aSavedException;
+try
+{
+throw css::uno::RuntimeException("RuntimeException");
+}
+catch (const css::uno::RuntimeException&)
+{
+aSavedException = cppu::getCaughtException();
+}
+CPPUNIT_ASSERT(aSavedException.hasValue());
+try
+{
+cppu::throwException(aSavedException);
+}
+catch (const css::uno::RuntimeException&)
+{
+// the expected case
+}
+catch (...)
+{
+CPPUNIT_ASSERT(false);
+}
+}
+
+CPPUNIT_TEST_SUITE_REGISTRATION(Test);
+}
+
+CPPUNIT_PLUGIN_IMPLEMENT();
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - vcl/source

[Damjan Jovanovic]

 vcl/source/gdi/pngread.cxx |   18 --
 1 file changed, 16 insertions(+), 2 deletions(-)

New commits:
commit 9819064de0ac29755bbf244fb3115d5b539df85f
Author: Damjan Jovanovic 
Date:   Sat Nov 25 13:21:24 2017 +

Add range checking to PNG palette indexes,

as per OSS-Fuzz issue 574.

Patch by: me

diff --git a/vcl/source/gdi/pngread.cxx b/vcl/source/gdi/pngread.cxx
index b35db105cfca..e2ec7daa1bb5 100644
--- a/vcl/source/gdi/pngread.cxx
+++ b/vcl/source/gdi/pngread.cxx
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 
 // ---
 // - Defines -
@@ -296,7 +297,7 @@ bool PNGReaderImpl::ReadNextChunk()
 if( mnChunkLen < 0 )
 return false;
 const sal_Size nStreamPos = mrPNGStream.Tell();
-if( nStreamPos + mnChunkLen >= mnStreamSize )
+if( nStreamPos + mnChunkLen + 4 >= mnStreamSize )
 return false;
 
 // calculate chunktype CRC (swap it back to original byte order)
@@ -434,7 +435,16 @@ BitmapEx PNGReaderImpl::GetBitmapEx( const Size& 
rPreviewSizeHint )
 if ( !mpInflateInBuf )  // taking care that the header has 
properly been read
 mbStatus = sal_False;
 else if ( !mbIDAT ) // the gfx is finished, but there may 
be left a zlibCRC of about 4Bytes
-ImplReadIDAT();
+{
+try
+{
+ImplReadIDAT();
+}
+catch (::com::sun::star::lang::IndexOutOfBoundsException&)
+{
+mbStatus = sal_False;
+}
+}
 }
 break;
 
@@ -1644,6 +1654,8 @@ void PNGReaderImpl::ImplSetPixel( sal_uInt32 nY, 
sal_uInt32 nX, sal_uInt8 nPalIn
 return;
 nX >>= mnPreviewShift;
 
+if (nPalIndex >= mpAcc->GetPaletteEntryCount())
+throw ::com::sun::star::lang::IndexOutOfBoundsException();
 mpAcc->SetPixelIndex( nY, nX, nPalIndex );
 }
 
@@ -1674,6 +1686,8 @@ void PNGReaderImpl::ImplSetAlphaPixel( sal_uInt32 nY, 
sal_uInt32 nX,
 return;
 nX >>= mnPreviewShift;
 
+if (nPalIndex >= mpAcc->GetPaletteEntryCount())
+throw ::com::sun::star::lang::IndexOutOfBoundsException();
 mpAcc->SetPixelIndex( nY, nX, nPalIndex );
 mpMaskAcc->SetPixelIndex( nY, nX, ~nAlpha );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

precompiled_basctl is always rebuilt on Windows, even when no edits were made

[Kaganski Mike]

Hi!

Since last few weeks, I see that precompiled_basctl started to get 
rebuilt every time I do an incremental build on my Win10+VS2015+cygwin64 
development box (and, naturally, the dependent module as well). This 
happens whenever I do make build-nocheck, even when there were no edits 
to anything in the tree. The net result is slower builds.

The problem persists after make clean; make.

Debugging with make --debug=b shows this:

[...skip...]
File 'baside.sdi' does not exist.
   Must remake target 'baside.sdi'.
   Successfully remade target file 'baside.sdi'.
File 'basslots.hrc' does not exist.
   Must remake target 'basslots.hrc'.
   Successfully remade target file 'basslots.hrc'.
  Prerequisite 'baside.sdi' of target 
'D:/sources/lo-core1/workdir/SdiTarget/basctl/sdi/basslots' does not exist.
  Prerequisite 'basslots.hrc' of target 
'D:/sources/lo-core1/workdir/SdiTarget/basctl/sdi/basslots' does not exist.
 Must remake target 
'D:/sources/lo-core1/workdir/SdiTarget/basctl/sdi/basslots'.
[...skip...]
  Prerequisite 
'D:/sources/lo-core1/workdir/SdiTarget/basctl/sdi/basslots' is newer 
than target 'D:/sources/lo-core1/workdir/SdiTarget/basctl/sdi/basslots.hxx'.
 Must remake target 
'D:/sources/lo-core1/workdir/SdiTarget/basctl/sdi/basslots.hxx'.
[...skip...]
Prerequisite 
'D:/sources/lo-core1/workdir/SdiTarget/basctl/sdi/basslots' is newer 
than target 'D:/sources/lo-core1/workdir/Headers/Library/basctllo.dll'.
   Must remake target 
'D:/sources/lo-core1/workdir/Headers/Library/basctllo.dll'.
[...skip...]
Prerequisite 
'D:/sources/lo-core1/workdir/Headers/Library/basctllo.dll' is newer than 
target 
'D:/sources/lo-core1/workdir/PrecompiledHeader/debug/precompiled_basctl.hxx.gch'.
   Must remake target 
'D:/sources/lo-core1/workdir/PrecompiledHeader/debug/precompiled_basctl.hxx.gch'.
[...skip to EOF]

The two files (baside.sdi and basslots.hrc) naturally exist in basctl/sdi.

Looking at workdir/Dep/SdiTarget/basctl/sdi/basslots.d, there are the 
two files that are listed without paths, unlike the rest:

D:/sources/lo-core1/workdir/SdiTarget/basctl/sdi/basslots : \
  D:/sources/lo-core1/basctl/sdi/basslots.sdi \
  D:\sources\lo-core1\include\editeng\editids.hrc \
  D:\sources\lo-core1\include\editeng\memberids.h \
  D:\sources\lo-core1\include\sfx2\sfxsids.hrc \
  D:\sources\lo-core1\include\svl\memberid.h \
  D:\sources\lo-core1\include\svl\solar.hrc \
  D:\sources\lo-core1\include\svx\svxids.hrc \
  D:\sources\lo-core1\include\svx\unomid.hxx \
  D:\sources\lo-core1\sfx2\sdi\sfx.sdi \
  D:\sources\lo-core1\sfx2\sdi\sfxitems.sdi \
  D:\sources\lo-core1\svx\sdi\svx.sdi \
  D:\sources\lo-core1\svx\sdi\svxitems.sdi \
  D:\sources\lo-core1\svx\sdi\xoitems.sdi \
  baside.sdi \
  basslots.hrc

D:/sources/lo-core1/basctl/sdi/basslots.sdi :

D:\sources\lo-core1\include\editeng\editids.hrc :

D:\sources\lo-core1\include\editeng\memberids.h :

D:\sources\lo-core1\include\sfx2\sfxsids.hrc :

D:\sources\lo-core1\include\svl\memberid.h :

D:\sources\lo-core1\include\svl\solar.hrc :

D:\sources\lo-core1\include\svx\svxids.hrc :

D:\sources\lo-core1\include\svx\unomid.hxx :

D:\sources\lo-core1\sfx2\sdi\sfx.sdi :

D:\sources\lo-core1\sfx2\sdi\sfxitems.sdi :

D:\sources\lo-core1\svx\sdi\svx.sdi :

D:\sources\lo-core1\svx\sdi\svxitems.sdi :

D:\sources\lo-core1\svx\sdi\xoitems.sdi :

baside.sdi :

basslots.hrc :

[EOF]

I couldn't find the reason for this file being generated like that. The 
workaround that works for me now is to edit the 
workdir/Dep/SdiTarget/basctl/sdi/basslots.d to include the paths for the 
files.

-- 
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: external/gpgmepp

[Christian Lohmaier]

 external/gpgmepp/Module_gpgmepp.mk |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 5bd633097b669f3e2153c4240b081ff8ac033574
Author: Christian Lohmaier 
Date:   Sat Nov 25 09:28:57 2017 +0100

gpgme: actually make use of the previous buildfix

Change-Id: I80bb7214429c2f10573b3c243a692b920a4ca1cc

diff --git a/external/gpgmepp/Module_gpgmepp.mk 
b/external/gpgmepp/Module_gpgmepp.mk
index 1c13a2a5fcb8..5763ccedb89a 100644
--- a/external/gpgmepp/Module_gpgmepp.mk
+++ b/external/gpgmepp/Module_gpgmepp.mk
@@ -12,6 +12,7 @@ $(eval $(call gb_Module_Module,gpgmepp))
 $(eval $(call gb_Module_add_targets,gpgmepp,\
UnpackedTarball_gpgmepp \
ExternalProject_gpgmepp \
+   ExternalPackage_gpgmepp \
 ))
 
 ifeq ($(COM),MSC)
@@ -20,12 +21,6 @@ $(eval $(call gb_Module_add_targets,gpgmepp,\
Library_gpgmepp \
 ))
 
-else
-
-$(eval $(call gb_Module_add_targets,gpgmepp,\
-   ExternalPackage_gpgmepp \
-))
-
 endif
 
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/implicitboolconversion.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit f82dc45bdb9e930878447015291c5b90c9325b57
Author: Stephan Bergmann 
Date:   Fri Nov 24 18:31:14 2017 +0100

Use the canonical TemplateDecl

...in case there are multiple, as is the case at least with recent (towards
GCC 8) libstdc++, where std::pair is forward-declared also in
include/c++/8.0.0/bits/stl_iterator.h, so that in
dbaccess/source/ui/dlg/DbAdminImpl.cxx

std::pair< Reference,sal_Bool> aRet;
aRet.second = false;

failed to reconstruct the sal_Bool template argument and issued a
loplugin:implicitboolconversion warning.

Change-Id: I0054f2596d3f8837b857f1dca2f25952828b12cc
Reviewed-on: https://gerrit.libreoffice.org/45254
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/implicitboolconversion.cxx 
b/compilerplugins/clang/implicitboolconversion.cxx
index c695148b790e..5c658fd9c715 100644
--- a/compilerplugins/clang/implicitboolconversion.cxx
+++ b/compilerplugins/clang/implicitboolconversion.cxx
@@ -159,6 +159,7 @@ bool isBoolExpr(Expr const * expr) {
 if (td == nullptr) {
 break;
 }
+td = cast(td->getCanonicalDecl());
 TemplateParameterList const * ps = td->getTemplateParameters();
 SubstTemplateTypeParmType const * t2
 = getAsSubstTemplateTypeParmType(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cppuhelper/source desktop/source

[Michael Meeks]

 cppuhelper/source/servicemanager.cxx |   42 ++-
 desktop/source/lib/init.cxx  |9 +--
 2 files changed, 47 insertions(+), 4 deletions(-)

New commits:
commit 1aedb6c4345719a963a883b13fa983db3ab4b9a8
Author: Michael Meeks 
Date:   Fri Nov 24 17:05:26 2017 +

LOK: provide user feedback while preloading.

Problems are hard enough to debug in a jailed kit process inside
a docker image; provide some visual feedback via stderr.

Change-Id: I54b0a21c1375be2acc9da0bbacf959a419471b08
Reviewed-on: https://gerrit.libreoffice.org/45256
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/cppuhelper/source/servicemanager.cxx 
b/cppuhelper/source/servicemanager.cxx
index 8aa294ca0720..163e0e631d37 100644
--- a/cppuhelper/source/servicemanager.cxx
+++ b/cppuhelper/source/servicemanager.cxx
@@ -10,6 +10,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 
@@ -39,6 +40,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -1806,6 +1808,33 @@ cppuhelper::ServiceManager::findServiceImplementation(
 return impl;
 }
 
+/// Make a simpler unique name for preload / progress reporting.
+static rtl::OUString simplifyModule(const rtl::OUString )
+{
+sal_Int32 nIdx;
+OUStringBuffer edit(uri);
+if ((nIdx = edit.lastIndexOf('/')) > 0)
+edit.remove(0,nIdx+1);
+if ((nIdx = edit.lastIndexOf(':')) > 0)
+edit.remove(0,nIdx+1);
+if ((nIdx = edit.lastIndexOf("lo.so")) > 0)
+edit.truncate(nIdx);
+if ((nIdx = edit.lastIndexOf(".3")) > 0)
+edit.truncate(nIdx);
+if ((nIdx = edit.lastIndexOf("gcc3.so")) > 0)
+edit.truncate(nIdx);
+if ((nIdx = edit.lastIndexOf(".so")) > 0)
+edit.truncate(nIdx);
+if ((nIdx = edit.lastIndexOf("_uno")) > 0)
+edit.truncate(nIdx);
+if ((nIdx = edit.lastIndexOf(".jar")) > 0)
+edit.truncate(nIdx);
+if (edit.indexOf("lib") == 0)
+edit.remove(0,3);
+return edit.makeStringAndClear();
+}
+
+/// Used only by LibreOfficeKit when used by Online to pre-initialize
 void cppuhelper::ServiceManager::preloadImplementations() {
 #ifdef DISABLE_DYNLOADING
 abort();
@@ -1814,6 +1843,9 @@ void cppuhelper::ServiceManager::preloadImplementations() 
{
 osl::MutexGuard g(rBHelper.rMutex);
 css::uno::Environment aSourceEnv(css::uno::Environment::getCurrent());
 
+std::cerr << "preload: ";
+std::vector aReported;
+
 // loop all implementations
 for (Data::NamedImplementations::const_iterator iterator(
 data_.namedImplementations.begin());
@@ -1821,8 +1853,15 @@ void 
cppuhelper::ServiceManager::preloadImplementations() {
 {
 try
 {
+const rtl::OUString  = iterator->second->info->uri;
+if (std::find(aReported.begin(), aReported.end(), aLibrary) == 
aReported.end())
+{
+std::cerr << simplifyModule(aLibrary) << " ";
+aReported.push_back(aLibrary);
+}
+
 // expand absolute URI implementation component library
-aUri = cppu::bootstrap_expandUri(iterator->second->info->uri);
+aUri = cppu::bootstrap_expandUri(aLibrary);
 }
 catch (css::lang::IllegalArgumentException& aError)
 {
@@ -1922,6 +1961,7 @@ void cppuhelper::ServiceManager::preloadImplementations() 
{
 aModule.release();
 }
 }
+std::cerr << std::endl;
 #endif
 }
 
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 42e78e8bec96..5d0e39c419cc 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -14,6 +14,7 @@
 #include 
 
 #include 
+#include 
 #include 
 
 #include 
@@ -3482,6 +3483,7 @@ static void lo_status_indicator_callback(void *data, 
comphelper::LibreOfficeKit:
 }
 }
 
+/// Used only by LibreOfficeKit when used by Online to pre-initialize
 static void preloadData()
 {
 // First: sit down and read all dictionaries: yum.
@@ -3491,14 +3493,14 @@ static void preloadData()
 
 css::uno::Reference 
xLocales(xSpellChecker, css::uno::UNO_QUERY_THROW);
 uno::Sequence< css::lang::Locale > aLocales = xLocales->getLocales();
-SAL_INFO("lok", "Preloading #" << aLocales.getLength() << " dictionaries");
+std::cerr << "Preloading dictionaries: ";
 for (auto  : aLocales)
 {
-SAL_INFO("lok", "load " << it.Language << "_" << it.Country);
+std::cerr << it.Language << "_" << it.Country << " ";
 css::beans::PropertyValues aNone;
 xSpellChecker->isValid("forcefed", it, aNone);
 }
-SAL_INFO("lok", "Preloading done");
+std::cerr << "\n";
 }
 
 static int lo_initialize(LibreOfficeKit* pThis, const char* pAppPath, const 
char* pUserProfileUrl)
@@ -3596,6 +3598,7 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* 

[Libreoffice-commits] core.git: 2 commits - sfx2/source vcl/source

[Michael Meeks]

 sfx2/source/appl/appinit.cxx |1 +
 vcl/source/window/dialog.cxx |   14 --
 2 files changed, 9 insertions(+), 6 deletions(-)

New commits:
commit b0e37303df56472fdc7782b977326c2391fdab07
Author: Michael Meeks 
Date:   Fri Nov 24 13:43:03 2017 +

tdf#114025 - avoid deadlock between x11 clipboard and the lock dialog.

Change-Id: I06e66f59531e7ff6a2e0bf874ebcf2a882d89b63
Reviewed-on: https://gerrit.libreoffice.org/45228
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index 4db7c9674a83..a55dc52705a4 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -1063,13 +1063,15 @@ short Dialog::Execute()
 return 0;
 
 VclPtr xWindow = this;
-
-css::uno::Reference< css::uno::XComponentContext > xContext(
+{
+SolarMutexReleaser aReleaser; // tdf#114025
+css::uno::Reference< css::uno::XComponentContext > xContext(
 comphelper::getProcessComponentContext() );
-css::uno::Reference 
xEventBroadcaster(css::frame::theGlobalEventBroadcaster::get(xContext), 
css::uno::UNO_QUERY_THROW);
-css::document::DocumentEvent aObject;
-aObject.EventName = "DialogExecute";
-xEventBroadcaster->documentEventOccured(aObject);
+css::uno::Reference 
xEventBroadcaster(css::frame::theGlobalEventBroadcaster::get(xContext), 
css::uno::UNO_QUERY_THROW);
+css::document::DocumentEvent aObject;
+aObject.EventName = "DialogExecute";
+xEventBroadcaster->documentEventOccured(aObject);
+}
 UITestLogger::getInstance().log("DialogExecute");
 // Yield util EndDialog is called or dialog gets destroyed
 // (the latter should not happen, but better safe than sorry
commit 4271a447cbc9f517e6cbd257790d08672f973b0a
Author: Michael Meeks 
Date:   Fri Nov 24 14:46:21 2017 +

tdf#114025 - minimal and not entirely convincing fix for assertion failure.

Almost certainly most of the sfx code needs guarding with the SolarMutex.

Change-Id: Ied52f1e57c44c20486777e08a901060c191043a2
Reviewed-on: https://gerrit.libreoffice.org/45233
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/sfx2/source/appl/appinit.cxx b/sfx2/source/appl/appinit.cxx
index a026765176b4..43f4131ddc5f 100644
--- a/sfx2/source/appl/appinit.cxx
+++ b/sfx2/source/appl/appinit.cxx
@@ -218,6 +218,7 @@ void SfxApplication::Initialize_Impl()
 
 if (!utl::ConfigManager::IsFuzzing())
 {
+SolarMutexGuard aGuard;
 //ensure instantiation of listener that manages the internal 
recently-used
 //list
 SfxPickList::ensure();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Julien Nabet]

 vcl/source/gdi/pdfwriter_impl.cxx |   38 +-
 1 file changed, 13 insertions(+), 25 deletions(-)

New commits:
commit b50b099d5a23a0306723c02b30bec056e59702c6
Author: Julien Nabet 
Date:   Fri Nov 24 19:55:24 2017 +0100

Modernize pdfwriter_impl, part 2 (vcl)

by using for range loops + find_if instead of loops

Change-Id: Ide439a683e6b3c406811fe135a7651e26395cf1e
Reviewed-on: https://gerrit.libreoffice.org/45257
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index e6ad03b44940..34161b7ca35a 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -9786,9 +9786,8 @@ void PDFWriterImpl::drawJPGBitmap( SvStream& rDCTData, 
bool bIsTrueColor, const
 if( ! rMask.IsEmpty() )
 aID.m_nMaskChecksum = rMask.GetChecksum();
 
-std::vector< JPGEmit >::const_iterator it;
-for( it = m_aJPGs.begin(); it != m_aJPGs.end() && ! (aID == it->m_aID); 
++it )
-;
+std::vector< JPGEmit >::const_iterator it = std::find_if(m_aJPGs.begin(), 
m_aJPGs.end(),
+ [&](const JPGEmit& arg) { return 
aID == arg.m_aID; });
 if( it == m_aJPGs.end() )
 {
 m_aJPGs.emplace( m_aJPGs.begin() );
@@ -9894,12 +9893,8 @@ const PDFWriterImpl::BitmapEmit& 
PDFWriterImpl::createBitmapEmit( const BitmapEx
 if( ! aMask.IsEmpty() )
 aID.m_nMaskChecksum = aMask.GetChecksum();
 }
-std::list< BitmapEmit >::const_iterator it;
-for( it = m_aBitmaps.begin(); it != m_aBitmaps.end(); ++it )
-{
-if( aID == it->m_aID )
-break;
-}
+std::list< BitmapEmit >::const_iterator it = 
std::find_if(m_aBitmaps.begin(), m_aBitmaps.end(),
+ [&](const BitmapEmit& arg) { 
return aID == arg.m_aID; });
 if( it == m_aBitmaps.end() )
 {
 m_aBitmaps.push_front( BitmapEmit() );
@@ -9951,19 +9946,13 @@ sal_Int32 PDFWriterImpl::createGradient( const 
Gradient& rGradient, const Size&
getReferenceDevice(),
rSize ) );
 // check if we already have this gradient
-std::list::iterator it;
 // rounding to point will generally lose some pixels
 // round up to point boundary
 aPtSize.Width()++;
 aPtSize.Height()++;
-for( it = m_aGradients.begin(); it != m_aGradients.end(); ++it )
-{
-if( it->m_aGradient == rGradient )
-{
-if( it->m_aSize == aPtSize )
-break;
-}
-}
+std::list< GradientEmit >::const_iterator it = 
std::find_if(m_aGradients.begin(), m_aGradients.end(),
+ [&](const GradientEmit& arg) { 
return ((rGradient == arg.m_aGradient) && (aPtSize == arg.m_aSize) ); });
+
 if( it == m_aGradients.end() )
 {
 m_aGradients.push_front( GradientEmit() );
@@ -11438,11 +11427,9 @@ void PDFWriterImpl::ensureUniqueRadioOnValues()
 PDFWidget& rGroupWidget = m_aWidgets[ group.second ];
 // check whether all kids have a unique OnValue
 std::unordered_map< OUString, sal_Int32 > aOnValues;
-int nChildren = rGroupWidget.m_aKidsIndex.size();
 bool bIsUnique = true;
-for( int nKid = 0; nKid < nChildren && bIsUnique; nKid++ )
+for (auto const& nKidIndex : rGroupWidget.m_aKidsIndex)
 {
-int nKidIndex = rGroupWidget.m_aKidsIndex[nKid];
 const OUString& rVal = m_aWidgets[nKidIndex].m_aOnValue;
 SAL_INFO("vcl.pdfwriter", "OnValue: " << rVal);
 if( aOnValues.find( rVal ) == aOnValues.end() )
@@ -11452,25 +11439,26 @@ void PDFWriterImpl::ensureUniqueRadioOnValues()
 else
 {
 bIsUnique = false;
+break;
 }
 }
 if( ! bIsUnique )
 {
 SAL_INFO("vcl.pdfwriter", "enforcing unique OnValues" );
 // make unique by using ascending OnValues
-for( int nKid = 0; nKid < nChildren; nKid++ )
+int nKid = 0;
+for (auto const& nKidIndex : rGroupWidget.m_aKidsIndex)
 {
-int nKidIndex = rGroupWidget.m_aKidsIndex[nKid];
 PDFWidget& rKid = m_aWidgets[nKidIndex];
 rKid.m_aOnValue = OUString::number( nKid+1 );
 if( rKid.m_aValue != "Off" )
 rKid.m_aValue = rKid.m_aOnValue;
+++nKid;
 }
 }
 // finally move the "Yes" appearance to the OnValue appearance
-for( int nKid = 0; nKid < nChildren; nKid++ )
+for (auto const& nKidIndex : rGroupWidget.m_aKidsIndex)
 {
-int nKidIndex = rGroupWidget.m_aKidsIndex[nKid];
 PDFWidget& rKid = 

[Libreoffice-commits] core.git: extras/Package_palettes.mk extras/source

[Yousuf Philips]

 extras/Package_palettes.mk|2 --
 extras/source/palettes/breeze.soc |   35 ---
 extras/source/palettes/tango.soc  |   35 ---
 3 files changed, 72 deletions(-)

New commits:
commit 6481a06b066a744e4f1a41ce1b0ca8b27e5f39b4
Author: Yousuf Philips 
Date:   Thu Nov 23 14:25:02 2017 +0400

tdf#113858 Removal of tango and breeze palettes

Change-Id: I15426cfe13985d26348728e5f8b0a638bcbec84c
Reviewed-on: https://gerrit.libreoffice.org/45141
Reviewed-by: Heiko Tietze 
Tested-by: Yousuf Philips 

diff --git a/extras/Package_palettes.mk b/extras/Package_palettes.mk
index 7750655e2058..dbd31c58d972 100644
--- a/extras/Package_palettes.mk
+++ b/extras/Package_palettes.mk
@@ -11,7 +11,6 @@ $(eval $(call 
gb_Package_Package,extras_palettes,$(SRCDIR)/extras/source/palette
 
 $(eval $(call 
gb_Package_add_files,extras_palettes,$(LIBO_SHARE_FOLDER)/palette,\
arrowhd.soe \
-   breeze.soc \
chart-palettes.soc \
classic.sog \
freecolour-hlc.soc \
@@ -27,7 +26,6 @@ $(eval $(call 
gb_Package_add_files,extras_palettes,$(LIBO_SHARE_FOLDER)/palette,
standard.soh \
standard.sop \
styles.sod \
-   tango.soc \
tonal.soc \
 ))
 
diff --git a/extras/source/palettes/breeze.soc 
b/extras/source/palettes/breeze.soc
deleted file mode 100644
index 5dd65b2ea3f1..
--- a/extras/source/palettes/breeze.soc
+++ /dev/null
@@ -1,35 +0,0 @@
-
-
-http://www.w3.org/1999/xlink; 
xmlns:svg="http://www.w3.org/2000/svg; 
xmlns:ooo="http://openoffice.org/2004/office;>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/extras/source/palettes/tango.soc b/extras/source/palettes/tango.soc
deleted file mode 100644
index 88e75a33a0be..
--- a/extras/source/palettes/tango.soc
+++ /dev/null
@@ -1,35 +0,0 @@
-
-http://www.w3.org/1999/xlink; 
xmlns:svg="http://www.w3.org/2000/svg; 
xmlns:ooo="http://openoffice.org/2004/office;>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - ios/CustomTarget_iOS_prelink.mk ios/LibreOfficeLight ios/README

[jan Iversen]

 ios/CustomTarget_iOS_prelink.mk |4 
 ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj |  123 
++
 ios/LibreOfficeLight/LibreOfficeLight/Info.plist|2 
 ios/LibreOfficeLight/LibreOfficeLight/dummyLOkit.c  |   14 +
 ios/LibreOfficeLight/LibreOfficeLight/lokit-Bridging-Header.h   |2 
 ios/README  |   13 -
 6 files changed, 48 insertions(+), 110 deletions(-)

New commits:
commit ff92dc75a7d8c5981503eebac84ceaf33e36845b
Author: jan Iversen 
Date:   Sat Nov 25 12:23:58 2017 +0100

iOS, project update to compile with dummy LOkit

Change-Id: If76f4aaecb853db6b33d671092b7806bbb9b9d2d

diff --git a/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj 
b/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
index ec9151c4acae..becd7212d156 100644
--- a/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
+++ b/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
@@ -16,6 +16,7 @@
393975781F8BECB0002DC80B /* libiconv.tbd in Frameworks */ = 
{isa = PBXBuildFile; fileRef = 393975771F8BECB0002DC80B /* libiconv.tbd */; };
3939757A1F8BECC1002DC80B /* libz.tbd in Frameworks */ = {isa = 
PBXBuildFile; fileRef = 393975791F8BECC1002DC80B /* libz.tbd */; };
39503A751F94D44900F19C78 /* libc++.tbd in Frameworks */ = {isa 
= PBXBuildFile; fileRef = 39503A741F94D44900F19C78 /* libc++.tbd */; };
+   396C83371FC989AB008E662A /* dummyLOkit.c in Sources */ = {isa = 
PBXBuildFile; fileRef = 39284DB01FA5E150006F43E4 /* dummyLOkit.c */; };
396F92F71E7AE62400A28C82 /* Settings.bundle in Resources */ = 
{isa = PBXBuildFile; fileRef = 396F92F61E7AE62400A28C82 /* Settings.bundle */; 
};
397868D61E59A3EA007F9248 /* LaunchScreen.xib in Resources */ = 
{isa = PBXBuildFile; fileRef = 397868D81E59A3EA007F9248 /* LaunchScreen.xib */; 
};
397E08FE1E597BD8001374E0 /* AppDelegate.swift in Sources */ = 
{isa = PBXBuildFile; fileRef = 397E08FD1E597BD8001374E0 /* AppDelegate.swift 
*/; };
@@ -267,6 +268,7 @@
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
+   396C83371FC989AB008E662A /* dummyLOkit.c in 
Sources */,
392ED9B31E5E4B03005C8435 /* 
ViewPrintManager.swift in Sources */,
399648471E5B87DC00E73E83 /* 
ViewProperties.swift in Sources */,
39284DB31FA5F207006F43E4 /* 
DocumentActions.swift in Sources */,
diff --git a/ios/LibreOfficeLight/LibreOfficeLight/dummyLOkit.c 
b/ios/LibreOfficeLight/LibreOfficeLight/dummyLOkit.c
index 5d6effbf9647..309d00506cf3 100644
--- a/ios/LibreOfficeLight/LibreOfficeLight/dummyLOkit.c
+++ b/ios/LibreOfficeLight/LibreOfficeLight/dummyLOkit.c
@@ -48,3 +48,17 @@ int BridgeLOkit_LeaveHipernate()
 {
 return 0;
 }
+
+
+
+int BridgeLOkit_Sizing(const int countXtiles, const int countYtiles,
+   const int pixelsXtile, const int pixelsYtile)
+{
+(void)countXtiles;
+(void)countYtiles;
+(void)pixelsXtile;
+(void)pixelsYtile;
+return 0;
+}
+
+
diff --git a/ios/LibreOfficeLight/LibreOfficeLight/lokit-Bridging-Header.h 
b/ios/LibreOfficeLight/LibreOfficeLight/lokit-Bridging-Header.h
index 0ddc877b0233..d501ae863444 100644
--- a/ios/LibreOfficeLight/LibreOfficeLight/lokit-Bridging-Header.h
+++ b/ios/LibreOfficeLight/LibreOfficeLight/lokit-Bridging-Header.h
@@ -10,4 +10,4 @@
 
 // LibreOfficeKit is a prelink of all used LO libraries, generated
 // as its own xCode project.
-#import "../LibreOfficeKit/LibreOfficeKit/LibreOfficeKit.h"
+#import "../../source/LibreOfficeKit.h"
commit 64c93f3fe939642acd4133ac5bbdeb91975b7662
Author: jan Iversen 
Date:   Sat Nov 25 12:16:39 2017 +0100

iOS, update app project

Updated LibreOfficeLight to correspond to new prelink.

Change-Id: Iec0425d3516849afaae4b640e8b4fc733430d595

diff --git a/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj 
b/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
index 2c96313d6c4d..ec9151c4acae 100644
--- a/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
+++ b/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
@@ -18,7 +18,6 @@
39503A751F94D44900F19C78 /* libc++.tbd in Frameworks */ = {isa 
= PBXBuildFile; fileRef = 39503A741F94D44900F19C78 /* libc++.tbd */; };
396F92F71E7AE62400A28C82 /* Settings.bundle in Resources */ = 
{isa = PBXBuildFile; fileRef = 396F92F61E7AE62400A28C82 /* Settings.bundle */; 
};
397868D61E59A3EA007F9248 /* LaunchScreen.xib in Resources */ = 
{isa = PBXBuildFile; fileRef = 397868D81E59A3EA007F9248 /* LaunchScreen.xib */; 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - external/icu

[Eike Rathke]

 external/icu/UnpackedTarball_icu.mk|1 +
 external/icu/icu4c-changeset-40324.patch.1 |   11 +++
 2 files changed, 12 insertions(+)

New commits:
commit f67b46422ab5a9e510028a754908ae1a317389fc
Author: Eike Rathke 
Date:   Wed Nov 8 17:17:44 2017 +0100

Add ICU changeset-40324 fix for CVE-2017-14952

(cherry picked from commit cebe1279665960b732c9cb05c18e481c33e778bb)

 Conflicts:
external/icu/UnpackedTarball_icu.mk

Change-Id: Ia457669c5ec6ef5c568f4550c44ef5df32a4be66
Reviewed-on: https://gerrit.libreoffice.org/44510
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/external/icu/UnpackedTarball_icu.mk 
b/external/icu/UnpackedTarball_icu.mk
index 58fedc9f3951..f1658a229586 100644
--- a/external/icu/UnpackedTarball_icu.mk
+++ b/external/icu/UnpackedTarball_icu.mk
@@ -28,6 +28,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,icu,\
$(if $(filter EMSCRIPTEN,$(OS)),external/icu/icu4c-emscripten.patch.1) \
external/icu/khmerbreakengine.patch \
external/icu/icu4c-changeset-39671.patch.1 \
+   external/icu/icu4c-changeset-40324.patch.1 \
 ))
 
 $(eval $(call 
gb_UnpackedTarball_add_file,icu,source/data/brkitr/khmerdict.dict,external/icu/khmerdict.dict))
diff --git a/external/icu/icu4c-changeset-40324.patch.1 
b/external/icu/icu4c-changeset-40324.patch.1
new file mode 100644
index ..a651eb19415d
--- /dev/null
+++ b/external/icu/icu4c-changeset-40324.patch.1
@@ -0,0 +1,11 @@
+# 
https://ssl.icu-project.org/trac/changeset/40324/trunk/icu4c/source/i18n/zonemeta.cpp
+Index: trunk/icu4c/source/i18n/zonemeta.cpp
+===
+--- icu.orig/source/i18n/zonemeta.cpp
 icu/source/i18n/zonemeta.cpp
+@@ -691,5 +691,4 @@
+ if (U_FAILURE(status)) {
+ delete mzMappings;
+-deleteOlsonToMetaMappingEntry(entry);
+ uprv_free(entry);
+ break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - external/icu

[Eike Rathke]

 external/icu/UnpackedTarball_icu.mk|1 +
 external/icu/icu4c-changeset-40324.patch.1 |   11 +++
 2 files changed, 12 insertions(+)

New commits:
commit e7738ab7b824fde359a7783ab65a4f4a26675528
Author: Eike Rathke 
Date:   Wed Nov 8 17:17:44 2017 +0100

Add ICU changeset-40324 fix for CVE-2017-14952

(cherry picked from commit cebe1279665960b732c9cb05c18e481c33e778bb)

 Conflicts:
external/icu/UnpackedTarball_icu.mk

Change-Id: Ia457669c5ec6ef5c568f4550c44ef5df32a4be66
Reviewed-on: https://gerrit.libreoffice.org/44494
Tested-by: Eike Rathke 
Reviewed-by: Andras Timar 

diff --git a/external/icu/UnpackedTarball_icu.mk 
b/external/icu/UnpackedTarball_icu.mk
index 58fedc9f3951..f1658a229586 100644
--- a/external/icu/UnpackedTarball_icu.mk
+++ b/external/icu/UnpackedTarball_icu.mk
@@ -28,6 +28,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,icu,\
$(if $(filter EMSCRIPTEN,$(OS)),external/icu/icu4c-emscripten.patch.1) \
external/icu/khmerbreakengine.patch \
external/icu/icu4c-changeset-39671.patch.1 \
+   external/icu/icu4c-changeset-40324.patch.1 \
 ))
 
 $(eval $(call 
gb_UnpackedTarball_add_file,icu,source/data/brkitr/khmerdict.dict,external/icu/khmerdict.dict))
diff --git a/external/icu/icu4c-changeset-40324.patch.1 
b/external/icu/icu4c-changeset-40324.patch.1
new file mode 100644
index ..a651eb19415d
--- /dev/null
+++ b/external/icu/icu4c-changeset-40324.patch.1
@@ -0,0 +1,11 @@
+# 
https://ssl.icu-project.org/trac/changeset/40324/trunk/icu4c/source/i18n/zonemeta.cpp
+Index: trunk/icu4c/source/i18n/zonemeta.cpp
+===
+--- icu.orig/source/i18n/zonemeta.cpp
 icu/source/i18n/zonemeta.cpp
+@@ -691,5 +691,4 @@
+ if (U_FAILURE(status)) {
+ delete mzMappings;
+-deleteOlsonToMetaMappingEntry(entry);
+ uprv_free(entry);
+ break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Caolán McNamara]

 sc/source/ui/unoobj/chart2uno.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 644f1451abf66085717feafdfd40012b14e722a4
Author: Caolán McNamara 
Date:   Fri Nov 24 16:42:12 2017 +

coverity#1422232 Improper use of negative value

Change-Id: I79b24e175906ca5552f45b6af472c436ffde5fe3
Reviewed-on: https://gerrit.libreoffice.org/45247
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/source/ui/unoobj/chart2uno.cxx 
b/sc/source/ui/unoobj/chart2uno.cxx
index ffea02a88546..71c3c96f83c0 100644
--- a/sc/source/ui/unoobj/chart2uno.cxx
+++ b/sc/source/ui/unoobj/chart2uno.cxx
@@ -752,7 +752,7 @@ void Chart2Positioner::createPositionMap()
 else
 pCol = it->second;
 
-sal_uInt32 nInsRow = static_cast(bNoGlue ? 
nNoGlueRow : nRow1);
+auto nInsRow = bNoGlue ? nNoGlueRow : nRow1;
 for (SCROW nRow = nRow1; nRow <= nRow2; ++nRow, ++nInsRow)
 {
 ScSingleRefData aCellData;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114042] Centring of text in Calc not very good.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114042

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Can not reproduce on Windows 10 Home 64-bit en-US (ver 1709) with
Version: 5.4.3.1 (x64)
Build ID: 32c8895c6cae21571f364dbb059f419a743ee44d
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
Locale: en-US (en_US); Calc: group


It would be a mistake to expect using a proportional font to maintain offset
from center line of column. To have centered results you must select a
monospaced font, e.g. Liberation Mono. 

The center line of each column is correctly calculated. Even or Odd length
strings will start at or split on the center line respectively. Space before
and space after are equal with mono spaced fonts.

Calculating positioning of a true center for each string of text would be
inefficient and is simply not needed for layout in a spread sheet.

The attached annotated clip compares centered column with Liberation Mono
(13pt) and Liberation Sans (13pt) text strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114048] Scrolling multi-page (pages on a row) with a lot of images is slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114048

--- Comment #2 from Telesto  ---
Created attachment 137985
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137985=edit
Bibisect log

Bisected to:
commit 4e9d8ca44a246653894559f10bf88effba366b10
Author: Matúš Kukan 
AuthorDate: Tue Jul 15 21:54:58 2014 +0200
Commit: Matúš Kukan 
CommitDate: Tue Jul 15 21:59:17 2014 +0200

libreofficekit does not work with libmerged

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114048] Scrolling multi-page (pages on a row) with a lot of images is slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114048

Thomas Woltjer  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Thomas Woltjer  ---
I can confirm this bug, it happens for me too. It looks like it could be an
issue with rendering the images, because it only lags when scrolling to parts
of the document that haven't yet been viewed. 

While scrolling, it seems that libreoffice is using up approx. 50% of the
processing power on a core, more than the usual amount. It isn't hitting max.
frequency at all, so I don't think putting too much work into one thread is the
issue.

System info:

Version: 5.4.1.2 (x64)
Build ID: ea7cb86e6eeb2bf3a5af73a8fac570321527
CPU threads: 8; OS: Windows 6.19; UI render: GL; 
Locale: en-US (en_US); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114051] New: tests sc_array_functions_test fail due to floating point precision

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114051

Bug ID: 114051
   Summary: tests sc_array_functions_test fail due to floating
point precision
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: miltonvandersl...@fake-box.com

The test ArrayFunctionsTest::testArrayFormulasFODS (files
sc/qa/unit/functions_test.cxx, sc/qa/unit/functions_array.cxx) fails the test
document sc/qa/unit/data/functions/array/fods/linest.fods. Opening the files in
sc/qa/unit/data/functions/array/fods/ reveals also that the file logest.fods
also fails (the others do not fail for me).

Error message in the compile run (Note that 1 = TRUE, 0 = FALSE in the
document)


functions_test.cxx:43:Assertion
Test name: ArrayFunctionsTest::testArrayFormulasFODS
double equality assertion failed
- Expected: 1
- Actual  : 0
- Delta   : 1e-14


The issue seems to be (again) floating point precision. Indeed, I've compiled
LibreOffice with FMA (fused multiply-add) instructions, if I disable them, i.e.
passing -ffp-contract=off to the compiler, then the tests succeed. Note that
FMA has slightly different floating point precision than ordinary plus and mult
[0, 1].

Mentionable commits:

* Add logest.fods test:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=588ebef9e8d1e2c703b79f51f2a1c8004cd7d96d
* Add linest.fods test:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=0523e11a2530ed101c580f93f94a4180e9dc0c9e
* Disable tests on 32-bit x86-linux due to floating point weirdness:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b9a27d5856f60688456762bfcc29c38670009254

[0] https://en.wikipedia.org/wiki/Fused_multiply-add
[1] https://github.com/uclouvain/openjpeg/issues/1017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102237] Timer UI is not appropriate for a timer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102237

Tin Man  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114053] New: Printer driver bug for 5.4.2.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114053

Bug ID: 114053
   Summary: Printer driver bug for 5.4.2.2
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gcrot...@icloud.com

Description:
The printer driver does'nt send to the printer the entire sheet,even the
setting of the printer is good.  It's like it's using a wrong paper size.

I use letter (8 1/2 inc X 11 inches) and legal paper (8 1/2 X 14 inches) on a
Smsung SCX-4828 printer.

The former version of Libre Office was running well 

Steps to Reproduce:
1.edit one page on writer
2. try to print that page, on letter size paper

Actual Results:  
see how the printed output is schrunked

Expected Results:
printing only a part of the page, and that part is not center to the paper,
align to left side and to the bottom of the page (no margins)


Reproducible: Always


User Profile Reset: No



Additional Info:
printing the total page properly to the good paper size


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0)
Gecko/20100101 Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102237] Timer UI is not appropriate for a timer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102237

--- Comment #2 from Tin Man  ---
(In reply to Xisco Faulí from comment #1)
> Thank you for reporting the bug.
> it seems you're using an old version of LibreOffice.
> Could you please try to reproduce it with the latest version of LibreOffice
> from https://www.libreoffice.org/download/libreoffice-fresh/ ?
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' if the bug is still present in the latest version.

This is not a bug in LibreOffice, but in the LibreOffice Viewer Android app.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114054] New: Weird orientation shift on printing letter size documents in Write

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114054

Bug ID: 114054
   Summary: Weird orientation shift on printing letter size
documents in Write
   Product: LibreOffice
   Version: 5.3.7.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philpe...@gmail.com

Description:
As discussed in the forum posts below, there is a bug numerous people are
experiencing printing US Letter-size Writer documents on MacOS.  Changing the
dimensions to 8.5x10.99 or the like fixes the problem (but it is rather
frustrating until you find that fix which is not necessarily intuitive).  It
appears to happen on both 5.3.7 and 5.4.2 at least.

https://ask.libreoffice.org/en/question/88250/printing-page-orientation-wrong-in-os-x/

Steps to Reproduce:
1. Create new document or open an existing one that is Letter page size.
2. Put some text in it
3. Select print from the menu and the preview image will show the problem.

Actual Results:  
Text is oriented at a 90 degree angle (off to its side) and cut off.

Expected Results:
Normal printing.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0)
Gecko/20100101 Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111837] Navigator: Lag in navigator selection update when clicking on next slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111837

Omer Zak  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97530] Installs, then hangs while verifying (OS X 10.10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97530

--- Comment #20 from steve -_-  ---
This is happening to other software as well and I tend to think this is an
apple bug specific to macOS 10.10.

Thoughts? Should we close this as NOTOURBUG?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113394] missing link to java jre

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113394

Jean-Baptiste Faure  changed:

   What|Removed |Added

Version|unspecified |5.3.6.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114049] Latest version 5.4.3.2 x86_69 installs but does not load any application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114049

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

--- Comment #3 from V Stuart Foote  ---
Sorry, not reproducible and without your additional input nothing we will be
able to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92190

V Stuart Foote  changed:

   What|Removed |Added

 CC||gcrot...@icloud.com

--- Comment #101 from V Stuart Foote  ---
*** Bug 114053 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114053] Printer driver bug for 5.4.2.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114053

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---
This should be resolved for you, retest with current 6.0 master or 5.4 daily
(or 5.4.4 when released)

https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-4=9f8429d81c08cc40d5b1210cb6e4b383316cdc75

*** This bug has been marked as a duplicate of bug 92190 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 33201] UI: Highlight (not select) current row and column in spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=33201

--- Comment #20 from Dan Dascalescu  ---
Sad to hear it's not a trivial task to highlight the current row.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90621] FORMATTING: Custom character styles are not applied in bibliographies

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90621

--- Comment #15 from Rastus Vernon  ---
Update: I was able to reproduce the bug on LibreOffice 5.4.3.2 using the test
document and reproduction steps 9 to 11.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81957] "Print comment on page margin" do not show comment in print preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81957

Kevin Suo  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81957] "Print comment on page margin" do not show comment in print preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81957

--- Comment #8 from Kevin Suo  ---
Bug still exists in:

Version: 6.0.0.0.alpha1+
Build ID：8b8aa6bc010fffbcd47679aa101075d702741f69
CPU 线程：4; 操作系统：Linux 4.13; UI 渲染：默认; VCL: gtk2; 
Locale: zh-CN (zh_CN.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81957] "Print comment on page margin" do not show comment in print preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81957

Kevin Suo  changed:

   What|Removed |Added

 Blocks||108804


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108804
[Bug 108804] [META] Print preview bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108804] [META] Print preview bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108804

Kevin Suo  changed:

   What|Removed |Added

 Depends on||81957


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=81957
[Bug 81957] "Print comment on page margin" do not show comment in print preview
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114056] New: Extensions "nlpsolvert.oxt" and "LanguageTool-x-x.oxt" are incompatible "java.lang.reflect.InvocationTargetException"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114056

Bug ID: 114056
   Summary: Extensions "nlpsolvert.oxt" and "LanguageTool-x-x.oxt"
are incompatible
"java.lang.reflect.InvocationTargetException"
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bg...@juggling.ch

Description:
I work under Linux KUbuntu 16.04, 64 bits, with KDE.
Having installed "LanguageTool--3.9.oxt", and "NLPSolver.oxt", when I try to
activate nlpsolver, I get the error message :
"java.lang.reflect.InvocationTargetException"
In Calc, it is not possible to solve non linear problems, such as minimising
the sum of the squares of differences, depending on two parameters.
"Tools > Solver..."
When disabling "LanguageTool", it doesn't help.
When removing "LanguageTool", the problem is solved and non linear problems can
be solved.
I'm not the only one with this issue, c.f.
https://code.google.com/archive/p/ooo2gd/issues/115


Steps to Reproduce:
1. Install LanguageTool-3.9.oxt  and activate it, if it is not already done
2. Install NLPSolver (from synaptic for example)
3. Activate nlpsolver
4. try to solve with "Tools > solver..." a non linear problem

Actual Results:  
° When activating nlpsolver, the error :
  "java.lang.reflect.InvocationTargetException" occur
° "Tools > solver..." doesn't work for optimising problems like minimising the
sum of the square of differences, depending on two parameters.


Expected Results:
I would expect to have no error and to be able to sole a non linear problem


Reproducible: Always


User Profile Reset: No



Additional Info:
I can solve a non linear problem after removing "LanguageTool".
As I already wrote, I'm not the only person concerned, c.f.
https://code.google.com/archive/p/ooo2gd/issues/115



User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101
Firefox/54.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105626] Breeze dark is hardly readable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105626

Aron Budea  changed:

   What|Removed |Added

 Status|REOPENED|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114021] No filename path tooltip appears inside of open split button menu (Gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114021

--- Comment #3 from Adolfo Jayme  ---
Menu entries should not have tooltips, ever. The solution to Jay’s use case
here would be to truncate the file names differently, e.g. to elide at the
center instead of at the end.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92190

V Stuart Foote  changed:

   What|Removed |Added

 CC||philpe...@gmail.com

--- Comment #100 from V Stuart Foote  ---
*** Bug 114054 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114054] Weird orientation shift on printing letter size documents in Write

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114054

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #4 from V Stuart Foote  ---
target:6.0.0 target:5.4.4

https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-4=9f8429d81c08cc40d5b1210cb6e4b383316cdc75

*** This bug has been marked as a duplicate of bug 92190 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105268] Auto Fill: The Next Value for "001-001-001" is "001-001-002" Rather than "001-001000"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105268

--- Comment #5 from Jim Raykowski  ---
Here is a link to a patch I think provides the requested behavior 

https://gerrit.libreoffice.org/#/c/45280/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112022] Writer repeatedly crashing for no apparent reason

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112022

--- Comment #35 from Sam  ---
Created attachment 137987
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137987=edit
two reports

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112022] Writer repeatedly crashing for no apparent reason

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112022

--- Comment #36 from Sam  ---
Comment on attachment 137987
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137987
two reports

Thanks much! I've now installed Xcode and it works fine.

So I've started LO, and after working a couple of minutes on a Writer file, it
froze and I had to force quit.

Attached are two files: the output from the terminal (crash1) and the problem
report generated from Apple.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112022] Writer repeatedly crashing for no apparent reason

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112022

Sam  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114050] New: Image compression seems to be rather slow and CPU hogging for high resolution images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114050

Bug ID: 114050
   Summary: Image compression seems to be rather slow and CPU
hogging for high resolution images
   Product: LibreOffice
   Version: 4.2.0.4 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Image compression seems to be rather slow and CPU hogging for high resolution
images

Steps to Reproduce:
1. Open the attached file
2. Compress the image to jpg 90; 200 dpi with any Interpolation filter
(Lanczos)

Actual Results:  
Takes around 5 seconds to compress with a progression bar (and LibO
unresponsive)

Expected Results:
2 second or so (FastStone image viewer/IrfanView)


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 6.0.0.0.alpha1+
Build ID: c24c32bf71b8e64bd0d36e511f554e1f6c015842
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-11-22_23:15:41
Locale: nl-NL (nl_NL); Calc: group threaded

and in 
4.2.0.4


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114050] Image compression seems to be rather slow and CPU hogging for high resolution images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114050

--- Comment #1 from Telesto  ---
Sample file: attachment 137986

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107495] An explicitly enabled contextual toolbar is always closing after exiting its contextual state

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107495

Telesto  changed:

   What|Removed |Added

  Component|Writer  |LibreOffice

--- Comment #5 from Telesto  ---
Setting it to LibreOffice, instead of Writer. 
https://ask.libreoffice.org/en/question/138729/menu-item-problem-with-mac-os-high-sierra/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112022] Writer repeatedly crashing for no apparent reason

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112022

--- Comment #38 from Sam  ---
Update: The problem mentioned in Comment # 37 is resolved (I've now been able
to quit the app properly.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114042] Centring of text in Calc not very good.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114042

Xavier Van Wijmeersch  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70425] EDITING: Embedded Firebird - Copying integer values from Calc to Base impossible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70425

--- Comment #17 from rob...@familiegrosskopf.de ---
Nothing changed. Couldn't copy integer values from Calc to Base with Firebird
3.0.
Tested with
Version: 5.4.3.2
Build-ID: 92a7159f7e4af62137622921e809f8546db437e5
CPU-Threads: 4; Betriebssystem:Linux 4.4; UI-Render: Standard; VCL: kde4; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114047] New: Option + Left/ Right Arrow Key Should Scroll to the Previous/Next Word not Reduce/ Increase the Column Width

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114047

Bug ID: 114047
   Summary: Option + Left/Right Arrow Key Should Scroll to the
Previous/Next Word not Reduce/Increase the Column
Width
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: guro...@gmail.com

Description:
While in cell editing, option left or right arrows should skip to cursor to the
previous/next word instead of decreasing/increasing the column width

Steps to Reproduce:
1.Double-click a cell with text comprising many words
2.Press Option and Right Arrow Key

Actual Results:  
The width of the column is changing.

Expected Results:
Scroll to the next word's beginning (like in Microsoft Excel)


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0)
Gecko/20100101 Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114042] Centring of text in Calc not very good.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114042

--- Comment #3 from V Stuart Foote  ---
Created attachment 137980
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137980=edit
comparison of a mono space font and proportional fonts in centered columns

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113977] Implement REGEXEXTRACT function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113977

--- Comment #4 from Dan Dascalescu  ---
> At first sight it looks like a proper enhancement, one function that
> with regex can extract the most wonderful parts out of a text string.

That's what I was going for, thank you.

> However I see some aspects that reduces its usefulness:
> -regular expressions are not everybody's cup of tea.
> This makes the function only useful to a very small group of users;

A lot of users are familiar with wildcards, e.g. *.jpg. Many regexp tasks are
solvable with just "foo.*bar". Anyway, by the logic "a function only serves
some users therefore we shouldn't have it", none of the trigonometry functions
should be in LibreCalc. For example, I've never used "arctangent" in my life.
Or "BAHTTEXT". Wish I had numbers to show that far more Google Docs users use
REGEXEXTRACT than BAHTTEXT.

> -Calc has a setting (in preferences) in which wild cards or regular 
> expressions can be selected to be used in function arguments. This request is 
> limited to regular expressions only and thereby somewhat conflicts with the 
> wild card/regex setting;

It "conflicts" only as much as the regex pattern for existing functions that
use regexps, like SEARCH, conflicts. We can solve this problem the same way we
solved the SEARCH problem.

> -As the function is neither in ODFF nor in Excel, it will be incompatible
>  with other applications where LibreOffice strives for optimal 
> interoperability with other applications;

Do we limit formatting because it's not compatible with CSV?

1. If a document author wants to provide backwards compatibility with
applications that don't support a given function, they won't use that function. 

2. What other applications exactly are we talking about? Only Excel has
significant market share, because Google Sheets supports REGEXEXTRACT.

3. Innovation requires breaking compatibility. By providing a new function, we
enable users to force the developers of their applications to step up and
provide the same function. This very process is at work now as I'm adovating
for supporting a function from Google Sheets...

4. ...which is reason #4 why we should implement that function - so Google
Sheets that use it could be opened in LibreCalc.


> -Calculations (including those on text strings) tend to look very complex 
> when the calculation goes further than just one simple calculation. This can 
> > be avoided by using more than one step

I prefer not to litter my spreadsheet with cells that contain intermediate
values. In my example with web service-based currency conversion (BTW a very
common task that we don't have a good solution for - see bug 113974), the
string "EUR:1.2,JPY:0.02,AUD:0.9,..." would require 2 intermediate cells per
each currency. This would trade off formula complexity (usually invisible and
forgotten about once you've figured out the formula) for the visible complexity
of the intermediate cells (which, yes, could be hidden as well). Anyway,  I'd
love to have one clean function that can extract exactly what I need into the
desired cell.

> Creating new functions that combine other functions will only be useful if 
> there is a common need for them.

I think Google Sheets shows there's a need for REGEXEXTRACT...

> In programming it is the same: with some standard functions an almost 
> infinite amount of functionalities can be programmed; only functionality that 
> is widely used is put into a separate function.

... and so do all modern programming languages:

"match" in JavaScript
"search" in Python
"matcher" in Java
etc.

> -A macro can provide the same functionality and be exactly suited to the 
> user's need.

I would say a lot more users are comfortable using functions already provided
by Calc/Excel/Sheets, than creating macros.


> The enhancement request is clear, so I set the status to new.
> @Dan : should you wish to do this yourself, LibreOffice has a mentor for 
> those new to developing for LibreOffice. I can help you with some code 
> pointers as well.

Thank you. I hope to have time to tackle this on next year, though for now I've
just been using a long formula, so my motivation has decreased somewhat.

> IMHO A7 should be A1.

Correct :) Which proves how brittle that sort of complex MID+SEARCH expression
is.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||111837


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111837
[Bug 111837] Navigator: Lag in navigator selection update when clicking on next
slide
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111837] Navigator: Lag in navigator selection update when clicking on next slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111837

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||103030


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114055] updates macos not downloading

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114055

steve -_-  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from steve -_-  ---
just a test bug, to test bug report form. invalid

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114055] New: updates macos not downloading

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114055

Bug ID: 114055
   Summary: updates macos not downloading
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: l...@disr.it

Description:
no new versions will download on macOS for libreoffice

Steps to Reproduce:
1. use internal update check

Actual Results:  
updates never download

Expected Results:
should download, ideally use MAR updater


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0)
Gecko/20100101 Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105626] Breeze dark is hardly readable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105626

steve -_-  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

--- Comment #4 from steve -_-  ---
NOTABUG? How so? Users are able to select Breeze Dark and will end up with
unreadable icons. That's what I'd consider a bug. I understand that the icons
are light and the idea is to have a dark background. But all that can not be
required for users to be known prior knowledge before selecting "Breeze dark".

@Heiko could you elaborate why this is not a bug? If breeze dark is an expert
only option it maybe should be treated as such?

Maybe we should still close this bug and file a new one regarding
cross-platform usage of dark themes?

I am re-opening this bug for the time being. Feel free to close again if you
disagree with my above statements.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114045] New: Undo after Clone Formatting changes formatting of entire table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114045

Bug ID: 114045
   Summary: Undo after Clone Formatting changes formatting of
entire table
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ger...@pfeifer.com

Created attachment 137981
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137981=edit
Sample document

How to reproduce:

 1. Open attached document
 2. Change text background color of the ONE cell (or probably any other).
 3. Clone formatting to the TWO/THREE/FOUR/FIVE cells (or probably others).
 4. Undo and observe how font SIZES(!) change across the table.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88752] DOC import: text grid size mismatch

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88752

Gerald Pfeifer  changed:

   What|Removed |Added

 CC||ger...@pfeifer.com

--- Comment #4 from Gerald Pfeifer  ---
Yes, still seeing this with LibreOffice 5.4.2.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112022] Writer repeatedly crashing for no apparent reason

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112022

--- Comment #37 from Sam  ---
The force quit mentioned in the previous comment turns out not to have
happened: there is the spinning wheel, and even using Cmd+Opt+Esc and choosing
LibreOfficeDev does not close the application. It's still frozen, with the
wheel. This has never happened before (maybe this is in connection with the
debugging session?) What can I do?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108567] [META] Splash screen and initialization related bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108567

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||90794


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90794
[Bug 90794] Fix the Linux HiDPI start screen
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114045] Undo after Clone Formatting changes formatting of entire table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114045

--- Comment #2 from Gerald Pfeifer  ---
Created attachment 137982
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137982=edit
Screenshort before the undo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114045] Undo after Clone Formatting changes formatting of entire table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114045

--- Comment #1 from Gerald Pfeifer  ---
> How to reproduce:
> 
>  1. Open attached document
>  2. Change text background color of the ONE cell (or probably any other).
>  3. Clone formatting to the TWO/THREE/FOUR/FIVE cells (or probably others).
>  4. Undo and observe how font SIZES(!) change across the table.

This reproduces _trying_ to clone text background color, which does not
seem to work, though (but that's another issue).

Best simply use text color or strike through formatting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114045] Undo after Clone Formatting changes formatting of entire table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114045

--- Comment #3 from Gerald Pfeifer  ---
Created attachment 137983
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137983=edit
Screenshort after the undo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114046] New: EDITING by PASTING text in the formula bar should not transfer the source format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114046

Bug ID: 114046
   Summary: EDITING by PASTING text in the formula bar should not
transfer the source format
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: guro...@gmail.com

Description:
Pasting directly into the formula bar should have text-only (not formatting is
transferred into the cell)

Steps to Reproduce:
1.Copy a formatted text (e.g. a text with Times New Roman)
2.Switch to LibreOffice Calc file
3.Click the formula bar
4.Paste the text

Actual Results:  
Cell's format is changed to Times New Roman

Expected Results:
Original cell format should not be changed (as in Microsoft Excel)


Reproducible: Always


User Profile Reset: No



Additional Info:
It must be Text-Only


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0)
Gecko/20100101 Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #12 from Jim Raykowski  ---
Hi All,

Here is a reworked patch for this bug. No merge conflict.

https://gerrit.libreoffice.org/#/c/45273/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114049] Latest version 5.4.3.2 x86_69 installs but does not load any application

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114049

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
(In reply to Stephen Devane from comment #0)
> version 5.4.3.2 x86_69

That has no meaning, not one of our TinderBoxes. Where did your package come
from? If from a mirror, please verify your hash value against those listed in
the archive build "details" here:

https://downloadarchive.documentfoundation.org/libreoffice/old/5.4.3.2/win/x86/

Otherwise please uninstall, and do a CLI install package listed in this archive
and capture a verbose installation log.  That is, from a command window
(cmd.exe) run as Administrator: "msiexec.exe /i LibreOffice_5.4.3.2_Win_x86.msi
/L*v LO5432installLog.txt".

If the install with matching HASH value launches correctly--you're set.
Otherwise zip and post the verbose install log.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114029] LibreOffice Vanilla version not present in bugzilla list of LO versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114029

--- Comment #3 from Tor Lillqvist  ---
It's 327ad42f4b641f37cf4dd9936346bc386252669a (directly on the libreoffice-5-4
branch).

I chose to call it 5.4.3 for the user-visible version number because it is
close to that, but has a couple of more commits to the 5.4 branch. Also, it
would be even more misleading to call it 5.4.4 as that does not exist yet, does
it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114045] Undo after Clone Formatting changes formatting of entire table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114045

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl

--- Comment #4 from Telesto  ---
Repro with:
Version: 6.0.0.0.alpha1+
Build ID: c24c32bf71b8e64bd0d36e511f554e1f6c015842
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-11-22_23:15:41
Locale: nl-NL (nl_NL); Calc: group threaded

and with
Version: 5.2.5.0.0+
Build ID: 78223678b7513ffe46804cb08f2dc5bc899b2bab
CPU Threads: 4; OS Version: Windows 6.29; UI Render: default; 
Locale: nl-NL (nl_NL); Calc: CL

and with
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112989] Time required to export a large document has doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112989

--- Comment #23 from Telesto  ---
Created attachment 137988
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137988=edit
Example file

A fast way to reproduce:
1. Open the attached file
2. Hold scroll down & monitor CPU usage; CPU will be 25% with the new Text
Layout engine and 12% with the old one. Scrolling speed is fine, though

Repro on Windows, but not on Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114054] Weird orientation shift on printing letter size documents in Write

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114054

--- Comment #3 from Phil Pesek  ---
The problem appears to be Mac-specific.  The same file on Ubuntu 16.04 behaves
correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107495] An explicitly enabled contextual toolbar is always closing after exiting its contextual state

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107495

--- Comment #6 from Yousuf Philips (jay)  ---
(In reply to Telesto from comment #5)
> Setting it to LibreOffice, instead of Writer. 
> https://ask.libreoffice.org/en/question/138729/menu-item-problem-with-mac-os-
> high-sierra/

This link is unrelated to this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114040] Wrong dictionary autocorrection with stressed words ( in italian and french)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114040

Luca Perri  changed:

   What|Removed |Added

Summary|Wrong dictionary|Wrong dictionary
   |autocorrection with |autocorrection with
   |stressed words (in italian) |stressed words (in italian
   ||and french)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs