[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70666

Michael Stahl  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||624

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

Michael Stahl mst...@redhat.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=78340

--- Comment #17 from Michael Stahl mst...@redhat.com ---
appears to be fixed now, thanks! have filed a follow-up bug 78340 about
different rendering with non-printing characters enabled, which
had confused me quite a bit while verifying this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #13 from László Németh nem...@numbertext.org ---
(In reply to comment #12)
 On Fri, 04 Apr 2014 12:12:38 +
 bugzilla-dae...@freedesktop.org wrote:
 
  https://bugs.freedesktop.org/show_bug.cgi?id=70666
  
  --- Comment #9 from László Németh nem...@numbertext.org ---
  Martin: I have forgot to use the original gr_count_unicode_characters() in 
  my
  last patch. It works well, but is there a performance issue here?
  
  [Also I am very interested in the word and line end dependent font features,
  yet. Maybe I have to add an extra space here to fix the explicit space 
  related
  italic correction feature of Linux Libertine G.]
  
   mst__ 13.45.40
  nemeth, hello do i see it right that
  https://bugs.freedesktop.org/show_bug.cgi?id=70666 is fixed only on master 
  but
  not release branches? any reason why not?
   mst__: It seems, I have forgot it. (Precisely, I had an idea to change my 
   last patch to add the Graphite Unicode helper function, as in the 
   original code of Martin Hosken, maybe it would be an optimization, but I 
   haven’t done it. I will ask Martin in the issue.)
 
 If you are using UTF16, it is still worth using the
 gr_count_unicode_characters() in case there are any surrogate pairs in the
 text. If there are none, then the character count is the same as the number
 of words, but if there are any surrogate pairs then the count will be less
 than the number of words. In addition, the text reading code is strict about
 using the number of characters passed in. So if your number is too high, it
 will try to read beyond the end of the string even if there is a guard NULL
 there.
 
 BTW in case folks are feeling edgy about graphite's speed, there is special
 speedup code in there such that, for example, if you use Charis with plain
 old ASCII text, it will execute twice as fast as the new harfbuzz. OK, so to
 get that kind of speedup one does have to think about about one's gdl, but
 it's not that hard. And even without the speed up, it's about the same
 speed. gr_count_unicode_characters() is no slouch either.
 
 Yours,
 Martin

Martin, many thanks for your explanation! It seems, OUString of LibreOffice is
based on UTF-16, so I will restore gr_count_unicode_characters() call (as I
planned), combined with the hyphenation fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #14 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4a8cf5221f425118a7ec79e0cbf9cb0fb47bf823

fdo#70666 avoid only bad Graphite ligature replacement



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|BSA target:4.3.0|BSA target:4.3.0
   ||target:4.2.4

--- Comment #15 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to libreoffice-4-2:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9f132a147c5d0f92b66837bb5816eb2a2b700f2ch=libreoffice-4-2

fdo#70666 fix Graphite ligature replacement at line breaks


It will be available in LibreOffice 4.2.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #16 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to libreoffice-4-2:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bffdb3eefe6ae5a6a758c5401d3558724fbaaa05h=libreoffice-4-2

fdo#70666 avoid only bad Graphite ligature replacement


It will be available in LibreOffice 4.2.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #12 from martin_hos...@sil.org ---
On Fri, 04 Apr 2014 12:12:38 +
bugzilla-dae...@freedesktop.org wrote:

 https://bugs.freedesktop.org/show_bug.cgi?id=70666
 
 --- Comment #9 from László Németh nem...@numbertext.org ---
 Martin: I have forgot to use the original gr_count_unicode_characters() in my
 last patch. It works well, but is there a performance issue here?
 
 [Also I am very interested in the word and line end dependent font features,
 yet. Maybe I have to add an extra space here to fix the explicit space related
 italic correction feature of Linux Libertine G.]
 
  mst__ 13.45.40
 nemeth, hello do i see it right that
 https://bugs.freedesktop.org/show_bug.cgi?id=70666 is fixed only on master but
 not release branches? any reason why not?
  mst__: It seems, I have forgot it. (Precisely, I had an idea to change my 
  last patch to add the Graphite Unicode helper function, as in the original 
  code of Martin Hosken, maybe it would be an optimization, but I haven’t 
  done it. I will ask Martin in the issue.)

If you are using UTF16, it is still worth using the
gr_count_unicode_characters() in case there are any surrogate pairs in the
text. If there are none, then the character count is the same as the number of
words, but if there are any surrogate pairs then the count will be less than
the number of words. In addition, the text reading code is strict about using
the number of characters passed in. So if your number is too high, it will try
to read beyond the end of the string even if there is a guard NULL there.

BTW in case folks are feeling edgy about graphite's speed, there is special
speedup code in there such that, for example, if you use Charis with plain old
ASCII text, it will execute twice as fast as the new harfbuzz. OK, so to get
that kind of speedup one does have to think about about one's gdl, but it's not
that hard. And even without the speed up, it's about the same speed.
gr_count_unicode_characters() is no slouch either.

Yours,
Martin

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #9 from László Németh nem...@numbertext.org ---
Martin: I have forgot to use the original gr_count_unicode_characters() in my
last patch. It works well, but is there a performance issue here?

[Also I am very interested in the word and line end dependent font features,
yet. Maybe I have to add an extra space here to fix the explicit space related
italic correction feature of Linux Libertine G.]

 mst__ 13.45.40
nemeth, hello do i see it right that
https://bugs.freedesktop.org/show_bug.cgi?id=70666 is fixed only on master but
not release branches? any reason why not?
 mst__: It seems, I have forgot it. (Precisely, I had an idea to change my 
 last patch to add the Graphite Unicode helper function, as in the original 
 code of Martin Hosken, maybe it would be an optimization, but I haven’t done 
 it. I will ask Martin in the issue.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #10 from László Németh nem...@numbertext.org ---
Created attachment 96907
  -- https://bugs.freedesktop.org/attachment.cgi?id=96907action=edit
Layout problem (double diacritics)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

László Németh nem...@numbertext.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #11 from László Németh nem...@numbertext.org ---
Michael Stahl has noticed that this issue hasn't been solved completely, yet,
because it reports an older problem, too.

I have attached a test file for the second problem, containing the same words,
but two spaces before the word breaks the correct layout with an extra
diacritics).

 mst__: My fix is good for the problem caused by me.  It seems, LibreOffice 
 has never supported that diacritics correctly: before Graphite 2 integration, 
 there was only bad positions, with Graphite 2, double diacritics (in good and 
 the old wrong positions). So there are two different problems in this issue.  
 Interestingly, removing the text before the word fix the double diacritics 
 problem, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

László Németh nem...@numbertext.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from László Németh nem...@numbertext.org ---
The problem was the special status of the character (not a combining character,
but it acts like a combining character, see http://codepoints.net/U+0952). Now
every ligatures are replaced, except the lower case letters to fix the problem
of the hyphenation within the f and other western ligatures.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

Michael Stahl mst...@redhat.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=68313

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

Michael Stahl mst...@redhat.com changed:

   What|Removed |Added

 CC||nem...@numbertext.org
  Component|Writer  |graphics stack

--- Comment #5 from Michael Stahl mst...@redhat.com ---
regression from:

commit bb09c7c14bb1caf7b08b39944bda61382b158c64
Author: László Németh nem...@numbertext.org
AuthorDate: Fri Sep 6 11:08:02 2013 +0200

fdo#68313 fix combining diacritics problem with Graphite fonts

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

László Németh nem...@numbertext.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #6 from László Németh nem...@numbertext.org ---
I will fix it soon. Thanks for your bug report!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard|BSA |BSA target:4.3.0

--- Comment #7 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a831930986166a8c5cb231821426f5cf4d976df2

fdo#70666 fix Graphite ligature replacement at line breaks



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

Jorendc jore...@libreoffice.org changed:

   What|Removed |Added

  Attachment #87871|application/octet-stream|application/x-font-ttf
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@quipo.it,
   ||mst...@redhat.com
   Keywords||regression
 Ever confirmed|0   |1

--- Comment #4 from tommy27 ba...@quipo.it ---
issue confirmed under Win7 64bit with 4.1.3.2 
works fine with 4.1.2, 4.1.1 and 4.1.0

so it's a very recent regression of the 4.1.3.x codeline
I add Writer expert to CC list

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #1 from Floater floa...@yahoo.in ---
Created attachment 87869
  -- https://bugs.freedesktop.org/attachment.cgi?id=87869action=edit
Expected behaviour

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #2 from Floater floa...@yahoo.in ---
Created attachment 87870
  -- https://bugs.freedesktop.org/attachment.cgi?id=87870action=edit
odt file illustrating the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70666] EDITING: Diacritic placement problem with Graphite font

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70666

--- Comment #3 from Floater floa...@yahoo.in ---
Created attachment 87871
  -- https://bugs.freedesktop.org/attachment.cgi?id=87871action=edit
Graphite font file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs