Re: [libvirt] [RFC PATCH v1 4/4] xlconfigtest: add tests for numa cell sibling distances
On Thu, 22 Jun 2017 16:16:16 +0100 Joao Martins wrote: > On 06/12/2017 07:54 PM, Wim Ten Have wrote: > > From: Wim ten Have > > > > Test a bidirectional xen-xl domxml to and from native for numa > > support administration as brought under this patch series. > > > > Signed-off-by: Wim ten Have > > --- > > ... > > diff --git a/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml > > b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml > > new file mode 100644 > > index 000..a576881 > > --- /dev/null > > +++ b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml > > @@ -0,0 +1,54 @@ > > + > > + XenGuest2 > > + c7a5fdb2-cdaf-9455-926a-d65c16db1809 > > + 8388608 > > + 8388608 > > + 8 > > + > > +hvm > > +/usr/lib/xen/boot/hvmloader > > + > > + > > + > > + > > + > > + > > + > > + > > + > > We don't set/support topology info then it shouldn't be in the xml. Therefore > the test with nodistances will fail right? In that case should be > removed then. Right ... specific line should not be there. It sneaked in because i was playing with code supporting topology and unfortunate forgot to delete specific line in the test. Reason i forgot is that specific line does _NOT_ cause any issue to testing as for 'fullvirt-vnuma-nodistances' the CANONs can only go one-way (domxml to native). > > diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c > > +DO_TEST_PARSE("fullvirt-vnuma-nodistances", false); Going backwards (domxml from native) would create XML topics listing, ignorant, default distances generated making the -nodistance CANON match fail its xml representation. > Albeit the other test doesn't have element which is good :) Indeed ... was not suppost to be in. Thanks for spotting this one. I'll remove it under v2. Rgds, - Wim. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH v1 4/4] xlconfigtest: add tests for numa cell sibling distances
On 06/12/2017 07:54 PM, Wim Ten Have wrote: > From: Wim ten Have > > Test a bidirectional xen-xl domxml to and from native for numa > support administration as brought under this patch series. > > Signed-off-by: Wim ten Have > --- > .../test-fullvirt-vnuma-nodistances.cfg| 26 +++ > .../test-fullvirt-vnuma-nodistances.xml| 54 +++ > tests/xlconfigdata/test-fullvirt-vnuma.cfg | 26 +++ > tests/xlconfigdata/test-fullvirt-vnuma.xml | 81 > ++ > tests/xlconfigtest.c | 4 ++ > 5 files changed, 191 insertions(+) > create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg > create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml > create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma.cfg > create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma.xml > > diff --git a/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg > b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg > new file mode 100644 > index 000..9871f21 > --- /dev/null > +++ b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg > @@ -0,0 +1,26 @@ > +name = "XenGuest2" > +uuid = "c7a5fdb2-cdaf-9455-926a-d65c16db1809" > +maxmem = 8192 > +memory = 8192 > +vcpus = 8 > +pae = 1 > +acpi = 1 > +apic = 1 > +viridian = 0 > +rtc_timeoffset = 0 > +localtime = 0 > +on_poweroff = "destroy" > +on_reboot = "restart" > +on_crash = "restart" > +device_model = "/usr/lib/xen/bin/qemu-system-i386" > +sdl = 0 > +vnc = 1 > +vncunused = 1 > +vnclisten = "127.0.0.1" > +vif = [ "mac=00:16:3e:66:92:9c,bridge=xenbr1,script=vif-bridge,model=e1000" ] > +parallel = "none" > +serial = "none" > +builder = "hvm" > +boot = "d" > +vnuma = [ [ "pnode=0", "size=2048", "vcpus=0-1", "vdistances=10,21,21,21" ], > [ "pnode=1", "size=2048", "vcpus=2-3", "vdistances=21,10,21,21" ], [ > "pnode=2", "size=2048", "vcpus=4-5", "vdistances=21,21,10,21" ], [ "pnode=3", > "size=2048", "vcpus=6-7", "vdistances=21,21,21,10" ] ] > +disk = [ > "format=raw,vdev=hda,access=rw,backendtype=phy,target=/dev/HostVG/XenGuest2" ] > diff --git a/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml > b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml > new file mode 100644 > index 000..a576881 > --- /dev/null > +++ b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml > @@ -0,0 +1,54 @@ > + > + XenGuest2 > + c7a5fdb2-cdaf-9455-926a-d65c16db1809 > + 8388608 > + 8388608 > + 8 > + > +hvm > +/usr/lib/xen/boot/hvmloader > + > + > + > + > + > + > + > + > + We don't set/support topology info then it shouldn't be in the xml. Therefore the test with nodistances will fail right? In that case should be removed then. Albeit the other test doesn't have element which is good :) > + > + > + > + > + > + > + > + > + destroy > + restart > + restart > + > +/usr/lib/xen/bin/qemu-system-i386 > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > diff --git a/tests/xlconfigdata/test-fullvirt-vnuma.cfg > b/tests/xlconfigdata/test-fullvirt-vnuma.cfg > new file mode 100644 > index 000..91e233a > --- /dev/null > +++ b/tests/xlconfigdata/test-fullvirt-vnuma.cfg > @@ -0,0 +1,26 @@ > +name = "XenGuest2" > +uuid = "c7a5fdb2-cdaf-9455-926a-d65c16db1809" > +maxmem = 8192 > +memory = 8192 > +vcpus = 8 > +pae = 1 > +acpi = 1 > +apic = 1 > +viridian = 0 > +rtc_timeoffset = 0 > +localtime = 0 > +on_poweroff = "destroy" > +on_reboot = "restart" > +on_crash = "restart" > +device_model = "/usr/lib/xen/bin/qemu-system-i386" > +sdl = 0 > +vnc = 1 > +vncunused = 1 > +vnclisten = "127.0.0.1" > +vif = [ "mac=00:16:3e:66:92:9c,bridge=xenbr1,script=vif-bridge,model=e1000" ] > +parallel = "none" > +serial = "none" > +builder = "hvm" > +boot = "d" > +vnuma = [ [ "pnode=0", "size=2048", "vcpus=0-1", "vdistances=10,21,31,41" ], > [ "pnode=1", "size=2048", "vcpus=2-3", "vdistances=21,10,21,31" ], [ > "pnode=2", "size=2048", "vcpus=4-5", "vdistances=31,21,10,21" ], [ "pnode=3", > "size=2048", "vcpus=6-7", "vdistances=41,31,21,10" ] ] > +disk = [ > "format=raw,vdev=hda,access=rw,backendtype=phy,target=/dev/HostVG/XenGuest2" ] > diff --git a/tests/xlconfigdata/test-fullvirt-vnuma.xml > b/tests/xlconfigdata/test-fullvirt-vnuma.xml > new file mode 100644 > index 000..5368b0d > --- /dev/null > +++ b/tests/xlconfigdata/test-fullvirt-vnuma.xml > @@ -0,0 +1,81 @@ > + > + XenGuest2 > + c7a5fdb2-cdaf-9455-926a-d65c16db1809 > + 8388608 > + 8388608 > + 8 > + > +hvm > +/usr/lib/xen/boot/hvmloader > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > +
[libvirt] [RFC PATCH v1 4/4] xlconfigtest: add tests for numa cell sibling distances
From: Wim ten Have Test a bidirectional xen-xl domxml to and from native for numa support administration as brought under this patch series. Signed-off-by: Wim ten Have --- .../test-fullvirt-vnuma-nodistances.cfg| 26 +++ .../test-fullvirt-vnuma-nodistances.xml| 54 +++ tests/xlconfigdata/test-fullvirt-vnuma.cfg | 26 +++ tests/xlconfigdata/test-fullvirt-vnuma.xml | 81 ++ tests/xlconfigtest.c | 4 ++ 5 files changed, 191 insertions(+) create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-vnuma.xml diff --git a/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg new file mode 100644 index 000..9871f21 --- /dev/null +++ b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.cfg @@ -0,0 +1,26 @@ +name = "XenGuest2" +uuid = "c7a5fdb2-cdaf-9455-926a-d65c16db1809" +maxmem = 8192 +memory = 8192 +vcpus = 8 +pae = 1 +acpi = 1 +apic = 1 +viridian = 0 +rtc_timeoffset = 0 +localtime = 0 +on_poweroff = "destroy" +on_reboot = "restart" +on_crash = "restart" +device_model = "/usr/lib/xen/bin/qemu-system-i386" +sdl = 0 +vnc = 1 +vncunused = 1 +vnclisten = "127.0.0.1" +vif = [ "mac=00:16:3e:66:92:9c,bridge=xenbr1,script=vif-bridge,model=e1000" ] +parallel = "none" +serial = "none" +builder = "hvm" +boot = "d" +vnuma = [ [ "pnode=0", "size=2048", "vcpus=0-1", "vdistances=10,21,21,21" ], [ "pnode=1", "size=2048", "vcpus=2-3", "vdistances=21,10,21,21" ], [ "pnode=2", "size=2048", "vcpus=4-5", "vdistances=21,21,10,21" ], [ "pnode=3", "size=2048", "vcpus=6-7", "vdistances=21,21,21,10" ] ] +disk = [ "format=raw,vdev=hda,access=rw,backendtype=phy,target=/dev/HostVG/XenGuest2" ] diff --git a/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml new file mode 100644 index 000..a576881 --- /dev/null +++ b/tests/xlconfigdata/test-fullvirt-vnuma-nodistances.xml @@ -0,0 +1,54 @@ + + XenGuest2 + c7a5fdb2-cdaf-9455-926a-d65c16db1809 + 8388608 + 8388608 + 8 + +hvm +/usr/lib/xen/boot/hvmloader + + + + + + + + + + + + + + + + + + destroy + restart + restart + +/usr/lib/xen/bin/qemu-system-i386 + + + + + + + + + + + + + + + + + + + + + + + diff --git a/tests/xlconfigdata/test-fullvirt-vnuma.cfg b/tests/xlconfigdata/test-fullvirt-vnuma.cfg new file mode 100644 index 000..91e233a --- /dev/null +++ b/tests/xlconfigdata/test-fullvirt-vnuma.cfg @@ -0,0 +1,26 @@ +name = "XenGuest2" +uuid = "c7a5fdb2-cdaf-9455-926a-d65c16db1809" +maxmem = 8192 +memory = 8192 +vcpus = 8 +pae = 1 +acpi = 1 +apic = 1 +viridian = 0 +rtc_timeoffset = 0 +localtime = 0 +on_poweroff = "destroy" +on_reboot = "restart" +on_crash = "restart" +device_model = "/usr/lib/xen/bin/qemu-system-i386" +sdl = 0 +vnc = 1 +vncunused = 1 +vnclisten = "127.0.0.1" +vif = [ "mac=00:16:3e:66:92:9c,bridge=xenbr1,script=vif-bridge,model=e1000" ] +parallel = "none" +serial = "none" +builder = "hvm" +boot = "d" +vnuma = [ [ "pnode=0", "size=2048", "vcpus=0-1", "vdistances=10,21,31,41" ], [ "pnode=1", "size=2048", "vcpus=2-3", "vdistances=21,10,21,31" ], [ "pnode=2", "size=2048", "vcpus=4-5", "vdistances=31,21,10,21" ], [ "pnode=3", "size=2048", "vcpus=6-7", "vdistances=41,31,21,10" ] ] +disk = [ "format=raw,vdev=hda,access=rw,backendtype=phy,target=/dev/HostVG/XenGuest2" ] diff --git a/tests/xlconfigdata/test-fullvirt-vnuma.xml b/tests/xlconfigdata/test-fullvirt-vnuma.xml new file mode 100644 index 000..5368b0d --- /dev/null +++ b/tests/xlconfigdata/test-fullvirt-vnuma.xml @@ -0,0 +1,81 @@ + + XenGuest2 + c7a5fdb2-cdaf-9455-926a-d65c16db1809 + 8388608 + 8388608 + 8 + +hvm +/usr/lib/xen/boot/hvmloader + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + destroy + restart + restart + +/usr/lib/xen/bin/qemu-system-i386 + + + + + + + + + + + + + + + + + + + + + + + diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c index 3fe4298..b5c6891 100644 --- a/tests/xlconfigtest.c +++ b/tests/xlconfigtest.c @@ -270,6 +270,10 @@ mymain(void) DO_TEST("fullvirt-multi-timer");