Re: [libvirt] [jenkins-ci PATCH v2 0/3] Add libvirt-ocaml
On Fri, 2018-11-02 at 12:21 +0100, Pino Toscano wrote: > > Either way, I'll have to apply changes to the live CI > > environment as you don't have any permissions there... > > Feel free to start the update magic, please ;) Done. https://ci.centos.org/view/libvirt/job/libvirt-ocaml-build/ Note that it failed to build on FreeBSD 10, so you'll probably want to look into that. Once you've done that, please also consider * adding an autogen.sh script to libvirt-ocaml, even if it ends up just calling autoreconf, and * introducing some sort of test suite that can be run with 'make check' as suggested during earlier discussion. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH v2 0/3] Add libvirt-ocaml
On Friday, 2 November 2018 12:08:22 CET Andrea Bolognani wrote: > On Mon, 2018-10-22 at 19:02 +0200, Pino Toscano wrote: > > Now that the libvirt-ocaml repository is fixed, let's build it in CI. > > > > Changes from v1 to v2: > > - split according to Andrea's hints > > - removed --with-libvirt as argument for configure, no more needed > > after upstream changes > > > > Pino Toscano (3): > > guests: add mappings for OCaml components > > guests: pull dependencies for libvirt-ocaml > > Add libvirt-ocaml project > > Reviewed-by: Andrea Bolognani > > Do you plan on pushing these yourself, or do you want me to take > care of it? I just pushed them, with Erik's and yours R-b. > Either way, I'll have to apply changes to the live CI > environment as you don't have any permissions there... Feel free to start the update magic, please ;) Thanks, -- Pino Toscano signature.asc Description: This is a digitally signed message part. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH v2 0/3] Add libvirt-ocaml
On Mon, 2018-10-22 at 19:02 +0200, Pino Toscano wrote: > Now that the libvirt-ocaml repository is fixed, let's build it in CI. > > Changes from v1 to v2: > - split according to Andrea's hints > - removed --with-libvirt as argument for configure, no more needed > after upstream changes > > Pino Toscano (3): > guests: add mappings for OCaml components > guests: pull dependencies for libvirt-ocaml > Add libvirt-ocaml project Reviewed-by: Andrea Bolognani Do you plan on pushing these yourself, or do you want me to take care of it? Either way, I'll have to apply changes to the live CI environment as you don't have any permissions there... -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH v2 0/3] Add libvirt-ocaml
On Mon, Oct 22, 2018 at 07:02:24PM +0200, Pino Toscano wrote: > Now that the libvirt-ocaml repository is fixed, let's build it in CI. > > Changes from v1 to v2: > - split according to Andrea's hints > - removed --with-libvirt as argument for configure, no more needed > after upstream changes Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [jenkins-ci PATCH v2 0/3] Add libvirt-ocaml
Now that the libvirt-ocaml repository is fixed, let's build it in CI. Changes from v1 to v2: - split according to Andrea's hints - removed --with-libvirt as argument for configure, no more needed after upstream changes Pino Toscano (3): guests: add mappings for OCaml components guests: pull dependencies for libvirt-ocaml Add libvirt-ocaml project guests/host_vars/libvirt-centos-7/main.yml| 1 + guests/host_vars/libvirt-debian-9/main.yml| 1 + guests/host_vars/libvirt-debian-sid/main.yml | 1 + guests/host_vars/libvirt-fedora-27/main.yml | 1 + guests/host_vars/libvirt-fedora-28/main.yml | 1 + .../host_vars/libvirt-fedora-rawhide/main.yml | 1 + guests/host_vars/libvirt-freebsd-10/main.yml | 1 + guests/host_vars/libvirt-freebsd-11/main.yml | 1 + .../libvirt-freebsd-current/main.yml | 1 + guests/host_vars/libvirt-ubuntu-16/main.yml | 1 + guests/host_vars/libvirt-ubuntu-18/main.yml | 1 + guests/playbooks/build/jobs/defaults.yml | 2 ++ .../build/projects/libvirt-ocaml.yml | 27 +++ guests/vars/mappings.yml | 6 + guests/vars/projects/libvirt-ocaml.yml| 5 jobs/defaults.yaml| 2 ++ projects/libvirt-ocaml.yaml | 23 17 files changed, 76 insertions(+) create mode 100644 guests/playbooks/build/projects/libvirt-ocaml.yml create mode 100644 guests/vars/projects/libvirt-ocaml.yml create mode 100644 projects/libvirt-ocaml.yaml -- 2.17.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list