Re: [libvirt] [PATCH] tests: fix QED disk test in xlconfigtest
On 01/17/2017 04:39 AM, Joao Martins wrote: On 01/16/2017 06:45 PM, Jim Fehlig wrote: When LIBXL_HAVE_QED is defined, xlconfigtest fails 9) Xen XL-2-XML Format disk-qed ... command line: config parsing error in disk specification: no vdev specified in `target=/var/lib/libvirt/images/XenGuest2,format=qed,backendtype=qdisk,vdev=hda,access=rw' FAILED As per the xl-disk-configuration(5) man page, target= must come last in the disk specification when specified by name: When this parameter is specified by name, ie with the target= syntax in the configuration file, it consumes the whole rest of the DISKSPEC including trailing whitespaces. Therefore in that case it must come last. Change tests/xlconfigdata/test-disk-qed.cfg to adhere to this restriction. Signed-off-by: Jim Fehlig Looks like Xen's osstest job doesn't run "make check" on the libvirt test case. Right, otherwise we would have seen this earlier. FWIW: Acked-by: Joao Martins Thanks. I've pushed this now since it is a build-breaker with xen-unstable. Regards, Jim --- tests/xlconfigdata/test-disk-qed.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/xlconfigdata/test-disk-qed.cfg b/tests/xlconfigdata/test-disk-qed.cfg index ee904e0..7842176 100644 --- a/tests/xlconfigdata/test-disk-qed.cfg +++ b/tests/xlconfigdata/test-disk-qed.cfg @@ -22,4 +22,4 @@ parallel = "none" serial = "none" builder = "hvm" boot = "d" -disk = [ "target=/var/lib/libvirt/images/XenGuest2,format=qed,backendtype=qdisk,vdev=hda,access=rw" ] +disk = [ "format=qed,backendtype=qdisk,vdev=hda,access=rw,target=/var/lib/libvirt/images/XenGuest2" ] -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tests: fix QED disk test in xlconfigtest
On 01/16/2017 06:45 PM, Jim Fehlig wrote: > When LIBXL_HAVE_QED is defined, xlconfigtest fails > > 9) Xen XL-2-XML Format disk-qed ... command line: config parsing error > in disk specification: no vdev specified in > > `target=/var/lib/libvirt/images/XenGuest2,format=qed,backendtype=qdisk,vdev=hda,access=rw' > FAILED > > As per the xl-disk-configuration(5) man page, target= must come > last in the disk specification when specified by name: > > When this parameter is specified by name, ie with the target= > syntax in the configuration file, it consumes the whole rest of the > DISKSPEC including trailing whitespaces. Therefore in that case > it must come last. > > Change tests/xlconfigdata/test-disk-qed.cfg to adhere to this > restriction. > > Signed-off-by: Jim Fehlig Looks like Xen's osstest job doesn't run "make check" on the libvirt test case. FWIW: Acked-by: Joao Martins > --- > tests/xlconfigdata/test-disk-qed.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/xlconfigdata/test-disk-qed.cfg > b/tests/xlconfigdata/test-disk-qed.cfg > index ee904e0..7842176 100644 > --- a/tests/xlconfigdata/test-disk-qed.cfg > +++ b/tests/xlconfigdata/test-disk-qed.cfg > @@ -22,4 +22,4 @@ parallel = "none" > serial = "none" > builder = "hvm" > boot = "d" > -disk = [ > "target=/var/lib/libvirt/images/XenGuest2,format=qed,backendtype=qdisk,vdev=hda,access=rw" > ] > +disk = [ > "format=qed,backendtype=qdisk,vdev=hda,access=rw,target=/var/lib/libvirt/images/XenGuest2" > ] > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
