Re: [PATCH] PKCS#7: fix missing break on OID_sha224 case
Colin King wrote: > From: Colin Ian King > > The OID_sha224 case is missing a break and it falls through > to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems > to be supported, this looks like an unintentional missing break. > > Fixes: 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash > algos and use them") > Cc: # 4.2+ > Signed-off-by: Colin Ian King Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] PKCS#7: fix missing break on OID_sha224 case
On Fri, Mar 18, 2016 at 03:51:31PM +, Colin King wrote: > From: Colin Ian King > > The OID_sha224 case is missing a break and it falls through > to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems > to be supported, this looks like an unintentional missing break. > > Fixes: 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash > algos and use them") > Cc: # 4.2+ > Signed-off-by: Colin Ian King Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] PKCS#7: fix missing break on OID_sha224 case
From: Colin Ian King The OID_sha224 case is missing a break and it falls through to the -ENOPKG error default. Since HASH_ALGO_SHA224 seems to be supported, this looks like an unintentional missing break. Fixes: 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them") Cc: # 4.2+ Signed-off-by: Colin Ian King --- crypto/asymmetric_keys/pkcs7_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c index 40de03f..bdd0d753 100644 --- a/crypto/asymmetric_keys/pkcs7_parser.c +++ b/crypto/asymmetric_keys/pkcs7_parser.c @@ -237,6 +237,7 @@ int pkcs7_sig_note_digest_algo(void *context, size_t hdrlen, break; case OID_sha224: ctx->sinfo->sig.hash_algo = "sha224"; + break; default: printk("Unsupported digest algo: %u\n", ctx->last_oid); return -ENOPKG; -- 2.7.3 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html