Re: [PATCH 7/9] crypto: picoxcell - don't leak pointers to authenc keys

[Jamie Iles]

On Wed, Mar 21, 2018 at 07:00:55PM +0200, Tudor Ambarus wrote:
> Signed-off-by: Tudor Ambarus 

Reviewed-by: Jamie Iles 

> ---
>  drivers/crypto/picoxcell_crypto.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/picoxcell_crypto.c 
> b/drivers/crypto/picoxcell_crypto.c
> index 4ef52c9..a4df966 100644
> --- a/drivers/crypto/picoxcell_crypto.c
> +++ b/drivers/crypto/picoxcell_crypto.c
> @@ -499,10 +499,12 @@ static int spacc_aead_setkey(struct crypto_aead *tfm, 
> const u8 *key,
>   memcpy(ctx->hash_ctx, keys.authkey, keys.authkeylen);
>   ctx->hash_key_len = keys.authkeylen;
>  
> + memzero_explicit(&keys, sizeof(keys));
>   return 0;
>  
>  badkey:
>   crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);
> + memzero_explicit(&keys, sizeof(keys));
>   return -EINVAL;
>  }
>  
> -- 
> 2.9.4
> 

[PATCH 7/9] crypto: picoxcell - don't leak pointers to authenc keys

[Tudor Ambarus]

Signed-off-by: Tudor Ambarus 
---
 drivers/crypto/picoxcell_crypto.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/picoxcell_crypto.c 
b/drivers/crypto/picoxcell_crypto.c
index 4ef52c9..a4df966 100644
--- a/drivers/crypto/picoxcell_crypto.c
+++ b/drivers/crypto/picoxcell_crypto.c
@@ -499,10 +499,12 @@ static int spacc_aead_setkey(struct crypto_aead *tfm, 
const u8 *key,
memcpy(ctx->hash_ctx, keys.authkey, keys.authkeylen);
ctx->hash_key_len = keys.authkeylen;
 
+   memzero_explicit(&keys, sizeof(keys));
return 0;
 
 badkey:
crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN);
+   memzero_explicit(&keys, sizeof(keys));
return -EINVAL;
 }
 
-- 
2.9.4