Re: export pcie_flr and remove copies of it in drivers V2
On Wed, Apr 19, 2017 at 08:37:37AM +0300, Leon Romanovsky wrote: > On Tue, Apr 18, 2017 at 01:36:12PM -0500, Bjorn Helgaas wrote: > > On Fri, Apr 14, 2017 at 09:11:24PM +0200, Christoph Hellwig wrote: > > > Hi all, > > > > > > this exports the PCI layer pcie_flr helper, and removes various opencoded > > > copies of it. > > > > > > Changes since V1: > > > - rebase on top of the pci/virtualization branch > > > - fixed the probe case in __pci_dev_reset > > > - added ACKs from Bjorn > > > > Applied the first three patches: > > > > bc13871ef35a PCI: Export pcie_flr() > > e641c375d414 PCI: Call pcie_flr() from reset_intel_82599_sfp_virtfn() > > 40e0901ea4bf PCI: Call pcie_flr() from reset_chelsio_generic_dev() > > > > Bjorn, > > How do you suggest to proceed with other patches? They should be applied > to your tree either, because they depend on "bc13871ef35a PCI: Export > pcie_flr()". I finally caught the old emails and found the answer by myself. http://marc.info/?l=linux-rdma&m=149218545228343&w=2 Thanks > > Thanks > > > > to pci/virtualization for v4.12, thanks! signature.asc Description: PGP signature
Re: export pcie_flr and remove copies of it in drivers V2
On Tue, Apr 18, 2017 at 01:36:12PM -0500, Bjorn Helgaas wrote: > On Fri, Apr 14, 2017 at 09:11:24PM +0200, Christoph Hellwig wrote: > > Hi all, > > > > this exports the PCI layer pcie_flr helper, and removes various opencoded > > copies of it. > > > > Changes since V1: > > - rebase on top of the pci/virtualization branch > > - fixed the probe case in __pci_dev_reset > > - added ACKs from Bjorn > > Applied the first three patches: > > bc13871ef35a PCI: Export pcie_flr() > e641c375d414 PCI: Call pcie_flr() from reset_intel_82599_sfp_virtfn() > 40e0901ea4bf PCI: Call pcie_flr() from reset_chelsio_generic_dev() > Bjorn, How do you suggest to proceed with other patches? They should be applied to your tree either, because they depend on "bc13871ef35a PCI: Export pcie_flr()". Thanks > to pci/virtualization for v4.12, thanks! signature.asc Description: PGP signature
Re: export pcie_flr and remove copies of it in drivers V2
On Fri, Apr 14, 2017 at 09:11:24PM +0200, Christoph Hellwig wrote: > Hi all, > > this exports the PCI layer pcie_flr helper, and removes various opencoded > copies of it. > > Changes since V1: > - rebase on top of the pci/virtualization branch > - fixed the probe case in __pci_dev_reset > - added ACKs from Bjorn Applied the first three patches: bc13871ef35a PCI: Export pcie_flr() e641c375d414 PCI: Call pcie_flr() from reset_intel_82599_sfp_virtfn() 40e0901ea4bf PCI: Call pcie_flr() from reset_chelsio_generic_dev() to pci/virtualization for v4.12, thanks!
export pcie_flr and remove copies of it in drivers V2
Hi all, this exports the PCI layer pcie_flr helper, and removes various opencoded copies of it. Changes since V1: - rebase on top of the pci/virtualization branch - fixed the probe case in __pci_dev_reset - added ACKs from Bjorn
Re: export pcie_flr and remove copies of it in drivers
On Fri, Apr 14, 2017 at 09:51:48AM -0500, Bjorn Helgaas wrote:
> > Otherwise, I'd be glad to take the series given acks for the non-PCI
> > parts. Just let me know.
>
> I do already have a patch (c5e4f0192ad2 ("PCI: Avoid FLR for Intel
> 82579 NICs")) on my pci/virtualization branch that touches pcie_flr()
> and will conflict with this one.
I'll take a look and will resend on top of that branch.
Re: export pcie_flr and remove copies of it in drivers
On Fri, Apr 14, 2017 at 09:41:08AM -0500, Bjorn Helgaas wrote: > Looks good to me (except the comment on probe). If you want to apply > the whole series via netdev or some non-PCI tree, here's my ack for > the drivers/pci parts, assuming the probe thing is resolved: > > Acked-by: Bjorn Helgaas > > Otherwise, I'd be glad to take the series given acks for the non-PCI > parts. Just let me know. I guess the best would be if you take the first three patches (once resent) for the PCI tree for 4.12, then we can do the other patches in the next merge window.
Re: export pcie_flr and remove copies of it in drivers
On Fri, Apr 14, 2017 at 9:41 AM, Bjorn Helgaas wrote:
> On Thu, Apr 13, 2017 at 04:53:32PM +0200, Christoph Hellwig wrote:
>> Hi all,
>>
>> this exports the PCI layer pcie_flr helper, and removes various opencoded
>> copies of it.
>
> Looks good to me (except the comment on probe). If you want to apply
> the whole series via netdev or some non-PCI tree, here's my ack for
> the drivers/pci parts, assuming the probe thing is resolved:
>
> Acked-by: Bjorn Helgaas
>
> Otherwise, I'd be glad to take the series given acks for the non-PCI
> parts. Just let me know.
I do already have a patch (c5e4f0192ad2 ("PCI: Avoid FLR for Intel
82579 NICs")) on my pci/virtualization branch that touches pcie_flr()
and will conflict with this one.
Re: export pcie_flr and remove copies of it in drivers
On Thu, Apr 13, 2017 at 04:53:32PM +0200, Christoph Hellwig wrote: > Hi all, > > this exports the PCI layer pcie_flr helper, and removes various opencoded > copies of it. Looks good to me (except the comment on probe). If you want to apply the whole series via netdev or some non-PCI tree, here's my ack for the drivers/pci parts, assuming the probe thing is resolved: Acked-by: Bjorn Helgaas Otherwise, I'd be glad to take the series given acks for the non-PCI parts. Just let me know. Bjorn
export pcie_flr and remove copies of it in drivers
Hi all, this exports the PCI layer pcie_flr helper, and removes various opencoded copies of it.
