Re: [RESEND/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks
suspend/resume order depends on probe ordering, so with deferred probe, the probe ordering might be right, but it should be thoroughly tested. Thanks a lot for the input here, Kevin! signature.asc Description: Digital signature
Re: [RESEND/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks
On 10/20/2014 06:07 PM, Kevin Hilman wrote:
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes:
The _noirq were previously chosen to make sure all the users of the
adapter were suspended by the time the adapter itself enters the
suspended state.
The {suspend,resume}_noirq usage was converted from an earlier
implementation based on suspend_late and resume_early on this commit:
commit 57f4d4f1b72983f8c76e2f232e064730aeffe599
Author: Magnus Damm d...@igel.co.jp
Date: Wed Jul 8 13:22:39 2009 +0200
I2C: Rework i2c-pxa suspend_late()/resume_early()
However, all the I2C devices are probed as children of its I2C adapter,
and hence the device model guarantees they are suspended before its parent,
and
resumed after it.
In other words, there's no need to use the _noirq hooks to get a
suspend/resume
device/adapter order.
Are you sure *really* about this?
Hm, now you made me doubt.
It's usally not the children that are the problem here. It's usually
some other driver trying to use an I2C device e.g. MMC changing voltage
using an I2C-based PMIC during its suspend process.
So we can't know for sure if using suspend/resume is going to work OK for
a I2C adapter?
There might be some use of it that can't be accurately modeled in the
device model.
I.e., the above example is a dependency of MMC on the I2C being suspended
after him, but right now there's no way to model such relationship.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
signature.asc
Description: OpenPGP digital signature
Re: [RESEND/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes:
On 10/20/2014 06:07 PM, Kevin Hilman wrote:
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes:
The _noirq were previously chosen to make sure all the users of the
adapter were suspended by the time the adapter itself enters the
suspended state.
The {suspend,resume}_noirq usage was converted from an earlier
implementation based on suspend_late and resume_early on this commit:
commit 57f4d4f1b72983f8c76e2f232e064730aeffe599
Author: Magnus Damm d...@igel.co.jp
Date: Wed Jul 8 13:22:39 2009 +0200
I2C: Rework i2c-pxa suspend_late()/resume_early()
However, all the I2C devices are probed as children of its I2C adapter,
and hence the device model guarantees they are suspended before its parent,
and
resumed after it.
In other words, there's no need to use the _noirq hooks to get a
suspend/resume
device/adapter order.
Are you sure *really* about this?
Hm, now you made me doubt.
Good. :)
It's usally not the children that are the problem here. It's usually
some other driver trying to use an I2C device e.g. MMC changing voltage
using an I2C-based PMIC during its suspend process.
So we can't know for sure if using suspend/resume is going to work OK for
a I2C adapter?
There might be some use of it that can't be accurately modeled in the
device model.
Correct.
I.e., the above example is a dependency of MMC on the I2C being suspended
after him, but right now there's no way to model such relationship.
That's right. That's why many i2c drivers are using the late/early
callbacks for suspend/resume.
suspend/resume order depends on probe ordering, so with deferred probe,
the probe ordering might be right, but it should be thoroughly tested.
Kevin
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[RESEND/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks
The _noirq were previously chosen to make sure all the users of the
adapter were suspended by the time the adapter itself enters the
suspended state.
The {suspend,resume}_noirq usage was converted from an earlier
implementation based on suspend_late and resume_early on this commit:
commit 57f4d4f1b72983f8c76e2f232e064730aeffe599
Author: Magnus Damm d...@igel.co.jp
Date: Wed Jul 8 13:22:39 2009 +0200
I2C: Rework i2c-pxa suspend_late()/resume_early()
However, all the I2C devices are probed as children of its I2C adapter,
and hence the device model guarantees they are suspended before its parent, and
resumed after it.
In other words, there's no need to use the _noirq hooks to get a suspend/resume
device/adapter order.
This commit changes this by using the suspend/resume PM hooks in the I2C
adapter.
Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar
---
Tested on a PXA CM-X300 board with a vendor-provided patch to make
suspend/resume work properly.
Now that the merge window is closed, I'm resending this rebased on
v3.18-rc1.
drivers/i2c/busses/i2c-pxa.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index be671f7..3be19b36 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1292,7 +1292,7 @@ static int i2c_pxa_remove(struct platform_device *dev)
}
#ifdef CONFIG_PM
-static int i2c_pxa_suspend_noirq(struct device *dev)
+static int i2c_pxa_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct pxa_i2c *i2c = platform_get_drvdata(pdev);
@@ -1302,7 +1302,7 @@ static int i2c_pxa_suspend_noirq(struct device *dev)
return 0;
}
-static int i2c_pxa_resume_noirq(struct device *dev)
+static int i2c_pxa_resume(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct pxa_i2c *i2c = platform_get_drvdata(pdev);
@@ -1314,8 +1314,8 @@ static int i2c_pxa_resume_noirq(struct device *dev)
}
static const struct dev_pm_ops i2c_pxa_dev_pm_ops = {
- .suspend_noirq = i2c_pxa_suspend_noirq,
- .resume_noirq = i2c_pxa_resume_noirq,
+ .suspend = i2c_pxa_suspend,
+ .resume = i2c_pxa_resume,
};
#define I2C_PXA_DEV_PM_OPS (i2c_pxa_dev_pm_ops)
--
2.1.0
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
