RE: [PATCH 00/12] lis3 accelerator feature update

2010-10-25 Thread samu.p.onkalo
-Original Message-
From: linux-i2c-ow...@vger.kernel.org [mailto:linux-i2c-
ow...@vger.kernel.org] On Behalf Of ext Éric Piel

Op 22-10-10 13:57, Samu Onkalo schreef:
 Changes are tested only with I2C interface using 8bit sensor since I
don't
 have other possibilities. Some features are not enabled
 by default since I can't test them with all possible configurations.
 Platform data contains field which controls new features.
Thanks Samu for persevering with the automatic power down feature.
Hopefully I'll find also some time to activate it on the hp_accel side.

For now, I've reviewed the changes and everything looked fine, as well
as tested them on my HP laptop (with a 12 bits sensor). Although most of
the changes are not visible on this platform, at least there shouldn't
be any regression.


Thanks for the review.

-Samu
 
N�r��yb�X��ǧv�^�)޺{.n�+{��g��^n�r���z���h����G���h�(�階�ݢj���m��z�ޖ���f���h���~�m�

Re: [PATCH 00/12] lis3 accelerator feature update

2010-10-24 Thread Éric Piel

Op 22-10-10 13:57, Samu Onkalo schreef:

Changes are tested only with I2C interface using 8bit sensor since I don't
have other possibilities. Some features are not enabled
by default since I can't test them with all possible configurations.
Platform data contains field which controls new features.
Thanks Samu for persevering with the automatic power down feature. 
Hopefully I'll find also some time to activate it on the hp_accel side.


For now, I've reviewed the changes and everything looked fine, as well 
as tested them on my HP laptop (with a 12 bits sensor). Although most of 
the changes are not visible on this platform, at least there shouldn't 
be any regression.


Thanks,
Eric
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 00/12] lis3 accelerator feature update

2010-10-24 Thread Guenter Roeck
On Sun, Oct 24, 2010 at 11:05:33AM -0400, Éric Piel wrote:
 Op 22-10-10 13:57, Samu Onkalo schreef:
  Changes are tested only with I2C interface using 8bit sensor since I don't
  have other possibilities. Some features are not enabled
  by default since I can't test them with all possible configurations.
  Platform data contains field which controls new features.
 Thanks Samu for persevering with the automatic power down feature. 
 Hopefully I'll find also some time to activate it on the hp_accel side.
 
 For now, I've reviewed the changes and everything looked fine, as well 
 as tested them on my HP laptop (with a 12 bits sensor). Although most of 
 the changes are not visible on this platform, at least there shouldn't 
 be any regression.
 
Great, thanks.

Unfortunately, the patches don't apply to my staging branch, probably
because of the other pending lis3 changes.

Samu, please rebase your patches to 
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging.git 
hwmon-next
and resubmit.

Thanks,
Guenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 00/12] lis3 accelerator feature update

2010-10-22 Thread Guenter Roeck
On Fri, 2010-10-22 at 07:57 -0400, Samu Onkalo wrote:
 Changes are tested only with I2C interface using 8bit sensor since I don't
 have other possibilities. Some features are not enabled
 by default since I can't test them with all possible configurations.
 Platform data contains field which controls new features.
 
[ ... ]
 
 Samu Onkalo (12):
   hwmon: lis3: pm_runtime support
   hwmon: lis3: regulator control
   hwmon: lis3: Cleanup interrupt handling
   hwmon: lis3: Update coordinates at polled device open
   hwmon: lis3: Power on corrections
   hwmon: lis3: restore axis enabled bits
   hwmon: lis3: New parameters to platform data
   hwmon: lis3: Adjust fuzziness for 8 bit device
   hwmon: lis3: use block read to access data registers
   hwmon: lis3: Enhance lis3 selftest with IRQ line test
   hwmon: lis3: Short explanations of platform data fields
   hwmon: lis3: Release resources is case of failure
 
  drivers/hwmon/lis3lv02d.c |  304 ++--
  drivers/hwmon/lis3lv02d.h |   18 +++
  drivers/hwmon/lis3lv02d_i2c.c |  127 +++--
  drivers/hwmon/lis3lv02d_spi.c |2 +-
  include/linux/lis3lv02d.h |   50 +++-
  5 files changed, 439 insertions(+), 62 deletions(-)
 
Eric, can you Ack this series ?

Guenter


--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 00/12] lis3 accelerator feature update

2010-10-22 Thread Éric Piel
Op 22-10-10 22:08, Guenter Roeck schreef:
 On Fri, 2010-10-22 at 07:57 -0400, Samu Onkalo wrote:
 Changes are tested only with I2C interface using 8bit sensor since I don't
 have other possibilities. Some features are not enabled
 by default since I can't test them with all possible configurations.
 Platform data contains field which controls new features.

 [ ... ]

 Samu Onkalo (12):
   hwmon: lis3: pm_runtime support
   hwmon: lis3: regulator control
   hwmon: lis3: Cleanup interrupt handling
   hwmon: lis3: Update coordinates at polled device open
   hwmon: lis3: Power on corrections
   hwmon: lis3: restore axis enabled bits
   hwmon: lis3: New parameters to platform data
   hwmon: lis3: Adjust fuzziness for 8 bit device
   hwmon: lis3: use block read to access data registers
   hwmon: lis3: Enhance lis3 selftest with IRQ line test
   hwmon: lis3: Short explanations of platform data fields
   hwmon: lis3: Release resources is case of failure

  drivers/hwmon/lis3lv02d.c |  304 
 ++--
  drivers/hwmon/lis3lv02d.h |   18 +++
  drivers/hwmon/lis3lv02d_i2c.c |  127 +++--
  drivers/hwmon/lis3lv02d_spi.c |2 +-
  include/linux/lis3lv02d.h |   50 +++-
  5 files changed, 439 insertions(+), 62 deletions(-)

 Eric, can you Ack this series ?
Hi, I'll try to review, test and ack the series this weekend :-)

Eric
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 00/12] lis3 accelerator feature update

2010-10-22 Thread Guenter Roeck
On Fri, Oct 22, 2010 at 07:44:48PM -0400, Éric Piel wrote:
 Op 22-10-10 22:08, Guenter Roeck schreef:
  On Fri, 2010-10-22 at 07:57 -0400, Samu Onkalo wrote:
  Changes are tested only with I2C interface using 8bit sensor since I don't
  have other possibilities. Some features are not enabled
  by default since I can't test them with all possible configurations.
  Platform data contains field which controls new features.
 
  [ ... ]
 
  Samu Onkalo (12):
hwmon: lis3: pm_runtime support
hwmon: lis3: regulator control
hwmon: lis3: Cleanup interrupt handling
hwmon: lis3: Update coordinates at polled device open
hwmon: lis3: Power on corrections
hwmon: lis3: restore axis enabled bits
hwmon: lis3: New parameters to platform data
hwmon: lis3: Adjust fuzziness for 8 bit device
hwmon: lis3: use block read to access data registers
hwmon: lis3: Enhance lis3 selftest with IRQ line test
hwmon: lis3: Short explanations of platform data fields
hwmon: lis3: Release resources is case of failure
 
   drivers/hwmon/lis3lv02d.c |  304 
  ++--
   drivers/hwmon/lis3lv02d.h |   18 +++
   drivers/hwmon/lis3lv02d_i2c.c |  127 +++--
   drivers/hwmon/lis3lv02d_spi.c |2 +-
   include/linux/lis3lv02d.h |   50 +++-
   5 files changed, 439 insertions(+), 62 deletions(-)
 
  Eric, can you Ack this series ?
 Hi, I'll try to review, test and ack the series this weekend :-)
 
Thanks!

Guenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html