Re: [PATCH] libata and starting/stopping ATAPI floppy devices
Ondrej Zary wrote: > Hello, > I switched to libata drivers for my onboard PATA controller (PIIX4) recently. > Everything works fine except that kernel tries to start not only my hard > drive (sda) but also LS-120 floppy drive (sdb) which does not like it: > > sd 0:0:0:0: [sda] Starting disk > ata1.00: configured for UDMA/33 > sd 0:0:0:0: [sda] 58633344 512-byte hardware sectors (30020 MB) > sd 0:0:0:0: [sda] Write Protect is off > sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support > DPO or FUA > sd 1:0:1:0: [sdb] Starting disk > ata2.00: configured for UDMA/33 > ata2.01: configured for PIO2 > sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 > sd 1:0:1:0: [sdb] Sense Key : 0x2 [current] > sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 > > > The question is: is it correct? Or a patch like this should be applied? Yeah, looks good to me. Please reformat the message w/ S-O-B. Acked-by: Tejun Heo <[EMAIL PROTECTED]> -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata and starting/stopping ATAPI floppy devices
On Wednesday 09 January 2008 03:41:16 Tejun Heo wrote: > Ondrej Zary wrote: > > Hello, > > I switched to libata drivers for my onboard PATA controller (PIIX4) > > recently. Everything works fine except that kernel tries to start not > > only my hard drive (sda) but also LS-120 floppy drive (sdb) which does > > not like it: > > > > sd 0:0:0:0: [sda] Starting disk > > ata1.00: configured for UDMA/33 > > sd 0:0:0:0: [sda] 58633344 512-byte hardware sectors (30020 MB) > > sd 0:0:0:0: [sda] Write Protect is off > > sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't > > support DPO or FUA > > sd 1:0:1:0: [sdb] Starting disk > > ata2.00: configured for UDMA/33 > > ata2.01: configured for PIO2 > > sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 > > sd 1:0:1:0: [sdb] Sense Key : 0x2 [current] > > sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 > > > > > > The question is: is it correct? Or a patch like this should be applied? > > Yeah, looks good to me. Please reformat the message w/ S-O-B. > > Acked-by: Tejun Heo <[EMAIL PROTECTED]> Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy drives) as they don't seem to like it: sd 1:0:1:0: [sdb] Starting disk ata2.01: configured for PIO2 sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 sd 1:0:1:0: [sdb] Sense Key : 0x2 [current] sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 Signed-off-by: Ondrej Zary <[EMAIL PROTECTED]> --- linux-2.6.23-orig/drivers/ata/libata-scsi.c 2007-10-09 22:31:38.0 +0200 +++ linux-2.6.23-pentium/drivers/ata/libata-scsi.c 2008-01-05 15:50:16.0 +0100 @@ -802,7 +802,8 @@ blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD); - sdev->manage_start_stop = 1; + if (dev->class == ATA_DEV_ATA) + sdev->manage_start_stop = 1; if (dev) ata_scsi_dev_config(sdev, dev); -- Ondrej Zary - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata and starting/stopping ATAPI floppy devices
Tejun Heo wrote: From: Ondrej Zary <[EMAIL PROTECTED]> Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy drives) as they don't seem to like it: sd 1:0:1:0: [sdb] Starting disk ata2.01: configured for PIO2 sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 sd 1:0:1:0: [sdb] Sense Key : 0x2 [current] sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 Well, all that error is saying is "No medium present". We could just make sd suppress that error on disk starting/stopping.. Signed-off-by: Ondrej Zary <[EMAIL PROTECTED]> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Trimmed message body and reformatted such that it's script friendly. drivers/ata/libata-scsi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.23-orig/drivers/ata/libata-scsi.c 2007-10-09 22:31:38.0 +0200 +++ linux-2.6.23-pentium/drivers/ata/libata-scsi.c 2008-01-05 15:50:16.0 +0100 @@ -802,7 +802,8 @@ blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD); - sdev->manage_start_stop = 1; + if (dev->class == ATA_DEV_ATA) + sdev->manage_start_stop = 1; if (dev) ata_scsi_dev_config(sdev, dev); -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata and starting/stopping ATAPI floppy devices
On Thursday 10 January 2008 02:05:23 Robert Hancock wrote: > Tejun Heo wrote: > > From: Ondrej Zary <[EMAIL PROTECTED]> > > > > Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy > > drives) as they don't seem to like it: > > > > sd 1:0:1:0: [sdb] Starting disk > > ata2.01: configured for PIO2 > > sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 > > sd 1:0:1:0: [sdb] Sense Key : 0x2 [current] > > sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 > > Well, all that error is saying is "No medium present". We could just > make sd suppress that error on disk starting/stopping.. Yes, provided that the start/stop command is valid for ATAPI drives and is the correct thing to do. I don't know. > > > Signed-off-by: Ondrej Zary <[EMAIL PROTECTED]> > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > > --- > > Trimmed message body and reformatted such that it's script friendly. > > > > drivers/ata/libata-scsi.c |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > --- linux-2.6.23-orig/drivers/ata/libata-scsi.c 2007-10-09 > > 22:31:38.0 +0200 +++ > > linux-2.6.23-pentium/drivers/ata/libata-scsi.c 2008-01-05 > > 15:50:16.0 +0100 @@ -802,7 +802,8 @@ > > > > blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD); > > > > - sdev->manage_start_stop = 1; > > + if (dev->class == ATA_DEV_ATA) > > + sdev->manage_start_stop = 1; > > > > if (dev) > > ata_scsi_dev_config(sdev, dev); -- Ondrej Zary - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] libata and starting/stopping ATAPI floppy devices
Tejun Heo wrote: From: Ondrej Zary <[EMAIL PROTECTED]> Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy drives) as they don't seem to like it: sd 1:0:1:0: [sdb] Starting disk ata2.01: configured for PIO2 sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 sd 1:0:1:0: [sdb] Sense Key : 0x2 [current] sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 Signed-off-by: Ondrej Zary <[EMAIL PROTECTED]> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- Trimmed message body and reformatted such that it's script friendly. drivers/ata/libata-scsi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.23-orig/drivers/ata/libata-scsi.c 2007-10-09 22:31:38.0 +0200 +++ linux-2.6.23-pentium/drivers/ata/libata-scsi.c 2008-01-05 15:50:16.0 +0100 @@ -802,7 +802,8 @@ blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD); - sdev->manage_start_stop = 1; + if (dev->class == ATA_DEV_ATA) + sdev->manage_start_stop = 1; if (dev) applied #upstream-fixes manually. not sure why git-am didn't like it, but patch(1) did. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
