[PATCH] [MTD] slram: Invalid checking of absolute end address
Fixed parsing end absolute address Signed-off-by: Jiri Engelthaler --- --- linux-3.2.28/drivers/mtd/devices/slram.c2012-08-19 19:15:38.0 +0200 +++ linux-3.2.28.mod/drivers/mtd/devices/slram.c2012-09-19 18:29:28.012740703 +0200 @@ -266,7 +266,7 @@ static int parse_cmdline(char *devname, if (*(szlength) != '+') { devlength = simple_strtoul(szlength, , 0); - devlength = handle_unit(devlength, buffer) - devstart; + devlength = handle_unit(devlength, buffer); if (devlength < devstart) goto err_out; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Fix bug in end absolute address in drivers/mtd/devices/slram.c
Hello. I found a bug in parsing end absolute address in drivers/mtd/devices/slram.c. There is checking for startaddress < endaddress and endaddress subtracted by startaddress before check. The bug is there from commit 3afd522de8d8ec446efe957b86e4f63e3dd8ce9d Mon, 19 Jan 2009 01:24:21 + Here is the patch Signed-off-by: Jiri Engelthaler --- linux-3.2.28/drivers/mtd/devices/slram.c2012-08-19 19:15:38.0 +0200 +++ linux-3.2.28.mod/drivers/mtd/devices/slram.c2012-09-19 18:29:28.012740703 +0200 @@ -266,7 +266,7 @@ static int parse_cmdline(char *devname, if (*(szlength) != '+') { devlength = simple_strtoul(szlength, , 0); - devlength = handle_unit(devlength, buffer) - devstart; + devlength = handle_unit(devlength, buffer); if (devlength < devstart) goto err_out; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Fix bug in end absolute address in drivers/mtd/devices/slram.c
Hello. I found a bug in parsing end absolute address in drivers/mtd/devices/slram.c. There is checking for startaddress endaddress and endaddress subtracted by startaddress before check. The bug is there from commit 3afd522de8d8ec446efe957b86e4f63e3dd8ce9d Mon, 19 Jan 2009 01:24:21 + Here is the patch Signed-off-by: Jiri Engelthaler eng...@gmail.com --- linux-3.2.28/drivers/mtd/devices/slram.c2012-08-19 19:15:38.0 +0200 +++ linux-3.2.28.mod/drivers/mtd/devices/slram.c2012-09-19 18:29:28.012740703 +0200 @@ -266,7 +266,7 @@ static int parse_cmdline(char *devname, if (*(szlength) != '+') { devlength = simple_strtoul(szlength, buffer, 0); - devlength = handle_unit(devlength, buffer) - devstart; + devlength = handle_unit(devlength, buffer); if (devlength devstart) goto err_out; -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] [MTD] slram: Invalid checking of absolute end address
Fixed parsing end absolute address Signed-off-by: Jiri Engelthaler eng...@gmail.com --- --- linux-3.2.28/drivers/mtd/devices/slram.c2012-08-19 19:15:38.0 +0200 +++ linux-3.2.28.mod/drivers/mtd/devices/slram.c2012-09-19 18:29:28.012740703 +0200 @@ -266,7 +266,7 @@ static int parse_cmdline(char *devname, if (*(szlength) != '+') { devlength = simple_strtoul(szlength, buffer, 0); - devlength = handle_unit(devlength, buffer) - devstart; + devlength = handle_unit(devlength, buffer); if (devlength devstart) goto err_out; -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/