Re: [PATCH] [19/20] x86: Use shorter addresses in i386 segfault printks
On Thursday 03 January 2008 11:56:14 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > x86: Use shorter addresses in i386 segfault printks > > hm, why? It's pretty well-established that we print addresses 8 char > wide on 32-bit. It's useless. What purpose does it have? -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [19/20] x86: Use shorter addresses in i386 segfault printks
* Andi Kleen <[EMAIL PROTECTED]> wrote: > x86: Use shorter addresses in i386 segfault printks hm, why? It's pretty well-established that we print addresses 8 char wide on 32-bit. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] [19/20] x86: Use shorter addresses in i386 segfault printks
Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/mm/fault_32.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/arch/x86/mm/fault_32.c === --- linux.orig/arch/x86/mm/fault_32.c +++ linux/arch/x86/mm/fault_32.c @@ -549,7 +549,7 @@ bad_area_nosemaphore: if (show_unhandled_signals && unhandled_signal(tsk, SIGSEGV) && printk_ratelimit()) { - printk("%s%s[%d]: segfault at %08lx ip %08lx " + printk("%s%s[%d]: segfault at %lx ip %08lx " "sp %08lx error %lx\n", task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG, tsk->comm, task_pid_nr(tsk), address, regs->ip, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/