Re: [PATCH 0/4] Improve CLKSRC_OF matching
On 02/07/2013 10:51 PM, Tony Prisk wrote: > On Thu, 2013-02-07 at 13:09 -0600, Rob Herring wrote: >> From: Rob Herring >> >> In the recently added support for OF based clocksource init, a device node >> will be matched twice. We can fix this by passing the device node to the >> init functions and removing the match functions within the init functions. >> >> This is based on arm-soc for-next branch and commit "of: fix incorrect >> return value of of_find_matching_node_and_match()" in my DT for-next >> branch. >> >> Rob >> >> Rob Herring (4): >> clocksource: pass DT node pointer to init functions >> clocksource: bcm2835: use the device_node pointer passed to init >> clocksource: vt8500: use the device_node pointer passed to init >> clocksource: tegra20: use the device_node pointer passed to init >> >> drivers/clocksource/bcm2835_timer.c | 12 +- >> drivers/clocksource/clksrc-of.c |4 +- >> drivers/clocksource/tegra20_timer.c | 70 >> ++- >> drivers/clocksource/vt8500_timer.c | 14 +-- >> 4 files changed, 31 insertions(+), 69 deletions(-) >> > > Looks fine, although I didn't get a CC for the vt8500 patch so I had to > go hunting for it :) Since it got moved to drivers/clocksource, did MAINTAINERS get updated? I just ran get_maintainers.pl. Stephen also needs to add himself to Tegra as I had to add him manually. Rob > > For patches 1 & 3: > Acked-by: Tony Prisk > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On 02/07/2013 10:51 PM, Tony Prisk wrote: On Thu, 2013-02-07 at 13:09 -0600, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com In the recently added support for OF based clocksource init, a device node will be matched twice. We can fix this by passing the device node to the init functions and removing the match functions within the init functions. This is based on arm-soc for-next branch and commit of: fix incorrect return value of of_find_matching_node_and_match() in my DT for-next branch. Rob Rob Herring (4): clocksource: pass DT node pointer to init functions clocksource: bcm2835: use the device_node pointer passed to init clocksource: vt8500: use the device_node pointer passed to init clocksource: tegra20: use the device_node pointer passed to init drivers/clocksource/bcm2835_timer.c | 12 +- drivers/clocksource/clksrc-of.c |4 +- drivers/clocksource/tegra20_timer.c | 70 ++- drivers/clocksource/vt8500_timer.c | 14 +-- 4 files changed, 31 insertions(+), 69 deletions(-) Looks fine, although I didn't get a CC for the vt8500 patch so I had to go hunting for it :) Since it got moved to drivers/clocksource, did MAINTAINERS get updated? I just ran get_maintainers.pl. Stephen also needs to add himself to Tegra as I had to add him manually. Rob For patches 1 3: Acked-by: Tony Prisk li...@prisktech.co.nz -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On Thu, 2013-02-07 at 13:09 -0600, Rob Herring wrote: > From: Rob Herring > > In the recently added support for OF based clocksource init, a device node > will be matched twice. We can fix this by passing the device node to the > init functions and removing the match functions within the init functions. > > This is based on arm-soc for-next branch and commit "of: fix incorrect > return value of of_find_matching_node_and_match()" in my DT for-next > branch. > > Rob > > Rob Herring (4): > clocksource: pass DT node pointer to init functions > clocksource: bcm2835: use the device_node pointer passed to init > clocksource: vt8500: use the device_node pointer passed to init > clocksource: tegra20: use the device_node pointer passed to init > > drivers/clocksource/bcm2835_timer.c | 12 +- > drivers/clocksource/clksrc-of.c |4 +- > drivers/clocksource/tegra20_timer.c | 70 > ++- > drivers/clocksource/vt8500_timer.c | 14 +-- > 4 files changed, 31 insertions(+), 69 deletions(-) > Looks fine, although I didn't get a CC for the vt8500 patch so I had to go hunting for it :) For patches 1 & 3: Acked-by: Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On Thursday 07 February 2013, Rob Herring wrote: > How so? I don't see a warning as there is no type checking on the init > function since of_device_id.data is just a void *. It would be good to > have type checking here if you know a way, but I don't. Ah, that's right. So it silently builds find even though the prototypes don't match, and given the C calling conventions it even ends up working correctly, it just feels wrong. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On 02/07/2013 04:44 PM, Arnd Bergmann wrote: > On Thursday 07 February 2013, Rob Herring wrote: >> From: Rob Herring >> >> In the recently added support for OF based clocksource init, a device node >> will be matched twice. We can fix this by passing the device node to the >> init functions and removing the match functions within the init functions. >> >> This is based on arm-soc for-next branch and commit "of: fix incorrect >> return value of of_find_matching_node_and_match()" in my DT for-next >> branch. >> > > Acked-by: Arnd Bergmann > > Conceptually this is definitely the way to go, but I noticed that > you create build warnings for the bisection points after the > first patch. I would suggest actually merging the first three > patches into one and also changing the prototype for the tegra > function in that patch to avoid this. > How so? I don't see a warning as there is no type checking on the init function since of_device_id.data is just a void *. It would be good to have type checking here if you know a way, but I don't. I agree it is a bit abusive and can change it as you suggest. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On Thursday 07 February 2013, Rob Herring wrote: > From: Rob Herring > > In the recently added support for OF based clocksource init, a device node > will be matched twice. We can fix this by passing the device node to the > init functions and removing the match functions within the init functions. > > This is based on arm-soc for-next branch and commit "of: fix incorrect > return value of of_find_matching_node_and_match()" in my DT for-next > branch. > Acked-by: Arnd Bergmann Conceptually this is definitely the way to go, but I noticed that you create build warnings for the bisection points after the first patch. I would suggest actually merging the first three patches into one and also changing the prototype for the tegra function in that patch to avoid this. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/4] Improve CLKSRC_OF matching
From: Rob Herring In the recently added support for OF based clocksource init, a device node will be matched twice. We can fix this by passing the device node to the init functions and removing the match functions within the init functions. This is based on arm-soc for-next branch and commit "of: fix incorrect return value of of_find_matching_node_and_match()" in my DT for-next branch. Rob Rob Herring (4): clocksource: pass DT node pointer to init functions clocksource: bcm2835: use the device_node pointer passed to init clocksource: vt8500: use the device_node pointer passed to init clocksource: tegra20: use the device_node pointer passed to init drivers/clocksource/bcm2835_timer.c | 12 +- drivers/clocksource/clksrc-of.c |4 +- drivers/clocksource/tegra20_timer.c | 70 ++- drivers/clocksource/vt8500_timer.c | 14 +-- 4 files changed, 31 insertions(+), 69 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/4] Improve CLKSRC_OF matching
From: Rob Herring rob.herr...@calxeda.com In the recently added support for OF based clocksource init, a device node will be matched twice. We can fix this by passing the device node to the init functions and removing the match functions within the init functions. This is based on arm-soc for-next branch and commit of: fix incorrect return value of of_find_matching_node_and_match() in my DT for-next branch. Rob Rob Herring (4): clocksource: pass DT node pointer to init functions clocksource: bcm2835: use the device_node pointer passed to init clocksource: vt8500: use the device_node pointer passed to init clocksource: tegra20: use the device_node pointer passed to init drivers/clocksource/bcm2835_timer.c | 12 +- drivers/clocksource/clksrc-of.c |4 +- drivers/clocksource/tegra20_timer.c | 70 ++- drivers/clocksource/vt8500_timer.c | 14 +-- 4 files changed, 31 insertions(+), 69 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On Thursday 07 February 2013, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com In the recently added support for OF based clocksource init, a device node will be matched twice. We can fix this by passing the device node to the init functions and removing the match functions within the init functions. This is based on arm-soc for-next branch and commit of: fix incorrect return value of of_find_matching_node_and_match() in my DT for-next branch. Acked-by: Arnd Bergmann a...@arndb.de Conceptually this is definitely the way to go, but I noticed that you create build warnings for the bisection points after the first patch. I would suggest actually merging the first three patches into one and also changing the prototype for the tegra function in that patch to avoid this. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On 02/07/2013 04:44 PM, Arnd Bergmann wrote: On Thursday 07 February 2013, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com In the recently added support for OF based clocksource init, a device node will be matched twice. We can fix this by passing the device node to the init functions and removing the match functions within the init functions. This is based on arm-soc for-next branch and commit of: fix incorrect return value of of_find_matching_node_and_match() in my DT for-next branch. Acked-by: Arnd Bergmann a...@arndb.de Conceptually this is definitely the way to go, but I noticed that you create build warnings for the bisection points after the first patch. I would suggest actually merging the first three patches into one and also changing the prototype for the tegra function in that patch to avoid this. How so? I don't see a warning as there is no type checking on the init function since of_device_id.data is just a void *. It would be good to have type checking here if you know a way, but I don't. I agree it is a bit abusive and can change it as you suggest. Rob -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On Thursday 07 February 2013, Rob Herring wrote: How so? I don't see a warning as there is no type checking on the init function since of_device_id.data is just a void *. It would be good to have type checking here if you know a way, but I don't. Ah, that's right. So it silently builds find even though the prototypes don't match, and given the C calling conventions it even ends up working correctly, it just feels wrong. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] Improve CLKSRC_OF matching
On Thu, 2013-02-07 at 13:09 -0600, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com In the recently added support for OF based clocksource init, a device node will be matched twice. We can fix this by passing the device node to the init functions and removing the match functions within the init functions. This is based on arm-soc for-next branch and commit of: fix incorrect return value of of_find_matching_node_and_match() in my DT for-next branch. Rob Rob Herring (4): clocksource: pass DT node pointer to init functions clocksource: bcm2835: use the device_node pointer passed to init clocksource: vt8500: use the device_node pointer passed to init clocksource: tegra20: use the device_node pointer passed to init drivers/clocksource/bcm2835_timer.c | 12 +- drivers/clocksource/clksrc-of.c |4 +- drivers/clocksource/tegra20_timer.c | 70 ++- drivers/clocksource/vt8500_timer.c | 14 +-- 4 files changed, 31 insertions(+), 69 deletions(-) Looks fine, although I didn't get a CC for the vt8500 patch so I had to go hunting for it :) For patches 1 3: Acked-by: Tony Prisk li...@prisktech.co.nz -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
