[PATCH RT 5/6] arm/unwind: use a raw_spin_lock
3.2.55-rt79-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior Mostly unwind is done with irqs enabled however SLUB may call it with irqs disabled while creating a new SLUB cache. I had system freeze while loading a module which called kmem_cache_create() on init. That means SLUB's __slab_alloc() disabled interrupts and then ->new_slab_objects() ->new_slab() ->setup_object() ->setup_object_debug() ->init_tracking() ->set_track() ->save_stack_trace() ->save_stack_trace_tsk() ->walk_stackframe() ->unwind_frame() ->unwind_find_idx() =>spin_lock_irqsave(_lock); Cc: stable...@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Steven Rostedt --- arch/arm/kernel/unwind.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c index 00df012..bbafc67 100644 --- a/arch/arm/kernel/unwind.c +++ b/arch/arm/kernel/unwind.c @@ -87,7 +87,7 @@ extern const struct unwind_idx __start_unwind_idx[]; static const struct unwind_idx *__origin_unwind_idx; extern const struct unwind_idx __stop_unwind_idx[]; -static DEFINE_SPINLOCK(unwind_lock); +static DEFINE_RAW_SPINLOCK(unwind_lock); static LIST_HEAD(unwind_tables); /* Convert a prel31 symbol to an absolute address */ @@ -195,7 +195,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) /* module unwind tables */ struct unwind_table *table; - spin_lock_irqsave(_lock, flags); + raw_spin_lock_irqsave(_lock, flags); list_for_each_entry(table, _tables, list) { if (addr >= table->begin_addr && addr < table->end_addr) { @@ -207,7 +207,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) break; } } - spin_unlock_irqrestore(_lock, flags); + raw_spin_unlock_irqrestore(_lock, flags); } pr_debug("%s: idx = %p\n", __func__, idx); @@ -469,9 +469,9 @@ struct unwind_table *unwind_table_add(unsigned long start, unsigned long size, tab->begin_addr = text_addr; tab->end_addr = text_addr + text_size; - spin_lock_irqsave(_lock, flags); + raw_spin_lock_irqsave(_lock, flags); list_add_tail(>list, _tables); - spin_unlock_irqrestore(_lock, flags); + raw_spin_unlock_irqrestore(_lock, flags); return tab; } @@ -483,9 +483,9 @@ void unwind_table_del(struct unwind_table *tab) if (!tab) return; - spin_lock_irqsave(_lock, flags); + raw_spin_lock_irqsave(_lock, flags); list_del(>list); - spin_unlock_irqrestore(_lock, flags); + raw_spin_unlock_irqrestore(_lock, flags); kfree(tab); } -- 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RT 5/6] arm/unwind: use a raw_spin_lock
3.4.82-rt101-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior Mostly unwind is done with irqs enabled however SLUB may call it with irqs disabled while creating a new SLUB cache. I had system freeze while loading a module which called kmem_cache_create() on init. That means SLUB's __slab_alloc() disabled interrupts and then ->new_slab_objects() ->new_slab() ->setup_object() ->setup_object_debug() ->init_tracking() ->set_track() ->save_stack_trace() ->save_stack_trace_tsk() ->walk_stackframe() ->unwind_frame() ->unwind_find_idx() =>spin_lock_irqsave(_lock); Cc: stable...@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Steven Rostedt --- arch/arm/kernel/unwind.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c index 00df012..bbafc67 100644 --- a/arch/arm/kernel/unwind.c +++ b/arch/arm/kernel/unwind.c @@ -87,7 +87,7 @@ extern const struct unwind_idx __start_unwind_idx[]; static const struct unwind_idx *__origin_unwind_idx; extern const struct unwind_idx __stop_unwind_idx[]; -static DEFINE_SPINLOCK(unwind_lock); +static DEFINE_RAW_SPINLOCK(unwind_lock); static LIST_HEAD(unwind_tables); /* Convert a prel31 symbol to an absolute address */ @@ -195,7 +195,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) /* module unwind tables */ struct unwind_table *table; - spin_lock_irqsave(_lock, flags); + raw_spin_lock_irqsave(_lock, flags); list_for_each_entry(table, _tables, list) { if (addr >= table->begin_addr && addr < table->end_addr) { @@ -207,7 +207,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) break; } } - spin_unlock_irqrestore(_lock, flags); + raw_spin_unlock_irqrestore(_lock, flags); } pr_debug("%s: idx = %p\n", __func__, idx); @@ -469,9 +469,9 @@ struct unwind_table *unwind_table_add(unsigned long start, unsigned long size, tab->begin_addr = text_addr; tab->end_addr = text_addr + text_size; - spin_lock_irqsave(_lock, flags); + raw_spin_lock_irqsave(_lock, flags); list_add_tail(>list, _tables); - spin_unlock_irqrestore(_lock, flags); + raw_spin_unlock_irqrestore(_lock, flags); return tab; } @@ -483,9 +483,9 @@ void unwind_table_del(struct unwind_table *tab) if (!tab) return; - spin_lock_irqsave(_lock, flags); + raw_spin_lock_irqsave(_lock, flags); list_del(>list); - spin_unlock_irqrestore(_lock, flags); + raw_spin_unlock_irqrestore(_lock, flags); kfree(tab); } -- 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RT 5/6] arm/unwind: use a raw_spin_lock
3.4.82-rt101-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior bige...@linutronix.de Mostly unwind is done with irqs enabled however SLUB may call it with irqs disabled while creating a new SLUB cache. I had system freeze while loading a module which called kmem_cache_create() on init. That means SLUB's __slab_alloc() disabled interrupts and then -new_slab_objects() -new_slab() -setup_object() -setup_object_debug() -init_tracking() -set_track() -save_stack_trace() -save_stack_trace_tsk() -walk_stackframe() -unwind_frame() -unwind_find_idx() =spin_lock_irqsave(unwind_lock); Cc: stable...@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: Steven Rostedt rost...@goodmis.org --- arch/arm/kernel/unwind.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c index 00df012..bbafc67 100644 --- a/arch/arm/kernel/unwind.c +++ b/arch/arm/kernel/unwind.c @@ -87,7 +87,7 @@ extern const struct unwind_idx __start_unwind_idx[]; static const struct unwind_idx *__origin_unwind_idx; extern const struct unwind_idx __stop_unwind_idx[]; -static DEFINE_SPINLOCK(unwind_lock); +static DEFINE_RAW_SPINLOCK(unwind_lock); static LIST_HEAD(unwind_tables); /* Convert a prel31 symbol to an absolute address */ @@ -195,7 +195,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) /* module unwind tables */ struct unwind_table *table; - spin_lock_irqsave(unwind_lock, flags); + raw_spin_lock_irqsave(unwind_lock, flags); list_for_each_entry(table, unwind_tables, list) { if (addr = table-begin_addr addr table-end_addr) { @@ -207,7 +207,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) break; } } - spin_unlock_irqrestore(unwind_lock, flags); + raw_spin_unlock_irqrestore(unwind_lock, flags); } pr_debug(%s: idx = %p\n, __func__, idx); @@ -469,9 +469,9 @@ struct unwind_table *unwind_table_add(unsigned long start, unsigned long size, tab-begin_addr = text_addr; tab-end_addr = text_addr + text_size; - spin_lock_irqsave(unwind_lock, flags); + raw_spin_lock_irqsave(unwind_lock, flags); list_add_tail(tab-list, unwind_tables); - spin_unlock_irqrestore(unwind_lock, flags); + raw_spin_unlock_irqrestore(unwind_lock, flags); return tab; } @@ -483,9 +483,9 @@ void unwind_table_del(struct unwind_table *tab) if (!tab) return; - spin_lock_irqsave(unwind_lock, flags); + raw_spin_lock_irqsave(unwind_lock, flags); list_del(tab-list); - spin_unlock_irqrestore(unwind_lock, flags); + raw_spin_unlock_irqrestore(unwind_lock, flags); kfree(tab); } -- 1.8.5.3 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH RT 5/6] arm/unwind: use a raw_spin_lock
3.2.55-rt79-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior bige...@linutronix.de Mostly unwind is done with irqs enabled however SLUB may call it with irqs disabled while creating a new SLUB cache. I had system freeze while loading a module which called kmem_cache_create() on init. That means SLUB's __slab_alloc() disabled interrupts and then -new_slab_objects() -new_slab() -setup_object() -setup_object_debug() -init_tracking() -set_track() -save_stack_trace() -save_stack_trace_tsk() -walk_stackframe() -unwind_frame() -unwind_find_idx() =spin_lock_irqsave(unwind_lock); Cc: stable...@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de Signed-off-by: Steven Rostedt rost...@goodmis.org --- arch/arm/kernel/unwind.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c index 00df012..bbafc67 100644 --- a/arch/arm/kernel/unwind.c +++ b/arch/arm/kernel/unwind.c @@ -87,7 +87,7 @@ extern const struct unwind_idx __start_unwind_idx[]; static const struct unwind_idx *__origin_unwind_idx; extern const struct unwind_idx __stop_unwind_idx[]; -static DEFINE_SPINLOCK(unwind_lock); +static DEFINE_RAW_SPINLOCK(unwind_lock); static LIST_HEAD(unwind_tables); /* Convert a prel31 symbol to an absolute address */ @@ -195,7 +195,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) /* module unwind tables */ struct unwind_table *table; - spin_lock_irqsave(unwind_lock, flags); + raw_spin_lock_irqsave(unwind_lock, flags); list_for_each_entry(table, unwind_tables, list) { if (addr = table-begin_addr addr table-end_addr) { @@ -207,7 +207,7 @@ static const struct unwind_idx *unwind_find_idx(unsigned long addr) break; } } - spin_unlock_irqrestore(unwind_lock, flags); + raw_spin_unlock_irqrestore(unwind_lock, flags); } pr_debug(%s: idx = %p\n, __func__, idx); @@ -469,9 +469,9 @@ struct unwind_table *unwind_table_add(unsigned long start, unsigned long size, tab-begin_addr = text_addr; tab-end_addr = text_addr + text_size; - spin_lock_irqsave(unwind_lock, flags); + raw_spin_lock_irqsave(unwind_lock, flags); list_add_tail(tab-list, unwind_tables); - spin_unlock_irqrestore(unwind_lock, flags); + raw_spin_unlock_irqrestore(unwind_lock, flags); return tab; } @@ -483,9 +483,9 @@ void unwind_table_del(struct unwind_table *tab) if (!tab) return; - spin_lock_irqsave(unwind_lock, flags); + raw_spin_lock_irqsave(unwind_lock, flags); list_del(tab-list); - spin_unlock_irqrestore(unwind_lock, flags); + raw_spin_unlock_irqrestore(unwind_lock, flags); kfree(tab); } -- 1.8.5.3 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/