Re: [PATCH v3 02/22] sched: select_task_rq_fair clean up
On 01/05/2013 02:07 PM, Alex Shi wrote: > It is impossible to miss a task allowed cpu in a eligible group. > > And since find_idlest_group only return a different group which > excludes old cpu, it's also imporissible to find a new cpu same as old > cpu. > > Signed-off-by: Alex Shi > --- > kernel/sched/fair.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 5eea870..6d3a95d 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3378,11 +3378,6 @@ select_task_rq_fair(struct task_struct *p, int > sd_flag, int wake_flags) > } > > new_cpu = find_idlest_cpu(group, p, cpu); > - if (new_cpu == -1 || new_cpu == cpu) { > - /* Now try balancing at a lower domain level of cpu */ > - sd = sd->child; > - continue; > - } > > /* Now try balancing at a lower domain level of new_cpu */ > cpu = new_cpu; > Reviewed-by:Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 02/22] sched: select_task_rq_fair clean up
On 01/05/2013 02:07 PM, Alex Shi wrote: It is impossible to miss a task allowed cpu in a eligible group. And since find_idlest_group only return a different group which excludes old cpu, it's also imporissible to find a new cpu same as old cpu. Signed-off-by: Alex Shi alex@intel.com --- kernel/sched/fair.c | 5 - 1 file changed, 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5eea870..6d3a95d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3378,11 +3378,6 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags) } new_cpu = find_idlest_cpu(group, p, cpu); - if (new_cpu == -1 || new_cpu == cpu) { - /* Now try balancing at a lower domain level of cpu */ - sd = sd-child; - continue; - } /* Now try balancing at a lower domain level of new_cpu */ cpu = new_cpu; Reviewed-by:Preeti U Murthy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 02/22] sched: select_task_rq_fair clean up
It is impossible to miss a task allowed cpu in a eligible group. And since find_idlest_group only return a different group which excludes old cpu, it's also imporissible to find a new cpu same as old cpu. Signed-off-by: Alex Shi --- kernel/sched/fair.c | 5 - 1 file changed, 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5eea870..6d3a95d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3378,11 +3378,6 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags) } new_cpu = find_idlest_cpu(group, p, cpu); - if (new_cpu == -1 || new_cpu == cpu) { - /* Now try balancing at a lower domain level of cpu */ - sd = sd->child; - continue; - } /* Now try balancing at a lower domain level of new_cpu */ cpu = new_cpu; -- 1.7.12 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 02/22] sched: select_task_rq_fair clean up
It is impossible to miss a task allowed cpu in a eligible group. And since find_idlest_group only return a different group which excludes old cpu, it's also imporissible to find a new cpu same as old cpu. Signed-off-by: Alex Shi alex@intel.com --- kernel/sched/fair.c | 5 - 1 file changed, 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5eea870..6d3a95d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3378,11 +3378,6 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags) } new_cpu = find_idlest_cpu(group, p, cpu); - if (new_cpu == -1 || new_cpu == cpu) { - /* Now try balancing at a lower domain level of cpu */ - sd = sd-child; - continue; - } /* Now try balancing at a lower domain level of new_cpu */ cpu = new_cpu; -- 1.7.12 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/