Re: [PATCH v4 0/3] Introduce USB charger support in USB phy
Hi Felipe, On 15 August 2017 at 17:53, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>> Currently the Linux kernel does not provide any standard integration of this >>> feature that integrates the USB subsystem with the system power regulation >>> provided by PMICs meaning that either vendors must add this in their kernels >>> or USB gadget devices based on Linux (such as mobile phones) may not behave >>> as they should. Thus provide a standard USB charger support in USB phy core >>> for doing this in kernel. >>> >>> Now introduce one user with wm831x_power to support and test the usb >>> charger. >>> In future we will also cnvert below power drivers: >>> drivers/power/supply/axp288_charger.c >>> drivers/power/supply/bq24190_charger.c >>> drivers/power/supply/charger-manager.c >>> drivers/power/supply/qcom_smbb.c >>> >>> Changes since v3: >>> - Bail out errors when failed to find usb phy for wm831x_power driver. >>> Changes since v2: >>> - Add DT binding documentation for wm831x_power driver. >>> - Change 'usb-phy' as one optional property for wm831x_power driver. >>> Changes since v1: >>> - Fix building errors. >> >> Do you have any comments about usb charger support in usb phy core? Thanks. > > No more comments from me Thanks for your feedback. I've send out V5 patchset which just changes phy phandle name from 'usb-phy' to 'phys' for patch 3 suggested by Rob. Hope you can apply this version patchset into your branch if there are no other comments. -- Baolin.wang Best Regards
Re: [PATCH v4 0/3] Introduce USB charger support in USB phy
Hi, Baolin Wang writes: >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >> provided by PMICs meaning that either vendors must add this in their kernels >> or USB gadget devices based on Linux (such as mobile phones) may not behave >> as they should. Thus provide a standard USB charger support in USB phy core >> for doing this in kernel. >> >> Now introduce one user with wm831x_power to support and test the usb charger. >> In future we will also cnvert below power drivers: >> drivers/power/supply/axp288_charger.c >> drivers/power/supply/bq24190_charger.c >> drivers/power/supply/charger-manager.c >> drivers/power/supply/qcom_smbb.c >> >> Changes since v3: >> - Bail out errors when failed to find usb phy for wm831x_power driver. >> Changes since v2: >> - Add DT binding documentation for wm831x_power driver. >> - Change 'usb-phy' as one optional property for wm831x_power driver. >> Changes since v1: >> - Fix building errors. > > Do you have any comments about usb charger support in usb phy core? Thanks. No more comments from me -- balbi signature.asc Description: PGP signature
Re: [PATCH v4 0/3] Introduce USB charger support in USB phy
Hi Felipe, On 27 July 2017 at 13:14, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their kernels > or USB gadget devices based on Linux (such as mobile phones) may not behave > as they should. Thus provide a standard USB charger support in USB phy core > for doing this in kernel. > > Now introduce one user with wm831x_power to support and test the usb charger. > In future we will also cnvert below power drivers: > drivers/power/supply/axp288_charger.c > drivers/power/supply/bq24190_charger.c > drivers/power/supply/charger-manager.c > drivers/power/supply/qcom_smbb.c > > Changes since v3: > - Bail out errors when failed to find usb phy for wm831x_power driver. > Changes since v2: > - Add DT binding documentation for wm831x_power driver. > - Change 'usb-phy' as one optional property for wm831x_power driver. > Changes since v1: > - Fix building errors. Do you have any comments about usb charger support in usb phy core? Thanks. > > Baolin Wang (3): > include: uapi: usb: Introduce USB charger type and state definition > usb: phy: Add USB charger support > power: wm831x_power: Support USB charger current limit management > > Documentation/devicetree/bindings/mfd/wm831x.txt |1 + > drivers/power/supply/wm831x_power.c | 72 ++ > drivers/usb/phy/phy.c| 272 > ++ > include/linux/usb/phy.h | 49 > include/uapi/linux/usb/charger.h | 31 +++ > 5 files changed, 425 insertions(+) > create mode 100644 include/uapi/linux/usb/charger.h > > -- > 1.7.9.5 > -- Baolin.wang Best Regards
[PATCH v4 0/3] Introduce USB charger support in USB phy
Currently the Linux kernel does not provide any standard integration of this feature that integrates the USB subsystem with the system power regulation provided by PMICs meaning that either vendors must add this in their kernels or USB gadget devices based on Linux (such as mobile phones) may not behave as they should. Thus provide a standard USB charger support in USB phy core for doing this in kernel. Now introduce one user with wm831x_power to support and test the usb charger. In future we will also cnvert below power drivers: drivers/power/supply/axp288_charger.c drivers/power/supply/bq24190_charger.c drivers/power/supply/charger-manager.c drivers/power/supply/qcom_smbb.c Changes since v3: - Bail out errors when failed to find usb phy for wm831x_power driver. Changes since v2: - Add DT binding documentation for wm831x_power driver. - Change 'usb-phy' as one optional property for wm831x_power driver. Changes since v1: - Fix building errors. Baolin Wang (3): include: uapi: usb: Introduce USB charger type and state definition usb: phy: Add USB charger support power: wm831x_power: Support USB charger current limit management Documentation/devicetree/bindings/mfd/wm831x.txt |1 + drivers/power/supply/wm831x_power.c | 72 ++ drivers/usb/phy/phy.c| 272 ++ include/linux/usb/phy.h | 49 include/uapi/linux/usb/charger.h | 31 +++ 5 files changed, 425 insertions(+) create mode 100644 include/uapi/linux/usb/charger.h -- 1.7.9.5