Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-06 Thread Bill Davidsen

Mathieu Chouquet-Stringer wrote:

 Hey there,

I've seen the changes you made in commit b6a2fea39318 and I guess they
might be responsible for my xargs breakage...

In the kernel source tree, if I run a stupid find | xargs ls, I now get
this:
xargs: ls: Argument list too long

Which is kind of annoying but I can work around it though make distclean in
my kernel tree dies with the same symptom (aka -E2BIG).

You can work around it many ways, using the options provided for xargs 
or using ls directly being among them.

   find . -ls

I don't see it with 2.6.23-rc8-git3 so it may be related to xargs 
version as well, I have 4.2.27 in FC6.



I run a vanilla 2.6.23-rc9 (Linux version 2.6.23-rc9 ([EMAIL PROTECTED])
(gcc version 4.1.2 20070925 (Red Hat 4.1.2-27)) #1 Tue Oct 2 08:13:47 EDT
2007) on FC7...

Let me know if I can do anything.  I'm going to try to bisect the problem
after I recompile the kernel without this patch...

Best,
Mathieu

[EMAIL PROTECTED] (Linus Torvalds) writes:
I said I was hoping that -rc8 was the last -rc, and I hate doing this, but 
we've had more changes since -rc8 than we had in -rc8. And while most of 
them are pretty trivial, I really couldn't face doing a 2.6.23 release and 
take the risk of some really stupid brown-paper-bag thing.

[...]





--
Bill Davidsen <[EMAIL PROTECTED]>
  "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-06 Thread Hans-Peter Jansen
Am Samstag, 6. Oktober 2007 10:29 schrieb Hans-Peter Jansen:
> Am Donnerstag, 4. Oktober 2007 19:05 schrieb Mathieu Chouquet-Stringer:
> >  Hey there,
> >
> > I've seen the changes you made in commit b6a2fea39318 and I guess they
> > might be responsible for my xargs breakage...
> >
> > In the kernel source tree, if I run a stupid find | xargs ls, I now get
> > this:
> > xargs: ls: Argument list too long
>
> Have you tried to remove xarg from the equation above, just in case that
> it stumbles upon the elemination of the reason for its existence in the
> first place..

Sorry guys, filtering by "linus" in kmail suppressed the solution messages 
in this thread.

Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-06 Thread Hans-Peter Jansen
Am Donnerstag, 4. Oktober 2007 19:05 schrieb Mathieu Chouquet-Stringer:
>  Hey there,
>
> I've seen the changes you made in commit b6a2fea39318 and I guess they
> might be responsible for my xargs breakage...
>
> In the kernel source tree, if I run a stupid find | xargs ls, I now get
> this:
> xargs: ls: Argument list too long

Have you tried to remove xarg from the equation above, just in case that it 
stumbles upon the elemination of the reason for its existence in the first 
place..

Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-05 Thread Peter Zijlstra
On Fri, 2007-10-05 at 05:22 +0200, Mathieu Chouquet-Stringer wrote:
> On Thu, Oct 04, 2007 at 05:12:11PM -0700, Linus Torvalds wrote:
> > I also tested that "ulimit -s" seems to do the right thing for me.
> > 
> > I'm also assuming Mathieu is running x86 (or x86-64): HP-PA has a stack 
> > that grows upwards, and that has traditionally been exciting.
> 
> Correct, x86 it is but as I said it's this stupid auditd thing that
> breaks the whole process.  I'm gonna file a bug against it.

Eric Paris just posted patches to solve this.


signature.asc
Description: This is a digitally signed message part


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Mathieu Chouquet-Stringer
On Thu, Oct 04, 2007 at 05:12:11PM -0700, Linus Torvalds wrote:
> I also tested that "ulimit -s" seems to do the right thing for me.
> 
> I'm also assuming Mathieu is running x86 (or x86-64): HP-PA has a stack 
> that grows upwards, and that has traditionally been exciting.

Correct, x86 it is but as I said it's this stupid auditd thing that
breaks the whole process.  I'm gonna file a bug against it.

Thanks for the help though.
-- 
Mathieu Chouquet-Stringer   [EMAIL PROTECTED]
The sun itself sees not till heaven clears.
 -- William Shakespeare --
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Linus Torvalds


On Fri, 5 Oct 2007, Paul Mackerras wrote:
> Linus Torvalds writes:
> > 
> > Well, since others definitely don't see this, including me, and I can do 
> > things like 62MB exec arrays:
> > 
> > [EMAIL PROTECTED] linux]$ echo $(find /home/torvalds/) | wc
> >   1  883304 63000962
> 
> That wouldn't actually do an exec, assuming you're using bash, since
> echo is a shell builtin in bash.  You'd need to do /bin/echo.

Right you are, silly me. But yes, it works for me even with that (and 
since I downloaded the gcc source tree, it now has six more megs of 
arguments).

I also tested that "ulimit -s" seems to do the right thing for me.

I'm also assuming Mathieu is running x86 (or x86-64): HP-PA has a stack 
that grows upwards, and that has traditionally been exciting.

IA64 also has some strange things for the register backing store.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Paul Mackerras
Linus Torvalds writes:

> Well, since others definitely don't see this, including me, and I can do 
> things like 62MB exec arrays:
> 
>   [EMAIL PROTECTED] linux]$ echo $(find /home/torvalds/) | wc
> 1  883304 63000962

That wouldn't actually do an exec, assuming you're using bash, since
echo is a shell builtin in bash.  You'd need to do /bin/echo.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Mathieu Chouquet-Stringer
On Thu, Oct 04, 2007 at 07:17:50PM +0200, Peter Zijlstra wrote:
> what happens if you up the stack limit to say 128M ?
> 
> Also, do you happen to have execve syscall audit stuff enabled?

Actually, you were right, not only it's enabled but it's also the
culprit.  If I stop it, all is well...

Sorry for the noise.

-- 
Mathieu Chouquet-Stringer   [EMAIL PROTECTED]
The sun itself sees not till heaven clears.
 -- William Shakespeare --
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Mathieu Chouquet-Stringer
On Thu, Oct 04, 2007 at 05:50:00PM -0400, Chuck Ebbert wrote:
> On 10/04/2007 01:05 PM, Mathieu Chouquet-Stringer wrote:
> > In the kernel source tree, if I run a stupid find | xargs ls, I now get
> > this:
> > xargs: ls: Argument list too long
> > 
> 
> Can you strace it to see what syscall is failing?

Sure:
25789 <... execve resumed> )= -1 E2BIG (Argument list too long)

I'm going to reboot to a kernel that has Linus' printks...

-- 
Mathieu Chouquet-Stringer   [EMAIL PROTECTED]
The sun itself sees not till heaven clears.
 -- William Shakespeare --
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Chuck Ebbert
On 10/04/2007 01:05 PM, Mathieu Chouquet-Stringer wrote:
> In the kernel source tree, if I run a stupid find | xargs ls, I now get
> this:
> xargs: ls: Argument list too long
> 

Can you strace it to see what syscall is failing?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Mathieu Chouquet-Stringer
On Thu, Oct 04, 2007 at 07:17:50PM +0200, Peter Zijlstra wrote:
> /me tries
> 
> yep works like a charm, and that is a tree with a full git repo and
> several build dirs in it.

Well, what can I say? ;-)

> what happens if you up the stack limit to say 128M ?

It's unlimited.

> Also, do you happen to have execve syscall audit stuff enabled?

Nope.

-- 
Mathieu Chouquet-Stringer   [EMAIL PROTECTED]
The sun itself sees not till heaven clears.
 -- William Shakespeare --
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Mathieu Chouquet-Stringer
Thank you for getting back to me.

On Thu, Oct 04, 2007 at 10:27:52AM -0700, Linus Torvalds wrote:
> What does your "ulimit -s" say?

That's actually the first thing I checked.

mchouque - /usr/src/kernel/linux %ulimit -s
unlimited

And for the record, ulimit -a yields:
-t: cpu time (seconds) unlimited
-f: file size (blocks) unlimited
-d: data seg size (kbytes) unlimited
-s: stack size (kbytes)unlimited
-c: core file size (blocks)0
-m: resident set size (kbytes) unlimited
-u: processes  16375
-n: file descriptors   1024
-l: locked-in-memory size (kb) 32
-v: address space (kb) unlimited
-x: file locks unlimited
-i: pending signals16375
-q: bytes in POSIX msg queues  819200
-N 13: 0
-N 14: 0


> I suspect that you might hit the code that limits execve() arguments to 
> one quarter of the maximum stack size.
> 
> We could change that from 25% to something else (half? three quarters?), 
> but if you really are hitting that limit, it sounds like you may have a 
> really small stack size to begin with (ie if 25% is smaller than the old 
> argument size limit of 128kB, you're running with a stack limit of less 
> than half a meg, which sounds pretty dang small).
> 
> So I'd like to verify that the stack limit really is the issue, and not 
> something else.

Anything else you'd like me to try?

-- 
Mathieu Chouquet-Stringer   [EMAIL PROTECTED]
The sun itself sees not till heaven clears.
 -- William Shakespeare --
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Linus Torvalds


On Thu, 4 Oct 2007, Mathieu Chouquet-Stringer wrote:
> 
> Anything else you'd like me to try?

Well, since others definitely don't see this, including me, and I can do 
things like 62MB exec arrays:

[EMAIL PROTECTED] linux]$ echo $(find /home/torvalds/) | wc
  1  883304 63000962

without getting any overflows (much less just on the kernel sources, which 
is less than a megabyte of pathnames), I think it would be good if you 
were to just instrument the kernel and make it do a "printk()" when it 
returns E2BIG in fs/execve.c (or the NULL returns from get_arg_page()).

Just to figure out *which* test fails for you but apparently nobody else.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Mathieu Chouquet-Stringer
 Hey there,

I've seen the changes you made in commit b6a2fea39318 and I guess they
might be responsible for my xargs breakage...

In the kernel source tree, if I run a stupid find | xargs ls, I now get
this:
xargs: ls: Argument list too long

Which is kind of annoying but I can work around it though make distclean in
my kernel tree dies with the same symptom (aka -E2BIG).

I run a vanilla 2.6.23-rc9 (Linux version 2.6.23-rc9 ([EMAIL PROTECTED])
(gcc version 4.1.2 20070925 (Red Hat 4.1.2-27)) #1 Tue Oct 2 08:13:47 EDT
2007) on FC7...

Let me know if I can do anything.  I'm going to try to bisect the problem
after I recompile the kernel without this patch...

Best,
Mathieu

[EMAIL PROTECTED] (Linus Torvalds) writes:
> I said I was hoping that -rc8 was the last -rc, and I hate doing this, but 
> we've had more changes since -rc8 than we had in -rc8. And while most of 
> them are pretty trivial, I really couldn't face doing a 2.6.23 release and 
> take the risk of some really stupid brown-paper-bag thing.
> [...]

-- 
Mathieu Chouquet-Stringer   [EMAIL PROTECTED]
The sun itself sees not till heaven clears.
 -- William Shakespeare --
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Linus Torvalds


On Thu, 4 Oct 2007, Mathieu Chouquet-Stringer wrote:
> 
> I've seen the changes you made in commit b6a2fea39318 and I guess they
> might be responsible for my xargs breakage...
> 
> In the kernel source tree, if I run a stupid find | xargs ls, I now get
> this:
> xargs: ls: Argument list too long

What does your "ulimit -s" say?

I suspect that you might hit the code that limits execve() arguments to 
one quarter of the maximum stack size.

We could change that from 25% to something else (half? three quarters?), 
but if you really are hitting that limit, it sounds like you may have a 
really small stack size to begin with (ie if 25% is smaller than the old 
argument size limit of 128kB, you're running with a stack limit of less 
than half a meg, which sounds pretty dang small).

So I'd like to verify that the stack limit really is the issue, and not 
something else.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [BUG] Linux 2.6.23-rc9 and MAX_ARG_PAGES

2007-10-04 Thread Peter Zijlstra

On Thu, 2007-10-04 at 19:05 +0200, Mathieu Chouquet-Stringer wrote:
> Hey there,
> 
> I've seen the changes you made in commit b6a2fea39318 and I guess they
> might be responsible for my xargs breakage...
> 
> In the kernel source tree, if I run a stupid find | xargs ls, I now get
> this:
> xargs: ls: Argument list too long

/me tries

yep works like a charm, and that is a tree with a full git repo and
several build dirs in it.

> Which is kind of annoying but I can work around it though make distclean in
> my kernel tree dies with the same symptom (aka -E2BIG).
> 
> I run a vanilla 2.6.23-rc9 (Linux version 2.6.23-rc9 ([EMAIL PROTECTED])
> (gcc version 4.1.2 20070925 (Red Hat 4.1.2-27)) #1 Tue Oct 2 08:13:47 EDT
> 2007) on FC7...
> 
> Let me know if I can do anything.  I'm going to try to bisect the problem
> after I recompile the kernel without this patch...

what happens if you up the stack limit to say 128M ?

Also, do you happen to have execve syscall audit stuff enabled?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/