Re: [PATCH] Add Cobalt button interface driver support
Hi Dmitry, On Wed, 4 Apr 2007 00:01:41 -0400 Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > Hi Yoichi, > > Could you please try the patch below? It moves platform device creation > code into cobalt arch code to belletr follow driver model. It works fine. Acked-by: Yoichi Yuasa <[EMAIL PROTECTED]> Yoichi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add Cobalt button interface driver support
Hi Dmitry, On Wed, 4 Apr 2007 00:01:41 -0400 Dmitry Torokhov [EMAIL PROTECTED] wrote: Hi Yoichi, Could you please try the patch below? It moves platform device creation code into cobalt arch code to belletr follow driver model. It works fine. Acked-by: Yoichi Yuasa [EMAIL PROTECTED] Yoichi - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add Cobalt button interface driver support
Hi Yoichi,
Could you please try the patch below? It moves platform device creation
code into cobalt arch code to belletr follow driver model.
Thank you!
--
Dmitry
Input: cobalt buttons - separate device and driver registration
Create platform device for cobalt buttons as part of arch setup.
This makes the driver follow current driver model more closely.
Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]>
---
arch/mips/cobalt/Makefile|2 -
arch/mips/cobalt/buttons.c | 54 +++
drivers/input/misc/cobalt_btns.c | 24 -
3 files changed, 56 insertions(+), 24 deletions(-)
Index: work/arch/mips/cobalt/Makefile
===
--- work.orig/arch/mips/cobalt/Makefile
+++ work/arch/mips/cobalt/Makefile
@@ -2,7 +2,7 @@
# Makefile for the Cobalt micro systems family specific parts of the kernel
#
-obj-y := irq.o reset.o setup.o
+obj-y := irq.o reset.o setup.o buttons.o
obj-$(CONFIG_EARLY_PRINTK) += console.o
obj-$(CONFIG_MTD_PHYSMAP) += mtd.o
Index: work/arch/mips/cobalt/buttons.c
===
--- /dev/null
+++ work/arch/mips/cobalt/buttons.c
@@ -0,0 +1,54 @@
+/*
+ * Cobalt buttons platform device.
+ *
+ * Copyright (C) 2007 Yoichi Yuasa <[EMAIL PROTECTED]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+ */
+
+#include
+#include
+#include
+
+static struct resource cobalt_buttons_resource __initdata = {
+ .start = 0x1d00,
+ .end= 0x1d03,
+ .flags = IORESOURCE_MEM,
+};
+
+static __init int cobalt_add_buttons(void)
+{
+ struct platform_device *pd;
+ int error;
+
+ pd = platform_device_alloc("Cobalt buttons", -1);
+ if (!pd)
+ return -ENOMEM;
+
+ error = platform_device_add_resources(pd, _buttons_resource, 1);
+ if (error)
+ goto err_free_device;
+
+ error = platform_device_add(pd);
+ if (error)
+ goto err_free_device;
+
+ return 0;
+
+ err_free_device:
+ platform_device_put(pd);
+ return error;
+}
+device_initcall(cobalt_add_buttons);
Index: work/drivers/input/misc/cobalt_btns.c
===
--- work.orig/drivers/input/misc/cobalt_btns.c
+++ work/drivers/input/misc/cobalt_btns.c
@@ -50,14 +50,6 @@ static struct buttons_map buttons_map[]
{ 0x8000, KEY_SELECT, },
};
-static struct resource cobalt_buttons_resource __initdata = {
- .start = 0x1d00,
- .end= 0x1d03,
- .flags = IORESOURCE_MEM,
-};
-
-static struct platform_device *cobalt_buttons_device;
-
static struct timer_list buttons_timer;
static void handle_buttons(unsigned long data)
@@ -183,26 +175,12 @@ static struct platform_driver cobalt_but
static int __init cobalt_buttons_init(void)
{
- int retval;
-
- cobalt_buttons_device = platform_device_register_simple("Cobalt
buttons", -1,
-
_buttons_resource, 1);
- if (IS_ERR(cobalt_buttons_device)) {
- retval = PTR_ERR(cobalt_buttons_device);
- return retval;
- }
-
- retval = platform_driver_register(_buttons_driver);
- if (retval < 0)
- platform_device_unregister(cobalt_buttons_device);
-
- return retval;
+ return platform_driver_register(_buttons_driver);
}
static void __exit cobalt_buttons_exit(void)
{
platform_driver_unregister(_buttons_driver);
- platform_device_unregister(cobalt_buttons_device);
}
module_init(cobalt_buttons_init);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add Cobalt button interface driver support
Hi Yoichi,
Could you please try the patch below? It moves platform device creation
code into cobalt arch code to belletr follow driver model.
Thank you!
--
Dmitry
Input: cobalt buttons - separate device and driver registration
Create platform device for cobalt buttons as part of arch setup.
This makes the driver follow current driver model more closely.
Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED]
---
arch/mips/cobalt/Makefile|2 -
arch/mips/cobalt/buttons.c | 54 +++
drivers/input/misc/cobalt_btns.c | 24 -
3 files changed, 56 insertions(+), 24 deletions(-)
Index: work/arch/mips/cobalt/Makefile
===
--- work.orig/arch/mips/cobalt/Makefile
+++ work/arch/mips/cobalt/Makefile
@@ -2,7 +2,7 @@
# Makefile for the Cobalt micro systems family specific parts of the kernel
#
-obj-y := irq.o reset.o setup.o
+obj-y := irq.o reset.o setup.o buttons.o
obj-$(CONFIG_EARLY_PRINTK) += console.o
obj-$(CONFIG_MTD_PHYSMAP) += mtd.o
Index: work/arch/mips/cobalt/buttons.c
===
--- /dev/null
+++ work/arch/mips/cobalt/buttons.c
@@ -0,0 +1,54 @@
+/*
+ * Cobalt buttons platform device.
+ *
+ * Copyright (C) 2007 Yoichi Yuasa [EMAIL PROTECTED]
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+ */
+
+#include linux/platform_device.h
+#include linux/errno.h
+#include linux/init.h
+
+static struct resource cobalt_buttons_resource __initdata = {
+ .start = 0x1d00,
+ .end= 0x1d03,
+ .flags = IORESOURCE_MEM,
+};
+
+static __init int cobalt_add_buttons(void)
+{
+ struct platform_device *pd;
+ int error;
+
+ pd = platform_device_alloc(Cobalt buttons, -1);
+ if (!pd)
+ return -ENOMEM;
+
+ error = platform_device_add_resources(pd, cobalt_buttons_resource, 1);
+ if (error)
+ goto err_free_device;
+
+ error = platform_device_add(pd);
+ if (error)
+ goto err_free_device;
+
+ return 0;
+
+ err_free_device:
+ platform_device_put(pd);
+ return error;
+}
+device_initcall(cobalt_add_buttons);
Index: work/drivers/input/misc/cobalt_btns.c
===
--- work.orig/drivers/input/misc/cobalt_btns.c
+++ work/drivers/input/misc/cobalt_btns.c
@@ -50,14 +50,6 @@ static struct buttons_map buttons_map[]
{ 0x8000, KEY_SELECT, },
};
-static struct resource cobalt_buttons_resource __initdata = {
- .start = 0x1d00,
- .end= 0x1d03,
- .flags = IORESOURCE_MEM,
-};
-
-static struct platform_device *cobalt_buttons_device;
-
static struct timer_list buttons_timer;
static void handle_buttons(unsigned long data)
@@ -183,26 +175,12 @@ static struct platform_driver cobalt_but
static int __init cobalt_buttons_init(void)
{
- int retval;
-
- cobalt_buttons_device = platform_device_register_simple(Cobalt
buttons, -1,
-
cobalt_buttons_resource, 1);
- if (IS_ERR(cobalt_buttons_device)) {
- retval = PTR_ERR(cobalt_buttons_device);
- return retval;
- }
-
- retval = platform_driver_register(cobalt_buttons_driver);
- if (retval 0)
- platform_device_unregister(cobalt_buttons_device);
-
- return retval;
+ return platform_driver_register(cobalt_buttons_driver);
}
static void __exit cobalt_buttons_exit(void)
{
platform_driver_unregister(cobalt_buttons_driver);
- platform_device_unregister(cobalt_buttons_device);
}
module_init(cobalt_buttons_init);
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add Cobalt button interface driver support
On Fri, 16 Feb 2007 10:15:11 -0500
"Dmitry Torokhov" <[EMAIL PROTECTED]> wrote:
> On 2/16/07, Yoichi Yuasa <[EMAIL PROTECTED]> wrote:
> > +
> > +static int cobalt_buttons_open(struct inode *inode, struct file *file)
> > +{
> > + buttons_timer.expires = jiffies +
> > msecs_to_jiffies(BUTTONS_POLL_INTERVAL);
> > + add_timer(_timer);
> > +
> > + return nonseekable_open(inode, file);
> > +
> > +}
>
> Hi,
>
> I am sorry, I was not clear enough - when I was talking about adding
> cobalt_buttons_open/close I was not asking you to add a misc device to
> the driver. I was talking about setting up open() and close() methods
> in input_dev structure. These methods are called by input core when
> first (or last) user opens or closes one of input interfaces, such as
> /dev/input/eventX, /dev/input/jsX, etc and so it is naturally to
> start/stop polling device from these functions.
>
> Does this make sense?
make sense.
updated my patch.
Yoichi
Signed-off-by: Yoichi Yuasa <[EMAIL PROTECTED]>
diff -pruN -X cobalt-buttons/Documentation/dontdiff
cobalt-buttons-orig/drivers/input/misc/Kconfig
cobalt-buttons/drivers/input/misc/Kconfig
--- cobalt-buttons-orig/drivers/input/misc/Kconfig 2007-02-14
15:35:30.566862000 +0900
+++ cobalt-buttons/drivers/input/misc/Kconfig 2007-02-15 17:20:28.721985250
+0900
@@ -89,4 +89,10 @@ config HP_SDC_RTC
Say Y here if you want to support the built-in real time clock
of the HP SDC controller.
+config INPUT_COBALT_BTNS
+ tristate "Cobalt button interface"
+ depends on MIPS_COBALT
+ help
+ Say Y here if you want to support MIPS Cobalt button interface.
+
endif
diff -pruN -X cobalt-buttons/Documentation/dontdiff
cobalt-buttons-orig/drivers/input/misc/Makefile
cobalt-buttons/drivers/input/misc/Makefile
--- cobalt-buttons-orig/drivers/input/misc/Makefile 2007-02-14
15:35:30.566862000 +0900
+++ cobalt-buttons/drivers/input/misc/Makefile 2007-02-15 11:55:30.856042500
+0900
@@ -12,3 +12,4 @@ obj-$(CONFIG_INPUT_WISTRON_BTNS) += wist
obj-$(CONFIG_INPUT_ATLAS_BTNS) += atlas_btns.o
obj-$(CONFIG_HP_SDC_RTC) += hp_sdc_rtc.o
obj-$(CONFIG_INPUT_IXP4XX_BEEPER) += ixp4xx-beeper.o
+obj-$(CONFIG_INPUT_COBALT_BTNS)+= cobalt_btns.o
diff -pruN -X cobalt-buttons/Documentation/dontdiff
cobalt-buttons-orig/drivers/input/misc/cobalt_btns.c
cobalt-buttons/drivers/input/misc/cobalt_btns.c
--- cobalt-buttons-orig/drivers/input/misc/cobalt_btns.c1970-01-01
09:00:00.0 +0900
+++ cobalt-buttons/drivers/input/misc/cobalt_btns.c 2007-02-17
01:14:33.079876500 +0900
@@ -0,0 +1,211 @@
+/*
+ * Cobalt button interface driver.
+ *
+ * Copyright (C) 2007 Yoichi Yuasa <[EMAIL PROTECTED]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#define BUTTONS_POLL_INTERVAL 30 /* msec */
+#define BUTTONS_COUNT_THRESHOLD3
+#define BUTTONS_STATUS_MASK0xfe00
+
+struct buttons_dev {
+ struct input_dev *input;
+ void __iomem *reg;
+};
+
+struct buttons_map {
+ uint32_tmask;
+ int keycode;
+ int count;
+};
+
+static struct buttons_map buttons_map[] = {
+ { 0x0200, KEY_RESTART, },
+ { 0x0400, KEY_LEFT, },
+ { 0x0800, KEY_UP, },
+ { 0x1000, KEY_DOWN, },
+ { 0x2000, KEY_RIGHT, },
+ { 0x4000, KEY_ENTER, },
+ { 0x8000, KEY_SELECT, },
+};
+
+static struct resource cobalt_buttons_resource __initdata = {
+ .start = 0x1d00,
+ .end= 0x1d03,
+ .flags = IORESOURCE_MEM,
+};
+
+static struct platform_device *cobalt_buttons_device;
+
+static struct timer_list buttons_timer;
+
+static void handle_buttons(unsigned long data)
+{
+ struct buttons_map *button = buttons_map;
+ struct buttons_dev *bdev;
+ uint32_t status;
+ int i;
+
+ bdev = (struct buttons_dev *)data;
+ status = readl(bdev->reg);
+ status = ~status & BUTTONS_STATUS_MASK;
+
+ for (i = 0; i < ARRAY_SIZE(buttons_map); i++) {
+ if (status & button->mask) {
+ button->count++;
+ } else {
Re: [PATCH] Add Cobalt button interface driver support
On 2/16/07, Yoichi Yuasa <[EMAIL PROTECTED]> wrote:
+
+static int cobalt_buttons_open(struct inode *inode, struct file *file)
+{
+ buttons_timer.expires = jiffies +
msecs_to_jiffies(BUTTONS_POLL_INTERVAL);
+ add_timer(_timer);
+
+ return nonseekable_open(inode, file);
+
+}
Hi,
I am sorry, I was not clear enough - when I was talking about adding
cobalt_buttons_open/close I was not asking you to add a misc device to
the driver. I was talking about setting up open() and close() methods
in input_dev structure. These methods are called by input core when
first (or last) user opens or closes one of input interfaces, such as
/dev/input/eventX, /dev/input/jsX, etc and so it is naturally to
start/stop polling device from these functions.
Does this make sense?
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add Cobalt button interface driver support
Hi,
Thank you for your comments.
On Thu, 15 Feb 2007 23:09:43 -0500
Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> On Thursday 15 February 2007 22:36, Yoichi Yuasa wrote:
> > Hi,
> >
> > This patch adds support for the back panel buttons on Cobalt server.
> > It's tested on the Cobalt Qube2.
> >
>
> Hi,
>
> Thank you for your patch. Couple of comments:
>
> > +
> > + button++;
> > + }
> > +
> > + mod_timer(_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
>
> May I suggest using msecs_to_jiffies() to avoid direct computations on HZ?
OK, I updated it.
> > +
> > + bdev->input = input;
> > + bdev->reg = ioremap(res->start, res->end - res->start + 1);
> > + dev_set_drvdata(>dev, bdev);
> > +
> > + setup_timer(_timer, handle_buttons, (unsigned long)bdev);
> > + mod_timer(_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
>
> Please implement cobalt_buttons_open() and cobalt_buttons_close() methods
> and start/stop timer from there - there is no point in polling hardware
> if noone is listening to the events.
I updated it too.
> > +static int __devexit cobalt_buttons_remove(struct platform_device *pdev)
> > +{
> > + struct device *dev = >dev;
> > + struct buttons_dev *bdev = dev_get_drvdata(dev);
> > +
> > + del_timer(_timer);
>
> del_timer_sync? Is there any possibility it may run SMP?
Cobalt server doesn't support SMP. but there is no problem.
I updated it.
> > +static void __exit cobalt_buttons_exit(void)
> > +{
> > + platform_driver_unregister(_buttons_driver);
>
> You are not allowed to unregister statically allocated devices -
> if there are references left and your module goes away then
> these references become invalid and kernel goes boom.
>
> Please convert to platform_device_alloc/platform_device_add.
I updated it.
> Is there a point of moving platform device creation code into
> platform-specific code? Is there a possibility of this driver
> being used elsewhere?
No it isn't.
Yoichi
Signed-off-by: Yoichi Yuasa <[EMAIL PROTECTED]>
diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Kconfig
mips/drivers/input/misc/Kconfig
--- mips-orig/drivers/input/misc/Kconfig2007-02-14 15:35:30.566862000
+0900
+++ mips/drivers/input/misc/Kconfig 2007-02-15 17:20:28.721985250 +0900
@@ -89,4 +89,10 @@ config HP_SDC_RTC
Say Y here if you want to support the built-in real time clock
of the HP SDC controller.
+config INPUT_COBALT_BTNS
+ tristate "Cobalt button interface"
+ depends on MIPS_COBALT
+ help
+ Say Y here if you want to support MIPS Cobalt button interface.
+
endif
diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Makefile
mips/drivers/input/misc/Makefile
--- mips-orig/drivers/input/misc/Makefile 2007-02-14 15:35:30.566862000
+0900
+++ mips/drivers/input/misc/Makefile2007-02-15 11:55:30.856042500 +0900
@@ -12,3 +12,4 @@ obj-$(CONFIG_INPUT_WISTRON_BTNS) += wist
obj-$(CONFIG_INPUT_ATLAS_BTNS) += atlas_btns.o
obj-$(CONFIG_HP_SDC_RTC) += hp_sdc_rtc.o
obj-$(CONFIG_INPUT_IXP4XX_BEEPER) += ixp4xx-beeper.o
+obj-$(CONFIG_INPUT_COBALT_BTNS)+= cobalt_btns.o
diff -pruN -X mips/Documentation/dontdiff
mips-orig/drivers/input/misc/cobalt_btns.c mips/drivers/input/misc/cobalt_btns.c
--- mips-orig/drivers/input/misc/cobalt_btns.c 1970-01-01 09:00:00.0
+0900
+++ mips/drivers/input/misc/cobalt_btns.c 2007-02-16 16:09:48.857365000
+0900
@@ -0,0 +1,233 @@
+/*
+ * Cobalt button interface driver.
+ *
+ * Copyright (C) 2007 Yoichi Yuasa <[EMAIL PROTECTED]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#define BUTTONS_POLL_INTERVAL 30 /* msec */
+#define BUTTONS_COUNT_THRESHOLD3
+#define BUTTONS_STATUS_MASK0xfe00
+
+struct buttons_dev {
+ struct input_dev *input;
+ void __iomem *reg;
+};
+
+struct buttons_map {
+ uint32_tmask;
+ int keycode;
+ int count;
+};
+
+static struct buttons_map buttons_map[] = {
+ { 0x0200, KEY_RESTART, },
+ { 0x0400, KEY_LEFT, },
+ { 0x0800, KEY_UP, },
+ {
Re: [PATCH] Add Cobalt button interface driver support
Hi,
Thank you for your comments.
On Thu, 15 Feb 2007 23:09:43 -0500
Dmitry Torokhov [EMAIL PROTECTED] wrote:
On Thursday 15 February 2007 22:36, Yoichi Yuasa wrote:
Hi,
This patch adds support for the back panel buttons on Cobalt server.
It's tested on the Cobalt Qube2.
Hi,
Thank you for your patch. Couple of comments:
+
+ button++;
+ }
+
+ mod_timer(buttons_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
May I suggest using msecs_to_jiffies() to avoid direct computations on HZ?
OK, I updated it.
+
+ bdev-input = input;
+ bdev-reg = ioremap(res-start, res-end - res-start + 1);
+ dev_set_drvdata(pdev-dev, bdev);
+
+ setup_timer(buttons_timer, handle_buttons, (unsigned long)bdev);
+ mod_timer(buttons_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
Please implement cobalt_buttons_open() and cobalt_buttons_close() methods
and start/stop timer from there - there is no point in polling hardware
if noone is listening to the events.
I updated it too.
+static int __devexit cobalt_buttons_remove(struct platform_device *pdev)
+{
+ struct device *dev = pdev-dev;
+ struct buttons_dev *bdev = dev_get_drvdata(dev);
+
+ del_timer(buttons_timer);
del_timer_sync? Is there any possibility it may run SMP?
Cobalt server doesn't support SMP. but there is no problem.
I updated it.
+static void __exit cobalt_buttons_exit(void)
+{
+ platform_driver_unregister(cobalt_buttons_driver);
You are not allowed to unregister statically allocated devices -
if there are references left and your module goes away then
these references become invalid and kernel goes boom.
Please convert to platform_device_alloc/platform_device_add.
I updated it.
Is there a point of moving platform device creation code into
platform-specific code? Is there a possibility of this driver
being used elsewhere?
No it isn't.
Yoichi
Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED]
diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Kconfig
mips/drivers/input/misc/Kconfig
--- mips-orig/drivers/input/misc/Kconfig2007-02-14 15:35:30.566862000
+0900
+++ mips/drivers/input/misc/Kconfig 2007-02-15 17:20:28.721985250 +0900
@@ -89,4 +89,10 @@ config HP_SDC_RTC
Say Y here if you want to support the built-in real time clock
of the HP SDC controller.
+config INPUT_COBALT_BTNS
+ tristate Cobalt button interface
+ depends on MIPS_COBALT
+ help
+ Say Y here if you want to support MIPS Cobalt button interface.
+
endif
diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Makefile
mips/drivers/input/misc/Makefile
--- mips-orig/drivers/input/misc/Makefile 2007-02-14 15:35:30.566862000
+0900
+++ mips/drivers/input/misc/Makefile2007-02-15 11:55:30.856042500 +0900
@@ -12,3 +12,4 @@ obj-$(CONFIG_INPUT_WISTRON_BTNS) += wist
obj-$(CONFIG_INPUT_ATLAS_BTNS) += atlas_btns.o
obj-$(CONFIG_HP_SDC_RTC) += hp_sdc_rtc.o
obj-$(CONFIG_INPUT_IXP4XX_BEEPER) += ixp4xx-beeper.o
+obj-$(CONFIG_INPUT_COBALT_BTNS)+= cobalt_btns.o
diff -pruN -X mips/Documentation/dontdiff
mips-orig/drivers/input/misc/cobalt_btns.c mips/drivers/input/misc/cobalt_btns.c
--- mips-orig/drivers/input/misc/cobalt_btns.c 1970-01-01 09:00:00.0
+0900
+++ mips/drivers/input/misc/cobalt_btns.c 2007-02-16 16:09:48.857365000
+0900
@@ -0,0 +1,233 @@
+/*
+ * Cobalt button interface driver.
+ *
+ * Copyright (C) 2007 Yoichi Yuasa [EMAIL PROTECTED]
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+ */
+#include linux/init.h
+#include linux/input.h
+#include linux/ioport.h
+#include linux/miscdevice.h
+#include linux/module.h
+#include linux/platform_device.h
+#include linux/jiffies.h
+#include linux/timer.h
+
+#include asm/param.h
+
+#define BUTTONS_POLL_INTERVAL 30 /* msec */
+#define BUTTONS_COUNT_THRESHOLD3
+#define BUTTONS_STATUS_MASK0xfe00
+
+struct buttons_dev {
+ struct input_dev *input;
+ void __iomem *reg;
+};
+
+struct buttons_map {
+ uint32_tmask;
+ int keycode;
+ int count;
+};
+
+static struct buttons_map buttons_map[] = {
+ { 0x0200,
Re: [PATCH] Add Cobalt button interface driver support
On 2/16/07, Yoichi Yuasa [EMAIL PROTECTED] wrote:
+
+static int cobalt_buttons_open(struct inode *inode, struct file *file)
+{
+ buttons_timer.expires = jiffies +
msecs_to_jiffies(BUTTONS_POLL_INTERVAL);
+ add_timer(buttons_timer);
+
+ return nonseekable_open(inode, file);
+
+}
Hi,
I am sorry, I was not clear enough - when I was talking about adding
cobalt_buttons_open/close I was not asking you to add a misc device to
the driver. I was talking about setting up open() and close() methods
in input_dev structure. These methods are called by input core when
first (or last) user opens or closes one of input interfaces, such as
/dev/input/eventX, /dev/input/jsX, etc and so it is naturally to
start/stop polling device from these functions.
Does this make sense?
--
Dmitry
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add Cobalt button interface driver support
On Fri, 16 Feb 2007 10:15:11 -0500
Dmitry Torokhov [EMAIL PROTECTED] wrote:
On 2/16/07, Yoichi Yuasa [EMAIL PROTECTED] wrote:
+
+static int cobalt_buttons_open(struct inode *inode, struct file *file)
+{
+ buttons_timer.expires = jiffies +
msecs_to_jiffies(BUTTONS_POLL_INTERVAL);
+ add_timer(buttons_timer);
+
+ return nonseekable_open(inode, file);
+
+}
Hi,
I am sorry, I was not clear enough - when I was talking about adding
cobalt_buttons_open/close I was not asking you to add a misc device to
the driver. I was talking about setting up open() and close() methods
in input_dev structure. These methods are called by input core when
first (or last) user opens or closes one of input interfaces, such as
/dev/input/eventX, /dev/input/jsX, etc and so it is naturally to
start/stop polling device from these functions.
Does this make sense?
make sense.
updated my patch.
Yoichi
Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED]
diff -pruN -X cobalt-buttons/Documentation/dontdiff
cobalt-buttons-orig/drivers/input/misc/Kconfig
cobalt-buttons/drivers/input/misc/Kconfig
--- cobalt-buttons-orig/drivers/input/misc/Kconfig 2007-02-14
15:35:30.566862000 +0900
+++ cobalt-buttons/drivers/input/misc/Kconfig 2007-02-15 17:20:28.721985250
+0900
@@ -89,4 +89,10 @@ config HP_SDC_RTC
Say Y here if you want to support the built-in real time clock
of the HP SDC controller.
+config INPUT_COBALT_BTNS
+ tristate Cobalt button interface
+ depends on MIPS_COBALT
+ help
+ Say Y here if you want to support MIPS Cobalt button interface.
+
endif
diff -pruN -X cobalt-buttons/Documentation/dontdiff
cobalt-buttons-orig/drivers/input/misc/Makefile
cobalt-buttons/drivers/input/misc/Makefile
--- cobalt-buttons-orig/drivers/input/misc/Makefile 2007-02-14
15:35:30.566862000 +0900
+++ cobalt-buttons/drivers/input/misc/Makefile 2007-02-15 11:55:30.856042500
+0900
@@ -12,3 +12,4 @@ obj-$(CONFIG_INPUT_WISTRON_BTNS) += wist
obj-$(CONFIG_INPUT_ATLAS_BTNS) += atlas_btns.o
obj-$(CONFIG_HP_SDC_RTC) += hp_sdc_rtc.o
obj-$(CONFIG_INPUT_IXP4XX_BEEPER) += ixp4xx-beeper.o
+obj-$(CONFIG_INPUT_COBALT_BTNS)+= cobalt_btns.o
diff -pruN -X cobalt-buttons/Documentation/dontdiff
cobalt-buttons-orig/drivers/input/misc/cobalt_btns.c
cobalt-buttons/drivers/input/misc/cobalt_btns.c
--- cobalt-buttons-orig/drivers/input/misc/cobalt_btns.c1970-01-01
09:00:00.0 +0900
+++ cobalt-buttons/drivers/input/misc/cobalt_btns.c 2007-02-17
01:14:33.079876500 +0900
@@ -0,0 +1,211 @@
+/*
+ * Cobalt button interface driver.
+ *
+ * Copyright (C) 2007 Yoichi Yuasa [EMAIL PROTECTED]
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+ */
+#include linux/init.h
+#include linux/input.h
+#include linux/ioport.h
+#include linux/module.h
+#include linux/platform_device.h
+#include linux/jiffies.h
+#include linux/timer.h
+
+#define BUTTONS_POLL_INTERVAL 30 /* msec */
+#define BUTTONS_COUNT_THRESHOLD3
+#define BUTTONS_STATUS_MASK0xfe00
+
+struct buttons_dev {
+ struct input_dev *input;
+ void __iomem *reg;
+};
+
+struct buttons_map {
+ uint32_tmask;
+ int keycode;
+ int count;
+};
+
+static struct buttons_map buttons_map[] = {
+ { 0x0200, KEY_RESTART, },
+ { 0x0400, KEY_LEFT, },
+ { 0x0800, KEY_UP, },
+ { 0x1000, KEY_DOWN, },
+ { 0x2000, KEY_RIGHT, },
+ { 0x4000, KEY_ENTER, },
+ { 0x8000, KEY_SELECT, },
+};
+
+static struct resource cobalt_buttons_resource __initdata = {
+ .start = 0x1d00,
+ .end= 0x1d03,
+ .flags = IORESOURCE_MEM,
+};
+
+static struct platform_device *cobalt_buttons_device;
+
+static struct timer_list buttons_timer;
+
+static void handle_buttons(unsigned long data)
+{
+ struct buttons_map *button = buttons_map;
+ struct buttons_dev *bdev;
+ uint32_t status;
+ int i;
+
+ bdev = (struct buttons_dev *)data;
+ status = readl(bdev-reg);
+ status = ~status BUTTONS_STATUS_MASK;
+
+ for (i = 0; i ARRAY_SIZE(buttons_map); i++) {
+ if (status button-mask) {
+
[PATCH] Add Cobalt button interface driver support
Hi,
This patch adds support for the back panel buttons on Cobalt server.
It's tested on the Cobalt Qube2.
Yoichi
Signed-off-by: Yoichi Yuasa <[EMAIL PROTECTED]>
diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Kconfig
mips/drivers/input/misc/Kconfig
--- mips-orig/drivers/input/misc/Kconfig2007-02-14 15:35:30.566862000
+0900
+++ mips/drivers/input/misc/Kconfig 2007-02-15 17:20:28.721985250 +0900
@@ -89,4 +89,10 @@ config HP_SDC_RTC
Say Y here if you want to support the built-in real time clock
of the HP SDC controller.
+config INPUT_COBALT_BTNS
+ tristate "Cobalt button interface"
+ depends on MIPS_COBALT
+ help
+ Say Y here if you want to support MIPS Cobalt button interface.
+
endif
diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Makefile
mips/drivers/input/misc/Makefile
--- mips-orig/drivers/input/misc/Makefile 2007-02-14 15:35:30.566862000
+0900
+++ mips/drivers/input/misc/Makefile2007-02-15 11:55:30.856042500 +0900
@@ -12,3 +12,4 @@ obj-$(CONFIG_INPUT_WISTRON_BTNS) += wist
obj-$(CONFIG_INPUT_ATLAS_BTNS) += atlas_btns.o
obj-$(CONFIG_HP_SDC_RTC) += hp_sdc_rtc.o
obj-$(CONFIG_INPUT_IXP4XX_BEEPER) += ixp4xx-beeper.o
+obj-$(CONFIG_INPUT_COBALT_BTNS)+= cobalt_btns.o
diff -pruN -X mips/Documentation/dontdiff
mips-orig/drivers/input/misc/cobalt_btns.c mips/drivers/input/misc/cobalt_btns.c
--- mips-orig/drivers/input/misc/cobalt_btns.c 1970-01-01 09:00:00.0
+0900
+++ mips/drivers/input/misc/cobalt_btns.c 2007-02-15 17:17:31.550912750
+0900
@@ -0,0 +1,199 @@
+/*
+ * Cobalt button interface driver.
+ *
+ * Copyright (C) 2007 Yoichi Yuasa <[EMAIL PROTECTED]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#define BUTTONS_POLL_FREQUENCY 30
+#define BUTTONS_COUNT_THRESHOLD3
+#define BUTTONS_STATUS_MASK0xfe00
+
+struct buttons_dev {
+ struct input_dev *input;
+ void __iomem *reg;
+};
+
+struct buttons_map {
+ uint32_tmask;
+ int keycode;
+ int count;
+};
+
+static struct buttons_map buttons_map[] = {
+ { 0x0200, KEY_RESTART, },
+ { 0x0400, KEY_LEFT, },
+ { 0x0800, KEY_UP, },
+ { 0x1000, KEY_DOWN, },
+ { 0x2000, KEY_RIGHT, },
+ { 0x4000, KEY_ENTER, },
+ { 0x8000, KEY_SELECT, },
+};
+
+static struct resource cobalt_buttons_resource = {
+ .start = 0x1d00,
+ .end= 0x1d03,
+ .flags = IORESOURCE_MEM,
+};
+
+static struct platform_device cobalt_buttons_device = {
+ .name = "Cobalt buttons",
+ .num_resources = 1,
+ .resource = _buttons_resource,
+};
+
+static struct timer_list buttons_timer;
+
+static void handle_buttons(unsigned long data)
+{
+ struct buttons_map *button = buttons_map;
+ struct buttons_dev *bdev;
+ uint32_t status;
+ int i;
+
+ bdev = (struct buttons_dev *)data;
+ status = readl(bdev->reg);
+ status = ~status & BUTTONS_STATUS_MASK;
+
+ for (i = 0; i < ARRAY_SIZE(buttons_map); i++) {
+ if (status & button->mask) {
+ button->count++;
+ } else {
+ if (button->count >= BUTTONS_COUNT_THRESHOLD) {
+ input_report_key(bdev->input, button->keycode,
0);
+ input_sync(bdev->input);
+ }
+ button->count = 0;
+ }
+
+ if (button->count == BUTTONS_COUNT_THRESHOLD) {
+ input_report_key(bdev->input, button->keycode, 1);
+ input_sync(bdev->input);
+ }
+
+ button++;
+ }
+
+ mod_timer(_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
+}
+
+static int __init cobalt_buttons_probe(struct platform_device *pdev)
+{
+ struct buttons_dev *bdev;
+ struct input_dev *input;
+ struct resource *res;
+ int retval, i;
+
+ bdev = kzalloc(sizeof(struct buttons_dev), GFP_KERNEL);
+ if
Re: [PATCH] Add Cobalt button interface driver support
On Thursday 15 February 2007 22:36, Yoichi Yuasa wrote:
> Hi,
>
> This patch adds support for the back panel buttons on Cobalt server.
> It's tested on the Cobalt Qube2.
>
Hi,
Thank you for your patch. Couple of comments:
> +
> + button++;
> + }
> +
> + mod_timer(_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
May I suggest using msecs_to_jiffies() to avoid direct computations on HZ?
> +
> + bdev->input = input;
> + bdev->reg = ioremap(res->start, res->end - res->start + 1);
> + dev_set_drvdata(>dev, bdev);
> +
> + setup_timer(_timer, handle_buttons, (unsigned long)bdev);
> + mod_timer(_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
Please implement cobalt_buttons_open() and cobalt_buttons_close() methods
and start/stop timer from there - there is no point in polling hardware
if noone is listening to the events.
> +
> + return retval;
> +}
> +
> +static int __devexit cobalt_buttons_remove(struct platform_device *pdev)
> +{
> + struct device *dev = >dev;
> + struct buttons_dev *bdev = dev_get_drvdata(dev);
> +
> + del_timer(_timer);
del_timer_sync? Is there any possibility it may run SMP?
> +
> +static void __exit cobalt_buttons_exit(void)
> +{
> + platform_driver_unregister(_buttons_driver);
You are not allowed to unregister statically allocated devices -
if there are references left and your module goes away then
these references become invalid and kernel goes boom.
Please convert to platform_device_alloc/platform_device_add.
Is there a point of moving platform device creation code into
platform-specific code? Is there a possibility of this driver
being used elsewhere?
> + platform_device_unregister(_buttons_device);
> +}
> +
> +module_init(cobalt_buttons_init);
> +module_exit(cobalt_buttons_exit);
>
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add Cobalt button interface driver support
On Thursday 15 February 2007 22:36, Yoichi Yuasa wrote:
Hi,
This patch adds support for the back panel buttons on Cobalt server.
It's tested on the Cobalt Qube2.
Hi,
Thank you for your patch. Couple of comments:
+
+ button++;
+ }
+
+ mod_timer(buttons_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
May I suggest using msecs_to_jiffies() to avoid direct computations on HZ?
+
+ bdev-input = input;
+ bdev-reg = ioremap(res-start, res-end - res-start + 1);
+ dev_set_drvdata(pdev-dev, bdev);
+
+ setup_timer(buttons_timer, handle_buttons, (unsigned long)bdev);
+ mod_timer(buttons_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
Please implement cobalt_buttons_open() and cobalt_buttons_close() methods
and start/stop timer from there - there is no point in polling hardware
if noone is listening to the events.
+
+ return retval;
+}
+
+static int __devexit cobalt_buttons_remove(struct platform_device *pdev)
+{
+ struct device *dev = pdev-dev;
+ struct buttons_dev *bdev = dev_get_drvdata(dev);
+
+ del_timer(buttons_timer);
del_timer_sync? Is there any possibility it may run SMP?
+
+static void __exit cobalt_buttons_exit(void)
+{
+ platform_driver_unregister(cobalt_buttons_driver);
You are not allowed to unregister statically allocated devices -
if there are references left and your module goes away then
these references become invalid and kernel goes boom.
Please convert to platform_device_alloc/platform_device_add.
Is there a point of moving platform device creation code into
platform-specific code? Is there a possibility of this driver
being used elsewhere?
+ platform_device_unregister(cobalt_buttons_device);
+}
+
+module_init(cobalt_buttons_init);
+module_exit(cobalt_buttons_exit);
--
Dmitry
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Add Cobalt button interface driver support
Hi,
This patch adds support for the back panel buttons on Cobalt server.
It's tested on the Cobalt Qube2.
Yoichi
Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED]
diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Kconfig
mips/drivers/input/misc/Kconfig
--- mips-orig/drivers/input/misc/Kconfig2007-02-14 15:35:30.566862000
+0900
+++ mips/drivers/input/misc/Kconfig 2007-02-15 17:20:28.721985250 +0900
@@ -89,4 +89,10 @@ config HP_SDC_RTC
Say Y here if you want to support the built-in real time clock
of the HP SDC controller.
+config INPUT_COBALT_BTNS
+ tristate Cobalt button interface
+ depends on MIPS_COBALT
+ help
+ Say Y here if you want to support MIPS Cobalt button interface.
+
endif
diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Makefile
mips/drivers/input/misc/Makefile
--- mips-orig/drivers/input/misc/Makefile 2007-02-14 15:35:30.566862000
+0900
+++ mips/drivers/input/misc/Makefile2007-02-15 11:55:30.856042500 +0900
@@ -12,3 +12,4 @@ obj-$(CONFIG_INPUT_WISTRON_BTNS) += wist
obj-$(CONFIG_INPUT_ATLAS_BTNS) += atlas_btns.o
obj-$(CONFIG_HP_SDC_RTC) += hp_sdc_rtc.o
obj-$(CONFIG_INPUT_IXP4XX_BEEPER) += ixp4xx-beeper.o
+obj-$(CONFIG_INPUT_COBALT_BTNS)+= cobalt_btns.o
diff -pruN -X mips/Documentation/dontdiff
mips-orig/drivers/input/misc/cobalt_btns.c mips/drivers/input/misc/cobalt_btns.c
--- mips-orig/drivers/input/misc/cobalt_btns.c 1970-01-01 09:00:00.0
+0900
+++ mips/drivers/input/misc/cobalt_btns.c 2007-02-15 17:17:31.550912750
+0900
@@ -0,0 +1,199 @@
+/*
+ * Cobalt button interface driver.
+ *
+ * Copyright (C) 2007 Yoichi Yuasa [EMAIL PROTECTED]
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
USA
+ */
+#include linux/init.h
+#include linux/input.h
+#include linux/ioport.h
+#include linux/module.h
+#include linux/platform_device.h
+#include linux/jiffies.h
+#include linux/timer.h
+
+#include asm/param.h
+
+#define BUTTONS_POLL_FREQUENCY 30
+#define BUTTONS_COUNT_THRESHOLD3
+#define BUTTONS_STATUS_MASK0xfe00
+
+struct buttons_dev {
+ struct input_dev *input;
+ void __iomem *reg;
+};
+
+struct buttons_map {
+ uint32_tmask;
+ int keycode;
+ int count;
+};
+
+static struct buttons_map buttons_map[] = {
+ { 0x0200, KEY_RESTART, },
+ { 0x0400, KEY_LEFT, },
+ { 0x0800, KEY_UP, },
+ { 0x1000, KEY_DOWN, },
+ { 0x2000, KEY_RIGHT, },
+ { 0x4000, KEY_ENTER, },
+ { 0x8000, KEY_SELECT, },
+};
+
+static struct resource cobalt_buttons_resource = {
+ .start = 0x1d00,
+ .end= 0x1d03,
+ .flags = IORESOURCE_MEM,
+};
+
+static struct platform_device cobalt_buttons_device = {
+ .name = Cobalt buttons,
+ .num_resources = 1,
+ .resource = cobalt_buttons_resource,
+};
+
+static struct timer_list buttons_timer;
+
+static void handle_buttons(unsigned long data)
+{
+ struct buttons_map *button = buttons_map;
+ struct buttons_dev *bdev;
+ uint32_t status;
+ int i;
+
+ bdev = (struct buttons_dev *)data;
+ status = readl(bdev-reg);
+ status = ~status BUTTONS_STATUS_MASK;
+
+ for (i = 0; i ARRAY_SIZE(buttons_map); i++) {
+ if (status button-mask) {
+ button-count++;
+ } else {
+ if (button-count = BUTTONS_COUNT_THRESHOLD) {
+ input_report_key(bdev-input, button-keycode,
0);
+ input_sync(bdev-input);
+ }
+ button-count = 0;
+ }
+
+ if (button-count == BUTTONS_COUNT_THRESHOLD) {
+ input_report_key(bdev-input, button-keycode, 1);
+ input_sync(bdev-input);
+ }
+
+ button++;
+ }
+
+ mod_timer(buttons_timer, jiffies + HZ / BUTTONS_POLL_FREQUENCY);
+}
+
+static int __init cobalt_buttons_probe(struct platform_device *pdev)
+{
+ struct buttons_dev *bdev;
+ struct input_dev *input;
+ struct resource *res;
+
