Re: [PATCH] iio: lm3533-als: Fix build warnings

[Johan Hovold]

On Tue, Aug 14, 2012 at 09:29:21PM +0100, Jonathan Cameron wrote:
> On 08/02/2012 11:10 AM, Axel Lin wrote:
> > Fix below build warnings:
> >   CC [M]  drivers/iio/light/lm3533-als.o
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from 
> > incompatible pointer type [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 
> > 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from 
> > incompatible pointer type [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 
> > 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
> > 
> > Signed-off-by: Axel Lin 
> Thanks queued up.

Thanks for fixing this and sorry for not responding sooner (vacation...).

Johan

> > ---
> >  drivers/iio/light/lm3533-als.c |4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> > index c3e7bac..e45712a9 100644
> > --- a/drivers/iio/light/lm3533-als.c
> > +++ b/drivers/iio/light/lm3533-als.c
> > @@ -404,7 +404,7 @@ out:
> > return ret;
> >  }
> >  
> > -static int show_thresh_either_en(struct device *dev,
> > +static ssize_t show_thresh_either_en(struct device *dev,
> > struct device_attribute *attr,
> > char *buf)
> >  {
> > @@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
> > return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
> >  }
> >  
> > -static int store_thresh_either_en(struct device *dev,
> > +static ssize_t store_thresh_either_en(struct device *dev,
> > struct device_attribute *attr,
> > const char *buf, size_t len)
> >  {
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] iio: lm3533-als: Fix build warnings

[Jonathan Cameron]

On 08/02/2012 11:10 AM, Axel Lin wrote:
> Fix below build warnings:
>   CC [M]  drivers/iio/light/lm3533-als.o
> drivers/iio/light/lm3533-als.c:667:8: warning: initialization from 
> incompatible pointer type [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 
> 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: initialization from 
> incompatible pointer type [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 
> 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
> 
> Signed-off-by: Axel Lin 
Thanks queued up.
> ---
>  drivers/iio/light/lm3533-als.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> index c3e7bac..e45712a9 100644
> --- a/drivers/iio/light/lm3533-als.c
> +++ b/drivers/iio/light/lm3533-als.c
> @@ -404,7 +404,7 @@ out:
>   return ret;
>  }
>  
> -static int show_thresh_either_en(struct device *dev,
> +static ssize_t show_thresh_either_en(struct device *dev,
>   struct device_attribute *attr,
>   char *buf)
>  {
> @@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
>   return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
>  }
>  
> -static int store_thresh_either_en(struct device *dev,
> +static ssize_t store_thresh_either_en(struct device *dev,
>   struct device_attribute *attr,
>   const char *buf, size_t len)
>  {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] iio: lm3533-als: Fix build warnings

[Axel Lin]

Fix below build warnings:
  CC [M]  drivers/iio/light/lm3533-als.o
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible 
pointer type [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 
'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible 
pointer type [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 
'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]

Signed-off-by: Axel Lin 
---
 drivers/iio/light/lm3533-als.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
index c3e7bac..e45712a9 100644
--- a/drivers/iio/light/lm3533-als.c
+++ b/drivers/iio/light/lm3533-als.c
@@ -404,7 +404,7 @@ out:
return ret;
 }
 
-static int show_thresh_either_en(struct device *dev,
+static ssize_t show_thresh_either_en(struct device *dev,
struct device_attribute *attr,
char *buf)
 {
@@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
 }
 
-static int store_thresh_either_en(struct device *dev,
+static ssize_t store_thresh_either_en(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t len)
 {
-- 
1.7.9.5



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/