Re: [PATCH] mm/page_counter: use page_counter_read in page_counter_set_max

2020-11-13 Thread Pankaj Gupta
> use page_counter_read() in page_counter_set_max().
>
> Signed-off-by: Hui Su 
> ---
>  mm/page_counter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_counter.c b/mm/page_counter.c
> index b24a60b28bb0..c6860f51b6c6 100644
> --- a/mm/page_counter.c
> +++ b/mm/page_counter.c
> @@ -183,14 +183,14 @@ int page_counter_set_max(struct page_counter *counter, 
> unsigned long nr_pages)
>  * the limit, so if it sees the old limit, we see the
>  * modified counter and retry.
>  */
> -   usage = atomic_long_read(>usage);
> +   usage = page_counter_read(counter);
>
> if (usage > nr_pages)
> return -EBUSY;
>
> old = xchg(>max, nr_pages);
>
> -   if (atomic_long_read(>usage) <= usage)
> +   if (page_counter_read(counter) <= usage)
> return 0;
>
> counter->max = old;

Reviewed-by: Pankaj Gupta 


[PATCH] mm/page_counter: use page_counter_read in page_counter_set_max

2020-11-13 Thread Hui Su
use page_counter_read() in page_counter_set_max().

Signed-off-by: Hui Su 
---
 mm/page_counter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_counter.c b/mm/page_counter.c
index b24a60b28bb0..c6860f51b6c6 100644
--- a/mm/page_counter.c
+++ b/mm/page_counter.c
@@ -183,14 +183,14 @@ int page_counter_set_max(struct page_counter *counter, 
unsigned long nr_pages)
 * the limit, so if it sees the old limit, we see the
 * modified counter and retry.
 */
-   usage = atomic_long_read(>usage);
+   usage = page_counter_read(counter);
 
if (usage > nr_pages)
return -EBUSY;
 
old = xchg(>max, nr_pages);
 
-   if (atomic_long_read(>usage) <= usage)
+   if (page_counter_read(counter) <= usage)
return 0;
 
counter->max = old;
-- 
2.29.0