Re: [PATCH] mm: compaction: show gfp flag names in try_to_compact_pages tracepoint
On 3/2/19 5:38 AM, Yafang Shao wrote:
> show the gfp flag names instead of the gfp_mask could make the trace
> more convenient.
>
> Signed-off-by: Yafang Shao
Acked-by: Vlastimil Babka
> ---
> include/trace/events/compaction.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/compaction.h
> b/include/trace/events/compaction.h
> index 6074eff..e66afb818 100644
> --- a/include/trace/events/compaction.h
> +++ b/include/trace/events/compaction.h
> @@ -189,9 +189,9 @@
> __entry->prio = prio;
> ),
>
> - TP_printk("order=%d gfp_mask=0x%x priority=%d",
> + TP_printk("order=%d gfp_mask=%s priority=%d",
> __entry->order,
> - __entry->gfp_mask,
> + show_gfp_flags(__entry->gfp_mask),
> __entry->prio)
> );
>
>
Re: [PATCH] mm: compaction: show gfp flag names in try_to_compact_pages tracepoint
On Sat 02-03-19 12:38:57, Yafang Shao wrote:
> show the gfp flag names instead of the gfp_mask could make the trace
> more convenient.
Agreed
> Signed-off-by: Yafang Shao
Acked-by: Michal Hocko
> ---
> include/trace/events/compaction.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/compaction.h
> b/include/trace/events/compaction.h
> index 6074eff..e66afb818 100644
> --- a/include/trace/events/compaction.h
> +++ b/include/trace/events/compaction.h
> @@ -189,9 +189,9 @@
> __entry->prio = prio;
> ),
>
> - TP_printk("order=%d gfp_mask=0x%x priority=%d",
> + TP_printk("order=%d gfp_mask=%s priority=%d",
> __entry->order,
> - __entry->gfp_mask,
> + show_gfp_flags(__entry->gfp_mask),
> __entry->prio)
> );
>
> --
> 1.8.3.1
>
--
Michal Hocko
SUSE Labs
Re: [PATCH] mm: compaction: show gfp flag names in try_to_compact_pages tracepoint
On Sun, Mar 3, 2019 at 7:04 AM kbuild test robot wrote: > > Hi Yafang, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on tip/perf/core] > [also build test WARNING on v5.0-rc8 next-20190301] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Yafang-Shao/mm-compaction-show-gfp-flag-names-in-try_to_compact_pages-tracepoint/20190302-212241 > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > > All warnings (new ones prefixed by >>): > > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > >> include/trace/events/compaction.h:171:1: sparse: warning: cast from > >> restricted gfp_t > > sparse warnings: (new ones prefixed by >>) > >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >include/trace/events/compaction.h:171:1: sparse: warning: cast from > restricted gfp_t >
Re: [PATCH] mm: compaction: show gfp flag names in try_to_compact_pages tracepoint
Hi Yafang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/perf/core] [also build test WARNING on v5.0-rc8 next-20190301] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yafang-Shao/mm-compaction-show-gfp-flag-names-in-try_to_compact_pages-tracepoint/20190302-212241 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' All warnings (new ones prefixed by >>): >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t >> include/trace/events/compaction.h:171:1: sparse: warning: cast from >> restricted gfp_t sparse warnings: (new ones prefixed by >>) include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t include/trace/events/compaction.h:171:1: sparse: warning: cast from restricted gfp_t
[PATCH] mm: compaction: show gfp flag names in try_to_compact_pages tracepoint
show the gfp flag names instead of the gfp_mask could make the trace
more convenient.
Signed-off-by: Yafang Shao
---
include/trace/events/compaction.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/compaction.h
b/include/trace/events/compaction.h
index 6074eff..e66afb818 100644
--- a/include/trace/events/compaction.h
+++ b/include/trace/events/compaction.h
@@ -189,9 +189,9 @@
__entry->prio = prio;
),
- TP_printk("order=%d gfp_mask=0x%x priority=%d",
+ TP_printk("order=%d gfp_mask=%s priority=%d",
__entry->order,
- __entry->gfp_mask,
+ show_gfp_flags(__entry->gfp_mask),
__entry->prio)
);
--
1.8.3.1
