Re: [PATCH] proc: add "Seccomp" to status

2012-10-31 Thread Andrew Morton 
On Wed, 31 Oct 2012 13:09:27 -0700
Kees Cook  wrote:

> Adds the seccomp mode to the /proc/$pid/status file so the state of
> seccomp can be externally examined.

There's no reason here for anyone to apply this patch to anything. 
Presumably you see some value to our users - please share your thoughts
with us ;)

> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c
> @@ -327,6 +327,13 @@ static inline void task_cap(struct seq_file *m, struct 
> task_struct *p)
>   render_cap_t(m, "CapBnd:\t", &cap_bset);
>  }
>  
> +static inline void task_seccomp(struct seq_file *m, struct task_struct *p)
> +{
> +#ifdef CONFIG_SECCOMP

hm, OK, cpuset_task_status_allowed() is a no-op if CONFIG_CPUSETS=n, so
there is precedent for fields vanishing with Kconfig changes.

> + seq_printf(m, "Seccomp:\t%d\n", p->seccomp.mode);

Get thee yon unto Documentation/filesystems/proc.txt!

> +#endif
> +}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] proc: add "Seccomp" to status

2012-10-31 Thread Cyrill Gorcunov 
On Wed, Oct 31, 2012 at 01:09:27PM -0700, Kees Cook wrote:
> Adds the seccomp mode to the /proc/$pid/status file so the state of
> seccomp can be externally examined.
> 
> Signed-off-by: Kees Cook 

Reviewed-by: Cyrill Gorcunov 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] proc: add "Seccomp" to status

2012-10-31 Thread Kees Cook 
Adds the seccomp mode to the /proc/$pid/status file so the state of
seccomp can be externally examined.

Signed-off-by: Kees Cook 
---
 fs/proc/array.c |8 
 1 file changed, 8 insertions(+)

diff --git a/fs/proc/array.c b/fs/proc/array.c
index c1c207c..135d6ac 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -327,6 +327,13 @@ static inline void task_cap(struct seq_file *m, struct 
task_struct *p)
render_cap_t(m, "CapBnd:\t", &cap_bset);
 }
 
+static inline void task_seccomp(struct seq_file *m, struct task_struct *p)
+{
+#ifdef CONFIG_SECCOMP
+   seq_printf(m, "Seccomp:\t%d\n", p->seccomp.mode);
+#endif
+}
+
 static inline void task_context_switch_counts(struct seq_file *m,
struct task_struct *p)
 {
@@ -360,6 +367,7 @@ int proc_pid_status(struct seq_file *m, struct 
pid_namespace *ns,
}
task_sig(m, task);
task_cap(m, task);
+   task_seccomp(m, task);
task_cpus_allowed(m, task);
cpuset_task_status_allowed(m, task);
task_context_switch_counts(m, task);
-- 
1.7.9.5


-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/