Re: [PATCH] tun: remove copyright printing
From: Corentin LabbeDate: Wed, 8 Mar 2017 16:46:57 +0100 > Printing copyright does not give any useful information on the boot > process. > Furthermore, the email address printed is obsolete since > commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries") > > Signed-off-by: Corentin Labbe Applied, thanks.
Re: [PATCH] tun: remove copyright printing
From: Corentin Labbe Date: Wed, 8 Mar 2017 16:46:57 +0100 > Printing copyright does not give any useful information on the boot > process. > Furthermore, the email address printed is obsolete since > commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries") > > Signed-off-by: Corentin Labbe Applied, thanks.
Re: [PATCH] tun: remove copyright printing
On Wed, 8 Mar 2017 16:46:57 +0100 Corentin Labbewrote: > Printing copyright does not give any useful information on the boot > process. > Furthermore, the email address printed is obsolete since > commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries") > > Signed-off-by: Corentin Labbe > --- > drivers/net/tun.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index dc1b1dd..f58b7d8 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -2570,7 +2570,6 @@ static int __init tun_init(void) > int ret = 0; > > pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION); > - pr_info("%s\n", DRV_COPYRIGHT); > > ret = rtnl_link_register(_link_ops); > if (ret) { Why not just kill the pr_info() all together. It is just a vanity message.
Re: [PATCH] tun: remove copyright printing
On Wed, 8 Mar 2017 16:46:57 +0100 Corentin Labbe wrote: > Printing copyright does not give any useful information on the boot > process. > Furthermore, the email address printed is obsolete since > commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries") > > Signed-off-by: Corentin Labbe > --- > drivers/net/tun.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index dc1b1dd..f58b7d8 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -2570,7 +2570,6 @@ static int __init tun_init(void) > int ret = 0; > > pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION); > - pr_info("%s\n", DRV_COPYRIGHT); > > ret = rtnl_link_register(_link_ops); > if (ret) { Why not just kill the pr_info() all together. It is just a vanity message.
[PATCH] tun: remove copyright printing
Printing copyright does not give any useful information on the boot process. Furthermore, the email address printed is obsolete since commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries") Signed-off-by: Corentin Labbe--- drivers/net/tun.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index dc1b1dd..f58b7d8 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2570,7 +2570,6 @@ static int __init tun_init(void) int ret = 0; pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION); - pr_info("%s\n", DRV_COPYRIGHT); ret = rtnl_link_register(_link_ops); if (ret) { -- 2.10.2
[PATCH] tun: remove copyright printing
Printing copyright does not give any useful information on the boot process. Furthermore, the email address printed is obsolete since commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries") Signed-off-by: Corentin Labbe --- drivers/net/tun.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index dc1b1dd..f58b7d8 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2570,7 +2570,6 @@ static int __init tun_init(void) int ret = 0; pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION); - pr_info("%s\n", DRV_COPYRIGHT); ret = rtnl_link_register(_link_ops); if (ret) { -- 2.10.2