Re: [PATCH 1/6] make pci_ids lowercase hexa

2007-06-18 Thread Jiri Slaby 
Greg KH napsal(a):
> On Sun, Jun 17, 2007 at 09:08:31AM +0200, Jiri Slaby wrote:
>> Greg KH napsal(a):
>>> Why?  What good is this going to do in the long run?
>> It's just cleanup to get rid of things like this:
>>  #define PCI_DEVICE_ID_PROMISE_20246 0x4d33
>>  #define PCI_DEVICE_ID_PROMISE_20262 0x4d38
>> -#define PCI_DEVICE_ID_PROMISE_20263 0x0D38
>> +#define PCI_DEVICE_ID_PROMISE_20263 0x0d38
>>  #define PCI_DEVICE_ID_PROMISE_20268 0x4d68
> 
> Get rid of what?  What's wrong with upper case hex numbers?  This seems
> like a pretty gratitous change to me.

Ok.

> Care to resend your other fixes to me, if you still think they are
> needed?

Sure.

regards,
-- 
http://www.fi.muni.cz/~xslaby/Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/6] make pci_ids lowercase hexa

2007-06-17 Thread Greg KH 
On Sun, Jun 17, 2007 at 09:08:31AM +0200, Jiri Slaby wrote:
> Greg KH napsal(a):
> > On Sat, Jun 16, 2007 at 05:44:52PM +0200, Jiri Slaby wrote:
> >> make pci_ids lowercase hexa
> > 
> > Why?  What good is this going to do in the long run?
> 
> It's just cleanup to get rid of things like this:
>  #define PCI_DEVICE_ID_PROMISE_20246  0x4d33
>  #define PCI_DEVICE_ID_PROMISE_20262  0x4d38
> -#define PCI_DEVICE_ID_PROMISE_20263  0x0D38
> +#define PCI_DEVICE_ID_PROMISE_20263  0x0d38
>  #define PCI_DEVICE_ID_PROMISE_20268  0x4d68

Get rid of what?  What's wrong with upper case hex numbers?  This seems
like a pretty gratitous change to me.

> But still not necessary, if you think, it's useless -- but why don't
> have whole document formatted in one way. However this patch needs a
> -fix if ACKed due to bad regexp used (omitted '*' changes only the
> first uppercase letter found). If NACKed, this doesn't matter.
> 
> > Also, shouldn't you send pci specific patches like this to the pci
> > maintainer?  :)
> 
> Hell yes :/, every second time I post something, somebody is missing
> in the CC list, grr.

Care to resend your other fixes to me, if you still think they are
needed?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/6] make pci_ids lowercase hexa

2007-06-17 Thread Jiri Slaby 
Greg KH napsal(a):
> On Sat, Jun 16, 2007 at 05:44:52PM +0200, Jiri Slaby wrote:
>> make pci_ids lowercase hexa
> 
> Why?  What good is this going to do in the long run?

It's just cleanup to get rid of things like this:
 #define PCI_DEVICE_ID_PROMISE_202460x4d33
 #define PCI_DEVICE_ID_PROMISE_202620x4d38
-#define PCI_DEVICE_ID_PROMISE_202630x0D38
+#define PCI_DEVICE_ID_PROMISE_202630x0d38
 #define PCI_DEVICE_ID_PROMISE_202680x4d68

But still not necessary, if you think, it's useless -- but why don't have whole
document formatted in one way. However this patch needs a -fix if ACKed due to
bad regexp used (omitted '*' changes only the first uppercase letter found). If
NACKed, this doesn't matter.

> Also, shouldn't you send pci specific patches like this to the pci
> maintainer?  :)

Hell yes :/, every second time I post something, somebody is missing in the CC
list, grr.

thanks,
--js
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/6] make pci_ids lowercase hexa

2007-06-16 Thread Greg KH 
On Sat, Jun 16, 2007 at 05:44:52PM +0200, Jiri Slaby wrote:
> make pci_ids lowercase hexa

Why?  What good is this going to do in the long run?

Also, shouldn't you send pci specific patches like this to the pci
maintainer?  :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/6] make pci_ids lowercase hexa

2007-06-16 Thread Jiri Slaby 
make pci_ids lowercase hexa

Make all ids in the document to be the same style.

Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>

---
commit 63c2460f837cabeeecc79026d668950d02b035c0
tree 72919579497e4fed0f02d3cba14f39a371ece7e2
parent 427d2812b00e5dcd2ed94c82fb7215f4d86b0530
author Jiri Slaby <[EMAIL PROTECTED]> Sat, 16 Jun 2007 17:05:47 +0200
committer Jiri Slaby <[EMAIL PROTECTED]> Sat, 16 Jun 2007 17:05:47 +0200

 include/linux/pci_ids.h |  222 ---
 1 files changed, 111 insertions(+), 111 deletions(-)

diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 24a5f46..2f1804c 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -196,11 +196,11 @@
 #define PCI_DEVICE_ID_LSI_63C815   0x1000
 #define PCI_DEVICE_ID_LSI_SAS1064  0x0050
 #define PCI_DEVICE_ID_LSI_SAS1064R 0x0411
-#define PCI_DEVICE_ID_LSI_SAS1066  0x005E
+#define PCI_DEVICE_ID_LSI_SAS1066  0x005e
 #define PCI_DEVICE_ID_LSI_SAS1068  0x0054
-#define PCI_DEVICE_ID_LSI_SAS1064A 0x005C
+#define PCI_DEVICE_ID_LSI_SAS1064A 0x005c
 #define PCI_DEVICE_ID_LSI_SAS1064E 0x0056
-#define PCI_DEVICE_ID_LSI_SAS1066E 0x005A
+#define PCI_DEVICE_ID_LSI_SAS1066E 0x005a
 #define PCI_DEVICE_ID_LSI_SAS1068E 0x0058
 #define PCI_DEVICE_ID_LSI_SAS1078  0x0060
 
@@ -221,14 +221,14 @@
 #define PCI_DEVICE_ID_ATI_215GTB   0x4755
 #define PCI_DEVICE_ID_ATI_215_IV   0x4756
 #define PCI_DEVICE_ID_ATI_215_IW   0x4757
-#define PCI_DEVICE_ID_ATI_215_IZ   0x475A
+#define PCI_DEVICE_ID_ATI_215_IZ   0x475a
 #define PCI_DEVICE_ID_ATI_210888GX 0x4758
 #define PCI_DEVICE_ID_ATI_215_LB   0x4c42
 #define PCI_DEVICE_ID_ATI_215_LD   0x4c44
 #define PCI_DEVICE_ID_ATI_215_LG   0x4c47
 #define PCI_DEVICE_ID_ATI_215_LI   0x4c49
-#define PCI_DEVICE_ID_ATI_215_LM   0x4c4D
-#define PCI_DEVICE_ID_ATI_215_LN   0x4c4E
+#define PCI_DEVICE_ID_ATI_215_LM   0x4c4d
+#define PCI_DEVICE_ID_ATI_215_LN   0x4c4e
 #define PCI_DEVICE_ID_ATI_215_LR   0x4c52
 #define PCI_DEVICE_ID_ATI_215_LS   0x4c53
 #define PCI_DEVICE_ID_ATI_264_LT   0x4c54
@@ -275,12 +275,12 @@
 #define PCI_DEVICE_ID_ATI_RAGE128_PG   0x5047
 #define PCI_DEVICE_ID_ATI_RAGE128_PH   0x5048
 #define PCI_DEVICE_ID_ATI_RAGE128_PI   0x5049
-#define PCI_DEVICE_ID_ATI_RAGE128_PJ   0x504A
-#define PCI_DEVICE_ID_ATI_RAGE128_PK   0x504B
-#define PCI_DEVICE_ID_ATI_RAGE128_PL   0x504C
-#define PCI_DEVICE_ID_ATI_RAGE128_PM   0x504D
-#define PCI_DEVICE_ID_ATI_RAGE128_PN   0x504E
-#define PCI_DEVICE_ID_ATI_RAGE128_PO   0x504F
+#define PCI_DEVICE_ID_ATI_RAGE128_PJ   0x504a
+#define PCI_DEVICE_ID_ATI_RAGE128_PK   0x504b
+#define PCI_DEVICE_ID_ATI_RAGE128_PL   0x504c
+#define PCI_DEVICE_ID_ATI_RAGE128_PM   0x504d
+#define PCI_DEVICE_ID_ATI_RAGE128_PN   0x504e
+#define PCI_DEVICE_ID_ATI_RAGE128_PO   0x504f
 #define PCI_DEVICE_ID_ATI_RAGE128_PP   0x5050
 #define PCI_DEVICE_ID_ATI_RAGE128_PQ   0x5051
 #define PCI_DEVICE_ID_ATI_RAGE128_PR   0x5052
@@ -431,8 +431,8 @@
 #define PCI_DEVICE_ID_DEC_TULIP0x0002
 #define PCI_DEVICE_ID_DEC_TGA  0x0004
 #define PCI_DEVICE_ID_DEC_TULIP_FAST   0x0009
-#define PCI_DEVICE_ID_DEC_TGA2 0x000D
-#define PCI_DEVICE_ID_DEC_FDDI 0x000F
+#define PCI_DEVICE_ID_DEC_TGA2 0x000d
+#define PCI_DEVICE_ID_DEC_FDDI 0x000f
 #define PCI_DEVICE_ID_DEC_TULIP_PLUS   0x0014
 #define PCI_DEVICE_ID_DEC_211420x0019
 #define PCI_DEVICE_ID_DEC_210520x0021
@@ -466,12 +466,12 @@
 #define PCI_DEVICE_ID_IBM_TR_WAKE  0x003e
 #define PCI_DEVICE_ID_IBM_CPC710_PCI64 0x00fc
 #define PCI_DEVICE_ID_IBM_SNIPE0x0180
-#define PCI_DEVICE_ID_IBM_CITRINE  0x028C
-#define PCI_DEVICE_ID_IBM_GEMSTONE 0xB166
-#define PCI_DEVICE_ID_IBM_OBSIDIAN 0x02BD
+#define PCI_DEVICE_ID_IBM_CITRINE  0x028c
+#define PCI_DEVICE_ID_IBM_GEMSTONE 0xb166
+#define PCI_DEVICE_ID_IBM_OBSIDIAN 0x02bD
 #define PCI_DEVICE_ID_IBM_ICOM_DEV_ID_10x0031
 #define PCI_DEVICE_ID_IBM_ICOM_DEV_ID_20x0219
-#define PCI_DEVICE_ID_IBM_ICOM_V2_TWO_PORTS_RVX0x021A
+#define PCI_DEVICE_ID_IBM_ICOM_V2_TWO_PORTS_RVX0x021a
 #define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM0x0251
 #define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM_PCIE 0x0361
 #define PCI_DEVICE_ID_IBM_ICOM_FOUR_PORT_MODEL 0x252
@@ -496,11 +496,11 @@
 #define PCI_DEVICE_ID_AMD_SERENADE 0x36c0
 #define PCI_DEVICE_ID_AMD_FE_GATE_7006 0x7006
 #define PCI_DEVICE_ID_AMD_FE_GATE_7007 0x7007
-#define PCI_DEVICE_ID_AMD_FE_GATE_700C 0x700C
-#define PCI_DEVICE_ID_AMD_FE_GATE_700E 0x700E
+#define PCI_DEVICE_ID_AMD_FE_GATE_700C 0x700c
+#define PCI_DEVICE_ID_AMD_FE_GATE_700E 0x700e
 #define PCI_DEVICE_ID_AMD_COBRA_7401   0x7401
 #define PCI_DEVICE_ID_AMD_VIPER_7409   0x7409
-#define PCI_DEVICE_ID_AMD_VIPER_740B   0x740B
+#define PCI