Re: [PATCH 2/2] dt: binding documentation for isp1704 charger

2013-11-15 Thread Mark Rutland 
On Thu, Nov 14, 2013 at 12:38:54PM +, Sebastian Reichel wrote:
> Add devicetree binding documentation for isp1704-charger.
> 
> Signed-off-by: Sebastian Reichel 
> ---
>  Documentation/devicetree/bindings/power/isp1704.txt | 17 +
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/isp1704.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/isp1704.txt 
> b/Documentation/devicetree/bindings/power/isp1704.txt
> new file mode 100644
> index 000..bbeec11
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/isp1704.txt
> @@ -0,0 +1,17 @@
> +Binding for NXP ISP1704 USB Charger Detection
> +
> +Required properties:
> +- compatible: Should contain one of the following:
> + * "nxp,isp1704"
> +- nxp,enable-gpio: Should contain a phandle to the

Nit: phandle + gpio-specifier

Otherwise this looks fine.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] dt: binding documentation for isp1704 charger

2013-11-15 Thread Mark Rutland 
On Thu, Nov 14, 2013 at 12:38:54PM +, Sebastian Reichel wrote:
 Add devicetree binding documentation for isp1704-charger.
 
 Signed-off-by: Sebastian Reichel s...@debian.org
 ---
  Documentation/devicetree/bindings/power/isp1704.txt | 17 +
  1 file changed, 17 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/power/isp1704.txt
 
 diff --git a/Documentation/devicetree/bindings/power/isp1704.txt 
 b/Documentation/devicetree/bindings/power/isp1704.txt
 new file mode 100644
 index 000..bbeec11
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/power/isp1704.txt
 @@ -0,0 +1,17 @@
 +Binding for NXP ISP1704 USB Charger Detection
 +
 +Required properties:
 +- compatible: Should contain one of the following:
 + * nxp,isp1704
 +- nxp,enable-gpio: Should contain a phandle to the

Nit: phandle + gpio-specifier

Otherwise this looks fine.

Mark.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] dt: binding documentation for isp1704 charger

2013-11-14 Thread Sebastian Reichel 
Add devicetree binding documentation for isp1704-charger.

Signed-off-by: Sebastian Reichel 
---
 Documentation/devicetree/bindings/power/isp1704.txt | 17 +
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/isp1704.txt

diff --git a/Documentation/devicetree/bindings/power/isp1704.txt 
b/Documentation/devicetree/bindings/power/isp1704.txt
new file mode 100644
index 000..bbeec11
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/isp1704.txt
@@ -0,0 +1,17 @@
+Binding for NXP ISP1704 USB Charger Detection
+
+Required properties:
+- compatible: Should contain one of the following:
+ * "nxp,isp1704"
+- nxp,enable-gpio: Should contain a phandle to the
+  GPIO pin connected to the chip's enable pin.
+- usb-phy: Should contain a phandle to the USB PHY
+  the ISP1704 is connected to.
+
+Example:
+
+isp1704 {
+   compatible = "nxp,isp1704";
+   nxp,enable-gpio = < 3 GPIO_ACTIVE_LOW>;
+   usb-phy = <_phy>;
+};
-- 
1.8.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] dt: binding documentation for isp1704 charger

2013-11-14 Thread Sebastian Reichel 
Add devicetree binding documentation for isp1704-charger.

Signed-off-by: Sebastian Reichel s...@debian.org
---
 Documentation/devicetree/bindings/power/isp1704.txt | 17 +
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/isp1704.txt

diff --git a/Documentation/devicetree/bindings/power/isp1704.txt 
b/Documentation/devicetree/bindings/power/isp1704.txt
new file mode 100644
index 000..bbeec11
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/isp1704.txt
@@ -0,0 +1,17 @@
+Binding for NXP ISP1704 USB Charger Detection
+
+Required properties:
+- compatible: Should contain one of the following:
+ * nxp,isp1704
+- nxp,enable-gpio: Should contain a phandle to the
+  GPIO pin connected to the chip's enable pin.
+- usb-phy: Should contain a phandle to the USB PHY
+  the ISP1704 is connected to.
+
+Example:
+
+isp1704 {
+   compatible = nxp,isp1704;
+   nxp,enable-gpio = gpio3 3 GPIO_ACTIVE_LOW;
+   usb-phy = usb2_phy;
+};
-- 
1.8.4.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/