Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
> I hope you had information you wanted from Julia ? Yes. - I am waiting on another Coccinelle software release which will contain improvements for my feature requests and bug reports. I'm curious when I should retry proposed filter patterns. Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html >> http://marc.info/?l=kernel-janitors=139405971927100=2 > Regular expressions do not allow taking advantage of the optimizations > provided by Coccinelle and are not easy for a reader to understand. I find that the application of regexes is appropriate here. Would you like to optimise any implementation details from my general approach? >> https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html >> http://marc.info/?l=kernel-janitors=139405983727148=2 > This is not safe due to the use of when any. You have no guarantee that > there is not a dereference of input in the matched region, or that the > value of input is still the argument value at the point of the test. Do you suggest to make the desired detection of input parameter validation a bit safer? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014 23:00:22 +0200 SF Markus Elfring wrote: > > Sorry but I'm not working on coccinelle ; just did a small script for > > kernel tree. > > I would appreciate a more constructive feedback for my update suggestions > around > the topic "Deletion of unnecessary checks before specific function calls". > - Did you look at the concrete patches? > - How do you think about the general approach? > > Examples: > https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html > http://marc.info/?l=kernel-janitors=139405971927100=2 > > https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html > http://marc.info/?l=kernel-janitors=139405983727148=2 > > Regards, > Markus Hello Markus, I hope you had information you wanted from Julia ? If you want more feedback, maybe you can create a new RFC (Request For Comment) in Linux Kernel mailing. Regards, Fabian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014 23:00:22 +0200 SF Markus Elfring elfr...@users.sourceforge.net wrote: Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I would appreciate a more constructive feedback for my update suggestions around the topic Deletion of unnecessary checks before specific function calls. - Did you look at the concrete patches? - How do you think about the general approach? Examples: https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html http://marc.info/?l=kernel-janitorsm=139405971927100w=2 https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html http://marc.info/?l=kernel-janitorsm=139405983727148w=2 Regards, Markus Hello Markus, I hope you had information you wanted from Julia ? If you want more feedback, maybe you can create a new RFC (Request For Comment) in Linux Kernel mailing. Regards, Fabian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html http://marc.info/?l=kernel-janitorsm=139405971927100w=2 Regular expressions do not allow taking advantage of the optimizations provided by Coccinelle and are not easy for a reader to understand. I find that the application of regexes is appropriate here. Would you like to optimise any implementation details from my general approach? https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html http://marc.info/?l=kernel-janitorsm=139405983727148w=2 This is not safe due to the use of when any. You have no guarantee that there is not a dereference of input in the matched region, or that the value of input is still the argument value at the point of the test. Do you suggest to make the desired detection of input parameter validation a bit safer? Regards, Markus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
I hope you had information you wanted from Julia ? Yes. - I am waiting on another Coccinelle software release which will contain improvements for my feature requests and bug reports. I'm curious when I should retry proposed filter patterns. Regards, Markus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014, SF Markus Elfring wrote: > > Sorry but I'm not working on coccinelle ; just did a small script for > > kernel tree. > > I would appreciate a more constructive feedback for my update suggestions > around > the topic "Deletion of unnecessary checks before specific function calls". > - Did you look at the concrete patches? > - How do you think about the general approach? > > Examples: > https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html > http://marc.info/?l=kernel-janitors=139405971927100=2 Regular expressions do not allow taking advantage of the optimizations provided by Coccinelle and are not easy for a reader to understand. > https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html > http://marc.info/?l=kernel-janitors=139405983727148=2 This is not safe due to the use of when any. You have no guarantee that there is not a dereference of input in the matched region, or that the value of input is still the argument value at the point of the test. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
> Sorry but I'm not working on coccinelle ; just did a small script for kernel > tree. I would appreciate a more constructive feedback for my update suggestions around the topic "Deletion of unnecessary checks before specific function calls". - Did you look at the concrete patches? - How do you think about the general approach? Examples: https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html http://marc.info/?l=kernel-janitors=139405971927100=2 https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html http://marc.info/?l=kernel-janitors=139405983727148=2 Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014, SF Markus Elfring wrote: > > > V3: > >-Update print_main message. > > Does the discussion topic need also an adjustment? > > How do you think about my previous update suggestion "Deletion of > unnecessary checks before specific function calls"? > https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html > https://lkml.org/lkml/2014/3/5/344 I would prefer to accept Fabian's semantic patch for the moment, as it considers a more restricted, well thought out, set of functions, julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014 13:38:15 +0200 SF Markus Elfring wrote: > > >> How do you think about my previous update suggestion "Deletion of > >> unnecessary checks before specific function calls"? > >> https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html > >> https://lkml.org/lkml/2014/3/5/344 > > I didn't see you made the same kind of script. > > Will my approach become a bit more complete in the near future? > http://article.gmane.org/gmane.comp.version-control.coccinelle/3512/ > Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I guess you'll have an answer from coccinelle people. Regards, Fabian > Regards, > Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
>> How do you think about my previous update suggestion "Deletion of >> unnecessary checks before specific function calls"? >> https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html >> https://lkml.org/lkml/2014/3/5/344 > I didn't see you made the same kind of script. Will my approach become a bit more complete in the near future? http://article.gmane.org/gmane.comp.version-control.coccinelle/3512/ Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014 11:08:35 +0200 SF Markus Elfring wrote: > > > V3: > >-Update print_main message. > > Does the discussion topic need also an adjustment? > > How do you think about my previous update suggestion "Deletion of > unnecessary checks before specific function calls"? > https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html > https://lkml.org/lkml/2014/3/5/344 Hello Markus, I didn't see you made the same kind of script. Ok, you can send yours and we forget this one :) Regards, Fabian > > Regards, > Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
> V3: >-Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion "Deletion of unnecessary checks before specific function calls"? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html https://lkml.org/lkml/2014/3/5/344 Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
V3: -Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html https://lkml.org/lkml/2014/3/5/344 Regards, Markus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014 11:08:35 +0200 SF Markus Elfring elfr...@users.sourceforge.net wrote: V3: -Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html https://lkml.org/lkml/2014/3/5/344 Hello Markus, I didn't see you made the same kind of script. Ok, you can send yours and we forget this one :) Regards, Fabian Regards, Markus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html https://lkml.org/lkml/2014/3/5/344 I didn't see you made the same kind of script. Will my approach become a bit more complete in the near future? http://article.gmane.org/gmane.comp.version-control.coccinelle/3512/ Regards, Markus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014 13:38:15 +0200 SF Markus Elfring elfr...@users.sourceforge.net wrote: How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html https://lkml.org/lkml/2014/3/5/344 I didn't see you made the same kind of script. Will my approach become a bit more complete in the near future? http://article.gmane.org/gmane.comp.version-control.coccinelle/3512/ Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I guess you'll have an answer from coccinelle people. Regards, Fabian Regards, Markus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014, SF Markus Elfring wrote: V3: -Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html https://lkml.org/lkml/2014/3/5/344 I would prefer to accept Fabian's semantic patch for the moment, as it considers a more restricted, well thought out, set of functions, julia -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I would appreciate a more constructive feedback for my update suggestions around the topic Deletion of unnecessary checks before specific function calls. - Did you look at the concrete patches? - How do you think about the general approach? Examples: https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html http://marc.info/?l=kernel-janitorsm=139405971927100w=2 https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html http://marc.info/?l=kernel-janitorsm=139405983727148w=2 Regards, Markus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
On Sat, 28 Jun 2014, SF Markus Elfring wrote: Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I would appreciate a more constructive feedback for my update suggestions around the topic Deletion of unnecessary checks before specific function calls. - Did you look at the concrete patches? - How do you think about the general approach? Examples: https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html http://marc.info/?l=kernel-janitorsm=139405971927100w=2 Regular expressions do not allow taking advantage of the optimizations provided by Coccinelle and are not easy for a reader to understand. https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html http://marc.info/?l=kernel-janitorsm=139405983727148w=2 This is not safe due to the use of when any. You have no guarantee that there is not a dereference of input in the matched region, or that the value of input is still the argument value at the point of the test. julia -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
