Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log

[Hui Tang]

On 2021/4/9 15:33, Herbert Xu wrote:

On Fri, Apr 02, 2021 at 07:24:29PM +0800, Hui Tang wrote:

'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
necessary to do it here, so remove it.

Signed-off-by: Hui Tang 

v1 -> v2:
- Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero.
---
 drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Your patch description is misleading as the patch does moe than
just remove the redundant printk.  Please rephrase so that it is
clear that the patch is in fact changing behaviour.


Okay, I will fix it in next version.

Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log

[Herbert Xu]

On Fri, Apr 02, 2021 at 07:24:29PM +0800, Hui Tang wrote:
> 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
> necessary to do it here, so remove it.
> 
> Signed-off-by: Hui Tang 
> 
> v1 -> v2:
> - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero.
> ---
>  drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Your patch description is misleading as the patch does moe than
just remove the redundant printk.  Please rephrase so that it is
clear that the patch is in fact changing behaviour.

Thanks,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH v2] crypto: hisilicon/hpre - delete redundant log

[Hui Tang]

'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
necessary to do it here, so remove it.

Signed-off-by: Hui Tang 

v1 -> v2:
- Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero.
---
 drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c 
b/drivers/crypto/hisilicon/hpre/hpre_main.c
index c7ab06d..fa40835 100644
--- a/drivers/crypto/hisilicon/hpre/hpre_main.c
+++ b/drivers/crypto/hisilicon/hpre/hpre_main.c
@@ -386,7 +386,7 @@ static int hpre_set_user_domain_and_cache(struct hisi_qm 
*qm)
if (qm->ver == QM_HW_V2) {
ret = hpre_cfg_by_dsm(qm);
if (ret)
-   dev_err(dev, "acpi_evaluate_dsm err.\n");
+   return ret;
 
disable_flr_of_bme(qm);
}
-- 
2.8.1