Re: PATCH 2.4.0.9.4: Fix Cardbus
On Wed, 20 Sep 2000 10:22:50 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote: >Dag Bakke wrote: >> ROM image dump: >> cs: no valid ROM images found! >> >> Same problem, or different problem? This time, the card is not even >> detected... > >Look around for patches from Keith Owens relating to this, and the >xircom_tulip_cb driver. It needs a ROM image mapping into the address >space, which is normally not done without the special "pci=rom" setting >on the kernel command line. Keith's patch, IIRC, temporary does a >mapping in order to get the necessary information from the ROM image. You must be thinking of my one line patch to pcibios_update_resource, adding new |= PCI_ROM_ADDRESS_ENABLE; But that patch was included in 2.4.0-test2-pre1. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: PATCH 2.4.0.9.4: Fix Cardbus
Dag Bakke wrote: > > Jeff Garzik wrote: > > > Ok, it's time to get test9 running on my laptop, so I played the "what > > code didn't get cut-n-pasted" game. > > > > With the attached tested patch against 2.4.0-test9-pre4, CardBus is > > working again for me. This patch makes the logic match that of the old > > code. > > Well. > Still doesn't work for me. So I tested 2.2.17 and pcmcia-cs 3.1.20. > > # lsmod > Module Size Used by > tulip_cb 32092 0 (unused) > cb_enabler 2504 1 [tulip_cb] [...] > cs: cb_alloc(bus 35): vendor 0x115d, device 0x0003 > > [/etc/init.d/pcmcia start] > cs: IO port probe 0x0c00-0x0cff: clean. > cs: IO port probe 0x0800-0x08ff: clean. > cs: IO port probe 0x0100-0x04ff: clean. > cs: IO port probe 0x0a00-0x0aff: clean. > ROM image dump: > cs: no valid ROM images found! > > Same problem, or different problem? This time, the card is not even > detected... Look around for patches from Keith Owens relating to this, and the xircom_tulip_cb driver. It needs a ROM image mapping into the address space, which is normally not done without the special "pci=rom" setting on the kernel command line. Keith's patch, IIRC, temporary does a mapping in order to get the necessary information from the ROM image. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: PATCH 2.4.0.9.4: Fix Cardbus
On Wed, 20 Sep 2000, Jeff Garzik wrote: > Ok, it's time to get test9 running on my laptop, so I played the "what > code didn't get cut-n-pasted" game. > > With the attached tested patch against 2.4.0-test9-pre4, CardBus is > working again for me. This patch makes the logic match that of the old > code. Good stuff - it fixes the problem for me. I still don't understand the fix but that doesn't matter :) your fix looks much nicer than my blind guess! Thanks, Tigran - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: PATCH 2.4.0.9.4: Fix Cardbus
Jeff Garzik wrote: > Ok, it's time to get test9 running on my laptop, so I played the "what > code didn't get cut-n-pasted" game. > > With the attached tested patch against 2.4.0-test9-pre4, CardBus is > working again for me. This patch makes the logic match that of the old > code. Well. Still doesn't work for me. So I tested 2.2.17 and pcmcia-cs 3.1.20. # lsmod Module Size Used by tulip_cb 32092 0 (unused) cb_enabler 2504 1 [tulip_cb] ds 6440 2 [cb_enabler] i82365 22420 2 pcmcia_core50912 0 [cb_enabler ds i82365] [These are the correct modules, right? Loaded by hand, as 'make install' in pcmcia-cs appears to be a little confused by the latest kernel module reorg.] # dmesg [snip] Linux PCMCIA Card Services 3.1.20 kernel build: 2.2.17 #1 Wed Sep 20 09:32:23 CEST 2000 options: [pci] [cardbus] [apm] [pnp] PCI routing table version 1.0 at 0xfbda0 00:03.0 -> irq 11 00:03.1 -> irq 11 PnP: PNP BIOS installation structure at 0xc00fe2d0 PnP: PNP BIOS version 1.0, entry at f:e2f4, dseg at 40 Intel PCIC probe: TI 1225 rev 01 PCI-to-CardBus at slot 00:03, mem 0x6800 host opts [0]: [ring] [serial pci & irq] [pci irq 11] [lat 32/32] [bus 32/34] host opts [1]: [ring] [serial pci & irq] [pci irq 11] [lat 32/32] [bus 35/37] ISA irqs (scanned) = 3,7,9,10 PCI status changes cs: cb_alloc(bus 35): vendor 0x115d, device 0x0003 [/etc/init.d/pcmcia start] cs: IO port probe 0x0c00-0x0cff: clean. cs: IO port probe 0x0800-0x08ff: clean. cs: IO port probe 0x0100-0x04ff: clean. cs: IO port probe 0x0a00-0x0aff: clean. ROM image dump: cs: no valid ROM images found! Same problem, or different problem? This time, the card is not even detected... Dag B - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: PATCH 2.4.0.9.4: Fix Cardbus
Jeff Garzik writes: > Ok, it's time to get test9 running on my laptop, so I played the "what > code didn't get cut-n-pasted" game. > > With the attached tested patch against 2.4.0-test9-pre4, CardBus is > working again for me. This patch makes the logic match that of the > old code. What patch? Regards, Richard Permanent: [EMAIL PROTECTED] Current: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
PATCH 2.4.0.9.4: Fix Cardbus
Ok, it's time to get test9 running on my laptop, so I played the "what code didn't get cut-n-pasted" game. With the attached tested patch against 2.4.0-test9-pre4, CardBus is working again for me. This patch makes the logic match that of the old code. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: PATCH 2.4.0.9.4: Fix Cardbus
Jeff Garzik wrote: > With the attached tested patch against 2.4.0-test9-pre4, CardBus is > working again for me. This patch makes the logic match that of the old > code. -ENOSLEEP. Here is the patch. Index: drivers/pci/pci.c === RCS file: /g/cvslan/linux_2_3/drivers/pci/pci.c,v retrieving revision 1.1.1.30 diff -u -r1.1.1.30 pci.c --- drivers/pci/pci.c 2000/09/17 19:44:33 1.1.1.30 +++ drivers/pci/pci.c 2000/09/20 04:45:26 @@ -693,6 +693,10 @@ if (!is_cardbus) { unsigned int cmax = pci_do_scan_bus(child); if (cmax > max) max = cmax; + } else { + int i; + for (i = 0; i < 4; i++) + child->resource[i] = +&dev->resource[PCI_BRIDGE_RESOURCES+i]; } } else { /* @@ -718,12 +722,15 @@ /* Now we can scan all subordinate buses... */ max = pci_do_scan_bus(child); } else { + int i; /* * For CardBus bridges, we leave 4 bus numbers * as cards with a PCI-to-PCI bridge can be * inserted later. */ max += 3; + for (i = 0; i < 4; i++) + child->resource[i] = +&dev->resource[PCI_BRIDGE_RESOURCES+i]; } /* * Set the subordinate bus number to its real value.