Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC by default

2020-09-15 Thread Krzysztof Kozlowski 
On Wed, 16 Sep 2020 at 03:59, Anson Huang  wrote:
>
> Hi, Krzysztof
>
> > Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in
> > CONFIG_GPIO_MXC by default
> >
> > On Mon, 14 Sep 2020 at 05:36, Anson Huang 
> > wrote:
> > >
> > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as
> > > built-in manually.
> >
> > Maybe it should stay not enabled? Please explain in commit msg why it should
> > be enabled.
>
> The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the 
> basic
> function of GPIO pin operations and IRQ operations, it is enabled by default 
> previously
> with " def_bool y " in Kconfig, now it is changed to tristate, so it should 
> be explicitly
> enabled in defconfig to make sure it does NOT break any existing functions, 
> that is
> why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC 
> as
> built-in manually " in commit msg, it aims to NOT change any previous 
> behaviors.

Sure, I was just saying that all this should be in commit msg. The
commit should explain why it is there in the Linux kernel.

Best regards,
Krzysztof

RE: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC by default

2020-09-15 Thread Anson Huang 
Hi, Krzysztof

> Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in
> CONFIG_GPIO_MXC by default
> 
> On Mon, 14 Sep 2020 at 05:36, Anson Huang 
> wrote:
> >
> > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as
> > built-in manually.
> 
> Maybe it should stay not enabled? Please explain in commit msg why it should
> be enabled.

The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the basic
function of GPIO pin operations and IRQ operations, it is enabled by default 
previously
with " def_bool y " in Kconfig, now it is changed to tristate, so it should be 
explicitly
enabled in defconfig to make sure it does NOT break any existing functions, 
that is
why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as 
built-in manually " in commit msg, it aims to NOT change any previous behaviors.

thanks,
Anson

Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC by default

2020-09-15 Thread Krzysztof Kozlowski 
On Mon, 14 Sep 2020 at 05:36, Anson Huang  wrote:
>
> i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC
> as built-in manually.

Maybe it should stay not enabled? Please explain in commit msg why it
should be enabled.

Best regards,
Krzysztof