Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation
On Tue, 10 Jan 2017 08:48:09 + Punnaiah Choudary Kalluri wrote: > Hi Boris, > > Thanks. I will implement these changes and send the next series. Please wait a bit. I still need to review the driver. > > Regards, > Punnaiah > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@free-electrons.com] > > Sent: Tuesday, January 10, 2017 1:36 PM > > To: Punnaiah Choudary Kalluri > > Cc: Rob Herring ; dw...@infradead.org; > > computersforpe...@gmail.com; marek.va...@gmail.com; rich...@nod.at; > > cyrille.pitc...@atmel.com; mark.rutl...@arm.com; linux- > > ker...@vger.kernel.org; linux-...@lists.infradead.org; > > devicet...@vger.kernel.org; Michal Simek ; > > kalluripunnaiahchoud...@gmail.com; kpc...@gmail.com > > Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding > > documentation > > > > Hi Punnaiah, > > > > On Tue, 10 Jan 2017 06:03:25 + > > Punnaiah Choudary Kalluri wrote: > > > > > Hi Rob, > > > > > >Thanks for the review. > > > > > > > -Original Message- > > > > From: Rob Herring [mailto:r...@kernel.org] > > > > Sent: Tuesday, January 10, 2017 11:06 AM > > > > To: Punnaiah Choudary Kalluri > > > > Cc: dw...@infradead.org; computersforpe...@gmail.com; > > > > boris.brezil...@free-electrons.com; marek.va...@gmail.com; > > > > rich...@nod.at; cyrille.pitc...@atmel.com; mark.rutl...@arm.com; > > linux- > > > > ker...@vger.kernel.org; linux-...@lists.infradead.org; > > > > devicet...@vger.kernel.org; Michal Simek ; > > > > kalluripunnaiahchoud...@gmail.com; kpc...@gmail.com; Punnaiah > > > > Choudary Kalluri > > > > Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding > > > > documentation > > > > > > > > On Mon, Jan 09, 2017 at 08:28:53AM +0530, Punnaiah Choudary Kalluri > > wrote: > > > > > This patch adds the dts binding document for arasan nand flash > > > > > controller. > > > > > > > > > > Signed-off-by: Punnaiah Choudary Kalluri > > > > > --- > > > > > Changes in v7: > > > > > - Corrected the acronyms those should be in caps > > > > > changes in v6: > > > > > - Removed num-cs property > > > > > - Separated nandchip from nand controller > > > > > changes in v5: > > > > > - None > > > > > Changes in v4: > > > > > - Added num-cs property > > > > > - Added clock support > > > > > Changes in v3: > > > > > - None > > > > > Changes in v2: > > > > > - None > > > > > --- > > > > > .../devicetree/bindings/mtd/arasan_nfc.txt | 38 > > > > ++ > > > > > 1 file changed, 38 insertions(+) > > > > > create mode 100644 > > > > Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > > new file mode 100644 > > > > > index 000..f20adfc > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > > @@ -0,0 +1,38 @@ > > > > > +Arasan NAND Flash Controller with ONFI 3.1 support > > > > > + > > > > > +Required properties: > > > > > +- compatible: Should be "arasan,nfc-v3p10" > > > > > > > > Needs a note that it must also have an SoC specific compatible string. > > > > > > > Sorry, I couldn't understand this comment. Could you elaborate it? > > > > Arasan is an IP vendor, and those IPs are usually embedded in specific > > SoCs. I guess Rob was suggesting to define something like: > > > > compatible = ",", "arasan,"; > > > > This way you can differentiate minor changes/tweaks between each SoC > > (each SoC vendor usually enable/disable specific features based on > > their needs). > > > > > > > > > > +- reg: Memory map for module access > > > > > +- interrupt-parent: Interrupt controller the interrupt is routed > > > > > through > > > > > +- interrupts: Should contain the interrupt for the device > > > > > +- clock-name: List of input clocks - "clk_sys", "clk_flash" > > > > > > > > clk_ is redundant. > > > > > > > > > > I have defined these clock names as per the controller data sheet. > > > So, I feel it is fine to have them in sync with the datasheet. > > > Please let me know if you still want me to change this. > > > > We already know this is a clock, hence the unneeded clk_ prefix. Please > > drop it. > > > > Thanks, > > > > Boris
RE: [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation
Hi Boris, Thanks. I will implement these changes and send the next series. Regards, Punnaiah > -Original Message- > From: Boris Brezillon [mailto:boris.brezil...@free-electrons.com] > Sent: Tuesday, January 10, 2017 1:36 PM > To: Punnaiah Choudary Kalluri > Cc: Rob Herring ; dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com; rich...@nod.at; > cyrille.pitc...@atmel.com; mark.rutl...@arm.com; linux- > ker...@vger.kernel.org; linux-...@lists.infradead.org; > devicet...@vger.kernel.org; Michal Simek ; > kalluripunnaiahchoud...@gmail.com; kpc...@gmail.com > Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding > documentation > > Hi Punnaiah, > > On Tue, 10 Jan 2017 06:03:25 + > Punnaiah Choudary Kalluri wrote: > > > Hi Rob, > > > >Thanks for the review. > > > > > -Original Message- > > > From: Rob Herring [mailto:r...@kernel.org] > > > Sent: Tuesday, January 10, 2017 11:06 AM > > > To: Punnaiah Choudary Kalluri > > > Cc: dw...@infradead.org; computersforpe...@gmail.com; > > > boris.brezil...@free-electrons.com; marek.va...@gmail.com; > > > rich...@nod.at; cyrille.pitc...@atmel.com; mark.rutl...@arm.com; > linux- > > > ker...@vger.kernel.org; linux-...@lists.infradead.org; > > > devicet...@vger.kernel.org; Michal Simek ; > > > kalluripunnaiahchoud...@gmail.com; kpc...@gmail.com; Punnaiah > > > Choudary Kalluri > > > Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding > > > documentation > > > > > > On Mon, Jan 09, 2017 at 08:28:53AM +0530, Punnaiah Choudary Kalluri > wrote: > > > > This patch adds the dts binding document for arasan nand flash > > > > controller. > > > > > > > > Signed-off-by: Punnaiah Choudary Kalluri > > > > --- > > > > Changes in v7: > > > > - Corrected the acronyms those should be in caps > > > > changes in v6: > > > > - Removed num-cs property > > > > - Separated nandchip from nand controller > > > > changes in v5: > > > > - None > > > > Changes in v4: > > > > - Added num-cs property > > > > - Added clock support > > > > Changes in v3: > > > > - None > > > > Changes in v2: > > > > - None > > > > --- > > > > .../devicetree/bindings/mtd/arasan_nfc.txt | 38 > > > ++ > > > > 1 file changed, 38 insertions(+) > > > > create mode 100644 > > > Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > new file mode 100644 > > > > index 000..f20adfc > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > @@ -0,0 +1,38 @@ > > > > +Arasan NAND Flash Controller with ONFI 3.1 support > > > > + > > > > +Required properties: > > > > +- compatible: Should be "arasan,nfc-v3p10" > > > > > > Needs a note that it must also have an SoC specific compatible string. > > > > > Sorry, I couldn't understand this comment. Could you elaborate it? > > Arasan is an IP vendor, and those IPs are usually embedded in specific > SoCs. I guess Rob was suggesting to define something like: > > compatible = ",", "arasan,"; > > This way you can differentiate minor changes/tweaks between each SoC > (each SoC vendor usually enable/disable specific features based on > their needs). > > > > > > > +- reg: Memory map for module access > > > > +- interrupt-parent: Interrupt controller the interrupt is routed > > > > through > > > > +- interrupts: Should contain the interrupt for the device > > > > +- clock-name: List of input clocks - "clk_sys", "clk_flash" > > > > > > clk_ is redundant. > > > > > > > I have defined these clock names as per the controller data sheet. > > So, I feel it is fine to have them in sync with the datasheet. > > Please let me know if you still want me to change this. > > We already know this is a clock, hence the unneeded clk_ prefix. Please > drop it. > > Thanks, > > Boris
Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation
Hi Punnaiah, On Tue, 10 Jan 2017 06:03:25 + Punnaiah Choudary Kalluri wrote: > Hi Rob, > >Thanks for the review. > > > -Original Message- > > From: Rob Herring [mailto:r...@kernel.org] > > Sent: Tuesday, January 10, 2017 11:06 AM > > To: Punnaiah Choudary Kalluri > > Cc: dw...@infradead.org; computersforpe...@gmail.com; > > boris.brezil...@free-electrons.com; marek.va...@gmail.com; > > rich...@nod.at; cyrille.pitc...@atmel.com; mark.rutl...@arm.com; linux- > > ker...@vger.kernel.org; linux-...@lists.infradead.org; > > devicet...@vger.kernel.org; Michal Simek ; > > kalluripunnaiahchoud...@gmail.com; kpc...@gmail.com; Punnaiah > > Choudary Kalluri > > Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding > > documentation > > > > On Mon, Jan 09, 2017 at 08:28:53AM +0530, Punnaiah Choudary Kalluri wrote: > > > This patch adds the dts binding document for arasan nand flash > > > controller. > > > > > > Signed-off-by: Punnaiah Choudary Kalluri > > > --- > > > Changes in v7: > > > - Corrected the acronyms those should be in caps > > > changes in v6: > > > - Removed num-cs property > > > - Separated nandchip from nand controller > > > changes in v5: > > > - None > > > Changes in v4: > > > - Added num-cs property > > > - Added clock support > > > Changes in v3: > > > - None > > > Changes in v2: > > > - None > > > --- > > > .../devicetree/bindings/mtd/arasan_nfc.txt | 38 > > ++ > > > 1 file changed, 38 insertions(+) > > > create mode 100644 > > Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > new file mode 100644 > > > index 000..f20adfc > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > @@ -0,0 +1,38 @@ > > > +Arasan NAND Flash Controller with ONFI 3.1 support > > > + > > > +Required properties: > > > +- compatible: Should be "arasan,nfc-v3p10" > > > > Needs a note that it must also have an SoC specific compatible string. > > > Sorry, I couldn't understand this comment. Could you elaborate it? Arasan is an IP vendor, and those IPs are usually embedded in specific SoCs. I guess Rob was suggesting to define something like: compatible = ",", "arasan,"; This way you can differentiate minor changes/tweaks between each SoC (each SoC vendor usually enable/disable specific features based on their needs). > > > > +- reg: Memory map for module access > > > +- interrupt-parent: Interrupt controller the interrupt is routed through > > > +- interrupts: Should contain the interrupt for the device > > > +- clock-name: List of input clocks - "clk_sys", "clk_flash" > > > > clk_ is redundant. > > > > I have defined these clock names as per the controller data sheet. > So, I feel it is fine to have them in sync with the datasheet. > Please let me know if you still want me to change this. We already know this is a clock, hence the unneeded clk_ prefix. Please drop it. Thanks, Boris
RE: [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation
Hi Rob, Thanks for the review. > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, January 10, 2017 11:06 AM > To: Punnaiah Choudary Kalluri > Cc: dw...@infradead.org; computersforpe...@gmail.com; > boris.brezil...@free-electrons.com; marek.va...@gmail.com; > rich...@nod.at; cyrille.pitc...@atmel.com; mark.rutl...@arm.com; linux- > ker...@vger.kernel.org; linux-...@lists.infradead.org; > devicet...@vger.kernel.org; Michal Simek ; > kalluripunnaiahchoud...@gmail.com; kpc...@gmail.com; Punnaiah > Choudary Kalluri > Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding > documentation > > On Mon, Jan 09, 2017 at 08:28:53AM +0530, Punnaiah Choudary Kalluri wrote: > > This patch adds the dts binding document for arasan nand flash > > controller. > > > > Signed-off-by: Punnaiah Choudary Kalluri > > --- > > Changes in v7: > > - Corrected the acronyms those should be in caps > > changes in v6: > > - Removed num-cs property > > - Separated nandchip from nand controller > > changes in v5: > > - None > > Changes in v4: > > - Added num-cs property > > - Added clock support > > Changes in v3: > > - None > > Changes in v2: > > - None > > --- > > .../devicetree/bindings/mtd/arasan_nfc.txt | 38 > ++ > > 1 file changed, 38 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > new file mode 100644 > > index 000..f20adfc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > @@ -0,0 +1,38 @@ > > +Arasan NAND Flash Controller with ONFI 3.1 support > > + > > +Required properties: > > +- compatible: Should be "arasan,nfc-v3p10" > > Needs a note that it must also have an SoC specific compatible string. > Sorry, I couldn't understand this comment. Could you elaborate it? > > +- reg: Memory map for module access > > +- interrupt-parent: Interrupt controller the interrupt is routed through > > +- interrupts: Should contain the interrupt for the device > > +- clock-name: List of input clocks - "clk_sys", "clk_flash" > > clk_ is redundant. > I have defined these clock names as per the controller data sheet. So, I feel it is fine to have them in sync with the datasheet. Please let me know if you still want me to change this. Regards, Punnaiah > > + (See clock bindings for details) > > +- clocks: Clock phandles (see clock bindings for details) > > + > > +Optional properties: > > +- arasan,has-mdma: Enables DMA support > > + > > +For NAND partition information please refer the below file > > +Documentation/devicetree/bindings/mtd/partition.txt > > + > > +Example: > > + nand0: nand@ff10 { > > + compatible = "arasan,nfc-v3p10" > > + reg = <0x0 0xff10 0x1000>; > > + clock-name = "clk_sys", "clk_flash" > > + clocks = <&misc_clk &misc_clk>; > > + interrupt-parent = <&gic>; > > + interrupts = <0 14 4>; > > + arasan,has-mdma; > > + #address-cells = <1>; > > + #size-cells = <0> > > + > > + nand@0 { > > + reg = <0> > > + partition@0 { > > + label = "filesystem"; > > + reg = <0x0 0x0 0x100>; > > + }; > > + (...) > > + }; > > + }; > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation
On Mon, Jan 09, 2017 at 08:28:53AM +0530, Punnaiah Choudary Kalluri wrote: > This patch adds the dts binding document for arasan nand flash > controller. > > Signed-off-by: Punnaiah Choudary Kalluri > --- > Changes in v7: > - Corrected the acronyms those should be in caps > changes in v6: > - Removed num-cs property > - Separated nandchip from nand controller > changes in v5: > - None > Changes in v4: > - Added num-cs property > - Added clock support > Changes in v3: > - None > Changes in v2: > - None > --- > .../devicetree/bindings/mtd/arasan_nfc.txt | 38 > ++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > new file mode 100644 > index 000..f20adfc > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > @@ -0,0 +1,38 @@ > +Arasan NAND Flash Controller with ONFI 3.1 support > + > +Required properties: > +- compatible: Should be "arasan,nfc-v3p10" Needs a note that it must also have an SoC specific compatible string. > +- reg: Memory map for module access > +- interrupt-parent: Interrupt controller the interrupt is routed through > +- interrupts: Should contain the interrupt for the device > +- clock-name: List of input clocks - "clk_sys", "clk_flash" clk_ is redundant. > + (See clock bindings for details) > +- clocks: Clock phandles (see clock bindings for details) > + > +Optional properties: > +- arasan,has-mdma: Enables DMA support > + > +For NAND partition information please refer the below file > +Documentation/devicetree/bindings/mtd/partition.txt > + > +Example: > + nand0: nand@ff10 { > + compatible = "arasan,nfc-v3p10" > + reg = <0x0 0xff10 0x1000>; > + clock-name = "clk_sys", "clk_flash" > + clocks = <&misc_clk &misc_clk>; > + interrupt-parent = <&gic>; > + interrupts = <0 14 4>; > + arasan,has-mdma; > + #address-cells = <1>; > + #size-cells = <0> > + > + nand@0 { > + reg = <0> > + partition@0 { > + label = "filesystem"; > + reg = <0x0 0x0 0x100>; > + }; > + (...) > + }; > + }; > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html