Re: [PATCH] [18/20] x86: Don't disable TSC in any C states on AMD Fam10h

2008-01-04 Thread Ingo Molnar

* Andi Kleen <[EMAIL PROTECTED]> wrote:

> The ACPI code currently disables TSC use in any C2 and C3 states. But 
> the AMD Fam10h BKDG documents that the TSC will never stop in any C 
> states when the CONSTANT_TSC bit is set. Make this disabling 
> conditional on CONSTANT_TSC not set on AMD.
> 
> I actually think this is true on Intel too for C2 states on CPUs with 
> p-state invariant TSC, but this needs further discussions with Len to 
> really confirm :-)
> 
> So far it is only enabled on AMD.

thanks Andi - i've picked this up for x86.git, to get it tested. Len, 
what do you think? If/when you pick it up into the ACPI tree i'll drop 
it from x86.git.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] [18/20] x86: Don't disable TSC in any C states on AMD Fam10h

2008-01-04 Thread Ingo Molnar

* Andi Kleen [EMAIL PROTECTED] wrote:

 The ACPI code currently disables TSC use in any C2 and C3 states. But 
 the AMD Fam10h BKDG documents that the TSC will never stop in any C 
 states when the CONSTANT_TSC bit is set. Make this disabling 
 conditional on CONSTANT_TSC not set on AMD.
 
 I actually think this is true on Intel too for C2 states on CPUs with 
 p-state invariant TSC, but this needs further discussions with Len to 
 really confirm :-)
 
 So far it is only enabled on AMD.

thanks Andi - i've picked this up for x86.git, to get it tested. Len, 
what do you think? If/when you pick it up into the ACPI tree i'll drop 
it from x86.git.

Ingo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/