Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver
On Tue, 2 Jun 2020 08:06:50 +0200 Ludovic Desroches wrote: > On Sun, May 31, 2020 at 03:40:17PM +0100, Jonathan Cameron wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Mon, 25 May 2020 13:27:44 +0300 > > Alexandru Ardelean wrote: > > > > > Since changes can come from all sort of places, it may make sense to have > > > this symbol as a dependency to make sure that the 'make allmodconfig' && > > > 'make allyesconfig' build rules cover this driver as well for a > > > compile-build/test. > > > > > > It seemed useful [recently] when trying to apply a change for this. > > > > > > Signed-off-by: Alexandru Ardelean > > Makes sense. Given this sort of change can expose weird an wonderful > > dependencies that were previously hidden, I'll be wanting an > > ack from at91 people. > > Agree. > > Acked-by: Ludovic Desroches Thanks, Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if they can find any problems with relaxing this. Thanks, Jonathan > > Regards > > Ludovic > > > > > Jonathan > > > > > --- > > > drivers/iio/adc/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > > > index c48c0005..c1f4c0aec265 100644 > > > --- a/drivers/iio/adc/Kconfig > > > +++ b/drivers/iio/adc/Kconfig > > > @@ -294,7 +294,7 @@ config ASPEED_ADC > > > > > > config AT91_ADC > > > tristate "Atmel AT91 ADC" > > > - depends on ARCH_AT91 > > > + depends on ARCH_AT91 || COMPILE_TEST > > > depends on INPUT && SYSFS > > > select IIO_BUFFER > > > select IIO_TRIGGERED_BUFFER > >
Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver
On Sun, May 31, 2020 at 03:40:17PM +0100, Jonathan Cameron wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 25 May 2020 13:27:44 +0300 > Alexandru Ardelean wrote: > > > Since changes can come from all sort of places, it may make sense to have > > this symbol as a dependency to make sure that the 'make allmodconfig' && > > 'make allyesconfig' build rules cover this driver as well for a > > compile-build/test. > > > > It seemed useful [recently] when trying to apply a change for this. > > > > Signed-off-by: Alexandru Ardelean > Makes sense. Given this sort of change can expose weird an wonderful > dependencies that were previously hidden, I'll be wanting an > ack from at91 people. Agree. Acked-by: Ludovic Desroches Regards Ludovic > > Jonathan > > > --- > > drivers/iio/adc/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > > index c48c0005..c1f4c0aec265 100644 > > --- a/drivers/iio/adc/Kconfig > > +++ b/drivers/iio/adc/Kconfig > > @@ -294,7 +294,7 @@ config ASPEED_ADC > > > > config AT91_ADC > > tristate "Atmel AT91 ADC" > > - depends on ARCH_AT91 > > + depends on ARCH_AT91 || COMPILE_TEST > > depends on INPUT && SYSFS > > select IIO_BUFFER > > select IIO_TRIGGERED_BUFFER >
Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver
On Mon, 25 May 2020 13:27:44 +0300 Alexandru Ardelean wrote: > Since changes can come from all sort of places, it may make sense to have > this symbol as a dependency to make sure that the 'make allmodconfig' && > 'make allyesconfig' build rules cover this driver as well for a > compile-build/test. > > It seemed useful [recently] when trying to apply a change for this. > > Signed-off-by: Alexandru Ardelean Makes sense. Given this sort of change can expose weird an wonderful dependencies that were previously hidden, I'll be wanting an ack from at91 people. Jonathan > --- > drivers/iio/adc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index c48c0005..c1f4c0aec265 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -294,7 +294,7 @@ config ASPEED_ADC > > config AT91_ADC > tristate "Atmel AT91 ADC" > - depends on ARCH_AT91 > + depends on ARCH_AT91 || COMPILE_TEST > depends on INPUT && SYSFS > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER