Re: [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n
Hi Florian, [auto build test ERROR on v4.9-rc8] [also build test ERROR on next-20170406] [cannot apply to glikely/devicetree/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-Make-of_match_node-an-inline-stub-for-CONFIG_OF-n/20170407-111805 config: x86_64-randconfig-ne0-04071359 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers//mfd/max8998.c: In function 'max8998_i2c_get_driver_data': >> drivers//mfd/max8998.c:174:25: error: 'max8998_dt_match' undeclared (first >> use in this function) match = of_match_node(max8998_dt_match, i2c->dev.of_node); ^~~~ drivers//mfd/max8998.c:174:25: note: each undeclared identifier is reported only once for each function it appears in vim +/max8998_dt_match +174 drivers//mfd/max8998.c ee999fb3 Tomasz Figa 2013-06-25 158 ee999fb3 Tomasz Figa 2013-06-25 159 pd->ono = irq_of_parse_and_map(dev->of_node, 1); ee999fb3 Tomasz Figa 2013-06-25 160 ee999fb3 Tomasz Figa 2013-06-25 161 /* ee999fb3 Tomasz Figa 2013-06-25 162 * ToDo: the 'wakeup' member in the platform data is more of a linux ee999fb3 Tomasz Figa 2013-06-25 163 * specfic information. Hence, there is no binding for that yet and ee999fb3 Tomasz Figa 2013-06-25 164 * not parsed here. ee999fb3 Tomasz Figa 2013-06-25 165 */ ee999fb3 Tomasz Figa 2013-06-25 166 return pd; ee999fb3 Tomasz Figa 2013-06-25 167 } ee999fb3 Tomasz Figa 2013-06-25 168 8bace2d5 Lee Jones 2014-02-03 169 static inline unsigned long max8998_i2c_get_driver_data(struct i2c_client *i2c, ee999fb3 Tomasz Figa 2013-06-25 170 const struct i2c_device_id *id) ee999fb3 Tomasz Figa 2013-06-25 171 { ee999fb3 Tomasz Figa 2013-06-25 172 if (IS_ENABLED(CONFIG_OF) && i2c->dev.of_node) { ee999fb3 Tomasz Figa 2013-06-25 173 const struct of_device_id *match; ee999fb3 Tomasz Figa 2013-06-25 @174 match = of_match_node(max8998_dt_match, i2c->dev.of_node); 8bace2d5 Lee Jones 2014-02-03 175 return (unsigned long)match->data; ee999fb3 Tomasz Figa 2013-06-25 176 } ee999fb3 Tomasz Figa 2013-06-25 177 8bace2d5 Lee Jones 2014-02-03 178 return id->driver_data; ee999fb3 Tomasz Figa 2013-06-25 179 } ee999fb3 Tomasz Figa 2013-06-25 180 156f2528 Kyungmin Park 2010-06-16 181 static int max8998_i2c_probe(struct i2c_client *i2c, 156f2528 Kyungmin Park 2010-06-16 182 const struct i2c_device_id *id) :: The code at line 174 was first introduced by commit :: ee999fb3f17faa3af6028bf7130707fe0d4157a4 mfd: max8998: Add support for Device Tree :: TO: Tomasz Figa:: CC: Samuel Ortiz --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n
Hi Florian, [auto build test ERROR on v4.9-rc8] [also build test ERROR on next-20170406] [cannot apply to glikely/devicetree/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-Make-of_match_node-an-inline-stub-for-CONFIG_OF-n/20170407-111805 config: x86_64-randconfig-ne0-04071359 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers//mfd/max8998.c: In function 'max8998_i2c_get_driver_data': >> drivers//mfd/max8998.c:174:25: error: 'max8998_dt_match' undeclared (first >> use in this function) match = of_match_node(max8998_dt_match, i2c->dev.of_node); ^~~~ drivers//mfd/max8998.c:174:25: note: each undeclared identifier is reported only once for each function it appears in vim +/max8998_dt_match +174 drivers//mfd/max8998.c ee999fb3 Tomasz Figa 2013-06-25 158 ee999fb3 Tomasz Figa 2013-06-25 159 pd->ono = irq_of_parse_and_map(dev->of_node, 1); ee999fb3 Tomasz Figa 2013-06-25 160 ee999fb3 Tomasz Figa 2013-06-25 161 /* ee999fb3 Tomasz Figa 2013-06-25 162 * ToDo: the 'wakeup' member in the platform data is more of a linux ee999fb3 Tomasz Figa 2013-06-25 163 * specfic information. Hence, there is no binding for that yet and ee999fb3 Tomasz Figa 2013-06-25 164 * not parsed here. ee999fb3 Tomasz Figa 2013-06-25 165 */ ee999fb3 Tomasz Figa 2013-06-25 166 return pd; ee999fb3 Tomasz Figa 2013-06-25 167 } ee999fb3 Tomasz Figa 2013-06-25 168 8bace2d5 Lee Jones 2014-02-03 169 static inline unsigned long max8998_i2c_get_driver_data(struct i2c_client *i2c, ee999fb3 Tomasz Figa 2013-06-25 170 const struct i2c_device_id *id) ee999fb3 Tomasz Figa 2013-06-25 171 { ee999fb3 Tomasz Figa 2013-06-25 172 if (IS_ENABLED(CONFIG_OF) && i2c->dev.of_node) { ee999fb3 Tomasz Figa 2013-06-25 173 const struct of_device_id *match; ee999fb3 Tomasz Figa 2013-06-25 @174 match = of_match_node(max8998_dt_match, i2c->dev.of_node); 8bace2d5 Lee Jones 2014-02-03 175 return (unsigned long)match->data; ee999fb3 Tomasz Figa 2013-06-25 176 } ee999fb3 Tomasz Figa 2013-06-25 177 8bace2d5 Lee Jones 2014-02-03 178 return id->driver_data; ee999fb3 Tomasz Figa 2013-06-25 179 } ee999fb3 Tomasz Figa 2013-06-25 180 156f2528 Kyungmin Park 2010-06-16 181 static int max8998_i2c_probe(struct i2c_client *i2c, 156f2528 Kyungmin Park 2010-06-16 182 const struct i2c_device_id *id) :: The code at line 174 was first introduced by commit :: ee999fb3f17faa3af6028bf7130707fe0d4157a4 mfd: max8998: Add support for Device Tree :: TO: Tomasz Figa :: CC: Samuel Ortiz --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n
Hi Florian, [auto build test ERROR on v4.9-rc8] [also build test ERROR on next-20170406] [cannot apply to glikely/devicetree/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-Make-of_match_node-an-inline-stub-for-CONFIG_OF-n/20170407-111805 config: x86_64-acpi-redef (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': >> drivers/net/ethernet/cadence/macb.c:2967:25: error: 'macb_dt_ids' undeclared >> (first use in this function) match = of_match_node(macb_dt_ids, np); ^~~ drivers/net/ethernet/cadence/macb.c:2967:25: note: each undeclared identifier is reported only once for each function it appears in vim +/macb_dt_ids +2967 drivers/net/ethernet/cadence/macb.c 421d9df06 Cyrille Pitchen 2015-03-07 2951struct phy_device *phydev; 421d9df06 Cyrille Pitchen 2015-03-07 2952struct net_device *dev; 421d9df06 Cyrille Pitchen 2015-03-07 2953struct resource *regs; 421d9df06 Cyrille Pitchen 2015-03-07 2954void __iomem *mem; 421d9df06 Cyrille Pitchen 2015-03-07 2955const char *mac; 421d9df06 Cyrille Pitchen 2015-03-07 2956struct macb *bp; 421d9df06 Cyrille Pitchen 2015-03-07 2957int err; 421d9df06 Cyrille Pitchen 2015-03-07 2958 f2ce8a9e4 Andy Shevchenko 2015-07-24 2959regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); f2ce8a9e4 Andy Shevchenko 2015-07-24 2960mem = devm_ioremap_resource(>dev, regs); f2ce8a9e4 Andy Shevchenko 2015-07-24 2961if (IS_ERR(mem)) f2ce8a9e4 Andy Shevchenko 2015-07-24 2962return PTR_ERR(mem); f2ce8a9e4 Andy Shevchenko 2015-07-24 2963 c69618b3e Nicolas Ferre 2015-03-31 2964if (np) { c69618b3e Nicolas Ferre 2015-03-31 2965const struct of_device_id *match; c69618b3e Nicolas Ferre 2015-03-31 2966 c69618b3e Nicolas Ferre 2015-03-31 @2967match = of_match_node(macb_dt_ids, np); c69618b3e Nicolas Ferre 2015-03-31 2968if (match && match->data) { c69618b3e Nicolas Ferre 2015-03-31 2969 macb_config = match->data; c69618b3e Nicolas Ferre 2015-03-31 2970 clk_init = macb_config->clk_init; c69618b3e Nicolas Ferre 2015-03-31 2971 init = macb_config->init; c69618b3e Nicolas Ferre 2015-03-31 2972} c69618b3e Nicolas Ferre 2015-03-31 2973} c69618b3e Nicolas Ferre 2015-03-31 2974 aead88bd0 shubhrajyoti.da...@xilinx.com 2016-08-16 2975err = clk_init(pdev, , , _clk, _clk); :: The code at line 2967 was first introduced by commit :: c69618b3e4f220f4990b91596d40ea3c4cdc938a net/macb: fix probe sequence to setup clocks earlier :: TO: Nicolas Ferre:: CC: David S. Miller --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n
Hi Florian, [auto build test ERROR on v4.9-rc8] [also build test ERROR on next-20170406] [cannot apply to glikely/devicetree/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-Make-of_match_node-an-inline-stub-for-CONFIG_OF-n/20170407-111805 config: x86_64-acpi-redef (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': >> drivers/net/ethernet/cadence/macb.c:2967:25: error: 'macb_dt_ids' undeclared >> (first use in this function) match = of_match_node(macb_dt_ids, np); ^~~ drivers/net/ethernet/cadence/macb.c:2967:25: note: each undeclared identifier is reported only once for each function it appears in vim +/macb_dt_ids +2967 drivers/net/ethernet/cadence/macb.c 421d9df06 Cyrille Pitchen 2015-03-07 2951struct phy_device *phydev; 421d9df06 Cyrille Pitchen 2015-03-07 2952struct net_device *dev; 421d9df06 Cyrille Pitchen 2015-03-07 2953struct resource *regs; 421d9df06 Cyrille Pitchen 2015-03-07 2954void __iomem *mem; 421d9df06 Cyrille Pitchen 2015-03-07 2955const char *mac; 421d9df06 Cyrille Pitchen 2015-03-07 2956struct macb *bp; 421d9df06 Cyrille Pitchen 2015-03-07 2957int err; 421d9df06 Cyrille Pitchen 2015-03-07 2958 f2ce8a9e4 Andy Shevchenko 2015-07-24 2959regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); f2ce8a9e4 Andy Shevchenko 2015-07-24 2960mem = devm_ioremap_resource(>dev, regs); f2ce8a9e4 Andy Shevchenko 2015-07-24 2961if (IS_ERR(mem)) f2ce8a9e4 Andy Shevchenko 2015-07-24 2962return PTR_ERR(mem); f2ce8a9e4 Andy Shevchenko 2015-07-24 2963 c69618b3e Nicolas Ferre 2015-03-31 2964if (np) { c69618b3e Nicolas Ferre 2015-03-31 2965const struct of_device_id *match; c69618b3e Nicolas Ferre 2015-03-31 2966 c69618b3e Nicolas Ferre 2015-03-31 @2967match = of_match_node(macb_dt_ids, np); c69618b3e Nicolas Ferre 2015-03-31 2968if (match && match->data) { c69618b3e Nicolas Ferre 2015-03-31 2969 macb_config = match->data; c69618b3e Nicolas Ferre 2015-03-31 2970 clk_init = macb_config->clk_init; c69618b3e Nicolas Ferre 2015-03-31 2971 init = macb_config->init; c69618b3e Nicolas Ferre 2015-03-31 2972} c69618b3e Nicolas Ferre 2015-03-31 2973} c69618b3e Nicolas Ferre 2015-03-31 2974 aead88bd0 shubhrajyoti.da...@xilinx.com 2016-08-16 2975err = clk_init(pdev, , , _clk, _clk); :: The code at line 2967 was first introduced by commit :: c69618b3e4f220f4990b91596d40ea3c4cdc938a net/macb: fix probe sequence to setup clocks earlier :: TO: Nicolas Ferre :: CC: David S. Miller --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n
On Thu, Apr 06, 2017 at 12:32:24PM -0700, Florian Fainelli wrote: > Make of_match_node() an inline function when CONFIG_OF=n which allows the > compiler to eliminate warnings about unused variables. > > Suggested-by: Andrew Lunn> Signed-off-by: Florian Fainelli Thanks Florian, Reviewed-by: Andrew Lunn Andrew
Re: [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n
On Thu, Apr 06, 2017 at 12:32:24PM -0700, Florian Fainelli wrote: > Make of_match_node() an inline function when CONFIG_OF=n which allows the > compiler to eliminate warnings about unused variables. > > Suggested-by: Andrew Lunn > Signed-off-by: Florian Fainelli Thanks Florian, Reviewed-by: Andrew Lunn Andrew