Re: [v4l-dvb-maintainer] Re: [stable] [patch 00/50] -stable review
On Wed, Feb 21, 2007 at 04:01:03PM -0500, Michael Krufky wrote: >... > Adrian, this should also apply against 2.6.16.y Thanks, applied. > Thank you, > > Michael Krufky >... cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [v4l-dvb-maintainer] Re: [stable] [patch 00/50] -stable review
Michael Krufky wrote:
> Greg KH wrote:
>> Ok, I've now gotten all of these for .19 and .18.
>>
>> If I've missed anything, please let me know.
>>
>> thanks for your patience.
>
> Looks good... Thank you, Greg.
>
> Greg KH wrote:
>> This will probably be the last release of the 2.6.19-stable series, so
>> if there are patches that you feel should be applied to that tree,
>> please let me know.
>
> Normally, I would wait for a patch to appear in Linus' tree before I send it
> to -stable,
> however, this patch can not wait. Since 2.6.18-stable and 2.6.19-stable have
> their last
> releases pending review, it is imperative that this final patch be added to
> the queue, if
> possible.
It is merged into Linus' tree now:
http://www2.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=b61901024776b25ce7b8edc31bb1757c7382a88e
... The only difference is that the changeset in Linus' tree also changes some
whitespace.
Please merge this into 2.6.18.y, 2.6.19.y and 2.6.20.y
Adrian, this should also apply against 2.6.16.y
Thank you,
Michael Krufky
---
dvbdev: fix illegal re-usage of fileoperations struct
From: Marcel Siegert <[EMAIL PROTECTED]>
Arjan van de Ven <[EMAIL PROTECTED]> reported an illegal re-usage of the
fileoperations struct
if more than one dvb device(e.g. frontend) is present. this patch fixes this
issue.
it allocates a new fileoperations struct each time a device is registered and
copies the default
template fileops.
Signed-off-by: Marcel Siegert <[EMAIL PROTECTED]>
Signed-off-by: Michael Krufky <[EMAIL PROTECTED]>
---
linux/drivers/media/dvb/dvb-core/dvbdev.c | 13 +
1 file changed, 13 insertions(+)
--- linux/drivers/media/dvb/dvb-core/dvbdev.c.orig
+++ linux/drivers/media/dvb/dvb-core/dvbdev.c
@@ -211,6 +211,8 @@
const struct dvb_device *template, void *priv, int type)
{
struct dvb_device *dvbdev;
+ struct file_operations *dvbdevfops;
+
int id;
if (mutex_lock_interruptible(&dvbdev_register_lock))
@@ -230,12 +232,22 @@
return -ENOMEM;
}
+ dvbdevfops = kzalloc(sizeof(struct file_operations), GFP_KERNEL);
+
+ if (!dvbdevfops) {
+ kfree (dvbdev);
+ mutex_unlock(&dvbdev_register_lock);
+ return -ENOMEM;
+ }
+
memcpy(dvbdev, template, sizeof(struct dvb_device));
dvbdev->type = type;
dvbdev->id = id;
dvbdev->adapter = adap;
dvbdev->priv = priv;
+ dvbdev->fops = dvbdevfops;
+ memcpy(dvbdev->fops, template->fops, sizeof(struct file_operations));
dvbdev->fops->owner = adap->module;
list_add_tail (&dvbdev->list_head, &adap->device_list);
@@ -263,6 +275,7 @@
dvbdev->type, dvbdev->id)));
list_del (&dvbdev->list_head);
+ kfree (dvbdev->fops);
kfree (dvbdev);
}
EXPORT_SYMBOL(dvb_unregister_device);
--
Michael Krufky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
Greg KH wrote:
> Ok, I've now gotten all of these for .19 and .18.
>
> If I've missed anything, please let me know.
>
> thanks for your patience.
Looks good... Thank you, Greg.
Greg KH wrote:
> This will probably be the last release of the 2.6.19-stable series, so
> if there are patches that you feel should be applied to that tree,
> please let me know.
Normally, I would wait for a patch to appear in Linus' tree before I send it to
-stable,
however, this patch can not wait. Since 2.6.18-stable and 2.6.19-stable have
their last
releases pending review, it is imperative that this final patch be added to the
queue, if
possible.
This patch was recently submitted, and fixes many horrible, previously
unexplained bugs of the
past.
Please queue this for the final 2.6.18 and 2.6.19 -stable releases, as well as
for 2.6.20.1
Thank you,
Michael Krufky
---
dvbdev: fix illegal re-usage of fileoperations struct
From: Marcel Siegert <[EMAIL PROTECTED]>
Arjan van de Ven <[EMAIL PROTECTED]> reported an illegal re-usage of the
fileoperations struct
if more than one dvb device(e.g. frontend) is present. this patch fixes this
issue.
it allocates a new fileoperations struct each time a device is registered and
copies the default
template fileops.
Signed-off-by: Marcel Siegert <[EMAIL PROTECTED]>
Signed-off-by: Michael Krufky <[EMAIL PROTECTED]>
---
linux/drivers/media/dvb/dvb-core/dvbdev.c | 13 +
1 file changed, 13 insertions(+)
--- linux/drivers/media/dvb/dvb-core/dvbdev.c.orig
+++ linux/drivers/media/dvb/dvb-core/dvbdev.c
@@ -211,6 +211,8 @@
const struct dvb_device *template, void *priv, int type)
{
struct dvb_device *dvbdev;
+ struct file_operations *dvbdevfops;
+
int id;
if (mutex_lock_interruptible(&dvbdev_register_lock))
@@ -230,12 +232,22 @@
return -ENOMEM;
}
+ dvbdevfops = kzalloc(sizeof(struct file_operations), GFP_KERNEL);
+
+ if (!dvbdevfops) {
+ kfree (dvbdev);
+ mutex_unlock(&dvbdev_register_lock);
+ return -ENOMEM;
+ }
+
memcpy(dvbdev, template, sizeof(struct dvb_device));
dvbdev->type = type;
dvbdev->id = id;
dvbdev->adapter = adap;
dvbdev->priv = priv;
+ dvbdev->fops = dvbdevfops;
+ memcpy(dvbdev->fops, template->fops, sizeof(struct file_operations));
dvbdev->fops->owner = adap->module;
list_add_tail (&dvbdev->list_head, &adap->device_list);
@@ -263,6 +275,7 @@
dvbdev->type, dvbdev->id)));
list_del (&dvbdev->list_head);
+ kfree (dvbdev->fops);
kfree (dvbdev);
}
EXPORT_SYMBOL(dvb_unregister_device);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
On Fri, Feb 09, 2007 at 11:51:56AM -0800, Greg KH wrote: > On Fri, Feb 09, 2007 at 02:41:05PM -0500, Michael Krufky wrote: > > Michael Krufky wrote: > > > Greg KH wrote: > > > > > I'll go through the archives and see if there's enough to do a .18 > > release (and the patches are serious enough to warrent it.) > > >>> Actually, I have a few more -stable patches for both 2.6.18.y and > > >>> 2.6.19.y, if > > >>> you don't mind holding off a day or two (wont have time to prepare > > >>> these until > > >>> tomorrow evening)... One of them is a security fix, that allows a > > >>> non-root user > > >>> to hang the kernel given the correct circumstances. > > >> Ok, that's serious enough :) > > >> > > >> I'll wait for your patches. > > >> > > >> thanks, > > >> > > >> greg k-h > > > > > > I've uploaded the remaining pending v4l/dvb -stable patches for both > > > 2.6.18.y > > > and 2.6.19.y to the following locations: > > > > > > http://linuxtv.org/~mkrufky/stable/2.6.18.y/ (8 patches) > > > > > > and > > > > > > http://linuxtv.org/~mkrufky/stable/2.6.19.y/ (5 patches) > > > > > > Using the mailer at my current location, I am unable to send patches > > > inline, and > > > I won't have the time for it this evening. In the interest of saving > > > time, I > > > figured that sending them to you in this method is good enough. If you > > > still > > > need for me to send them via email inline, please let me know. > > > > Greg & Chris, > > > > I haven't heard from either of you about these patches, nor have I seen any > > update to the stable-queue. > > > > Just for clarification, the security fix patch, that prevents a non-root > > user > > from hanging the kernel is the patch entitled, > > > > "V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup" > > > > ...as per Mauro's description, here: > > > > http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg113820.html > > Thanks, I'll be flushing out the stable queue later on tonight and will > pick up all of these patches. Ok, I've now gotten all of these for .19 and .18. If I've missed anything, please let me know. thanks for your patience. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
On Fri, Feb 09, 2007 at 02:41:05PM -0500, Michael Krufky wrote: > Michael Krufky wrote: > > Greg KH wrote: > > > I'll go through the archives and see if there's enough to do a .18 > release (and the patches are serious enough to warrent it.) > >>> Actually, I have a few more -stable patches for both 2.6.18.y and > >>> 2.6.19.y, if > >>> you don't mind holding off a day or two (wont have time to prepare these > >>> until > >>> tomorrow evening)... One of them is a security fix, that allows a > >>> non-root user > >>> to hang the kernel given the correct circumstances. > >> Ok, that's serious enough :) > >> > >> I'll wait for your patches. > >> > >> thanks, > >> > >> greg k-h > > > > I've uploaded the remaining pending v4l/dvb -stable patches for both > > 2.6.18.y > > and 2.6.19.y to the following locations: > > > > http://linuxtv.org/~mkrufky/stable/2.6.18.y/ (8 patches) > > > > and > > > > http://linuxtv.org/~mkrufky/stable/2.6.19.y/ (5 patches) > > > > Using the mailer at my current location, I am unable to send patches > > inline, and > > I won't have the time for it this evening. In the interest of saving time, > > I > > figured that sending them to you in this method is good enough. If you > > still > > need for me to send them via email inline, please let me know. > > Greg & Chris, > > I haven't heard from either of you about these patches, nor have I seen any > update to the stable-queue. > > Just for clarification, the security fix patch, that prevents a non-root user > from hanging the kernel is the patch entitled, > > "V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup" > > ...as per Mauro's description, here: > > http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg113820.html Thanks, I'll be flushing out the stable queue later on tonight and will pick up all of these patches. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
Michael Krufky wrote: > Greg KH wrote: > I'll go through the archives and see if there's enough to do a .18 release (and the patches are serious enough to warrent it.) >>> Actually, I have a few more -stable patches for both 2.6.18.y and 2.6.19.y, >>> if >>> you don't mind holding off a day or two (wont have time to prepare these >>> until >>> tomorrow evening)... One of them is a security fix, that allows a non-root >>> user >>> to hang the kernel given the correct circumstances. >> Ok, that's serious enough :) >> >> I'll wait for your patches. >> >> thanks, >> >> greg k-h > > I've uploaded the remaining pending v4l/dvb -stable patches for both 2.6.18.y > and 2.6.19.y to the following locations: > > http://linuxtv.org/~mkrufky/stable/2.6.18.y/ (8 patches) > > and > > http://linuxtv.org/~mkrufky/stable/2.6.19.y/ (5 patches) > > Using the mailer at my current location, I am unable to send patches inline, > and > I won't have the time for it this evening. In the interest of saving time, I > figured that sending them to you in this method is good enough. If you still > need for me to send them via email inline, please let me know. Greg & Chris, I haven't heard from either of you about these patches, nor have I seen any update to the stable-queue. Just for clarification, the security fix patch, that prevents a non-root user from hanging the kernel is the patch entitled, "V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup" ...as per Mauro's description, here: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg113820.html Regards, Michael Krufky - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
Greg KH wrote: >>> I'll go through the archives and see if there's enough to do a .18 >>> release (and the patches are serious enough to warrent it.) >> Actually, I have a few more -stable patches for both 2.6.18.y and 2.6.19.y, >> if >> you don't mind holding off a day or two (wont have time to prepare these >> until >> tomorrow evening)... One of them is a security fix, that allows a non-root >> user >> to hang the kernel given the correct circumstances. > > Ok, that's serious enough :) > > I'll wait for your patches. > > thanks, > > greg k-h I've uploaded the remaining pending v4l/dvb -stable patches for both 2.6.18.y and 2.6.19.y to the following locations: http://linuxtv.org/~mkrufky/stable/2.6.18.y/ (8 patches) and http://linuxtv.org/~mkrufky/stable/2.6.19.y/ (5 patches) Using the mailer at my current location, I am unable to send patches inline, and I won't have the time for it this evening. In the interest of saving time, I figured that sending them to you in this method is good enough. If you still need for me to send them via email inline, please let me know. Best Regards, Michael Krufky - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
On Mon, Feb 05, 2007 at 05:16:11PM -0500, Michael Krufky wrote: > Greg KH wrote: > > On Sun, Feb 04, 2007 at 01:24:18PM -0500, Michael Krufky wrote: > >> Chris Wright wrote: > >>> This is the start of the stable review cycle for the 2.6.19.2 release. > >>> There are 50 patches in this series, all will be posted as a response > >>> to this one. If anyone has any issues with these being applied, please > >>> let us know. If anyone is a maintainer of the proper subsystem, and > >>> wants to add a Signed-off-by: line to the patch, please respond with it. > >>> > >>> These patches are sent out with a number of different people on the > >>> Cc: line. If you wish to be a reviewer, please email [EMAIL PROTECTED] > >>> to add your name to the list. If you want to be off the reviewer list, > >>> also email us. > >>> > >>> Responses should be made by Mon Jan 8 02:30 UTC. > >>> Anything received after that time might be too late. > >> At which point was 2.6.18.y dropped? I thought we were always going to > >> keep > >> the last two stable kernels up-to-date. Have I been wasting my time > >> fwd'ing > >> 2.6.18.y patches? > > > > It was dropped a while ago, sorry. > > > > I'll go through the archives and see if there's enough to do a .18 > > release (and the patches are serious enough to warrent it.) > > Actually, I have a few more -stable patches for both 2.6.18.y and 2.6.19.y, if > you don't mind holding off a day or two (wont have time to prepare these until > tomorrow evening)... One of them is a security fix, that allows a non-root > user > to hang the kernel given the correct circumstances. Ok, that's serious enough :) I'll wait for your patches. > Maybe you guys can make some sort of announcement before the -stable kernel is > closed. I know that now that 2.6.20 is released, implicitly 2.6.18.y is > closed... but it's been a long while since the last 2.6.18.y release, so I > wasn't sure if patches were still being accepted. I thought we did at the time we did the last release, but I'll try to remember to highlight it a more prominently next time. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
Greg KH wrote: > On Sun, Feb 04, 2007 at 01:24:18PM -0500, Michael Krufky wrote: >> Chris Wright wrote: >>> This is the start of the stable review cycle for the 2.6.19.2 release. >>> There are 50 patches in this series, all will be posted as a response >>> to this one. If anyone has any issues with these being applied, please >>> let us know. If anyone is a maintainer of the proper subsystem, and >>> wants to add a Signed-off-by: line to the patch, please respond with it. >>> >>> These patches are sent out with a number of different people on the >>> Cc: line. If you wish to be a reviewer, please email [EMAIL PROTECTED] >>> to add your name to the list. If you want to be off the reviewer list, >>> also email us. >>> >>> Responses should be made by Mon Jan 8 02:30 UTC. >>> Anything received after that time might be too late. >> At which point was 2.6.18.y dropped? I thought we were always going to keep >> the last two stable kernels up-to-date. Have I been wasting my time fwd'ing >> 2.6.18.y patches? > > It was dropped a while ago, sorry. > > I'll go through the archives and see if there's enough to do a .18 > release (and the patches are serious enough to warrent it.) Actually, I have a few more -stable patches for both 2.6.18.y and 2.6.19.y, if you don't mind holding off a day or two (wont have time to prepare these until tomorrow evening)... One of them is a security fix, that allows a non-root user to hang the kernel given the correct circumstances. Maybe you guys can make some sort of announcement before the -stable kernel is closed. I know that now that 2.6.20 is released, implicitly 2.6.18.y is closed... but it's been a long while since the last 2.6.18.y release, so I wasn't sure if patches were still being accepted. Regards, Michael Krufky - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
On Mon, Feb 05, 2007 at 02:12:33PM -0800, Chris Wright wrote: > * Greg KH ([EMAIL PROTECTED]) wrote: > > On Sun, Feb 04, 2007 at 01:24:18PM -0500, Michael Krufky wrote: > > > At which point was 2.6.18.y dropped? I thought we were always going to > > > keep > > > the last two stable kernels up-to-date. > > Not quite. It's more of a "some overlap," so that as soon as 2.6.x > comes out we don't instantly drop 2.6.(x-1).y stream. But we don't keep > it going, typically more 1 or 2 2.6.(x-1).y releases once 2.6.x is out. > > > > Have I been wasting my time fwd'ing > > > 2.6.18.y patches? > > I had actually queued them up, but we only had 1 or 2 other patches, > and they weren't significant enough to warrant flushing that queue. I'll see if the latest stuff that is queued up and some other stuff is worth to push out a new release in a few days. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
* Greg KH ([EMAIL PROTECTED]) wrote: > On Sun, Feb 04, 2007 at 01:24:18PM -0500, Michael Krufky wrote: > > At which point was 2.6.18.y dropped? I thought we were always going to keep > > the last two stable kernels up-to-date. Not quite. It's more of a "some overlap," so that as soon as 2.6.x comes out we don't instantly drop 2.6.(x-1).y stream. But we don't keep it going, typically more 1 or 2 2.6.(x-1).y releases once 2.6.x is out. > > Have I been wasting my time fwd'ing > > 2.6.18.y patches? I had actually queued them up, but we only had 1 or 2 other patches, and they weren't significant enough to warrant flushing that queue. thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [stable] [patch 00/50] -stable review
On Sun, Feb 04, 2007 at 01:24:18PM -0500, Michael Krufky wrote: > Chris Wright wrote: > > This is the start of the stable review cycle for the 2.6.19.2 release. > > There are 50 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let us know. If anyone is a maintainer of the proper subsystem, and > > wants to add a Signed-off-by: line to the patch, please respond with it. > > > > These patches are sent out with a number of different people on the > > Cc: line. If you wish to be a reviewer, please email [EMAIL PROTECTED] > > to add your name to the list. If you want to be off the reviewer list, > > also email us. > > > > Responses should be made by Mon Jan 8 02:30 UTC. > > Anything received after that time might be too late. > > At which point was 2.6.18.y dropped? I thought we were always going to keep > the last two stable kernels up-to-date. Have I been wasting my time fwd'ing > 2.6.18.y patches? It was dropped a while ago, sorry. I'll go through the archives and see if there's enough to do a .18 release (and the patches are serious enough to warrent it.) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
