Re: [linux-dvb-maintainer] DVB at76c651.c driver seems to be dead code
Adrian Bunk wrote: I didn't find any way how the drivers/media/dvb/frontends/at76c651.c driver would do anything inside kernel 2.6.11-rc3-mm2. All it does is to EXPORT_SYMBOL a function at76c651_attach that isn't used anywhere. Is a patch to remove this driver OK or did I miss anything? no, please let it there. This driver is the GPL'd part of the dbox2 driver which is not part of the official kernel tree. Since frontend and demod drivers are reusable elsewhere and mainstream hardware that makes use of this demodulator may show up every week it's just stupid to remove this code as long we know it is working and continously tested by the dbox2 folks. Instead it may make sense to move the dbox2 sources into the mainstream source tree. Andreas, what do you think? Holger - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [linux-dvb-maintainer] [RFC: 2.6 patch] DVB: possible cleanups
Adrian Bunk wrote: Before I'm getting flamed to death: This patch contains possible cleanups. If parts of this patch conflict with pending changes these parts of my patch have to be dropped. This patch contains the following possible cleanups: - make needlessly global code static - remove the following EXPORT_SYMBOL'ed but unused function: - bt8xx/bt878.c: bt878_find_by_i2c_adap - remove the following unused global functions: - dvb-core/dvb_demux.c: dmx_get_demuxes - dvb-core/dvb_demux.c: dvb_set_crc32 - remove the following unneeded EXPORT_SYMBOL's: - dvb-core/dvb_demux.c: dvb_dmx_swfilter_packet dvb_dmx_swfilter_packet() should remain exported to the public, accessing this directly makes sense for some architectures. Holger - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [linux-dvb-maintainer] [2.6 patch] DVB: remove bouncing address of Alex Woods
Have you ever considered asking on the linux-dvb mailing list for a more recent address? stop trolling and do something useful. please. Bounces are sometimes temporary, contacting linux dvb developers is usually easiest over the linux-dvb mailing list. Subscribe there if you have a dvb-related problem and want to solve it. Holger Adrian Bunk wrote: This patch removes the bouncing email address [EMAIL PROTECTED] of Alex Woods. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/media/dvb/ttusb-dec/ttusb_dec.c |4 ++-- drivers/media/dvb/ttusb-dec/ttusbdecfe.c |2 +- drivers/media/dvb/ttusb-dec/ttusbdecfe.h |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) --- linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusbdecfe.h.old 2005-02-06 21:18:09.0 +0100 +++ linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusbdecfe.h 2005-02-06 21:18:31.0 +0100 @@ -1,7 +1,7 @@ /* * TTUSB DEC Driver * - * Copyright (C) 2003-2004 Alex Woods [EMAIL PROTECTED] + * Copyright (C) 2003-2004 Alex Woods * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by --- linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusb_dec.c.old 2005-02-06 21:18:43.0 +0100 +++ linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusb_dec.c 2005-02-06 21:18:53.0 +0100 @@ -1,7 +1,7 @@ /* * TTUSB DEC Driver * - * Copyright (C) 2003-2004 Alex Woods [EMAIL PROTECTED] + * Copyright (C) 2003-2004 Alex Woods * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -1583,7 +1583,7 @@ module_init(ttusb_dec_init); module_exit(ttusb_dec_exit); -MODULE_AUTHOR(Alex Woods [EMAIL PROTECTED]); +MODULE_AUTHOR(Alex Woods); MODULE_DESCRIPTION(DRIVER_NAME); MODULE_LICENSE(GPL); MODULE_DEVICE_TABLE(usb, ttusb_dec_table); --- linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusbdecfe.c.old 2005-02-06 21:19:01.0 +0100 +++ linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusbdecfe.c 2005-02-06 21:19:06.0 +0100 @@ -1,7 +1,7 @@ /* * TTUSB DEC Frontend Driver * - * Copyright (C) 2003-2004 Alex Woods [EMAIL PROTECTED] + * Copyright (C) 2003-2004 Alex Woods * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[linux-dvb] Re: 2.5.46: DVB don't work...
Alan Cox wrote: On Wed, 2002-11-06 at 11:23, Gregoire Favre wrote: On Tue, Nov 05, 2002 at 05:31:06PM +0100, Gregoire Favre wrote: I have tried to compil dvb-ttpci in the kernel: ld -m elf_i386 -e stext -T arch/i386/vmlinux.lds.s arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/built-in.o --start-group usr/built-in.o arch/i386/kernel/built-in.o arch/i386/mm/built-in.o arch/i386/mach-generic/built-in.o kernel/built-in.o mm/built-in.o fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o lib/lib.a arch/i386/lib/lib.a drivers/built-in.o sound/built-in.o arch/i386/pci/built-in.o net/built-in.o --end-group -o .tmp_vmlinux1 drivers/built-in.o(.data+0xf6f4): undefined reference to `local symbols in discarded section .exit.text' make: *** [.tmp_vmlinux1] Error 1 Anyone got a fix? Missing devexit_p for the pci remove call somewhere. I'll take a look if I get time, but you are looking for a pci module declaration which has a remove function that isnt marked __devexit_p() when the function it calls is I'll fix this in the linux-dvb CVS repository, it will be included in the next 2.5 patchset. Holger -- Info: To unsubscribe send a mail to [EMAIL PROTECTED] with unsubscribe linux-dvb as subject.
[linux-dvb] Re: How to compil dvb CVS with 2.5.52?
Hi Gregoire,
Gregoire Favre wrote:
It then don't compil and i have to patch with the patch sent to this
list the Wed, 11 Dec 2002 10:53:43 +1100 from Rusty Russell:
--- drivers/media/dvb/dvb-core/dvb_i2c.c 2002-12-19 23:21:07.0 +0100
+++ drivers/media/dvb/dvb-core/dvb_i2c.c~ 2002-11-28 19:57:09.0 +0100
@@ -64,8 +64,10 @@
void try_attach_device (struct dvb_i2c_bus *i2c, struct dvb_i2c_device *dev)
{
if (dev-owner) {
- if (!try_inc_mod_count(dev-owner))
+ if (!MOD_CAN_QUERY(dev-owner))
return;
+
+ __MOD_INC_USE_COUNT(dev-owner);
}
if (dev-attach (i2c) == 0) {
are you sure? MOD_CAN_QUERY() and __MOD_INC_USE_COUNT() are 2.4 macros,
they are deprecated now. The compatibility fake is implemented in
compat.h. Could you please check this again and tell me what exactly the
problem is?
Holger
--
Info:
To unsubscribe send a mail to [EMAIL PROTECTED] with unsubscribe linux-dvb as subject.
Re: [linux-dvb-maintainer] DVB at76c651.c driver seems to be dead code
Adrian Bunk wrote: I didn't find any way how the drivers/media/dvb/frontends/at76c651.c driver would do anything inside kernel 2.6.11-rc3-mm2. All it does is to EXPORT_SYMBOL a function at76c651_attach that isn't used anywhere. Is a patch to remove this driver OK or did I miss anything? no, please let it there. This driver is the GPL'd part of the dbox2 driver which is not part of the official kernel tree. Since frontend and demod drivers are reusable elsewhere and mainstream hardware that makes use of this demodulator may show up every week it's just stupid to remove this code as long we know it is working and continously tested by the dbox2 folks. Instead it may make sense to move the dbox2 sources into the mainstream source tree. Andreas, what do you think? Holger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [linux-dvb-maintainer] [RFC: 2.6 patch] DVB: possible cleanups
Adrian Bunk wrote: Before I'm getting flamed to death: This patch contains possible cleanups. If parts of this patch conflict with pending changes these parts of my patch have to be dropped. This patch contains the following possible cleanups: - make needlessly global code static - remove the following EXPORT_SYMBOL'ed but unused function: - bt8xx/bt878.c: bt878_find_by_i2c_adap - remove the following unused global functions: - dvb-core/dvb_demux.c: dmx_get_demuxes - dvb-core/dvb_demux.c: dvb_set_crc32 - remove the following unneeded EXPORT_SYMBOL's: - dvb-core/dvb_demux.c: dvb_dmx_swfilter_packet dvb_dmx_swfilter_packet() should remain exported to the public, accessing this directly makes sense for some architectures. Holger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [linux-dvb-maintainer] [2.6 patch] DVB: remove bouncing address of Alex Woods
Have you ever considered asking on the linux-dvb mailing list for a more
recent address? stop trolling and do something useful. please.
Bounces are sometimes temporary, contacting linux dvb developers is
usually easiest over the linux-dvb mailing list. Subscribe there if you
have a dvb-related problem and want to solve it.
Holger
Adrian Bunk wrote:
This patch removes the bouncing email address [EMAIL PROTECTED] of
Alex Woods.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/media/dvb/ttusb-dec/ttusb_dec.c |4 ++--
drivers/media/dvb/ttusb-dec/ttusbdecfe.c |2 +-
drivers/media/dvb/ttusb-dec/ttusbdecfe.h |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusbdecfe.h.old
2005-02-06 21:18:09.0 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusbdecfe.h
2005-02-06 21:18:31.0 +0100
@@ -1,7 +1,7 @@
/*
* TTUSB DEC Driver
*
- * Copyright (C) 2003-2004 Alex Woods <[EMAIL PROTECTED]>
+ * Copyright (C) 2003-2004 Alex Woods
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
--- linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusb_dec.c.old
2005-02-06 21:18:43.0 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusb_dec.c
2005-02-06 21:18:53.0 +0100
@@ -1,7 +1,7 @@
/*
* TTUSB DEC Driver
*
- * Copyright (C) 2003-2004 Alex Woods <[EMAIL PROTECTED]>
+ * Copyright (C) 2003-2004 Alex Woods
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -1583,7 +1583,7 @@
module_init(ttusb_dec_init);
module_exit(ttusb_dec_exit);
-MODULE_AUTHOR("Alex Woods <[EMAIL PROTECTED]>");
+MODULE_AUTHOR("Alex Woods");
MODULE_DESCRIPTION(DRIVER_NAME);
MODULE_LICENSE("GPL");
MODULE_DEVICE_TABLE(usb, ttusb_dec_table);
--- linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusbdecfe.c.old
2005-02-06 21:19:01.0 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/media/dvb/ttusb-dec/ttusbdecfe.c
2005-02-06 21:19:06.0 +0100
@@ -1,7 +1,7 @@
/*
* TTUSB DEC Frontend Driver
*
- * Copyright (C) 2003-2004 Alex Woods <[EMAIL PROTECTED]>
+ * Copyright (C) 2003-2004 Alex Woods
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[linux-dvb] Re: 2.5.46: DVB don't work...
Alan Cox wrote: On Wed, 2002-11-06 at 11:23, Gregoire Favre wrote: On Tue, Nov 05, 2002 at 05:31:06PM +0100, Gregoire Favre wrote: I have tried to compil dvb-ttpci in the kernel: ld -m elf_i386 -e stext -T arch/i386/vmlinux.lds.s arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/built-in.o --start-group usr/built-in.o arch/i386/kernel/built-in.o arch/i386/mm/built-in.o arch/i386/mach-generic/built-in.o kernel/built-in.o mm/built-in.o fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o lib/lib.a arch/i386/lib/lib.a drivers/built-in.o sound/built-in.o arch/i386/pci/built-in.o net/built-in.o --end-group -o .tmp_vmlinux1 drivers/built-in.o(.data+0xf6f4): undefined reference to `local symbols in discarded section .exit.text' make: *** [.tmp_vmlinux1] Error 1 Anyone got a fix? Missing devexit_p for the pci remove call somewhere. I'll take a look if I get time, but you are looking for a pci module declaration which has a remove function that isnt marked __devexit_p() when the function it calls is I'll fix this in the linux-dvb CVS repository, it will be included in the next 2.5 patchset. Holger -- Info: To unsubscribe send a mail to [EMAIL PROTECTED] with "unsubscribe linux-dvb" as subject.
[linux-dvb] Re: How to compil dvb CVS with 2.5.52?
Hi Gregoire,
Gregoire Favre wrote:
It then don't compil and i have to patch with the patch sent to this
list the Wed, 11 Dec 2002 10:53:43 +1100 from Rusty Russell:
--- drivers/media/dvb/dvb-core/dvb_i2c.c 2002-12-19 23:21:07.0 +0100
+++ drivers/media/dvb/dvb-core/dvb_i2c.c~ 2002-11-28 19:57:09.0 +0100
@@ -64,8 +64,10 @@
void try_attach_device (struct dvb_i2c_bus *i2c, struct dvb_i2c_device *dev)
{
if (dev->owner) {
- if (!try_inc_mod_count(dev->owner))
+ if (!MOD_CAN_QUERY(dev->owner))
return;
+
+ __MOD_INC_USE_COUNT(dev->owner);
}
if (dev->attach (i2c) == 0) {
are you sure? MOD_CAN_QUERY() and __MOD_INC_USE_COUNT() are 2.4 macros,
they are deprecated now. The compatibility fake is implemented in
compat.h. Could you please check this again and tell me what exactly the
problem is?
Holger
--
Info:
To unsubscribe send a mail to [EMAIL PROTECTED] with "unsubscribe linux-dvb" as subject.
