Re: [PATCH v2 12/15] dt: bindings: Add lane-polarity property to endpoint nodes

2015-04-24 Thread Benoit Parrot
Sakari Ailus sakari.ai...@iki.fi wrote on Thu [2015-Mar-26 00:57:36 +0200]:
 Add lane-polarity property to endpoint nodes. This essentially tells that
 the order of the differential signal wires is inverted.
 
 Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
 Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
 ---
  Documentation/devicetree/bindings/media/video-interfaces.txt |6 ++
  1 file changed, 6 insertions(+)
 
 diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt 
 b/Documentation/devicetree/bindings/media/video-interfaces.txt
 index 571b4c6..9cd2a36 100644
 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
 +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
 @@ -106,6 +106,12 @@ Optional endpoint properties
  - link-frequencies: Allowed data bus frequencies. For MIPI CSI-2, for
instance, this is the actual frequency of the bus, not bits per clock per
lane value. An array of 64-bit unsigned integers.
 +- lane-polarities: an array of polarities of the lanes starting from the 
 clock
 +  lane and followed by the data lanes in the same order as in data-lanes.
 +  Valid values are 0 (normal) and 1 (inverted). The length of the array
 +  should be the combined length of data-lanes and clock-lanes properties.
 +  If the lane-polarities property is omitted, the value must be interpreted
 +  as 0 (normal). This property is valid for serial busses only.
  

I am interested in this functionality.
But I do have the following question.
If the lane-polarities property is not specified, shouldn't the
relevant struct member (bus-lane_polarities[i]) be set to 0?

Regards,
Benoit
  
  Example
 -- 
 1.7.10.4
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 12/15] dt: bindings: Add lane-polarity property to endpoint nodes

2015-04-24 Thread Sakari Ailus
Hi Benoit,

On Fri, Apr 24, 2015 at 02:41:00PM -0500, Benoit Parrot wrote:
 Sakari Ailus sakari.ai...@iki.fi wrote on Thu [2015-Mar-26 00:57:36 +0200]:
  Add lane-polarity property to endpoint nodes. This essentially tells that
  the order of the differential signal wires is inverted.
  
  Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
  Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
  ---
   Documentation/devicetree/bindings/media/video-interfaces.txt |6 ++
   1 file changed, 6 insertions(+)
  
  diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt 
  b/Documentation/devicetree/bindings/media/video-interfaces.txt
  index 571b4c6..9cd2a36 100644
  --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
  +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
  @@ -106,6 +106,12 @@ Optional endpoint properties
   - link-frequencies: Allowed data bus frequencies. For MIPI CSI-2, for
 instance, this is the actual frequency of the bus, not bits per clock per
 lane value. An array of 64-bit unsigned integers.
  +- lane-polarities: an array of polarities of the lanes starting from the 
  clock
  +  lane and followed by the data lanes in the same order as in data-lanes.
  +  Valid values are 0 (normal) and 1 (inverted). The length of the array
  +  should be the combined length of data-lanes and clock-lanes properties.
  +  If the lane-polarities property is omitted, the value must be interpreted
  +  as 0 (normal). This property is valid for serial busses only.
   
 
 I am interested in this functionality.
 But I do have the following question.
 If the lane-polarities property is not specified, shouldn't the
 relevant struct member (bus-lane_polarities[i]) be set to 0?

This is done in the caller function; endpoint-bus is zeroed in
v4l2_of_parse_endpoint(). I believe reading rest of the properties relies on
the same.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 12/15] dt: bindings: Add lane-polarity property to endpoint nodes

2015-04-24 Thread Benoit Parrot
Sakari Ailus sakari.ai...@iki.fi wrote on Fri [2015-Apr-24 22:49:33 +0300]:
 Hi Benoit,
 
 On Fri, Apr 24, 2015 at 02:41:00PM -0500, Benoit Parrot wrote:
  Sakari Ailus sakari.ai...@iki.fi wrote on Thu [2015-Mar-26 00:57:36 
  +0200]:
   Add lane-polarity property to endpoint nodes. This essentially tells that
   the order of the differential signal wires is inverted.
   
   Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
   Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
   ---
Documentation/devicetree/bindings/media/video-interfaces.txt |6 
   ++
1 file changed, 6 insertions(+)
   
   diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt 
   b/Documentation/devicetree/bindings/media/video-interfaces.txt
   index 571b4c6..9cd2a36 100644
   --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
   +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
   @@ -106,6 +106,12 @@ Optional endpoint properties
- link-frequencies: Allowed data bus frequencies. For MIPI CSI-2, for
  instance, this is the actual frequency of the bus, not bits per clock 
   per
  lane value. An array of 64-bit unsigned integers.
   +- lane-polarities: an array of polarities of the lanes starting from the 
   clock
   +  lane and followed by the data lanes in the same order as in data-lanes.
   +  Valid values are 0 (normal) and 1 (inverted). The length of the array
   +  should be the combined length of data-lanes and clock-lanes properties.
   +  If the lane-polarities property is omitted, the value must be 
   interpreted
   +  as 0 (normal). This property is valid for serial busses only.

  
  I am interested in this functionality.
  But I do have the following question.
  If the lane-polarities property is not specified, shouldn't the
  relevant struct member (bus-lane_polarities[i]) be set to 0?
 
 This is done in the caller function; endpoint-bus is zeroed in
 v4l2_of_parse_endpoint(). I believe reading rest of the properties relies on
 the same.

Dang, missed that.
Sorry for the noise.

 
 -- 
 Kind regards,
 
 Sakari Ailus
 e-mail: sakari.ai...@iki.fi   XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 12/15] dt: bindings: Add lane-polarity property to endpoint nodes

2015-03-25 Thread Sakari Ailus
Add lane-polarity property to endpoint nodes. This essentially tells that
the order of the differential signal wires is inverted.

Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
 Documentation/devicetree/bindings/media/video-interfaces.txt |6 ++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt 
b/Documentation/devicetree/bindings/media/video-interfaces.txt
index 571b4c6..9cd2a36 100644
--- a/Documentation/devicetree/bindings/media/video-interfaces.txt
+++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
@@ -106,6 +106,12 @@ Optional endpoint properties
 - link-frequencies: Allowed data bus frequencies. For MIPI CSI-2, for
   instance, this is the actual frequency of the bus, not bits per clock per
   lane value. An array of 64-bit unsigned integers.
+- lane-polarities: an array of polarities of the lanes starting from the clock
+  lane and followed by the data lanes in the same order as in data-lanes.
+  Valid values are 0 (normal) and 1 (inverted). The length of the array
+  should be the combined length of data-lanes and clock-lanes properties.
+  If the lane-polarities property is omitted, the value must be interpreted
+  as 0 (normal). This property is valid for serial busses only.
 
 
 Example
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html